Re: [PATCH] drm/amd/display: Align num_crtc to max_streams

2023-02-07 Thread Yin, Tianci (Rico)
pes and adev->pageflip_irq.num_types. I have made a new patch with title "drm/amd/display: fix dm irq error message in gpu recover", please help to review. Regards, Rico From: Wentland, Harry Sent: Wednesday, February 8, 2023 0:19 To: Mahfooz, Hamza ; Yin,

RE: [PATCH] drm/amd/display: Disable migration to ensure consistency of per-CPU variable

2023-02-06 Thread Yin, Tianci (Rico)
desktop.org> Cc: Wentland, Harry<mailto:harry.wentl...@amd.com>; Siqueira, Rodrigo<mailto:rodrigo.sique...@amd.com>; Pillai, Aurabindo<mailto:aurabindo.pil...@amd.com>; Yin, Tianci (Rico)<mailto:tianci@amd.com> Subject: [PATCH] drm/amd/display: Disable migration

Re: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0

2022-03-27 Thread Yin, Tianci (Rico)
[AMD Official Use Only] Thank you very much for your suggestion, but I have already submitted. Regards, Rico From: Chen, Guchun Sent: Monday, March 28, 2022 10:17 To: Chen, Guchun ; Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Wang, Yu (Charlie

Re: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0

2022-03-27 Thread Yin, Tianci (Rico)
[AMD Official Use Only] Thank you James! Rico From: Zhu, James Sent: Sunday, March 27, 2022 21:47 To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Chen, Guchun ; Wang, Yu (Charlie) Subject: Re: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0 [AMD

Re: [PATCH] drm/amdgpu/vcn: fix vcn ring test failure in igt reload test

2022-03-15 Thread Yin, Tianci (Rico)
[AMD Official Use Only] Thank you for reviewing James! Regards, Rico From: Zhu, James Sent: Tuesday, March 15, 2022 20:01 To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Chen, Guchun ; Zhu, James ; Wang, Yu (Charlie) Subject: Re: [PATCH] drm

Re: [PATCH] drm/amd: fix gfx hang on renoir in IGT reload test

2022-03-10 Thread Yin, Tianci (Rico)
[AMD Official Use Only] Thank you very much Alex! Regards, Rico From: Alex Deucher Sent: Friday, March 11, 2022 0:52 To: Yin, Tianci (Rico) Cc: amd-gfx list ; Chen, Guchun ; Zhuo, Qingqing (Lillian) ; Liu, Wenjing ; Wang, Yu (Charlie) ; Deucher, Alexander

Re: [PATCH] drm/amd/display: fix dp kvm can't light up

2022-03-08 Thread Yin, Tianci (Rico)
[AMD Official Use Only] Thank you very much Harry! Regards, Rico From: Wentland, Harry Sent: Tuesday, March 8, 2022 21:55 To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Wang, Yu (Charlie) ; Zhuo, Qingqing (Lillian) ; Liu, Wenjing ; Chen, Guchun

Re: [PATCH] drm/amdgpu: Fix an error message in rmmod

2022-01-27 Thread Yin, Tianci (Rico)
ent: Thursday, January 27, 2022 23:28 To: Yin, Tianci (Rico) ; Wang, Yang(Kevin) ; amd-gfx@lists.freedesktop.org Cc: Grodzovsky, Andrey ; Chen, Guchun Subject: Re: [PATCH] drm/amdgpu: Fix an error message in rmmod The hang you're seeing is the result of a command submission of an UNMAP_QUE

Re: [PATCH] drm/amdgpu: Fix an error message in rmmod

2022-01-26 Thread Yin, Tianci (Rico)
ueue request is not thru a cmd on a ring, it directly writes CP registers, so GFX core remains in gfxoff. Thanks, Rico From: Kuehling, Felix Sent: Wednesday, January 26, 2022 23:08 To: Yin, Tianci (Rico) ; Wang, Yang(Kevin) ; amd-gfx@lists.freedesktop.org Cc

Re: [PATCH] drm/amdgpu: Fix an error message in rmmod

2022-01-25 Thread Yin, Tianci (Rico)
again! Rico From: Kuehling, Felix Sent: Tuesday, January 25, 2022 23:31 To: Wang, Yang(Kevin) ; Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Grodzovsky, Andrey ; Chen, Guchun Subject: Re: [PATCH] drm/amdgpu: Fix an error message in rmmod I have

Re: [PATCH] drm/amdgpu: enable DCN for navi10 headless SKU

2020-11-08 Thread Yin, Tianci (Rico)
[AMD Public Use] Thanks very much Alex and Guchun! From: Chen, Guchun Sent: Sunday, November 8, 2020 21:42 To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Long, Gang ; Xu, Feifei ; Yin, Tianci (Rico) ; Tuikov, Luben ; Deucher, Alexander ; Cui

Re: [PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headless SKU

2020-11-04 Thread Yin, Tianci (Rico)
! Rico From: Deucher, Alexander Sent: Tuesday, November 3, 2020 22:19 To: Yin, Tianci (Rico) ; Alex Deucher Cc: Zhang, Hawking ; amd-gfx@lists.freedesktop.org ; Cui, Flora ; Xu, Feifei ; Tuikov, Luben ; Chen, Guchun ; Long, Gang Subject: Re: [PATCH] drm/amdgpu: fix NULL pointer

Re: [PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headless SKU

2020-11-02 Thread Yin, Tianci (Rico)
Sent: Tuesday, November 3, 2020 1:49 To: Deucher, Alexander Cc: Yin, Tianci (Rico) ; Zhang, Hawking ; amd-gfx@lists.freedesktop.org ; Cui, Flora ; Xu, Feifei ; Tuikov, Luben ; Chen, Guchun ; Long, Gang Subject: Re: [PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headless SKU Does

Re: [PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headless SKU

2020-11-01 Thread Yin, Tianci (Rico)
ang, Hawking ; Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Tuikov, Luben ; Chen, Guchun ; Cui, Flora ; Xu, Feifei ; Long, Gang Subject: Re: [PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headless SKU [AMD Public Use] Maybe it would be easier to check if the DCE IP exists?

Re: [PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headless SKU

2020-10-30 Thread Yin, Tianci (Rico)
(adev)) drm_helper_hpd_irq_event(dev); //right path for headless SKU else drm_kms_helper_hotplug_event(dev); //wrong path for headless SKU ... } Thanks! Rico From: Zhang, Hawking Sent: Friday, October 30, 2020 19:48 To: Yin, Tianci (Rico) ; amd

Re: [PATCH 2/2] drm/amdgpu: disable DCN and VCN for navi10 blockchain SKU(v3)

2020-10-21 Thread Yin, Tianci (Rico)
[AMD Official Use Only - Internal Distribution Only] Thanks very much Alex! From: Alex Deucher Sent: Thursday, October 22, 2020 11:45 To: Yin, Tianci (Rico) Cc: amd-gfx list ; Long, Gang ; Chen, Guchun ; Xu, Feifei ; Tuikov, Luben ; Deucher, Alexander ; Cui

Re: [PATCH 2/3] drm/amdgpu: disable DCN for navi10 blockchain SKU

2020-10-21 Thread Yin, Tianci (Rico)
[AMD Official Use Only - Internal Distribution Only] Hi Alex, Sorry, I misunderstand your meaning, I will refine it. Thanks! Rico From: Alex Deucher Sent: Thursday, October 22, 2020 11:16 To: Yin, Tianci (Rico) Cc: amd-gfx list ; Long, Gang ; Chen, Guchun

Re: [PATCH 2/3] drm/amdgpu: disable DCN for navi10 blockchain SKU

2020-10-21 Thread Yin, Tianci (Rico)
[AMD Official Use Only - Internal Distribution Only] Thanks very much Alex and Luben! I refine the patches, please review again. Rico From: Tuikov, Luben Sent: Thursday, October 22, 2020 1:40 To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Deucher

Re: [PATCH 1/3] drm/amdgpu: add DID for navi10 blockchain SKU

2020-10-21 Thread Yin, Tianci (Rico)
[AMD Public Use] Thanks Guchun! From: Chen, Guchun Sent: Wednesday, October 21, 2020 16:01 To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Tuikov, Luben ; Deucher, Alexander ; Zhang, Hawking ; Cui, Flora ; Xu, Feifei ; Long, Gang ; Yin, Tianci

RE: [PATCH] drm/amdgpu: declare ta firmware for navy_flounder

2020-09-16 Thread Yin, Tianci (Rico)
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Tianci Yin -Original Message- From: Jiansong Chen Sent: Wednesday, September 16, 2020 7:34 PM To: amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao ; Yin, Tianci (Rico) ; Chen, Jiansong (Simon) Subject: [PATCH] drm/amdgpu

Re: [PATCH 2/2] drm/amdgpu: reconfigure spm golden settings on Navi1x after GFXOFF exit

2020-07-28 Thread Yin, Tianci (Rico)
[AMD Official Use Only - Internal Distribution Only] Thanks very much Lunben and Guchun! Regards, Rico From: Tuikov, Luben Sent: Wednesday, July 29, 2020 2:44 To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Zhang, Hawking ; Xu

Re: [PATCH 1/2] drm/amdgpu: add interface amdgpu_gfx_init_spm_golden for Navi1x

2020-07-28 Thread Yin, Tianci (Rico)
[AMD Official Use Only - Internal Distribution Only] Thanks very much Luben! Regards, Rico From: Tuikov, Luben Sent: Wednesday, July 29, 2020 2:29 To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Zhang, Hawking ; Xu, Feifei

Re: [PATCH] drm/amdgpu: reconfigure spm golden settings on Navi1x after GFXOFF exit(v2)

2020-07-28 Thread Yin, Tianci (Rico)
:16 To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Tuikov, Luben ; Zhang, Hawking ; Xu, Feifei ; Hesik, Christopher ; Swamy, Manjunatha ; Quan, Evan ; Chen, Guchun ; Feng, Kenneth Subject: Re: [PATCH] drm/amdgpu: reconfigure spm golden settings on Navi1x after GFXOFF exit(v2) [

RE: [PATCH 2/2] drm/amdgpu: reconfigure spm golden settings on Navi1x after GFXOFF exit

2020-07-28 Thread Yin, Tianci (Rico)
Hi Guchun, Since the adev variable invoked a few times, local adev make the code more concise. Thanks! Rico -Original Message- From: Chen, Guchun Sent: Tuesday, July 28, 2020 2:26 PM To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Xu, Feifei ; Yin, Tianci (Rico) ; Tuikov

RE: [PATCH 2/2] drm/amdgpu: reconfigure spm golden settings on Navi1x after GFXOFF exit

2020-07-28 Thread Yin, Tianci (Rico)
[AMD Official Use Only - Internal Distribution Only] Thanks Feifei! Rico -Original Message- From: Xu, Feifei Sent: Tuesday, July 28, 2020 2:21 PM To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Tuikov, Luben ; Deucher, Alexander ; Zhang, Hawking ; Hesik, Christopher

Re: [PATCH] drm/amdgpu: add SPM golden settings for Navi10(v2)

2020-04-06 Thread Yin, Tianci (Rico)
[AMD Official Use Only - Internal Distribution Only] Thanks very much Alex! From: Alex Deucher Sent: Monday, April 6, 2020 22:29 To: Yin, Tianci (Rico) Cc: amd-gfx list ; Deucher, Alexander ; Xu, Feifei ; Zhang, Hawking ; Hesik, Christopher Subject: Re

Re: [PATCH] drm/amdgpu: fix size validation failure in large buffer creation

2020-03-21 Thread Yin, Tianci (Rico)
[AMD Official Use Only - Internal Distribution Only] I see, thanks your explanation. Regards, Rico From: Koenig, Christian Sent: Saturday, March 21, 2020 16:44 To: Yin, Tianci (Rico) Cc: amd-gfx@lists.freedesktop.org ; Xu, Feifei ; Li, Pauline ; Long, Gang

Re: [PATCH] drm/amdgpu: fix size validation failure in large buffer creation

2020-03-21 Thread Yin, Tianci (Rico)
turday, March 21, 2020 2:27 To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Xu, Feifei ; Li, Pauline ; Long, Gang ; Zhang, Hawking Subject: Re: [PATCH] drm/amdgpu: fix size validation failure in large buffer creation Am 20.03.20 um 10:46 schrieb Tianci Yin: > From: "Tianci.

Re: [PATCH] drm/amdgpu: disable 3D pipe 1 on Navi1x

2020-03-02 Thread Yin, Tianci (Rico)
Thanks Feifei and Monk! From: Liu, Monk Sent: Monday, March 2, 2020 17:35 To: Xu, Feifei ; Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Long, Gang ; Li, Pauline ; Yin, Tianci (Rico) ; Gao, Likun ; Zhang, Hawking ; Yuan, Xiaojie Subject: RE: [PATCH

Re: [PATCH 1/2] drm/amdgpu: fix VRAM partially encroached issue in GDDR6 memory training(V2)

2020-01-21 Thread Yin, Tianci (Rico)
[AMD Official Use Only - Internal Distribution Only] Thanks very much Christian! From: Koenig, Christian Sent: Tuesday, January 21, 2020 4:52 To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Tuikov, Luben ; Deucher, Alexander ; Zhang, Hawking ; Xu

Re: [PATCH 2/2] drm/amdgpu: fix VRAM partially encroached issue in GDDR6 memory training

2020-01-20 Thread Yin, Tianci (Rico)
[AMD Official Use Only - Internal Distribution Only] Thanks very much Christian! Please review again. Rico From: Christian König Sent: Monday, January 20, 2020 19:58 To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Long, Gang ; Xu, Feifei ; Wang

Re: [PATCH 2/2] drm/amdgpu/gfx10: update gfx golden settings for navi14

2020-01-14 Thread Yin, Tianci (Rico)
[AMD Official Use Only - Internal Distribution Only] Thanks Alex! From: Alex Deucher Sent: Wednesday, January 15, 2020 1:39 To: Yin, Tianci (Rico) Cc: amd-gfx list ; Xu, Feifei ; Zhang, Hawking Subject: Re: [PATCH 2/2] drm/amdgpu/gfx10: update gfx golden

Re: [PATCH] drm/amdgpu: fix modprobe failure of the 2nd GPU when GDDR6 training enabled

2020-01-09 Thread Yin, Tianci (Rico)
From: Christian König Sent: Thursday, January 9, 2020 18:29 To: Yin, Tianci (Rico) ; Alex Deucher Cc: Koenig, Christian ; Long, Gang ; Wang, Kevin(Yang) ; Xu, Feifei ; amd-gfx list ; Tuikov, Luben ; Deucher, Alexander ; Yuan, Xiaojie ; Zhang, Hawking Subject

Re: [PATCH] drm/amdgpu: fix modprobe failure of the 2nd GPU when GDDR6 training enabled

2020-01-08 Thread Yin, Tianci (Rico)
[AMD Official Use Only - Internal Distribution Only] Ok, thanks very much Alex! From: Alex Deucher Sent: Thursday, January 9, 2020 11:12 To: Yin, Tianci (Rico) Cc: Christian König ; Koenig, Christian ; Long, Gang ; Wang, Kevin(Yang) ; Xu, Feifei ; amd-gfx list

Re: [PATCH] drm/amdgpu: fix modprobe failure of the 2nd GPU when GDDR6 training enabled

2020-01-08 Thread Yin, Tianci (Rico)
why, are there some special reasons or just missed by coding? Thanks! Rico From: Christian König Sent: Wednesday, January 8, 2020 23:04 To: Alex Deucher ; Koenig, Christian Cc: Long, Gang ; Wang, Kevin(Yang) ; Xu, Feifei ; Yin, Tianci (Rico) ; amd-gfx list

Re: [PATCH 1/2] drm/amdgpu: update the method to get fb_loc of memory training(V4)

2019-12-22 Thread Yin, Tianci (Rico)
[AMD Official Use Only - Internal Distribution Only] Thank you very much for your review! From: Tuikov, Luben Sent: Saturday, December 21, 2019 5:52 To: Alex Deucher ; Yin, Tianci (Rico) Cc: amd-gfx@lists.freedesktop.org ; Long, Gang ; Xu, Feifei ; Wang, Kevin

Re: [PATCH 1/2] drm/amdgpu: update the method to get fb_loc of memory training(V4)

2019-12-19 Thread Yin, Tianci (Rico)
[AMD Official Use Only - Internal Distribution Only] Hi Luben, May I have your Review-by? Thanks a lot! Rico From: Tuikov, Luben Sent: Friday, December 20, 2019 3:47 To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Koenig, Christian ; Deucher

Re: [PATCH 1/2] drm/amdgpu: update the method to get fb_loc of memory training(V3)

2019-12-19 Thread Yin, Tianci (Rico)
[AMD Official Use Only - Internal Distribution Only] Hi Luben, What a brilliant thought! Concise and easy for eyes! Thanks so much! Rico From: Tuikov, Luben Sent: Thursday, December 19, 2019 11:10 To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc

Re: [PATCH 2/2] drm/amdgpu: remove memory training p2c buffer reservation(V2)

2019-12-18 Thread Yin, Tianci (Rico)
Thanks Xiaojie! From: Yuan, Xiaojie Sent: Thursday, December 19, 2019 11:02 To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Tuikov, Luben ; Koenig, Christian ; Deucher, Alexander ; Zhang, Hawking ; Xu, Feifei ; Long, Gang ; Wang, Kevin(Yang

Re: [PATCH 1/2] drm/amdgpu: update the method to get fb_loc of memory training(V2)

2019-12-18 Thread Yin, Tianci (Rico)
[AMD Official Use Only - Internal Distribution Only] Hi Luben, Thank you very much for your suggestion and detailed explanation! Patch has been refined, please help review. Rico From: Tuikov, Luben Sent: Thursday, December 19, 2019 4:14 To: Yin, Tianci (Rico

Re: [PATCH 1/2] drm/amdgpu: update the method to get fb_loc of memory training(V2)

2019-12-18 Thread Yin, Tianci (Rico)
, Kevin(Yang) ; Yin, Tianci (Rico) Subject: [PATCH 1/2] drm/amdgpu: update the method to get fb_loc of memory training(V2) From: "Tianci.Yin" The method of getting fb_loc changed from parsing VBIOS to taking certain offset from top of VRAM Change-Id: I053b42fdb1d822722fa7980b2cd9f86b3f

Re: [PATCH 2/2] drm/amdgpu: remove memory training p2c buffer reservation(V2)

2019-12-18 Thread Yin, Tianci (Rico)
Thanks Kevin! From: Wang, Kevin(Yang) Sent: Wednesday, December 18, 2019 16:53 To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Tuikov, Luben ; Koenig, Christian ; Deucher, Alexander ; Zhang, Hawking ; Xu, Feifei ; Yuan, Xiaojie ; Long, Gang

Re: [PATCH 1/2] drm/amdgpu: update the method to get fb_loc of memory training

2019-12-18 Thread Yin, Tianci (Rico)
Hi Kevin, Thanks very much! I have rename the amdgpu_atomfirmware_get_mem_train_fb_loc function to amdgpu_atomfirmware_get_mem_train_info, please review again. Rico From: Wang, Kevin(Yang) Sent: Wednesday, December 18, 2019 13:32 To: Yin, Tianci (Rico) ; amd

Re: [PATCH 2/2] drm/amdgpu: remove memory training p2c buffer reservation

2019-12-17 Thread Yin, Tianci (Rico)
Hi Guchun, Thanks very much for your suggestion. I will refine it and send it out later. Rico From: Chen, Guchun Sent: Tuesday, December 17, 2019 22:11 To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Long, Gang ; Yin, Tianci (Rico) ; Xu, Feifei

Re: [PATCH 1/2] drm/amdgpu/gfx10: update gfx golden settings

2019-12-10 Thread Yin, Tianci (Rico)
[AMD Official Use Only - Internal Distribution Only] Thanks Feifei! From: Xu, Feifei Sent: Wednesday, December 11, 2019 11:29 To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Yuan, Xiaojie ; Long, Gang ; Li, Pauline ; Yin, Tianci

Re: amd-gfx Digest, Vol 41, Issue 390

2019-10-30 Thread Yin, Tianci (Rico)
[PATCH] drm/amdgpu/gmc10: properly set BANK_SELECT and FRAGMENT_SIZE Reviewed-by: Tianci Yin From: amd-gfx on behalf of amd-gfx-requ...@lists.freedesktop.org Sent: Wednesday, October 30, 2019 6:01 To: amd-gfx@lists.freedesktop.org Subject: amd-gfx Digest,

Re: [PATCH 2/3] drm/amdgpu/gfx10: update gfx golden settings for navi14

2019-10-24 Thread Yin, Tianci (Rico)
Thanks Feifei! From: Xu, Feifei Sent: Thursday, October 24, 2019 18:12 To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Xiao, Jack ; Yuan, Xiaojie ; Yin, Tianci (Rico) ; Zhang, Hawking Subject: RE: [PATCH 2/3] drm/amdgpu/gfx10: update gfx golden

Re: [PATCH 1/8] drm/amdgpu: update amdgpu_discovery to handle revision

2019-10-15 Thread Yin, Tianci (Rico)
Thanks Luben! Patch 8 v2 has sent out, please review again. From: Tuikov, Luben Sent: Wednesday, October 16, 2019 2:01 To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Koenig, Christian Subject: Re: [PATCH 1/8] drm/amdgpu: update

Re: [PATCH 8/8] drm/amdgpu/psp: add psp memory training implementation

2019-10-15 Thread Yin, Tianci (Rico)
Thanks very much! Please review again. Rico From: Tuikov, Luben Sent: Wednesday, October 16, 2019 1:59 To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Koenig, Christian ; Deucher, Alexander Subject: Re: [PATCH 8/8] drm/amdgpu/psp: add psp memory

Re: [PATCH 7/8] drm/amdgpu: reserve vram for memory training

2019-10-14 Thread Yin, Tianci (Rico)
Thanks very much Christian! Rico From: Koenig, Christian Sent: Monday, October 14, 2019 16:26 To: Tuikov, Luben ; Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: Re: [PATCH 7/8] drm/amdgpu: reserve vram for memory training

Re: [PATCH 7/8] drm/amdgpu: reserve vram for memory training

2019-10-09 Thread Yin, Tianci (Rico)
Oh, I see, I thought we should eliminate warning, but it's a wrong idea, actually we need it. Thanks! Rico From: Christian K?nig Sent: Wednesday, October 9, 2019 19:40 To: Yin, Tianci (Rico) ; Tuikov, Luben ; Alex Deucher ; amd-gfx@lists.freedesktop.org Cc

Re: [PATCH 2/8] drm/amdgpu: add a generic fb accessing helper function

2019-10-09 Thread Yin, Tianci (Rico)
Ok, Thanks for your reviewing! Rico From: Christian K?nig Sent: Wednesday, October 9, 2019 16:25 To: Alex Deucher ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Yin, Tianci (Rico) Subject: Re: [PATCH 2/8] drm/amdgpu: add a generic fb accessing

Recall: [PATCH 7/8] drm/amdgpu: reserve vram for memory training

2019-10-09 Thread Yin, Tianci (Rico)
Yin, Tianci (Rico) would like to recall the message, "[PATCH 7/8] drm/amdgpu: reserve vram for memory training". ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Recall: [PATCH 7/8] drm/amdgpu: reserve vram for memory training

2019-10-09 Thread Yin, Tianci (Rico)
Yin, Tianci (Rico) would like to recall the message, "[PATCH 7/8] drm/amdgpu: reserve vram for memory training". ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH 7/8] drm/amdgpu: reserve vram for memory training

2019-10-09 Thread Yin, Tianci (Rico)
e-initialization can avoid "uninitialized variable", why should we can't pre-initialize? From: Tuikov, Luben Sent: Wednesday, October 9, 2019 11:44 To: Alex Deucher ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Yin, Tianci (Rico) Subje

Re: [PATCH] drm/amdgpu/gfx10: add support for wks firmware loading

2019-09-19 Thread Yin, Tianci (Rico)
Thanks Feifei! From: Xu, Feifei Sent: Thursday, September 19, 2019 14:05 To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Yin, Tianci (Rico) ; Zhang, Hawking Subject: RE: [PATCH] drm/amdgpu/gfx10: add support for wks firmware

Re: [Patch] drm/amdgpu: add navi12 pci id

2019-09-16 Thread Yin, Tianci (Rico)
Thanks Hawking! From: Zhang, Hawking Sent: Tuesday, September 17, 2019 11:02 To: Yin, Tianci (Rico) Cc: amd-gfx@lists.freedesktop.org ; Deucher, Alexander ; Xu, Feifei ; Yuan, Xiaojie ; Xiao, Jack ; Long, Gang Subject: Re: [Patch] drm/amdgpu: add navi12 pci

[Patch] drm/amdgpu: add navi12 pci id

2019-09-16 Thread Yin, Tianci (Rico)
From ec0d4e0069877a5a763972da4393b3c11404108d Mon Sep 17 00:00:00 2001 From: "Tianci.Yin" Date: Tue, 17 Sep 2019 10:35:34 +0800 Subject: [PATCH] drm/amdgpu: add navi12 pci id Add Navi12 PCI id support. Change-Id: Ic4e63f46f6ddf856910018dc3ddc2093d87873d0 Signed-off-by: Tianci.Yin ---

Re: [Patch] drm/amdgpu: fix CPDMA hang in PRT mode for VEGA10

2019-09-10 Thread Yin, Tianci (Rico)
Thanks Tao! From: Zhou1, Tao Sent: Tuesday, September 10, 2019 18:24 To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Xu, Feifei ; Long, Gang Subject: RE: [Patch] drm/amdgpu: fix CPDMA hang in PRT mode for VEGA10 Reviewed-by: Tao

[Patch] drm/amdgpu: fix CPDMA hang in PRT mode for VEGA10

2019-09-10 Thread Yin, Tianci (Rico)
From 3bd277d5c954d1bbcbb0ebec28216c3f23ce8e7d Mon Sep 17 00:00:00 2001 From: "Tianci.Yin" Date: Tue, 10 Sep 2019 16:54:14 +0800 Subject: [PATCH] drm/amdgpu: fix CPDMA hang in PRT mode for VEGA10 add and_mask since the programming logic of golden setting changed Change-Id:

Recall: [Patch] drm/amdgpu: add navi14 PCI ID for WKS SKU Pro-XLM

2019-09-10 Thread Yin, Tianci (Rico)
Yin, Tianci (Rico) would like to recall the message, "[Patch] drm/amdgpu: add navi14 PCI ID for WKS SKU Pro-XLM". ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[Patch] drm/amdgpu: add navi14 PCI ID for WKS SKU Pro-XLM

2019-09-09 Thread Yin, Tianci (Rico)
From 418e6a02650b5e8d89d91b3dcde3d50567133260 Mon Sep 17 00:00:00 2001 From: "Tianci.Yin" Date: Tue, 10 Sep 2019 13:24:05 +0800 Subject: [PATCH] drm/amdgpu: add navi14 PCI ID for WKS SKU Pro-XLM add navi14 PCI ID for work station SKU Pro-XLM Change-Id: I2883fc55a03a598a2b3f89a5c1fa440d0c553ded

Re: [Patch] drm/amdgpu: add navi14 PCI ID for WKS SKU Pro-XLM

2019-09-09 Thread Yin, Tianci (Rico)
Ok, Sorry. From: Yin, Tianci (Rico) Sent: Tuesday, September 10, 2019 13:37 To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Xu, Feifei ; Xiao, Jack ; Zhang, Hawking ; Long, Gang Subject: [Patch] drm/amdgpu: add navi14 PCI ID for WKS SKU Pro-XLM Hi

Recall: [Patch] drm/amdgpu: add navi14 PCI ID for WKS SKU Pro-XLM

2019-09-09 Thread Yin, Tianci (Rico)
Yin, Tianci (Rico) would like to recall the message, "[Patch] drm/amdgpu: add navi14 PCI ID for WKS SKU Pro-XLM". ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[Patch] drm/amdgpu: add navi14 PCI ID for WKS SKU Pro-XLM

2019-09-09 Thread Yin, Tianci (Rico)
Hi, NV14 add a new workstation SKU DID, please help review. http://ontrack-internal.amd.com/browse/SWDEV-202589 Thanks! Rico From 418e6a02650b5e8d89d91b3dcde3d50567133260 Mon Sep 17 00:00:00 2001 From: "Tianci.Yin" Date: Tue, 10 Sep 2019 13:24:05 +0800 Subject: [PATCH] drm/amdgpu: add navi14

Re: [PATCH] drm/amdgpu: add navi14 PCI ID for work station SKU

2019-09-09 Thread Yin, Tianci (Rico)
Thanks Feifei! From: Xu, Feifei Sent: Monday, September 9, 2019 18:43 To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Xiao, Jack ; Yuan, Xiaojie ; Long, Gang Subject: RE: [PATCH] drm/amdgpu: add navi14 PCI ID for work station SKU

[PATCH] drm/amdgpu: add navi14 PCI ID for work station SKU

2019-09-06 Thread Yin, Tianci (Rico)
From 6da2451b1391939cf49518d82d42c4d57b32a571 Mon Sep 17 00:00:00 2001 From: "Tianci.Yin" Date: Thu, 5 Sep 2019 15:28:57 +0800 Subject: [PATCH] drm/amdgpu: add navi14 PCI ID for work station SKU Add the navi14 PCI device id. Change-Id: I96a8c892becaa8dcc7ad59dc80d047d3f755775f Signed-off-by:

Re: [PATCH 2/2] drm/amdgpu: keep the stolen memory in visible vram region

2019-08-29 Thread Yin, Tianci (Rico)
Ok, I'll fix that, thanks! From: Christian König Sent: Thursday, August 29, 2019 15:13 To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Xu, Feifei ; Ma, Le ; Xiao, Jack ; Zhang, Hawking Subject: Re: [PATCH 2/2] drm/amdgpu: keep the stolen memory

Re: [PATCH 1/2] drm/amdgpu/psp: keep TMR in visible vram region for SRIOV

2019-08-28 Thread Yin, Tianci (Rico)
Hi Christian, Thank you very much for your suggestions! A little more improvement have made about the patch1, please review again. BTW, any suggestion about the patch2? Rico From: Christian König Sent: Wednesday, August 28, 2019 21:09 To: Yin, Tianci (Rico

Re: [PATCH] drm/amdgpu/psp: keep TMR in visible vram region for SRIOV

2019-08-28 Thread Yin, Tianci (Rico)
I checked the code, cpu pointer indeed only used for checking. Thanks for your suggestions! From: Koenig, Christian Sent: Wednesday, August 28, 2019 19:08 To: Yin, Tianci (Rico) Cc: amd-gfx@lists.freedesktop.org ; Xu, Feifei ; Ma, Le ; Xiao, Jack ; Zhang

Re: [PATCH] drm/amdgpu/psp: keep TMR in visible vram region for SRIOV

2019-08-28 Thread Yin, Tianci (Rico)
Might be better to use a local variable for the CPU pointer instead of duplicating the calling parameters. Local variable can't be used in cleaner. From: Christian K?nig Sent: Wednesday, August 28, 2019 17:57 To: Yin, Tianci (Rico) ; amd-gfx

Re: [PATCH] drm/amdgpu/psp: keep TMR in visible vram region for SRIOV

2019-08-28 Thread Yin, Tianci (Rico)
Great! That's good idea! Thanks! From: Koenig, Christian Sent: Wednesday, August 28, 2019 18:25 To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Xu, Feifei ; Ma, Le ; Xiao, Jack ; Zhang, Hawking Subject: Re: [PATCH] drm/amdgpu/psp: keep TMR

Re: [PATCH] drm/amdgpu/psp: keep TMR in visible vram region for SRIOV

2019-08-28 Thread Yin, Tianci (Rico)
From: Christian K?nig Sent: Wednesday, August 28, 2019 17:57 To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Xu, Feifei ; Ma, Le ; Xiao, Jack ; Zhang, Hawking Subject: Re: [PATCH] drm/amdgpu/psp: keep TMR in visible vram region for SRIOV Am 28.08.19 um 11:25

Re: [PATCH] drm/amdgpu/psp: move TMR to cpu invisible vram region

2019-08-19 Thread Yin, Tianci (Rico)
Sent: Monday, August 19, 2019 16:07 To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Xiao, Jack ; Yuan, Xiaojie ; Zhang, Hawking Subject: Re: [PATCH] drm/amdgpu/psp: move TMR to cpu invisible vram region Am 19.08.19 um 10:05 schrieb Tianci Yin: > From: "Tianci.Yin" >

Re: [PATCH] drm/amdgpu/psp: move TMR to cpu invisible vram region

2019-08-19 Thread Yin, Tianci (Rico)
Thanks Christian, I'll improve the coding style. From: Christian K?nig Sent: Monday, August 19, 2019 15:39 To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Xiao, Jack ; Yuan, Xiaojie ; Zhang, Hawking Subject: Re: [PATCH] drm/amdgpu/psp: move TMR

Re: [PATCH 2/2] drm/amd/powerplay: update smu11_driver_if_navi10.h

2019-08-08 Thread Yin, Tianci (Rico)
Thanks Hawking! From: Zhang, Hawking Sent: Thursday, August 8, 2019 14:44 To: Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Xiao, Jack ; Wang, Kevin(Yang) ; Yin, Tianci (Rico) ; Quan, Evan ; Yuan, Xiaojie Subject: RE: [PATCH 2/2] drm/amd/powerplay

RE: [PATCH] drm/amdgpu/soc15: fix external_rev_id for navi14

2019-08-05 Thread Yin, Tianci (Rico)
Thanks Hawking, I'll take care of the difference on topic branch and drm-next. -Original Message- From: Zhang, Hawking Sent: Monday, August 5, 2019 5:49 PM To: Zhang, Hawking ; Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Xiao, Jack ; Yin, Tianci (Rico) ; Yuan, Xiaojie

Re: [PATCH] drm/amdgpu/discovery: fix DCE_HWIP mapping error in hw_id_map array

2019-07-11 Thread Yin, Tianci (Rico)
Thanks Feifei and Xiaojie! From: Xu, Feifei Sent: Thursday, July 11, 2019 16:28 To: Yin, Tianci (Rico); amd-gfx@lists.freedesktop.org Cc: Xiao, Jack; Yuan, Xiaojie; Yin, Tianci (Rico); Zhang, Hawking Subject: RE: [PATCH] drm/amdgpu/discovery: fix DCE_HWIP mapping

Re: [PATCH] drm/amd/powerplay: update smu11_driver_if_navi10.h

2019-06-28 Thread Yin, Tianci (Rico)
Thanks Alex! From: Deucher, Alexander Sent: Thursday, June 27, 2019 23:38 To: Yin, Tianci (Rico); amd-gfx@lists.freedesktop.org Cc: Xiao, Jack; Zhang, Hawking Subject: Re: [PATCH] drm/amd/powerplay: update smu11_driver_if_navi10.h Acked-by: Alex Deucher

Re: [PATCH] drm/amdgpu: fix modprobe failure for uvd_4/5/6

2019-06-24 Thread Yin, Tianci (Rico)
Reviewed-by: Tianci Yin From: Hawking Zhang Sent: Monday, June 24, 2019 19:58 To: amd-gfx@lists.freedesktop.org; Deucher, Alexander; Yin, Tianci (Rico) Cc: Zhang, Hawking Subject: [PATCH] drm/amdgpu: fix modprobe failure for uvd_4/5/6 For uvd_4/5/6, amdgpu

答复: [PATCH] drm/amd/powerplay: improve OD code robustness

2018-12-04 Thread Yin, Tianci (Rico)
thanks Rex, done! I only push it to amd-staging-drm-next, is this enough? 发件人: Zhu, Rex 发送时间: 2018年12月4日 17:26:36 收件人: Yin, Tianci (Rico); Zhang, Jerry; Li, Pauline; Teng, Rui; Liang, Prike; Zhu, Changfeng; Wang, Kevin(Yang); amd-gfx@lists.freedesktop.org 主题

答复: [PATCH] drm/amd/powerplay: improve OD code robustness

2018-12-04 Thread Yin, Tianci (Rico)
hi , a lower request system clock may cause gpu hang, add protection code to avoid this kind of issue, pls help to review. thanks! Rico From e8f0a05ae172f6e2988148dc925b0bde9943be9a Mon Sep 17 00:00:00 2001 From: tianci yin Date: Tue, 4 Dec 2018 16:07:18 +0800 Subject: [PATCH]