Thanks guys, note taken.
Andrey
On 06/13/2018 10:01 AM, Christian König wrote:
Am 13.06.2018 um 15:57 schrieb Michel Dänzer:
On 2018-06-13 03:52 PM, Andrey Grodzovsky wrote:
Yea, will take care of this, this particular warning is all over the
place when you compile so I didn't notice my own
Am 13.06.2018 um 15:57 schrieb Michel Dänzer:
On 2018-06-13 03:52 PM, Andrey Grodzovsky wrote:
Yea, will take care of this, this particular warning is all over the
place when you compile so I didn't notice my own among others.
To avoid that problem, I recommend generating documentation first
Hi Andrey,
On 2018-06-12 04:05 PM, Andrey Grodzovsky wrote:
> Add/update function level documentation and add reference to amdgpu_vm.c
> in amdgpu.rst
>
> v2:
> Fix reference in rst file.
> Fix compilation warnings.
> Add space between function names and params list where
> it's missing.
>
>
On 2018-06-13 03:52 PM, Andrey Grodzovsky wrote:
> Yea, will take care of this, this particular warning is all over the
> place when you compile so I didn't notice my own among others.
To avoid that problem, I recommend generating documentation first
without one's patches applied, then (without
Yea, will take care of this, this particular warning is all over the
place when you compile so I didn't notice my own among others.
Andrey
On 06/13/2018 09:48 AM, Michel Dänzer wrote:
Hi Andrey,
On 2018-06-12 04:05 PM, Andrey Grodzovsky wrote:
Add/update function level documentation and
There are multiple occasions of "adev->gmc.visible_vram_size <
adev->gmc.real_vram_size" in amdgpu_cs.c.
It's basically the same check as in amdgpu_vm_is_large_bar().
I suggest to name it something like amdgpu_gmc_vram_full_visible() or
similar since the BAR actually doesn't needs to be large
I didn't find that check in amdgpu_cs.c, can you clarify please ?
Andrey
On 06/12/2018 10:41 AM, Christian König wrote:
Unrelated to this patch, but we should probably move that function
into amdgpu_gmc.h.
There are a couple of more occasions of that check waiting for cleanup
in
Please update the subject line and add a "drm/amdgpu: " prefix.
Am 12.06.2018 um 16:05 schrieb Andrey Grodzovsky:
Add/update function level documentation and add reference to amdgpu_vm.c
in amdgpu.rst
v2:
Fix reference in rst file.
Fix compilation warnings.
Add space between function names and
Add/update function level documentation and add reference to amdgpu_vm.c
in amdgpu.rst
v2:
Fix reference in rst file.
Fix compilation warnings.
Add space between function names and params list where
it's missing.
Signed-off-by: Andrey Grodzovsky
---
Documentation/gpu/amdgpu.rst | 9
