[PATCH 1/2] drm/amd/pp: Fix pp_sclk/mclk_od not work on Vega10

2018-10-31 Thread Rex Zhu
not update dpm table with user's setting. Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 31 ++ 1 file changed, 31 insertions(+) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c

[PATCH 2/2] drm/amd/pp: Print warning if od_sclk/mclk out of range

2018-10-31 Thread Rex Zhu
print warning in dmesg to notify user the setting for sclk_od/mclk_od out of range that vbios can support Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git

Re: [PATCH v4 3/4] drm: Document variable refresh properties

2018-10-31 Thread Kazlauskas, Nicholas
On 10/30/18 11:34 AM, Kazlauskas, Nicholas wrote: > On 10/30/18 5:29 AM, Michel Dänzer wrote: >> On 2018-10-29 7:03 p.m., Ville Syrjälä wrote: >>> On Mon, Oct 29, 2018 at 05:37:49PM +0100, Michel Dänzer wrote: On 2018-10-26 7:59 p.m., Ville Syrjälä wrote: > On Fri, Oct 26, 2018 at

Re: [PATCH] drm/amdgpu: Fix skipping hangged job reset during gpu recover.

2018-10-31 Thread Koenig, Christian
Am 31.10.18 um 15:36 schrieb Andrey Grodzovsky: > Problem: > During GPU recover DAL would hang in > amdgpu_pm_compute_clocks->amdgpu_fence_wait_empty > > Fix: > Turns out there was what looks like a typo introduced by > 3320b8d drm/amdgpu: remove job->ring which caused skipping >

[PATCH 5/6] drm/amdgpu: Add new ring interface ib_preempt

2018-10-31 Thread Rex Zhu
Used to trigger preemtption Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h index a9ddb0d..cdd66a3 100644 ---

[PATCH 1/6] drm/amdgpu: Add fence flag AMDGPU_FENCE_FLAG_CLEAR_PREEMPT

2018-10-31 Thread Rex Zhu
when emit fence with this flag, driver will de-assert IB_PREEMPTION Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h index a4b6eff..a9ddb0d

Re: [PATCH v4 3/4] drm: Document variable refresh properties

2018-10-31 Thread Kazlauskas, Nicholas
On 10/31/18 10:12 AM, Michel Dänzer wrote: > On 2018-10-31 2:38 p.m., Kazlauskas, Nicholas wrote: >> On 10/30/18 11:34 AM, Kazlauskas, Nicholas wrote: >>> On 10/30/18 5:29 AM, Michel Dänzer wrote: On 2018-10-29 7:03 p.m., Ville Syrjälä wrote: > On Mon, Oct 29, 2018 at 05:37:49PM +0100,

Re: [PATCH] drm/amd/powerplay: no MGPU fan boost enablement on DPM disabled

2018-10-31 Thread Alex Deucher
On Wed, Oct 31, 2018 at 2:27 AM Evan Quan wrote: > > As MGPU fan boost feature will be definitely not needed when > DPM is disabled. So, there is no need to error out. > > Change-Id: Ia417ea3082f50a63f94c85d630f591027ff4c39c > Signed-off-by: Evan Quan Reviewed-by: Alex Deucher > --- >

[PATCH 2/6] drm/amdgpu: report more sdma amdgpu_fence_info

2018-10-31 Thread Rex Zhu
This can help checking MCBP feature on sdma. If preemption occurred in the previous IB the address is adjusted by 2 DWs. Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 4/6] drm/amdgpu: Add sdma ib preempt clear when emit fence

2018-10-31 Thread Rex Zhu
need to clear ib preempt in a proper time Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 13 + drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 12 2 files changed, 25 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c

[PATCH 6/6] drm/amdgpu: Implement ib_preemmpt interface for sdma

2018-10-31 Thread Rex Zhu
sdma can be preempted via this interface Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 14 ++ drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 15 +++ 2 files changed, 29 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c

[PATCH 3/6] drm/amdgpu: Add helper function to get sdma index

2018-10-31 Thread Rex Zhu
Get the sdma index from sdma ring Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 16 drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.h | 1 + 2 files changed, 17 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c

[PATCH] drm/amdgpu: Fix skipping hangged job reset during gpu recover.

2018-10-31 Thread Andrey Grodzovsky
Problem: During GPU recover DAL would hang in amdgpu_pm_compute_clocks->amdgpu_fence_wait_empty Fix: Turns out there was what looks like a typo introduced by 3320b8d drm/amdgpu: remove job->ring which caused skipping amdgpu_fence_driver_force_completion for guilty's job fence and so it was never

Re: [PATCH v4 3/4] drm: Document variable refresh properties

2018-10-31 Thread Michel Dänzer
On 2018-10-31 2:38 p.m., Kazlauskas, Nicholas wrote: > On 10/30/18 11:34 AM, Kazlauskas, Nicholas wrote: >> On 10/30/18 5:29 AM, Michel Dänzer wrote: >>> On 2018-10-29 7:03 p.m., Ville Syrjälä wrote: On Mon, Oct 29, 2018 at 05:37:49PM +0100, Michel Dänzer wrote: > On 2018-10-26 7:59 p.m.,

Re: [PATCH v4 3/4] drm: Document variable refresh properties

2018-10-31 Thread Michel Dänzer
On 2018-10-31 3:41 p.m., Kazlauskas, Nicholas wrote: > On 10/31/18 10:12 AM, Michel Dänzer wrote: >> On 2018-10-31 2:38 p.m., Kazlauskas, Nicholas wrote: >>> On 10/30/18 11:34 AM, Kazlauskas, Nicholas wrote: I understand the issue you're describing now. The timestamp is supposed to

Re: [PATCH 2/2] drm/amdgpu: Change pp clock requests to mHz

2018-10-31 Thread Wentland, Harry
On 2018-10-30 3:34 p.m., David Francis wrote: > We were multiplying clock requests by 1000 in amdgpu_dm > and then dividing them by 1000 in powerplay. > > Also, the vega12 code was dividing by 10 when it should have been > multiplying (to convert units of 10kHz to units of kHz). > >

[PATCH libdrm] amdgpu/test: Add illegal register and memory access test.

2018-10-31 Thread Andrey Grodzovsky
Illegal access will cause CP hang followed by job timeout and recovery kicking in. Also, disable the suite for all APU ASICs until GPU reset issues for them will be resolved and GPU reset recovery will be enabled by default. Signed-off-by: Andrey Grodzovsky --- tests/amdgpu/deadlock_tests.c |

Re: [PATCH 3/3] drm/amd:Enable/Disable NBPSTATE on On/OFF of UVD

2018-10-31 Thread Alex Deucher
On Fri, Oct 26, 2018 at 9:46 AM Guttula, Suresh wrote: > > We observe black lines (underflow) on display when playing a > 4K video with UVD. On Disabling Low memory P state this issue is > not seen. > In this patch ,disabling low memory P state only when video > size >= 4k. > Multiple runs of

Re: [PATCH 3/6] drm/amdgpu: Add helper function to get sdma index

2018-10-31 Thread Alex Deucher
On Wed, Oct 31, 2018 at 8:28 AM Rex Zhu wrote: > > Get the sdma index from sdma ring > > Signed-off-by: Rex Zhu > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 16 > drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.h | 1 + > 2 files changed, 17 insertions(+) > > diff --git

Re: [PATCH v4 3/4] drm: Document variable refresh properties

2018-10-31 Thread Kazlauskas, Nicholas
On 10/31/18 12:20 PM, Michel Dänzer wrote: > On 2018-10-31 3:41 p.m., Kazlauskas, Nicholas wrote: >> On 10/31/18 10:12 AM, Michel Dänzer wrote: >>> On 2018-10-31 2:38 p.m., Kazlauskas, Nicholas wrote: On 10/30/18 11:34 AM, Kazlauskas, Nicholas wrote: > > I understand the issue you're

Re: [PATCH 2/2] drm/amdgpu: Change pp clock requests to mHz

2018-10-31 Thread Wentland, Harry
On 2018-10-30 3:34 p.m., David Francis wrote: > We were multiplying clock requests by 1000 in amdgpu_dm > and then dividing them by 1000 in powerplay. > > Also, the vega12 code was dividing by 10 when it should have been > multiplying (to convert units of 10kHz to units of kHz). > >

Re: [PATCH 2/2] drm/amd/display: Drop reusing drm connector for MST

2018-10-31 Thread Wentland, Harry
On 2018-10-30 6:09 p.m., Jerry (Fangzhi) Zuo wrote: > [why] > It is not safe to keep existing connector while entire topology > has been removed. Could lead potential impact to uapi. > Entirely unregister all the connectors on the topology, > and use a new set of connectors when the topology is

Re: [PATCH libdrm 1/2] amdgpu: prevent an integer wraparound of cpu_map_count

2018-10-31 Thread Marek Olšák
On Wed, Oct 31, 2018 at 3:59 AM Koenig, Christian wrote: > Am 30.10.18 um 16:59 schrieb Michel Dänzer: > > On 2018-10-30 4:52 p.m., Marek Olšák wrote: > >> On Tue, Oct 30, 2018, 11:49 AM Marek Olšák wrote: > >>> On Tue, Oct 30, 2018, 4:20 AM Michel Dänzer > wrote: > >>> > On 2018-10-29

Re: [PATCH libdrm] amdgpu/test: Add illegal register and memory access test.

2018-10-31 Thread Alex Deucher
On Wed, Oct 31, 2018 at 2:33 PM Andrey Grodzovsky wrote: > > Illegal access will cause CP hang followed by job timeout and > recovery kicking in. > Also, disable the suite for all APU ASICs until GPU > reset issues for them will be resolved and GPU reset recovery > will be enabled by default. > >

Re: [PATCH libdrm] amdgpu/test: Add illegal register and memory access test.

2018-10-31 Thread Grodzovsky, Andrey
On 10/31/2018 03:49 PM, Alex Deucher wrote: > On Wed, Oct 31, 2018 at 2:33 PM Andrey Grodzovsky > wrote: >> Illegal access will cause CP hang followed by job timeout and >> recovery kicking in. >> Also, disable the suite for all APU ASICs until GPU >> reset issues for them will be resolved and

Re: [PATCH libdrm] amdgpu/test: Add illegal register and memory access test.

2018-10-31 Thread Grodzovsky, Andrey
On 10/31/2018 03:49 PM, Alex Deucher wrote: > On Wed, Oct 31, 2018 at 2:33 PM Andrey Grodzovsky > wrote: >> Illegal access will cause CP hang followed by job timeout and >> recovery kicking in. >> Also, disable the suite for all APU ASICs until GPU >> reset issues for them will be resolved and

Re: [PATCH libdrm] amdgpu/test: Add illegal register and memory access test.

2018-10-31 Thread Alex Deucher
On Wed, Oct 31, 2018 at 4:05 PM Grodzovsky, Andrey wrote: > > > > On 10/31/2018 03:49 PM, Alex Deucher wrote: > > On Wed, Oct 31, 2018 at 2:33 PM Andrey Grodzovsky > > wrote: > >> Illegal access will cause CP hang followed by job timeout and > >> recovery kicking in. > >> Also, disable the suite

[PATCH 1/2] drm/amdgpu: Refine function name

2018-10-31 Thread Rex Zhu
there is no functional changes.just refine function name to keep consistence with other files. change amdgpu_get_sdma_instance to amdgpu_sdma_get_instance_from_ring. suggested by alex. Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 2 +-

[PATCH 2/2] drm/amdgpu: Add helper function to get sdma index

2018-10-31 Thread Rex Zhu
Get the sdma index from ring v2: refine function name Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 16 drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.h | 1 + 2 files changed, 17 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c

Re: [PATCH libdrm 1/2] amdgpu: prevent an integer wraparound of cpu_map_count

2018-10-31 Thread Koenig, Christian
Am 30.10.18 um 16:59 schrieb Michel Dänzer: > On 2018-10-30 4:52 p.m., Marek Olšák wrote: >> On Tue, Oct 30, 2018, 11:49 AM Marek Olšák wrote: >>> On Tue, Oct 30, 2018, 4:20 AM Michel Dänzer wrote: >>> On 2018-10-29 10:15 p.m., Marek Olšák wrote: > You and I discussed this extensively

Re: [PATCH] drm/amdgpu: fix gfx wptr for sdma v4

2018-10-31 Thread Christian König
Am 31.10.18 um 03:57 schrieb Junwei Zhang: The wptr value will be shitfed when function returns. Remove the redundant shift and clean up. Signed-off-by: Junwei Zhang Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 13 - 1 file changed, 4

[PATCH] drm/amd/powerplay: no MGPU fan boost enablement on DPM disabled

2018-10-31 Thread Evan Quan
As MGPU fan boost feature will be definitely not needed when DPM is disabled. So, there is no need to error out. Change-Id: Ia417ea3082f50a63f94c85d630f591027ff4c39c Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 6 +++--- 1 file changed, 3 insertions(+), 3