On 10/7/21 8:08 AM, Christian König wrote:
Am 06.10.21 um 18:04 schrieb Nirmoy Das:
Unify BO evicting functionality for possible memory
types in amdgpu_ttm.c and remove corresponding function
from amdgpu_object.c.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
On 10/22/21 11:44 AM, Christian König wrote:
Am 22.10.21 um 11:32 schrieb Nirmoy Das:
Do not allow exported amdgpu_gtt_mgr_*() to accept
any ttm_resource_manager pointer. Also there is no need
to force other module to call a ttm function just to
eventually call gtt_mgr functions.
v3: upcast
On 10/22/21 12:54 PM, Nirmoy Das wrote:
Get rid off pin/unpin of gart BO at resume/suspend and
instead pin only once and try to recover gart content
at resume time. This is much more stable in case there
is OOM situation at 2nd call to amdgpu_device_evict_resources()
while evicting GART table
ping.
On 3/17/21 11:52 AM, Nirmoy Das wrote:
Replace GFP_KERNEL with GFP_ATOMIC as dcn20_resource_construct()
can't sleep.
Partially fixes: https://bugzilla.kernel.org/show_bug.cgi?id=212311
as dcn20_resource_construct() also calls into SMU functions which does
mutex_lock().
Signed-o
I tested ./piglit run opengl results/test multiple times. Once I got gfx
time out
error but without kernel freeze. I can't reproduce it any more.
Regards,
Nirmoy
On 3/22/21 2:11 PM, Chen, Guchun wrote:
[AMD Public Use]
Hi Christian,
I will conduct one stress test for this tomorrow.
Tested on Navi1x with "piglit run opengl results/test".
The series is Tested-by: Nirmoy Das from my side.
Curious to know how this holds up against Guchun's Vulkan cts test.
Regards,
Nirmoy
On 3/23/21 3:54 PM, Christian König wrote:
Now that we found the underlying pr
Found the fixes tag for this:
Fixes: f4a5cbdcb1 ("drm/amd/display: hide VGH asic specific structs")
The series is Acked-by: Nirmoy Das
On 3/23/21 6:06 PM, Alex Deucher wrote:
It looks like the SI case was missed. Need to return
the clkmgr struct for SI.
Signed-off-by: Al
Reviewed-by: Nirmoy Das
On 3/25/21 9:53 AM, Bhaskar Chowdhury wrote:
s/acccess/access/
s/inferface/interface/
s/sequnce/sequence/ .two different places.
s/retrive/retrieve/
s/sheduling/scheduling/
s/independant/independent/
s/wether/whether/ ..two different places.
s/emmit/emit/
s
s it possible to load amdgpu on guest without msix ? If so then we need
to probe if msix is enabled.
Nirmoy
+
for (i = 0; i < AMDGPU_IRQ_CLIENTID_MAX; ++i) {
if (!adev->irq.client[i].sources)
continue;
_
On 3/30/21 11:29 AM, Deng, Emily wrote:
[AMD Official Use Only - Internal Distribution Only]
-Original Message-
From: Das, Nirmoy
Sent: Tuesday, March 30, 2021 4:59 PM
To: Deng, Emily ; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: Toggle msix after FLR for sriov
Acked-by: Nirmoy Das
On 3/30/21 11:42 AM, Emily Deng wrote:
From: "Emily.Deng"
For vf assigned to guest VM, after FLR, the msix table will be reset.
As the flr is done on host driver. The qemu and vfio driver don't know
this, and the msix is still enable from qemu and vfio dri
p_blocks[i].version->type == type &&
+ adev->ip_blocks[i].status.valid &&
+ count < AMDGPU_HW_IP_INSTANCE_MAX_COUNT)
+ count++;
+ return count;
+
+}
+
+#ifdef CONFIG_PROC_FS
+void amdgpu_show_fdinfo(struct seq_file
We need this for radeon too.
On 4/7/21 2:00 PM, Christian König wrote:
Am 07.04.21 um 13:35 schrieb xinhui pan:
ttm->num_pages is uint32. Hit overflow when << PAGE_SHIFT directly
Fix: 230c079fd (drm/ttm: make num_pages uint32_t)
Signed-off-by: xinhui pan
---
drivers/gpu/drm/amd/amdgpu/amdg
Both patches are Reviewed-by: Nirmoy Das
On 4/8/21 1:29 PM, Christian König wrote:
No functional changes, just cleaning up some leftovers and improve
documentation.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 173 ++-
1 file changed
On 4/13/21 10:50 PM, Nirmoy Das wrote:
Use bo->tbo.base.size instead of bo->tbo.mem.num_pages << PAGE_SHIFT.
Ignore this please, pressed send-email too quick!
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +-
drivers/gpu/drm/amd/amdgpu/
On 4/14/21 8:52 AM, Christian König wrote:
Am 13.04.21 um 22:57 schrieb Nirmoy Das:
Use bo->tbo.base.size instead of calculating it from num_pages.
Those don't clash with the two I've send out yesterday, don't they?
It does, I didn't check dri-devel's [PAT
: Christian König for the series.
Nirmoy if you are idle again could you give that a testing round? I
don't expect it to cause trouble, just want to double check that we
haven't forgotten taking a lock or stuff like that.
Looks good, Tested-by: Nirmoy Das . One minor typo
below:
Reviewed-by: Nirmoy Das
On 4/16/21 4:37 PM, Lee Jones wrote:
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c:73: warning: expecting prototype for
amdgpu_dummy_page_init(). Prototype was for amdgpu_gart_dummy_page_init()
instead
drivers/gpu/drm
On 4/22/21 9:08 AM, Christian König wrote:
Am 21.04.21 um 18:35 schrieb Nirmoy Das:
Shadow BOs are only needed for vm code so call amdgpu_bo_create_shadow()
directly instead of depending on amdgpu_bo_create().
As far as I can see that won't work correctly.
Now you only create the shado
On 4/22/21 2:48 PM, Christian König wrote:
Am 22.04.21 um 14:35 schrieb Nirmoy Das:
Shadow BOs are only needed for vm code so call amdgpu_bo_create_shadow()
directly instead of depending on amdgpu_bo_create().
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 75
On 4/22/21 3:56 PM, Felix Kuehling wrote:
Am 2021-04-22 um 8:35 a.m. schrieb Nirmoy Das:
Fix vm->is_compute_context initialization in amdgpu_vm_init().
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
d
On 4/23/21 9:55 AM, Christian König wrote:
Am 22.04.21 um 17:40 schrieb Nirmoy Das:
Shadow BOs are only needed for vm code so call amdgpu_bo_create_shadow()
directly instead of depending on amdgpu_bo_create().
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 70
Acked-and-Tested-by: Nirmoy Das
On 4/26/21 10:54 AM, Christian König wrote:
Merge the two loops, loosen the restriction for big allocations.
This reduces the CPU overhead in the good case, but increases
it a bit under memory pressure.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd
Reviewed-by: Nirmoy Das
On 4/26/21 2:13 PM, Colin King wrote:
From: Colin Ian King
There is a spelling mistake in a pr_debug message. Fix it.
Signed-off-by: Colin Ian King
---
drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
On 4/30/21 2:56 PM, Christian König wrote:
Hi,
Am 30.04.21 um 14:52 schrieb Rodrigo Siqueira:
Hi,
On 04/30, Nirmoy Das wrote:
Fixes: 49020fc1f5("drm/amdgpu: cleanup amdgpu_vm_init()")
Just for curiosity, do we need the Fixes tag for this?
It's indeed a bit overkill.
The
Series is Tested-by: Nirmoy Das
On 4/27/21 12:54 PM, Christian König wrote:
Now that we found the underlying problem we can re-apply this patch.
This reverts commit 867fee7f8821ff42e7308088cf0c3450ac49c17c.
v2: rebase on KFD changes
Signed-off-by: Christian König
---
drivers/gpu/drm/amd
Reviewed-by: Nirmoy Das
On 5/13/21 8:41 PM, Alex Deucher wrote:
Remove it.
Fixes: b8d598968950 ("drm/amdgpu: Complete multimedia bandwidth interface")
Signed-off-by: Alex Deucher
Cc: Bokun Zhang
---
drivers/gpu/drm/amd/amdgpu/nv.c | 1 -
1 file changed, 1 deletion(-)
di
Found the commit that removed usages of this function.
Fixes: dfcbe6d5f ("drm/amdgpu: Remove unused function pointers")
On 1/7/22 09:51, Nirmoy Das wrote:
Remove unused amdgpu_amdkfd_get_vram_usage()
CC: felix.kuehl...@amd.com
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/
On 5/19/21 5:14 AM, Huang, Ray wrote:
[Public]
I check the patch (below) to disable compute queues for raven is not
landed into drm-next. So actually all queues are enabled at this
moment. Nirmoy, can we get your confirmation?
I indeed didn't push the commit that disable all but o
this
confusion!
Acked-by: Nirmoy Das
Regards,
Nirmoy
Alex
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 10 +++---
drivers/gpu/drm/amd/amdgpu/soc15.c| 2 --
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
b/drivers/gpu/dr
On 5/21/21 2:58 PM, Christian König wrote:
Am 21.05.21 um 14:45 schrieb Nirmoy Das:
Add has_shadow to identify if a BO is shadowed.
Ok that is not going into the right direction.
I was expecting this :) but wasn't sure how to handle it.
Instead of identifying which BOs have a s
On 5/21/21 3:01 PM, Christian König wrote:
Am 21.05.21 um 14:45 schrieb Nirmoy Das:
Allocate PD/PT entries while allocating VM BOs and use that
instead of allocating those entries separately.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 31
On 5/21/21 4:54 PM, Alex Deucher wrote:
On Fri, May 21, 2021 at 8:46 AM Nirmoy Das wrote:
Add new BO subcalss that will be used by amdgpu vm code.
s/subcalss/subclass/
Thanks, Alex!
Alex
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 32
On 5/24/21 1:52 PM, Shiwu Zhang wrote:
Although the kfd_ioctl_get_dmabuf_info() still fail it will indicate
the caller right metadat_size useful for the same kfd ioctl next time.
v2: free the metadata buffer for sg type when to destroy BOs.
Signed-off-by: Shiwu Zhang
---
drivers/gpu/drm/am
Hi Christian,
On 5/26/21 4:58 PM, Christian König wrote:
Am 26.05.21 um 15:06 schrieb Nirmoy Das:
The subclass, amdgpu_bo_vm is intended for PT/PD BOs which are also
shadowed, so switch to amdgpu_bo_vm BO for PT/PD BOs.
v2: squash three related patches.
Signed-off-by: Nirmoy Das
Acked-by: Nirmoy Das
On 7/31/20 4:43 AM, Evan Quan wrote:
Add Renoir gpu metrics export interface.
V2: use memcpy to make code more compact
Change-Id: Ic83265536eeaa9e458dc395b2be18ea49da4c68a
Signed-off-by: Evan Quan
Reviewed-by: Alex Deucher
---
drivers/gpu/drm/amd/powerplay/inc
Please remove change-Id before pushing.
Acked-by: Nirmoy Das
On 8/5/20 10:41 AM, Dennis Li wrote:
Make sure unlock the mutex when error happen
Signed-off-by: Dennis Li
Change-Id: I6c36a193df5fe70516282d8136b4eadf32d20915
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
b/drivers
Acked-by: Nirmoy Das
On 8/10/20 5:56 PM, Alex Deucher wrote:
This is not longer used as of the latest rework of this
code so drop it to avoid a unused function warning.
Signed-off-by: Alex Deucher
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 18 --
1 file changed
Acked-by: Nirmoy Das for both patches.
On 8/11/20 6:04 PM, Alex Deucher wrote:
When we reset the GPU, note what type of reset will be
used. This makes debugging different reset scenarios
more clear as the driver may use different reset
methods depending on conditions on the system.
Signed
rom that, the series is Acked-by: Nirmoy Das
+
+ return smu_cmn_send_smc_msg_with_param(smu,
+ SMU_MSG_SetMGpuFanBoostLimitRpm,
+ param,
+ NULL);
+}
On 8/12/20 11:19 AM, Emily.Deng wrote:
From: jqdeng
Only for no job running test case need to do recover in
flr notification.
For having job in mirror list, then let guest driver to
hit job timeout, and then do recover.
Signed-off-by: jqdeng
Change-Id: Ic6234fce46fa1655ba81c4149235eeac75e75
On 8/12/20 2:20 PM, Tom St Denis wrote:
Fixes:
CC [M] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_mst_types.o
drivers/gpu/drm/amd/amdgpu/../powerplay/arcturus_ppt.c: In function
‘arcturus_log_thermal_throttling_event’:
drivers/gpu/drm/amd/amdgpu/../powerplay/arcturus_ppt.c:22
future...).
I think caller should initialize the result value before passing it to
arcturus_get_smu_metrics_data
as the warning is generated from the calling function. My comment is
only concerning about setting "value"
to 0, which seems wrong. Rest of the patch is fine.
Nirm
Acked-by: Nirmoy Das for 1st 3 patches. Check for
below for
more comments.
On 8/13/20 11:08 AM, Evan Quan wrote:
As other power interfaces.
Change-Id: I5e3b85ae21c4b1d0239f54fa75247b33cfdb7ddc
Signed-off-by: Evan Quan
---
drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.c | 425
On 8/12/20 4:52 PM, Andrey Grodzovsky wrote:
On 8/11/20 9:30 AM, Nirmoy Das wrote:
This patch will ignore non-fatal errors and try to
stop amdgpu's sw stack on fatal errors.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 56 -
1
On 8/13/20 3:38 PM, Andrey Grodzovsky wrote:
On 8/13/20 7:09 AM, Nirmoy wrote:
On 8/12/20 4:52 PM, Andrey Grodzovsky wrote:
On 8/11/20 9:30 AM, Nirmoy Das wrote:
This patch will ignore non-fatal errors and try to
stop amdgpu's sw stack on fatal errors.
Signed-off-by: Nirmo
On 8/14/20 4:56 AM, Quan, Evan wrote:
[AMD Official Use Only - Internal Distribution Only]
Yes, I would like to make another patch to address Nirmoy's comments.
@Das, Nirmoy is that OK?
Yes.
Nirmoy
BR
Evan
-Original Message-
From: Alex Deucher
Sent: Thursday, August 13,
Reviewed-by: Nirmoy Das
Nirmoy
On 8/14/20 10:43 AM, Evan Quan wrote:
As these are already defined in amdgpu_atombios.h. Otherwise, we may
hit "redefined" compile warning.
Change-Id: Ia2a9e10b35173fedcbbd8e0abb8ad38dd231baf4
Signed-off-by: Evan Quan
---
drivers/gpu/drm/amd/pm
;s too generic a name for this. I'd rather add "pci" in there,
static const struct pci_error_handlers amdgpu_pci_err_handler = {
True, thanks for the name suggestion.
Nirmoy
.element = init,
...
};
Being a singular noun from the outset is good and
Acked-by: Nirmoy Das
On 8/14/20 5:14 PM, Leo Liu wrote:
Fix warning from kernel test robot
v2: remove the local variable as well
Signed-off-by: Leo Liu
Reviewed-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff
Acked-by: Nirmoy Das
On 8/17/20 9:35 AM, Kevin Wang wrote:
fix amdgpu_bo_release_notify() comment error.
Signed-off-by: Kevin Wang
---
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
On 8/18/20 4:48 AM, Deng, Emily wrote:
[AMD Official Use Only - Internal Distribution Only]
-Original Message-
From: Das, Nirmoy
Sent: Wednesday, August 12, 2020 8:18 PM
To: Deng, Emily ; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: Fix repeatly flr issue
On 8/12
Series is Acked-by: Nirmoy Das
On 8/17/20 9:53 PM, Alex Deucher wrote:
We can get this on RENOIR and newer via the SMU metrics
table.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu
With below minor comments fixed, the series is Acked-by: Nirmoy Das
On 8/18/20 11:41 AM, Emily.Deng wrote:
From: jqdeng
Only for no job running test case need to do recover in
flr notification.
For having job in mirror list, then let guest driver to
hit job timeout, and then do recover
Acked-by: Nirmoy Das
On 8/18/20 3:29 PM, Emily.Deng wrote:
From: jqdeng
Only for no job running test case need to do recover in
flr notification.
For having job in mirror list, then let guest driver to
hit job timeout, and then do recover.
Signed-off-by: jqdeng
Change-Id
Acked-by: Nirmoy Das
On 8/18/20 3:43 PM, Deng, Emily wrote:
[AMD Official Use Only - Internal Distribution Only]
[AMD Official Use Only - Internal Distribution Only]
Ping ...
What about this patch.
-Original Message-
From: Emily.Deng
Sent: Tuesday, August 18, 2020 5:42 PM
To: amd
ids are different ? Is it like that, the cpid-2114
process created a page/memory-area and now pid-2128 using that
page/memory-area to submit a command ?
Regards,
Nirmoy
Trace event by default seems to be adding the process name and id at
the header of the event (gnome-shell-2114),
On 8/19/20 2:58 PM, Christian König wrote:
Am 19.08.20 um 14:51 schrieb Shashank Sharma:
On 19/08/20 6:15 pm, Nirmoy wrote:
Hi Christian,
On 8/19/20 2:08 PM, Christian König wrote:
Am 19.08.20 um 13:52 schrieb Shashank Sharma:
On 13/08/20 1:28 pm, Christian König wrote:
Am 13.08.20 um 05
Series is Acked-by: Nirmoy Das
On 8/19/20 11:58 AM, Evan Quan wrote:
Fulfill Navi gfx and pcie settings on umd pstate switching.
V2: temporarily skip the pcie ASPM setting considering the ASPM function
is not fully enabled yet
Change-Id: I8d746d4c25f890665feeffddf64164ed2b1f5ccc
Signed
Series is Acked-by: Nirmoy Das
On 8/24/20 6:15 PM, Alex Deucher wrote:
This allows us to add asic specific workarounds for atom
asic init while keeping the adev specifics out of the
atombios parser code.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 20
On 8/25/20 4:18 PM, Alex Deucher wrote:
virtual display is non-atomic so report false to avoid checking
With below nitpick fixed, Acked-by: Nirmoy Das
virtual --> Virtual
Nirmoy
atomic state and other atomic things at runtime.
v2: squash into the sr-iov check
Signed-off-by: A
ras_features;
+ boolin_dpc;
We should have more generic name instead of "in_dpc", may be
"in_pci_error" ?
Nirmoy
};
static inline struct amdgpu_device *drm_to_adev(struct drm_device *ddev)
diff --git a
Series is Acked-by: Nirmoy Das
On 8/25/20 9:49 AM, Evan Quan wrote:
As these operations are performed in hardware setup and there
is actually no race conditions during this period considering:
1. the hardware setup is serial and cannnot be in parallel
2. all other operations can be performed
= ip_order[i] ||
+ for (j = 0; j < ARRAY_SIZE(ip_order); j++) {
We could probably replace this "for" loop with a big if-statement
if ( block->version->type== AMD_IP_BLOCK_TYPE_GMC ||
block->version->type== AMD_IP_BLOCK_TYPE_COMM
On 8/28/20 3:16 AM, Deng, Emily wrote:
[AMD Official Use Only - Internal Distribution Only]
Hi Nirmoy,
Still think the original logical is more clear.
No problem but we should at least make sure
amdgpu_device_ip_reinit_late_sriov() and
amdgpu_device_ip_reinit_early_sriov()
are
On 8/28/20 8:58 AM, Gu, JiaWei (Will) wrote:
[AMD Official Use Only - Internal Distribution Only]
Hi Nirmoy,
I also found amdgpu_device_ip_reinit_late_sriov() part is missed.
Will push another patch to make them consistent soon.
Thanks, Jiawei.
Nirmoy
Best regards,
Jiawei
it will be not necessary
Hi Monk,
The patch was to fix the previous inconsistent optimization patch.
I don't have a sriov device so definitely wouldn't merge it without a
tested-by tag so I added all relevant people.
Regards,
Nirmoy
_
Monk Li
Hi Alex,
On 8/31/20 4:17 PM, Alex Deucher wrote:
On Mon, Aug 31, 2020 at 6:41 AM Nirmoy Das wrote:
UVD dependent jobs should run on the same udv instance.
This patch disables gpu scheduler's load balancer for
a context which binds jobs from same the context to a udv
instance.
typos
Hi Andrey,
I need to understand more about pci saved state. So excluding patch 5
the series is Acked-by: Nirmoy Das .
Regards,
Nirmoy
On 8/31/20 5:50 PM, Andrey Grodzovsky wrote:
Many PCI bus controllers are able to detect a variety of hardware PCI errors on
the bus,
such as parity
On 9/1/20 9:07 AM, Paul Menzel wrote:
Dear Nirmoy,
Am 31.08.20 um 12:45 schrieb Nirmoy Das:
UVD dependent jobs should run on the same udv instance.
Why? Datasheet? Performance reasons? What happens if they do not run
on the UVD instance? Are there bug reports?
Sorry about that, I
On 9/2/20 8:55 AM, Christian König wrote:
Am 01.09.20 um 21:49 schrieb Nirmoy Das:
This reverts commit e0300ed8820d19fe108006cf1b69fa26f0b4e3fc.
We should also disable load balance for AMDGPU_HW_IP_UVD_ENC jobs.
Well revert and re-apply is usually not the best option. Just provide
a delta
Please ignore this.
On 9/2/20 12:08 PM, Nirmoy Das wrote:
On hardware with multiple uvd instances, dependent uvd_enc jobs
may get scheduled to different uvd instances. Because uvd_enc
jobs retain hw context, dependent jobs should always run on the
same uvd instance. This patch disables GPU
Hi Alex,
If possible, please squash this with:
commit e0300ed8820d19fe108006cf1b69fa26f0b4e3fc
drm/amdgpu: disable gpu-sched load balance for uvd
Regards,
Nirmoy
On 9/2/20 1:07 PM, Christian König wrote:
Am 02.09.20 um 12:15 schrieb Nirmoy Das:
On hardware with multiple uvd instances
LT_ADDR_HI32,
-(u32)((u64)adev->dummy_page_addr >> 44));
+(u32)((u64)adev->dummy_page_addr >> 44));
WREG32_FIELD15(GC, 0, GCVM_L2_PROTECTION_FAULT_CNTL2,
- ACTIVE_PAGE_MIGRATION_PTE_READ_R
ping.
On 9/8/20 5:57 PM, Nirmoy Das wrote:
Fixes: 9a0154630e958a2f (drm/amdgpu: Bring back support for non-upstream
FreeSync)
Signed-off-by: Nirmoy Das
---
include/uapi/drm/amdgpu_drm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/drm/amdgpu_drm.h b
I don't know much about display code but this is
Acked-by: Nirmoy Das as Sonny confirmed that the
revert fixes display corruption.
On 9/11/20 9:35 AM, Christian König wrote:
Ping, we need to revert this ASAP.
Christian.
Am 09.09.20 um 13:16 schrieb Christian König:
Turns out this b
Acked-by: Nirmoy Das
On 9/22/20 5:36 PM, Alex Deucher wrote:
Properly handle clang and older versions of gcc.
Fixes: e77165bf7b02a3 ("drm/amd/display: Add DCN3 blocks to Makefile")
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/display/dc/dcn30/Makefile | 18
Tested-by: Nirmoy Das
On 9/22/20 3:32 PM, Christian König wrote:
Stop using TTM_PL_FLAG_NO_EVICT.
Signed-off-by: Christian König
---
.../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 5 ++-
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c| 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
Tested-by: Nirmoy Das
On 9/22/20 3:32 PM, Christian König wrote:
Stop using TTM_PL_FLAG_NO_EVICT.
Signed-off-by: Christian König
---
.../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 5 ++-
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c| 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
Acked-by: Nirmoy Das
On 9/25/20 4:31 PM, Alex Deucher wrote:
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c: In function ‘amdgpu_ras_fs_init’:
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1284:2: warning: ignoring return value
of ‘sysfs_create_group’, declared with attribute warn_unused_result
[-Wunused
On 9/25/20 7:36 PM, Luben Tuikov wrote:
On 2020-09-25 11:00, Nirmoy wrote:
Acked-by: Nirmoy Das
On 9/25/20 4:31 PM, Alex Deucher wrote:
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c: In function ‘amdgpu_ras_fs_init’:
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1284:2: warning: ignoring return value
Acked-by: Nirmoy Das
On 9/25/20 9:23 PM, Alex Deucher wrote:
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c: In function ‘amdgpu_ras_fs_init’:
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1284:2: warning: ignoring return value
of ‘sysfs_create_group’, declared with attribute warn_unused_result
[-Wunused
Acked-by: Nirmoy Das
On 9/30/20 6:07 AM, Evan Quan wrote:
As the dpm clock table is needed during DC HW initialization.
And that (DC HW initialization) comes before smu_late_init()
where current APU dpm clock table setup is performed. So, NULL
pointer dereference will be triggered. By moving
Acked-by: Nirmoy Das
On 10/6/20 8:05 AM, Shashank Sharma wrote:
This patch adds a return value check and an error message to
highlight the DAC setup failure case during encoder DPMS
operation.
Cc: Alex Deucher
Signed-off-by: Shashank Sharma
---
drivers/gpu/drm/amd/amdgpu
Please do not merge this yet without more debugging.
On 10/9/20 9:55 AM, Liu, Aaron wrote:
[AMD Official Use Only - Approved for External Use]
Acked-by: Aaron Liu
--
Best Regards
Aaron Liu
-Original Message-
From: Zhu, Changfeng
Sent: Friday, October 9, 2020 2:17 PM
To: amd-gfx@list
Please ignore this patch, it didn't workaround the fw bug.
Regards,
Nirmoy
On 10/14/20 3:52 PM, Nirmoy Das wrote:
Because of firmware bug, Raven asics can't handle jobs
scheduled to multiple compute queues. So enable only one
compute queue till we have a firmware fix.
Signed-off-
Acked-by: Nirmoy Das
On 10/14/20 7:55 PM, Alex Deucher wrote:
Fix this to avoid build problems if DRM_AMD_DC_DCN3_02 is defined, but
DRM_AMD_DC_DCN3_01 is not.
Fixes: 36d26912e8d854 ("drm/amd/display: Add support for DCN302 (v2)")
Reported-by: Randy Dunlap
Signed-off-by: Al
On 10/16/20 3:56 PM, Alex Deucher wrote:
On Wed, Oct 14, 2020 at 9:53 AM Nirmoy Das wrote:
Because of firmware bug, Raven asics can't handle jobs
scheduled to multiple compute queues. So enable only one
compute queue till we have a firmware fix.
Signed-off-by: Nirmoy Das
---
driver
Acked-by: Nirmoy Das
On 10/16/20 4:20 PM, Alex Deucher wrote:
Add a helper so we can set per asic default values. Also,
the module parameter is currently clamped to 8, but clamp it
per asic just in case some asics have different limits in the
future. Enable the option on gfx6,7 as well for
On 1/28/21 3:49 PM, Christian König wrote:
Am 28.01.21 um 15:35 schrieb Nirmoy Das:
Enable gfx wave limiting for gfx jobs before pushing high priority
compute jobs so that high priority compute jobs gets more resources
to finish early.
The problem here is what happens if you have multiple
On 1/28/21 4:25 PM, Christian König wrote:
Am 28.01.21 um 16:21 schrieb Nirmoy:
On 1/28/21 3:49 PM, Christian König wrote:
Am 28.01.21 um 15:35 schrieb Nirmoy Das:
Enable gfx wave limiting for gfx jobs before pushing high priority
compute jobs so that high priority compute jobs gets more
On 1/28/21 5:14 PM, Christian König wrote:
Am 28.01.21 um 17:01 schrieb Nirmoy:
On 1/28/21 4:25 PM, Christian König wrote:
Am 28.01.21 um 16:21 schrieb Nirmoy:
On 1/28/21 3:49 PM, Christian König wrote:
Am 28.01.21 um 15:35 schrieb Nirmoy Das:
Enable gfx wave limiting for gfx jobs before
On 2/1/21 1:19 PM, Christian König wrote:
Am 01.02.21 um 13:07 schrieb Nirmoy Das:
Enable gfx wave limiting for gfx jobs before pushing high priority
compute jobs so that high priority compute jobs gets more resources
to finish early.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd
On 2/1/21 4:00 PM, Christian König wrote:
Am 01.02.21 um 15:37 schrieb Nirmoy Das:
Assign correct ring priority.
Fixes: 33abcb1f5a17 ("drm/amdgpu: set compute queue priority at
mqd_init")
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 3 ++-
1 file
On 2/1/21 10:34 PM, Alex Deucher wrote:
On Mon, Feb 1, 2021 at 11:13 AM Christian König
wrote:
Am 01.02.21 um 16:51 schrieb Nirmoy Das:
This patch consist of below related changes:
1 Rename ring->priority to ring->hw_prio.
2 Assign correct hardware ring priority.
3 Remov
Acked-by: Nirmoy Das
On 2/2/21 6:16 PM, Alex Deucher wrote:
Align with Vangogh.
Bug:
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Fdrm%2Famd%2F-%2Fissues%2F1467&data=04%7C01%7Cnirmoy.das%40amd.com%7C58ce04c3aa7c49734cd008d8c79e
On 2/3/21 11:47 AM, Kenneth Feng wrote:
Enable Async DCS
Please expand the commit message, like v1/v2 of this patch.
Regards,
Nirmoy
V3:
1. add the flag to skip APU support.
2. remove the hunk for workload selection since
it doesn't impact the function.
Signed-off-by: Kenneth
On 2/3/21 5:56 PM, Alex Deucher wrote:
On Wed, Feb 3, 2021 at 11:07 AM Nirmoy Das wrote:
To achieve the best QoS for high priority compute jobs it is
required to limit waves on other compute pipes as well.
This patch will set min value in non high priority
mmSPI_WCL_PIPE_PERCENT_CS[0-3
ping.
On 2/3/21 6:11 PM, Nirmoy Das wrote:
To achieve the best QoS for high priority compute jobs it is
required to limit waves on other compute pipes as well.
This patch will set min value in non high priority
mmSPI_WCL_PIPE_PERCENT_CS[0-3] registers to minimize the
impact of normal/low
On 2/10/21 7:22 PM, Christian König wrote:
Am 10.02.21 um 17:06 schrieb Nirmoy Das:
Cleanup unwanted debugfs dentries.
Maybe write unnecessary instead of unwanted.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 ---
drivers/gpu/drm/amd/amdgpu
1 - 100 of 860 matches
Mail list logo
