Re: [Amsn-devel] Nudge plugin patch

2010-02-04 Thread Youness Alaoui
I would vote for 'set file' rather than set dir... + use 'set file [file join [::config::getKey nudgepluginpath] nudge.wav] rather than do a $dir/nudge.wav... and also.. WTF!? the directory is stored in amsn config ???... (I know, it's not your code)!!! config keys should only be used by amsn

Re: [Amsn-devel] Nudge plugin patch

2010-02-04 Thread Alexander Nestorov
Ok, I fixed both things :) Now the plugin isn't setting anything in amsn. I also changed that string range to dirname. -- Alexander Nest nudge_plugin.patch Description: Binary data -- The Planet: dedicated and managed

Re: [Amsn-devel] Nudge plugin patch

2010-02-04 Thread Youness Alaoui
cool, looks good apart from some typos (see below), but I just noticed something in the logic... you use [file exists] to check for whether the file exists or not... but GetSkinFile actually always returns a valid file! If it can't find the file (checks multiple locations), then it will return the