Michael Richardson wrote:
>
> Martin Björklund wrote:
> >> This is important to know, as the intention with the augmentation was
> >> to extend the voucher with additional values as you did in the example
> >> above.
>
> > Ok. Just to be clear; this is not what is defined
Martin Björklund wrote:
>> This is important to know, as the intention with the augmentation was
>> to extend the voucher with additional values as you did in the example
>> above.
> Ok. Just to be clear; this is not what is defined today. In order to
> get this, 8366bis
Martin Björklund wrote:
>> And then Module D wishes to inherit from B and C :-)
> "inherit from" is quite generic; I would need to see a detailed
> example of the definitions you envision in B, C and D to give
> guidelines.
Yes, you are right.
>> In practical terms, this
> > Sent: Mittwoch, 7. Dezember 2022 08:50
> > To: mcr+i...@sandelman.ca
> > Cc: yang-doct...@ietf.org; anima@ietf.org; draft-ietf-anima-brski-
> > prm....@ietf.org
> > Subject: Re: Yangdoctors early review of draft-ietf-anima-brski-prm-05
> >
&
lman.ca
> Cc: yang-doct...@ietf.org; anima@ietf.org; draft-ietf-anima-brski-
> prm@ietf.org
> Subject: Re: Yangdoctors early review of draft-ietf-anima-brski-prm-05
>
> Michael Richardson wrote:
> >
> > Thank you very much for the review.
> >
> > Martin Björ
Michael Richardson wrote:
>
> Thank you very much for the review.
>
> Martin Björklund via Datatracker wrote:
> > From a YANG perspective, this module is quite simple and looks good.
> The only
> > thing you should change is to use sx:structure (from RFC 8791) instead
> of
> >
Thank you very much for the review.
Martin Björklund via Datatracker wrote:
> From a YANG perspective, this module is quite simple and looks good. The
only
> thing you should change is to use sx:structure (from RFC 8791) instead of
> rc:yang-data.
yes, but we need to do this
Reviewer: Martin Björklund
Review result: Ready with Issues
This is my YANG doctor's review of draft-ietf-anima-brski-prm-05.
>From a YANG perspective, this module is quite simple and looks good. The only
thing you should change is to use sx:structure (from RFC 8791) instead of
rc:yang-data.