Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread Tom Jackson
Michael, I have just provided you with information which shows that even this is not functioning correctly. If you have multiple virtual servers, whichever one runs the pools.tcl file last will set the default pool parameters, and there is only one 'default' pool in a single nsd process, no mat

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread dhogaza
> My opinion is that any OTHER pools should be created and managed by > Tcl Modules and or Tcl Packages, not the server config. So backwards compatibility with virtual servers disappears, then. One of the hallmarks of AOLserver has always been ease of configuration. My sense is that we're drifti

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread Michael Andrews
To clarify - The pools.tcl file I wrote serves ONE purpose. To set the "default" pool's params to what is in the server config. This was ONLY done because folks expected the default pool to be set at start up using the config params... as it was in 4.0.10. My opinion is that any OTHER pool

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread Tom Jackson
Dossy, Sounds like a great goal, but there are still other considerations: 1. Even if the server tunes itself, it needs to start somewhere 2. Hard coding defaults already makes it difficult to figure out what the settings are because usually the programmers don't update the config 'data structu

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread Dossy Shiobara
On 2007.08.01, Michael Andrews <[EMAIL PROTECTED]> wrote: > I guess adding the ability to manage pools from the config does not > take anything away from the ability ALSO manage pools from a package/ > module. Gives folks a choice. One of the ideas for AOLserver 5.0 is to eliminate most of the

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread Tom Jackson
Michael, There seems to be more serious issues which need to be addressed (hopefully I am wrong): 1. how can you verify how a pool is mapped, and if it is really being used? 2. if you have multiple virtual servers, it appears that the last one loaded overwrites the values of previous servers.

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread Michael Andrews
I guess adding the ability to manage pools from the config does not take anything away from the ability ALSO manage pools from a package/ module. Gives folks a choice. M On Aug 1, 2007, at 6:24 PM, Michael Andrews wrote: Tom - I'll take a look at the code in more detail this week. Here

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread Michael Andrews
Tom - I'll take a look at the code in more detail this week. Here are my initial thoughts: One of the benefits of having a Tcl command to manage pools is that you do not need to use the server config. A Tcl module or package can 1) create a pool, 2) register the pool, and 3) throttle the

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread Michael Andrews
I see your point, and considering the misunderstanding of all this, it might be best to explicitly log it so folks can see what the default pool is set to at start up. I have made the change and committed. M On Aug 1, 2007, at 5:48 PM, Tom Jackson wrote: Michael, One other change I made

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread Tom Jackson
Michael, One other change I made in your initial file was to use an ns_log Notice instead of ns_log Debug. The reason is because this is configuration information which only gets printed on startup, although since it is default behavior it would only help identify servers that are not running w

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread Tom Jackson
I've just confirmed maxconnections from an old config file, although I guess the real answer would be in the C code. Are you going to commit my additions to the file? tom jackson On Wednesday 01 August 2007 14:21, Michael Andrews wrote: > I'll install 4.0.10 this week, confirm the param, and c

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread Michael Andrews
I have also updated the base.tcl so maxconns is now maxconnections to be backward compatible with 4.0.x. M On Aug 1, 2007, at 5:28 PM, Michael Andrews wrote: I just confirmed it. It was maxconnections. the base.tcl file that comes with 4.5 was wrong. I have made the change to pools.tcl

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread Michael Andrews
I just confirmed it. It was maxconnections. the base.tcl file that comes with 4.5 was wrong. I have made the change to pools.tcl and committed. Michael On Aug 1, 2007, at 5:21 PM, Michael Andrews wrote: I'll install 4.0.10 this week, confirm the param, and change if needed. It is probab

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread Michael Andrews
I'll install 4.0.10 this week, confirm the param, and change if needed. It is probably time to do a better base.tcl (server.cfg) file. I will do that this week too. M On Aug 1, 2007, at 5:15 PM, Michael Andrews wrote: The base.tcl file that comes with AOLserver was using maxconns - but

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread Michael Andrews
The base.tcl file that comes with AOLserver was using maxconns - but - I also saw maxconnections on the AOLserver Site. I went with the base.tcl file. M On Aug 1, 2007, at 4:16 PM, Tom Jackson wrote: I have added additional code for handling the old style (not too old) which allows you to

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread Nathan Folkman
Awesome! Thanks! :) - n On 8/1/07, Tom Jackson <[EMAIL PROTECTED]> wrote: > > I have added additional code for handling the old style (not too old) > which allows you to set up threadpools for specific methods + url > patterns. > > Also, I think there is a bug in the new pools.tcl file. The origi

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread Tom Jackson
I have added additional code for handling the old style (not too old) which allows you to set up threadpools for specific methods + url patterns. Also, I think there is a bug in the new pools.tcl file. The original maxconnections parameter was changed to maxconns, can anyone verify that the old

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread Michael Andrews
see the file modules/tcl/pools.tcl. It has been added to the HEAD. I will let Dossy and Nate decide how this should be tagged. Michael On Aug 1, 2007, at 1:50 PM, Nathan Folkman wrote: Bingo - Michael Andrews just contributed such a script. - n On 8/1/07, Tom Jackson <[EMAIL PROTECTED]>

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread Nathan Folkman
Bingo - Michael Andrews just contributed such a script. - n On 8/1/07, Tom Jackson <[EMAIL PROTECTED]> wrote: > > I would just like to point out that 4.5 was released over one year ago, so > the > cat is already out of the bag. > > But more important: it seems like this is not really a problem. T

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread Rick Cobb
Please accept one apology for this email: my search for "roadmap" was limited to aolserver.com, which does not include the wiki. There was a 4.5 roadmap on the wiki, which is what I was asking for. Unfortunately, the map does not point out the potholes any better than the release notes do. Thank

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread Nathan Folkman
I think we did actually talk about some of the stuff that was coming down the pipe when we used to have those AOLserver chats. Not sure what happened to those. I personally haven't been "officially" assigned to AOLserver support for a while now. - n On 8/1/07, Nathan Folkman <[EMAIL PROTECTED]> w

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread Nathan Folkman
To be honest and blunt, the community process in terms of AOLserver is rather broken, and has been for some time. The 4.5 work was done in-house here at AOL, and with limited community involvement. A lot of the "experimental" features were added to deal with specific scaling challenges we knew we w

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread Tom Jackson
I would just like to point out that 4.5 was released over one year ago, so the cat is already out of the bag. But more important: it seems like this is not really a problem. The old configuration can still be used. All we need is a script which reads the configuration data and runs the new com

[AOLSERVER] New pools.tcl file

2007-08-01 Thread Michael Andrews
I have added a file called "pools.tcl" to the modules/tcl directory. It will set the default pool's params from the server config. It will be sourced @ Start up with the other Tcl files in that directory. This file has been added to the HEAD. For those interested - please look over the fil

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread Rick Cobb
But did the community at large? Were these roadmaps and experiments only discussed internally @ AOL? Again, I want to _encourage_ you guys to make these changes; I just want to know when they're happening and have some idea of why. Thanks -- -- ReC -Original Message- From: AOLserver Disc

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread Rick Cobb
I mostly sympathize with your sentiments. Incompatible changes should be documented. And design documents & directions for AOLServer belong in public on the AOLServer wiki, not hidden. I.e., if when someone decided this was a good idea, there was an "experimental features" page for 4.5 that outli

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread dossy
I'm currently away on vacation this week (in Ocean City, MD) and writing long emails on the Treo isn't exactly fun, so I'll keep this short: 1. It's my fault that 4.5 has the pools/limits functionality. I didn't do a good enough job communicating to everyone about the change. I haven't done a g

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread dhogaza
> The idea of thread pools and allowing the dynamic changing of pool > settings is a great addition to the code base. The failures here > were 1) communication, 2) backward compatibility of the config settings. I have no disagreement with this, at all. > As Nathan and I pointed out - it would no

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread Nathan Folkman
As I said before, if you have issues with the changes made in 4.5, simply do not upgrade. There were a number of factors that led to our decision to release as we did, when we did. Unfortunately a lot of the backwards compatibility work never got completed. Sorry. On 8/1/07, [EMAIL PROTECTED] <[E

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread Michael Andrews
This is a lesson learned. The next release will have better documentation for the community. The idea of thread pools and allowing the dynamic changing of pool settings is a great addition to the code base. The failures here were 1) communication, 2) backward compatibility of the config se

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread Nathan Folkman
Yep, the documentationn or lack there of, continues to dog us. Did you read the release notes at least? It doesn't specifically mention this incompatibility, but does contain a lot of useful information. On 8/1/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > You are absolutely correct. Lack

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread Nathan Folkman
Simple answer - don't upgrade to 4.5. As I was trying to explain before, we knew some things in 4.5 would not be backwards compatible. On 8/1/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > Nathan, > > > > This has to be the most bizzar change to the configuration setup for > > AOLserver, is

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread Nathan Folkman
What about just contributing documentation? What is making that hard? On 8/1/07, Michael Andrews <[EMAIL PROTECTED]> wrote: > > I think lack of process is a big deterrent. How do changes get > rolled into releases, what are the coding standards, is there a > review process, etc. > > > > On Aug 1

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread dhogaza
> Technically everything in the configuration file is a Tcl command > (ns_section, ns_param, etc.) so it's really not that much of a stretch. > But > I agree, it is different. Technically, the configuration file is a bucket of bits, but that's not a very useful observation. > Had we ever actually

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread dhogaza
> I think the best way to manage this change is to run the "ns_pools > set default" command from the init.tcl and use the cfg params. That > makes it backwards compatible. > > If folks agree - I can add that to the head today. Sounds reasonable to this hacker. -- AOLserver - http://www.aolserver

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread dhogaza
> You are absolutely correct. Lack of documentation continues to be one of > the > biggest issues with this project in my opinion. Not sure how best to > resolve > this at this point to be completely honest. Would be a great start if > other > folks would start contributing to the example configura

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread Michael Andrews
I think lack of process is a big deterrent. How do changes get rolled into releases, what are the coding standards, is there a review process, etc. On Aug 1, 2007, at 10:29 AM, Nathan Folkman wrote: You are absolutely correct. Lack of documentation continues to be one of the biggest i

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread dhogaza
> Nathan, > > This has to be the most bizzar change to the configuration setup for > AOLserver, is it really true? Now you have to execute commands inside the > config file to set this? This is absolutely crazy. The init file has never required dynamic execution of procs to work, and to have some

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread Nathan Folkman
Yes and no. ;) Technically everything in the configuration file is a Tcl command (ns_section, ns_param, etc.) so it's really not that much of a stretch. But I agree, it is different. Here's the deal, a decision was made a while back to try some new things with AOLserver 4.5, some of which we knew

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread Michael Andrews
We should stay away from running commands in the cfg - the server has not fully started and the main thread is not initialized yet. I think the best way to manage this change is to run the "ns_pools set default" command from the init.tcl and use the cfg params. That makes it backwards compa

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread Nathan Folkman
You are absolutely correct. Lack of documentation continues to be one of the biggest issues with this project in my opinion. Not sure how best to resolve this at this point to be completely honest. Would be a great start if other folks would start contributing to the example configuration files and

Re: [AOLSERVER] configured minthreads, maxthreads doesnt show up with [ns_server threads] command

2007-08-01 Thread Ian Harding
Better I think to add them (commented out if need be) the default config file that ships with 4.5. I searched the documentation and couldn't find any mention of the new setup (until someone pointed it out) but plenty of talk about the old ones. I think it's in the release notes, but nobody reads