Re: [arch-dev-public] RFC: Dropping -DCMAKE_BUILD_TYPE from packages using cmake

2018-04-12 Thread Baptiste Jonglez
Hi, On 10-03-18, Antonio Rojas via arch-dev-public wrote: > Currently most of our packages which use the cmake build system are built > with -DCMAKE_BUILD_TYPE=Release. This provides a reasonable (according to > upstream) set of C(XX)FLAGS defaults which are appended to and override our >

Re: [arch-dev-public] RFC: Dropping -DCMAKE_BUILD_TYPE from packages using cmake

2018-03-14 Thread Allan McRae via arch-dev-public
On 14/03/18 04:19, Bartłomiej Piotrowski via arch-dev-public wrote: > On 2018-03-13 14:40, Allan McRae via arch-dev-public wrote: >> On 13/03/18 21:22, Jan Alexander Steffens via arch-dev-public wrote: >>> For that matter, I'm all for putting an arch-configure helper into our >>> autoconf package.

Re: [arch-dev-public] RFC: Dropping -DCMAKE_BUILD_TYPE from packages using cmake

2018-03-13 Thread Bartłomiej Piotrowski via arch-dev-public
On 2018-03-13 15:32, Eli Schwartz via arch-dev-public wrote: > This wrapper changes depending on which version of meson you have installed. The wrapper is part of the package that changes. > The fact that autoconf has weird bugs like needing to set localstatedir > and sysconfdir to their

Re: [arch-dev-public] RFC: Dropping -DCMAKE_BUILD_TYPE from packages using cmake

2018-03-13 Thread Bartłomiej Piotrowski via arch-dev-public
On 2018-03-13 14:40, Allan McRae via arch-dev-public wrote: > On 13/03/18 21:22, Jan Alexander Steffens via arch-dev-public wrote: >> For that matter, I'm all for putting an arch-configure helper into our >> autoconf package. > > Don't muck around with vanilla packages. Put it in another package

Re: [arch-dev-public] RFC: Dropping -DCMAKE_BUILD_TYPE from packages using cmake

2018-03-13 Thread Eli Schwartz via arch-dev-public
On 03/13/2018 07:22 AM, Jan Alexander Steffens wrote: > It's not magical. This doesn't even compare to dpkg-buildpackage's hooks > and buildsystem handling, which changes behavior drastically based on > what's installed and what the source tree looks like. > > arch-meson is just a wrapper

Re: [arch-dev-public] RFC: Dropping -DCMAKE_BUILD_TYPE from packages using cmake

2018-03-13 Thread Allan McRae via arch-dev-public
On 13/03/18 21:22, Jan Alexander Steffens via arch-dev-public wrote: > For that matter, I'm all for putting an arch-configure helper into our > autoconf package. Don't muck around with vanilla packages. Put it in another package (devtools). A

Re: [arch-dev-public] RFC: Dropping -DCMAKE_BUILD_TYPE from packages using cmake

2018-03-13 Thread Levente Polyak via arch-dev-public
On March 13, 2018 2:07:31 PM GMT+01:00, Bruno Pagani via arch-dev-public wrote: >Le 13/03/2018 à 13:42, Antonio Rojas via arch-dev-public a écrit : > >> El martes, 13 de marzo de 2018 11:23:07 (CET) Bruno Pagani via >arch-dev-public escribió: >>> Some projects

Re: [arch-dev-public] RFC: Dropping -DCMAKE_BUILD_TYPE from packages using cmake

2018-03-13 Thread Bruno Pagani via arch-dev-public
Le 13/03/2018 à 13:42, Antonio Rojas via arch-dev-public a écrit : > El martes, 13 de marzo de 2018 11:23:07 (CET) Bruno Pagani via > arch-dev-public escribió: >> Some projects seems to default to Debug instead of None… So should we >> specify a BUILD_TYPE of None instead of Release? >> > Not

Re: [arch-dev-public] RFC: Dropping -DCMAKE_BUILD_TYPE from packages using cmake

2018-03-13 Thread Antonio Rojas via arch-dev-public
El martes, 13 de marzo de 2018 11:23:07 (CET) Bruno Pagani via arch-dev-public escribió: > Some projects seems to default to Debug instead of None… So should we > specify a BUILD_TYPE of None instead of Release? > Not sure if it's a good idea to systematically override the build type when it

Re: [arch-dev-public] RFC: Dropping -DCMAKE_BUILD_TYPE from packages using cmake

2018-03-13 Thread Jan Alexander Steffens via arch-dev-public
On Sun, Mar 11, 2018 at 1:43 AM Eli Schwartz via arch-dev-public < arch-dev-public@archlinux.org> wrote: > While we are at it, someone has seen fit to create some arbitrary meson > wrapper called "arch-meson" (note we have never shipped an arch-cmake > nor an arch-configure, nor an arch-setup-py

Re: [arch-dev-public] RFC: Dropping -DCMAKE_BUILD_TYPE from packages using cmake

2018-03-13 Thread Bruno Pagani via arch-dev-public
Le 11/03/2018 à 10:00, Antonio Rojas via arch-dev-public a écrit : > El domingo, 11 de marzo de 2018 1:44:07 (CET) Eli Schwartz via > arch-dev-public escribió: >> This theoretically sounds like a fantastic idea, but I'm not really sure >> what CMake's deal with build flags are in the first

Re: [arch-dev-public] RFC: Dropping -DCMAKE_BUILD_TYPE from packages using cmake

2018-03-11 Thread Antonio Rojas via arch-dev-public
El domingo, 11 de marzo de 2018 21:58:16 (CET) Eli Schwartz via arch-dev-public escribió: > I know repository PKGBUILDs are typically built in a clean chroot, so > cached builds make no difference there, but then neither do unquoted > srcdir/pkgdir. It is still not helpful to people who e.g.

Re: [arch-dev-public] RFC: Dropping -DCMAKE_BUILD_TYPE from packages using cmake

2018-03-11 Thread Eli Schwartz via arch-dev-public
On 03/11/2018 05:00 AM, Antonio Rojas via arch-dev-public wrote: > This is very poorly documented, so you have to dig into the cmake > code to figure it out. The default build type is None, which means > CMAKE_C(XX)_FLAGS is used (see > /usr/share/cmake-3.10/Modules/CMakeCInformation.cmake:117),

Re: [arch-dev-public] RFC: Dropping -DCMAKE_BUILD_TYPE from packages using cmake

2018-03-11 Thread Antonio Rojas via arch-dev-public
El domingo, 11 de marzo de 2018 19:11:13 (CET) Bartłomiej Piotrowski via arch-dev-public escribió: > Sounds good. I'm also surprised that it's how it works, honestly. Are > LDFLAGS taken into account regardless of CMAKE_BUILD_TYPE? Will there a > to do list to track the progress? > Yes, linker

Re: [arch-dev-public] RFC: Dropping -DCMAKE_BUILD_TYPE from packages using cmake

2018-03-11 Thread Bartłomiej Piotrowski via arch-dev-public
On 2018-03-10 11:34, Antonio Rojas via arch-dev-public wrote: > Hi, > Currently most of our packages which use the cmake build system are built > with -DCMAKE_BUILD_TYPE=Release. This provides a reasonable (according to > upstream) set of C(XX)FLAGS defaults which are appended to and override

Re: [arch-dev-public] RFC: Dropping -DCMAKE_BUILD_TYPE from packages using cmake

2018-03-11 Thread Antonio Rojas via arch-dev-public
El domingo, 11 de marzo de 2018 1:44:07 (CET) Eli Schwartz via arch-dev-public escribió: > > This theoretically sounds like a fantastic idea, but I'm not really sure > what CMake's deal with build flags are in the first place. What is the > default build type, and does CMake even look at build

Re: [arch-dev-public] RFC: Dropping -DCMAKE_BUILD_TYPE from packages using cmake

2018-03-11 Thread Antonio Rojas via arch-dev-public
El sábado, 10 de marzo de 2018 14:34:16 (CET) Bruno Pagani via arch-dev-public escribió: > As long as you accept exceptions to this (I have scientific stuff in > mind, like NetCDF — currently not built with CMake but will be in next > release), I’m fine with this. This is just about stopping

Re: [arch-dev-public] RFC: Dropping -DCMAKE_BUILD_TYPE from packages using cmake

2018-03-10 Thread Eli Schwartz via arch-dev-public
On 03/10/2018 05:34 AM, Antonio Rojas via arch-dev-public wrote: > Hi, Currently most of our packages which use the cmake build system > are built with -DCMAKE_BUILD_TYPE=Release. This provides a reasonable > (according to upstream) set of C(XX)FLAGS defaults which are appended > to and override

Re: [arch-dev-public] RFC: Dropping -DCMAKE_BUILD_TYPE from packages using cmake

2018-03-10 Thread Bruno Pagani via arch-dev-public
Le 10/03/2018 à 11:34, Antonio Rojas via arch-dev-public a écrit : > Hi, > Currently most of our packages which use the cmake build system are built > with -DCMAKE_BUILD_TYPE=Release. This provides a reasonable (according to > upstream) set of C(XX)FLAGS defaults which are appended to and

[arch-dev-public] RFC: Dropping -DCMAKE_BUILD_TYPE from packages using cmake

2018-03-10 Thread Antonio Rojas via arch-dev-public
Hi, Currently most of our packages which use the cmake build system are built with -DCMAKE_BUILD_TYPE=Release. This provides a reasonable (according to upstream) set of C(XX)FLAGS defaults which are appended to and override our default C(XX)FLAGS. So, for instance, our cmake packages are being