[Architecture] Updated, simplified PCP API

2017-10-02 Thread Antranig Basman
I've updated my pull request at https://github.com/GPII/universal/pull/549 to incorporate a further 
simplified version of the PCP API, which is more closely focused on the needs of the UI. This now encodes 
the model state corresponding to the settings widgets directly rather than this information being 
synthesized from excerpts of payloads taken around the system. I've updated the PCP API "work in progress" 
Google Doc to describe this API at 
https://docs.google.com/document/d/1c7QWlh-CFmkdERja7m0VRby50rySAkAP9eLGNiSlZGE/edit#
There is another example of a test payload showing an update to an application-scoped setting at 
https://github.com/amb26/universal/blob/dcdd43ff551eac2218f8a7552a0a6c3422be7d79/gpii/node_modules/flowManager/test/PCPChannelTests.js#L32
I had a chat with Georgi this morning who confirmed he thought the new API would be easy to work with. I 
will be working this afternoon for architectural support for
https://issues.gpii.net/browse/GPII-2608 - "Select preference sets" which can be done with the current 
architecture.
Support for https://issues.gpii.net/browse/GPII-2607 will continue after Kaspar returns on Monday - this 
requires some further rework of the core architecture to support the flow of updates to settings propagated 
to the running system. Work can progress on this issue in the meantime by means of mocks and tests.


There will be discussions and updates on these and other PCP related issues at the PCP status meeting which 
is upcoming shortly.


Cheers,

Antranig
___
Architecture mailing list
Architecture@lists.gpii.net
https://lists.gpii.net/mailman/listinfo/architecture


Re: [Architecture] Alternatives to the "marked" markdown renderer...

2017-10-02 Thread Tony Atkins
Hi, All.

I have created pulls against gpii-handlebars
 and infusion-docs
 to migrate to
markdown-it.  Thus far my experience with markdown-it has been pretty
positive, it was basically a drop-in replacement for marked with one minor
configuration change (enabling html, which is disabled by default).

Cheers,


Tony

On 19 September 2017 at 18:47, Tony Atkins  wrote:

> Hi, All:
>
> [I posted this earlier, crossposting as suggested by Justin to include a
> wider audience.]
>
> As you may remember from previous discussions regarding Snyk
> , the largest source of vulnerabilities in the work I
> maintain is the "marked " library, which
> is also used in the Docpad Infusion docs site.   After waiting months for a
> "marked" release that includes the fix for a previous vulnerability, I
> discovered this week that even more vulnerabilities have been reported
> since I last looked.
>
> It seemed like a good time to look around for replacements, I did so and
> wrote up a technology evaluation on the wiki:
>
> http://wiki.gpii.net/w/Technology_Evaluation_-_Rendering_Markdown
>
> Please take a moment to review, especially those of you who regularly
> contribute to the Infusion Docpad docs.  I would like to confirm that the
> list of candidates and requirements is reasonable, and to get feedback on
> my conclusion, which is that "markdown-it" and the associated Docpad plugin
> are our best candidates to replace "marked" at the moment.
>
> Although I will also mention this in the architecture meeting tomorrow and
> ask for feedback there, feedback in the next day or so would be much
> appreciated.  Unless there are strong objections coming out of tomorrow's
> meeting, I plan to work on replacing "marked" in gpii-handlebars by the end
> of the week.
>
> Cheers,
>
>
> Tony
>
>
___
Architecture mailing list
Architecture@lists.gpii.net
https://lists.gpii.net/mailman/listinfo/architecture