Re: [Architecture] [APIM][C5] New API version creation notification email feature - C5 - APIM

2017-08-10 Thread Krishan Wijesena
Hi Chamila, I'll go through that.thanks for the detail. Regards Krishan. On Wed, Aug 9, 2017 at 10:15 AM, Chamila Adhikarinayake wrote: > Hi Krishan, > > There was an intern project done to introduce Event Listeners using > observers to api manager. I think you could re-use

Re: [Architecture] [APIM][C5] New API version creation notification email feature - C5 - APIM

2017-08-08 Thread Chamila Adhikarinayake
Hi Krishan, There was an intern project done to introduce Event Listeners using observers to api manager. I think you could re-use this feature for your implementation as well. There is a simple listener added to log message for api creation (see [1][2]) . You might be able to use the same

Re: [Architecture] [APIM][C5] New API version creation notification email feature - C5 - APIM

2017-08-04 Thread Krishan Wijesena
Hi Ishara, Please find my answers in-line. On Fri, Aug 4, 2017 at 11:35 AM, Ishara Cooray wrote: > Hi Krishan, > > I guess you are planing to add this configuration into deployment.yaml > which is the Global configuration model in C5. > > If that is the case how will it

Re: [Architecture] [APIM][C5] New API version creation notification email feature - C5 - APIM

2017-07-31 Thread Krishan Wijesena
Hi Nuwan, As we discussed in the design review apart from email configuration we need to consider the global configuration model that support other notification mechanisms. And that should be compatible with APIM C5 configurations. *Solotion 1* : Implement String to store the necessary details

Re: [Architecture] [APIM][C5] New API version creation notification email feature - C5 - APIM

2017-07-24 Thread Harsha Kumara
In that case, this should be fine. So we can give an interface which can be extended to support multiple event types. We can have a separate component for this feature which can be reused if needed. On Mon, Jul 24, 2017 at 8:25 AM, Nuwan Dias wrote: > I think we have to focus

Re: [Architecture] [APIM][C5] New API version creation notification email feature - C5 - APIM

2017-07-23 Thread Nuwan Dias
I think we have to focus on simplicity too. I'm guessing that over 95% of users of this feature will opt for email. Using a separate component in this case doesn't give us a huge gain IMO. Bring a separate component will drag along its configuration and other bulk which isn't really useful for us.

Re: [Architecture] [APIM][C5] New API version creation notification email feature - C5 - APIM

2017-07-23 Thread Harsha Kumara
Hi Sam/Krishan, Shouldn't we use event-output adapters to get this work done? So with this, we don't need to worry about different event output types if we reuse the features of it. I'm not sure whether it's moved to C5. Thanks, Harsha On Fri, Jul 21, 2017 at 4:37 AM, Sam Sivayogam

Re: [Architecture] [APIM][C5] New API version creation notification email feature - C5 - APIM

2017-07-20 Thread Sam Sivayogam
Hi Pubudu, There is a Notifier interface so if anyone needs a different type of notification then they can extend that interface and write their own Notifier class and there should be a configuration to set the Notifier class. Thanks, Sam On Fri, Jul 21, 2017 at 1:07 AM, Pubudu Gunatilaka

Re: [Architecture] [APIM][C5] New API version creation notification email feature - C5 - APIM

2017-07-20 Thread Pubudu Gunatilaka
Hi Krishan, Is this notification mechanism restricted to email? Have we considered other notification mechanism? If we can integrate a generic CEP output adapter module which supports email, sms, etc, users will be able to plug any notification mechanism based on their preference. Email

Re: [Architecture] [APIM][C5] New API version creation notification email feature - C5 - APIM

2017-07-20 Thread Jochen Traunecker
Hi, what about supporting webhooks in addition or is this already available? Thanks, Jochen 2017-07-20 9:37 GMT+02:00 Nuwan Dias : > We will need to template the email content and stuff. So we'll need some > sort of a configuration to store the default template and allow users

Re: [Architecture] [APIM][C5] New API version creation notification email feature - C5 - APIM

2017-07-20 Thread Nuwan Dias
We will need to template the email content and stuff. So we'll need some sort of a configuration to store the default template and allow users to change it as needed. On Thu, Jul 20, 2017 at 12:53 PM, Krishan Wijesena wrote: > Hi All, > > An earlier version of APIM had

[Architecture] [APIM][C5] New API version creation notification email feature - C5 - APIM

2017-07-20 Thread Krishan Wijesena
Hi All, An earlier version of APIM had enabled notifications process at the creation of new API versions in order to notify existing subscribers (via email) that a new version of the API is available.now need to implement this feature according to C5 APIM. [image: ] 1.Check whether user