Re: [asterisk-dev] [Code Review] 3476: Memory Pre- and Post-Test Condition

2014-04-25 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3476/#review11739 --- ./asterisk/trunk/lib/python/asterisk/memory_test_condition.py

Re: [asterisk-dev] encoding issues in Asterisk 11.9.0 Now Available

2014-04-25 Thread Walter Doekes
On 23/04/14 18:52, Asterisk Development Team wrote: --===4365525224653466459== Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit ... * ASTERISK-23028 - [patch] Asterisk man pages contains unquoted minus signs (Reported by Jeremy Lainé) ... *

[asterisk-dev] [Code Review] 3477: Japanese language patch for app_voicemail.c and say.c

2014-04-25 Thread Kevin McCoy
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3477/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3443: Japanese language patch for app_voicemail.c and say.c, compatible with newly submitted Japanese sound files

2014-04-25 Thread Kevin McCoy
On April 19, 2014, 4:07 p.m., Matt Jordan wrote: It looks like these patches were merely attached to the review board posting, as opposed to being uploaded using post-review or uploaded directly as a diff. That makes it very hard to review. Please review the instructions for using

Re: [asterisk-dev] [Code Review] 3443: Japanese language patch for app_voicemail.c and say.c, compatible with newly submitted Japanese sound files

2014-04-25 Thread Kevin McCoy
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3443/ --- (Updated April 25, 2014, 10:17 a.m.) Status -- This change has been

[asterisk-dev] [Code Review] 3478: chan_pjsip: Add call pickup support.

2014-04-25 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3478/ --- Review request for Asterisk Developers. Repository: Asterisk

[asterisk-dev] [Code Review] 3479: chan_pjsip: Call pickup test.

2014-04-25 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3479/ --- Review request for Asterisk Developers. Repository: testsuite

[asterisk-dev] Add new option to Queue function

2014-04-25 Thread Nguyen Hoang Son
Hi all, I'm using Queue function of Asterisk to arrange calls which is coming to my agents. I want to customize the way asterisk arrange coming call, in other word, is it possible to create a new option instead of using the existing: RINGALL, ROUNDROBIN,... . For example: The incoming call

Re: [asterisk-dev] encoding issues in Asterisk 11.9.0 Now Available

2014-04-25 Thread Matthew Jordan
On Fri, Apr 25, 2014 at 4:32 AM, Walter Doekes walter+asterisk-...@osso.nl wrote: On 23/04/14 18:52, Asterisk Development Team wrote: --===4365525224653466459== Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit ... * ASTERISK-23028 - [patch] Asterisk

Re: [asterisk-dev] [Code Review] 3478: chan_pjsip: Add call pickup support.

2014-04-25 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3478/#review11741 --- Ship it! /branches/12/res/res_pjsip_session.c

Re: [asterisk-dev] Add new option to Queue function

2014-04-25 Thread jonathan white
Just something I know which may restrict what can be done. Avaya have many patents for call distribution. This includes call distribution to agents who have spent the least amount of time on the phone and taken the lowest number of calls. On 25 Apr 2014 15:00, Nguyen Hoang Son nh...@vasc.com.vn

Re: [asterisk-dev] [Code Review] 3479: chan_pjsip: Call pickup test.

2014-04-25 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3479/#review11742 --- /asterisk/trunk/tests/channels/pjsip/call_pickup/run-test

Re: [asterisk-dev] [Code Review] 3449: Testsuite: PJSIPQualify AMI Action Test

2014-04-25 Thread Scott Emidy
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3449/ --- (Updated April 25, 2014, 9:27 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3457: DISA Test - Invalid Extension

2014-04-25 Thread Benjamin Keith Ford
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3457/ --- (Updated April 25, 2014, 9:32 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3476: Memory Pre- and Post-Test Condition

2014-04-25 Thread Benjamin Keith Ford
On April 24, 2014, 10:46 p.m., Mark Michelson wrote: I suggest writing a sample yaml file that illustrates how this is intended to be used and explains what the default values are for the various configuration options. I'll start working on that. In the mean time, I'm going to go ahead

Re: [asterisk-dev] [Code Review] 3476: Memory Pre- and Post-Test Condition

2014-04-25 Thread Benjamin Keith Ford
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3476/ --- (Updated April 25, 2014, 2:46 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3420: Testsuite: Call Files' Max Retries

2014-04-25 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3420/#review11743 --- ./asterisk/trunk/lib/python/asterisk/pluggable_modules.py

Re: [asterisk-dev] [Code Review] 3476: Memory Pre- and Post-Test Condition

2014-04-25 Thread Benjamin Keith Ford
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3476/ --- (Updated April 25, 2014, 3:41 p.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 3480: chan_pjsip: Implement get_pvt_uniqueid channel technology callback.

2014-04-25 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3480/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3446: Parking: Add 'AnnounceChannel' to Park manager action. Change some announcement behavior for Park manager action.

2014-04-25 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3446/ --- (Updated April 25, 2014, 11:54 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3446: Parking: Add 'AnnounceChannel' to Park manager action. Change some announcement behavior for Park manager action.

2014-04-25 Thread Jonathan Rose
On April 24, 2014, 5:21 p.m., rmudgett wrote: /branches/12/res/parking/parking_manager.c, lines 461-463 https://reviewboard.asterisk.org/r/3446/diff/3/?file=57809#file57809line461 Moving this to where you test bridge_channel for NULL only leaves two places where bridge_channel

Re: [asterisk-dev] [Code Review] 3417: Add AMI events for all device state and presence state changes

2014-04-25 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3417/#review11747 --- Ship it! /trunk/res/res_manager_devicestate.c

Re: [asterisk-dev] [Code Review] 3403: Test for channel Pickup

2014-04-25 Thread Benjamin Keith Ford
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3403/ --- (Updated April 25, 2014, 12:34 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3474: TLS and SRTP status not available in CLI

2014-04-25 Thread Patrick Laimbock
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3474/ --- (Updated April 25, 2014, 5:37 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3337: Code for DTLS retransmission

2014-04-25 Thread Nitesh Bansal
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3337/ --- (Updated April 25, 2014, 12:41 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 1803: P-Asserted-Identity Privacy - fixed behaviour - trust peer

2014-04-25 Thread jamicque
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/1803/ --- (Updated April 25, 2014, 12:48 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3474: TLS and SRTP status not available in CLI

2014-04-25 Thread rmudgett
On April 25, 2014, 1:03 p.m., rmudgett wrote: /branches/11/channels/chan_sip.c, lines 21287-21295 https://reviewboard.asterisk.org/r/3474/diff/3/?file=57909#file57909line21287 These are supposed to be AST_TRANSPORT_xxx declarations. SIP_TRANSPORT_xxx declarations don't exist.

Re: [asterisk-dev] [Code Review] 3471: Filesystem based dynamic MoH classes

2014-04-25 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3471/#review11750 --- While I appreciate the contribution to Asterisk and the

Re: [asterisk-dev] [Code Review] 3474: TLS and SRTP status not available in CLI

2014-04-25 Thread Matt Jordan
On April 25, 2014, 1:03 p.m., rmudgett wrote: /branches/11/channels/chan_sip.c, lines 21287-21295 https://reviewboard.asterisk.org/r/3474/diff/3/?file=57909#file57909line21287 These are supposed to be AST_TRANSPORT_xxx declarations. SIP_TRANSPORT_xxx declarations don't exist.

Re: [asterisk-dev] [Code Review] 3474: TLS and SRTP status not available in CLI

2014-04-25 Thread Olle E Johansson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3474/#review11755 --- Ship it! I think this is a very good addition ready to be

[asterisk-dev] [Code Review] 3481: Websocket: Add locking around session access and modification

2014-04-25 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3481/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23605

Re: [asterisk-dev] [Code Review] 3481: Websocket: Add locking around session access and modification

2014-04-25 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3481/#review11756 --- branches/11/res/res_http_websocket.c

Re: [asterisk-dev] [Code Review] 3480: chan_pjsip: Implement get_pvt_uniqueid channel technology callback.

2014-04-25 Thread Matt Jordan
On April 25, 2014, 12:02 p.m., Matt Jordan wrote: /branches/12/channels/chan_pjsip.c, line 927 https://reviewboard.asterisk.org/r/3480/diff/1/?file=57904#file57904line927 I'm not sure about using threadstorage for this. One of the places that this gets called from is the bridging

[asterisk-dev] Function Read - Timeout

2014-04-25 Thread Jonathan White
Just a quick suggestion to enhance function Read. I am using function read in places to provide options to skip announcements or provide hidden features. However the minimum timeout is 1 second which puts an unnatural pause in the flow of announcements when not skipping. It would be great if

Re: [asterisk-dev] Function Read - Timeout

2014-04-25 Thread Eric Wieling
You're holding it wrong. There are several ways to accomplish this, the easiest is to play all sound files with one Read, like: Read(fwdto,call-fwd-unconditionalplease-enter-thedigits/11digit/igc/sounds/destinationtelephone-number,11,,1,6) If you can't play all the sound files with one Read,

Re: [asterisk-dev] [Code Review] 3428: Testsuite: ARI Playback Tones tests for channels and bridges

2014-04-25 Thread Jonathan Rose
On April 10, 2014, 6:44 a.m., Matt Jordan wrote: /asterisk/trunk/tests/rest_api/bridges/playback/tones/test-config.yaml, line 80 https://reviewboard.asterisk.org/r/3428/diff/1/?file=57149#file57149line80 This is a bridge test, so you need dependencies other than just

Re: [asterisk-dev] [Code Review] 3420: Testsuite: Call Files' Max Retries

2014-04-25 Thread Scott Emidy
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3420/ --- (Updated April 25, 2014, 8:28 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3476: Memory Pre- and Post-Test Condition

2014-04-25 Thread Scott Emidy
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3476/#review11758 --- ./asterisk/trunk/lib/python/asterisk/memory_test_condition.py

Re: [asterisk-dev] [Code Review] 3476: Memory Pre- and Post-Test Condition

2014-04-25 Thread Benjamin Keith Ford
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3476/ --- (Updated April 25, 2014, 8:42 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3428: Testsuite: ARI Playback Tones tests for channels and bridges

2014-04-25 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3428/ --- (Updated April 25, 2014, 4:21 p.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 3482: func_presencestate: Make base64 encoded-ness consistent for consumers of presence state

2014-04-25 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3482/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23671

[asterisk-dev] [Code Review] 3485: pjsip: Fix a bug where transferring to a parking extension causes calls to hang

2014-04-25 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3485/ --- Review request for Asterisk Developers, Matt Jordan and Mark Michelson.

Re: [asterisk-dev] Function Read - Timeout

2014-04-25 Thread Jonathan White
Yes that's a good idea. This fixes one of my issues however it doesn't when I have two reads one after the other. It would still be good if there was a parameter to have no delay. J -Original Message- From: Eric Wieling Sent: Friday, April 25, 2014 8:54 PM To: Jonathan White ;

Re: [asterisk-dev] asterisk-dev Digest, Vol 117, Issue 173

2014-04-25 Thread Nguyen Hoang Son
://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev -- next part -- An HTML attachment was scrubbed... URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20140425