Re: [asterisk-dev] [Code Review] 4541: clang compiler warning: -Wpointer-bool-conversion

> On April 7, 2015, 3:05 a.m., rmudgett wrote: > > /branches/13/apps/app_minivm.c, line 1842 > > > > > > Missing the ! > > > > if (!ast_strlen_zero()) Thanks again for checking my stuff, and sorry for the

Re: [asterisk-dev] [Code Review] 4580: Fix issue with Makefile that prevents use of ~/.asterisk.makeopts and /etc/asterisk.makeopts

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4580/#review15082 --- So, maybe I'm doing this wrong, but... 1) Created .asterisk.ma

Re: [asterisk-dev] [Code Review] 4541: clang compiler warning: -Wpointer-bool-conversion

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4541/ --- (Updated April 7, 2015, 4:23 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4552: clang compiler warning: -Wsometimes-uninitialized

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4552/ --- (Updated April 6, 2015, 9:09 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4551: clang compiler warning: -Wnon-literal-null-conversion

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4551/ --- (Updated April 6, 2015, 8:59 p.m.) Status -- This change has been mar

[asterisk-dev] Change in testsuite[master]: non_stasis_bridge_to_stasis_bridge: Update regex for ami events

Ashley Sanders has posted comments on this change. Change subject: non_stasis_bridge_to_stasis_bridge: Update regex for ami events .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/25 To unsubscribe,

Re: [asterisk-dev] [Code Review] 4541: clang compiler warning: -Wpointer-bool-conversion

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4541/#review15081 --- /branches/13/apps/app_minivm.c

[asterisk-dev] Asterisk 13.2.1 Now Available

The Asterisk Development Team has announced the release of Asterisk 13.2.1. This release is available for immediate download at http://downloads.asterisk.org/pub/telephony/asterisk The release of Asterisk 13.2.1 resolves an issue reported by the community and would have not been possible without y

[asterisk-dev] Asterisk 13.3.1 Now Available

The Asterisk Development Team has announced the release of Asterisk 13.3.1. This release is available for immediate download at http://downloads.asterisk.org/pub/telephony/asterisk The release of Asterisk 13.3.1 resolves an issue reported by the community and would have not been possible without y

[asterisk-dev] Change in testsuite[master]: Testsuite: New test for FAX via PJSIP T38 with authentication

Ashley Sanders has posted comments on this change. Change subject: Testsuite: New test for FAX via PJSIP T38 with authentication .. Patch Set 4: Code-Review+1 Looks good. -- To view, visit https://gerrit.asterisk.org/28 To un

[asterisk-dev] [Code Review] 4597: res_pjsip: add CLI commands for global and system configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4597/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24918 https://i

[asterisk-dev] [Code Review] 4598: Refactor duplicated DNS routines into common sections

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4598/ --- Review request for Asterisk Developers. Repository: Asterisk Description

Re: [asterisk-dev] [Code Review] 4572: RFC: Refactor Qualify and res_pjsip/endpt_send_request

On Mon, Apr 6, 2015 at 3:56 PM, Jean-Denis Girard wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hi, > > Though I'm following ASTERISK-24863, I may have missed something: what > is this change replaced by? > > Oops, I meant to update the ticket. These are the 2 real reviews... htt

Re: [asterisk-dev] [Code Review] 4572: RFC: Refactor Qualify and res_pjsip/endpt_send_request

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, Though I'm following ASTERISK-24863, I may have missed something: what is this change replaced by? Thanks, - -- Jean-Denis Girard SysNuxSystèmes Linux en Polynésie française http://www.sysnux.pf/ Tél: +689 40.50.10.40 /

[asterisk-dev] Change in testsuite[master]: Testsuite: New test for FAX via PJSIP T38 with authentication

Jonathan Rose has uploaded a new patch set (#4). Change subject: Testsuite: New test for FAX via PJSIP T38 with authentication .. Testsuite: New test for FAX via PJSIP T38 with authentication Add a test for PJSIP t38 with authen

[asterisk-dev] Change in testsuite[master]: Testsuite: New test for FAX via PJSIP T38 with authentication

Ashley Sanders has posted comments on this change. Change subject: Testsuite: New test for FAX via PJSIP T38 with authentication .. Patch Set 3: (4 comments) I just found a few minor issues regarding docstrings, but everything

[asterisk-dev] [Code Review] 4596: res_pjsip_phoneprov_provider: Fix leaked OBJ_MULTIPLE iterator (2nd try)

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4596/ --- Review request for Asterisk Developers and Corey Farrell. Bugs: ASTERISK-2

[asterisk-dev] [Code Review] 4595: Voicemail API: fix handling of mailbox full condition

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4595/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24942 https://i

[asterisk-dev] Change in testsuite[master]: Testsuite: New test for FAX via PJSIP T38 with authentication

Jonathan Rose has uploaded a new patch set (#3). Change subject: Testsuite: New test for FAX via PJSIP T38 with authentication .. Testsuite: New test for FAX via PJSIP T38 with authentication Add a test for PJSIP t38 with authen

Re: [asterisk-dev] [Code Review] 4594: Asterisk manager output escape message control characters

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4594/ --- (Updated April 6, 2015, 7:54 p.m.) Review request for Asterisk Developers.

[asterisk-dev] [Code Review] 4594: Asterisk manager output escape message control characters

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4594/ --- Review request for Asterisk Developers. Bugs: asterisk-24937 https://i

Re: [asterisk-dev] [Code Review] 4582: res_pjsip: config option 'timers' can't be set to 'no'

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4582/ --- (Updated April 6, 2015, 2:23 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4581: build: Fixes for gcc 5 compilation

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4581/ --- (Updated April 6, 2015, 1:58 p.m.) Status -- This change has been mar

[asterisk-dev] Change in testsuite[master]: sip_attended_transfer now supports pre-12 Asterisk versions.

Ashley Sanders has posted comments on this change. Change subject: sip_attended_transfer now supports pre-12 Asterisk versions. .. Patch Set 2: (4 comments) A vast improvement over the previous approach. I think this version i

Re: [asterisk-dev] [Code Review] 4581: build: Fixes for gcc 5 compilation

> On April 6, 2015, 11:59 a.m., Matt Jordan wrote: > > branches/11/main/ccss.c, lines 816-818 > > > > > > Shouldn't this be: > > > > if (sscanf(value, "%30u", &value_ast_uint) != 1) { > >... > >

[asterisk-dev] [Code Review] 4592: chan_pjsip: 183 sent when inband_progress=no

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4592/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24835 https://i

Re: [asterisk-dev] [Code Review] 4577: res_pjsip_t38: T38 fax fails when using authentication with PJSIP sender

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4577/ --- (Updated April 6, 2015, 1:16 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4553: clang compiler warning: dev-mode and -Wunused-function

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4553/ --- (Updated April 6, 2015, 1:07 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4529: clang compiler warning: -Wno-sometimes-uninitialized

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4529/ --- (Updated April 6, 2015, 1:03 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 4581: build: Fixes for gcc 5 compilation

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4581/#review15079 --- Ship it! The issue below is minor and can be tweaked on commit

Re: [asterisk-dev] [Code Review] 4576: testsuite: Add PJSIP test for new auto_dtmf option.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4576/#review15078 --- Nice job on the test! Just a few minor documentation findings.

Re: [asterisk-dev] [Code Review] 4540: clang compiler warning: -Wformat

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4540/ --- (Updated April 6, 2015, 12:52 p.m.) Status -- This change has been ma

[asterisk-dev] Change in testsuite[master]: non_stasis_bridge_to_stasis_bridge: Update regex for ami events

Kevin Harwell has uploaded a new patch set (#3). Change subject: non_stasis_bridge_to_stasis_bridge: Update regex for ami events .. non_stasis_bridge_to_stasis_bridge: Update regex for ami events Due to a bug in Asterisk, in som

Re: [asterisk-dev] [Code Review] 4542: DNS: Add NAPTR support and tests

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4542/ --- (Updated April 6, 2015, 12:06 p.m.) Status -- This change has been ma

Re: [asterisk-dev] [Code Review] 4588: IAX make calltoken expiration time configurable

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4588/#review15067 --- trunk/channels/chan_iax2.c

Re: [asterisk-dev] [Code Review] 4577: res_pjsip_t38: T38 fax fails when using authentication with PJSIP sender

> On April 6, 2015, 4:16 p.m., Joshua Colp wrote: > > /certified/branches/13.1/res/res_pjsip_t38.c, lines 493-498 > > > > > > How could this occur? > > Jonathan Rose wrote: > As far as I know, it should never o

[asterisk-dev] Change in testsuite[master]: Add a test for PJSIP t38 with authentication based on normal...

Matt Jordan has posted comments on this change. Change subject: Add a test for PJSIP t38 with authentication based on normal t38 test The test will start two instances of Asterisk. The first will originate a PJSIP call with authentication to the second using an extension that will run sendFax.

Re: [asterisk-dev] [Code Review] 4577: res_pjsip_t38: T38 fax fails when using authentication with PJSIP sender

> On April 6, 2015, 11:16 a.m., Joshua Colp wrote: > > /certified/branches/13.1/res/res_pjsip_t38.c, lines 493-498 > > > > > > How could this occur? As far as I know, it should never occur. I'm probably being paran

[asterisk-dev] Change in testsuite[master]: sip_attended_transfer now supports pre-12 Asterisk versions.

Matt Jordan has posted comments on this change. Change subject: sip_attended_transfer now supports pre-12 Asterisk versions. .. Patch Set 2: (1 comment) While my comment is piddly, I think a little bit more debug logging throw

Re: [asterisk-dev] [Code Review] 4577: res_pjsip_t38: T38 fax fails when using authentication with PJSIP sender

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4577/#review15075 --- /certified/branches/13.1/res/res_pjsip_t38.c

Re: [asterisk-dev] [Code Review] 4577: res_pjsip_t38: T38 fax fails when using authentication with PJSIP sender

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4577/ --- (Updated April 6, 2015, 11:14 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4577: res_pjsip_t38: T38 fax fails when using authentication with PJSIP sender

> On April 6, 2015, 8:59 a.m., Joshua Colp wrote: > > /certified/branches/13.1/res/res_pjsip_t38.c, lines 514-524 > > > > > > You aren't actually using the framehook id for anything. The sheer > > presence of the d

Re: [asterisk-dev] [Code Review] 4589: res_pjsip_t38: Add missing initialization of udptl->far_max_datagram in t38_initialize_session()

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4589/ --- (Updated April 6, 2015, 3:53 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4589: res_pjsip_t38: Add missing initialization of udptl->far_max_datagram in t38_initialize_session()

> On April 6, 2015, 1:24 p.m., Joshua Colp wrote: > > I think the t38_interpret_sdp function should be updated to only set the > > far max datagram if not explicitly configured. Right now it will set it > > again needlessly. > > Juergen Spies wrote: > That is true if we can be sure that t3

Re: [asterisk-dev] [Code Review] 4572: RFC: Refactor Qualify and res_pjsip/endpt_send_request

> On April 6, 2015, 7:52 a.m., Joshua Colp wrote: > > Hey George - is this review useful anymore since you've got the two others? Nope. Will discard. - George --- This is an automatically generated e-mail. To reply, visit: https://revi

Re: [asterisk-dev] [Code Review] 4572: RFC: Refactor Qualify and res_pjsip/endpt_send_request

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4572/ --- (Updated April 6, 2015, 8:46 a.m.) Status -- This change has been dis

Re: [asterisk-dev] [Code Review] 4589: res_pjsip_t38: Add missing initialization of udptl->far_max_datagram in t38_initialize_session()

> On April 6, 2015, 1:24 p.m., Joshua Colp wrote: > > I think the t38_interpret_sdp function should be updated to only set the > > far max datagram if not explicitly configured. Right now it will set it > > again needlessly. That is true if we can be sure that t38_initialize_session() has alwa

Re: [asterisk-dev] [Code Review] 4577: res_pjsip_t38: T38 fax fails when using authentication with PJSIP sender

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4577/#review15069 --- /certified/branches/13.1/res/res_pjsip_t38.c

Re: [asterisk-dev] [Code Review] 4572: RFC: Refactor Qualify and res_pjsip/endpt_send_request

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4572/#review15070 --- Hey George - is this review useful anymore since you've got the

Re: [asterisk-dev] [Code Review] 4575: bridge.c: Hangup attended transfer target after it has been swapped out

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4575/#review15068 --- Ship it! Ship It! - Joshua Colp On April 2, 2015, 7:32 p.m.

Re: [asterisk-dev] [Code Review] 4589: res_pjsip_t38: Add missing initialization of udptl->far_max_datagram in t38_initialize_session()

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4589/#review15066 --- I think the t38_interpret_sdp function should be updated to onl

Re: [asterisk-dev] [Code Review] 4549: ARI: Add the ability to intercept hold and raise an event

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4549/#review15065 --- Ship it! Ship It! - Joshua Colp On April 6, 2015, 2:39 a.m.