[asterisk-dev] Change in testsuite[master]: rest_api/applications/stasisstatus: Make run-test executable

2015-04-09 Thread Ashley Sanders (Code Review)
Ashley Sanders has posted comments on this change. Change subject: rest_api/applications/stasisstatus: Make run-test executable .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/36 To unsubscribe

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

2015-04-08 Thread Ashley Sanders (Code Review)
Gerrit-Branch: master Gerrit-Owner: Ashley Sanders asand...@digium.com Gerrit-Reviewer: Ashley Sanders asand...@digium.com Gerrit-Reviewer: Mark Michelson mmichel...@digium.com Gerrit-Reviewer: Matt Jordan mjor...@digium.com

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

2015-04-08 Thread Ashley Sanders (Code Review)
Ashley Sanders has posted comments on this change. Change subject: stasis: set a channel variable on websocket disconnect error .. Patch Set 5: (6 comments) https://gerrit.asterisk.org/#/c/18/5/tests/rest_api/applications

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

2015-04-08 Thread Ashley Sanders (Code Review)
Ashley Sanders has posted comments on this change. Change subject: stasis: set a channel variable on websocket disconnect error .. Patch Set 5: (1 comment) Gerrit ate this response in my previous draft. :/ https

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

2015-04-08 Thread Ashley Sanders (Code Review)
Ashley Sanders has posted comments on this change. Change subject: stasis: set a channel variable on websocket disconnect error .. Patch Set 6: (1 comment) Just one more finding. https://gerrit.asterisk.org/#/c/18/6/tests

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

2015-04-08 Thread Ashley Sanders (Code Review)
Gerrit-Branch: master Gerrit-Owner: Ashley Sanders asand...@digium.com Gerrit-Reviewer: Ashley Sanders asand...@digium.com Gerrit-Reviewer: Mark Michelson mmichel...@digium.com Gerrit-Reviewer: Matt Jordan mjor...@digium.com

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

2015-04-08 Thread Ashley Sanders (Code Review)
Ashley Sanders has posted comments on this change. Change subject: stasis: set a channel variable on websocket disconnect error .. Patch Set 7: (1 comment) Done =) https://gerrit.asterisk.org/#/c/18/7/tests/rest_api

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

2015-04-08 Thread Ashley Sanders (Code Review)
Ashley Sanders has posted comments on this change. Change subject: stasis: set a channel variable on websocket disconnect error .. Patch Set 5: (3 comments) Found more draft comments that gerrit obscured from me earlier

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

2015-04-08 Thread Ashley Sanders (Code Review)
Ashley Sanders has posted comments on this change. Change subject: stasis: set a channel variable on websocket disconnect error .. Patch Set 7: (1 comment) Ooops. I forgot to remove the chan_sip dependency from the test

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

2015-04-08 Thread Ashley Sanders (Code Review)
Gerrit-Branch: master Gerrit-Owner: Ashley Sanders asand...@digium.com Gerrit-Reviewer: Ashley Sanders asand...@digium.com Gerrit-Reviewer: Mark Michelson mmichel...@digium.com Gerrit-Reviewer: Matt Jordan mjor...@digium.com

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

2015-04-08 Thread Ashley Sanders (Code Review)
Ashley Sanders has posted comments on this change. Change subject: stasis: set a channel variable on websocket disconnect error .. Patch Set 6: (1 comment) https://gerrit.asterisk.org/#/c/18/6/tests/rest_api/applications

[asterisk-dev] Change in testsuite[master]: Enable support for directory containing custom tests.

2015-04-08 Thread Ashley Sanders (Code Review)
Ashley Sanders has posted comments on this change. Change subject: Enable support for directory containing custom tests. .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/27 To unsubscribe, visit

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

2015-04-08 Thread Ashley Sanders (Code Review)
Ashley Sanders has posted comments on this change. Change subject: stasis: set a channel variable on websocket disconnect error .. Patch Set 8: (2 comments) Addressed both of Matt Jordan's review feedback comments. https

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

2015-04-08 Thread Ashley Sanders (Code Review)
: testsuite Gerrit-Branch: master Gerrit-Owner: Ashley Sanders asand...@digium.com Gerrit-Reviewer: Ashley Sanders asand...@digium.com Gerrit-Reviewer: Mark Michelson mmichel...@digium.com Gerrit-Reviewer: Matt Jordan mjor...@digium.com

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

2015-04-08 Thread Ashley Sanders (Code Review)
Ashley Sanders has posted comments on this change. Change subject: stasis: set a channel variable on websocket disconnect error .. Patch Set 9: (1 comment) Found one more tiny issue with the docstrings. https

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

2015-04-08 Thread Ashley Sanders (Code Review)
Gerrit-Branch: master Gerrit-Owner: Ashley Sanders asand...@digium.com Gerrit-Reviewer: Ashley Sanders asand...@digium.com Gerrit-Reviewer: Mark Michelson mmichel...@digium.com Gerrit-Reviewer: Matt Jordan mjor...@digium.com

[asterisk-dev] Change in testsuite[master]: sip_attended_transfer now supports pre-12 Asterisk versions.

2015-04-07 Thread Ashley Sanders (Code Review)
Ashley Sanders has posted comments on this change. Change subject: sip_attended_transfer now supports pre-12 Asterisk versions. .. Patch Set 3: Code-Review+1 (2 comments) https://gerrit.asterisk.org/#/c/29/3/tests/channels

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

2015-04-07 Thread Ashley Sanders (Code Review)
: I0f7dadfd429bd30e9f07a531f47884d8c923fc13 Gerrit-PatchSet: 3 Gerrit-Project: testsuite Gerrit-Branch: master Gerrit-Owner: Ashley Sanders asand...@digium.com Gerrit-Reviewer: Ashley Sanders asand...@digium.com Gerrit-Reviewer: Mark Michelson mmichel...@digium.com Gerrit-Reviewer: Matt Jordan mjor...@digium.com

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

2015-04-07 Thread Ashley Sanders (Code Review)
Ashley Sanders has posted comments on this change. Change subject: stasis: set a channel variable on websocket disconnect error .. Patch Set 2: (5 comments) Addressed Matt Jordan's review feedback. https

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

2015-04-07 Thread Ashley Sanders (Code Review)
: I0f7dadfd429bd30e9f07a531f47884d8c923fc13 Gerrit-PatchSet: 5 Gerrit-Project: testsuite Gerrit-Branch: master Gerrit-Owner: Ashley Sanders asand...@digium.com Gerrit-Reviewer: Ashley Sanders asand...@digium.com Gerrit-Reviewer: Mark Michelson mmichel...@digium.com Gerrit-Reviewer: Matt Jordan mjor...@digium.com

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

2015-04-07 Thread Ashley Sanders (Code Review)
: I0f7dadfd429bd30e9f07a531f47884d8c923fc13 Gerrit-PatchSet: 4 Gerrit-Project: testsuite Gerrit-Branch: master Gerrit-Owner: Ashley Sanders asand...@digium.com Gerrit-Reviewer: Ashley Sanders asand...@digium.com Gerrit-Reviewer: Mark Michelson mmichel...@digium.com Gerrit-Reviewer: Matt Jordan mjor...@digium.com

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

2015-04-07 Thread Ashley Sanders (Code Review)
Ashley Sanders has posted comments on this change. Change subject: stasis: set a channel variable on websocket disconnect error .. Patch Set 5: (1 comment) https://gerrit.asterisk.org/#/c/18/5/tests/rest_api/applications

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

2015-04-07 Thread Ashley Sanders (Code Review)
Ashley Sanders has posted comments on this change. Change subject: stasis: set a channel variable on websocket disconnect error .. Patch Set 2: (5 comments) https://gerrit.asterisk.org/#/c/18/2/tests/rest_api/applications

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

2015-04-07 Thread Ashley Sanders (Code Review)
Ashley Sanders has posted comments on this change. Change subject: stasis: set a channel variable on websocket disconnect error .. Patch Set 1: (1 comment) Addressed Mark Michelson's suggestion for refactoring the self

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

2015-04-07 Thread Ashley Sanders (Code Review)
Ashley Sanders has posted comments on this change. Change subject: stasis: set a channel variable on websocket disconnect error .. Patch Set 5: (5 comments) I found some more minor issues with the review. https

[asterisk-dev] Change in testsuite[master]: Testsuite: New test for FAX via PJSIP T38 with authentication

2015-04-06 Thread Ashley Sanders (Code Review)
Ashley Sanders has posted comments on this change. Change subject: Testsuite: New test for FAX via PJSIP T38 with authentication .. Patch Set 3: (4 comments) I just found a few minor issues regarding docstrings

[asterisk-dev] Change in testsuite[master]: sip_attended_transfer now supports pre-12 Asterisk versions.

2015-04-06 Thread Ashley Sanders (Code Review)
Ashley Sanders has posted comments on this change. Change subject: sip_attended_transfer now supports pre-12 Asterisk versions. .. Patch Set 2: (4 comments) A vast improvement over the previous approach. I think this version

[asterisk-dev] Change in testsuite[master]: Testsuite: New test for FAX via PJSIP T38 with authentication

2015-04-06 Thread Ashley Sanders (Code Review)
Ashley Sanders has posted comments on this change. Change subject: Testsuite: New test for FAX via PJSIP T38 with authentication .. Patch Set 4: Code-Review+1 Looks good. -- To view, visit https://gerrit.asterisk.org/28

[asterisk-dev] Change in testsuite[master]: non_stasis_bridge_to_stasis_bridge: Update regex for ami events

2015-04-06 Thread Ashley Sanders (Code Review)
Ashley Sanders has posted comments on this change. Change subject: non_stasis_bridge_to_stasis_bridge: Update regex for ami events .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/25 To unsubscribe

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

2015-04-03 Thread Ashley Sanders (Code Review)
Ashley Sanders has posted comments on this change. Change subject: stasis: set a channel variable on websocket disconnect error .. Patch Set 2: (1 comment) https://gerrit.asterisk.org/#/c/18/2/tests/rest_api/applications

[asterisk-dev] Change in testsuite[master]: Memory Debugging Improvements

2015-04-02 Thread Ashley Sanders (Code Review)
Ashley Sanders has posted comments on this change. Change subject: Memory Debugging Improvements .. Patch Set 4: Code-Review+1 From what I can tell, everything looks good to me. -- To view, visit https://gerrit.asterisk.org

[asterisk-dev] Change in testsuite[master]: non_stasis_bridge_to_stasis_bridge: Update regex for ami events

2015-04-02 Thread Ashley Sanders (Code Review)
Ashley Sanders has posted comments on this change. Change subject: non_stasis_bridge_to_stasis_bridge: Update regex for ami events .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/25 To unsubscribe

[asterisk-dev] Change in testsuite[master]: Add a test for PJSIP t38 with authentication based on normal...

2015-04-02 Thread Ashley Sanders (Code Review)
Ashley Sanders has posted comments on this change. Change subject: Add a test for PJSIP t38 with authentication based on normal t38 test .. Patch Set 1: Code-Review-1 (5 comments) Very close. I think just fix the pylint

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

2015-04-02 Thread Ashley Sanders (Code Review)
Ashley Sanders has posted comments on this change. Change subject: stasis: set a channel variable on websocket disconnect error .. Patch Set 1: (3 comments) https://gerrit.asterisk.org/#/c/18/1/tests/rest_api/applications

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

2015-04-01 Thread Ashley Sanders (Code Review)
: I0f7dadfd429bd30e9f07a531f47884d8c923fc13 Gerrit-PatchSet: 2 Gerrit-Project: testsuite Gerrit-Branch: master Gerrit-Owner: Ashley Sanders asand...@digium.com Gerrit-Reviewer: Ashley Sanders asand...@digium.com Gerrit-Reviewer: Mark Michelson mmichel...@digium.com

Re: [asterisk-dev] [Code Review] 4573: trunk: Can't touch this

2015-04-01 Thread Ashley Sanders
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4573/#review15029 --- Ship it! Do it. - Ashley Sanders On April 1, 2015, 2:59

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

2015-04-01 Thread Ashley Sanders (Code Review)
Ashley Sanders has posted comments on this change. Change subject: stasis: set a channel variable on websocket disconnect error .. Patch Set 1: (5 comments) https://gerrit.asterisk.org/#/c/18/1/tests/rest_api/applications

[asterisk-dev] Change in testsuite[master]: Rewrite sip_attended_transfer test to stop failing.

2015-04-01 Thread Ashley Sanders (Code Review)
Ashley Sanders has posted comments on this change. Change subject: Rewrite sip_attended_transfer test to stop failing. .. Patch Set 2: (1 comment) https://gerrit.asterisk.org/#/c/19/2/tests/channels/SIP/sip_attended_transfer

[asterisk-dev] Change in testsuite[master]: Rewrite sip_attended_transfer test to stop failing.

2015-04-01 Thread Ashley Sanders (Code Review)
Ashley Sanders has posted comments on this change. Change subject: Rewrite sip_attended_transfer test to stop failing. .. Patch Set 3: Code-Review+1 (2 comments) Very nice!!! Thanks for taking my (more reasonable) suggestions

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

2015-04-01 Thread Ashley Sanders (Code Review)
Ashley Sanders has posted comments on this change. Change subject: stasis: set a channel variable on websocket disconnect error .. Patch Set 1: (6 comments) Responses to most of the review feedback from Mark Michelson. https

Re: [asterisk-dev] [Code Review] 4520: Testsuite: stasis: set a channel variable on websocket disconnect error

2015-03-31 Thread Ashley Sanders
-CREATION Diff: https://reviewboard.asterisk.org/r/4520/diff/ Testing --- Thanks, Ashley Sanders -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update

Re: [asterisk-dev] [Code Review] 4520: Testsuite: stasis: set a channel variable on websocket disconnect error

2015-03-31 Thread Ashley Sanders
/applications/stasisstatus/ari_client.py PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4520/diff/ Testing --- Thanks, Ashley Sanders -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

[asterisk-dev] Change in testsuite[master]: Rewrite sip_attended_transfer test to stop failing.

2015-03-31 Thread Ashley Sanders (Code Review)
Ashley Sanders has posted comments on this change. Change subject: Rewrite sip_attended_transfer test to stop failing. .. Patch Set 2: Code-Review-1 (6 comments) Overall, this is pretty good. The flow was mostly easy

[asterisk-dev] Change in testsuite[master]: Add SIP attended transfer for Asterisk 11.

2015-03-31 Thread Ashley Sanders (Code Review)
Ashley Sanders has posted comments on this change. Change subject: Add SIP attended transfer for Asterisk 11. .. Patch Set 1: Code-Review-1 (1 comment) I think that most of this could be collapsed into the logic for the test

[asterisk-dev] Change in testsuite[master]: Memory Debugging Improvements

2015-03-31 Thread Ashley Sanders (Code Review)
Ashley Sanders has posted comments on this change. Change subject: Memory Debugging Improvements .. Patch Set 3: Would it be possible for you to post a sample output file? -- To view, visit https://gerrit.asterisk.org/15

[asterisk-dev] Change in testsuite[master]: Memory Debugging Improvements

2015-03-31 Thread Ashley Sanders (Code Review)
Ashley Sanders has posted comments on this change. Change subject: Memory Debugging Improvements .. Patch Set 3: Code-Review-1 (1 comment) I only have one finding - a misspelling. https://gerrit.asterisk.org/#/c/15/3/contrib

Re: [asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

2015-03-31 Thread Ashley Sanders
the situation where an app that was registered in Stasis when call A was originated (and while call A is still active) but is no longer registered when call B is originated. Determines if the 'FAILED' state is correctly applied. Thanks, Ashley Sanders

Re: [asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

2015-03-31 Thread Ashley Sanders
: tests the situation where an app that was registered in Stasis when call A was originated (and while call A is still active) but is no longer registered when call B is originated. Determines if the 'FAILED' state is correctly applied. Thanks, Ashley Sanders

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

2015-03-28 Thread Ashley Sanders (Code Review)
Ashley Sanders has uploaded a new change for review. https://gerrit.asterisk.org/18 Change subject: stasis: set a channel variable on websocket disconnect error .. stasis: set a channel variable on websocket disconnect error

Re: [asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

2015-03-27 Thread Ashley Sanders
if the 'FAILED' state is correctly applied. Thanks, Ashley Sanders -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

2015-03-27 Thread Ashley Sanders
--- On March 27, 2015, 9:54 a.m., Ashley Sanders wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4519

Re: [asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

2015-03-27 Thread Ashley Sanders
applied. 3) The 'Buster' scenario: tests the situation where an app that was registered in Stasis when call A was originated (and while call A is still active) but is no longer registered when call B is originated. Determines if the 'FAILED' state is correctly applied. Thanks, Ashley Sanders

Re: [asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

2015-03-27 Thread Ashley Sanders
. 3) The 'Buster' scenario: tests the situation where an app that was registered in Stasis when call A was originated (and while call A is still active) but is no longer registered when call B is originated. Determines if the 'FAILED' state is correctly applied. Thanks, Ashley Sanders

Re: [asterisk-dev] [Code Review] 4520: Testsuite: stasis: set a channel variable on websocket disconnect error

2015-03-27 Thread Ashley Sanders
/ast1/ari.conf PRE-CREATION ./asterisk/trunk/tests/rest_api/applications/stasis_status/ari_client.py PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4520/diff/ Testing --- Thanks, Ashley Sanders

Re: [asterisk-dev] [Code Review] 4520: Testsuite: stasis: set a channel variable on websocket disconnect error

2015-03-27 Thread Ashley Sanders
--- On March 27, 2015, 10:02 a.m., Ashley Sanders wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4520

Re: [asterisk-dev] [Code Review] 4520: Testsuite: stasis: set a channel variable on websocket disconnect error

2015-03-27 Thread Ashley Sanders
/test_scenario_factory.py https://reviewboard.asterisk.org/r/4520/#comment25524 This function is very similar (if not the same) as the function on line 184. - Ashley Sanders On March 27, 2015, 10:02 a.m., Ashley Sanders wrote

Re: [asterisk-dev] [Code Review] 4520: Testsuite: stasis: set a channel variable on websocket disconnect error

2015-03-27 Thread Ashley Sanders
: https://reviewboard.asterisk.org/r/4520/diff/ Testing --- Thanks, Ashley Sanders -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options

Re: [asterisk-dev] [Code Review] 4520: Testsuite: stasis: set a channel variable on websocket disconnect error

2015-03-27 Thread Ashley Sanders
/tests/rest_api/applications/stasisstatus/ari_client.py PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4520/diff/ Testing --- Thanks, Ashley Sanders -- _ -- Bandwidth and Colocation Provided by http://www.api

Re: [asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

2015-03-27 Thread Ashley Sanders
if the 'FAILED' state is correctly applied. Thanks, Ashley Sanders -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4520: Testsuite: stasis: set a channel variable on websocket disconnect error

2015-03-27 Thread Ashley Sanders
://reviewboard.asterisk.org/r/4520/#review14800 --- On March 27, 2015, 10:58 a.m., Ashley Sanders wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 4520: Testsuite: stasis: set a channel variable on websocket disconnect error

2015-03-27 Thread Ashley Sanders
://reviewboard.asterisk.org/r/4520/diff/ Testing --- Thanks, Ashley Sanders -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

2015-03-27 Thread Ashley Sanders
: tests the situation where an app that was registered in Stasis when call A was originated (and while call A is still active) but is no longer registered when call B is originated. Determines if the 'FAILED' state is correctly applied. Thanks, Ashley Sanders

Re: [asterisk-dev] [Code Review] 4520: Testsuite: stasis: set a channel variable on websocket disconnect error

2015-03-27 Thread Ashley Sanders
://reviewboard.asterisk.org/r/4520/diff/ Testing --- Thanks, Ashley Sanders -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com

Re: [asterisk-dev] [Code Review] 4520: Testsuite: stasis: set a channel variable on websocket disconnect error

2015-03-26 Thread Ashley Sanders
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4520/#review14783 --- On March 22, 2015, 11:34 p.m., Ashley Sanders wrote

Re: [asterisk-dev] [Code Review] 4520: Testsuite: stasis: set a channel variable on websocket disconnect error

2015-03-26 Thread Ashley Sanders
/stasis_status/configs/ast1/ari.conf PRE-CREATION ./asterisk/trunk/tests/rest_api/applications/stasis_status/ari_client.py PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4520/diff/ Testing --- Thanks, Ashley Sanders

Re: [asterisk-dev] [Code Review] 4520: Testsuite: stasis: set a channel variable on websocket disconnect error

2015-03-26 Thread Ashley Sanders
://reviewboard.asterisk.org/r/4520/#review14800 --- On March 22, 2015, 11:34 p.m., Ashley Sanders wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 4520: Testsuite: stasis: set a channel variable on websocket disconnect error

2015-03-26 Thread Ashley Sanders
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4520/#review14783 --- On March 22, 2015, 11:34 p.m., Ashley Sanders wrote

Re: [asterisk-dev] [Code Review] 4520: Testsuite: stasis: set a channel variable on websocket disconnect error

2015-03-26 Thread Ashley Sanders
://reviewboard.asterisk.org/r/4520/#review14783 --- On March 22, 2015, 11:34 p.m., Ashley Sanders wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 4520: Testsuite: stasis: set a channel variable on websocket disconnect error

2015-03-26 Thread Ashley Sanders
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4520/#review14783 --- On March 22, 2015, 11:34 p.m., Ashley Sanders wrote

Re: [asterisk-dev] [Code Review] 4388: Testsuite: Test for res_pjsip_config_wizard auto-create hints.

2015-03-25 Thread Ashley Sanders
-config.yaml https://reviewboard.asterisk.org/r/4388/#comment25429 This needs to be updated to reflect the version in which the feature added. - Ashley Sanders On Jan. 29, 2015, 11:36 a.m., George Joseph wrote

Re: [asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

2015-03-25 Thread Ashley Sanders
) The 'Buster' scenario: tests the situation where an app that was registered in Stasis when call A was originated (and while call A is still active) but is no longer registered when call B is originated. Determines if the 'FAILED' state is correctly applied. Thanks, Ashley Sanders

Re: [asterisk-dev] [Code Review] 4520: Testsuite: stasis: set a channel variable on websocket disconnect error

2015-03-24 Thread Ashley Sanders
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4520/#review14783 --- On March 22, 2015, 11:34 p.m., Ashley Sanders wrote

Re: [asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

2015-03-23 Thread Ashley Sanders
://reviewboard.asterisk.org/r/4519/#comment25360 Here, I refer to the variable as STASISSTATUS, but below, I refer to it as STASIS_STATUS. This may be a moot point wrt to the source after fixing the issue opened by Matt Jordan, but will impact the test. - Ashley Sanders On March 22, 2015, 11:36 p.m

[asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

2015-03-22 Thread Ashley Sanders
to a reviewboard near you (well, this reviewboard.) Diffs - ./branches/13/res/res_stasis.c 433290 ./branches/13/apps/app_stasis.c 433290 Diff: https://reviewboard.asterisk.org/r/4519/diff/ Testing --- Thanks, Ashley Sanders

[asterisk-dev] [Code Review] 4520: Testsuite: stasis: set a channel variable on websocket disconnect error

2015-03-22 Thread Ashley Sanders
Diff: https://reviewboard.asterisk.org/r/4520/diff/ Testing --- Thanks, Ashley Sanders -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update

Re: [asterisk-dev] [Code Review] 4519: Asterisk: stasis: set a channel variable on websocket disconnect error

2015-03-22 Thread Ashley Sanders
://reviewboard.asterisk.org/r/4519/diff/ Testing --- Thanks, Ashley Sanders -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit

Re: [asterisk-dev] [Code Review] 4460: res_pjsip_refer: Fix occasional unexpected BYE sent after receiving a REFER.

2015-03-09 Thread Ashley Sanders
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4460/#review14617 --- Ship it! Ship It! - Ashley Sanders On March 6, 2015, 5:27

Re: [asterisk-dev] [Code Review] 4452: Testsuite: ARI channel subscription tests

2015-03-05 Thread Ashley Sanders
a couple of more instances where we could apply some smart refactoring such that reuse would be possible. - Ashley Sanders On March 4, 2015, 12:58 p.m., jbigelow wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 4452: Testsuite: ARI channel subscription tests

2015-03-05 Thread Ashley Sanders
On March 5, 2015, 1:53 p.m., jbigelow wrote: I see a lot of duplication in the run-test files. I suggest that we refactor and abstract the common pieces of code into a base class somewhere. For instance the check_results function could be abstracted and I saw a couple of more

Re: [asterisk-dev] [Code Review] 4460: res_pjsip_refer: Fix occasional unexpected BYE sent after receiving a REFER.

2015-03-05 Thread Ashley Sanders
function for assigning the response value. - Ashley Sanders On March 4, 2015, 11:31 a.m., rmudgett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4460

Re: [asterisk-dev] [Code Review] 4442: chan_sip: Asterisk fails to re-activate an inactive media session when an offer does not contain a=sendrecv

2015-03-02 Thread Ashley Sanders
/ Testing --- Thanks, Ashley Sanders -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo

Re: [asterisk-dev] [Code Review] 4442: chan_sip: Asterisk fails to re-activate an inactive media session when an offer does not contain a=sendrecv

2015-02-26 Thread Ashley Sanders
/phone_B_IP_media_restrict.xml 6458 ./asterisk/trunk/tests/channels/SIP/sip_hold/sipp/phone_A_no_direction.xml PRE-CREATION ./asterisk/trunk/tests/channels/SIP/sip_hold/run-test 6458 Diff: https://reviewboard.asterisk.org/r/4442/diff/ Testing --- Thanks, Ashley Sanders

Re: [asterisk-dev] [Code Review] 4442: chan_sip: Asterisk fails to re-activate an inactive media session when an offer does not contain a=sendrecv

2015-02-26 Thread Ashley Sanders
./asterisk/trunk/tests/channels/SIP/sip_hold/sipp/phone_A_no_direction.xml PRE-CREATION ./asterisk/trunk/tests/channels/SIP/sip_hold/run-test 6458 Diff: https://reviewboard.asterisk.org/r/4442/diff/ Testing --- Thanks, Ashley Sanders

Re: [asterisk-dev] [Code Review] 4437: dns: Define a core DNS API with examples.

2015-02-26 Thread Ashley Sanders
On Feb. 26, 2015, 10:46 a.m., Joshua Colp wrote: mjordan file: for the proposed DNS API, are you envisioning having it act as a facade over a particular library? Or having a separate file/module register to the core? file register file the end result will be the same but it keeps

Re: [asterisk-dev] [Code Review] 4437: dns: Define a core DNS API with examples.

2015-02-25 Thread Ashley Sanders
for the query? Record - Here is where I would go into more detail the types of records we support - Ashley Sanders On Feb. 22, 2015, 6:25 p.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 4442: chan_sip: Asterisk fails to re-activate an inactive media session when an offer does not contain a=sendrecv

2015-02-24 Thread Ashley Sanders
/phone_B_IP_media_restrict.xml 6458 ./asterisk/trunk/tests/channels/SIP/sip_hold/sipp/phone_A_no_direction.xml PRE-CREATION ./asterisk/trunk/tests/channels/SIP/sip_hold/run-test 6458 Diff: https://reviewboard.asterisk.org/r/4442/diff/ Testing --- Thanks, Ashley Sanders

Re: [asterisk-dev] [Code Review] 4442: chan_sip: Asterisk fails to re-activate an inactive media session when an offer does not contain a=sendrecv

2015-02-24 Thread Ashley Sanders
: https://reviewboard.asterisk.org/r/4442/#review14522 --- On Feb. 24, 2015, 12:47 p.m., Ashley Sanders wrote: --- This is an automatically generated e-mail. To reply, visit: https

[asterisk-dev] [Code Review] 4442: chan_sip: Asterisk fails to re-activate an inactive media session when an offer does not contain a=sendrecv

2015-02-23 Thread Ashley Sanders
/phone_B_IP_restrict.xml 6458 ./asterisk/trunk/tests/channels/SIP/sip_hold/sipp/phone_B_IP_media_restrict.xml 6458 ./asterisk/trunk/tests/channels/SIP/sip_hold/run-test 6458 Diff: https://reviewboard.asterisk.org/r/4442/diff/ Testing --- Thanks, Ashley Sanders

Re: [asterisk-dev] [Code Review] 4377: Testsuite: For httpd server, need option to define server name for security purposes

2015-01-30 Thread Ashley Sanders
-CREATION ./asterisk/trunk/tests/http_server/servername/configs/ast1/http.conf PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4377/diff/ Testing --- Thanks, Ashley Sanders -- _ -- Bandwidth and Colocation Provided

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

2015-01-30 Thread Ashley Sanders
/http.h 431112 ./branches/13/configs/samples/http.conf.sample 431112 Diff: https://reviewboard.asterisk.org/r/4374/diff/ Testing --- Thanks, Ashley Sanders -- _ -- Bandwidth and Colocation Provided by http://www.api

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

2015-01-29 Thread Ashley Sanders
., Ashley Sanders wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4374/ --- (Updated Jan. 28, 2015, 8:13 p.m.) Review

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

2015-01-29 Thread Ashley Sanders
--- On Jan. 28, 2015, 8:13 p.m., Ashley Sanders wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4374/ --- (Updated Jan. 28, 2015

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

2015-01-29 Thread Ashley Sanders
://reviewboard.asterisk.org/r/4374/diff/ Testing --- Thanks, Ashley Sanders -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

2015-01-29 Thread Ashley Sanders
://reviewboard.asterisk.org/r/4374/diff/ Testing --- Thanks, Ashley Sanders -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

2015-01-28 Thread Ashley Sanders
://reviewboard.asterisk.org/r/4374/diff/ Testing --- Thanks, Ashley Sanders -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

2015-01-28 Thread Ashley Sanders
for this and use ast_str_set_va() instead of the snprintf() when filling the string. Ashley Sanders wrote: You are correct, this is a small amount. From the previous review, you advised to take the larger of the error/auth functions' header size and use that, which, admittedly, was different from

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

2015-01-28 Thread Ashley Sanders
16 bytes and copies the string into the array then nuls any extra array characters. Ashley Sanders wrote: Unauthorized + a null terminating character = 13 characters, which is and 13 bytes, right? Ashley Sanders wrote: Earlier, I misread what you typed. I understand what you

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

2015-01-28 Thread Ashley Sanders
On Jan. 27, 2015, 7:51 p.m., rmudgett wrote: ./branches/13/main/http.c, line 384 https://reviewboard.asterisk.org/r/4374/diff/2/?file=71124#file71124line384 Does this need to be skipped if http_server_name is empty? Ashley Sanders wrote: I think in the case of the status

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

2015-01-28 Thread Ashley Sanders
://reviewboard.asterisk.org/r/4374/diff/ Testing --- Thanks, Ashley Sanders -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

2015-01-28 Thread Ashley Sanders
://reviewboard.asterisk.org/r/4374/diff/ Testing --- Thanks, Ashley Sanders -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

  1   2   >