Re: [asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

2014-07-21 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3758/ --- (Updated July 21, 2014, 4:40 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

2014-07-21 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3758/ --- (Updated July 21, 2014, 3:41 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

2014-07-18 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3758/#review12760 --- Ship it! Ship It! - opticron On July 16, 2014, 8:29 p.m.,

Re: [asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

2014-07-18 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3758/#review12763 --- Ship it! Ship It! - rmudgett On July 16, 2014, 8:29 p.m.,

Re: [asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

2014-07-16 Thread Corey Farrell
On July 13, 2014, 2:59 p.m., opticron wrote: /trunk/res/res_smdi.c, line 394 https://reviewboard.asterisk.org/r/3758/diff/1/?file=62870#file62870line394 This can be accomplished with: ao2_callback(iface-mwi_q, OBJ_UNLINK | OBJ_NODATA, NULL, NULL); Seems like I shouldn't use

Re: [asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

2014-07-16 Thread rmudgett
On July 13, 2014, 1:59 p.m., opticron wrote: /trunk/res/res_smdi.c, line 394 https://reviewboard.asterisk.org/r/3758/diff/1/?file=62870#file62870line394 This can be accomplished with: ao2_callback(iface-mwi_q, OBJ_UNLINK | OBJ_NODATA, NULL, NULL); Corey Farrell wrote:

Re: [asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

2014-07-16 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3758/ --- (Updated July 16, 2014, 7:32 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

2014-07-16 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3758/#review12704 --- /trunk/res/res_smdi.c

Re: [asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

2014-07-16 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3758/ --- (Updated July 16, 2014, 9:29 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

2014-07-16 Thread Corey Farrell
On July 16, 2014, 9:19 p.m., rmudgett wrote: /trunk/res/res_smdi.c, line 1207 https://reviewboard.asterisk.org/r/3758/diff/2/?file=64626#file64626line1207 Yuck a shadowed variable. Technically no the other 'iface' variable was in a different sub-scope (to allow use with RAII_VAR).

Re: [asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

2014-07-13 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3758/#review12606 --- /trunk/res/res_smdi.c

Re: [asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

2014-07-13 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3758/#review12612 --- /trunk/channels/dahdi/bridge_native_dahdi.c

[asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

2014-07-12 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3758/ --- Review request for Asterisk Developers. Repository: Asterisk