[asterisk-dev] Change in asterisk[13]: pjsip_options: Add qualify_timeout processing and eventing

2015-04-11 Thread George Joseph (Code Review)
George Joseph has uploaded a new change for review. https://gerrit.asterisk.org/44 Change subject: pjsip_options: Add qualify_timeout processing and eventing .. pjsip_options: Add qualify_timeout processing and eventing This

[asterisk-dev] Change in asterisk[master]: Add .gitignore and .gitreview files

2015-04-11 Thread George Joseph (Code Review)
George Joseph has uploaded a new change for review. https://gerrit.asterisk.org/42 Change subject: Add .gitignore and .gitreview files .. Add .gitignore and .gitreview files Add the .gitignore and .gitreview files to the

Re: [asterisk-dev] [Code Review] 4585: res_pjsip: Refactor endpt_send_request to include transaction timeout

2015-04-11 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4585/ --- (Updated April 11, 2015, 3:52 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4587: pjsip_options: Add qualify_timeout processing and eventing

2015-04-11 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4587/ --- (Updated April 11, 2015, 4:02 p.m.) Status -- This change has been

[asterisk-dev] How to get peer review for patch to deprecated module (was: Re: [asterisk-users] Help debugging a possible SIP channel leak in 11.17.0, possible race condition)

2015-04-11 Thread Alex Villacís Lasso
El 10/04/15 a las 14:16, Alex Villací­s Lasso escribió: El 08/04/15 a las 08:22, Vinicius Fontes escribió: Have you tried Asterisk 13? The bridging mechanism has been completely rewritten on Asterisk 12, so there's no longer channel masquerading and zombie channels. Might be worth a try.

[asterisk-dev] Change in asterisk[master]: Add .gitignore and .gitreview files

2015-04-11 Thread Corey Farrell (Code Review)
Corey Farrell has posted comments on this change. Change subject: Add .gitignore and .gitreview files .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/42 To unsubscribe, visit

[asterisk-dev] Change in asterisk[master]: Add .gitignore and .gitreview files

2015-04-11 Thread Corey Farrell (Code Review)
Corey Farrell has posted comments on this change. Change subject: Add .gitignore and .gitreview files .. Patch Set 1: (2 comments) Couple minor things then this is good to go. https://gerrit.asterisk.org/#/c/42/1/.gitignore

[asterisk-dev] Change in asterisk[master]: Add .gitignore and .gitreview files

2015-04-11 Thread Russell Bryant (Code Review)
Russell Bryant has posted comments on this change. Change subject: Add .gitignore and .gitreview files .. Patch Set 2: (1 comment) https://gerrit.asterisk.org/#/c/42/2/.gitignore File .gitignore: Line 21: addons/mp3 I

[asterisk-dev] Change in asterisk[master]: Add .gitignore and .gitreview files

2015-04-11 Thread Russell Bryant (Code Review)
Russell Bryant has posted comments on this change. Change subject: Add .gitignore and .gitreview files .. Patch Set 2: (1 comment) https://gerrit.asterisk.org/#/c/42/2//COMMIT_MSG Commit Message: Line 15: Tested-by: George

[asterisk-dev] Change in asterisk[master]: Add .gitignore and .gitreview files

2015-04-11 Thread George Joseph (Code Review)
George Joseph has posted comments on this change. Change subject: Add .gitignore and .gitreview files .. Patch Set 2: (1 comment) My only issue with this is that it makes it harder to troubleshoot or get an overview of

[asterisk-dev] Change in asterisk[13]: res_pjsip: Refactor endpt_send_request to include transactio...

2015-04-11 Thread George Joseph (Code Review)
George Joseph has uploaded a new change for review. https://gerrit.asterisk.org/43 Change subject: res_pjsip: Refactor endpt_send_request to include transaction timeout .. res_pjsip: Refactor endpt_send_request to include

Re: [asterisk-dev] [Code Review] 4589: res_pjsip_t38: Add missing initialization of udptl-far_max_datagram in t38_initialize_session()

2015-04-11 Thread Juergen Spies
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4589/ --- (Updated April 11, 2015, 10:11 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4555: clang compiler warning: fixes for tests to be compiled using clang

2015-04-11 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4555/ --- (Updated April 11, 2015, 10:26 a.m.) Status -- This change has been

[asterisk-dev] Change in testsuite[master]: tests/channels/pjsip/config_wizard/hints: Add 'has_hint' var...

2015-04-11 Thread George Joseph (Code Review)
George Joseph has uploaded a new change for review. https://gerrit.asterisk.org/41 Change subject: tests/channels/pjsip/config_wizard/hints: Add 'has_hint' variable .. tests/channels/pjsip/config_wizard/hints: Add 'has_hint'

Re: [asterisk-dev] How to get peer review for patch to deprecated module (was: Re: [asterisk-users] Help debugging a possible SIP channel leak in 11.17.0, possible race condition)

2015-04-11 Thread Matthew Jordan
On Sat, Apr 11, 2015 at 4:31 PM, Alex Villacís Lasso a_villa...@palosanto.com wrote: El 10/04/15 a las 14:16, Alex Villací­s Lasso escribió: El 08/04/15 a las 08:22, Vinicius Fontes escribió: Have you tried Asterisk 13? The bridging mechanism has been completely rewritten on Asterisk 12, so

[asterisk-dev] Change in asterisk[master]: sounds: Add a .gitignore file for downloaded sound tarballs

2015-04-11 Thread Matt Jordan (Code Review)
Matt Jordan has uploaded a new change for review. https://gerrit.asterisk.org/55 Change subject: sounds: Add a .gitignore file for downloaded sound tarballs .. sounds: Add a .gitignore file for downloaded sound tarballs This

[asterisk-dev] Change in asterisk[master]: sounds: Add a .gitignore file for downloaded sound tarballs

2015-04-11 Thread Corey Farrell (Code Review)
Corey Farrell has posted comments on this change. Change subject: sounds: Add a .gitignore file for downloaded sound tarballs .. Patch Set 1: Code-Review-1 Any reason we can't just add to the root .gitignore: *.gz This way if

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

2015-04-11 Thread Matt Jordan (Code Review)
Matt Jordan has uploaded a new patch set (#3). Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. git migration: Refactor the ASTERISK_FILE_VERSION macro Git does not support the ability to replace a

[asterisk-dev] Change in asterisk[master]: .gitignore: Ignore tarballs (*.gz)

2015-04-11 Thread Matt Jordan (Code Review)
Hello Corey Farrell, I'd like you to reexamine a change. Please visit https://gerrit.asterisk.org/55 to look at the new patch set (#2). Change subject: .gitignore: Ignore tarballs (*.gz) .. .gitignore: Ignore tarballs

[asterisk-dev] Change in asterisk[master]: Add .gitignore and .gitreview files

2015-04-11 Thread Matt Jordan (Code Review)
Matt Jordan has submitted this change and it was merged. Change subject: Add .gitignore and .gitreview files .. Add .gitignore and .gitreview files Add the .gitignore and .gitreview files to the asterisk repo. NB: You can

[asterisk-dev] Change in asterisk[master]: Add .gitignore and .gitreview files

2015-04-11 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: Add .gitignore and .gitreview files .. Patch Set 3: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/42 To unsubscribe, visit

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

2015-04-11 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. Patch Set 3: Note for reviewers: This patch will break ABI, and can't be backported as-is. Once

[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

2015-04-11 Thread Matt Jordan (Code Review)
Matt Jordan has uploaded a new patch set (#2). Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro .. git migration: Refactor the ASTERISK_FILE_VERSION macro Git does not support the ability to replace a

[asterisk-dev] Git Migration update

2015-04-11 Thread Matthew Jordan
Hey everyone - As an update on the Git migration, here is the current state of the world: 1. The SVN repos have been marked read-only. While you will still be able to checkout from SVN, you shouldn't commit to any of the branches. Note that even if you do, those commits won't make it into the

Re: [asterisk-dev] Git Migration update

2015-04-11 Thread Matthew Jordan
On Sat, Apr 11, 2015 at 11:15 PM, Matthew Jordan mjor...@digium.com wrote: 1. We need to determine the best way to handle maintaining the long running branches. While rebasing is appropriate for topic branches (team branches) that closely track a mainline branch, the mainline branches are a

[asterisk-dev] Change in asterisk[master]: .gitignore: Ignore tarballs (*.gz)

2015-04-11 Thread Corey Farrell (Code Review)
Corey Farrell has posted comments on this change. Change subject: .gitignore: Ignore tarballs (*.gz) .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/55 To unsubscribe, visit

[asterisk-dev] Change in asterisk[13]: res_pjsip: Add global option to limit the maximum time for i...

2015-04-11 Thread George Joseph (Code Review)
George Joseph has uploaded a new change for review. https://gerrit.asterisk.org/45 Change subject: res_pjsip: Add global option to limit the maximum time for initial qualifies .. res_pjsip: Add global option to limit the

Re: [asterisk-dev] [Code Review] 4611: res_pjsip: Add global option to limit the maximum time for initial qualifies

2015-04-11 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4611/ --- (Updated April 11, 2015, 4:06 p.m.) Status -- This change has been

[asterisk-dev] Change in asterisk[13]: res_pjsip: Add global option to limit the maximum time for i...

2015-04-11 Thread George Joseph (Code Review)
George Joseph has uploaded a new patch set (#2). Change subject: res_pjsip: Add global option to limit the maximum time for initial qualifies .. res_pjsip: Add global option to limit the maximum time for initial qualifies

[asterisk-dev] Change in asterisk[master]: Add .gitignore and .gitreview files

2015-04-11 Thread Matt Jordan (Code Review)
Matt Jordan has posted comments on this change. Change subject: Add .gitignore and .gitreview files .. Patch Set 2: (2 comments) https://gerrit.asterisk.org/#/c/42/2/.gitignore File .gitignore: Line 21: addons/mp3 I

[asterisk-dev] Change in asterisk[master]: res_pjsip: Add global option to limit the maximum time for i...

2015-04-11 Thread George Joseph (Code Review)
George Joseph has uploaded a new change for review. https://gerrit.asterisk.org/48 Change subject: res_pjsip: Add global option to limit the maximum time for initial qualifies .. res_pjsip: Add global option to limit the

[asterisk-dev] Change in asterisk[master]: pjsip_options: Add qualify_timeout processing and eventing

2015-04-11 Thread George Joseph (Code Review)
George Joseph has uploaded a new change for review. https://gerrit.asterisk.org/47 Change subject: pjsip_options: Add qualify_timeout processing and eventing .. pjsip_options: Add qualify_timeout processing and eventing This

[asterisk-dev] Change in asterisk[13]: Add .gitignore and .gitreview files

2015-04-11 Thread George Joseph (Code Review)
George Joseph has uploaded a new change for review. https://gerrit.asterisk.org/49 Change subject: Add .gitignore and .gitreview files .. Add .gitignore and .gitreview files Add the .gitignore and .gitreview files to the

[asterisk-dev] Change in asterisk[master]: pjsip_options: Add qualify_timeout processing and eventing

2015-04-11 Thread George Joseph (Code Review)
George Joseph has abandoned this change. Change subject: pjsip_options: Add qualify_timeout processing and eventing .. Abandoned -- To view, visit https://gerrit.asterisk.org/47 To unsubscribe, visit

[asterisk-dev] Change in asterisk[13]: Add .gitignore and .gitreview files

2015-04-11 Thread George Joseph (Code Review)
George Joseph has abandoned this change. Change subject: Add .gitignore and .gitreview files .. Abandoned -- To view, visit https://gerrit.asterisk.org/49 To unsubscribe, visit https://gerrit.asterisk.org/settings

[asterisk-dev] Change in asterisk[master]: res_pjsip: Refactor endpt_send_request to include transactio...

2015-04-11 Thread George Joseph (Code Review)
George Joseph has abandoned this change. Change subject: res_pjsip: Refactor endpt_send_request to include transaction timeout .. Abandoned -- To view, visit https://gerrit.asterisk.org/46 To unsubscribe, visit

[asterisk-dev] Change in asterisk[master]: res_pjsip: Add global option to limit the maximum time for i...

2015-04-11 Thread George Joseph (Code Review)
George Joseph has abandoned this change. Change subject: res_pjsip: Add global option to limit the maximum time for initial qualifies .. Abandoned -- To view, visit https://gerrit.asterisk.org/48 To unsubscribe, visit

[asterisk-dev] Change in asterisk[master]: Add .gitignore and .gitreview files

2015-04-11 Thread George Joseph (Code Review)
Hello Corey Farrell, I'd like you to reexamine a change. Please visit https://gerrit.asterisk.org/42 to look at the new patch set (#3). Change subject: Add .gitignore and .gitreview files .. Add .gitignore and .gitreview

[asterisk-dev] Change in asterisk[master]: Add .gitignore and .gitreview files

2015-04-11 Thread Russell Bryant (Code Review)
Russell Bryant has posted comments on this change. Change subject: Add .gitignore and .gitreview files .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/42 To unsubscribe, visit