[asterisk-dev] Question about interface to sound processing library

2014-07-18 Thread Rolf-Werner Eilert
Hi folks, I hope I'm right here in this list. Tried to ask this as a general question in forum General first, but there was only a vague answer. Here I expect to find the guys who make the core functions of Asterisk, so I ask my question again. To describe the reason for my question: We are

Re: [asterisk-dev] Question about interface to sound processing library

2014-07-18 Thread Dennis Guse
Hi Rolf, there is a nice option available in Asterisk. Asterisk supports JACK [1], which is basically a virtual local audio routing system that allows to send audio data from one application on the same PC running as the same user. Using a audio processing like Puredata [2] realtime audio

Re: [asterisk-dev] [Code Review] 3811: Move main/manager_*.c to loadable modules

2014-07-18 Thread Mark Michelson
On July 17, 2014, 9:41 p.m., Matt Jordan wrote: /trunk/main/stasis_channels.c, lines 1071-1077 https://reviewboard.asterisk.org/r/3811/diff/1/?file=64565#file64565line1071 I'm not sure why these changes (removal of the .to_ami callback) were necessary. Generally, I

Re: [asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

2014-07-18 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3823/#review12740 --- trunk/configs/samples/stasis.conf.sample

Re: [asterisk-dev] [Code Review] 3816: Publish transferee and transfer target channels, when possible, during transfers.

2014-07-18 Thread Mark Michelson
On July 17, 2014, 9 p.m., Jonathan Rose wrote: /trunk/main/bridge_basic.c, line 1539 https://reviewboard.asterisk.org/r/3816/diff/2/?file=64708#file64708line1539 Should this be a NOTICE log message? It appears to occur kind of deeply and might be better as debug. Yep, all of

Re: [asterisk-dev] [Code Review] 3765: astobj2: debug backtrace and assert on invalid refcount

2014-07-18 Thread Scott Griepentrog
On July 13, 2014, 4:22 p.m., rmudgett wrote: ast_assert() already outputs a backtrace using ao2_bt() even if DO_CRACH is not enabled. We also seem to have two backtrace generation functions: ao2_bt() ast_log_bactrace() Matt Jordan wrote: We could consolidate these two

Re: [asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

2014-07-18 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3823/ --- (Updated July 18, 2014, 9:54 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3765: astobj2: debug backtrace and assert on invalid refcount

2014-07-18 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3765/ --- (Updated July 18, 2014, 9:58 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3817: res_pjsip_notify: Add the ability for PJSIPNotify AMI command and pjsip send notify CLI command to send to a URI instead of an endpoint

2014-07-18 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3817/#review12744 --- /trunk/include/asterisk/res_pjsip.h

Re: [asterisk-dev] [Code Review] 3666: res_fax: fax show session, fax show sessions, fax show stats - providing similar AMI commands

2014-07-18 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3666/ --- (Updated July 18, 2014, 10:49 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3825: testsuite: Add a PJSIPNotify manager command test for using URIs instead of endpoints

2014-07-18 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3825/#review12746 --- The mechanics of the test are all good as far as I can tell.

Re: [asterisk-dev] [Code Review] 3721: Masquerades: Framehook and Audiohook fixup

2014-07-18 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3721/ --- (Updated July 18, 2014, 11:02 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3817: res_pjsip_notify: Add the ability for PJSIPNotify AMI command and pjsip send notify CLI command to send to a URI instead of an endpoint

2014-07-18 Thread Jonathan Rose
On July 18, 2014, 10:40 a.m., Mark Michelson wrote: /trunk/include/asterisk/res_pjsip.h, lines 1195-1203 https://reviewboard.asterisk.org/r/3817/diff/2/?file=64713#file64713line1195 This function isn't necessary. When PJSIP is passed a URI string, PJSIP will perform URI

Re: [asterisk-dev] [Code Review] 3759: chan_sip: upgrade registry and mwi object to ao2

2014-07-18 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3759/#review12742 --- /trunk/channels/chan_sip.c

Re: [asterisk-dev] [Code Review] 3765: astobj2: debug backtrace and assert on invalid refcount

2014-07-18 Thread rmudgett
On July 13, 2014, 4:22 p.m., rmudgett wrote: ast_assert() already outputs a backtrace using ao2_bt() even if DO_CRACH is not enabled. We also seem to have two backtrace generation functions: ao2_bt() ast_log_bactrace() Matt Jordan wrote: We could consolidate these two

[asterisk-dev] [Code Review] 3829: Voicemail send email to multiple email addresses

2014-07-18 Thread Jacob Barber
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3829/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3765: astobj2: debug backtrace and assert on invalid refcount

2014-07-18 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3765/#review12750 --- Ship it! I also checked that the utils directory still

Re: [asterisk-dev] [Code Review] 3829: Voicemail send email to multiple email addresses

2014-07-18 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3829/#review12751 --- Just put ASTERISK-24045 in the bugs section of the review. -

Re: [asterisk-dev] [Code Review] 3829: Voicemail send email to multiple email addresses

2014-07-18 Thread Jacob Barber
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3829/ --- (Updated July 18, 2014, 4:55 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3822: media_formats: move format_compatability to channels/iax2 where possible

2014-07-18 Thread rmudgett
On July 17, 2014, 4:38 p.m., rmudgett wrote: /team/group/media_formats-reviewed-trunk/main/format_compatibility.c, line 176 https://reviewboard.asterisk.org/r/3822/diff/3/?file=64775#file64775line176 I'm not sure this should be moved from the core since the conversion the

Re: [asterisk-dev] [Code Review] 3822: media_formats: move format_compatability to channels/iax2 where possible

2014-07-18 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3822/#review12753 --- Ship it! Ship It! - rmudgett On July 17, 2014, 11:15 p.m.,

Re: [asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

2014-07-18 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3823/#review12756 --- trunk/main/stasis.c

Re: [asterisk-dev] [Code Review] 3799: manager: Add ExtensionStateList, PresenceStateList, and DeviceStateList commands

2014-07-18 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3799/#review12755 --- /trunk/main/pbx.c

Re: [asterisk-dev] [Code Review] 3823: Stasis: Allow configuration of message types to disallow

2014-07-18 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3823/ --- (Updated July 18, 2014, 12:22 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3817: res_pjsip_notify: Add the ability for PJSIPNotify AMI command and pjsip send notify CLI command to send to a URI instead of an endpoint

2014-07-18 Thread Jonathan Rose
On July 18, 2014, 10:40 a.m., Mark Michelson wrote: /trunk/res/res_pjsip_notify.c, lines 799-801 https://reviewboard.asterisk.org/r/3817/diff/2/?file=64715#file64715line799 The way this is set up, if you were to get on the CLI and type pjsip notify foo urtab then the generation

Re: [asterisk-dev] [Code Review] 3800: media formats: chan_iax2 - Obey preferred codec order when selecting format for calls

2014-07-18 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3800/#review12757 --- Ship it! Ship It! - opticron On July 15, 2014, 5:28 p.m.,

Re: [asterisk-dev] [Code Review] 3829: Voicemail send email to multiple email addresses

2014-07-18 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3829/#review12758 --- /branches/12/apps/app_voicemail.c

Re: [asterisk-dev] [Code Review] 3822: media_formats: move format_compatability to channels/iax2 where possible

2014-07-18 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3822/ --- (Updated July 18, 2014, 12:40 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3728: ARI: Add missing transfer information

2014-07-18 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3728/ --- (Updated July 18, 2014, 12:42 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3729: Stasis: Allow prestart actions to be queued

2014-07-18 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3729/ --- (Updated July 18, 2014, 12:48 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3765: astobj2: debug backtrace and assert on invalid refcount

2014-07-18 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3765/ --- (Updated July 18, 2014, 12:55 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3731: Stasis: Prevent non-stasis channels from entering stasis bridges

2014-07-18 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3731/ --- (Updated July 18, 2014, 12:58 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3817: res_pjsip_notify: Add the ability for PJSIPNotify AMI command and pjsip send notify CLI command to send to a URI instead of an endpoint

2014-07-18 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3817/ --- (Updated July 18, 2014, 1:32 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3829: Voicemail send email to multiple email addresses

2014-07-18 Thread Jacob Barber
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3829/ --- (Updated July 18, 2014, 6:33 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3825: testsuite: Add a PJSIPNotify manager command test for using URIs instead of endpoints

2014-07-18 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3825/ --- (Updated July 18, 2014, 1:33 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3829: Voicemail send email to multiple email addresses

2014-07-18 Thread Jacob Barber
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3829/ --- (Updated July 18, 2014, 6:35 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3810: res_hep_rtcp: Add module that sends RTCP information to a Homer Server

2014-07-18 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3810/#review12759 --- The Asterisk side of this looks good. Could you add the

[asterisk-dev] Original 48kHz versions of the asterisk prompts and addons?

2014-07-18 Thread Stephen Davies
Hi, I'm on a mission to build a little demo system that blows past everyone's perceptions of what a VOIP system sounds like. For that system I want to make a set of standard and addon prompts in .sln48. But I don't just want to upsample the existing sln16 since that is only 16kHz sample rate.

[asterisk-dev] Astridevcon - Monday or Tuesday?

2014-07-18 Thread Stephen Davies
Hi, Astricon has been moved to Wednesday 22nd through 24th. Will Astridevcon be on Monday or Tuesday? Thanks, Steve -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To

Re: [asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

2014-07-18 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3758/#review12760 --- Ship it! Ship It! - opticron On July 16, 2014, 8:29 p.m.,

Re: [asterisk-dev] [Code Review] 3800: media formats: chan_iax2 - Obey preferred codec order when selecting format for calls

2014-07-18 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3800/#review12761 --- Before you commit be sure you can recompile against the latest

[asterisk-dev] [Code Review] 3830: Fix build when pjproject is installed in non-standard location

2014-07-18 Thread Sean Bright
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3830/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] Astridevcon - Monday or Tuesday?

2014-07-18 Thread David Duffett
Tuesday All the best, David On 18 July 2014 19:58, Stephen Davies stephen.l.dav...@gmail.com wrote: Hi, Astricon has been moved to Wednesday 22nd through 24th. Will Astridevcon be on Monday or Tuesday? Thanks, Steve --

Re: [asterisk-dev] [Code Review] 3821: Use ao2_t_alloc for certain stasis allocators

2014-07-18 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3821/ --- (Updated July 18, 2014, 2:53 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3812: AMI: Allow for response documentation

2014-07-18 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3812/ --- (Updated July 18, 2014, 2:57 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3811: Move main/manager_*.c to loadable modules

2014-07-18 Thread Corey Farrell
On July 17, 2014, 5:41 p.m., Matt Jordan wrote: /trunk/main/stasis_channels.c, lines 1071-1077 https://reviewboard.asterisk.org/r/3811/diff/1/?file=64565#file64565line1071 I'm not sure why these changes (removal of the .to_ami callback) were necessary. Generally, I

Re: [asterisk-dev] [Code Review] 3758: res_smdi: convert to astobj2

2014-07-18 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3758/#review12763 --- Ship it! Ship It! - rmudgett On July 16, 2014, 8:29 p.m.,

Re: [asterisk-dev] [Code Review] 3759: chan_sip: upgrade registry and mwi object to ao2

2014-07-18 Thread Corey Farrell
On July 18, 2014, 12:09 p.m., opticron wrote: I'm going to run tests/channels/SIP then I'll update the diff. On July 18, 2014, 12:09 p.m., opticron wrote: /trunk/channels/chan_sip.c, lines 1190-1194 https://reviewboard.asterisk.org/r/3759/diff/2/?file=63077#file63077line1190

Re: [asterisk-dev] [Code Review] 3819: Substitute Variables In Features Application Map Before Execution

2014-07-18 Thread Michael Young
On July 16, 2014, 8:23 p.m., rmudgett wrote: /trunk/main/bridge_channel.c, lines 875-876 https://reviewboard.asterisk.org/r/3819/diff/1/?file=64628#file64628line875 I think you want strlen(app_args) + 1 instead of sizeof(app_args) which returns the size of a pointer. I'm

Re: [asterisk-dev] [Code Review] 3819: Substitute Variables In Features Application Map Before Execution

2014-07-18 Thread Michael Young
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3819/ --- (Updated July 18, 2014, 4:51 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3820: MixMonitor: Add Options To Play Beep At Start Or End

2014-07-18 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3820/#review12766 --- Ship it! /trunk/apps/app_mixmonitor.c

Re: [asterisk-dev] [Code Review] 3768: ARI: add a copy operation for stored recordings

2014-07-18 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3768/ --- (Updated July 18, 2014, 4:26 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3800: media formats: chan_iax2 - Obey preferred codec order when selecting format for calls

2014-07-18 Thread Jonathan Rose
On July 18, 2014, 2:13 p.m., Corey Farrell wrote: Before you commit be sure you can recompile against the latest revision, r3822 has been committed. This renamed ast_codec_pref* to iax2_codec_pref and a couple of the ast_format_compatibility_* to iax2_format_compatibility. Thanks for

Re: [asterisk-dev] [Code Review] 3769: testsuite: Add tests for copying a stored recording

2014-07-18 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3769/ --- (Updated July 18, 2014, 4:58 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3759: chan_sip: upgrade registry and mwi object to ao2

2014-07-18 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3759/ --- (Updated July 18, 2014, 7:39 p.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 3831: res_fax: unregister manager actions on unload

2014-07-18 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3831/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24058