Re: [asterisk-dev] [Code Review] 3915: AMI: Add AllVariables parameter to Status

2014-08-19 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3915/ --- (Updated Aug. 19, 2014, 7:16 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3921: Stasis: Add missing information to blind transfer events

2014-08-19 Thread opticron
On Aug. 18, 2014, 2:47 p.m., rmudgett wrote: branches/12/main/stasis_bridges.c, line 627 https://reviewboard.asterisk.org/r/3921/diff/2/?file=66598#file66598line627 Please make this one declaration per line. json_transferer is leaked (new and pre-existing leak)

Re: [asterisk-dev] [Code Review] 3921: Stasis: Add missing information to blind transfer events

2014-08-19 Thread opticron
On Aug. 18, 2014, 2:47 p.m., rmudgett wrote: branches/12/main/stasis_bridges.c, line 627 https://reviewboard.asterisk.org/r/3921/diff/2/?file=66598#file66598line627 Please make this one declaration per line. json_transferer is leaked (new and pre-existing leak)

Re: [asterisk-dev] [Code Review] 3921: Stasis: Add missing information to blind transfer events

2014-08-19 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3921/ --- (Updated Aug. 19, 2014, 7:29 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3906: chan_pjsip: Update media translation paths when new SDP negotiated.

2014-08-19 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3906/#review13113 --- Ship it! Ship It! - opticron On Aug. 13, 2014, 3 p.m.,

Re: [asterisk-dev] [Code Review] 3913: chan_pjsip: Attended transfer does not update connected line name.

2014-08-19 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3913/ --- (Updated Aug. 19, 2014, 11:07 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3920: Fix after bridge behavior when channel moves from a Stasis bridge to a non-Stasis bridge

2014-08-19 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3920/ --- (Updated Aug. 19, 2014, 4:10 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3917: ARI: /channels/continue doesn't work on a channel originated to a Stasis application with no PBX

2014-08-19 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3917/ --- (Updated Aug. 19, 2014, 11:21 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3911: testsuite: Tests hangup during ari playback to a channel in a bridge

2014-08-19 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3911/#review13115 ---

[asterisk-dev] Asterisk beginner trying to develop a new channel

2014-08-19 Thread Maiquel Breitenbach
Hi, my name is Maiquel Breitenbach, I am from Brazil and i am trying develop a new asterisk channel, nothing specific, only to understand a whole channel process of channel construction, until now i am understand the load and unload process to register in asterisk new channel, I understand to the

Re: [asterisk-dev] [Code Review] 3918: Testsuite: Add a test for ARI originate and continue functionality

2014-08-19 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3918/#review13116 ---

Re: [asterisk-dev] [Code Review] 3873: Testsuite: RLS tests - nominal presence lists

2014-08-19 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3873/#review13117 ---

Re: [asterisk-dev] [Code Review] 3920: Fix after bridge behavior when channel moves from a Stasis bridge to a non-Stasis bridge

2014-08-19 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3920/#review13118 --- /branches/13/res/stasis/control.c

Re: [asterisk-dev] [Code Review] 3920: Fix after bridge behavior when channel moves from a Stasis bridge to a non-Stasis bridge

2014-08-19 Thread rmudgett
On Aug. 19, 2014, 12:29 p.m., opticron wrote: /branches/13/res/stasis/control.c, lines 824-826 https://reviewboard.asterisk.org/r/3920/diff/2/?file=66624#file66624line824 Drop the explicit locks and use ast_softhangup() instead since it locks chan for you. Actually, those two

Re: [asterisk-dev] [Code Review] 3923: CallerID: Fix parsing of malformed callerid strings

2014-08-19 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3923/#review13120 --- branches/1.8/main/callerid.c

Re: [asterisk-dev] [Code Review] 3915: AMI: Add AllVariables parameter to Status

2014-08-19 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3915/#review13121 --- Ship it! Minor existing documentation problem.

Re: [asterisk-dev] [Code Review] 3921: Stasis: Add missing information to blind transfer events

2014-08-19 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3921/#review13122 --- Ship it! Looks ok to me. - rmudgett On Aug. 19, 2014, 7:29

Re: [asterisk-dev] [Code Review] 3923: CallerID: Fix parsing of malformed callerid strings

2014-08-19 Thread opticron
On Aug. 19, 2014, 1:05 p.m., rmudgett wrote: branches/1.8/main/callerid.c, line https://reviewboard.asterisk.org/r/3923/diff/1/?file=66611#file66611line I am wondering if ast_callerid_parse() should be escaping the quotes at all. The job of ast_callerid_parse() is to

[asterisk-dev] Asterisk 11.12.0 Now Available

2014-08-19 Thread Asterisk Development Team
The Asterisk Development Team has announced the release of Asterisk 11.12.0. This release is available for immediate download at http://downloads.asterisk.org/pub/telephony/asterisk The release of Asterisk 11.12.0 resolves several issues reported by the community and would have not been possible

[asterisk-dev] Asterisk 12.5.0 Now Available

2014-08-19 Thread Asterisk Development Team
The Asterisk Development Team has announced the release of Asterisk 12.5.0. This release is available for immediate download at http://downloads.asterisk.org/pub/telephony/asterisk The release of Asterisk 12.5.0 resolves several issues reported by the community and would have not been possible

Re: [asterisk-dev] [Code Review] 3918: Testsuite: Add a test for ARI originate and continue functionality

2014-08-19 Thread Jonathan Rose
On Aug. 19, 2014, 11:51 a.m., opticron wrote: Both of these findings also apply to the test I based this on, so I'll fix these there as well. - Jonathan --- This is an automatically generated e-mail. To reply, visit:

Re: [asterisk-dev] [Code Review] 3918: Testsuite: Add a test for ARI originate and continue functionality

2014-08-19 Thread Jonathan Rose
On Aug. 19, 2014, 11:51 a.m., opticron wrote: /asterisk/trunk/tests/rest_api/channels/originate_then_continue/channel_originate.py, lines 20-24 https://reviewboard.asterisk.org/r/3918/diff/2/?file=66551#file66551line20 This should be done in the config. Nothing really happens in

Re: [asterisk-dev] [Code Review] 3918: Testsuite: Add a test for ARI originate and continue functionality

2014-08-19 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3918/ --- (Updated Aug. 19, 2014, 5:15 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3920: Fix after bridge behavior when channel moves from a Stasis bridge to a non-Stasis bridge

2014-08-19 Thread Mark Michelson
On Aug. 19, 2014, 5:29 p.m., opticron wrote: /branches/13/res/stasis/control.c, lines 824-826 https://reviewboard.asterisk.org/r/3920/diff/2/?file=66624#file66624line824 Drop the explicit locks and use ast_softhangup() instead since it locks chan for you. rmudgett wrote: