---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4554/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24917
George Joseph wrote:
The fact that it goes to unavailable would be a bug. Why does it do so?
Mark should probably chime in here but I think it's because the
earliest you could get a response from pjsip when a contact isn't
reachable is the unconfigurable 32 seconds. As I said that's a long
snip all the things
G, it requires an rdata. I'll ponder further.
--
Joshua Colp
Digium, Inc. | Senior Software Developer
445 Jan Davis Drive NW - Huntsville, AL 35806 - US
Check us out at: www.digium.com www.asterisk.org
--
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4554/
---
(Updated March 29, 2015, 12:46 a.m.)
Review request for Asterisk
On March 29, 2015, 1:49 a.m., Diederik de Groot wrote:
The fixes for unused-value to chan_iax2, to compile smoothly should be seen as
a showcase that this can be off potential benefit. Would have been nice if
ao2_ref(..., -1) would have behaved in the same way, so that ao2_ref(..., -1)
Corey Farrell has uploaded a new patch set (#3).
Change subject: Memory Debugging Improvements
..
Memory Debugging Improvements
* Enable XML output from valgrind.
* Display and save a summary of valgrind errors and leaks.
*
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4554/
---
(Updated March 29, 2015, 1:44 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4554/#review14952
---
/branches/13/channels/chan_iax2.c
George Joseph wrote:
I've been trying to figure out how to get more control of the
pjsip_options qualify process. Specifically, how to get a timely
positive indication of failure and how to generate events on a status
change.
Right now when a contact is qualified, it's immediately marked as
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4554/
---
(Updated March 28, 2015, 8:32 p.m.)
Review request for Asterisk
I've been trying to figure out how to get more control of the
pjsip_options qualify process. Specifically, how to get a timely
positive indication of failure and how to generate events on a status
change.
Right now when a contact is qualified, it's immediately marked as
UNAVAILABLE. If a
On Sat, Mar 28, 2015 at 6:48 PM, Joshua Colp jc...@digium.com wrote:
George Joseph wrote:
I've been trying to figure out how to get more control of the
pjsip_options qualify process. Specifically, how to get a timely
positive indication of failure and how to generate events on a status
On Sat, Mar 28, 2015 at 6:53 PM, Joshua Colp jc...@digium.com wrote:
snip all the things
G, it requires an rdata. I'll ponder further.
Eagerly awaiting the results of the ponder while continuing the
investigation myself.
--
Joshua Colp
Digium, Inc. | Senior Software Developer
445 Jan
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4543/#review14955
---
/branches/13/contrib/scan-build
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4543/
---
(Updated March 29, 2015, 5:18 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4543/
---
(Updated March 29, 2015, 5:01 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4543/#review14954
---
/branches/13/include/asterisk/utils.h
Ashley Sanders has uploaded a new change for review.
https://gerrit.asterisk.org/18
Change subject: stasis: set a channel variable on websocket disconnect error
..
stasis: set a channel variable on websocket disconnect error
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4543/
---
(Updated March 29, 2015, 4:57 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4554/#review14951
---
Work in Progress:
There are too many sources issues with
On March 27, 2015, 10:31 p.m., Matt Jordan wrote:
Why do we want to ignore unused-command-line-argument?
I'm not against it, just curious :-)
Diederik de Groot wrote:
Because it also checks all if the -I parameter is actually used. It will
generate a waring for almost every
On March 27, 2015, 8:26 a.m., Matt Jordan wrote:
I think your solution here is fine.
Diederik de Groot wrote:
Hi Matt, can i commit directly to the svn repository or does someone have
to do this for me.
Your 'ship it' gives the impression that i can. If so is there a
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4539/
---
(Updated March 28, 2015, 7:27 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4531/
---
(Updated March 28, 2015, 7:39 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4526/
---
(Updated March 28, 2015, 7:54 a.m.)
Status
--
This change has been
On March 28, 2015, 1:28 p.m., Diederik de Groot wrote:
/branches/13/configure.ac, lines 1179-1183
https://reviewboard.asterisk.org/r/4546/diff/2/?file=73163#file73163line1179
Test is not working as i hoped yet. Tests inside configure don't seem
to get optimized to the same level
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4546/#review14935
---
/branches/13/configure.ac
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4540/#review14938
---
Ship it!
Ship It!
- Matt Jordan
On March 27, 2015, 6:51
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4533/
---
(Updated March 28, 2015, 3:45 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4535/#review14937
---
Ship it!
I'd say close out the findings just so the review
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4533/
---
(Updated March 28, 2015, 3:43 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4546/#review14929
---
/branches/13/channels/pjsip/dialplan_functions.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4546/
---
(Updated March 28, 2015, 12:13 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4546/#review14933
---
/branches/13/configure.ac
On March 26, 2015, 5:57 p.m., Diederik de Groot wrote:
/branches/13/include/asterisk/strings.h, lines 1236-1237
https://reviewboard.asterisk.org/r/4535/diff/1/?file=72977#file72977line1236
Not 100% sure if this substition is correct. Please verify.
Well, it's correct, but odd.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4525/#review14939
---
Ship it!
I'd prefer promoting the variables in res_calendar
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4546/
---
(Updated March 28, 2015, 12:14 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4527/
---
(Updated March 28, 2015, 7:18 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4537/
---
(Updated March 28, 2015, 7:31 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4544/
---
(Updated March 28, 2015, 7:48 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4533/
---
(Updated March 28, 2015, 5:28 p.m.)
Review request for Asterisk
Corey Farrell has posted comments on this change.
Change subject: Memory Debugging Improvements
..
Patch Set 2:
(2 comments)
https://gerrit.asterisk.org/#/c/15/2/contrib/valgrind/text-summary.xsl
File
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4550/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24917
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4550/
---
(Updated March 28, 2015, 5:41 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4551/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24917
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4525/
---
(Updated March 28, 2015, 6:01 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4552/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24917
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4525/#review14948
---
/branches/13/apps/app_queue.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4533/
---
(Updated March 28, 2015, 3:54 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4547/#review14941
---
/branches/13/channels/chan_iax2.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4543/
---
(Updated March 28, 2015, 4:04 p.m.)
Review request for Asterisk
On March 28, 2015, 3:51 p.m., Matt Jordan wrote:
/branches/13/include/asterisk/utils.h, line 1055
https://reviewboard.asterisk.org/r/4543/diff/1/?file=73018#file73018line1055
I don't have any problem with the actual fix here, but I don't think we
should change the parameter name
On March 28, 2015, 3:59 p.m., Matt Jordan wrote:
/branches/13/channels/chan_iax2.c, lines 7674-7676
https://reviewboard.asterisk.org/r/4547/diff/1/?file=73110#file73110line7674
I really dislike this warning.
In C, it has always been perfectly valid to initialize all
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4543/#review14940
---
/branches/13/include/asterisk/utils.h
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4533/
---
(Updated March 28, 2015, 3:56 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4543/
---
(Updated March 28, 2015, 4:01 p.m.)
Review request for Asterisk
On March 27, 2015, 8:23 a.m., Matt Jordan wrote:
/branches/13/pbx/pbx_config.c, lines 960-961
https://reviewboard.asterisk.org/r/4529/diff/2/?file=72981#file72981line960
Well, this won't quite work, as appdata can be NULL. strlen isn't NULL
safe.
As such, you'll need
On March 27, 2015, 2:23 p.m., Matt Jordan wrote:
/branches/13/pbx/pbx_config.c, lines 960-961
https://reviewboard.asterisk.org/r/4529/diff/2/?file=72981#file72981line960
Well, this won't quite work, as appdata can be NULL. strlen isn't NULL
safe.
As such, you'll need
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4529/
---
(Updated March 28, 2015, 4:08 p.m.)
Review request for Asterisk
Matt Jordan has posted comments on this change.
Change subject: Memory Debugging Improvements
..
Patch Set 2:
(2 comments)
https://gerrit.asterisk.org/#/c/15/2/contrib/valgrind/text-summary.xsl
File
On March 26, 2015, 11:57 p.m., Diederik de Groot wrote:
/branches/13/include/asterisk/strings.h, lines 1236-1237
https://reviewboard.asterisk.org/r/4535/diff/1/?file=72977#file72977line1236
Not 100% sure if this substition is correct. Please verify.
Matt Jordan wrote:
Well,
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4535/
---
(Updated March 28, 2015, 4:27 p.m.)
Review request for Asterisk
On March 25, 2015, 5:26 p.m., rmudgett wrote:
/trunk/main/db.c, lines 493-497
https://reviewboard.asterisk.org/r/4490/diff/1/?file=72613#file72613line493
Is clone ref leaked here?
Yup. I had initially used RAII_VAR here, and didn't complete the removal.
Thanks for catching that.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4533/
---
(Updated March 28, 2015, 6:28 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4543/#review14949
---
/branches/13/include/asterisk/utils.h
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4543/
---
(Updated March 28, 2015, 6:35 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4553/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24917
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4543/
---
(Updated March 28, 2015, 7:31 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4543/#review14950
---
/branches/13/include/asterisk/utils.h
On March 28, 2015, 4:31 a.m., Matt Jordan wrote:
Why do we want to ignore unused-command-line-argument?
I'm not against it, just curious :-)
Because it also checks all if the -I parameter is actually used. It will
generate a waring for almost every file compiled because of CFLAGS
70 matches
Mail list logo
