[asterisk-dev] [Code Review] 3573: [main/config.c] AMI action UpdateConfig EmptyCat clears all categories but the requested one

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3573/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23803 https://i

Re: [asterisk-dev] [Code Review] 3573: [main/config.c] AMI action UpdateConfig EmptyCat clears all categories but the requested one

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3573/#review11991 --- Ship it! This is also applicable to 1.8 and seems to have been

Re: [asterisk-dev] [Code Review] 3541: res_http_websocket: Create a websocket client

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3541/#review11992 --- Ship it! Ship It! - Joshua Colp On May 28, 2014, 10:58 p.m.

Re: [asterisk-dev] [Code Review] 3572: cli_aliases: Add 'pjsip reload' alias because it's nice. Plus, another for 11 syntax compatability.

> On May 28, 2014, 11:57 p.m., Paul Belanger wrote: > > I'm all for adding the pjsip reload, but the context changes in the > > template seem unnecessary and potentially break systems that depend on the > > default config files. > > Matt Jordan wrote: > Do you have an alternative to propos

Re: [asterisk-dev] [Code Review] 3541: res_http_websocket: Create a websocket client

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3541/#review11993 --- I didn't check all of it. trunk/include/asterisk/http.h

Re: [asterisk-dev] [Code Review] 3563: TALK_DETECT: A channel function that raises AMI/ARI events when talking is detected

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3563/#review11995 --- How do you foresee this being invoked for ARI? the existing cha

Re: [asterisk-dev] [Code Review] 3563: TALK_DETECT: A channel function that raises AMI/ARI events when talking is detected

> On May 29, 2014, 8:53 a.m., Joshua Colp wrote: > > /branches/12/funcs/func_talkdetect.c, line 260 > > > > > > Is it possible for another thread to jump in here and do the same thing? Certainly for another channel

Re: [asterisk-dev] [Code Review] 3563: TALK_DETECT: A channel function that raises AMI/ARI events when talking is detected

> On May 29, 2014, 8:53 a.m., Joshua Colp wrote: > > How do you foresee this being invoked for ARI? the existing channel > > variable stuff? Yup. Enabling an event to be emitted on a channel didn't feel worthy of a full operation on the channels resource - and implementing this as a function m

Re: [asterisk-dev] [Code Review] 3563: TALK_DETECT: A channel function that raises AMI/ARI events when talking is detected

> On May 29, 2014, 1:53 p.m., Joshua Colp wrote: > > How do you foresee this being invoked for ARI? the existing channel > > variable stuff? > > Matt Jordan wrote: > Yup. Enabling an event to be emitted on a channel didn't feel worthy of a > full operation on the channels resource - and im

Re: [asterisk-dev] [Code Review] 3563: TALK_DETECT: A channel function that raises AMI/ARI events when talking is detected

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3563/ --- (Updated May 29, 2014, 9:46 a.m.) Review request for Asterisk Developers.

[asterisk-dev] [Code Review] 3574: safe_asterisk: Cleanup and debian compatibility.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3574/ --- Review request for Asterisk Developers and Tzafrir Cohen. Bugs: ASTERISK-2

Re: [asterisk-dev] [Code Review] 3516: media_formats: Move chan_sip over.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3516/#review12000 --- Ship it! I think I've gone sufficiently blind looking at this.

Re: [asterisk-dev] [Code Review] 3506: format improvements: Port bridge_native_rtp over to new format capability API

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3506/ --- (Updated May 29, 2014, 12:02 p.m.) Status -- This change has been mar

Re: [asterisk-dev] [Code Review] 3572: cli_aliases: Add 'pjsip reload' alias because it's nice. Plus, another for 11 syntax compatability.

> On May 28, 2014, 11:57 p.m., Paul Belanger wrote: > > I'm all for adding the pjsip reload, but the context changes in the > > template seem unnecessary and potentially break systems that depend on the > > default config files. > > Matt Jordan wrote: > Do you have an alternative to propos

Re: [asterisk-dev] [Code Review] 3541: res_http_websocket: Create a websocket client

> On May 29, 2014, 8:07 a.m., wdoekes wrote: > > trunk/include/asterisk/http.h, lines 271-272 > > > > > > This is case sensitive, > > > > while ast_http_header_match is sensitive. > > > > I don't s

Re: [asterisk-dev] [Code Review] 3541: res_http_websocket: Create a websocket client

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3541/ --- (Updated May 29, 2014, 1:07 p.m.) Review request for Asterisk Developers a

Re: [asterisk-dev] [Code Review] 3512: media formats: Convert the translation core over

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3512/#review12002 --- Ship it! Ship It! - Mark Michelson On May 8, 2014, 8:37 p.m

Re: [asterisk-dev] [Code Review] 3512: media formats: Convert the translation core over

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3512/ --- (Updated May 29, 2014, 2:37 p.m.) Status -- This change has been mark

[asterisk-dev] Asterisk 1.8.28.0 Now Available

The Asterisk Development Team has announced the release of Asterisk 1.8.28.0. This release is available for immediate download at http://downloads.asterisk.org/pub/telephony/asterisk The release of Asterisk 1.8.28.0 resolves several issues reported by the community and would have not been possible

[asterisk-dev] Asterisk 11.10.0 Now Available

The Asterisk Development Team has announced the release of Asterisk 11.10.0. This release is available for immediate download at http://downloads.asterisk.org/pub/telephony/asterisk The release of Asterisk 11.10.0 resolves several issues reported by the community and would have not been possible w

[asterisk-dev] Asterisk 12.3.0 Now Available

The Asterisk Development Team has announced the release of Asterisk 12.3.0. This release is available for immediate download at http://downloads.asterisk.org/pub/telephony/asterisk The release of Asterisk 12.3.0 resolves several issues reported by the community and would have not been possible wit

Re: [asterisk-dev] Sip call consciously without audio

On 2014-05-28 17:46, Matthew Jordan wrote: On Tue, May 27, 2014 at 4:59 PM, Gunnar Hellstrom wrote: On 2014-05-25 21:33, Gunnar Hellstrom wrote: Hi, chan-sip.c in release 11 and 12 is dropping sip calls in which no common audio media is negotiated, regardless of if other media are negotiated.

Re: [asterisk-dev] [Code Review] 3541: res_http_websocket: Create a websocket client

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3541/#review12003 --- Ship it! Looks mostly good. A few minor points below. trunk/

Re: [asterisk-dev] [Code Review] 3541: res_http_websocket: Create a websocket client

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3541/ --- (Updated May 29, 2014, 4:14 p.m.) Review request for Asterisk Developers a

Re: [asterisk-dev] [Code Review] 3563: TALK_DETECT: A channel function that raises AMI/ARI events when talking is detected

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3563/#review12005 --- Ship it! Ship It! - Kevin Harwell On May 29, 2014, 9:46 a.m

Re: [asterisk-dev] [Code Review] 3564: TALK_DETECT: Tests for Asterisk Test Suite

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3564/#review12004 --- Ship it! /asterisk/trunk/tests/funcs/func_talkdetect/talk_det

Re: [asterisk-dev] [Code Review] 3541: res_http_websocket: Create a websocket client

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3541/#review12007 --- Yay for tests! (And the other changes look good. You still hav

Re: [asterisk-dev] [Code Review] 3564: TALK_DETECT: Tests for Asterisk Test Suite

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3564/#review12006 --- Ship it! /asterisk/trunk/tests/funcs/func_talkdetect/talk_det

Re: [asterisk-dev] [Code Review] 3537: chan_sip+CEL: Add missing ANSWER and PICKUP events to INVITE/w/replaces pickup (for asterisk 12)

> On May 22, 2014, 2:12 p.m., Matt Jordan wrote: > > /branches/12/channels/chan_sip.c, lines 25146-25151 > > > > > > Not a finding, just a thought for your testing. > > > > Under the hood, ast_do_pickup w

[asterisk-dev] [Code Review] 3575: config: Fix config files not reloading when only an included file changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3575/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23683 https://i

Re: [asterisk-dev] [Code Review] 3575: config: Fix config files not reloading when only an included file changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3575/ --- (Updated May 29, 2014, 5:11 p.m.) Review request for Asterisk Developers.

[asterisk-dev] [Code Review] 3576: astobj2: Split hash and rbtree impls into their own source files.

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3576/ --- Review request for Asterisk Developers and rmudgett. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3563: TALK_DETECT: A channel function that raises AMI/ARI events when talking is detected

> On May 29, 2014, 8:53 a.m., Joshua Colp wrote: > > /branches/12/funcs/func_talkdetect.c, line 70 > > > > > > It may be worthwhile adding some information about using this with the > > AGC and DENOISE dialplan func