Re: Setting tx retry count in ath10k

2018-07-19 Thread Toke Høiland-Jørgensen
Benjamin Beichler writes: >>> For general internet traffic, a retry count of 30 is way too high; that >>> is up to 120 ms of HOL blocking latency. Better to just drop the packet >>> at that point. >>> >>> Ideally, the retry count should be dynamically calculated in units of >>> time (which would

Re: Setting tx retry count in ath10k

2018-07-19 Thread Ben Greear
On 07/19/2018 05:39 AM, Benjamin Beichler wrote: Am 18.07.2018 um 19:01 schrieb Jean-Pierre TOSONI: Hi Ben, I attached the patch. Please remind that it applies to ath9k. At the end there are 3 comments in French, translation follows: 1) " longretry gives directly the transmit count, the +1

Re: Setting tx retry count in ath10k

2018-07-19 Thread Benjamin Beichler
Am 18.07.2018 um 19:01 schrieb Jean-Pierre TOSONI: > Hi Ben, > > I attached the patch. Please remind that it applies to ath9k. > > At the end there are 3 comments in French, translation follows: > 1) " longretry gives directly the transmit count, the +1 is useless. > Should rather have -1 to

RE: Setting tx retry count in ath10k

2018-07-18 Thread Toke Høiland-Jørgensen
Jean-Pierre TOSONI writes: > @Toke: As you can see in the patch, the value 30 was the fixed value > defined in ath9k, I kept it for compatibility only (and that's why I > wanted to make it configurable :-) Yup, I'm aware that this is the default from ath9k; doesn't make it any less wrong ;) >

RE: Setting tx retry count in ath10k

2018-07-18 Thread Jean-Pierre TOSONI
Greear; Jean-Pierre TOSONI; SEDE; Benjamin Beichler; ath10k; > linux-wirel...@vger.kernel.org > Objet : Re: Setting tx retry count in ath10k > > Ben Greear writes: > > > On 07/18/2018 08:50 AM, Jean-Pierre TOSONI wrote: > >> Hi, > >> > >> We mad

Re: Setting tx retry count in ath10k

2018-07-18 Thread Toke Høiland-Jørgensen
Ben Greear writes: > On 07/18/2018 08:50 AM, Jean-Pierre TOSONI wrote: >> Hi, >> >> We made retries configurable in our mac80211+ath9k system, and we ended with >> 3 counts: >> 1) short retry count, defaults to 4 >> 2) long retrys count, defauts to 7 >> 3) software retry count, defaults to 30

Re: Setting tx retry count in ath10k

2018-07-18 Thread Ben Greear
...@vger.kernel.org] De la part de Ben Greear Envoyé : mardi 17 juillet 2018 17:08 À : SEDE; Benjamin Beichler; ath10k; linux-wirel...@vger.kernel.org Objet : Re: Setting tx retry count in ath10k On 07/17/2018 12:56 AM, SEDE wrote: Hi, In the standard, 7 is the default for the short retry count, 4

RE: Setting tx retry count in ath10k

2018-07-18 Thread Jean-Pierre TOSONI
th10k; linux-wirel...@vger.kernel.org > Objet : Re: Setting tx retry count in ath10k > > > > On 07/17/2018 12:56 AM, SEDE wrote: > > Hi, > > > > In the standard, 7 is the default for the short retry count, 4 is well the > > default for long retry > count. >

Re: Setting tx retry count in ath10k

2018-07-17 Thread Ben Greear
On 07/17/2018 12:56 AM, SEDE wrote: Hi, In the standard, 7 is the default for the short retry count, 4 is well the default for long retry count. In ath10k, there is also non_agg_sw_retry_th to control this, will this still be used? Or what is the difference with rc_num_retries? Kind

Re: Setting tx retry count in ath10k

2018-07-17 Thread SEDE
Hi, In the standard, 7 is the default for the short retry count, 4 is well the default for long retry count. In ath10k, there is also non_agg_sw_retry_th to control this, will this still be used? Or what is the difference with rc_num_retries? Kind regards, Sébastien. On 2018-07-17 09:39,

Re: Setting tx retry count in ath10k

2018-07-17 Thread Benjamin Beichler
Hi, Am 17.07.2018 um 02:37 schrieb Ben Greear: > I spent a bit of time looking into setting the tx retry count in > ath10k (wave-1 firmware).  The firmware has support for setting this as > a vdev parameter, and it defaults to '2', at least in my wave-1 firmware. > > I enabled propagating the