Re: [PATCH] ath10k: improve channel switching

2014-08-02 Thread Kalle Valo
rid of the synchronization warnings/timeouts and makes channel switching smoother during traffic. Signed-off-by: Michal Kazior michal.kaz...@tieto.com Thanks, applied. -- Kalle Valo ___ ath10k mailing list ath10k@lists.infradead.org http

Re: Reporting firmware stats to ethtool

2014-08-08 Thread Kalle Valo
, but if someone feels otherwise, please let me know sooner than later. I also prefer to have this in user space, but how does user space know when the stats have been zeroed? -- Kalle Valo ___ ath10k mailing list ath10k@lists.infradead.org http

Re: [RFC 3/3] ath10k: make target endianess more explicit

2014-08-08 Thread Kalle Valo
= DRAM_BASE_ADDRESS) - return ath10k_pci_diag_read_mem(ar, address, data, sizeof(u32)); + if (address = DRAM_BASE_ADDRESS) { + __le32 val; + int ret; For simplicity I would prefer to have variable declaration in the beginning of the function. -- Kalle Valo

crash in ath10k_spectral_destroy()

2014-08-08 Thread Kalle Valo
0xc100 (relocation range: 0xc000-0xf7ffdfff) [ 192.654019] drm_kms_helper: panic occurred, switching back to text console [ 192.659628] Rebooting in 10 seconds.. [ 202.684887] ACPI MEMORY or I/O RESET_REG. -- Kalle Valo ___ ath10k mailing

[PATCH v5 1/7] ath10k: add ath10k_pci_diag_* helpers

2014-08-08 Thread Kalle Valo
ath10k_pci_diag_read32() is for reading u32 from a device and ath10k_pci_diag_read_hi() is a helper for reading data using host interest table. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/pci.c | 55 +++-- 1 file changed, 38

[PATCH v5 6/7] ath10k: save firmware RAM and ROM BSS sections on crash

2014-08-08 Thread Kalle Valo
. This requires a packaged firmware with a new IE to describe the BSS section starts and length. Signed-off-by: Ben Greear gree...@candelatech.com Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/core.c | 54 +++ drivers/net/wireless/ath

[PATCH v5 7/7] ath10k: rename ath10k_pci_hif_dump_area() to ath10k_pci_firmware_crashed()

2014-08-08 Thread Kalle Valo
Better to have a clear name for the function. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/pci.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c

Re: Reporting firmware stats to ethtool

2014-08-09 Thread Kalle Valo
restart, ie. through ieee80211_restart_hw(). ath10k does use ieee80211_restart_hw(). If only user-space could get that info. Yeah, that would be nice to have for ath10k firmware crash dump functionality. And doesn't Android also need something similar? -- Kalle Valo

Re: [PATCH 0/6] ath10k: fixes 2014-08-07, part 1

2014-08-12 Thread Kalle Valo
code ath10k: remove pci features var ath10k: group some pci probing helpers ath10k: remove htc-stopped Thanks, these five patches applied. ath10k: move fw init print I dropped this one as I think it's buggy. -- Kalle Valo ___ ath10k

Re: [PATCH 6/6] ath10k: move fw init print

2014-08-14 Thread Kalle Valo
Kalle Valo kv...@qca.qualcomm.com writes: Michal Kazior michal.kaz...@tieto.com writes: Firmware probing is done only once when driver is registered and firmware version is guaranteed to remain the same until driver is unregistered. Signed-off-by: Michal Kazior michal.kaz...@tieto.com

Re: [PATCH 4/5] ath10k: split ce irq/handler setup

2014-08-14 Thread Kalle Valo
pointers? What if we just call the functions directly? -- Kalle Valo ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH] ath10k: unregister spectral before mac

2014-08-14 Thread Kalle Valo
Simon Wunderlich s...@simonwunderlich.de writes: On Thursday 14 August 2014 13:12:13 Kalle Valo wrote: Simon Wunderlich s...@simonwunderlich.de writes: If spectral is unregistered after mac80211, the relayfs file has already been removed recursively by mac/cfg80211, and spectral tries

Re: [PATCH v6 2/8] ath10k: provide firmware crash info via debugfs

2014-08-18 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: On 18 August 2014 13:39, Kalle Valo kv...@qca.qualcomm.com wrote: Michal Kazior michal.kaz...@tieto.com writes: On 9 August 2014 20:08, Kalle Valo kv...@qca.qualcomm.com wrote: +struct ath10k_dump_file_data { + /* dump file information

Re: Timeout Issues

2014-08-19 Thread Kalle Valo
board ath10k works with openwrt but with another distribution it fails? What's this another distribution? -- Kalle Valo ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH v8 2/4] ath10k: provide firmware crash info via debugfs

2014-08-25 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: On 21 August 2014 14:49, Kalle Valo kv...@qca.qualcomm.com wrote: +static struct ath10k_dump_file_data *ath10k_build_dump_file(struct ath10k *ar) +{ + struct ath10k_fw_crash_data *crash_data = ar-debug.fw_crash_data; + struct

Re: Malformed AddBA Response prevents clients from associating?

2014-08-25 Thread Kalle Valo
And then take the firmware from here: https://github.com/kvalo/ath10k-firmware/tree/master/10.2 Do not rename the firmware to firmware-2.bin or anything like that. To avoid problems keep the name firmware-3.bin. -- Kalle Valo ___ ath10k mailing list

Re: [PATCH v2 0/5] ath10k: fixes 2014-08-07, part 3

2014-08-25 Thread Kalle Valo
Michal Kazior (5): ath10k: rework posting pci rx buffers ath10k: update comment regarding warm reset ath10k: ignore ar_pci-started in pipe cleanup ath10k: remove ar_pci-started ath10k: flush hif buffers before recovery Thanks, all five patches applied. -- Kalle Valo

Re: [RFC] ath10k: improve logging to include dev id

2014-08-25 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: On 25 August 2014 11:18, Kalle Valo kv...@qca.qualcomm.com wrote: Michal Kazior michal.kaz...@tieto.com writes: This makes it a lot easier to log and debug messages if there's more than 1 ath10k device on a system. Signed-off-by: Michal Kazior

Re: [PATCH v2] ath10k: improve logging to include dev id

2014-08-26 Thread Kalle Valo
debug print after core is allocated [Kalle] Thanks, applied. I just folded the patch to fix the smatch warning about ret variable. -- Kalle Valo ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH] ath10k: fix fw crash dumping

2014-08-26 Thread Kalle Valo
10.1.467.2-1 api 2 htt 2.1 [ 793.89] ath10k: debug 0 debugfs 0 tracing 0 dfs 1 The report was missing register dump. Fix it by printing registers regardless if crash_data is present or not. Signed-off-by: Michal Kazior michal.kaz...@tieto.com Thanks, applied. -- Kalle Valo

Re: Malformed AddBA Response prevents clients from associating?

2014-08-26 Thread Kalle Valo
. There is a substantial amount of randomness, but it generally happens within 2 hours. So whatever this issue is, firmware 10.2 does appear to resolve it or at least make it way less likely to happen. That's good to hear, thanks for testing. -- Kalle Valo

Re: [PATCH v2 3/3] ath10k: make target endianess more explicit

2014-08-27 Thread Kalle Valo
what's the idea behind this? I would prefer that we get rid of all the ugly _access() functions in pci.c. -- Kalle Valo ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH v2 0/3] ath10k: ce fixes 2014-08-08

2014-08-27 Thread Kalle Valo
fixes in patch [3/3] (see notes there) Michal Kazior (3): ath10k: move pci init structures ath10k: dont duplicate service-pipe mapping ath10k: make target endianess more explicit Thanks, all three applied. -- Kalle Valo ___ ath10k mailing

Pull request: ath 20140827

2014-08-27 Thread Kalle Valo
module_usb_driver() Janusz Dziedzic (1): ath10k: extend debug code for RX path Kalle Valo (3): ath10k: add ath10k_pci_diag_* helpers ath10k: rename ath10k_pci_hif_dump_area() to ath10k_pci_fw_crashed_dump() ath10k: print more driver info when firmware crashes Michal

Re: [PATCH v3] ath10k: save firmware debug log messages.

2014-08-27 Thread Kalle Valo
int [unsigned] [usertype] first_idx drivers/net/wireless/ath/ath10k/debug.c:831:35:got restricted __le32 [usertype] noident -- Kalle Valo ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

BUG when doing rmmod

2014-08-28 Thread Kalle Valo
-0xf7ffdfff) [ 123.701676] drm_kms_helper: panic occurred, switching back to text console [ 123.706525] Rebooting in 10 seconds.. [ 133.730793] ACPI MEMORY or I/O RESET_REG. -- Kalle Valo ___ ath10k mailing list ath10k@lists.infradead.org http

[PATCH v2 1/2] ath10k: make ath10k_wmi_cmd_send() public

2014-08-28 Thread Kalle Valo
We need this function to send wmi packets from testmode.c. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/wmi.c |5 ++--- drivers/net/wireless/ath/ath10k/wmi.h |4 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net

Re: BUG when doing rmmod

2014-08-28 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: On 28 August 2014 08:58, Kalle Valo kv...@qca.qualcomm.com wrote: [ 123.552499] Call Trace: [ 123.554957] [fe576c1b] ath10k_pci_tasklet+0x1b/0x60 [ath10k_pci] [ 123.557436] [c1053fbe] tasklet_action+0x9e/0xb0 [ 123.559874] [c10534f1

ath.git master branch rebased to 3.17.0-rc2-wl-ath

2014-08-28 Thread Kalle Valo
Hi, as always after a merge window, I have rebased ath.git master branch to 3.17.0-rc2-wl-ath. So please be careful when updating it. -- Kalle Valo ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH] ath10k: add device/driver strings to tracepoints

2014-08-28 Thread Kalle Valo
://github.com/kvalo/ath/commit/d4bcfa9487e0837fdaf01645ade15acbadc3873c -- Kalle Valo ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH v2 2/2] ath10k: add testmode

2014-08-29 Thread Kalle Valo
Arend van Spriel ar...@broadcom.com writes: On 08/28/14 10:02, Kalle Valo wrote: Kalle Valokv...@qca.qualcomm.com writes: Johannes suggested to put this to a separate file as that way it's easier for the user space. In v3 I'm planning to create testmode_uapi.h for this. I suppose

Re: [PATCH v2 2/2] ath10k: add testmode

2014-08-29 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: On 28 August 2014 09:30, Kalle Valo kv...@qca.qualcomm.com wrote: @@ -2483,8 +2484,12 @@ static int ath10k_start(struct ieee80211_hw *hw) case ATH10K_STATE_RESTARTED: case ATH10K_STATE_WEDGED: WARN_ON(1

Re: [PATCH] ath10k: re-enable interrupts properly in hw recovery

2014-09-02 Thread Kalle Valo
...@tieto.com Thanks, applied. -- Kalle Valo ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH] ath10k: fix num_legacy_stations tracking

2014-09-02 Thread Kalle Valo
as enabled. Signed-off-by: Michal Kazior michal.kaz...@tieto.com Thanks, applied. -- Kalle Valo ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH] ath10k: kill tasklets after free_irq

2014-09-02 Thread Kalle Valo
] irq_exit+0x86/0xb0 ... [c132d522] do_pci_disable_device+0x52/0x60 [c132d57f] pci_disable_device+0x4f/0xb0 [c132a961] ? __pci_set_master+0x51/0x80 [fe5740b3] ath10k_pci_release+0x33/0x40 [ath10k_pci] [fe575d4b] ath10k_pci_remove+0x7b/0x90 [ath10k_pci] Reported-by: Kalle Valo kv

Re: [PATCH 0/2] ath10k: monitor fixes

2014-09-02 Thread Kalle Valo
. -- Kalle Valo ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH] ath10k: remove diag_*_access functions

2014-09-02 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: Remove the ugly _access functions. Being explicit is a good thing. Signed-off-by: Michal Kazior michal.kaz...@tieto.com Thanks, applied. -- Kalle Valo ___ ath10k mailing list ath10k

Re: [PATCH] ath10k: don't access tx_info while overwriting it

2014-09-02 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: Nothing important was being overwritten so it didn't yield any bugs yet. Signed-off-by: Michal Kazior michal.kaz...@tieto.com Thanks, applied. -- Kalle Valo ___ ath10k mailing list ath10k

Re: [PATCH v5] ath10k: save firmware debug log messages.

2014-09-02 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: On 2 September 2014 15:38, Kalle Valo kv...@qca.qualcomm.com wrote: (Dropping linux-wireless) gree...@candelatech.com writes: From: Ben Greear gree...@candelatech.com They may be dumped through the firmware dump debugfs file. Signed-off

WMI version handling

2014-09-03 Thread Kalle Valo
a new firmware branch with significant changes or similar. And for backwards comptability we need to do so that ATH10K_FW_FEATURE_WMI_10X sets ATH10K_FW_WMI_VERSION_10_1 and ATH10K_FW_FEATURE_WMI_10_2 sets ATH10K_FW_WMI_VERSION_10_2. Thoughts? -- Kalle Valo

Re: [PATCH] ath10k: ATH10K_DEBUGFS depends on DEBUG_FS

2014-09-04 Thread Kalle Valo
check Documentation/SubmittingPatches and please resend. The safest way to submit a patch is to commit with 'git commit -s' and then submit the commit with 'git send-email'. But first do a trial run by submitting it to yourself. -- Kalle Valo ___ ath10k

[PATCH v3 1/2] ath10k: make ath10k_wmi_cmd_send() public

2014-09-04 Thread Kalle Valo
We need this function to send wmi packets from testmode.c. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/wmi.c |5 ++--- drivers/net/wireless/ath/ath10k/wmi.h |4 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net

[PATCH v3 2/2] ath10k: add testmode

2014-09-04 Thread Kalle Valo
. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/Makefile |1 drivers/net/wireless/ath/ath10k/core.c | 88 -- drivers/net/wireless/ath/ath10k/core.h | 22 +- drivers/net/wireless/ath/ath10k/debug.c |5 drivers/net/wireless

Re: WMI version handling

2014-09-05 Thread Kalle Valo
of bounds. If we do that, it's a bug in ath10k. -- Kalle Valo ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

Re: WMI version handling

2014-09-05 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: On 3 September 2014 17:00, Ben Greear gree...@candelatech.com wrote: On 09/02/2014 11:14 PM, Kalle Valo wrote: Hi, [...] Also I have been thinking that using firmware feature bits (for example ATH10K_FW_FEATURE_WMI_10_2

Re: Firmware crash w/ 10.2 diagnosis?

2014-09-09 Thread Kalle Valo
be extra careful. Please note that updating backports is not enough for SO_WIFI_STATUS status, you need to update the kernel itself. -- Kalle Valo ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH] ath10k: move fw_crash_dump allocation

2014-09-10 Thread Kalle Valo
dereference at (null) [...] ---[ end Kernel panic - not syncing: Fatal exception in interrupt To prevent that split debug functions and allocate fw_crash_data earlier. Signed-off-by: Michal Kazior michal.kaz...@tieto.com Thanks, applied. -- Kalle Valo

Re: [PATCH] ath10k: use proper service bitmap size

2014-09-10 Thread Kalle Valo
...@tieto.com Thanks, applied. -- Kalle Valo ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH] ath10k: ATH10K_DEBUGFS depends on DEBUG_FS

2014-09-10 Thread Kalle Valo
Matteo Croce mat...@openwrt.org writes: ATH10K_DEBUGFS must depend on DEBUG_FS, otherwise ath10k will generate an invalid pointer on module load Signed-off-by: Matteo Croce mat...@openwrt.org Thanks, applied. -- Kalle Valo ___ ath10k mailing

Re: [PATCH v3 2/2] ath10k: add testmode

2014-09-10 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: (On 4 September 2014 15:56, Kalle Valo kv...@qca.qualcomm.com wrote: Add testmode interface for starting and using UTF firmware which is used to run factory tests. This is implemented by adding new state ATH10K_STATE_UTF and user space can

[PATCH v4 0/2] ath10k: testmode support

2014-09-10 Thread Kalle Valo
testmode %d in ath10k_print_driver_info() * don't call ath10k_wait_for_suspend() in UTF mode --- Kalle Valo (2): ath10k: make ath10k_wmi_cmd_send() public ath10k: add testmode drivers/net/wireless/ath/ath10k/Makefile |1 drivers/net/wireless/ath/ath10k/core.c | 88

[PATCH v4 1/2] ath10k: make ath10k_wmi_cmd_send() public

2014-09-10 Thread Kalle Valo
We need this function to send wmi packets from testmode.c. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/wmi.c |5 ++--- drivers/net/wireless/ath/ath10k/wmi.h |4 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net

[PATCH v4 2/2] ath10k: add testmode

2014-09-10 Thread Kalle Valo
. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/Makefile |1 drivers/net/wireless/ath/ath10k/core.c | 88 -- drivers/net/wireless/ath/ath10k/core.h | 22 +- drivers/net/wireless/ath/ath10k/debug.c |5 drivers/net/wireless

Re: [PATCH] ath10k: Support firmware crash-by-assert.

2014-09-10 Thread Kalle Valo
would actually prefer to have this in debug.c. With my patch ath10k: make ath10k_wmi_cmd_send() public that's possible now. I can do the changes and will send v2 shortly. Just need to test it first. -- Kalle Valo ___ ath10k mailing list ath10k

[PATCH v2] ath10k: support firmware crash-by-assert

2014-09-10 Thread Kalle Valo
in different manners, so this will help the crash-report testing as well as offer better ways to test firmware failure and recovery. kvalo: move the wmi command creation to debug.c, modify the info print Signed-off-by: Ben Greear gree...@candelatech.com Signed-off-by: Kalle Valo kv...@qca.qualcomm.com

Re: [PATCH v3] ath10k: fix debugfs_create_dir() checking

2014-09-10 Thread Kalle Valo
paragraph like you recommended. Also I had a conflict with this patch, please double check my resolution in ath-next-test: https://github.com/kvalo/ath/commit/bee6d655eefe488b76998c9c0018a4e6b0828de6 -- Kalle Valo ___ ath10k mailing list ath10k

Re: [PATCH v4 2/2] ath10k: add testmode

2014-09-11 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: On 10 September 2014 17:23, Kalle Valo kv...@qca.qualcomm.com wrote: [...] Just a small nitpick: +static int ath10k_tm_cmd_utf_stop(struct ath10k *ar, struct nlattr *tb[]) +{ + int ret; + + ath10k_dbg(ar, ATH10K_DBG_TESTMODE

Re: [RFC] ath10k: use raw tx

2014-09-11 Thread Kalle Valo
software crypto for tx entirely on host. BTW, it would be nice to get software crypto support to ath10k, for example with a nohwcrypt module parameter like ath9k has. -- Kalle Valo ___ ath10k mailing list ath10k@lists.infradead.org http

[RFC PATCH 1/3] ath10k: ignore diagnose pipes in ath10k_pci_ce_recv_data()/_send_done()

2014-09-11 Thread Kalle Valo
As ath10k_pci_diag_read_mem() uses polling to receive data from CE, the CE callbacks have to ignore the pipe used for diagnose reads. Otherwise ath10k crashes due to NULL dereference and polling reads timeout. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k

Re: [PATCH v4 0/2] ath10k: testmode support

2014-09-11 Thread Kalle Valo
Kalle Valo kv...@qca.qualcomm.com writes: latest version of my testmode patches. Getting closer, more or less cosmetic changes this time :) [...] Kalle Valo (2): ath10k: make ath10k_wmi_cmd_send() public ath10k: add testmode Applied, with an addition of the small change

Re: [PATCH v2] ath10k: support firmware crash-by-assert

2014-09-11 Thread Kalle Valo
Kalle Valo kv...@qca.qualcomm.com writes: From: Ben Greear gree...@candelatech.com 10.1 firmware does not have an official way to cause assert on purpose, but it can be done with carefully crafted WMI command. This is a different kind of crash from the 'hard' crash, which is a bad memory

Re: [RFC PATCH 2/3] ath10k: add diag_read() to hif ops

2014-09-12 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: On 11 September 2014 22:31, Kalle Valo kv...@qca.qualcomm.com wrote: diag_read() is used for reading from firmware memory via the diagnose window. First user will be cal_data debugfs file. [...] diff --git a/drivers/net/wireless/ath/ath10k/pci.c

Re: [RFC PATCH 3/3] ath10k: add cal_data debugfs file

2014-09-12 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: On 11 September 2014 22:31, Kalle Valo kv...@qca.qualcomm.com wrote: Provide calibration data used by the firmware to user space via a debugfs file. This makes it easier to debug calibration related problems. Example: sudo cp /sys/kernel

Re: [RFC PATCH 3/3] ath10k: add cal_data debugfs file

2014-09-12 Thread Kalle Valo
Ben Greear gree...@candelatech.com writes: On 09/11/2014 01:31 PM, Kalle Valo wrote: Provide calibration data used by the firmware to user space via a debugfs file. This makes it easier to debug calibration related problems. Example: sudo cp /sys/kernel/debug/ieee80211/phy0/ath10k

[PATCH 05/10] ath10k: fix space after a cast style errors

2014-09-14 Thread Kalle Valo
Fixes checkpatch warnings: CHECK: No space is necessary after a cast Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/pci.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers

[PATCH 01/10] ath10k: fix parenthesis alignment warning in ath10k_htt_rx_alloc()

2014-09-14 Thread Kalle Valo
Fixes checkpatch warning: ath10k/htt_rx.c:519: CHECK: Alignment should match open parenthesis Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/htt_rx.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath

[PATCH 00/10] ath10k: checkpatch fixes from v3.17

2014-09-14 Thread Kalle Valo
Hi, some fixes to recently added checkpatch warnings. Please review. Kalle --- Kalle Valo (10): ath10k: fix parenthesis alignment warning in ath10k_htt_rx_alloc() ath10k: fix checkpatch warnings about parenthesis alignment ath10k: fix use of multiple blank lines ath10k

[PATCH 08/10] ath10k: miscellaneous checkpatch fixes

2014-09-14 Thread Kalle Valo
: Unnecessary parentheses around htt-rx_ring.alloc_idx.vaddr ath10k/htt_rx.c:173: CHECK: Unnecessary parentheses around htt-rx_ring.alloc_idx.vaddr ath10k/pci.c:633: WARNING: macros should not use a trailing semicolon ath10k/wmi.c:3594: WARNING: quoted string split across lines Signed-off-by: Kalle

Re: Hard lockup during vif restart tests.

2014-09-18 Thread Kalle Valo
probing/bootup). It's just simpler to reboot firmware on drv_stop/start(). And there's the reliability issue. Being able to reset the firmware with interface down/up sequency is pretty useful and AFAIK almost all upstream drivers do that. And let's not forget power consumption either. -- Kalle Valo

Re: [PATCH 6/9] ath10k: deduplicate wmi service ready logic

2014-09-19 Thread Kalle Valo
? -- Kalle Valo ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH 2/3] ath10k: dump hex bytes with dev string prefix

2014-09-22 Thread Kalle Valo
: , prefix ? prefix : , (unsigned int)(ptr - buf)); -- Kalle Valo ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH 2/3] ath10k: dump hex bytes with dev string prefix

2014-09-22 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: On 22 September 2014 12:52, Kalle Valo kv...@qca.qualcomm.com wrote: Michal Kazior michal.kaz...@tieto.com writes: - print_hex_dump_bytes(prefix, DUMP_PREFIX_OFFSET, buf, len); + for (ptr = buf; (ptr - buf) len; ptr += 16

Re: [PATCH 1/3] ath10k: use 64-bit vdev map.

2014-09-23 Thread Kalle Valo
; [...] - arvif-vdev_id = bit - 1; + ath10k_warn(ar, Creating vdev id: %i map: %llu\n, + bit, ar-free_vdev_map); + + arvif-vdev_id = bit; Why remove the - 1? Are you sure that's not going to break any assumptions somewhere? -- Kalle Valo

Re: [PATCH 1/2] ath10k: make firmware text debug messages more verbose.

2014-09-23 Thread Kalle Valo
); This does not bring any extra value to normal users, it's only useful to firmware engineers. That's why it needs to stay as a debug message. Maybe we should add a new debug level just for these events, would that help? -- Kalle Valo ___ ath10k mailing list

Re: [PATCH 1/2] ath10k: save firmware stacks upon firmware crash

2014-09-23 Thread Kalle Valo
gree...@candelatech.com writes: From: Ben Greear gree...@candelatech.com Should help debug firmware crashes, and give users a way to provide some useful debug reports to firmware developers. Signed-off-by: Ben Greear gree...@candelatech.com Signed-off-by: Kalle Valo kv...@qca.qualcomm.com

[PATCH v3 3/3] ath10k: add cal_data debugfs file

2014-09-24 Thread Kalle Valo
Provide calibration data used by the firmware to user space via a debugfs file. This makes it easier to debug calibration related problems. Example: sudo cp /sys/kernel/debug/ieee80211/phy0/ath10k/cal_data 1.cal Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath

[PATCH v3 1/3] ath10k: don't enable interrupts for the diagnostic window

2014-09-24 Thread Kalle Valo
The diagnostic window (CE7) uses polling and is not initiliased to retrieve interrupts so disable interrupts altogether for CE7. Otherwise ath10k crashes when using the diagnostic window while the firmware is running due to NULL dereference and polling reads timeout. Signed-off-by: Kalle Valo kv

Re: [PATCH v2 01/10] ath10k: use 64-bit vdev map.

2014-10-01 Thread Kalle Valo
gree...@candelatech.com writes: From: Ben Greear gree...@candelatech.com This can allow more than 32 stations to be supported without over-running the bitmap. Signed-off-by: Ben Greear gree...@candelatech.com Thanks, I have applied this patch. -- Kalle Valo

Re: Unable to upgrade firmware for QCA988x module, ath10k!

2014-10-02 Thread Kalle Valo
. And if you want to run latest ath10k on an older kernel, you need to use backports: http://wireless.kernel.org/en/users/Drivers/ath10k/faq#How_can_I_run_latest_ath10k_on_older_kernels.3F -- Kalle Valo ___ ath10k mailing list ath10k@lists.infradead.org

ath10k: calibration data through Device Tree?

2014-10-02 Thread Kalle Valo
with Device Tree? Especially how to map the calibration data to correct PCI device? Are there any examples which would help us to implement this? -- Kalle Valo ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo

Re: ath10k: calibration data through Device Tree?

2014-10-02 Thread Kalle Valo
Kalle Valo kv...@qca.qualcomm.com writes: ath10k is a wireless driver for Qualcomm Atheros 802.11ac hardware and located in drivers/net/wireless/ath/ath10k/. Currently it only supports PCI devices. Great, I used an old address: 5.1.0 - Unknown address error 550-'5.1.6 devicetree-disc

ath10k: calibration data through Device Tree?

2014-10-02 Thread Kalle Valo
with Device Tree? Especially how to map the calibration data to correct PCI device? Are there any examples which would help us to implement this? -- Kalle Valo ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo

Re: ath10k: calibration data through Device Tree?

2014-10-02 Thread Kalle Valo
along those lines. I'd like to get a better understanding of the problem before we start figuring out how to pass an arbitrary blob of information around. I hope my answers helped. -- Kalle Valo ___ ath10k mailing list ath10k@lists.infradead.org http

Re: ath10k: calibration data through Device Tree?

2014-10-02 Thread Kalle Valo
Arnd Bergmann a...@arndb.de writes: On Thursday 02 October 2014 16:14:43 Kalle Valo wrote: Hi Device Tree gurus, ath10k is a wireless driver for Qualcomm Atheros 802.11ac hardware and located in drivers/net/wireless/ath/ath10k/. Currently it only supports PCI devices. Some

Re: [PATCH v2 1/4] ath10k: Add support to configure pktlog filter

2014-10-06 Thread Kalle Valo
Rajkumar Manoharan rmano...@qti.qualcomm.com writes: On Mon, Oct 06, 2014 at 02:52:45PM +0300, Kalle Valo wrote: Rajkumar Manoharan rmano...@qti.qualcomm.com writes: Add support to configure packet log filters (tx, rx, rate control) via debugfs. To disable htt pktlog events set

Re: [PATCH v2] ath10k: add tracing for frame transmission

2014-10-07 Thread Kalle Valo
or ignore. -- Kalle Valo ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH v2] ath10k: add tracing for frame transmission

2014-10-07 Thread Kalle Valo
+ + skb_tailroom(msdu)); Why add skb_tailroom() to the length? I think that deserves a comment. -- Kalle Valo ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

Re: ath10k: calibration data through Device Tree?

2014-10-07 Thread Kalle Valo
on a real solution. I'm hoping to have ath10k support three different methods to get calibration data: 1) OTP (already supported) 2) Device Tree (under discussion) 3) from a file I'm hoping to send patches for 2) and 3) soon. -- Kalle Valo ___ ath10k

Re: [PATCH] ath10k: don't create bssid peer for ibss

2014-10-08 Thread Kalle Valo
Janusz Dziedzic janusz.dzied...@tieto.com writes: It's not really necessary to create bssid peer for bssid. Self-address peer is sufficient. This prevents some firmware revisions from crashing. Signed-off-by: Janusz Dziedzic janusz.dzied...@tieto.com Thanks, applied. -- Kalle Valo

Re: [PATCH] ath10k: advertise all possible firmware(-api) files

2014-10-08 Thread Kalle Valo
accessible from ram disk too, and this patch guarantee this. Signed-off-by: Bartosz Markowski bartosz.markow...@tieto.com Thanks, applied. -- Kalle Valo ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH] ath10k: fix WMI scan command length

2014-10-08 Thread Kalle Valo
ath10k_pci :02:00.0: failed to stop wmi scan: -11 ath10k_pci :02:00.0: failed to stop scan: -11 ath10k_pci :02:00.0: failed to start hw scan: -110 Signed-off-by: Janusz Dziedzic janusz.dzied...@tieto.com Thanks, applied. -- Kalle Valo

Re: [PATCH v2] ath10k: add tracing for frame transmission

2014-10-08 Thread Kalle Valo
Rajkumar Manoharan rmano...@qti.qualcomm.com writes: Add tracing support to forward management and data frames to user space for packet inspection. Signed-off-by: Rajkumar Manoharan rmano...@qti.qualcomm.com Thanks, applied. -- Kalle Valo

Re: [PATCH] ath10k: use bss_info as txpower source

2014-10-10 Thread Kalle Valo
...@tieto.com In ath-next-test there was a conflict in ath10k_bss_info_changed(). Please check my resolution: https://github.com/kvalo/ath/commit/86eea6fda33ce16a40f98d41c19ea4b0e157f5ba -- Kalle Valo ___ ath10k mailing list ath10k@lists.infradead.org http

[PATCH 3/3] ath10k: retrieve calibration data from file

2014-10-13 Thread Kalle Valo
an error message that no calibration data found and stop driver initialization for this device. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com --- drivers/net/wireless/ath/ath10k/core.c | 86 +++ drivers/net/wireless/ath/ath10k/core.h | 20 +++ drivers/net

[PATCH 0/3] ath10k: cal file support

2014-10-13 Thread Kalle Valo
Hi, this adds support for loading calibration data from a file as discussed some time ago. Please review. Kalle --- Kalle Valo (3): ath10k: add back enum ath10k_bus ath10k: refactor ath10k_init_download_firmware() ath10k: retrieve calibration data from file drivers/net

Re: [PATCH 2/3] ath10k: expose hw restart via debugfs

2014-10-13 Thread Kalle Valo
; request is not really very descriptive command. Maybe call it hw-restart because that's what it really does, right? -- Kalle Valo ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH] ath10k: add missing '\n' to warning and error messages

2014-10-21 Thread Kalle Valo
Kalle Valo kv...@qca.qualcomm.com writes: All warning and error messages should end with '\n', fix that. Signed-off-by: Kalle Valo kv...@qca.qualcomm.com Joe pointed out that I had missed a few, will send v2. -- Kalle Valo ___ ath10k mailing list

Re: [PATCH 0/3] ath10k: cal file support

2014-10-21 Thread Kalle Valo
Kalle Valo kv...@qca.qualcomm.com writes: this adds support for loading calibration data from a file as discussed some time ago. Please review. Kalle --- Kalle Valo (3): ath10k: add back enum ath10k_bus ath10k: refactor ath10k_init_download_firmware() ath10k: retrieve

Re: [PATCH] ath10k: use bss_info as txpower source

2014-10-21 Thread Kalle Valo
...@tieto.com Thanks, applied. -- Kalle Valo ___ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k

Re: [PATCH v2 3/3] ath10k: speed up hw recovery

2014-10-21 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: On 21 October 2014 10:17, Kalle Valo kv...@qca.qualcomm.com wrote: Michal Kazior michal.kaz...@tieto.com writes: In some cases hw recovery was taking an absurdly long time due to ath10k waiting for things that would never really complete

  1   2   3   4   5   6   7   8   9   10   >