Erik Stromdahl writes:
> I can't find patch 1/7...
Odd, apparently it didn't get delivered to ath10k list but did get to
linux-wireless. You can find the patch from linux-wireless patchwork:
https://patchwork.kernel.org/patch/9663097/
Also copying it below.
Kalle
Author: Kal
The real problem could be
anywhere.
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
More changes to Erik's SDIO patches. The biggest change in this round
is refactoring of the ugly ath10k_sdio_io() function.
Only compile tested, I don't have any SDIO boards at the moment.
Changes in v7:
* fix mutex unlock bug found by kbuild bot
* fix function rename mistake found by Ryan
* r
From: Erik Stromdahl
Changed ath10k_htc_notify_tx_completion and
ath10k_htc_process_trailer from static to non static.
These functions are needed by SDIO/mbox.
Signed-off-by: Erik Stromdahl
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/htc.c | 14 --
drivers
a bundle, which endpoint it belongs
to and how long it is.
Signed-off-by: Erik Stromdahl
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/htc.c | 95 -
drivers/net/wireless/ath/ath10k/htc.h | 30 +-
2 files changed, 120 insertions(+), 5
part of
the service connect, the get_default_pipe call is redundant
and was removed.
Signed-off-by: Erik Stromdahl
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/htc.c | 39 ++---
1 file changed, 17 insertions(+), 22 deletions(-)
diff --git a/drivers
ath10k_htc_control_rx_complete already is present
(only containing a warning message) there is no reason for not
using it (instead of having a special case for ep 0 in
ath10k_htc_rx_completion_handler).
Signed-off-by: Erik Stromdahl
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/htc.c
From: Erik Stromdahl
Debug masks for SDIO HIF layer.
Address definitions for SDIO/mbox based chipsets.
Augmented struct host_interest with more members.
Signed-off-by: Erik Stromdahl
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/core.h |3 ++
drivers/net/wireless/ath
From: Erik Stromdahl
Special BMI get target info function for SDIO.
Signed-off-by: Erik Stromdahl
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/bmi.c | 71
drivers/net/wireless/ath/ath10k/bmi.h |2 +
drivers/net/wireless/ath/ath10k
: Erik Stromdahl
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/core.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/core.c
b/drivers/net/wireless/ath/ath10k/core.c
index 23cf6b191770..9ae20680bcb6 100644
--- a
ned-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/htc.c | 28 ++--
drivers/net/wireless/ath/ath10k/htc.h |5 +
2 files changed, 27 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/htc.c
b/drivers/net/wireless/ath/ath10k/h
From: Erik Stromdahl
Extra initializations needed by all sdio boards.
Derived from qcacld.
Signed-off-by: Erik Stromdahl
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/core.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/drivers/net/wireless/ath
d for full functionality. For that reason
we print during initialisation:
WARNING: ath10k SDIO support is incomplete, don't expect anything to work!
Signed-off-by: Erik Stromdahl
[kv...@qca.qualcomm.com: refactoring, cleanup, commit log]
Signed-off-by: Kalle Valo
---
drivers/net/wire
Mohammed Shafi Shajakhan wrote:
> From: Mohammed Shafi Shajakhan
>
> In 'ath10k_ce_alloc_pipe' the compile time sanity check to
> ensure that there is sufficient buffers in CE4 for HTT Tx
> MSDU descriptors, but this did not take into account of the
> case with 'peer flow control' enabled, fix t
Simon Wunderlich wrote:
> From: Ben Greear
>
> Many chips support channels in licensed bands. Add support for those,
> along with a corresponding kernel config option to disable them by
> default. Note that these channels are not selectable even if the
> option has been compiled unless the user
ge. Actually in commit
7be52c03bbf7 we downgraded that error message to a debug message.
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
Mohammed Shafi Shajakhan wrote:
> From: Mohammed Shafi Shajakhan
>
> spectral_bin length (number of bins per fft sample) is usually
> a value where (2^n = value), n is an integer. All of the QCA99X0
> family of chipsets seems to report a spectral_bin length of
> 2^n + 'm' bytes, where m = 4, 12
ryan...@qti.qualcomm.com wrote:
> From: Ryan Hsu
>
> For QCA6174 hw3.0, since WLAN.RM.4.4-00022-QCARMSWPZ-2, it starts to
> support the board ID information from otp, with some devices released on
> the market that didn't calibrated with OTP, will have 0 for board ID
> information, which cause th
Simon Wunderlich wrote:
> Introduce a debugfs option to manually override the noise floor,
> ignoring the automatically tuned noise floor of the driver/hw.
>
> In my tests with a AR9580 based module and a tx99 5 MHz interferer,
> I could tune the noisefloor to -95 dBm or above to allow communicat
Mohammed Shafi Shajakhan wrote:
> From: Mohammed Shafi Shajakhan
>
> As per latest regulatory update for India, channel 52, 56, 60, 64
> is no longer restricted to DFS. Enabling DFS/no infra flags in driver
> results in applying all DFS related restrictions (like doing CAC etc
> before this chan
2
> [9.739549] ath10k_pci :00:00.0: otp calibration failed: 2
This is the problem, otp.bin fails to find your calibration data from
the boards's OTP memory. Are you sure that the board has the calibration
data in OTP?
What kernel is this? Something from openwrt? And what device?
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
ENTID:
> case WMI_10_2_WDS_PEER_EVENTID:
> ath10k_dbg(ar, ATH10K_DBG_WMI,
>"received event id %d not implemented\n", id);
> break;
Yes, it's harmless but ath10k should not print that warning to not
distract the user
tant, like "10.1.2.3-4" or something like that.
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
Kalle Valo writes:
> ryan...@qti.qualcomm.com wrote:
>> From: Ryan Hsu
>>
>> For QCA6174 hw3.0, since WLAN.RM.4.4-00022-QCARMSWPZ-2, it starts to
>> support the board ID information from otp, with some devices released on
>> the market that didn't calibra
a 9886/8 system available for testing at the moment.
I got some updated to ath10k-firmware.git some time ago. Please check
and let me know if something is still missing.
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
arch I should have done prior to ordering, hehe) - I
> found out that only PCI seems to be supported (?)
Erik is working on adding USB support to ath10k (iirc he uses that
dongle for testing) and he has a kernel tree on github which has all the
patches. Search the archives of this list for
Michael Mera wrote:
> During write to debugfs file simulate_fw_crash, fixed-size local buffer
> 'buf' is accessed and modified at index 'count-1', where 'count' is the
> size of the write (so potentially out of bounds).
> This patch fixes this problem.
>
> Signed-off-by: Michael Mera
I fixed a
Michael Mera writes:
> Kalle Valo writes:
>> I fixed a checkpatch warning in the pending branch:
>>
>> drivers/net/wireless/ath/ath10k/debug.c:636: spaces preferred around
>> that '-' (ctx:VxV)
>
> Hum... but then you will have a line longer than 8
"KAVITA MATHUR" writes:
> Is anyone tested MCS32 or HT-duplicate mode using ath10k driver on Atheros
> chipsets?
To my knowledge the chip does not support MCS32 or HT-duplicate mode.
--
Kalle Valo
___
ath10k mailing list
ath10k@lis
Kalle Valo wrote:
> From: Erik Stromdahl
>
> Changed ath10k_htc_notify_tx_completion and
> ath10k_htc_process_trailer from static to non static.
>
> These functions are needed by SDIO/mbox.
>
> Signed-off-by: Erik Stromdahl
> Signed-off-by: Kalle Valo
10 patches
Michael Mera wrote:
> During write to debugfs file simulate_fw_crash, fixed-size local buffer
> 'buf' is accessed and modified at index 'count-1', where 'count' is the
> size of the write (so potentially out of bounds).
> This patch fixes this problem.
>
> Signed-off-by: Michael Mera
Patch appl
ryan...@qti.qualcomm.com wrote:
> From: Ryan Hsu
>
> QCA9xxx and QCA61x4/QCA93xx are using different wmi operation, in order
> for userspace to differentiate it, appends the wmi_op_version information
> alone with the get_version command.
>
> Signed-off-by: Ryan Hsu
Patch applied to ath-next b
Christian Lamparter wrote:
> The 10.4 firmware adds extended peer information to the
> firmware's statistics payload. This additional info is
> stored as a separate data field. During review of
> "ath10k: add accounting for the extended peer statistics" [0]
>
> Mohammed Shafi Shajakhan commented
derstand the commit log, especially what does "The name of an
array used by itself" mean?
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
Arend Van Spriel writes:
> On 9-5-2017 7:33, Kalle Valo wrote:
>> "Gustavo A. R. Silva" writes:
>>
>>> The name of an array used by itself will always return the array's address.
>>> So these tests will always evaluate as false and t
nel exactly?
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
Su Kang Yin writes:
> On 11 May 2017 at 11:55, Kalle Valo wrote:
>> Su Kang Yin writes:
>>
>>> Without this patch QCA9888 is not working. Also I have to update
>>> board2.bin from Kalle's git repo.
>>
>> More details would be good to know, a
asy.
So the way I see this is that the risks outweigh the benefits and that's
why I do not want to take these. Sorry.
[1] https://patchwork.kernel.org/patch/9641105/
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
le
helping that way, Adrian already expressed his interest which is very
cool and others have been also asking especially SDIO support. And with
good luck there are just small fixes needed to SDIO and USB properly
working.
Let's just clearly document that SDIO and USB support is w
inciple the split
sounds like a good idea. Just try to keep the size of patchsets
reasonable, a maximum of about a dozen (dependent) patches per set is a
good rule of thumb.
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
32:01 2015 +0100
ath10k: do not use coherent memory for allocated device memory chunks
Coherent memory is more expensive to allocate (and constrained on some
architectures where it has to be pre-allocated). It is also completely
unnecessary, since the host has no reason to even ac
0
[ 845.221149] ? process_one_work+0x7d0/0x7d0
[ 845.221175] ? kthread_create_on_node+0x40/0x40
[ 845.221205] ret_from_fork+0x31/0x40
[ 845.221314] Kernel Offset: 0xb00 from 0x8100 (relocation
range: 0x8000-0xbfff)
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
t;
>> -enum wmi_bss_survey_req_type type = WMI_BSS_SURVEY_REQ_TYPE_READ_CLEAR;
>> +enum wmi_bss_survey_req_type type = WMI_BSS_SURVEY_REQ_TYPE_READ;
>
> Does the firmware read the registers directly, or does it accumulate
> the results in a way that can&
hould match open
parenthesis
drivers/net/wireless/ath/ath10k/debug.c:2640: Alignment should match open
parenthesis
I fixed those in the pending branch:
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=bd8c3bdce70adc201037b2
thesis
drivers/net/wireless/ath/ath10k/debug.c:2640: Alignment should match open
parenthesis
I fixed those in the pending branch:
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=bd8c3bdce70adc201037b2eb7eda0a83911ef375
I'll look at this more closely
Ben Greear wrote:
> From: Ben Greear
>
> ath10k firmware checks nbytes == 0 as part of determining if DMA
> has completed successfully. To help make this work more often,
> have the driver initialize nbytes to zero when freeing the descriptor
> slot.
>
> Signed-off-by: Ben Greear
This patch
"Gustavo A. R. Silva" wrote:
> The array fields in struct wmi_start_scan_arg that are checked here are
> fixed size arrays so they can never be NULL.
>
> Addresses-Coverity-ID: 1260031
> Cc: Arend Van Spriel
> Cc: Kalle Valo
> Signed-off-by: Gustavo A. R. Si
Sven Eckelmann wrote:
> The QCA4019 firmware 10.4-3.2.1-00050 reports only HT MCS rates between
> 0-9. But 802.11n MCS rates can be larger than that. For example a 2x2
> device can send with up to MCS 15.
>
> The firmware encodes the higher MCS rates using the NSS field. The actual
> calculation
ocResp from 00:1a:1e:bb:2a:29 (capab=0x411
> status=0 aid=1)
> [ 337.858372] wlp2s0: associated
>From a quick look only suspicious I found was these disabling HT and VHT
messages. It might be that ath10k is not handling that case correctly.
Do you see these messages with ath10k when the connection works without
problems?
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
p being such a touchy issue. If it is though, using
> dma_alloc_coherent() use gets us access to the CMB APIs too relatively
> easily and ideally we would be allocating memory early in boot for
> exactly these reasons.
>
> Signed-off-by: Adrian Chadd
> Signed-off-by: Kalle Valo
P
> +#ifdef CONFIG_ATH10K_DEBUGFS
> +static ssize_t ath10k_write_debug_mask(struct file *file,
> +const char __user *ubuf,
> +size_t count, loff_t *ppos)
> +{
The ifdef looks wrong, it's already inside CONFI
it really needed to be able to filter trace messages? debug_mask
I understand, but not sure about trace_debug_mask.
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
xt.
> * Must be paired with napi_disable.
> */
> static inline void napi_enable(struct napi_struct *n)
> {
> BUG_ON(!test_bit(NAPI_STATE_SCHED, &n->state));
> smp_mb__before_atomic();
> clear_bit(NAPI_STATE_SCHED, &n->state);
> clear_bit(N
Ben Greear wrote:
> This lets one have a clue that maybe timeouts are happening
> when we just aren't waiting long enough.
>
> Signed-off-by: Ben Greear
> Signed-off-by: Kalle Valo
I did some cosmetic changes and ret is now initialised after the loop:
https://git.kern
d of disclaimer. The
patches must follow the Developer's Certificate of Origin[1] and not
have any other disclaimer.
[1]
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin
--
Kalle Valo
___
right now, and then we figure out how to
> express the smoothing in mac80211 or further up the layers?
I think this is a good approach.
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
s thinks, but in my opinion this kind of
smoothing should be in mac80211 and not in drivers. The driver should be
as simple as possible.
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
8185] ath10k_pci :05:00.0: bmi cmd took: 1986 jiffies (HZ:
> 1000), rv: 0
> [ 2277.294732] ath10k_pci :05:00.0: bmi cmd took: 1989 jiffies (HZ:
> 1000), rv: 0
>
> So, increase the BMI timeout to 3 seconds.
>
> Signed-off-by: Ben Greear
> Signed-off-by: Kalle V
Ben Greear wrote:
> ath10k firmware checks nbytes == 0 as part of determining if DMA
> has completed successfully. To help make this work more often,
> have the driver initialize nbytes to zero when freeing the descriptor
> slot.
>
> Signed-off-by: Ben Greear
> Sign
are used to get board id and
> applying calibration parameters from cal data.
>
> EEPROM[OTP] FLASH[DT/pre-cal file]
> Cal param 0x700 0x1
> Board id 0x100x8000
>
> Tested on QCA9888 with pre-cal file.
>
> Signed-off-by: A
handle the failure case, e.g disable the tdls peer, delete the
> peer and also vdev count cleanup.
>
> Signed-off-by: Ryan Hsu
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
9a993cc1ea95 ath10k: fix the logic of limiting tdls peer counts
--
http
called later. This was
just to match the symmetry with napi_disable() and fix the error
handling.
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
Arend van Spriel writes:
> On 31-05-17 14:16, Kalle Valo wrote:
>> Adrian Chadd writes:
>>
>>> This adds a few configurable debugging options:
>>>
>>> * driver debugging and tracing is now configurable per device
>>> * driver debugging a
age space or something else? Just curious.
So what's the most expensive part here, the actual function call to
ath10k_dbg() or va_start()/ve_end() within the function? And do you have
before and after throughput numbers for this? And maybe also with
CONFIG_ATH10K_DEBUG is
ecause
> the firmware would not have configured the rxnss_override.
>
> This could use some testing
>
> Signed-off-by: Ben Greear
> [sven.eckelm...@openmesh.com: rebase, cleanup, drop 160Mhz workaround cleanup]
> Signed-off-by: Sven Eckelmann
> Signed-off-by: Kalle Val
Sven Eckelmann wrote:
> QCA9888 supports VHT80 with 2x2. But it only support 1x1 with VHT160 or
> VHT80+80. Inform userspace and the the QCA firmware about that limitation
> whenever VHT80+80 or VHT160 is configured.
>
> Signed-off-by: Sven Eckelmann
> Signed-off-by: Kalle Va
code optimization and dynamic configuration of the copy engine
> register map for respective hardware bus interface.
>
> Signed-off-by: Sarada Prasanna Garnayak
> Signed-off-by: Kalle Valo
Like kbuild test robot reported, this failed to build. I fixed it like this in
ahb.c in p
Norik Dzhandzhapanyan wrote:
> Report per chain RSSI to mac80211.
>
> Signed-off-by: Norik Dzhandzhapanyan
> [kv...@qca.qualcomm.com: fix conflicts and style]
> Signed-off-by: Kalle Valo
This failed to apply and had quite a few checkpatch warnings. So I recreted the
patch m
code optimization and dynamic configuration of the copy engine
> register map for respective hardware bus interface.
>
> Signed-off-by: Sarada Prasanna Garnayak
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
03a016f8944c ath10k: define struct
Norik Dzhandzhapanyan wrote:
> Report per chain RSSI to mac80211.
>
> Signed-off-by: Norik Dzhandzhapanyan
> [kv...@qca.qualcomm.com: fix conflicts and style]
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
8241253d03fe ath10k: add per chain
break;
> + }
> + }
We have hw_params for stuff like this so I changed this and the
following patch to use that. Please review:
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=81f55f2a3e1837287a52de6577ca89a2c7393456
https://g
ptimise is hard to get right.
> That being said, any improvement is always welcome (even micro
> optimizations if they are beneficial). I will think about this and see
> if adding function pointers can be done in a nice way.
But are function p
0..) as a
> mask for this task doesn't make any sense. The correct mask for the VHT
> channel width should be used instead to make this check more readable.
>
> Signed-off-by: Ben Greear
> [sven.eckelm...@openmesh.com: separate 160Mhz workaround cleanup, add commit
> message]
&g
Signed-off-by: Kalle Valo
---
ath10k/QCA4019/hw1.0/board-2.bin | Bin 72788 -> 109172 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
diff --git a/ath10k/QCA4019/hw1.0/board-2.bin b/ath10k/QCA4019/hw1.0/board-2.bin
index
25d204295d532758730d6dc5957ac075bf486
Hi,
here's a set of firmware and board file updates for ath10k.
Kalle
Kalle Valo (12):
ath10k: QCA4019 hw1.0: update board-2.bin
ath10k: QCA4019 hw1.0: update firmware to 10.4-3.4-00082
ath10k: QCA6174 hw3.0: update board-2.bin
ath10k: QCA6174 hw3.0: add WLAN.RM.4.4-00022-QCARMS
Signed-off-by: Kalle Valo
---
ath10k/QCA6174/hw3.0/board-2.bin | Bin 361924 -> 477060 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
diff --git a/ath10k/QCA6174/hw3.0/board-2.bin b/ath10k/QCA6174/hw3.0/board-2.bin
index
ea18004951fed49aa9214093fa900427e4960
Signed-off-by: Kalle Valo
---
ath10k/QCA9377/hw1.0/board-2.bin | Bin 427668 -> 304308 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
diff --git a/ath10k/QCA9377/hw1.0/board-2.bin b/ath10k/QCA9377/hw1.0/board-2.bin
index
841456c9e982599fb4c3552d0ab28c62abc6f
Signed-off-by: Kalle Valo
---
ath10k/QCA9888/hw2.0/board-2.bin | Bin 12148 -> 72788 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
diff --git a/ath10k/QCA9888/hw2.0/board-2.bin b/ath10k/QCA9888/hw2.0/board-2.bin
index
4e808583314d05c917c664dd7433b81a39d5f
Signed-off-by: Kalle Valo
---
ath10k/QCA9984/hw1.0/board-2.bin | Bin 12144 -> 121264 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
diff --git a/ath10k/QCA9984/hw1.0/board-2.bin b/ath10k/QCA9984/hw1.0/board-2.bin
index
292b723da079e9b028fdfbb281ec8b513907a
Signed-off-by: Kalle Valo
---
WHENCE | 2 +-
ath10k/QCA988X/hw2.0/firmware-5.bin | Bin 248188 -> 249384 bytes
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/WHENCE b/WHENCE
index 33e23611be18..cb93391f44e0 100644
--- a/WHENCE
+++ b/WHENCE
@@ -263
Signed-off-by: Kalle Valo
---
LICENSE.QualcommAtheros_ath10k | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/LICENSE.QualcommAtheros_ath10k b/LICENSE.QualcommAtheros_ath10k
index 7fae6323f5df..c68935c11adf 100644
--- a/LICENSE.QualcommAtheros_ath10k
+++ b
Bhumika Goyal wrote:
> Declare thermal_cooling_device_ops structure as const as it is only passed
> as an argument to the function thermal_cooling_device_register and this
> argument is of type const. So, declare the structure as const.
>
> Signed-off-by: Bhumika Goyal
> Si
Colin Ian King wrote:
> Fix the following spelling mistakes in messages:
> syncronise -> synchronize
> unusally -> unusually
> addrress -> address
> inverval -> interval
>
> Signed-off-by: Colin Ian King
> Signed-off-by: Kalle Valo
Patch applied t
you are using XPS 13 I'm guessing it's one
of QCA6174 family.
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
I expect
> here (same as other params in this dbg info).
> Anyway I can return "out" here and initialize as empty before calling
> ath10k_get_tid().
IMHO return "" is more readable here.
>>> + is_multicast_ether_addr(iee
t have the Signed-off-by tag. Can you resend, please?
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
gree...@candelatech.com writes:
> From: Ben Greear
>
> Different firmware may support different numbers of
> vdevs. Use value that is always out of range for all
> firmware.
>
> Signed-off-by: Ben Greear
Thanks, applied.
--
Kalle Valo
_
oid *buf,
> + const struct wmi_peer_assoc_complete_arg
> *arg)
> +{
And this was too long. I "fixed" it by s/main_636/main/. I think the 636
part was a bit redundant anyway.
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
t; - ath10k_reset_scan((unsigned long)ar);
> ath10k_peer_cleanup_all(ar);
> ath10k_core_stop(ar);
> ath10k_hif_power_down(ar);
Why you don't call ath10k_scan_reset() here? I would have assumed that
you do that.
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
n more intense traffic was generated.
>
> Reported-by: Vu Hai NGUYEN
> Signed-off-by: Michal Kazior
Thanks, applied.
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
Janusz Dziedzic writes:
> Print sequence number, AMSDU_MORE flag and AC when additional
> debug enabled in RX path. This is usefull for debugging purpose.
>
> Signed-off-by: Janusz Dziedzic
Thanks, applied.
--
Kalle Valo
___
ath10k
need to work on this patch a little bit more and fix another
> corner case.
Ok, I'll drop this patch and wait for the next version.
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
;
> This gets rid of the synchronization
> warnings/timeouts and makes channel switching
> smoother during traffic.
>
> Signed-off-by: Michal Kazior
Thanks, applied.
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http
This introduces a new checkpatch warning:
drivers/net/wireless/ath/ath10k/wmi.h:214: ERROR: spaces required around that
':' (ctx:VxE)
But I think that's just a false warning and I should ignore it. Any
other ideas?
--
Kalle Valo
___
ath
.h has style problems, please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
ath10k: add spectral scan feature
>
> Sven Eckelmann (1):
> ath: Move spectral debugfs structs to shared header
Thanks, both patches applied.
And thanks for fixing a bug I introduced!
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
work_struct *work)
case ATH10K_STATE_ON:
ar->state = ATH10K_STATE_RESTARTING;
ath10k_scan_finish(ar);
+ ath10k_hif_stop(ar);
ieee80211_restart_hw(ar->hw);
break;
nce is to punt this to user-space, but if
> someone feels otherwise, please let me know sooner than later.
I also prefer to have this in user space, but how does user space know
when the stats have been zeroed?
--
Kalle Valo
___
ath10k
ou work on so I'm
> tentatively posting this as an RFC first.
Yeah, and I have done some ath10k_pci_diag_ changes in Ben's patches. It
would be easier if you could rebase your patches on top of ben's
firmware crash patches, which I should be able
undary */
> - if (address >= DRAM_BASE_ADDRESS)
> - return ath10k_pci_diag_read_mem(ar, address, data, sizeof(u32));
> + if (address >= DRAM_BASE_ADDRESS) {
> + __le32 val;
> + int ret;
For simplicity I would prefer to have
801 - 900 of 3044 matches
Mail list logo
