TR(WMI_SERVICE_SMART_ANTENNA_HW_SUPPORT);
default:
return NULL;
}
+
#undef SVCSTR
}
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
r)
+static void ath10k_pci_sleep(struct ath10k *ar)
{
ath10k_pci_reg_write32(ar, PCIE_SOC_WAKE_ADDRESS,
PCIE_SOC_WAKE_RESET);
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
FEATURE_MSI_X= 0,
> -
> - /* keep last */
> - ATH10K_PCI_FEATURE_COUNT
> -};
I wouldn't be too surprised if we need this again at some point. But we
can then add it back.
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
Michal Kazior writes:
> On 8 August 2014 12:45, Kalle Valo wrote:
>> Michal Kazior writes:
>>
>>> The soc powersave was disabled by default. It
>>> never was fully tested. Some hw apparently had
>>> problems with it and the implementation itself had
&g
d to have a checkpatch warning either way unless
> we don't use a macro at all.
Yeah. And it's not like that we need to have 0 checkpatch warnings. For
example, I already have a long list of errors I ignore:
MSLEEP,USLEEP_RANGE,PRINTK_WITHOUT_KERN_LEVEL,NETWORKING_BLOCK_COMME
conds..
[ 202.684887] ACPI MEMORY or I/O RESET_REG.
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
ath10k_pci_diag_read32() is for reading u32 from a device and
ath10k_pci_diag_read_hi()
is a helper for reading data using "host interest" table.
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/pci.c | 55 +++--
1 file changed, 38 inserti
log messages
ath10k: save firmware stack upon firmware crash
ath10k: dump exception stack contents on firmware crash
ath10k: save firmware RAM and ROM BSS sections on crash
Kalle Valo (2):
ath10k: add ath10k_pci_diag_* helpers
ath10k: rename ath10k_pci_hif_dump_area()
From: Ben Greear
Store the firmware crash registers and last 128 or so
firmware debug-log ids and present them to user-space
via debugfs.
Should help with figuring out why the firmware crashed.
Signed-off-by: Ben Greear
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/core.h
From: Ben Greear
Should help debug firmware crashes, and give users a way
to provide some useful debug reports to firmware developers.
Signed-off-by: Ben Greear
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/core.h |1 +
drivers/net/wireless/ath/ath10k/debug.c | 11
From: Ben Greear
They may be dumped through the firmware dump debugfs
file.
Signed-off-by: Ben Greear
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/wmi.c |6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/wireless/ath/ath10k/wmi.c
b/drivers/net/wireless
From: Ben Greear
Firmware developers can decode this and maybe figure out
why the firmware crashed.
Signed-off-by: Ben Greear
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/core.h |1 +
drivers/net/wireless/ath/ath10k/debug.c | 11 +++
drivers/net/wireless/ath
firmware with a new IE to describe the
BSS section starts and length.
Signed-off-by: Ben Greear
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/core.c | 54 +++
drivers/net/wireless/ath/ath10k/core.h | 16 +
drivers/net/wireless/ath/ath10k
Better to have a clear name for the function.
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/pci.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/pci.c
b/drivers/net/wireless/ath/ath10k/pci.c
index a65d45c78542
Ben Greear writes:
> On 08/08/2014 01:28 PM, Kalle Valo wrote:
>> Hi,
>>
>> here's my reworked Ben's patchset adding firmware crash dump support to
>> ath10k.
>> Unfortunately this crashes when reading the stack dump from the firmware but
>> tim
Ben Greear writes:
> On 08/08/2014 01:28 PM, Kalle Valo wrote:
>
>> +
>> +getnstimeofday(×tamp);
>> +dump_data->tv_sec = timestamp.tv_sec;
>> +dump_data->tv_nsec = timestamp.tv_nsec;
>
> I wonder if we should take timestamp at crash time
Ben Greear writes:
> On 08/08/2014 01:29 PM, Kalle Valo wrote:
>>
>> +/* estimated values, hopefully these are enough */
>> +#define ATH10K_ROM_BSS_BUF_LEN 1
>> +#define ATH10K_RAM_BSS_BUF_LEN 3
>> +
>> /* used for crash-dump storag
Ben Greear writes:
> On 08/08/2014 02:06 AM, Kalle Valo wrote:
>> Ben Greear writes:
>>
>>> I'm working on a patch to report the stats seen in
>>> debugfs/...ath10k/fw_stats
>>> as ethtool stats, somewhat similar to how ath9k does it.
>>>
gt;> reset themselves all the time...
>
> Does ath driver notify mac80211 about firmware restart, ie. through
> ieee80211_restart_hw().
ath10k does use ieee80211_restart_hw().
> If only user-space could get that info.
Yeah, that would be nice to have for ath10k firmw
nice to have a fw restart and fw crash counter in ethtool
> stats in case something wants to poll that instead of dealing with
> uevents. I will add those counters.
Yeah, those would be great to have.
--
Kalle Valo
___
ath10k mailing l
g to just provide a debugfs file to retrieve the
latest dump.
> I have seen similar thing from Marvell recently [1] which relies on
> udev and ethtool to do the work. I guess aligning the solutions is why
> this topic is listed for the wireless breakout ses
ems more elegant all around.
>
> I don't think you can do vmalloc in atomic context, btw. But, can do it
> on firmware load.
Ok, I'll look how to implement this.
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
ath10k_pci_diag_read32() is for reading u32 from a device and
ath10k_pci_diag_read_hi()
is a helper for reading data using "host interest" table.
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/pci.c | 55 +++--
1 file changed, 38 inserti
ath10k: save firmware RAM and ROM BSS sections on crash
Kalle Valo (3):
ath10k: add ath10k_pci_diag_* helpers
ath10k: rename ath10k_pci_hif_dump_area() to ath10k_pci_firmware_crashed()
ath10k: print more driver info when firmware crashes
drivers/net/wireless/ath/ath10k/core.c |
From: Ben Greear
Store the firmware crash registers and last 128 or so
firmware debug-log ids and present them to user-space
via debugfs.
Should help with figuring out why the firmware crashed.
Signed-off-by: Ben Greear
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/core.h
From: Ben Greear
Should help debug firmware crashes, and give users a way
to provide some useful debug reports to firmware developers.
Signed-off-by: Ben Greear
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/core.h |1 +
drivers/net/wireless/ath/ath10k/debug.c | 11
From: Ben Greear
They may be dumped through the firmware dump debugfs
file.
Signed-off-by: Ben Greear
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/wmi.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/net/wireless/ath/ath10k/wmi.c
b/drivers/net
From: Ben Greear
Firmware developers can decode this and maybe figure out
why the firmware crashed.
Signed-off-by: Ben Greear
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/core.h |1 +
drivers/net/wireless/ath/ath10k/debug.c | 11 +++
drivers/net/wireless/ath
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/core.c | 17 ++---
drivers/net/wireless/ath/ath10k/debug.c | 18 ++
drivers/net/wireless/ath/ath10k/debug.h |1 +
drivers/net/wireless/ath/ath10k/pci.c |4 +---
4 files changed, 22 insertions
firmware with a new IE to describe the
BSS section starts and length.
Signed-off-by: Ben Greear
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/core.c | 54 +++
drivers/net/wireless/ath/ath10k/core.h | 16 +
drivers/net/wireless/ath/ath10k
Better to have a clear name for the function. While at it, clear up the title
for the register dump.
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/pci.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/pci.c
b
c int ath10k_pci_warm_reset(struct ath10k *ar)
ath10k_dbg(ATH10K_DBG_BOOT, "boot warm reset complete\n");
- return ret;
+ return 0;
}
static int __ath10k_pci_hif_power_up(struct ath10k *ar, bool cold_reset)
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
Kalle Valo writes:
>> @@ -1915,7 +1870,6 @@ static int ath10k_pci_warm_reset(struct ath10k *ar)
>>
>> ath10k_dbg(ATH10K_DBG_BOOT, "boot warm reset complete\n");
>>
>> -ath10k_do_pci_sleep(ar);
>> return ret;
>> }
>
>
Michal Kazior writes:
> The 10.x and main firmware branches have
> conflicting WMI service bitmap definitions.
>
> This also fixes WMI services parsing on big-endian
> hosts and changes debugfs output to be more human
> friendly.
>
> Signed-off-by: Michal Kazior
Tha
by
> firmware when spectral scan is running (same goes
> for management rx).
>
> v2:
> * addressed some comments from Kalle
> * fixed a few more issues
>
>
> Michal Kazior (2):
> ath10k: simplify scan debug prints
> ath10k: intr
10k: remove target soc ps code
> ath10k: remove pci features var
> ath10k: group some pci probing helpers
> ath10k: remove htc->stopped
Thanks, these five patches applied.
> ath10k: move fw init print
I dropped this one as I think it's buggy.
--
Kalle Valo
_
NE, &ar->dev_flags))
ath10k_info("pci irq %s irq_mode %d reset_mode %d\n",
irq_mode, ath10k_pci_irq_mode,
ath10k_pci_reset_mode);
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
10k_pci_ce_init() to hif_power_up()? Isn't that unnecessary as we
already do that in probe()?
> + ath10k_info("pci irq %s (num %d) irq_mode %d reset_mode %d\n",
> + ath10k_pci_get_irq_method(ar), ar_pci->num_msi_intrs,
> + ath10k_pci_irq
S,
> -val & ~FW_IND_EVENT_PENDING);
> - ath10k_pci_hif_dump_area(ar);
> - return -ECOMM;
> - }
I'm a bit worried about this. Are you relying now that the target will
always trigger an inter
Kalle Valo writes:
> Michal Kazior writes:
>
>> Firmware probing is done only once when driver is
>> registered and firmware version is guaranteed to
>> remain the same until driver is unregistered.
>>
>> Signed-off-by: Michal Kazior
>
> [...]
>
bother bother with function pointers? What if we
just call the functions directly?
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
that problem.
>
> Reported-by: Kalle Valo
> Signed-off-by: Simon Wunderlich
Thanks for checking this. But I'm just wondering why even bother to call
relay_close() in the first place if mac80211 recursively removes
everything anyway? We don't remove any of the debugf
vers/net/wireless/ath/ath10k/pci.c:380 ath10k_pci_rx_replenish() warn:
mod_timer() takes an absolute \
time not an offset.
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
gt; use of larger bitfields.
>
> Signed-off-by: Ben Greear
Thanks, applied.
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
gree...@candelatech.com writes:
> From: Ben Greear
>
> Signed-off-by: Ben Greear
Thanks, applied with a simple commit log.
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
Simon Wunderlich writes:
> On Thursday 14 August 2014 13:12:13 Kalle Valo wrote:
>> Simon Wunderlich writes:
>> > If spectral is unregistered after mac80211, the relayfs file has already
>> > been removed recursively by mac/cfg80211, and spectral tries to remove
&g
that problem.
>
> Reported-by: Kalle Valo
> Signed-off-by: Simon Wunderlich
Thanks, applied.
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
ed, will not restart (state %d)\n",
> + ar->state);
> + ar->state = ATH10K_STATE_WEDGED;
> break;
> }
I think state prints should be debug messages, not part of error
messages. For example, we could add new debug level ATH10K_DBG_COR
hould this be ath10k_err() as it's an unrecoverable error?
Also I would prefer this kind of indentation:
if (ar->state != ATH10K_STATE_RESTARTED) {
ath10k_err("device failed to recover");
goto out;
}
ath10k_info("dev
Michal Kazior writes:
> On 9 August 2014 20:08, Kalle Valo wrote:
>> From: Ben Greear
>>
>> Store the firmware crash registers and last 128 or so
>> firmware debug-log ids and present them to user-space
>> via debugfs.
>>
>> Should help with figuri
Michal Kazior writes:
> On 18 August 2014 13:39, Kalle Valo wrote:
>> Michal Kazior writes:
>>
>>> On 9 August 2014 20:08, Kalle Valo wrote:
>>>
>>>> +struct ath10k_dump_file_data {
>>>> + /* dump file information */
>>>
E_AP_SCAN;
> Are there any plans to implement this feature? It's important in
> order to implement automatic channel change in case of changes in the
> interference environment.
No plans at the moment. Does anyone know how much work would it be to
change mac8
thing.
For mobile devices hw_scan is important because the ability to allow the
host CPU to sleep while scanning. For others I'm not that sure, maybe
firmware can do timing better (less intrusive) than host based sw
scanning?
--
Kalle Valo
___
Michal Kazior writes:
> On 19 August 2014 08:07, Kalle Valo wrote:
>> Avery Pennarun writes:
>>
>>>>> Are there any plans to implement this feature? It's important in
>>>>> order to implement automatic channel change in case of changes in the
nts on firmware crash
ath10k: save firmware RAM and ROM BSS sections on crash
Kalle Valo (3):
ath10k: add ath10k_pci_diag_* helpers
ath10k: rename ath10k_pci_hif_dump_area() to ath10k_pci_fw_crashed_dump()
ath10k: print more driver info when firmware crashes
drivers/net/wi
Better to have a clear name for the function. While at it, clear up the title
for the register dump.
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/pci.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/pci.c
b
ath10k_pci_diag_read32() is for reading u32 from a device and
ath10k_pci_diag_read_hi()
is a helper for reading data using "host interest" table.
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/pci.c | 55 +++--
1 file changed, 38 inserti
From: Ben Greear
They may be dumped through the firmware dump debugfs
file.
Signed-off-by: Ben Greear
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/wmi.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/net/wireless/ath/ath10k/wmi.c
b/drivers/net
From: Ben Greear
Store the firmware crash registers and last 128 or so
firmware debug-log ids and present them to user-space
via debugfs.
Should help with figuring out why the firmware crashed.
Signed-off-by: Ben Greear
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/core.h
From: Ben Greear
Firmware developers can decode this and maybe figure out
why the firmware crashed.
Signed-off-by: Ben Greear
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/core.h |1 +
drivers/net/wireless/ath/ath10k/debug.c | 11 +++
drivers/net/wireless/ath
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/core.c | 17 ++---
drivers/net/wireless/ath/ath10k/debug.c | 18 ++
drivers/net/wireless/ath/ath10k/debug.h |1 +
drivers/net/wireless/ath/ath10k/pci.c |4 +---
4 files changed, 22 insertions
From: Ben Greear
Should help debug firmware crashes, and give users a way
to provide some useful debug reports to firmware developers.
Signed-off-by: Ben Greear
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/core.h |1 +
drivers/net/wireless/ath/ath10k/debug.c | 12
firmware with a new IE to describe the
BSS section starts and length.
Signed-off-by: Ben Greear
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/core.c | 54 +++
drivers/net/wireless/ath/ath10k/core.h | 16 +
drivers/net/wireless/ath/ath10k
Michal Kazior writes:
> On 12 August 2014 09:44, Kalle Valo wrote:
>> Michal Kazior writes:
>>
>>> The 10.x and main firmware branches have
>>> conflicting WMI service bitmap definitions.
>>>
>>> This also fixes WMI services parsing on big-end
27;s
> safer to just re-init it on each power up until it is proven it is not
> necessary.
So I have been trying to follow this naming scheme for initilisation:
_create() - called during device probe time
_start() - if up / power up
_stop() - if down / power down
_destroy() - called wh
register Dump Location: 0x%08X\n", reg_dump_area);
I actually removed this line in the firmware crash dump patchset.
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
Michal Kazior writes:
> On 14 August 2014 10:40, Kalle Valo wrote:
>> Michal Kazior writes:
>>
>>> It doesn't make much sense to overwrite send_cb
>>> and recv_cb callbacks over and over again whenever
>>> transport starts. Just make sure to
d ath10k works with openwrt but
with another distribution it fails?
What's this another distribution?
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
the exact same kernel?
> I am using the following software on an ARM board:
> ath10k branch of linux kernel: 3.16.0-wl-ath-182333-g6a69f0c
Have you verified that with this kernel version the PCI bus works
correctly on your ARM board? Especially check that interrupts work.
--
Kalle
Kalle Valo writes:
> Pushpal Sidhu writes:
>
>> I'm having issues with ath10k timing out when trying to communicate
>> with the wireless card (UNEX DAXA-O1 + have tried several others).
>> Below is what I grabbed from dmesg.
>>
>> $ dmesg | grep ath10k
Michal Kazior writes:
> On 19 August 2014 17:25, Ben Greear wrote:
>> On 08/19/2014 02:33 AM, Michal Kazior wrote:
>>> On 19 August 2014 10:22, Kalle Valo wrote:
> [...]
>>>> + __le32 target_version;
>>>> + __le32 fw_versio
Kalle Valo writes:
>> Since this is just debugfs then I imagine you could have a userspace
>> program that would create the single blob/crash report from things it
>> thinks is important, e.g.. `uname -a`, debugfs entries (fw stack
>> traces, dbglog, etc), recent kernel l
don't like the idea of having untested code in ath10k. Buggy
code is okay (preferably document the known bugs when submitting code),
but untested code is not.
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
W_CRASH_DUMP_RAM_BSS = 4,
ATH10K_FW_CRASH_DUMP_ROM_BSS = 5,
And as we use TLV format this split doesn't break anything in user
space. How does that sound?
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
Ben Greear writes:
> On 08/20/2014 12:29 AM, Kalle Valo wrote:
>> Ben Greear writes:
>>
>>>>> + /* Gather dbg-log */ + dump_tlv = (struct ath10k_tlv_dump_data
>>>>> *)(buf + sofar); + dump_tlv->type =
>>>>> cpu_to_le32(ATH10K_FW_CRA
round 270 Mbps). So I should obtain 650 Mbps in practical for TCP
> with NSS3:MCS7 (975 Mbps in theory). 570 Mbps is so far to 650 Mbps :(
Forcing the data rate isn't really optimal. Have you tried 10.2
firmware? I was told it has improvements in the rate control algorithm.
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
ath10k_pci_diag_read32() is for reading u32 from a device and
ath10k_pci_diag_read_hi()
is a helper for reading data using "host interest" table.
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/pci.c | 55 +++--
1 file changed, 38 inserti
ing ath10k_fw_crash_ prefix etc
* change warning and debug messages to follow ath10k style
* add ath10k_debug_get_new_fw_crash_data() to avoid ifdefs in pci.c
---
Ben Greear (1):
ath10k: provide firmware crash info via debugfs
Kalle Valo (3):
ath10k: add ath10k_p
it as well
Signed-off-by: Ben Greear
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/core.h | 13 ++
drivers/net/wireless/ath/ath10k/debug.c | 249 +++
drivers/net/wireless/ath/ath10k/debug.h | 15 ++
drivers/net/wireless/ath/ath10k/hw.h|2
Better to have a clear name for the function. While at it, clear up the title
for the register dump.
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/pci.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/pci.c
b
Sometimes users forget to include important info like firmware version,
so better to print all the info.
Signed-off-by: Kalle Valo
---
drivers/net/wireless/ath/ath10k/core.c | 17 ++---
drivers/net/wireless/ath/ath10k/debug.c | 18 ++
drivers/net/wireless/ath
Johannes Berg writes:
> On Thu, 2014-08-21 at 15:49 +0300, Kalle Valo wrote:
>> From: Ben Greear
>>
>> Store the firmware registers and other relevant data to a firmware crash dump
>> file and provide it to user-space via debugfs. Should help with figuring out
Johannes Berg writes:
> On Thu, 2014-08-21 at 17:40 +0300, Kalle Valo wrote:
>
>> Heh, this has been a pretty long review period. To be honest I really
>> would like to get this just out of my hands :) And we do have a need for
>> this. When are you planning to implemen
Michal Kazior writes:
> On 21 August 2014 14:49, Kalle Valo wrote:
>
>> +static struct ath10k_dump_file_data *ath10k_build_dump_file(struct ath10k
>> *ar)
>> +{
>> + struct ath10k_fw_crash_data *crash_data = ar->debug.fw_crash_data;
>> +
the firmware from here:
https://github.com/kvalo/ath10k-firmware/tree/master/10.2
Do not rename the firmware to firmware-2.bin or anything like that. To
avoid problems keep the name firmware-3.bin.
--
Kalle Valo
___
ath10k mailing list
ath10k@l
ed properly or
git had a bad day.
Signed-off-by: Michal Kazior
Signed-off-by: Kalle Valo
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
Kalle Valo writes:
> And yet another version of firmware crash dumps. Now I dropped all dumps
> except
> firmware registers and tested all the features myself.
[...]
> Ben Greear (1):
> ath10k: provide firmware crash info via debugfs
>
> Kalle Valo (3)
> ath10k: split ce irq/handler setup
> ath10k: make sure to really disable irqs
> ath10k: remove early irq handling
Thanks, all six patches applied.
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
es, see notes
>
>
> Michal Kazior (5):
> ath10k: rework posting pci rx buffers
> ath10k: update comment regarding warm reset
> ath10k: ignore ar_pci->started in pipe cleanup
> ath10k: remove ar_pci->started
> ath10k: flush hif buffers bef
bug_mask dbg_mask,
> +static inline int ath10k_dbg(struct ath10k *ar,
> + enum ath10k_debug_mask dbg_mask,
> const char *fmt, ...)
> {
> return 0;
> }
>
> -static inline void ath10k_dbg_dump(enum ath10k_debug_mask ma
Michal Kazior writes:
> On 25 August 2014 11:18, Kalle Valo wrote:
>> Michal Kazior writes:
>>
>>> This makes it a lot easier to log and debug
>>> messages if there's more than 1 ath10k device on a
>>> system.
>>>
>>> Signed-
One idea I had is that we modify the tracing logging macros to take
struct ath10k (or struct device) and use dev_driver_string() &
dev_name() to provide the same info via trace events.
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
;
>> Please consider folding the attached diff :-)
>
> The variable is indeed not needed. I guess the function returns a value
> for parallelism with ath10k_err. But the function dev_err used in that
> function returns a value, while the macro dev_warn_ratelimited
probe" debug print after core is allocated [Kalle]
Thanks, applied. I just folded the patch to fix the smatch warning about
ret variable.
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
t; 10.1.467.2-1 api 2 htt 2.1
> [ 793.89] ath10k: debug 0 debugfs 0 tracing 0 dfs 1
>
> The report was missing register dump. Fix it by
> printing registers regardless if crash_data is
> present or not.
>
> Signed-off-by: Michal
tes. There is a
> substantial amount of randomness, but it generally happens within 2
> hours.
>
> So whatever this issue is, firmware 10.2 does appear to resolve it or
> at least make it way less likely to happen.
That's good to hear,
e = __le32_to_cpu(val);
return ret;
https://github.com/kvalo/ath/commit/1850a415873cb34a6f84b699dfb9a283df3252ec
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
}
return ret;
}
Can you guess what's the idea behind this? I would prefer that we get
rid of all the ugly _access() functions in pci.c.
--
Kalle Valo
___
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
; v2:
> * rebased
> * some fixes in patch [3/3] (see notes there)
>
>
> Michal Kazior (3):
> ath10k: move pci init structures
> ath10k: dont duplicate service-pipe mapping
> ath10k: make target endianess more explicit
Thanks, all three applied.
--
Kalle Valo
__
Himangi Saraogi (1):
ath6kl: convert a driver to use module_usb_driver()
Janusz Dziedzic (1):
ath10k: extend debug code for RX path
Kalle Valo (3):
ath10k: add ath10k_pci_diag_* helpers
ath10k: rename ath10k_pci_hif_dump_area() to ath10k_pci_fw_crashed_dump()
ath10k:
901 - 1000 of 3044 matches
Mail list logo
