Re: [PATCH v2 3/3] arm64: dts: qcom: msm8998: set qcom,no-msa-ready-indicator for wifi

2024-04-25 Thread Kalle Valo
Conor Dooley writes: > On Thu, Apr 25, 2024 at 06:42:16PM +0300, Kalle Valo wrote: > >> Marc Gonzalez writes: >> >> > On 25/04/2024 11:42, Kalle Valo wrote: >> > >> >> Marc Gonzalez wrote: >> >> >> >>> Do you

Re: [PATCH v2 3/3] arm64: dts: qcom: msm8998: set qcom,no-msa-ready-indicator for wifi

2024-04-25 Thread Kalle Valo
Marc Gonzalez writes: > On 25/04/2024 11:42, Kalle Valo wrote: > >> Marc Gonzalez wrote: >> >>> Do you prefer: >>> >>> Option A = never waiting for the MSA_READY indicator for ANYONE >>> Option B = not waiting for the MSA_READY ind

Re: [PATCH 1/3] wifi: ath10k: populate board data for WCN3990

2024-04-25 Thread Kalle Valo
Dmitry Baryshkov wrote: > Specify board data size (and board.bin filename) for the WCN3990 > platform. > > Reported-by: Yongqin Liu > Fixes: 03a72288c546 ("ath10k: wmi: add hw params entry for wcn3990") > Signed-off-by: Dmitry Baryshkov > Signed-off-by: Kalle

Re: QCA6174 showing terrible performance when connecting via WPA3-SAE

2024-04-25 Thread Kalle Valo
Eric Park writes: > Resending as I forgot to CC the mailing list, sorry! I've added some > more info since the last email. Thanks. Let's keep the discussion on the list so that others can join. > On 2024-03-11 11:21, Kalle Valo wrote: >> But with modern CPUs I would have

Re: [PATCH v2 3/3] arm64: dts: qcom: msm8998: set qcom,no-msa-ready-indicator for wifi

2024-04-25 Thread Kalle Valo
Marc Gonzalez writes: > On 04/04/2024 17:28, Kalle Valo wrote: > >> Marc Gonzalez wrote: >> >>> On 04/04/2024 13:57, Kalle Valo wrote: >>> >>>> Dmitry Baryshkov wrote: >>>> >>>>> I'd say, we should take a st

Re: [PATCH wireless v2] wifi: ath10k: Fix an error code problem in ath10k_dbg_sta_write_peer_debug_trigger()

2024-04-24 Thread Kalle Valo
t;ath10k: add debugfs support to get per peer tids log > via tracing") > Signed-off-by: Su Hui > Acked-by: Jeff Johnson > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. c511a9c12674 wifi: ath10k: Fix an error code problem in ath10k

Re: [PATCH net-next v7 10/10] wifi: ath11k: allocate dummy net_device dynamically

2024-04-22 Thread Kalle Valo
. > > [1] https://lore.kernel.org/all/20240229225910.79e22...@kernel.org/ > > Signed-off-by: Breno Leitao > Tested-by: Kalle Valo I assume this goes via net-next: Acked-by: Kalle Valo -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH net-next v7 09/10] wifi: ath10k: allocate dummy net_device dynamically

2024-04-22 Thread Kalle Valo
erage alloc_netdev() to allocate the > net_device object at ath10k_core_create(). The free of the device occurs > at ath10k_core_destroy(). > > [1] https://lore.kernel.org/all/20240229225910.79e22...@kernel.org/ > > Signed-off-by: Breno Leitao I assume this goes via net-nex

Re: [PATCH net-next v7 08/10] wifi: qtnfmac: Use netdev dummy allocator helper

2024-04-22 Thread Kalle Valo
i: qtnfmac: allocate dummy net_device dynamically") > Signed-off-by: Breno Leitao I assume this goes via net-next: Acked-by: Kalle Valo -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH wireless v2] wifi: ath10k: Fix an error code problem in ath10k_dbg_sta_write_peer_debug_trigger()

2024-04-22 Thread Kalle Valo
Su Hui writes: > Clang Static Checker (scan-build) Warning: > drivers/net/wireless/ath/ath10k/debugfs_sta.c:line 429, column 3 > Value stored to 'ret' is never read. > > Return 'ret' rather than 'count' when 'ret' stores an error code. > By the way, remove some useless code. > > Fixes:

Re: [PATCH net-next v5 00/10] allocate dummy device dynamically

2024-04-11 Thread Kalle Valo
e wireless drivers. > > PS: Due to lack of hardware, unfortunately most these patches are > compiled tested only, except ath11k that was kindly tested by Kalle Valo. > > --- > Changelog: > > v1: > * https://lore.kernel.org/all/20240327200809.512867-1-lei...@deb

Re: [PATCH 0/3] wifi: Un-embed ath10k and ath11k dummy netdev

2024-04-09 Thread Kalle Valo
Breno Leitao writes: > On Tue, Apr 09, 2024 at 01:03:21PM +0300, Kalle Valo wrote: > >> Breno Leitao writes: >> >> >> > Reading the issue, I am afraid that freeing netdev explicitly >> >> > (free_netdev()) might not be the best approach at th

Re: [PATCH 0/3] wifi: Un-embed ath10k and ath11k dummy netdev

2024-04-09 Thread Kalle Valo
Breno Leitao writes: >> > Reading the issue, I am afraid that freeing netdev explicitly >> > (free_netdev()) might not be the best approach at the exit path. >> > >> > I would like to try to leverage the ->needs_free_netdev netdev >> > mechanism to do the clean-up, if that makes sense. I've

Re: [PATCH 0/3] wifi: Un-embed ath10k and ath11k dummy netdev

2024-04-08 Thread Kalle Valo
Breno Leitao writes: > Hello Kalle, > > On Fri, Apr 05, 2024 at 06:15:05PM +0300, Kalle Valo wrote: >> Breno Leitao writes: >> >> > struct net_device shouldn't be embedded into any structure, instead, >> > the owner should use the private space to

Re: [PATCH 0/3] wifi: Un-embed ath10k and ath11k dummy netdev

2024-04-05 Thread Kalle Valo
Breno Leitao writes: > struct net_device shouldn't be embedded into any structure, instead, > the owner should use the private space to embed their state into > net_device. > > This patch set fixes the problem above for ath10k and ath11k. This also > fixes the conversion of qtnfmac driver to the

Re: [PATCH 0/3] wifi: ath10k: fix board file loading for wcn3990 devices

2024-04-05 Thread Kalle Valo
Dmitry Baryshkov writes: > On Fri, 5 Apr 2024 at 14:57, Kalle Valo wrote: > >> >> Dmitry Baryshkov writes: >> >> > On Tue, 30 Jan 2024 at 08:47, Dmitry Baryshkov >> > wrote: >> > >> >> >> >> The ath10k driver fails

Re: [PATCH RFC v2 0/4] wifi: ath10k: support board-specific firmware overrides

2024-04-05 Thread Kalle Valo
Dmitry Baryshkov writes: > On Fri, 5 Apr 2024 at 15:01, Kalle Valo wrote: > >> >> Dmitry Baryshkov writes: >> >> > On Fri, 8 Mar 2024 at 17:19, Kalle Valo wrote: >> >> >> >> Dmitry Baryshkov writes: >> >> >>

Re: [PATCH RFC v2 1/4] dt-bindings: net: wireless: ath10k: describe firmware-name property

2024-04-05 Thread Kalle Valo
rzysztof Kozlowski > Signed-off-by: Dmitry Baryshkov > Signed-off-by: Kalle Valo 2 patches applied to ath-next branch of ath.git, thanks. 158fff51b4c3 dt-bindings: net: wireless: ath10k: describe firmware-name property 5abf259772df wifi: ath10k: support board-specific firmw

Re: [PATCH RFC v2 0/4] wifi: ath10k: support board-specific firmware overrides

2024-04-05 Thread Kalle Valo
Dmitry Baryshkov writes: > On Fri, 8 Mar 2024 at 17:19, Kalle Valo wrote: >> >> Dmitry Baryshkov writes: >> >> >> To be on the safe side using 'qcom-rb1' makes sense but on the other >> >> hand that means we need to update linux-firmware (basic

Re: [PATCH 0/3] wifi: ath10k: fix board file loading for wcn3990 devices

2024-04-05 Thread Kalle Valo
Dmitry Baryshkov writes: > On Tue, 30 Jan 2024 at 08:47, Dmitry Baryshkov > wrote: > >> >> The ath10k driver fails to properly handle fallback from board-2.bin to >> board.bin for WCN3990 cards. This happens because the >> ath10k_hw_params_list doesn't include .fw.board* parameters for the >>

Re: [3/6] wifi: rsi: sdio: simplify module initialization

2024-04-05 Thread Kalle Valo
Krzysztof Kozlowski wrote: > This driver's initialization functions do not perform any custom code, > except printing messages. Printing messages on modules > loading/unloading is discouraged because it pollutes the dmesg > regardless whether user actually has this device. Core kernel code >

Re: [PATCH v2 3/3] arm64: dts: qcom: msm8998: set qcom,no-msa-ready-indicator for wifi

2024-04-04 Thread Kalle Valo
Marc Gonzalez writes: > On 04/04/2024 13:57, Kalle Valo wrote: > >> Dmitry Baryshkov wrote: >> >>> I'd say, we should take a step back and actually verify how this was >>> handled in the vendor kernel. >> >> One comment related to this: usually

Re: [PATCH v2 3/3] arm64: dts: qcom: msm8998: set qcom,no-msa-ready-indicator for wifi

2024-04-04 Thread Kalle Valo
Dmitry Baryshkov writes: >> 3) ADD that compatible to the wifi node in msm8998.dtsi >>compatible = "qcom,wcn3990-wifi", "qcom,msm8998-wifi"; >> 4) In the driver, set qmi->fake_msa_ready_indicator to true if we >> detect "qcom,msm8998-wifi" >> >> And this approach would be acceptable to both

Re: [PATCH RFC v2 0/4] wifi: ath10k: support board-specific firmware overrides

2024-04-04 Thread Kalle Valo
Jeff Johnson writes: > On 3/29/2024 9:47 PM, Dmitry Baryshkov wrote: > >> On Wed, 6 Mar 2024 at 10:16, Dmitry Baryshkov >> wrote: >>> >>> On WCN3990 platforms actual firmware, wlanmdsp.mbn, is sideloaded to the >>> modem DSP via the TQFTPserv. These MBN files are signed by the device >>>

Re: [PATCH 2/6] wifi: ath6kl: sdio: simplify module initialization

2024-04-04 Thread Kalle Valo
kernel code > already gives tools to investigate whether module was loaded or not. > > Drop the printing messages which allows to replace open-coded > module_sdio_driver(). > > Signed-off-by: Krzysztof Kozlowski > Signed-off-by: Kalle Valo Patch applied to ath-next branch

Re: [PATCH 1/6] wifi: ath10k: sdio: simplify module initialization

2024-04-03 Thread Kalle Valo
Krzysztof Kozlowski writes: > On 03/04/2024 15:50, Kalle Valo wrote: > >> Jeff Johnson writes: >> >>> On 3/29/2024 10:10 AM, Krzysztof Kozlowski wrote: >>>> This driver's initialization functions do not perform any custom code, >>>> exce

Re: [PATCH 7/7] wifi: silabs: wfx: drop driver owner initialization

2024-04-03 Thread Kalle Valo
tree: Acked-by: Kalle Valo -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH 6/7] wifi: marvell: mwifiex: drop driver owner initialization

2024-04-03 Thread Kalle Valo
his via sdio tree: Acked-by: Kalle Valo -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH 1/6] wifi: ath10k: sdio: simplify module initialization

2024-04-03 Thread Kalle Valo
uch as possible. In this patchset I'm not anticipating any conflicts with wireless trees, so if we can avoid any conflicts, please take this patchset via the other tree: Acked-by: Kalle Valo I'll drop this patchset from my queue. But if I should take these to wireless trees instead just le

Re: pull-request: ath-next-20240402

2024-04-02 Thread Kalle Valo
Kalle Valo wrote: > Hi, > > Please pull, more information in the tag below. > > Kalle > > > The following changes since commit f654e228ed6b822e87e6e6ad8e889bedccae2e16: > > Merge tag 'ath-next-20240305' of > git://git.kernel.org/pub/scm/linux/kernel/g

pull-request: ath-next-20240402

2024-04-02 Thread Kalle Valo
obsolete struct wmi_start_scan_arg wifi: ath11k: remove obsolete struct wmi_start_scan_arg wifi: ath11k: fix soc_dp_stats debugfs file permission Kalle Valo (7): wifi: ath6kl: fix sparse warnings wifi: wcn36xx: buff_to_be(): fix sparse warnings wifi: wcn36xx: main: fix

Re: [PATCH] ath10k: allocate dummy net_device dynamically

2024-03-27 Thread Kalle Valo
Jakub Kicinski writes: > On Fri, 22 Mar 2024 07:58:02 -0700 Breno Leitao wrote: >> > Looks like init_dummy_netdev wipes the netdev structure clean, so I >> > don't think we can use it directly as the setup function, Breno :( >> >> Before my patch, init_dummy_netdev was being also used. The

Re: [PATCH v2 1/3] wifi: ath: Convert sprintf/snprintf to sysfs_emit

2024-03-25 Thread Kalle Valo
). > > sprintf() will be converted as weel if they have. > > Generally, this patch is generated by > make coccicheck M= MODE=patch \ > COCCI=scripts/coccinelle/api/device_attr_show.cocci > > No functional change intended > > CC: Kalle Valo > CC: Jeff Johnson

Re: [PATCH] ath10k: allocate dummy net_device dynamically

2024-03-20 Thread Kalle Valo
Jeff Johnson writes: > On 3/19/2024 3:47 AM, Breno Leitao wrote: >> Embedding net_device into structures prohibits the usage of flexible >> arrays in the net_device structure. For more details, see the discussion >> at [1]. >> >> Un-embed the net_device from struct ath10k by converting it >>

Re: QCA6174 showing terrible performance when connecting via WPA3-SAE

2024-03-11 Thread Kalle Valo
Eric Park writes: > Hello! I have a Samsung NT500R5H-Y53L with the QCA6174 card, and I > noticed I was getting terrible performance (around 20-30 Mbps) > compared to other devices on the network (600-700 Mbps), when running > a speedtest. > > I tried modifying some settings and discovered that I

Re: [PATCH RFC v2 0/4] wifi: ath10k: support board-specific firmware overrides

2024-03-08 Thread Kalle Valo
Dmitry Baryshkov writes: >> To be on the safe side using 'qcom-rb1' makes sense but on the other >> hand that means we need to update linux-firmware (basically add a new >> symlink) everytime a new product is added. But are there going to be >> that many new ath10k based products? >> >> Using

Re: [PATCH v2] wifi: ath10k: poll service ready message before failing

2024-03-08 Thread Kalle Valo
.org/linux-wireless/304ce305-fbe6-420e-ac2a-d61ae5e6c...@gmail.com/ > Signed-off-by: Baochen Qiang > Acked-by: Jeff Johnson > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. e57b7d62a1b2 wifi: ath10k: poll service ready message before failing -- http

Re: New staging repos for ath1*k firmware

2024-03-07 Thread Kalle Valo
Robert Marko writes: > On Wed, Mar 6, 2024 at 8:23 PM Jeff Johnson wrote: > >> >> Historically, prior to being incorporated into the linux-firmware >> project, firmware for kernel.org ath1*k drivers has been first published >> to Kalle's GitHub: >> https://github.com/kvalo/ath10k-firmware >>

Re: [PATCH RFC v2 0/4] wifi: ath10k: support board-specific firmware overrides

2024-03-06 Thread Kalle Valo
Dmitry Baryshkov writes: > On Wed, 6 Mar 2024 at 11:04, Kalle Valo wrote: > >> >> Dmitry Baryshkov writes: >> >> > On WCN3990 platforms actual firmware, wlanmdsp.mbn, is sideloaded to the >> > modem DSP via the TQFTPserv. These MBN files are signed b

Re: [PATCH RFC v2 0/4] wifi: ath10k: support board-specific firmware overrides

2024-03-06 Thread Kalle Valo
Dmitry Baryshkov writes: > On WCN3990 platforms actual firmware, wlanmdsp.mbn, is sideloaded to the > modem DSP via the TQFTPserv. These MBN files are signed by the device > vendor, can only be used with the particular SoC or device. > > Unfortunately different firmware versions come with

Re: [PATCH RFC v2 2/4] wifi: ath10k: support board-specific firmware overrides

2024-03-06 Thread Kalle Valo
Dmitry Baryshkov writes: > Different Qualcomm platforms using WCN3990 WiFI chip use SoC-specific > firmware versions with different features. For example firmware for > SDM845 doesn't use single-chan-info-per-channel feature, while firmware > for QRB2210 / QRB4210 requires that feature. Allow

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-05 Thread Kalle Valo
Marc Gonzalez writes: > On 05/03/2024 15:31, Kalle Valo wrote: > >> Thanks, this is exactly what I'm proposing. > > With your suggestions, the patch becomes much simpler: Nice, looks good to me. > I need to build a kernel + rootfs + FW to test the proposed solution, >

Re: pull-request: ath-next-20240305

2024-03-05 Thread Kalle Valo
Kalle Valo wrote: > Hi, > > Please pull, more information in the tag below. > > Kalle > > > The following changes since commit a4634aa71fee11f5e3e13bf7d80ee1480a64ce70: > > bonding: rate-limit bonding driver inspect messages (2024-02-22 19:13:18 > -08

pull-request: ath-next-20240305

2024-03-05 Thread Kalle Valo
: constify MHI channel and controller configs Kalle Valo (2): wifi: ath11k: thermal: don't try to register multiple times wifi: ath12k: fix license in p2p.c and p2p.h Kang Yang (1): wifi: ath12k: add rcu lock for ath12k_wmi_p2p_noa_event() .../bindings/net/wireless/qcom,ath10k.yaml

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-05 Thread Kalle Valo
Marc Gonzalez writes: > On 29/02/2024 19:40, Conor Dooley wrote: > >> On Wed, Feb 28, 2024 at 06:37:08PM +0200, Kalle Valo wrote: >> >>> Marc Gonzalez wrote: >>> >>>> As mentioned in my other reply, there are several msm8998-based >>&g

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-05 Thread Kalle Valo
Conor Dooley writes: > On Wed, Feb 28, 2024 at 06:37:08PM +0200, Kalle Valo wrote: >> Marc Gonzalez writes: > >> > As mentioned in my other reply, there are several msm8998-based >> > devices affected by this issue. Is it not appropriate to consider >> > a

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-05 Thread Kalle Valo
Marc Gonzalez writes: > On 01/03/2024 09:10, Kalle Valo wrote: > >> Marc Gonzalez wrote: >> >>> Kalle Valo wrote: >>> >>>> Here's one example where in ath10k we use a feature bit as a workaround: >>>> >>>>/* Don't trus

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-03-01 Thread Kalle Valo
Marc Gonzalez writes: >> Here's one example where in ath10k we use a feature bit as a workaround: >> >> /* Don't trust error code from otp.bin */ >> ATH10K_FW_FEATURE_IGNORE_OTP_RESULT = 7, >> >> >> >> if (!(skip_otp || test_bit(ATH10K_FW_FEATURE_IGNORE_OTP_RESULT,

Re: [PATCH RFC 2/4] wifi: ath10k: support board-specific firmware overrides

2024-03-01 Thread Kalle Valo
Dmitry Baryshkov writes: > Different Qualcomm platforms using WCN3990 WiFI chip use SoC-specific > firmware versions with different features. For example firmware for > SDM845 doesn't use single-chan-info-per-channel feature, while firmware > for QRB2210 / QRB4210 requires that feature. Allow

Re: [PATCH v2] wifi: ath10k: poll service ready message before failing

2024-02-29 Thread Kalle Valo
Baochen Qiang writes: > Currently host relies on CE interrupts to get notified that > the service ready message is ready. This results in timeout > issue if the interrupt is not fired, due to some unknown > reasons. See below logs: > > [76321.937866] ath10k_pci :02:00.0: wmi service ready

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-02-28 Thread Kalle Valo
Marc Gonzalez writes: > On 28/02/2024 15:03, Kalle Valo wrote: > >> Marc Gonzalez writes: >> >>> + qcom,no-msa-ready-indicator: >>> +type: boolean >>> +description: >>> + The driver waits for this indicator before proceed

Re: [PATCH 1/2] dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

2024-02-28 Thread Kalle Valo
Marc Gonzalez writes: > The driver waits for this indicator before proceeding, > yet some WCNSS firmwares apparently do not send it. > On those devices, it seems safe to ignore the indicator, > and continue loading the firmware. > > Signed-off-by: Pierre-Hugues Husson > Signed-off-by: Marc

Re: [PATCH] wifi: ath10k: poll service ready message before failing

2024-02-26 Thread Kalle Valo
Baochen Qiang writes: > Currently host relies on CE interrupts to get notified that > the service ready message is ready. This results in timeout > issue if the interrupt is not fired, due to some unknown > reasons. See below logs: > > [76321.937866] ath10k_pci :02:00.0: wmi service ready

Re: [PATCH] dt-bindings: net: wireless: qcom: Update maintainers

2024-02-23 Thread Kalle Valo
Jeff Johnson wrote: > Add Jeff Johnson as a maintainer of the qcom,ath1*k.yaml files. > > Signed-off-by: Jeff Johnson > Acked-by: Krzysztof Kozlowski > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 1098eb62433c dt-bindings: net: wireles

Re: pull-request: ath-next-20240222

2024-02-22 Thread Kalle Valo
Kalle Valo writes: > Hi, > > Here's an ath-next pull request to wireless-next. More info below. > > Kalle > > The following changes since commit 2a71528427c635f0a8bff704b2e62ce81c641d6f: > > wifi: brcmfmac: fix copyright year mentioned in platform_data header &

pull-request: ath-next-20240222

2024-02-22 Thread Kalle Valo
Hi, Here's an ath-next pull request to wireless-next. More info below. Kalle The following changes since commit 2a71528427c635f0a8bff704b2e62ce81c641d6f: wifi: brcmfmac: fix copyright year mentioned in platform_data header (2024-01-31 18:48:06 +0200) are available in the Git repository at:

Re: [1/2] MAINTAINERS: wifi: update Jeff Johnson e-mail address

2024-02-21 Thread Kalle Valo
Jeff Johnson wrote: > I now have a @kernel.org e-mail address, so use that for my > maintenance activities. > > Signed-off-by: Jeff Johnson 2 patches applied to wireless.git, thanks. 27dc4c6ee5fe MAINTAINERS: wifi: update Jeff Johnson e-mail address 1b7d9ab3e666 MAINTAINERS: wifi: Add N:

Re: [kvalo-ath:pending 47/100] drivers/net/wireless/ath/ath11k/mac.c:7949 ath11k_mac_fill_reg_tpc_info() error: uninitialized symbol 'eirp_power'.

2024-02-01 Thread Kalle Valo
Baochen Qiang writes: > On 1/31/2024 8:35 PM, Kalle Valo wrote: >> + ath11k list >> kernel test robot writes: >> >>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git >>> pending >>> head: 2c4

Re: pull-request: ath-next-20240130

2024-01-31 Thread Kalle Valo
Kalle Valo wrote: > Hi, > > Our ath-next pull request for wireless-next. > > Kalle > > The following changes since commit c5a3f56fcdb0a48a20772e4c9b8adc6c7256a461: > > Merge tag 'ath-next-20231215' of > git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath

Re: [kvalo-ath:pending 47/100] drivers/net/wireless/ath/ath11k/mac.c:7949 ath11k_mac_fill_reg_tpc_info() error: uninitialized symbol 'eirp_power'.

2024-01-31 Thread Kalle Valo
+ ath11k list kernel test robot writes: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git pending > head: 2c471f31297856be56f60ef29f2565dea1470800 > commit: 92425f788feede9bf152ecf3fb7a264942ee7719 [47/100] wifi: > ath11k: fill parameters for vdev set tpc power WMI

[PULL linux-firmware] ath10k, ath11k and ath12k firmware 20240130

2024-01-30 Thread Kalle Valo
-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.37 (2024-01-30 19:58:18 +0200) Kalle Valo (1): ath11k: WCN6855 hw2.0: update to WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.37 WHENCE| 2 +- ath11k

pull-request: ath-next-20240130

2024-01-30 Thread Kalle Valo
Hi, Our ath-next pull request for wireless-next. Kalle The following changes since commit c5a3f56fcdb0a48a20772e4c9b8adc6c7256a461: Merge tag 'ath-next-20231215' of git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath (2023-12-17 13:20:18 +0200) are available in the Git repository at:

Re: [PATCH 1/5] wifi: ath10k: add missing wmi_10_4_feature_mask documentation

2024-01-19 Thread Kalle Valo
ing: Enum value > 'WMI_10_4_REPORT_AIRTIME' not described in enum 'wmi_10_4_feature_mask' > > Update the kernel-doc for enum wmi_10_4_feature_mask to add the > missing documentation. > > No functional changes, compile tested only. > > Signed-off-by: Jeff Johnson > Sig

Re: [PATCH v3 1/3] wifi: ath12k: replace ENOTSUPP with EOPNOTSUPP

2024-01-17 Thread Kalle Valo
Karthikeyan Periyasamy wrote: > ENOTSUPP is not a standard error code, don't use it. Replace with > EOPNOTSUPP instead. > > No functional changes, compile tested only. > > Signed-off-by: Karthikeyan Periyasamy > Acked-by: Jeff Johnson > Signed-off-by: Kalle Valo

[PULL linux-firmware] ath10k, ath11k and ath12k firmware 2023-12-21

2023-12-21 Thread Kalle Valo
to 17509e53b97baaefeb287b98d3358da8a6e1c199: ath11k: WCN6855 hw2.0: update to WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.36 (2023-12-21 16:13:58 +0200) Kalle Valo (9): ath12k: add new driver and firmware for WCN7850 ath10k: QCA6174 hw3.0: update

Re: [PATCH 1/6] wifi: ath10k: use flexible array in struct wmi_host_mem_chunks

2023-12-18 Thread Kalle Valo
; Reviewed-by: Kees Cook > Reviewed-by: Gustavo A. R. Silva > Signed-off-by: Kalle Valo 6 patches applied to ath-next branch of ath.git, thanks. d2eb318f4b6b wifi: ath10k: use flexible array in struct wmi_host_mem_chunks 72ca7c4073ac wifi: ath10k: use flexible arrays for WMI start scan TLVs 26eb7

Re: [PATCH v2] wifi: ath10k: fix NULL pointer dereference in ath10k_wmi_tlv_op_pull_mgmt_tx_compl_ev()

2023-12-18 Thread Kalle Valo
ingyuan Mo > Acked-by: Jeff Johnson > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. ad25ee36f001 wifi: ath10k: fix NULL pointer dereference in ath10k_wmi_tlv_op_pull_mgmt_tx_compl_ev() -- https://patchwork.kernel.org/project/linux-wireless/patch/2023120

Re: pull-request: ath-next-20231215

2023-12-17 Thread Kalle Valo
Kalle Valo wrote: > Hi, > > Now that Jeff is also the ath maintainer we decided to start doing > proper pull requests. Earlier I was just merging ath-next directly to > wireless-next. So here's our first pull request, let's see if we got it > right :) > > Kalle > &g

pull-request: ath-next-20231215

2023-12-15 Thread Kalle Valo
Jiri Slaby (SUSE) (1): wifi: ath5k: remove unused ath5k_eeprom_info::ee_antenna Justin Stitt (1): wifi: ath10k: replace deprecated strncpy with memcpy Kalle Valo (1): wifi: ath11k: workaround too long expansion sparse warnings Kang Yang (8): wifi: ath12k: get msi_data

Re: ath10k-firmware: WCN3990: Add board file for the Qualcomm SDM845 MTP platform

2023-12-13 Thread Kalle Valo
Dmitry Baryshkov writes: > We'd like to ask for inclusion of the board file for the Qualcomm > SDM845 MTP board. It is a hardware development kit manufactured by > Qualcomm, using the Snapdragon SDM845 SoC and a variant of wcn3990 > BT/WiFi chip. > > Following the questions from the ath10k wiki

Re: Fwd: ath10k-firmware: QCA9888 hw2.0: Add BDF for ASUS MAP-AC2200

2023-12-07 Thread Kalle Valo
Erkki hietaranta writes: > ASUS MAP-AC2200 is IPQ4019 based device with three radios. > - one QCA40xx radio is used as 2.4GHz radio > - one QCA40xx radio is used as 5GHz radio > -- Both allready supported: > https://www.mail-archive.com/ath10k@lists.infradead.org/msg09696.html > - one QCA9888

Re: ath10k-firmware: WCN3990: Add board file for the Qualcomm SDM845 MTP platform

2023-12-07 Thread Kalle Valo
Dmitry Baryshkov writes: > We'd like to ask for inclusion of the board file for the Qualcomm > SDM845 MTP board. It is a hardware development kit manufactured by > Qualcomm, using the Snapdragon SDM845 SoC and a variant of wcn3990 > BT/WiFi chip. > > Following the questions from the ath10k wiki

Re: ath10k-firmware: WCN3990: Add board file for Xiaomi POCOPHONE F1

2023-12-07 Thread Kalle Valo
Dylan Van Assche writes: > I would like to include the board file for the Xiaomi POCOPHONE F1 > smartphone. > This smartphone is manufactured by Xiaomi and uses the Snapdragon > SDM845 SoC. > At postmarketOS, we run the mainline kernel on this phone so shipping > this board file > from upstream

Re: ath10k-firmware: WCN3990: Add board file for SHIFTPHONES SHIFT6mq

2023-12-07 Thread Kalle Valo
Dylan Van Assche writes: > I would like to include the board file for the SHIFTPHONES SHIFT6mq > smartphone. > This smartphone is manufactured by SHIFTPHONES and uses the Snapdragon > SDM845 SoC. > At postmarketOS, we run the mainline kernel on this phone so shipping > this board file > from

Re: ath10k-firmware: WCN3990: Add board file for the Qualcomm Robotics RB2 platform

2023-12-07 Thread Kalle Valo
Dmitry Baryshkov writes: > We'd like to ask for inclusion of the board file for the Qualcomm > Robotics RB2 platform. It is > an IOT platform manufactured by Thundercomm, using the Snapdragon QRB4210 SoC. > > Following the questions from the ath10k wiki page: > > * description for what hardware

Re: ath10k-firmware: WCN3990: Add board file for Oneplus 6/6T

2023-12-07 Thread Kalle Valo
Dylan Van Assche writes: > I would like to include the board file for the Oneplus 6/6T smartphone. > This smartphone is manufactured by Oneplus and uses the Snapdragon > SDM845 SoC. > At postmarketOS, we run the mainline kernel on this phone so shipping > this board file > from upstream would be

Re: ath10k-firmware: WCN3990: Add board file for the Qualcomm Robotics RB1 platform

2023-12-07 Thread Kalle Valo
Dmitry Baryshkov writes: > Hello Kalle, > > We'd like to ask for inclusion of the board file for the Qualcomm > Robotics RB1 platform. It is > an IOT platform manufactured by Thundercomm, using the Snapdragon QRB2210 SoC. > > Following the questions from the ath10k wiki page: > > * description

Re: ath10k-firmware: QCA4019 hw1.0: Add Eero Cento specific BDFs

2023-12-07 Thread Kalle Valo
"Connor Northway" writes: > Hello, > > I am preparing a commit to port OpenWrt to the Eero Cento, and would > like to provide its board files for inclusion in the official file. > > Following the wiki's form: > > description for what hardware this is: > >- the Eero Cento (model no. J010001)

Re: [PATCH] ath10k: Don't touch the CE interrupt registers after power up

2023-12-07 Thread Kalle Valo
Yongqin Liu writes: > On Sat, 1 Jul 2023 at 06:19, Douglas Anderson wrote: >> >> As talked about in commit d66d24ac300c ("ath10k: Keep track of which >> interrupts fired, don't poll them"), if we access the copy engine >> register at a bad time then ath10k can go boom. However, it's not >>

Re: [PATCH] wifi: ath10k: fix NULL pointer dereference in ath10k_wmi_tlv_op_pull_mgmt_tx_compl_ev()

2023-12-07 Thread Kalle Valo
Xingyuan Mo writes: > We should check whether the WMI_TLV_TAG_STRUCT_MGMT_TX_COMPL_EVENT tlv is > present before accessing it, otherwise a null pointer deference error will > occur. I cannot take patches without s-o-b, please read:

Re: [PATCH 4/4] wifi: ath11k: Use DECLARE_FLEX_ARRAY() for ath11k_htc_record

2023-12-05 Thread Kalle Valo
"Gustavo A. R. Silva" writes: > On 12/5/23 09:29, Kalle Valo wrote: >> Jeff Johnson writes: >> >>> On 11/27/2023 8:23 AM, Gustavo A. R. Silva wrote: >>> >>>> >>>> >>>> On 11/27/23 10:14, Jeff Johnson wrote: >>

Re: [PATCH 4/4] wifi: ath11k: Use DECLARE_FLEX_ARRAY() for ath11k_htc_record

2023-12-05 Thread Kalle Valo
Jeff Johnson writes: > On 11/27/2023 8:23 AM, Gustavo A. R. Silva wrote: > >> >> >> On 11/27/23 10:14, Jeff Johnson wrote: >>> Transform the zero-length array in ath11k_htc_record into a proper >>> flexible array via the DECLARE_FLEX_ARRAY() macro. This helps with >>> ongoing efforts to

Re: [PATCH v2] wifi: ath10k: add support to allow broadcast action frame RX

2023-12-05 Thread Kalle Valo
Jeff Johnson writes: > On 11/16/2023 9:32 AM, James Prestwood wrote: > >> Broadcast action frames are needed for the Device Provisioning >> Protocol (DPP) for Presence and PKEX Exchange requests. Currently >> just ath9k has this capability so this is being enabled for >> ath10k (for at least one

Re: ath10k / WCN3990: firmware-5.bin and wlanmdsp.mbn being out of sync

2023-12-05 Thread Kalle Valo
Dmitry Baryshkov writes: > On Mon, 4 Dec 2023 at 18:14, Kalle Valo wrote: > >> >> Dmitry Baryshkov writes: >> >> > On Mon, 4 Dec 2023 at 14:56, Kalle Valo wrote: >> > >> >> >> >> Hi Dmitry, >> >> >> &

Re: ath10k / WCN3990: firmware-5.bin and wlanmdsp.mbn being out of sync

2023-12-04 Thread Kalle Valo
Dmitry Baryshkov writes: > On Mon, 4 Dec 2023 at 14:56, Kalle Valo wrote: > >> >> Hi Dmitry, >> >> Dmitry Baryshkov writes: >> >> > I wanted to ask your opinion regarding one of the issues we stumbled >> > upon on the Qualcomm RB1 a

Re: ath10k/ath11k board data

2023-12-04 Thread Kalle Valo
Dmitry Baryshkov writes: > I just wanted to check whether you have plans to update ath10k / > ath11k board data files. The last update was IIRC 9 months ago. It is very high on my todo list. I was supposed to start processing that already last week but it got delayed as usual :) --

Re: ath10k / WCN3990: firmware-5.bin and wlanmdsp.mbn being out of sync

2023-12-04 Thread Kalle Valo
Hi Dmitry, Dmitry Baryshkov writes: > I wanted to ask your opinion regarding one of the issues we stumbled > upon on the Qualcomm RB1 and RB2 platforms. These platforms use ath10k > snoc (WCN3990) WiFi "card". We noticed the following messages being > spawned on the console, which I traced it

Re: [PATCH] wifi: ath10k: Default to board.bin for legacy board data file

2023-12-04 Thread Kalle Valo
Dmitry Baryshkov writes: > On Sat, 26 Aug 2023 at 08:44, Kalle Valo wrote: >> >> Dmitry Baryshkov writes: >> >> > Default to 'board.bin' for the legacy board data file, in case the >> > hw_params array doesn't list hw-specific board data file name (e.g.

Re: [PATCH 1/4] wifi: ath10k: remove ath10k_htc_record::pauload[]

2023-11-30 Thread Kalle Valo
Jeff Johnson wrote: > The misspelled pauload member of struct ath10k_htc_record is unused, > so remove it. > > Signed-off-by: Jeff Johnson > Signed-off-by: Kalle Valo 3 patches applied to ath-next branch of ath.git, thanks. c7876faa91ab wifi: ath10k: remove ath10k_htc_

Re: [PATCH 1/3] wifi: ath12k: Update Qualcomm Innovation Center, Inc. copyrights

2023-11-30 Thread Kalle Valo
Jeff Johnson wrote: > Update the copyright for all ath12k files modified on behalf of > Qualcomm Innovation Center, Inc. in 2023. > > Signed-off-by: Jeff Johnson > Signed-off-by: Kalle Valo 3 patches applied to ath-next branch of ath.git, thanks. 05205b957661 wifi: ath12k:

Re: [PATCH] wifi: ath10k: Remove unused struct ath10k_htc_frame

2023-11-22 Thread Kalle Valo
Jeff Johnson wrote: > struct ath10k_htc_frame is unused, and since it illogically contains > two consecutive flexible arrays, it could never be used, so remove it. > > No functional changes, compile tested only. > > Signed-off-by: Jeff Johnson > Signed-off-by: Kalle

Re: [PATCH] wifi: ath10k: simplify __ath10k_htt_tx_txq_recalc()

2023-11-22 Thread Kalle Valo
Dmitry Antipov wrote: > Since 'ieee80211_txq_get_depth()' allows NULL for 2nd and > 3rd arguments, simplify '__ath10k_htt_tx_txq_recalc()' by > dropping unused 'frame_cnt'. Compile tested only. > > Signed-off-by: Dmitry Antipov > Acked-by: Jeff Johnson > Signed-off-b

Re: Power save setting while interface is down

2023-11-21 Thread Kalle Valo
James Prestwood writes: > Hi, > > I've noticed a somewhat rare behavior (<1% of the time) where bringing > an interface up fails after disabling power save. This is done by IWD > when a user-option is enabled, and follows an interface > removal/creation. The sequence is: > > 1. Remove default

Re: [PATCH] wifi: ath10k: add support to allow broadcast action from RX

2023-11-14 Thread Kalle Valo
James Prestwood writes: >>> Is there some firmware/driver value that can be queried which tells me >>> if broadcast RX is supported? >> >> A good question for which I don't have an answer. Does anyone else >> know? Do you have a simple test case for this? It would help if >> people could test

Re: [PATCH] wifi: ath10k: add support to allow broadcast action from RX

2023-11-14 Thread Kalle Valo
James Prestwood writes: > On 11/13/23 7:50 AM, Kalle Valo wrote: >> James Prestwood wrote: >> >>> Advertise support for multicast frame registration and update the RX >>> filter with FIF_MCAST_ACTION to allow broadcast action frames to be >>> re

Re: [PATCH] wifi: ath10k: add support to allow broadcast action from RX

2023-11-13 Thread Kalle Valo
nge requests. > > Signed-off-by: James Prestwood > Signed-off-by: Kalle Valo On what hardware and firmware did you test with this? As there's so many different combinations in ath10k we use Tested-on tag to document that. https://wireless.wiki.kernel.org/en/users/drivers/ath10k/sub

Re: [PATCH v2] wifi: ath10k: replace deprecated strncpy with memcpy

2023-10-31 Thread Kalle Valo
https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings > [1] > Link: https://github.com/KSPP/linux/issues/90 > Cc: linux-harden...@vger.kernel.org > Signed-off-by: Justin Stitt > Acked-by: Jeff Johnson > Signed-off-by: Kalle Valo P

Re: [PATCH] ath10k: replace deprecated strncpy with strtomem_pad

2023-10-24 Thread Kalle Valo
Justin Stitt writes: > strncpy() is deprecated [1] and we should prefer less ambiguous > interfaces. > > In this case, arvif->u.ap.ssid has its length maintained by > arvif->u.ap.ssid_len which indicates it may not need to be > NUL-terminated, although by virtue of using strtomem_pad (with

Re: [PATCH 2/2] ath10k: mac: enable WIPHY_FLAG_CHANNEL_CHANGE_ON_BEACON on ath10k

2023-10-13 Thread Kalle Valo
Kalle Valo writes: > Abhishek Kumar wrote: > >> Enabling this flag, ensures that reg_call_notifier is called >> on beacon hints from handle_reg_beacon in cfg80211. This call >> propagates the channel property changes to ath10k driver, thus >> changing the chan

Re: chan info: invalid frequency 0 (idx 41 out of bounds)

2023-10-12 Thread Kalle Valo
"Luca Weiss" writes: > Anybody have an idea about the issue I sent a few months ago? I don't recall anyone reporting anything similar before. As the ath10k firmware can be different on devices it is a possibility that's something specific with your firmware version. Unfortunately I don't have

  1   2   3   4   5   6   7   8   9   10   >