Re: [Autotest] Python3 and Autotest
Hi all, On 04/22/2018 01:18 AM, Plamen Dimitrov wrote: > Don't worry, take your time. I will add further revisions in the coming > days perhaps even afterwards. Feel free to look at it when you have > time. I will add any recommendations on your side together with other > fixes during these weeks. > There have been multiple revisions on the python3-master branch which is not fully functional at least for all our own use cases. I would advise for anyone that would like to work on top of it to simply checkout there, add small fixes here and there if necessary and then speak back to me so that we can integrate them for a seamless development experience on top of the branch. Other than that, a lot of work has also been done on the virt-test side which remains a significant chunk of Autotest up to date. I know it is deprecated officially but because of its importance for Autotest and because we still use it I would like to contribute that code as well if you don't mind. It will reside on its own python3-master branch for which I need access right as well. If no one is interested in using the repo (which they shouldn't considering it's deprecated) they shouldn't bother about the extra python 3 code there but if they do it can still be really useful. Tell me what you think, Plamen signature.asc Description: OpenPGP digital signature ___ Autotest-kernel mailing list Autotest-kernel@redhat.com https://www.redhat.com/mailman/listinfo/autotest-kernel
Re: [Autotest] Python3 and Autotest
Don't worry, take your time. I will add further revisions in the coming days perhaps even afterwards. Feel free to look at it when you have time. I will add any recommendations on your side together with other fixes during these weeks. On 21.04.2018 18:21, Lucas Meneghel Rodrigues wrote: > I'll take a look at the branch ASAP > > On Sat, Apr 21, 2018, 5:05 PM Plamen Dimitrov wrote: > >> On 04/18/2018 02:36 PM, Lucas Meneghel Rodrigues wrote: >>> Great, thanks for the update! >> Alright, I have pushed a branch called *python3-master* which is a draft >> at its earliest stage. Hopefully it will gradually be refined in the >> coming weeks (I intend to do much more testing from the virt-test side) >> and will eventually become as worthy as the actual python2 master. >> >> Any reviews and thoughts on the current draft are absolutely welcome. >> There is a lot of work ahead with multiple full branch revisions to comes. >> >> Best, >> Plamen >> >> signature.asc Description: OpenPGP digital signature ___ Autotest-kernel mailing list Autotest-kernel@redhat.com https://www.redhat.com/mailman/listinfo/autotest-kernel
Re: [Autotest] Python3 and Autotest
I'll take a look at the branch ASAP On Sat, Apr 21, 2018, 5:05 PM Plamen Dimitrov wrote: > On 04/18/2018 02:36 PM, Lucas Meneghel Rodrigues wrote: > > Great, thanks for the update! > > Alright, I have pushed a branch called *python3-master* which is a draft > at its earliest stage. Hopefully it will gradually be refined in the > coming weeks (I intend to do much more testing from the virt-test side) > and will eventually become as worthy as the actual python2 master. > > Any reviews and thoughts on the current draft are absolutely welcome. > There is a lot of work ahead with multiple full branch revisions to comes. > > Best, > Plamen > > ___ Autotest-kernel mailing list Autotest-kernel@redhat.com https://www.redhat.com/mailman/listinfo/autotest-kernel
Re: [Autotest] Python3 and Autotest
On 04/18/2018 02:36 PM, Lucas Meneghel Rodrigues wrote: > Great, thanks for the update! Alright, I have pushed a branch called *python3-master* which is a draft at its earliest stage. Hopefully it will gradually be refined in the coming weeks (I intend to do much more testing from the virt-test side) and will eventually become as worthy as the actual python2 master. Any reviews and thoughts on the current draft are absolutely welcome. There is a lot of work ahead with multiple full branch revisions to come. Best, Plamen signature.asc Description: OpenPGP digital signature ___ Autotest-kernel mailing list Autotest-kernel@redhat.com https://www.redhat.com/mailman/listinfo/autotest-kernel
Re: [Autotest] Python3 and Autotest
On 04/17/2018 05:02 PM, Lucas Meneghel Rodrigues wrote: Chris, I take that you need compatibility with 2.7, is that right? My requirement is that master remain planetoid-stable (rocks aren't good enough). As in, barring some horrible terrible magnificent bug, I need master basically as-is, warts included. Perhaps if not a branch, how about an "official" fork instead? Like autotest/autotest3, or autotest/python3, something like that? That would circumvent some of the github-permissions oddities, and not risk any chance of breaking tests that rely on old/odd 2.7 behaviors we're not aware of, but don't want to learn about :D -- Chris Evich, RHCA IV Senior Quality Assurance Engineer Theory and practice are the same, except in practice. ___ Autotest-kernel mailing list Autotest-kernel@redhat.com https://www.redhat.com/mailman/listinfo/autotest-kernel
Re: [Autotest] Python3 and Autotest
Great, thanks for the update! On Wed, Apr 18, 2018, 10:23 AM Plamen Dimitrov wrote: > On 04/18/2018 12:02 AM, Lucas Meneghel Rodrigues wrote: > > On Tue, Apr 17, 2018 at 7:26 PM, Plamen Dimitrov > wrote: > >> On 04/17/2018 06:19 PM, Lucas Meneghel Rodrigues wrote: > >>> I suppose we can make autotest work with a dialect compatible with > >>> python2.7 and python3.x. The problem however is the man power required > >>> to go through the codebase and make the adjustments. Sure, I can make > >>> a bunch of semi-automated changes to ease the fine grained work, but > >>> testing and getting to a point where it's fully python3 compliant is > >>> something that we don't have the resources to go through. Avocado took > >>> Cleber, Lukas and Amador many release cycles to get it 100% done. > >> Your second point about 100% compatibility is perhaps more important > here. > >> We are only making solid use of the autotest client code so > compatibility > >> with python 3.4 there suffices for us. Nevertheless, perhaps the branch > >> can be of use to someone and the cost of maintenance should be low > considering > >> the inactive development at the present. I could also maintain the > branch > >> since we are interested in having the most recent master version at all > times. > > I'll be happy to take your branch and incorporate the changes to the > > client, and perhaps make it to master even. With my limited bandwidth > > I can look into unittests. > > > > Let's share this work. I also have no problem making you an autotest > > contributor, which should let you push to branches. > > That's great news! Alright, I will update you once I have the changes > available for additional review. I can also help out with unit tests and > whatever is necessary but we can talk about this later on. If you think > we have to move further communication to a different medium to discuss > code- and maintenance-specific issues, I can do so as well. > > >> On 04/17/2018 06:26 PM, Lucas Meneghel Rodrigues wrote: > Though dated, just about all problems are known, and with it in > maintenance-mode, it's a really stable testing framework (some warts > included). > >>> I'll take a look at some of the low hanging fruit if work allows me :) > >> The current compatibility coverage I talk about above is sufficient to > >> run the autotest client code and the virt-test (deprecated I know) > modules > >> without a problem but I can make an extra effort for the unit tests at > >> least for the client code if we think about having an upstream branch > >> for this. I hope the effort for it shouldn't be much larger. > > Sure. I'm willing to help getting this done. Is the code also > > compatible with py 2.7? > > Mostly yes, there are a few cases that I have to recheck to confirm. > Since the original idea was to make the code compatible with 3.4 and > offer it as an extra branch I didn't put much effort in backwards > compatibility as well. This shouldn't be too hard to accomplish however, > especially considering that the original code is python 2.7 compatible. > > Best, > Plamen > > ___ Autotest-kernel mailing list Autotest-kernel@redhat.com https://www.redhat.com/mailman/listinfo/autotest-kernel
Re: [Autotest] Python3 and Autotest
On 04/18/2018 12:02 AM, Lucas Meneghel Rodrigues wrote: > On Tue, Apr 17, 2018 at 7:26 PM, Plamen Dimitrov > wrote: >> On 04/17/2018 06:19 PM, Lucas Meneghel Rodrigues wrote: >>> I suppose we can make autotest work with a dialect compatible with >>> python2.7 and python3.x. The problem however is the man power required >>> to go through the codebase and make the adjustments. Sure, I can make >>> a bunch of semi-automated changes to ease the fine grained work, but >>> testing and getting to a point where it's fully python3 compliant is >>> something that we don't have the resources to go through. Avocado took >>> Cleber, Lukas and Amador many release cycles to get it 100% done. >> Your second point about 100% compatibility is perhaps more important here. >> We are only making solid use of the autotest client code so compatibility >> with python 3.4 there suffices for us. Nevertheless, perhaps the branch >> can be of use to someone and the cost of maintenance should be low >> considering >> the inactive development at the present. I could also maintain the branch >> since we are interested in having the most recent master version at all >> times. > I'll be happy to take your branch and incorporate the changes to the > client, and perhaps make it to master even. With my limited bandwidth > I can look into unittests. > > Let's share this work. I also have no problem making you an autotest > contributor, which should let you push to branches. That's great news! Alright, I will update you once I have the changes available for additional review. I can also help out with unit tests and whatever is necessary but we can talk about this later on. If you think we have to move further communication to a different medium to discuss code- and maintenance-specific issues, I can do so as well. >> On 04/17/2018 06:26 PM, Lucas Meneghel Rodrigues wrote: Though dated, just about all problems are known, and with it in maintenance-mode, it's a really stable testing framework (some warts included). >>> I'll take a look at some of the low hanging fruit if work allows me :) >> The current compatibility coverage I talk about above is sufficient to >> run the autotest client code and the virt-test (deprecated I know) modules >> without a problem but I can make an extra effort for the unit tests at >> least for the client code if we think about having an upstream branch >> for this. I hope the effort for it shouldn't be much larger. > Sure. I'm willing to help getting this done. Is the code also > compatible with py 2.7? Mostly yes, there are a few cases that I have to recheck to confirm. Since the original idea was to make the code compatible with 3.4 and offer it as an extra branch I didn't put much effort in backwards compatibility as well. This shouldn't be too hard to accomplish however, especially considering that the original code is python 2.7 compatible. Best, Plamen signature.asc Description: OpenPGP digital signature ___ Autotest-kernel mailing list Autotest-kernel@redhat.com https://www.redhat.com/mailman/listinfo/autotest-kernel
Re: [Autotest] Python3 and Autotest
On Tue, Apr 17, 2018 at 7:26 PM, Plamen Dimitrov wrote: > Hi Lucas, > > On 04/17/2018 06:19 PM, Lucas Meneghel Rodrigues wrote: >> I suppose we can make autotest work with a dialect compatible with >> python2.7 and python3.x. The problem however is the man power required >> to go through the codebase and make the adjustments. Sure, I can make >> a bunch of semi-automated changes to ease the fine grained work, but >> testing and getting to a point where it's fully python3 compliant is >> something that we don't have the resources to go through. Avocado took >> Cleber, Lukas and Amador many release cycles to get it 100% done. >> >> So let's go with 'no'. Like I said, it's possible to do some changes >> to ease the work of an interested party, but going all the way to a >> fully functional python2.7/3.x compliant codebase is something we may >> never see. > > In case you are interested, we already have a working version of Autotest > which is compatible with Python 3.4. Maybe I can offer you a pull request > that you can keep as unmerged python3.4-WIP branch for any party interested > in such compatibility. > > Your second point about 100% compatibility is perhaps more important here. > We are only making solid use of the autotest client code so compatibility > with python 3.4 there suffices for us. Nevertheless, perhaps the branch > can be of use to someone and the cost of maintenance should be low considering > the inactive development at the present. I could also maintain the branch > since we are interested in having the most recent master version at all times. I'll be happy to take your branch and incorporate the changes to the client, and perhaps make it to master even. With my limited bandwidth I can look into unittests. Let's share this work. I also have no problem making you an autotest contributor, which should let you push to branches. > On 04/17/2018 06:26 PM, Lucas Meneghel Rodrigues wrote: >>> I'm unaware of the Fedora/python2 state, but even so, all currently >>> supported releases contain python2, as well as RHEL and CentOS. So from >>> that front, Autotest isn't going away at least within a year or five. >>> >>> Though dated, just about all problems are known, and with it in >>> maintenance-mode, it's a really stable testing framework (some warts >>> included). >> Based on the experience we had with avocado, getting the code base >> 100% python3 compliant is a significant effort. As I said on my e-mail >> to Plamen, there's low hanging fruit that we can deal with, specially >> because that first part is semi-automated. It's the details that take >> the lion's share of the work, and getting all those details right >> requires a commitment I can't make. >> >> I'll take a look at some of the low hanging fruit if work allows me :) > > The current compatibility coverage I talk about above is sufficient to > run the autotest client code and the virt-test (deprecated I know) modules > without a problem but I can make an extra effort for the unit tests at > least for the client code if we think about having an upstream branch > for this. I hope the effort for it shouldn't be much larger. Sure. I'm willing to help getting this done. Is the code also compatible with py 2.7? Chris, I take that you need compatibility with 2.7, is that right? Cheers, Lucas ___ Autotest-kernel mailing list Autotest-kernel@redhat.com https://www.redhat.com/mailman/listinfo/autotest-kernel
Re: [Autotest] Python3 and Autotest
On 04/17/2018 01:26 PM, Plamen Dimitrov wrote: could also maintain the branch since we are interested in having the most recent master version at all times. lmr, Those are always magic-words for me :D I dunno the wonky github permissions system would allow granting maintainership to a single branch :S That seems it might be the biggest stumbling block (maybe). Otherwise IMHO, having a python3.4-WIP off to the side sounds like a perfectly sane compromise. Who knows, maybe others are interested in helping with it as well. -- Chris Evich, RHCA IV Senior Quality Assurance Engineer Theory and practice are the same, except in practice. ___ Autotest-kernel mailing list Autotest-kernel@redhat.com https://www.redhat.com/mailman/listinfo/autotest-kernel
Re: [Autotest] Python3 and Autotest
Hi Lucas, On 04/17/2018 06:19 PM, Lucas Meneghel Rodrigues wrote: > I suppose we can make autotest work with a dialect compatible with > python2.7 and python3.x. The problem however is the man power required > to go through the codebase and make the adjustments. Sure, I can make > a bunch of semi-automated changes to ease the fine grained work, but > testing and getting to a point where it's fully python3 compliant is > something that we don't have the resources to go through. Avocado took > Cleber, Lukas and Amador many release cycles to get it 100% done. > > So let's go with 'no'. Like I said, it's possible to do some changes > to ease the work of an interested party, but going all the way to a > fully functional python2.7/3.x compliant codebase is something we may > never see. In case you are interested, we already have a working version of Autotest which is compatible with Python 3.4. Maybe I can offer you a pull request that you can keep as unmerged python3.4-WIP branch for any party interested in such compatibility. Your second point about 100% compatibility is perhaps more important here. We are only making solid use of the autotest client code so compatibility with python 3.4 there suffices for us. Nevertheless, perhaps the branch can be of use to someone and the cost of maintenance should be low considering the inactive development at the present. I could also maintain the branch since we are interested in having the most recent master version at all times. On 04/17/2018 06:26 PM, Lucas Meneghel Rodrigues wrote: >> I'm unaware of the Fedora/python2 state, but even so, all currently >> supported releases contain python2, as well as RHEL and CentOS. So from >> that front, Autotest isn't going away at least within a year or five. >> >> Though dated, just about all problems are known, and with it in >> maintenance-mode, it's a really stable testing framework (some warts >> included). > Based on the experience we had with avocado, getting the code base > 100% python3 compliant is a significant effort. As I said on my e-mail > to Plamen, there's low hanging fruit that we can deal with, specially > because that first part is semi-automated. It's the details that take > the lion's share of the work, and getting all those details right > requires a commitment I can't make. > > I'll take a look at some of the low hanging fruit if work allows me :) The current compatibility coverage I talk about above is sufficient to run the autotest client code and the virt-test (deprecated I know) modules without a problem but I can make an extra effort for the unit tests at least for the client code if we think about having an upstream branch for this. I hope the effort for it shouldn't be much larger. Thanks for your replies, Plamen signature.asc Description: OpenPGP digital signature ___ Autotest-kernel mailing list Autotest-kernel@redhat.com https://www.redhat.com/mailman/listinfo/autotest-kernel
Re: [Autotest] Python3 and Autotest
On Wed, Apr 11, 2018 at 9:58 PM, Chris Evich wrote: > On 04/11/2018 03:21 PM, Plamen Dimitrov wrote: >> >> Is there any chance of Autotest possibly moving to python 3 or is the plan >> to leave it on >> python 2 and let it deprecate in the same way while moving all effort to >> avocado? > > > I'm pretty sure this will never happen. Waay back in the day (years > ago) I asked LMR the same question, he just laughed :D Even with 2.7 > growing long in the tooth, the standard for Autotest was always 2.4 > compatibility. True, we had to keep 2.4 compatibility for longer than I'd like to admit (RHEL 5, I'm looking at you :)). Nowadays, I'd prefer to leave it 2.7 compliant. > I'm unaware of the Fedora/python2 state, but even so, all currently > supported releases contain python2, as well as RHEL and CentOS. So from > that front, Autotest isn't going away at least within a year or five. > > Though dated, just about all problems are known, and with it in > maintenance-mode, it's a really stable testing framework (some warts > included). Based on the experience we had with avocado, getting the code base 100% python3 compliant is a significant effort. As I said on my e-mail to Plamen, there's low hanging fruit that we can deal with, specially because that first part is semi-automated. It's the details that take the lion's share of the work, and getting all those details right requires a commitment I can't make. I'll take a look at some of the low hanging fruit if work allows me :) Cheers, Lucas ___ Autotest-kernel mailing list Autotest-kernel@redhat.com https://www.redhat.com/mailman/listinfo/autotest-kernel
Re: [Autotest] Python3 and Autotest
Hi Plamen, I suppose we can make autotest work with a dialect compatible with python2.7 and python3.x. The problem however is the man power required to go through the codebase and make the adjustments. Sure, I can make a bunch of semi-automated changes to ease the fine grained work, but testing and getting to a point where it's fully python3 compliant is something that we don't have the resources to go through. Avocado took Cleber, Lukas and Amador many release cycles to get it 100% done. So let's go with 'no'. Like I said, it's possible to do some changes to ease the work of an interested party, but going all the way to a fully functional python2.7/3.x compliant codebase is something we may never see. Cheers, Lucas On Wed, Apr 11, 2018 at 9:21 PM, Plamen Dimitrov wrote: > Hi all, > > I know Autotest is not under active development and virt-test is already > deprecated, > but I was still wondering about the future plans on it regarding the > deprecation of python2. > > In particular: > > - upstream Python 2.7 support expires on 2020-01-01 > (https://lwn.net/Articles/750846/) > - there will never be another Python 2.x feature release > (https://legacy.python.org/dev/peps/pep-0404/) > - Fedora is already expiring Python 2 packages wherever possible > (https://lwn.net/Articles/750849/) > > Is there any chance of Autotest possibly moving to python 3 or is the plan to > leave it on > python 2 and let it deprecate in the same way while moving all effort to > avocado? > > I will be glad to hear your thoughts on the matter, > Plamen > > > ___ > Autotest-kernel mailing list > Autotest-kernel@redhat.com > https://www.redhat.com/mailman/listinfo/autotest-kernel -- Lucas ___ Autotest-kernel mailing list Autotest-kernel@redhat.com https://www.redhat.com/mailman/listinfo/autotest-kernel
Re: [Autotest] Python3 and Autotest
On 04/11/2018 03:21 PM, Plamen Dimitrov wrote: Is there any chance of Autotest possibly moving to python 3 or is the plan to leave it on python 2 and let it deprecate in the same way while moving all effort to avocado? I'm pretty sure this will never happen. Waay back in the day (years ago) I asked LMR the same question, he just laughed :D Even with 2.7 growing long in the tooth, the standard for Autotest was always 2.4 compatibility. I'm unaware of the Fedora/python2 state, but even so, all currently supported releases contain python2, as well as RHEL and CentOS. So from that front, Autotest isn't going away at least within a year or five. Though dated, just about all problems are known, and with it in maintenance-mode, it's a really stable testing framework (some warts included). -- Chris Evich, RHCA IV Senior Quality Assurance Engineer Theory and practice are the same, except in practice. ___ Autotest-kernel mailing list Autotest-kernel@redhat.com https://www.redhat.com/mailman/listinfo/autotest-kernel
[Autotest] Python3 and Autotest
Hi all, I know Autotest is not under active development and virt-test is already deprecated, but I was still wondering about the future plans on it regarding the deprecation of python2. In particular: - upstream Python 2.7 support expires on 2020-01-01 (https://lwn.net/Articles/750846/) - there will never be another Python 2.x feature release (https://legacy.python.org/dev/peps/pep-0404/) - Fedora is already expiring Python 2 packages wherever possible (https://lwn.net/Articles/750849/) Is there any chance of Autotest possibly moving to python 3 or is the plan to leave it on python 2 and let it deprecate in the same way while moving all effort to avocado? I will be glad to hear your thoughts on the matter, Plamen signature.asc Description: OpenPGP digital signature ___ Autotest-kernel mailing list Autotest-kernel@redhat.com https://www.redhat.com/mailman/listinfo/autotest-kernel
