Re: [Patch] SHAPE stuff *again*

2009-06-23 Thread Julien Danjou
At 1245756208 time_t, Uli Schlachter wrote: +size = width * height; Seems unused. +static void +do_update_shape(xcb_window_t win, xcb_shape_kind_t kind, image_t *image, int offset) +{ +xcb_pixmap_t shape; + +if(!image) +{ +/* Reset the shape */ +shape

Re: [Patch] SHAPE stuff *again*

2009-06-23 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Julien Danjou wrote: At 1245756208 time_t, Uli Schlachter wrote: +size = width * height; Seems unused. Seems you are right. http://git.znc.in/?p=psychon/awesome.git;a=commitdiff;h=56d73102ea8995c911664f0203f77f7a3dc0767d +static void

Re: [Patch] SHAPE stuff *again*

2009-06-23 Thread Julien Danjou
At 1245761941 time_t, Uli Schlachter wrote: Uhm, how would I do that? I would need to do some evil math with cos and sin for this and then loop through the single pixels... I'm not a geometry expert but if you need to draw a top left corner: ++ |1 / | |/ 2 | ++ (1 is being

Re: [Patch] SHAPE stuff *again*

2009-06-23 Thread Uli Schlachter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Julien Danjou wrote: At 1245761941 time_t, Uli Schlachter wrote: Uhm, how would I do that? I would need to do some evil math with cos and sin for this and then loop through the single pixels... I'm not a geometry expert but if you need to

Re: [Patch] SHAPE stuff *again*

2009-06-23 Thread Maarten Maathuis
Could the interface be simplified to leave the border related calculations on the C side? This was done for geometry to make the code clearer, is there any reason to not do that here? Maarten. -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.

Re: [Patch] SHAPE stuff *again*

2009-06-23 Thread Julien Danjou
At 1245766970 time_t, Maarten Maathuis wrote: Could the interface be simplified to leave the border related calculations on the C side? This was done for geometry to make the code clearer, is there any reason to not do that here? Because you can have border that are not regular I guess. --

Re: [Patch] SHAPE stuff *again*

2009-06-23 Thread Maarten Maathuis
I wasn't expecting custom borders, so ignore me. Maarten. -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.