Re: [9] Review request for 8143914: Provide Mac-specific fullscreen support

Please see the updated webrev: http://cr.openjdk.java.net/~azvegint/jdk/9/8143914/02/ Thanks, Alexander. On 10/11/16 5:00 PM, Alexander Zvegintsev wrote: Hi Sergey, Please see the updated webrev: http://cr.openjdk.java.net/~azvegint/jdk/9/8143914/01/ As I can observe other windows

Re: [9] Review request for 8166594: Taskbar.setWindowProgressValue() spec does not specify expected visual behavior of setWindowProgressValue()

Updated the "behavior is undefined" section: http://cr.openjdk.java.net/~azvegint/jdk/9/8166594/01/ Thanks, Alexander. On 10/6/16 6:14 PM, Semyon Sadetsky wrote: On 10/6/2016 3:38 PM, Alexander Zvegintsev wrote: Hi Semyon, Yes it is, Microsoft defined some set of rules for s

Re: [9] Review request for 8166897: Some font overlap in the Optionpane dialog.

+1 Thanks, Alexander. On 10/13/16 12:12 AM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8166897 webrev: http://cr.openjdk.java.net/~ssadetsky/8166897/webrev.00/ The setResizable() method of XDecoratedPeer class clears the frame

Re: [9] Review Request: 8143077 Deprecate InputEvent._MASK in favor of InputEvent._DOWN_MASK

Looks good. On 10/7/16 4:21 PM, Sergey Bylokhov wrote: On 07.10.16 10:06, Semyon Sadetsky wrote: Hi Sergey, After applying the patch I found 72 usages of the Event class. Why they are not replaced? By the same reason why InputEvent.getModifiers() was not replaced by

[9] Review request for 8167565: [macosx] Maximization of a dialog hides it

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8167565/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8167565 We trying to zoom to a zero size window(standardFrame has zero size). standardFrame initialization happens on setMaximizedBounds call. Dialog

Re: [9] Review request for 8143914: Provide Mac-specific fullscreen support

Actually I can't reproduce such behavior. On 9/30/16 5:12 PM, Semyon Sadetsky wrote: The fix looks good. Do you know why JDialog maximize button doesn't work? When I click on it the maximize button the dialog disappears. --Semyon On 9/6/2016 5:32 PM, Alexander Zvegintsev wrote: Hello

Re: RFR: JDK-8165232 XKeycodeToKeysym is deprecated and should be replaced with XkbKeycodeToKeysym

+1 P.S. It wasn't hard to find, but the webrev is updated at the first revision http://cr.openjdk.java.net/~alanbur/JDK-8165232 -- Thanks, Alexander. On 06.10.2016 13:18, Alan Burlison wrote: On 04/10/2016 19:34, Alan Burlison wrote: key_syms is not freed. So there is, thanks for the

Re: [9] Review request for 8166594: Taskbar.setWindowProgressValue() spec does not specify expected visual behavior of setWindowProgressValue()

lines to make them following the 80 chars maximum? --Semyon On 06.10.2016 04:56, Alexander Zvegintsev wrote: Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8166594/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8166594 It also fixes two issues

Re: [9] Review request for 8166942: Usage of SplashScreen Functions hangs up FX Application

You are right, it it undefined behavior. On 10/6/16 10:02 AM, Semyon Sadetsky wrote: Hi Alexander, Is it safe to lock the mutex on one thread and unlock it on another? --Semyon On 06.10.2016 06:08, Alexander Zvegintsev wrote: Hello, please review the fix http://cr.openjdk.java.net

[9] Review request for 8166942: Usage of SplashScreen Functions hangs up FX Application

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8166942/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8166942 SplashEventLoop() acquires the lock[0] and then trying to call SplashRedrawWindow() which is trying execute some code on the main thread[1].

[9] Review request for 8166594: Taskbar.setWindowProgressValue() spec does not specify expected visual behavior of setWindowProgressValue()

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8166594/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8166594 It also fixes two issues to conform the documentation: setting value below 0 doesn't disable progress indication switching from indeterminate

Re: RFR: JDK-8165232 XKeycodeToKeysym is deprecated and should be replaced with XkbKeycodeToKeysym

Hello, as I can see there is a memory leak in case when the index is greater than or equal to num_syms: 837 KeySym *key_syms = XGetKeyboardMapping(display, keycode, 1, _syms); 838 if (index >= num_syms) { 839 return NoSymbol; 840 } key_syms is not freed. -- Thanks, Alexander. On 10/4/16

Re: [9] Review Request for 8141528: Test closed/java/awt/FullScreen/DisplayMode/CycleDMImage.java fails for Ubuntu 15.10

Looks fine. -- Thanks, Alexander. On 10/03/2016 07:38 PM, Semyon Sadetsky wrote: The fix is updated http://cr.openjdk.java.net/~ssadetsky/8141528/webrev.01/ The root case of the issue is that in Unity the screen window size and location are get updated several times after display mode is

Re: [9] Review request for 8159432: [PIT][macosx] StackOverflow in closed/java/awt/Dialog/DialogDeadlock/DialogDeadlockTest

looks good to me. -- Thanks, Alexander. On 24.08.2016 22:18, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8159432 webrev: http://cr.openjdk.java.net/~ssadetsky/8159432/webrev.00/ The issue is connected to the restoring focus to the

Re: [9] Review request for 8154434: Open the request focus methods of the java.awt.Component which accept FocusEvent.Cause

Looks good to me. -- Thanks, Alexander. On 26.04.2016 16:14, Semyon Sadetsky wrote: On 4/26/2016 3:49 PM, Philip Race wrote: > In applications one may need to know the reason why focus is requested I do not mean why should apps want to *know* the cause. I am asking why apps should be able

Re: [9] Review request for 8165619: Frame is not repainted if created in state=MAXIMIZED_BOTH on Unity

Looks good to me. -- Thanks, Alexander. On 23.09.2016 16:15, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8165619 webrev: http://cr.openjdk.java.net/~ssadetsky/8165619/webrev.00/ If frame is created in maximized the window extent

Re: [9] Review Request for 8041519: JVM crash on second DnD after modal dialog opened during Swing DnD operation

Looks good to me. On 7/17/15 7:27 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8041519 webrev: http://cr.openjdk.java.net/~ssadetsky/8041519/webrev.00/ This is regression from JDK-6342381. When a modal dialog blocks drop

Re: [9] Review request for 8161910: [PIT] regression: HW/LW mixing seems broken on Unity

Looks good to me. On 8/30/16 7:18 PM, Semyon Sadetsky wrote: Sorry for inconvenience, but I have to update this fix once again. http://cr.openjdk.java.net/~ssadetsky/8161910/webrev.02 I have found the main root cause of the issue. In the 8036815 I have missed one insets_corrected = true;

Re: [9] Review Request: 8004693 TEST_BUG: java/awt/KeyboardFocusmanager/DefaultPolicyChange/DefaultPolicyChange_Swing.java fails

Looks good to me. On 5/30/16 7:39 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. The test DefaultPolicyChange_Swing.java has two issues: - It uses invokeLater(), so the test usually pass before the code is executed on the EDT, because the main thread completes before. -

[9] Review request for 8140311: SwingInterop crashes at window close

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8140311/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8140311 This issue is only reproducible when a window using CWarningWindow. After window close we cancel HidingTask in CWarningWindow at java level,

Re: [9] Review Request for 8141528: Test closed/java/awt/FullScreen/DisplayMode/CycleDMImage.java fails for Ubuntu 15.10

Hi Semyon, I believe that this webrev should be updated to use isUnityCompiz(). -- Thanks, Alexander. On 07.12.2015 14:11, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8141528 webrev:

Re: [9] Review request for 8164536: enableSuddenTermination() - Not throws SecurityException if a security manager exists and it will not allow the caller to invoke System.exit

/2016 04:53 PM, Sergey Bylokhov wrote: On 31.08.16 3:27, Alexander Zvegintsev wrote: Hi Sergey, It could be, but actually RuntimePermission is used by eawt(sure we can change it too, but I don't see a point) It is still unclear to me why in most of the place we check two permissions? Can you

Re: [9] Review request for 8153526: [Unity] Taskbar.getTaskbar().setMenu(null) doesn't remove menu

. On 06.09.16 20:56, Alexander Zvegintsev wrote: Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8153526/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8153526

[9] Review request for 8153526: [Unity] Taskbar.getTaskbar().setMenu(null) doesn't remove menu

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8153526/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8153526 -- Thanks, Alexander.

[9] Review request for 8143914: Provide Mac-specific fullscreen support

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8143914/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8143914 This fix adds the green FullScreen button to a resizable frames by default. Previous maximize behavior is still accessible by holding Alt while

Re: [9] Review request for 8164536: enableSuddenTermination() - Not throws SecurityException if a security manager exists and it will not allow the caller to invoke System.exit

or require similar permissions. On 30.08.16 21:58, Alexander Zvegintsev wrote: Hello, Please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8164536/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8164536 This fix add check for canProcessApplicationEvents runtime

[9] Review request for 8164536: enableSuddenTermination() - Not throws SecurityException if a security manager exists and it will not allow the caller to invoke System.exit

Hello, Please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8164536/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8164536 This fix add check for canProcessApplicationEvents runtime permission(currently used by eawt) for Desktop and Taskbar classes. -- Thanks,

Re: [9] Review request for 8162840: Desktop. enableSuddenTermination() has no effect

to create a test for the fix? On 16.08.16 19:20, Alexander Zvegintsev wrote: Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8162840/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8162840 We don't call QuitHandler and using default QuitStrategy if sudden

[9] Review request for 8162840: Desktop. enableSuddenTermination() has no effect

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8162840/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8162840 We don't call QuitHandler and using default QuitStrategy if sudden termination is enabled. -- Thanks, Alexander.

Re: [9] Review request for 8161007: GPL header missing comma in year - not swapped in licensee bundles

+1 On 7/19/16 2:28 PM, Alexandr Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 7/15/2016 2:46 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8161007 webrev:

Re: [9] Review Request for 8036915: setLocationRelativeTo stopped working in Ubuntu 13.10 (Unity)

Hi Semyon, The fix looks good to me. Thanks, Alexander. On 07/13/2016 01:28 PM, Semyon Sadetsky wrote: Please review an updated version of the fix: http://cr.openjdk.java.net/~ssadetsky/8036915/webrev.02/ The solution was completely changed. The frame insets correction algorithm is

Re: [9] Review request for 8159460: On Ubuntu Unity, problem with java/awt/Window/FindOwner/FindOwnerTest

Looks good to me. -- Thanks, Alexander. On 17.06.2016 11:42, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8159460 webrev: http://cr.openjdk.java.net/~ssadetsky/8159460/webrev.00/ On Unity WM_TAKE_FOCUS notification is sent to the

Re: [9] Review request for 8153512: Taskbar support reported for Xfce4.

Hi Semyon, please see the updated webrev http://cr.openjdk.java.net/~azvegint/jdk/9/8153512/01/ Thanks, Alexander. On 07/12/2016 05:22 PM, Semyon Sadetsky wrote: Hi Alexander, I would use a static variable and check it once only. --Semyon On 12.07.2016 16:56, Alexander Zvegintsev wrote

[9] Review request for 8153512: Taskbar support reported for Xfce4.

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8153512/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8153512 -- Thanks, Alexander.

Re: [9] Review request for 8149115: [hidpi] Linux: display-wise scaling factor should probably be taken into account

/8149115/webrev.03/ --Semyon On 7/7/2016 9:57 AM, Alexandr Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 7/6/2016 11:46 PM, Alexander Zvegintsev wrote: Still looks good. -- Thanks, Alexander. On 06.07.2016 21:42, Semyon Sadetsky wrote: Thanks, Alexander. Please see the updated

Re: [9] Review request for 8149115: [hidpi] Linux: display-wise scaling factor should probably be taken into account

Still looks good. -- Thanks, Alexander. On 06.07.2016 21:42, Semyon Sadetsky wrote: Thanks, Alexander. Please see the updated webrev http://cr.openjdk.java.net/~ssadetsky/8149115/webrev.02/ --Semyon On 7/6/2016 9:03 PM, Alexander Zvegintsev wrote: The fix looks good to me. Just a minor

Re: [9] Review request for 8149115: [hidpi] Linux: display-wise scaling factor should probably be taken into account

The fix looks good to me. Just a minor comment: multiple NULL checks in get_schema_value could be wrapped in CHECK_NULL_RETURN macro, e.g.: CHECH_NULL_RETURN(fp_g_settings_schema_has_key = dlsym(lib_handle, "g_settings_schema_has_key"), NULL);

[9] Review request for 8159374 : Taskbar.setIconBadge() spec omits mention of exception for ICON_BADGE_TEXT feature

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8159374/00 for the issue https://bugs.openjdk.java.net/browse/JDK-8159374 -- -- Thanks, Alexander.

Re: CFV: New AWT Group Lead: Sergey Bylokhov

Vote: yes -- Thanks, Alexander. On 10.06.2016 18:39, Artem Ananiev wrote: Hi, AWT team, I hereby nominate Sergey Bylokhov (OpenJDK user name: serb) to AWT Group Lead [1]. Sergey is a member of Java Client group at Oracle. He has been one of the most active contributors to AWT (and other

Re: Taking screenshots on x11 composite desktop produce wrong result

Looks fine to me. Thanks, Alexander. On 31/05/16 17:29, Sergey Bylokhov wrote: Hi, Mario. Thanks for your contribution! there is tiny typo in the native: isGtkSupported should be useGtk. It will be good if someone run jprt job to confirm that the build is ok, since make file was changed.

Re: [8u/9] Review request 8156116 : [macosx] two JNI locals to delete in AWTWindow.m, CGraphicsEnv.m

Looks fine to me too. Thanks, Alexander. On 05/17/2016 06:36 PM, Anton Tarasov wrote: Would anyone else please review the fix? Thanks Anton. On 5/5/2016 12:45 PM, Sergey Bylokhov wrote: Looks fine. On 05.05.16 10:50, Anton Tarasov wrote: Hello, Please, review a simple fix: webrev:

Re: Review-request for 8143227: Platform-Specific Desktop Features

Fixed: http://cr.openjdk.java.net/~azvegint/jdk/9/8143227/09/ -- Thanks, Alexander. On 03/05/2016 04:10 AM, Mandy Chung wrote: On Mar 4, 2016, at 11:07 AM, Phil Race wrote: Approved. -phil. One comment on something you can't do anything about *yet*, is that adding a

Re: Review-request for 8143227: Platform-Specific Desktop Features

ad permission for the file as well. At the end it is an interesting question: what permissions are needed to delete the file. On 21.02.16 14:38, Alexander Zvegintsev wrote: Hi Phil, please see updated the webrev here http://cr.openjdk.java.net/~azvegint/jdk/9/8143227/08/ and comments inline On

Re: Review-request for 8143227: Platform-Specific Desktop Features

used to return null. Now it can. So do we really want to add more places that we need to fix ? In other words I don't think the fix is going to be to revert to it not returning null, so you are going to have to deal with it directly here. -phil. On 2/21/16, 5:08 PM, Alexander Zvegintsev wrote: Hi

Re: [9] Review Request for 8021961: setAlwaysOnTop doesn't behave correctly in Linux/Solaris under certain scenarios

+1 -- Thanks, Alexander. On 10.02.2016 14:06, Sergey Bylokhov wrote: Looks fine. On 01.10.15 21:27, Semyon Sadetsky wrote: The fix is amended : plese review the new version http://cr.openjdk.java.net/~ssadetsky/8021961/webrev.01/ It is taken into account that the transientFor chain may be

Re: [9] Review reuest for 8036915: setLocationRelativeTo stopped working in Ubuntu 13.10 (Unity)

Hi Sergey, Yes, it is, anyway I can see only a part of the fix in this webrev. -- Thanks, Alexander. On 26.02.2016 16:57, Sergey Bylokhov wrote: Hi, Alexander. It seems that this request is withdrawn? On 24.11.14 18:07, Alexander Zvegintsev wrote: Hello, please review the fix http

Re: Review-request for 8143227: Platform-Specific Desktop Features

e, it does exactly how it described. You can have no windows(not even created), no system menu bar and some running thread, AppReopenedListener will be called on click in dock icon or on double click on the application executable. -phil. On 02/16/2016 07:04 AM, Alexander Zvegintsev wrote:

Re: Review-request for 8143227: Platform-Specific Desktop Features

ions ? You do need permission to exit the VM, so should you be able to set a QuitStrategy if you don't have such permission ?? More later .. -phil. On 01/21/2016 11:16 PM, Alexander Zvegintsev wrote: Hi Semyon, I am not sure about flexibility, but providing additional info for a user session chang

Re: Review-request for 8143227: Platform-Specific Desktop Features

. Also this may add flexibility that allows to support new features in the future. --Semyon On 1/17/2016 11:55 PM, Alexander Zvegintsev wrote: Hi Semyon, Is it possible to use WM_QUERYENDSESSION for Action.APP_SUDDEN_TERMINATION? Sure, so please see updated webrev: http://cr.openjdk.java.net

Re: Review-request for 8143227: Platform-Specific Desktop Features

, WDesktopPeer.java: added SuddenTerminaton support for Windows -- Thanks, Alexander. On 01/15/2016 04:14 PM, Semyon Sadetsky wrote: Hi, On 1/15/2016 12:39 PM, Alexander Zvegintsev wrote: Hi Semyon, Yes, it is just LOCK/UNLOCK for now, because it is the most common scenario of desktop usage

Re: Review-request for 8143227: Platform-Specific Desktop Features

CONNECT 0x4 #define WTS_SESSION_LOGON 0x5 #define WTS_SESSION_LOGOFF 0x6 #define WTS_SESSION_LOCK 0x7 #define WTS_SESSION_REMOTE_CONTROL some of them seems to me more suitable to be chosen as the session act/deact event. Could you comment that for me? --Semyon On 11/24/2015 6:02 PM, Alexander Zvegintsev wr

Re: Review-request for 8143227: Platform-Specific Desktop Features

Please review the updated fix: http://cr.openjdk.java.net/~azvegint/jdk/9/8143227/03/ removed fullscreen related code (moved to JDK-8143914 [0]) fix serialization in AppEvent [0] https://bugs.openjdk.java.net/browse/JDK-8143914 Thanks, Alexander. On 11/21/2015 03:33 AM, Alexander Zvegintsev

Re: Review-request for 8143227: Platform-Specific Desktop Features

-- Thanks, Alexander. On 11/20/2015 05:36 PM, Yuri Nesterenko wrote: Hi Alexander, On 11/19/2015 06:23 PM, Alexander Zvegintsev wrote: Hi Yuri, Nice catch! Just tested on Ubuntu 14.04.3, it does not have libunity.so symlink to libuity.so.9. so we should try to load version 9 instead of 0 in awt

Re: Review-request for 8143227: Platform-Specific Desktop Features

.java.html * The strategy use to -> The strategy used to http://cr.openjdk.java.net/~azvegint/jdk/9/8143227/00/src/java.desktop/share/classes/java/awt/desktop/ScreenSleepListener.java.html * have awoke -> have awoken http://cr.openjdk.java.net/~azvegint/jdk/9/8143227/00/src/java.desk

Re: Review-request for 8143227: Platform-Specific Desktop Features

27/00/src/java.desktop/share/classes/java/awt/desktop/QuitStrategy.java.html * The strategy use to -> The strategy used to http://cr.openjdk.java.net/~azvegint/jdk/9/8143227/00/src/java.desktop/share/classes/java/awt/desktop/ScreenSleepListener.java.html * have awoke -> have awoken http:/

Re: Review-request for 8143227: Platform-Specific Desktop Features

Hi Phil, Can someone explain why this is needed given the existing support of GraphicsDevice.setFullScreenWindow(Window) ? GraphicsDevice.setFullScreenWindow is used for an exclusive full screen mode. Mac OS has another option to create a virtual desktop with provided window in it. You

Re: Review-request for 8143227: Platform-Specific Desktop Features

t I don't see BROWSE supported. Thanks, -yan On 11/18/2015 05:01 PM, Alexander Zvegintsev wrote: Hi Alexander, resending the same webrev under the new ID https://bugs.openjdk.java.net/browse/JDK-8143227 http://cr.openjdk.java.net/~azvegint/jdk/9/8143227/00/ The approach is pretty the same as

Re: Review-request for 8048731: JEP 272: Platform-Specific Desktop Features

/~azvegint/jdk/9/8143227/00/src/java.desktop/macosx/classes/sun/lwawt/macosx/CTaskbarPeer.java.html Thanks, Alexander. On 11/19/2015 01:17 AM, Michael Hall wrote: On Nov 18, 2015, at 1:12 AM, Alexander Zvegintsev <alexander.zvegint...@oracle.com <mailto:alexander.zvegint...@oracle.com&g

Review-request for 8048731: JEP 272: Platform-Specific Desktop Features

Hello please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8048731/ for https://bugs.openjdk.java.net/browse/JDK-8048731 This fix provides public support Mac OS X features(com.apple.{eawt,eio}), adds support for various desktop features such as progress indication, dock overlays,

Re: JDK9 Review Request for 8037575: JFrame on Windows doesn't animate when setting ICONIFIED state

: Alexander Scherbatiy Sent: 11 November 2015 19:57 To: Rajeev Chamyal Cc: Sergey Bylokhov; Alexander Zvegintsev; awt-dev@openjdk.java.net Subject: Re: JDK9 Review Request for 8037575: JFrame on Windows doesn't animate when setting ICONIFIED state The fix looks good to me. Thanks

Re: [9] Review Request: 8011541 [TEST_BUG] closed/javax/swing/plaf/metal/MetalUtils/bug6190373.java fails NPE since 7u25b03

looks fine to me. -- Thanks, Alexander. On 10/21/2015 07:32 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. The test emulate implementation of two applets inside one vm. It has two threads in two different threads groups, for one of them it creates an appcontext, and the

Re: [9] Review Request for 8081457: TrayIcon tests fail in OEL 7 only

Hi Semyon, As I can see there are a lot similar checks in tests for OEL7, ideally it should be checked against gnome-shell(probably from DESKTOP_SESSION env variable, or check for running gnome-shell process), but I am OK with the current check. Could you please extract this check to some

Re: Review Request for JDK-8040322 : TextArea.replaceRange() and insert() are broken with setText(null)

Looks fine to me too. Thanks, Alexander. On 09/28/2015 02:11 PM, Ambarish Rapte wrote: Hi Sergey, Thanks for the review. Executed regression tests for TextArea, TextField & also other tests which use any of the TextArea, TextField or TextComponent. => There are NO

Re: JEP 272: Platform-Specific Desktop Features

Hi Anthony, Thank you for your feedback! It seems correct and appropriate to me, so I'll incorporate your suggestions into the JEP. Thanks, Alexander. On 09/27/2015 09:42 AM, Anthony Vanelverdinghe wrote: Hi I have a few questions/comments about the proposed API: - why not add a class

Re: [9] Review Request for 8022334: After calling frame.toBack() dialog goes to the back on Ubuntu 12.04

The fix looks good to me. Thanks, Alexander. On 09/29/2015 08:51 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8022334 webrev: http://cr.openjdk.java.net/~ssadetsky/8022334/webrev.00/ The Unity WM cannot switch top-level windows

Re: RFR: JDK-8134808 Remove support for serialized applets from java.desktop

+1 -- Thanks, Alexander. On 15.09.2015 14:31, Sergey Bylokhov wrote: Looks fine. 14.09.2015 22:12, Daniil Titov wrote: Hello, Please review java.desktop part of the changes for jdk9 that remove the support for serialized applets. Support for serialized applets was added in JDK 1.1 to

Re: < AWT- Dev> [9] Review Request:JDK-8136354 [TEST_BUG]Test java/awt/image/RescaleOp/RescaleAlphaTest.java with Bad action for script

looks fine Thanks, Alexander. On 09/11/2015 01:09 PM, pooja chopra wrote: Hello, Please review a fix for issue :- 8136354 [TEST_BUG]Test java/awt/image/RescaleOp/RescaleAlphaTest.java with Bad action for script Test bug fix. https://bugs.openjdk.java.net/browse/JDK-8136354 The webrev is :

Re: [9] Review Request for 8014725: closed/java/awt/Clipboard/HTMLTransferTest/HTMLTransferTest.html failed intermittently

+1 Thanks, Alexander. On 09/04/2015 05:43 PM, Alexander Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 9/3/2015 4:21 PM, Semyon Sadetsky wrote: Alexanders? Any questions? On 8/5/2015 3:11 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug:

Re: [9] Review request for 8133453 Remove AWTKeyStroke.registerSubclass(Class) method

+1 -- Thanks, Alexander. On 01.09.2015 16:39, Sergey Bylokhov wrote: Looks fine to me. On 01.09.15 13:49, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8133453 webrev: http://cr.openjdk.java.net/~alexsch/8133453/webrev.00

Re: AWT Dev [9] Review Request: 8134603 Incorrect destination is used in CGLLayer surface

+1 Thanks, Alexander. On 08/28/2015 01:30 PM, Alexander Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 8/27/2015 4:49 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. The CGLLayer.java has a typo it uses the peer as a destination, but the target

Re: AWT Dev Swing Dev [9] Review Request:JDK-8130481 [TEST_BUG] javax/swing/JPopupMenu/6583251/bug6583251.java failed with UnsupportedOperation exception

BTW, there is no need in try/catch block. Thanks, Alexander. On 08/27/2015 03:08 PM, Alexander Scherbatiy wrote: On 8/27/2015 1:12 PM, pooja chopra wrote: Hi Alexandr, Please review updated webrev link :- http://cr.openjdk.java.net/~pchopra/8130481/webrev.06/ There are some problems

Re: AWT Dev [9] Review Request: 8047226 closed/java/awt/Component/GetScreenLocTest/GetScreenLocTest.html clicks on Unity's tool bar

Looks fine. Thanks, Alexander. On 08/25/2015 06:28 PM, Sergey Bylokhov wrote: On 25.08.15 17:55, Alexander Zvegintsev wrote: I think that there is no need in RuntimeException in mousePressed() callback, it could be replaced with println and break. makes sense, the new version: http

Re: AWT Dev [9] Review Request: 8047226 closed/java/awt/Component/GetScreenLocTest/GetScreenLocTest.html clicks on Unity's tool bar

Hello Sergey, I think that there is no need in RuntimeException in mousePressed() callback, it could be replaced with println and break. Thanks, Alexander. On 08/25/2015 05:36 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. Test was fixed(the windows were moved to the

AWT Dev [9] Request for review 8134028: [PIT] XToolkit, strange behavior of robot.createScreenCapture(): looks like a native crash in X11/GTK

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8134028/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8134028 In previous robot fix I forgot to wrap gtk calls with gdk_threads_enter/gdk_threads_leave, therefore we have such failure. -- Thanks, Alexander.

Re: AWT Dev Swing Dev [9] Review Request: JDK-8081764 [TEST_BUG] Test javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on Solaris Sparcv9 and Linux but passes on MacOSX

+1 Thanks, Alexander. On 07/29/2015 01:39 PM, Alexander Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 7/29/2015 10:00 AM, pooja chopra wrote: Hi , As default look and feel in mac is aqua only so there is no need of setting system look and feel explicitly.

Re: AWT Dev [9] Review Request: 7124271 [macosx] RealSync test failure

Hello Sergey, the fix looks good to me. -- Thanks, Alexander. On 10.08.2015 14:21, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. Two bugs were fixed: - The changes in NSApplicationAWT.waitForDummyEvent() is a fix for a regression of JDK-8080504, which does not take into

Re: AWT Dev [9] Review Request: 4379403 Need to disable the magic AWT dump key (CTRL+SHIFT+F1)

Hello Sergey, the fix looks good to me. Thanks, Alexander. On 08/10/2015 02:35 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. After the fix a Magic dump key is disabled by default, to enable it the user needs to enable debug mode(via property file or system property).

Re: AWT Dev JDK-8015471 Deadlock or infinit loop in XAWT on Ubuntu 12.04

Hi Cristian, it looks like that I've already fixed this issue as [1] Could you please check if the problem is gone with 8u60? [1] https://bugs.openjdk.java.net/browse/JDK-8129116 Deadlock with multimonitor fullscreen windows. Thanks, Alexander. On 07/30/2015 05:23 PM, Christian wrote:

Re: AWT Dev [9] Review request for 8014212: Robot captures black screen

Hello Sergey, please see the updated version http://cr.openjdk.java.net/~azvegint/jdk/9/8014212/02/ GetPrimitiveArrayCritical() is used instead of manual array allocation. Thanks, Alexander. On 07/27/2015 08:35 PM, Alexander Zvegintsev wrote: Please see the updated version: http

Re: AWT Dev [9] Review Request: 8132355 Incorrect guard block in HPkeysym.h, awt_Event.h

Looks fine. Thanks, Alexander. On 07/27/2015 02:36 PM, Sergey Bylokhov wrote: Hello. Please review the fix for a typo in jdk9. The HPkeysym.h is from external library, so I have filed the bug in upstream too: https://bugs.freedesktop.org/show_bug.cgi?id=91469 Bug:

Re: AWT Dev [9] Review request for 8014212: Robot captures black screen

unknown reason 107 // Color newColor2 = r.getPixelColor(200, 200); On 23.07.15 19:37, Alexander Zvegintsev wrote: Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8014212/00 for the issue https://bugs.openjdk.java.net/browse/JDK-8014212 This fix trying to use

AWT Dev [9] Review request for 8014212: Robot captures black screen

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8014212/00 for the issue https://bugs.openjdk.java.net/browse/JDK-8014212 This fix trying to use gdk_pixbuf_get_from_drawable () [0] to capture screenshot(basic image data handling could be found here[1]). If it fails

AWT Dev [9] Review request for 8131752 [Regression] Test java/awt/GraphicsDevice/CheckDisplayModes.java fails

Hello, Please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8131752/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8131752 This fix simply restores fullscreen windows check. Actually fullscreen is not necessary to change display mode, but since I am planning to

Re: AWT Dev [9] Review request for 8130478 Reconsider awt.toolkit property usage in java.awt.Toolkit getDefaultToolkit() method

+1 Thanks, Alexander. On 07/22/2015 12:14 AM, Sergey Bylokhov wrote: +1 On 21.07.15 21:24, Phil Race wrote: Seems fine to me. Since this is specification visible you will need an approved CCC request before commiting the change. -phil. On 07/21/2015 07:49 AM, Alexander Scherbatiy wrote:

Re: AWT Dev Awt Dev [9] Review Request for 8130769: The new menu can't be shown on the menubar after clicking the Add button.

+1 Thanks, Alexander. On 07/22/2015 10:51 AM, Alexander Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 7/22/2015 12:32 AM, Sergey Bylokhov wrote: Hi, Semyon. The fix looks good. On 16.07.15 19:08, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug:

Re: AWT Dev [9] Review Request: 8067093 Fix windows-specific deprecation warnings in the java.desktop module

+1 Thanks, Alexander. On 07/22/2015 11:49 AM, Alexander Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 7/22/2015 1:01 AM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. In the fix I replace the usage of the deprecated api in WListPeer. Most of the

Re: AWT Dev [9] Review Request for 8131673: [TEST_BUG] add @modules to some OS X-specific regtests

+1 Thanks, Alexander. On 07/16/2015 06:07 PM, Sergey Bylokhov wrote: The fix looks fine. On 16.07.15 17:16, Yuri Nesterenko wrote: I cannot, however, easily fix them for OS X 10.10 where full screen button is in different place. Let's make another bug for that. Current CR is

Re: AWT Dev Awt Dev [9] Review Request for 8025815: Child FileDialog of modal dialog does not get focus on Gnome

, Alexander Zvegintsev wrote: Hello Semyon, the fix itself look good to me, but the test seems to be broken, it passes for me before the fix and fails after( Ubuntu 14.04, Unity) Thanks, Alexander. On 07/13/2015 04:59 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https

Re: AWT Dev Awt Dev [9] Review Request for 8130242: DataFlavorComparator transitivity exception

looks good to me too. Thanks, Alexander. On 07/08/2015 11:50 AM, Alexander Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 7/6/2015 5:33 PM, Semyon Sadetsky wrote: Transitivity (2) violated: X:

Re: AWT Dev Awt Dev [9] Review Request for 8025815: Child FileDialog of modal dialog does not get focus on Gnome

Hello Semyon, the fix itself look good to me, but the test seems to be broken, it passes for me before the fix and fails after( Ubuntu 14.04, Unity) Thanks, Alexander. On 07/13/2015 04:59 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug:

Re: AWT Dev [9] Review Request: 8129894 NSApplicationAWT.m:343:72: error: comparison of constant 777 with expression of type 'NSEventSubtype'

Hello Sergey, the fix looks good to me. Thanks, Alexander. On 07/09/2015 01:49 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. This is the last issue, which prevents us to build the jdk on osx using the latest clang w/o --disable-warnings-as-errors. This code was

Re: AWT Dev Awt Dev [9] Review Request for 8130390: Applet fails to launch on virtual desktop

looks fine to me. Thanks, Alexander. On 07/07/2015 01:38 PM, Semyon Sadetsky wrote: Hello, Please review fix for JDK9: bug: https://bugs.openjdk.java.net/browse/JDK-8130390 webrev: http://cr.openjdk.java.net/~ssadetsky/8130390/webrev.00/ The FlipBufferStrategy did not take an Applet

Re: AWT Dev [9] Review Request: 8130525 Build failure on jdk9-client solaris-sparcv9

Looks fine to me. Thanks, Alexander. On 07/06/2015 04:20 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9. In the fix for JDK-7188942 I forgot to cleanup the mapfiles when I removed initPbuffer() method. Bug: https://bugs.openjdk.java.net/browse/JDK-8130525 Webrev can be

Re: AWT Dev [9] Review Request: JDK-8080953 [TEST_BUG]Test java/awt/FontClass/DebugFonts.java fails due to wrongly typed bugid

Looks fine to me. Thanks, Alexander. On 07/02/2015 10:29 AM, pooja chopra wrote: Hi All, Please review below fix. Regards, Pooja On 6/17/2015 12:06 PM, pooja chopra wrote: Hi All , Gentle Reminder. Please review below fix . Regards, Pooja On 5/22/2015 10:34 PM, Sergey Bylokhov wrote: cc 2d

Re: AWT Dev RFR: JDK-8080246 JNLP app cannot be launched due to deadlock

Hi Daniil, the fix looks good to me too. -- Thanks, Alexander. On 24.06.2015 22:42, Daniil Titov wrote: Hello, Could you, please, review the following fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8080246 Webrev : http://cr.openjdk.java.net/~dtitov/8080246.8/

AWT Dev [9] Review request for 8129116: Deadlock with multimonitor fullscreen windows.

Hello please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8129116/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8129116 This deadlock occurs when we setting a fullscreen window on each graphics device sequentially without a delay.

AWT Dev [9] Review request for 8081371: [PIT] Test closed/java/awt/FullScreen/DisplayMode/CycleDMImage.java switches Linux to the single device mode

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8081371/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8081371 As known we are currently return a wrong list of display modes in multi screen environment[0]. Apparently the recent fullscreen mode fix[1] enables

Re: AWT Dev [9] Review Request: 7178683 [macosx] The default directory for open dialog is different for FileDialogOpenDirTest.html

Hello Sergey, the fix looks good to me. -- Thanks, Alexander. On 09.06.2015 22:34, Sergey Bylokhov wrote: Hello. Please review the small fix for jdk9. The test was created for the JDK-4974135 and checks specific to xawt/mawt behavior. It is not applicable to the osx as well as windows. The

Re: AWT Dev [OpenJDK 2D-Dev] RFR: 8081315: 8077982 giflib upgrade breaks system giflib builds with earlier versions

Sure, looks good to me. Thanks, Alexander. On 06/05/2015 06:34 PM, Andrew Hughes wrote: - Original Message - Hi Andrew, We have removed a workaround[0] for interlaced images support, there is no need in it after 5.0.0 [1]: DGifSlurp() and EGifSpew() now read and write interlaced

Re: AWT Dev [OpenJDK 2D-Dev] RFR: 8081315: 8077982 giflib upgrade breaks system giflib builds with earlier versions

Hi Andrew, We have removed a workaround[0] for interlaced images support, there is no need in it after 5.0.0 [1]: DGifSlurp() and EGifSpew() now read and write interlaced images properly. I didn't test it, but it seems to me that interlaced images will look bad after building against GIFLIB

<    1   2   3   4   >