On 27/11/2017 14:02, Semyon Sadetsky wrote:
> The current changes get my "+1" as comformant HTML5.
This is not true. The empty tags produce warnings in HTML5 validator:
https://validator.w3.org/nu/?doc=http%3A%2F%2Fcr.openjdk.java.net%2F~ssadetsky%2F8181289%2Fjdoc%2FmodB-summary.html
The
> The current changes get my "+1" as comformant HTML5.
This is not true. The empty tags produce warnings in HTML5 validator:
https://validator.w3.org/nu/?doc=http%3A%2F%2Fcr.openjdk.java.net%2F~ssadetsky%2F8181289%2Fjdoc%2FmodB-summary.html
-phil.
On 11/22/2017 07:58 PM, Jonathan Gibbons
The current changes get my "+1" as comformant HTML5.
-phil.
On 11/22/2017 07:58 PM, Jonathan Gibbons wrote:
Semyon,
You may indeed have explained why the behavior as it is, but we cannot
and should not link this review with changes to the javadoc
stylesheets, when the specific changes in
Jon,
You shouldn't use empty tag for margins. It looks odd. You can add
the same css rule for appropriate element. I don't understand which
visual issues you mean.
--Semyon
On 11/22/2017 07:58 PM, Jonathan Gibbons wrote:
Semyon,
You may indeed have explained why the behavior as it is,
Semyon,
You may indeed have explained why the behavior as it is, but we cannot
and should not link this review with changes to the javadoc stylesheets,
when the specific changes in the review are gratuitous and not necessary
in the first place.
Yes, we may separately, and later, look at how
I can confirm the same behavior that Jon sees with Firefox 57 on Windows 7.
The link scrolls to the right place with the link and does
not with the link.
-- Kevin
Jonathan Gibbons wrote:
Semyon,
Using the files I previously posted, I confirm that I see the same
display problem on a
Semyon,
Using the files I previously posted, I confirm that I see the same
display problem on a Mac, using the latest OS (High Sierra) and Safari.
I also see the problem on the same Mac, with Firefox 55.0.2
-- Jon
On 11/22/2017 02:53 PM, Jonathan Gibbons wrote:
Semyon,
I have
Semyon,
I have reconstructed a very simple, very artificial example to demo the
bug. This example uses lots of filler text, but while that is
artificial, for sake of recreating a demo, note that the problem first
appeared, for real, in real JDK 9 API documentation with extended doc
Hi Jon,
This is not only about HTML5 spec, I also hardly can find resources that
follow your "
You are correct that there is no bug here. But a bug was absent before
this fix as well. This bug is about following to the HTML5 standards, so
let's follow them in full and not to return to this
If there are no other comments about this review, I'll push the first
version(.00) of the fix.
On 23/10/2017 14:42, Sergey Bylokhov wrote:
Hello,
Please review the fix for.
8182410: missing 'title' in
api/javax/swing/plaf/synth/doc-files/componentProperties.html
8183508: multi_tsc.html
Semyon,
I read the HTML 5 spec the same as you, and we (on the Javadoc team)
started using id on other elements, as well as to provide a target
that could be linked to.
However, the pragmatic experience was that the scrolling in some
browsers did not completely reveal the element when
Hi Jonathan,
On 10/24/2017 03:20 PM, Jonathan Gibbons wrote:
Semyon,
Although id is a global attribute and can be used to identify any
node, some browsers do better navigation/scrolling when the id is in
an tag. We have seen poor autoscrolling behavior when the id is
an a header tag,
Semyon,
Although id is a global attribute and can be used to identify any node,
some browsers do better navigation/scrolling when the id is in an
tag. We have seen poor autoscrolling behavior when the id is an a
header tag, such that the header ends up obscured under the navigation
bar at
On 10/24/2017 12:02 PM, Sergey Bylokhov wrote:
Hi, Semyon
I guess I did not add a new tags, it seems that this tag is used
as an anchor everywhere and since it is allowed in html5 its usage was
preserved.
Starting version 9 JDK supports the html5 markup in javadoc, so the
files need to be
Hi, Semyon
I guess I did not add a new tags, it seems that this tag is used as
an anchor everywhere and since it is allowed in html5 its usage was
preserved.
On 23/10/2017 22:08, Semyon Sadetsky wrote:
Hi Sergey,
I see no reason to have an extra empty anchor tag to set a bookmark. The
id
Hi Sergey,
I see no reason to have an extra empty anchor tag to set a bookmark. The
id attribute works with any element.
For example:
Definitions
should be
Definitions
--Semyon
On 10/23/2017 02:42 PM, Sergey Bylokhov wrote:
Hello,
Please review the fix for.
8182410:
Hello,
Please review the fix for.
8182410: missing 'title' in
api/javax/swing/plaf/synth/doc-files/componentProperties.html
8183508: multi_tsc.html should be updated
8181289: Invalid HTML 5 in AWT/Swing docs
Description:
- Illegal characters were removed.
- Unsupported tags/properties were
17 matches
Mail list logo
