Re: [8] Review request for 7124553: [macosx] Need minimum size for titled Frames and JFrames

2012-04-04 Thread Artem Ananiev
On 4/3/2012 4:22 PM, Anthony Petrov wrote: Hi Artem, May I consider the fix reviewed, or do you (and anyone else interested) have any further questions/suggestions? I still think that the code to support 10.6, which will a legacy OS at the moment when JDK8 is released, should not be fw-porte

Re: [8] Review request for 7156194 [macosx] Can't type non-ASCII characters into applets

2012-04-04 Thread Anthony Petrov
Hi Dmitry, The fix looks good to me. One question though: src/macosx/classes/sun/lwawt/macosx/CPlatformResponder.java 188 while (index < length) { 189 c = text.charAt(index); 190 peer.dispatchKeyEvent(KeyEvent.KEY_TYPED, 191

hg: jdk8/awt/jdk: 7093156: NLS Please change the mnemonic assignment system to avoid translation issue (Swing files)

2012-04-04 Thread alexandr . scherbatiy
Changeset: cbf39e7a7535 Author:alexsch Date: 2012-04-04 16:27 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/cbf39e7a7535 7093156: NLS Please change the mnemonic assignment system to avoid translation issue (Swing files) Reviewed-by: rupashka ! src/share/classes/com/sun/ja

Re: [8] Review request for 7124553: [macosx] Need minimum size for titled Frames and JFrames

2012-04-04 Thread Anthony Petrov
Here's a fix that wipes out all traces of the grow box: http://cr.openjdk.java.net/~anthony/8-19-frameMinSize-7124553.1/ -- best regards, Anthony On 4/4/2012 1:50 PM, Artem Ananiev wrote: On 4/3/2012 4:22 PM, Anthony Petrov wrote: Hi Artem, May I consider the fix reviewed, or do you (and an

[8] Review request for 7147435: closed/java/awt/Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh failed since 7u4b11

2012-04-04 Thread Anthony Petrov
Hello, We've fixed this closed test in 7u4 by eliminating a scenario that caused the failure. In JDK 8 we open-source the test. Please review the fix for http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7147435 at: http://cr.openjdk.java.net/~anthony/8-22-headlessTestFailed-7147435.0/ -- b

Re: [8] Review request for 7148275: [macosx] setIconImages() not working correctly (distorted icon when minimized)

2012-04-04 Thread Artem Ananiev
On 4/3/2012 2:00 PM, Anthony Petrov wrote: Thanks Mike. The auto magnification feature indeed justifies the current OS' behavior. And it always makes sense to pass all available images to the system and let it decide which is best in every case. Artem, So the latest webrev seems to be doing th

Re: [8] Review request for 7124553: [macosx] Need minimum size for titled Frames and JFrames

2012-04-04 Thread Mike Swingler
Looks good to me. Cheers, Mike Swingler Apple Inc. On Apr 4, 2012, at 7:00 AM, Anthony Petrov wrote: > Here's a fix that wipes out all traces of the grow box: > > http://cr.openjdk.java.net/~anthony/8-19-frameMinSize-7124553.1/ > > -- > best regards, > Anthony > > On 4/4/2012 1:50 PM, Artem A

hg: jdk8/awt/jdk: 2 new changesets

2012-04-04 Thread alexander . zuev
Changeset: e0bf70361777 Author:kizune Date: 2012-04-04 20:31 +0400 URL: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/e0bf70361777 7153735: [macosx] Text with diacritics is pasted with broken encoding Reviewed-by: anthony ! make/common/Defs-linux.gmk ! make/common/Defs-macosx.gmk ! m

A simple method to check headless property

2012-04-04 Thread Sean Chou
Hi all, I thought the code to check headless property in src/share/classes/java/awt/GraphicsEnvironment.java is a little redundant, it checks every platform one by one. "headless = defaultHeadless = Boolean.valueOf(("Linux".equals(osName) || "SunOS".equals(