[10][

Hi All, Please review the fix for test bug: Bug : JDK-8027154 __ JDK 10 Webrev: http://cr.openjdk.java.net/~pkbalakr/Krishna/8027154/webrev00/

[10][JDK-8027154] [TESTBUG] Test java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails

Hi All, Please review the fix for test bug: Bug : JDK-8027154 __ JDK 10 Webrev: http://cr.openjdk.java.net/~pkbalakr/Krishna/8027154/webrev00/

[10][JDK-8075084] JOptionPane.showMessageDialog causes JScrollBar to move

Hi All, Please review the fix for bug: Bug: JDK- 8075084 https://bugs.openjdk.java.net/browse/JDK-8075084 JDK 10 Webrev : http://cr.openjdk.java.net/~psadhukhan/8075084/webrev00/ Summary: This is an interesting test case written by Drew Jetter (http://webbugs.us.oracle.com/IMWeb/

Re: [10][JDK-8027154] [TESTBUG] Test java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails

: Krishna Addepalli mailto:krishna.addepa...@oracle.com"krishna.addepa...@oracle.com> Cc: Ambarish Rapte mailto:ambarish.ra...@oracle.com"ambarish.ra...@oracle.com>; Ajit Ghaisas mailto:ajit.ghai...@oracle.com"ajit.ghai...@oracle.com>; Prem Balakrishnan mailto:prem

[10][JDK-8175015] FileSystemView.isDrive(File) memory leak on "C:\" file reference

Hi All, Please review the fix for bug: Bug: JDK- 8175015 https://bugs.openjdk.java.net/browse/JDK-8175015 JDK 10 Webrev : http://cr.openjdk.java.net/~pkbalakr/Krishna/8175015/webrev00/ Summary: The bug reports about memory leak by repeatedly querying FileSystemView, if "C:\" is a

Re: [10][JDK-8175015] FileSystemView.isDrive(File) memory leak on "C:\" file reference

is again reducing. You can see that this kind of pattern repeats a few times, but eventually, the memory runs out. Thanks, Krishna -Original Message- From: Sergey Bylokhov Sent: Wednesday, August 9, 2017 5:16 AM To: Krishna Addepalli ; awt-dev@openjdk.java.net Subject: Re: [10][JDK-8

Re: [10][JDK-8175015] FileSystemView.isDrive(File) memory leak on "C:\" file reference

://cr.openjdk.java.net/~pkbalakr/Krishna/8175015/webrev01/ Thanks, Krishna -Original Message- From: Sergey Bylokhov Sent: Wednesday, August 9, 2017 5:16 AM To: Krishna Addepalli ; awt-dev@openjdk.java.net Subject: Re: [10][JDK-8175015] FileSystemView.isDrive(File) memory leak on "C:\&

Re: [10][JDK-8175015] FileSystemView.isDrive(File) memory leak on "C:\" file reference

Hi Sergey, I checked with Thread.MAX_PRIORITY - 1, and found that it still leads to OOM exception, although it takes longer to get to that condition. Thanks, Krishna -Original Message- From: Sergey Bylokhov Sent: Tuesday, August 29, 2017 6:19 AM To: Krishna Addepalli Cc: awt-dev

Re: [10][JDK-8175015] FileSystemView.isDrive(File) memory leak on "C:\" file reference

Hi Prasanta,   Even in the previous case, it falls through and returns false. The same behavior is maintained with the current code as well.   Thanks, Krishna   From: Prasanta Sadhukhan Sent: Wednesday, August 30, 2017 2:00 PM To: Krishna Addepalli Cc: awt-dev@openjdk.java.net Subject

[11][JDK-8171000]Robot.createScreenCapture() crashes in wayland mode

Hi All, Please review a fix for JDK-8171000: https://bugs.openjdk.java.net/browse/JDK-8171000 Webrev: http://cr.openjdk.java.net/~kaddepalli/8171000/webrev00/ The crash happens since XGetImage can return NULL in case of Wayland, which doesnot permit reading screen pixels outside the own

Re: [11][JDK-8171000]Robot.createScreenCapture() crashes in wayland mode

int of use. Thanks, Krishna -Original Message- From: Sergey Bylokhov Sent: Saturday, February 3, 2018 1:27 PM To: Krishna Addepalli ; awt-dev@openjdk.java.net Subject: Re: [11][JDK-8171000]Robot.createScreenCapture() crashes in wayland mode Hi, Krishna. The change of local types declarat

[11][JDK-8152974] AWT hang occurs when sequenced events arrive out of sequence

Hi All, Please review a fix for JDK-8152974: https://bugs.openjdk.java.net/browse/JDK-8152974 Webrev: http://cr.openjdk.java.net/~kaddepalli/8152974/webrev00/ The problem is when the events arrive out of sequence, the sequenced event's dispatch loop assumes that the sequenced events ar

Re: [11][JDK-8152974] AWT hang occurs when sequenced events

it post two SequencedEvents out of order, the first waits when the second will be dispatched, why it hangs forever? On 15/02/2018 04:16, Krishna Addepalli wrote: > Hi All, > > Please review a fix for ?JDK-8152974: > https://bugs.openjdk.java.net/browse/JDK-8152974 > > Webr

Re: [11][JDK-8152974] AWT hang occurs when sequenced events

ergey Bylokhov Sent: Saturday, February 17, 2018 1:49 AM To: Krishna Addepalli ; awt-dev@openjdk.java.net; Semyon Sadetsky Subject: Re: [11][JDK-8152974] AWT hang occurs when sequenced events Hi, Krishna. On 16/02/2018 00:42, Krishna Addepalli wrote: > The SentEvent.ID value is "java.awt.e

[11][JDK-8197808] Test java/awt/Dialog/MakeWindowAlwaysOnTop/MakeWindowAlwaysOnTop.java fails on Windows

Hi All, Please review a fix for JDK-8197808: https://bugs.openjdk.java.net/browse/JDK-8197808 Webrev: http://cr.openjdk.java.net/~kaddepalli/8197808/webrev00/ The problem was that by the time Robot tries to read the color on screen, the compositing of the window is not completed, and hen

Re: [11] JDK-8196017: java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails

Hi Shashi, This test passes for me without any problems on my machine. I'm using Windows 10 build 1703 - i.e it is not Fall Creators build. Also, the intent of the test is to check that, if a frame is drawn on top of another frame, then the mouse move should be seen by the top frame and not th

Re: [11][JDK-8197808] Test java/awt/Dialog/MakeWindowAlwaysOnTop/MakeWindowAlwaysOnTop.java fails on Windows

/without my changes. As noted earlier, on Windows 10, the test passes after the fix. Thanks, Krishna -Original Message- From: Philip Race Sent: Tuesday, February 27, 2018 6:01 AM To: Sergey Bylokhov Cc: Krishna Addepalli ; awt-dev@openjdk.java.net Subject: Re: [11][JDK-8197808] Test java/awt

Re: [11] Review request for JDK-8190767: [macos] if JFrame is maximized on OS X, all new JFrames will be maximized by default

Looks fine for me as well. Thanks, Krishna Date: Tue, 6 Mar 2018 15:25:04 -0800 From: Sergey Bylokhov To: Manajit Halder Cc: awt-dev@openjdk.java.net Subject: Re: [11] Review request for JDK-8190767: [macos] if JFrame is maximized on OS X, all new JFrames will be maximized by d

Re: [11] Review Request: 8199022 New

Hi Sergey, Bug id is JDK-8197798 for java/awt/JAWT/JAWT.sh Thanks, Krishna Message: 1 Date: Wed, 7 Mar 2018 05:55:58 -0800 From: Sergey Bylokhov To: Prasanta Sadhukhan , "swing-...@openjdk.java.net" , "awt-dev@openjdk.java.net" Subject: Re: [11] Review Request: 8199022 New

Re: [11][JDK-8152974] AWT hang occurs when sequenced events

/ However, could you point me to a doc/spec which says that all the SequencedEvents have to be processed together, even if other events in the queue have arrived before? Thanks, Krishna -Original Message- From: Krishna Addepalli Sent: Saturday, February 17, 2018 7:57 AM To: Sergey

Re: [11][JDK-8152974] AWT hang occurs when sequenced events

- From: Semyon Sadetsky Sent: Thursday, March 15, 2018 9:14 PM To: Krishna Addepalli ; awt-dev@openjdk.java.net Subject: Re: [11][JDK-8152974] AWT hang occurs when sequenced events Hi Krishna, You have replaced FOCUS_LAST+2 with the FOCUS_LAST+1 which is absolutely different event. They

Re: [11][JDK-8152974] AWT hang occurs when sequenced events

reference: "edt.pumpEvents(ID, () -> !SequencedEvent.this.isFirstOrDisposed());" Thanks, Krishna -Original Message- From: Semyon Sadetsky Sent: Thursday, March 15, 2018 10:36 PM To: Krishna Addepalli ; awt-dev@openjdk.java.net Subject: Re: [11][JDK-8152974] AWT han

Re: [11][JDK-8152974] AWT hang occurs when sequenced events

: Krishna Addepalli ; awt-dev@openjdk.java.net Subject: Re: [11][JDK-8152974] AWT hang occurs when sequenced events On 03/15/2018 10:11 AM, Krishna Addepalli wrote: > If no such event is posted to the queue, it will lead to hang right? Are you sure that the root cause is that there are no s

Re: [11][JDK-8152974] AWT hang occurs when sequenced events

the newly created context. And I have also added two dummy events between two sequenced events just to make sure that, that case also works. Thanks, Krishna -Original Message- From: Semyon Sadetsky Sent: Friday, March 16, 2018 12:01 AM To: Krishna Addepalli ; awt-dev@openjdk.java.net Su

Re: [11][JDK-8152974] AWT hang occurs when sequenced events

ifies your concerns. Thanks, Krishna -Original Message- From: Semyon Sadetsky Sent: Friday, March 16, 2018 1:59 AM To: Krishna Addepalli ; awt-dev@openjdk.java.net Subject: Re: [11][JDK-8152974] AWT hang occurs when sequenced events I was wrong I see the application context in the test bu

Re: RFR: 8198649 : Switch AWT/Swing's default GTK version to 3

Hi Phil, The change looks fine for me. Thanks, Krishna -Original Message- From: Phil Race Sent: Friday, March 16, 2018 11:05 PM To: awt-dev@openjdk.java.net; swing-...@openjdk.java.net Subject: RFR: 8198649 : Switch AWT/Swing's default GTK version to 3 Bug: https://bugs.openjdk.java.

Re: [11][JDK-8152974] AWT hang occurs when sequenced events

ontext, whereas the other two are >> posted on the newly created context. And I have also added two dummy >> events between two sequenced events just to make sure that, that case >> also works. >> >> Thanks, >> Krishna >> >> -Original Messag

Re: RFR: 8200313 : java/awt/Gtk/GtkVersionTest/GtkVersionTest.java fails

Hi Phil, The changes look fine. However, since you are already making changes to the test, could you also clean up the imports? Thanks, Krishna -Original Message- From: Phil Race Sent: Tuesday, March 27, 2018 11:05 PM To: awt-dev@openjdk.java.net Subject: RFR: 8200313 : java/awt/Gtk/

Re: RFR: 8200313 : java/awt/Gtk/GtkVersionTest/GtkVersionTest.java fails

+1 -Original Message- From: Sergey Bylokhov Sent: Thursday, March 29, 2018 6:23 AM To: Phil Race ; Krishna Addepalli ; awt-dev@openjdk.java.net Subject: Re: RFR: 8200313 : java/awt/Gtk/GtkVersionTest/GtkVersionTest.java fails +1 On 28/03/2018 15:03, Phil Race wrote: > Updated web

[11]JDK-8200525: test java/awt/event/SequencedEvent/SequencedEventTest.java fails to compile

Hi All, Please review a trivial compilation fix for the bug: https://bugs.openjdk.java.net/browse/JDK-8200525 Webrev: http://cr.openjdk.java.net/~kaddepalli/8200525/webrev00/ The problem was, the test case uses some of the internal classes, which were not specified for the jtreg data sec

Re: [11] Review Request: 8187392 Deprecated methods in the peers can be removed

Hi Sergey, The changes look fine to me. Thanks, Krishna -Original Message- From: Sergey Bylokhov Sent: Wednesday, April 4, 2018 12:14 PM To: awt-dev@openjdk.java.net Subject: [11] Review Request: 8187392 Deprecated methods in the peers can be removed Hello. Please review fix for jdk1

Re: [8u-backport] Review request for 8152974 : AWT hang occurrs when sequenced events arrive out of sequence

Looks fine to me. Thanks, Krishna From: Dipak Kumar Sent: Thursday, April 5, 2018 1:57 PM To: Sergey Bylokhov ; Semyon Sadetsky ; Philip Race ; Krishna Addepalli ; awt-dev@openjdk.java.net Subject: [8u-backport] Review request for 8152974 : AWT hang occurrs when sequenced events

[11][JDK-8197810]RFR: Test java/awt/Choice/SelectCurrentItemTest/SelectCurrentItemTest.html fails on Windows

Hi All Please review a fix for JDK-8197810: https://bugs.openjdk.java.net/browse/JDK-8197810 , Webrev: http://cr.openjdk.java.net/~kaddepalli/8197810/webrev00/ The basic problem is that, the Robot mouse move is moving to position where item 0 is located (which is already selected), and sel

Re: [11][JDK-8197810]RFR: Test java/awt/Choice/SelectCurrentItemTest/SelectCurrentItemTest.html fails on Windows

Gentle reminder to review this. Thanks, Krishna From: Krishna Addepalli Sent: Tuesday, May 8, 2018 3:29 PM To: awt-dev@openjdk.java.net Subject: [11][JDK-8197810]RFR: Test java/awt/Choice/SelectCurrentItemTest/SelectCurrentItemTest.html fails on Windows Hi All Please review a fix

Re: [11] Review Request: 8204118 [macos] Nonsensical self == [super init] in CFileDialog.m

Looks fine. -Original Message- From: Sergey Bylokhov Sent: Saturday, June 2, 2018 4:41 AM To: awt-dev@openjdk.java.net Subject: [11] Review Request: 8204118 [macos] Nonsensical self == [super init] in CFileDialog.m Hello. Please review the fix for jdk11. Bug: https://bugs.openjdk.java

Re: [11] Review Request: 8203224 java.awt.desktop.*Event classes could not be instantiated if Desktop feature is not supported

Looks fine. > On 05-Jun-2018, at 2:49 AM, Phil Race wrote: > > +1. > > -phil. > > On 05/24/2018 09:48 PM, Sergey Bylokhov wrote: >> Hello. >> Please review the fix for jdk11. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8203224 >> Webrev: http://cr.openjdk.java.net/~serb/8203224/webre

Re: [11] Review Request: 8189604 possible hang in sun.awt.shell.Win32ShellFolder2$KnownFolderDefinition::

Hi Sergey, The fix looks fine. However, I have couple of comments: 1. The variable "result" in Java_sun_awt_shell_Win32ShellFolder2_loadKnownFolders at line 1401 is not initialized. Although it is initialized in the following if condition, I'm not sure when it return false, and lead to a return

Re: [11] Review Request: 8189604 possible hang in sun.awt.shell.Win32ShellFolder2$KnownFolderDefinition::

Hi Sergey, The changes look fine. Thanks, Krishna -Original Message- From: Sergey Bylokhov Sent: Tuesday, June 26, 2018 11:12 AM To: Krishna Addepalli ; awt-dev@openjdk.java.net Subject: Re: [11] Review Request: 8189604 possible hang in sun.awt.shell.Win32ShellFolder2

Re: [11][JDK-8197810]RFR: Test java/awt/Choice/SelectCurrentItemTest/SelectCurrentItemTest.html fails on Windows

, selectedIndex); } This is the reason why the test is failing. Hope this clarifies. Thanks, Krishna -Original Message- From: Sergey Bylokhov Sent: Tuesday, May 29, 2018 8:48 PM To: Krishna Addepalli ; awt-dev@openjdk.java.net Subject: Re: [11][JDK-8197810]RFR: Test j

Re: [11][JDK-8197810]RFR: Test java/awt/Choice/SelectCurrentItemTest/SelectCurrentItemTest.html fails on Windows

ishna -Original Message- From: Sergey Bylokhov Sent: Wednesday, June 27, 2018 6:05 AM To: Krishna Addepalli ; awt-dev@openjdk.java.net Subject: Re: [11][JDK-8197810]RFR: Test java/awt/Choice/SelectCurrentItemTest/SelectCurrentItemTest.html fails on Windows If this was done intentionally t

Re: [11][JDK-8197810]RFR: Test java/awt/Choice/SelectCurrentItemTest/SelectCurrentItemTest.html fails on Windows

, 2018 9:27 AM To: Krishna Addepalli ; awt-dev@openjdk.java.net Subject: Re: [11][JDK-8197810]RFR: Test java/awt/Choice/SelectCurrentItemTest/SelectCurrentItemTest.html fails on Windows On 26/06/2018 19:40, Krishna Addepalli wrote: > Hi Sergey, > > The test with my changes will run on

Re: [11][JDK-8197810]RFR: Test java/awt/Choice/SelectCurrentItemTest/SelectCurrentItemTest.html fails on Windows

ginal Message- From: Sergey Bylokhov Sent: Wednesday, June 27, 2018 12:16 PM To: Krishna Addepalli ; awt-dev@openjdk.java.net Subject: Re: [11][JDK-8197810]RFR: Test java/awt/Choice/SelectCurrentItemTest/SelectCurrentItemTest.html fails on Windows > Thanks for the clarification. So, this means

[12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

Hi All, Please review a fix for JDK-8014503: https://bugs.openjdk.java.net/browse/JDK-8014503 Webrev: http://cr.openjdk.java.net/~kaddepalli/8014503/webrev00/ On Windows, the default behavior has been changed to not send an ItemEvent, if the same item is selected again, whereas this was

Re: [11] Review Request: 8205588 Deprecate for removal com.sun.awt.SecurityWarning

+1 -Original Message- From: Philip Race Sent: Tuesday, July 3, 2018 12:17 AM To: Sergey Bylokhov Cc: awt-dev@openjdk.java.net Subject: Re: [11] Review Request: 8205588 Deprecate for removal com.sun.awt.SecurityWarning +1 -phil. On 6/24/18, 11:27 PM, Sergey Bylokhov wrote: > Hello. >

Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

To: Krishna Addepalli ; awt-dev@openjdk.java.net Subject: RE: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms. Hi Krishna, Below are the comments on the fix that you made. 1. Based on the getSelectedIndex(), I think the selectedIndex should

Re: [OpenJDK 2D-Dev] [11] Review Request: 8201611 Broken links in java.desktop javadoc

Looks fine -Original Message- From: Phil Race Sent: Monday, July 2, 2018 10:46 PM To: Sergey Bylokhov ; awt-dev@openjdk.java.net; 2d-dev <2d-...@openjdk.java.net> Subject: Re: [OpenJDK 2D-Dev] [11] Review Request: 8201611 Broken links in java.desktop javadoc OK, +1 -phil. On 07/02/

Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

t: Tuesday, July 3, 2018 1:15 PM To: Shashidhara Veerabhadraiah ; Krishna Addepalli ; awt-dev@openjdk.java.net Subject: RE: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms. Can we use existing 'skipPostMessage' member for this check instead of

Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

Hi Prasanta/Sergey, Could you review this ? @Ajit, Shashi - Thanks for your review. Thanks, Krishna From: Ajit Ghaisas Sent: Tuesday, July 3, 2018 3:31 PM To: Krishna Addepalli ; Shashidhara Veerabhadraiah ; awt-dev@openjdk.java.net Subject: RE: [12]RFR : JDK-8014503: AWT

Re: RFR: 8208353: Upgrade JDK 11 to libpng 1.6.35

Hi Phil, The changes look fine to me. Great to see the steps that need to be followed for updating png library into UPDATING.txt. I see a small typo on line 19: "handiling". Don’t need a new webrev for this. Thanks, Krishna -Original Message- From: Philip Race Sent: Friday, July 27,

Re: RFR: 8208353: Upgrade JDK 11 to libpng 1.6.35

One more thing, in the UPDATING.txt: In the first line: "TING libpng in OpenJDK". I guess it should have been "UPDATING" ... -Original Message- From: Krishna Addepalli Sent: Friday, July 27, 2018 5:46 PM To: Philip Race ; awt-dev@openjdk.java.net Subject: Re: RFR:

Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

}); } } Thanks, Krishna -Original Message- From: Sergey Bylokhov Sent: Thursday, July 5, 2018 8:10 PM To: Krishna Addepalli ; Ajit Ghaisas ; Shashidhara Veerabhadraiah ; awt-dev@openjdk.java.net Subject: Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made

Re: [12] Review Request: 8209340 The code which avoids synthetic accessors has become outdated

Hi Sergey, I understand that with the new jep, we no longer need to explicitly write the constructor to avoid the synthetic accessor methods generated by the compiler. AFAIK, each inner class declared results in a class file being generated rather than each default constructor. Could you clari

Re: [12] Review Request: 8209340 The code which avoids synthetic accessors has become outdated

- From: Sergey Bylokhov Sent: Tuesday, August 14, 2018 8:36 AM To: Krishna Addepalli ; awt-dev@openjdk.java.net; swing-...@openjdk.java.net Subject: Re: [12] Review Request: 8209340 The code which avoids synthetic accessors has become outdated On 13/08/2018 19:32, Krishna Addepalli

Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

t;, but my question is, should I make this change or keep the index based change, since that would keep the implementation also consistent across platforms. Thanks, Krishna -Original Message- From: Sergey Bylokhov Sent: Tuesday, August 14, 2018 7:52 AM To: Krishna Addepalli ; Aj

Re: StackOverflowError happened by TextField.setFont(...)

Hi Ichiroh, I have tried the steps you outlined, but I'm not able to reproduce the issue you are seeing. Could you try with the latest jdk12 repo? Thanks, Krishna -Original Message- From: Ichiroh Takiguchi Sent: Friday, August 24, 2018 1:42 PM To: awt-dev@openjdk.java.net Subject: St

Re: OpenJdk11-28-EA JDialog hanging

Hi Laurent, Thanks for bringing this up. I have fixed a problem in this area JDK-8152974, which is about AWT hang when SequencedEvents arrive out of order. However, the fix was partial, and same problem was reported in JDK8(because of webstart), after it was backported. At that point, the fix wa

Re: StackOverflowError happened by TextField.setFont(...)

d run FontChangeTest > 2. Press "Shuffle" button to top > 3. Change Font size (TextField) "12" to "24" on right-buttom, then > press Enter/Return key >Then above exception will be happened > > Thanks, > > On 2018-08-27 12:55, Krishna Add

Re: OpenJdk11-28-EA JDialog hanging

e = new WindowEvent(this, id); > try { > @SuppressWarnings("unchecked") > Class seqClass = (Class) > Class.forName("java.awt.SequencedEvent"); > Constructor seqConst = > seqClass.getConstructor(AWTEvent.class); >

RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

Hi All, Enhancement: https://bugs.openjdk.java.net/browse/JDK-8196681 Webrev: http://cr.openjdk.java.net/~kaddepalli/8196681/webrev00/ Please review an enhancement for supporting the logging of Java Access Bridge, so that customers/users facing problems with Accessibility can turn on/off

Re: [12] Review request for JDK-8206392: [macosx] Cycling through windows (JFrames) does not work with keyboard shortcut

Looks fine to me!   Thanks, Krishna   From: Dmitry Markov Sent: Monday, September 10, 2018 6:06 PM To: Manajit Halder Cc: awt-dev@openjdk.java.net Subject: Re: [12] Review request for JDK-8206392: [macosx] Cycling through windows (JFrames) does not work with keyboard shortcut   Hi Manaji

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

14, 2018 11:38 AM To: Krishna Addepalli ; awt-dev@openjdk.java.net Subject: Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled One thing, since you are passing va_list as the last parameter, shouldn't all fprintf be actually vfprintf? Regards Pra

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

Thanks for the comments. Here is the new webrev: http://cr.openjdk.java.net/~kaddepalli/8196681/webrev02/ --Krishna From: Prasanta Sadhukhan Sent: Friday, September 14, 2018 3:23 PM To: Krishna Addepalli ; awt-dev@openjdk.java.net Subject: Re: RFR: [12] JDK-8196681: Java Access Bridge

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

Nullptr is the recommended way in modern c++. I thought of changing the other places as well, but wanted to keep the changes minimal, so left them as is. Thanks, Krishna From: Prasanta Sadhukhan Sent: Friday, September 14, 2018 5:48 PM To: Krishna Addepalli ; awt-dev@openjdk.java.net

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

anta > On 14-Sep-18 8:33 PM, Krishna Addepalli wrote: >> Nullptr is the recommended way in modern c++. I thought of changing the >> other places as well, but wanted to keep the changes minimal, so left them >> as is. >> >> Thanks, >> Krishna >> >

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

it possibly that the > log file will be garbled because of two libraries will print in parallel? > > On 13/09/2018 12:25, Krishna Addepalli wrote: >> Hi All, >> Enhancement: https://bugs.openjdk.java.net/browse/JDK-8196681 >> Webrev: http://cr.openjdk.java.net/~kaddepalli/8

Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

tested it. Here is the new webrev: http://cr.openjdk.java.net/~kaddepalli/8014503/webrev03/ <http://cr.openjdk.java.net/~kaddepalli/8014503/webrev03/> Thanks, Krishna > On 23-Aug-2018, at 4:34 PM, Sergey Bylokhov > wrote: > > Hi, Krishna. > On 20/08/2018 04:30, Krishna Ad

[12]RFR: [JDK-8074824]: Resolve disabled warnings for libawt_xawt

Hi All, Please review a fix for JDK-8074824: https://bugs.openjdk.java.net/browse/JDK-8074824 Webrev: http://cr.openjdk.java.net/~kaddepalli/8074824/webrev01/ Most of the warnings have been fixed for Linux, Mac and Windows. Thanks, Krishna

Re: [12]RFR: [JDK-8074824]: Resolve disabled warnings for libawt_xawt

question about awt_Window.cpp: > > 2150 w = static_cast((rect.right - rect.left) * scaleX / prevScaleX); > 2151 h = static_cast((rect.bottom - rect.top) * scaleY / prevScaleY); > > Are you sure that we need to use "cast" instead of ScaleUp/Down? > > On 29/09/

Re: [12]RFR: [JDK-8074824]: Resolve disabled warnings for libawt_xawt

/unix/native/common/awt/awt_Font.c.udiff.html >>> >>> <http://cr.openjdk.java.net/%7Ekaddepalli/8074824/webrev01/src/java.desktop/unix/native/common/awt/awt_Font.c.udiff.html> >>> >>> why would that not be #ifdef instead ? >>> >>>

Re: OpenJdk11-28-EA JDialog hanging

problem. Then I’ll create a backout bug and push this patch.   Thanks, Krishna   From: Laurent Bourgès Sent: Thursday, September 27, 2018 12:57 PM To: Krishna Addepalli Cc: Phil Race ; Sergey Bylokhov ; awt-dev@openjdk.java.net Subject: Re: OpenJdk11-28-EA JDialog hanging   Any

Re: [12] Review request for JDK-8209123: [Macosx] Maximized frame is resizable on Mac but not on Windows and Ubuntu

line 825, you could initialize windowResizable like this: “resizable && !isMaximizedBoth()”.   Thanks, Krishna     From: Manajit Halder Sent: Tuesday, September 25, 2018 3:23 PM To: Krishna Addepalli mailto:krishna.addepa...@oracle.com"krishna.addepa...@oracle.com> Subject:

Re: [12]RFR : JDK-8014503: AWT Choice implementation should be made consistent across platforms.

Hi Sergey, I had to update the test, since on Mac, it is always selecting the second element, and the test fails. Thanks, Krishna -Original Message- From: Sergey Bylokhov Sent: Monday, October 1, 2018 7:57 AM To: Krishna Addepalli Cc: Ajit Ghaisas ; Shashidhara Veerabhadraiah ; awt

Re: [12] Review request for JDK-8209123: [Macosx] Maximized frame is resizable on Mac but not on Windows and Ubuntu

Looks fine.   Krishna   From: Manajit Halder Sent: Thursday, October 4, 2018 6:01 PM To: Krishna Addepalli ; awt-dev@openjdk.java.net Subject: Re: [12] Review request for JDK-8209123: [Macosx] Maximized frame is resizable on Mac but not on Windows and Ubuntu   Hi Krishna, Thanks for your

Re: [12] Review Request: 8210231 Robot.delay() catches InterruptedException and prints stacktrace to stderr.

+1 Thanks, Krishna -Original Message- From: Sergey Bylokhov Sent: Monday, October 8, 2018 10:26 AM To: awt-dev@openjdk.java.net Subject: [12] Review Request: 8210231 Robot.delay() catches InterruptedException and prints stacktrace to stderr. Hello. Please review the fix for jdk12. Bu

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

ergey Bylokhov Sent: Tuesday, September 18, 2018 3:26 AM To: Prasanta Sadhukhan ; Krishna Addepalli ; awt-dev@openjdk.java.net Subject: Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled I guess that it is a good thing to use nullptr, but I think it is better

Re: OpenJdk11-28-EA JDialog hanging

Hi Martin,   Excellent assessment of the problem and great explanation of it. Appreciate your efforts in debugging and proposing a solution to this problem.   I have couple questions: 1.   This problem (including the one described in JDK-8152974) is not reproducible at all in Mac. I woul

Re: OpenJdk11-28-EA JDialog hanging

Hi Martin, As far as my experience goes(which is less), the usage of SequencedEvents is relatively rare, and rarer even to generate a high volume of SequencedEvents. So, I would be inclined to pursue the path of blocking the dispatch till the SequencedEvents are processed. Probably Sergey/Phil a

Re: [12] JDK-7124285: Nothing heard from VoiceOver regarding the status of the progress bar

Hi Shashi, The fix looks good to me. Regarding the decision of placing the line “setFocusable(true)” in the constructor of ProgressBar, I think that is a good decision since the Swing users needn’t explicitly make that call to make it accessible. There is one problem though: The focus is not

[12]RFR: JDK-8197811: Test java/awt/Choice/PopupPosTest/PopupPosTest.html fails on Windows

Hi All, Please review a fix for JDK-8197811: https://bugs.openjdk.java.net/browse/JDK-8197811 Webrev: http://cr.openjdk.java.net/~kaddepalli/8197811/webrev00/ The problem is that, the mouse click happens in the item display area (and not on the arrow button in the right side of the choi

Re: [12]RFR: JDK-8197811: Test java/awt/Choice/PopupPosTest/PopupPosTest.html fails on Windows

test did not work all this time? On 24/10/2018 21:04, Krishna Addepalli wrote: Hi All, Please review a fix for JDK-8197811: https://bugs.openjdk.java.net/browse/JDK-8197811 Webrev: http://cr.openjdk.java.net/~kaddepalli/8197811/webrev00/ The problem is that, the mouse click happens in the

Re: [12] Review Request: 8211435 Exception in thread "AWT-EventQueue-1" java.lang.IllegalArgumentException: null source

Looks good to me. > On 25-Oct-2018, at 5:41 PM, Laurent Bourgès wrote: > > Hi Sergey, > > (I am not a Reviewer). > > Thanks for both the bug report and the fix, it looks good for me. > > Laurent > > Le mer. 24 oct. 2018 à 23:32, Sergey Bylokhov > a écrit :

Re: OpenJdk11-28-EA JDialog hanging

Hi Sergey, I also agree with Laurent about root cause of hang provided by Martin. However, we just need to make sure that non Sequenced Events are not dispatched when SequencedEvents are being dealt with. Thanks, Krishna > On 25-Oct-2018, at 1:35 PM, Laurent Bourgès wrote: > > Hi Sergey & Mar

Re: [12] Review request for JDK-8208543: [macos] Support for apple.awt.documentModalSheet incomplete

+1 Krishna -Original Message- From: Dmitry Markov Sent: Friday, October 26, 2018 4:57 PM To: Manajit Halder Cc: awt-dev@openjdk.java.net Subject: Re: [12] Review request for JDK-8208543: [macos] Support for apple.awt.documentModalSheet incomplete Hi Manajit, Looks good to me. Thank

Re: [12] Review Request: 8211822 and 8202886

Hi Sergey, Could you update the test use @requires tag, instead of relying on Platform for NSTexturedJFrame.java? This would probably make the test skip faster on non-Mac platforms. Thanks, Krishna -Original Message- From: Jayathirth Rao Sent: Wednesday, October 31, 2018 12:25 PM To:

Re: [12] Review Request: 8211822 and 8202886

Also consider adding it for bug7154841, bug8007006.java. -Original Message- From: Krishna Addepalli Sent: Wednesday, October 31, 2018 1:35 PM To: Jayathirth D V ; Sergey Bylokhov Cc: awt-dev@openjdk.java.net; Igor Ignatyev Subject: Re: [12] Review Request: 8211822 and 8202886 Hi

Re: [12] JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails

Hi Shashi, 1. Please add "@key headful" to the test. 2. I don’t think you need to replace the waitForIdle call with delay. You may choose to add delay in addition to waitForIdle. 3. Minor nit: replace () -> createAndShowGUI() with method reference. Thanks, Krishna -Original Message- Fro

Re: [12] Review Request: 8211822 and 8202886

erb/8211822/webrev.02 > > On 31/10/2018 01:08, Krishna Addepalli wrote: >> Also consider adding it for bug7154841, bug8007006.java. >> -Original Message- >> From: Krishna Addepalli >> Sent: Wednesday, October 31, 2018 1:35 PM >> To: Jayathirth D V ; Sergey Byl

Re: [12] RFR : JDK-8198002 : java/awt/Mixing/Validating.java debug assert on Windows

Hi Ambarish, Looks fine to me as well. Could you also remove the wildcard imports in the test? I don't need to see a new webrev - just do the changes and push it. Thanks, Krishna -Original Message- From: Sergey Bylokhov Sent: Thursday, November 8, 2018 10:41 PM To: Ambarish Rapte ; awt

[12]RFR: JDK-8213048: Invalid use of HTML5 in java.awt files

Hi All, Please review a simple fix for updating html attributes to use CSS style options to comply with HTML5. JDK-8213048: https://bugs.openjdk.java.net/browse/JDK-8213048 Webrev: http://cr.openjdk.java.net/~kaddepalli/8213048/webrev00/ Thanks, Krishna

Re: OpenJdk11-28-EA JDialog hanging

+1   Krishna   From: Laurent Bourgès Sent: Tuesday, November 13, 2018 2:18 PM To: Martin Balao Cc: awt-dev@openjdk.java.net Subject: Re: OpenJdk11-28-EA JDialog hanging   Hi, Sergey approved the webrev.4, anyone else?   I would like this bug fix to be pushed soon, then this RFR.   Re

Re: OpenJdk11-28-EA JDialog hanging

Hi Martin & Laurent, Thank you for all your efforts in root causing and fixing this important issue. Regards, Krishna > On 14-Nov-2018, at 11:16 PM, Martin Balao wrote: > > Hi, > > Submit-repo tests passed. > > Changeset has been committed: > http://hg.openjdk.java.net/jdk/jdk/rev/08a0bf1592

Re: [12] RFR 8213983: [macosx] Keyboard shortcut “cmd +`” stops working properly if popup window is displayed

Hi Dmitry, While I understand that you donot want to order the windows when the popup window is present as a child of the root window, I did not understand, why you need to check if the total number of windows should be only one. If I understand correctly, if a modal dialog/any other child windo

Re: [12]RFR: JDK-8213048: Invalid use of HTML5 in java.awt files

net/~kaddepalli/8213048/webrev01/ Thanks, Krishna -Original Message- From: Sergey Bylokhov Sent: Saturday, November 10, 2018 2:19 AM To: Krishna Addepalli ; awt-dev@openjdk.java.net Subject: Re: [12]RFR: JDK-8213048: Invalid use of HTML5 in java.awt files Hi, Krishna. The closed tag &qu

Re: [12] RFR 8213583: Error while opening the JFileChooser when desktop contains shortcuts pointing to deleted files

Hi Dmitry, Thanks for fixing this issue. The change looks fine. Thanks, Krishna From: Dmitry Markov Sent: Monday, November 26, 2018 4:09 PM To: awt-dev@openjdk.java.net Subject: [12] RFR 8213583: Error while opening the JFileChooser when desktop contains shortcuts pointing to delete

Re: [OpenJDK 2D-Dev] [12]RFR: [JDK-8074824]: Resolve disabled warnings for libawt_xawt

K3 and did not find any crashes. Thanks, Krishna From: Krishna Addepalli Sent: Tuesday, October 2, 2018 8:53 PM To: Philip Race Cc: awt-dev@openjdk.java.net; 2d-dev <2d-...@openjdk.java.net>; build-dev Subject: Re: [OpenJDK 2D-Dev] [12]RFR: [JDK-8074824]: Resolve disabled warnings

Re: [OpenJDK 2D-Dev] [12]RFR: [JDK-8074824]: Resolve disabled warnings for libawt_xawt

Hi Magnus,   Thanks for taking a look. I was wanting to change the SAFE_ALLOC definition, but since that file is in java.base, I was not sure of changing it.   Krishna   From: Magnus Ihse Bursie Sent: Tuesday, November 27, 2018 6:52 PM To: Krishna Addepalli Cc: Philip Race ; awt-dev

Re: [12]RFR: JDK-8213048: Invalid use of HTML5 in java.awt files

, addressing them in separate bug is better? Here is the updated webrev: http://cr.openjdk.java.net/~kaddepalli/8213048/webrev02 Thanks, Krishna -Original Message- From: Alexey Ivanov Sent: Tuesday, November 27, 2018 5:18 PM To: Sergey Bylokhov ; Krishna Addepalli ; awt-dev Subject: Re: [12]RFR

Re: [12]RFR: JDK-8213048: Invalid use of HTML5 in java.awt files

Sure, Alexey that would be helpful. Thanks, Krishna -Original Message- From: Alexey Ivanov Sent: Thursday, November 29, 2018 4:23 PM To: Sergey Bylokhov ; Krishna Addepalli ; awt-dev Subject: Re: [12]RFR: JDK-8213048: Invalid use of HTML5 in java.awt files On 28/11/2018 21:55

Re: [12]RFR: JDK-8213048: Invalid use of HTML5 in java.awt files

Hi Alexey, Thanks for your suggestions. I have already committed the changes. Can we address this in a new bug? Thanks, Krishna > On 29-Nov-2018, at 5:15 PM, Alexey Ivanov wrote: > > Hi Krishna, > > Thank you for dropping tags. > > *DesktopProperties.html:* > > 61 > > bgcolor attribute i

Re: [OpenJDK 2D-Dev] [12] Review Request: 8214461 Some unused classes may be removed

Looks good to me. Krishna > On 01-Dec-2018, at 7:33 AM, Sergey Bylokhov > wrote: > > Hello. > Please review the fix for jdk 12. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8214461 > Webrev: http://cr.openjdk.java.net/~serb/8214461/webrev.00 > > We have a few internal classes/interfaces

  1   2   >