Re: [7u] Review request for 8012026: [macosx] Component.getMousePosition() does not work in an applet on MacOS

The fix looks good for me. Thanks, Alexandr. On 3/6/2014 11:13 AM, dmitry markov wrote: Reminder. Could you review this, please? Thanks, Dmitry On 03/03/2014 16:20, dmitry markov wrote: Hello, Could you review a straight back-port of 8012026 to jdk7u, please? bug: https://bugs.open

[9] Review request for 8035069 [macosx] Loading resolution variants by demand

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8035069 webrev: http://cr.openjdk.java.net/~alexsch/8035069/webrev.00 Image resolution variants are generated by request and cached in the ImageCache. - ImageCache is refactored to store different type of

Re: [9] Review request for 8035069 [macosx] Loading resolution variants by demand

/JDK-8037405 It seems as a common problem so I added resolution variants preloading to the MultiResolutionBufferedImage. Thanks, Alexandr. With best regards. Petr. On 12.03.2014, at 19:03, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.op

Re: [OpenJDK 2D-Dev] [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

return image; } } return this; } } -- Thanks, Alexandr. On 2/27/2014 4:54 PM, Alexander Scherbatiy wrote: On 2/22/2014 3:54 AM, Jim Graham wrote: Hi Alexandr, On 2/18/14 7:33 AM, Alexander Scherbatiy wrote: Hi Jim, Let's divide the discussion

Re: [OpenJDK 2D-Dev] [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

...jim On 3/20/14 7:52 AM, Alexander Scherbatiy wrote: Hello, Could you review the updated version of the fix: http://cr.openjdk.java.net/~alexsch/8029339/webrev.01/ - The "getResolutionVariant(int width, int height)" method from MultiResol

Re: [9] Review request : 8022531 [TEST_BUG] After double-click on the folder names , there is no 'OK' button in the dialog.

The fix looks good. Thanks, Alexandr. On 3/21/2014 2:31 PM, Konstantin Shefov wrote: Hello AWT team, please review the fix http://cr.openjdk.java.net/~kshefov/8022531/webrev.00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8022531 It is simple manual test fix. Thanks -Konst

Re: [OpenJDK 2D-Dev] [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

:33 AM, Alexander Scherbatiy wrote: Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8029339/webrev.02/ - transform is removed from the getResolutionVariant(...) method I notice that you reverted the changes to SG2D so that it now calculates the

[9] Review request for 8032667 [macosx] Components cannot be rendered in HiDPI to BufferedImage

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8032667 webrev: http://cr.openjdk.java.net/~alexsch/8032667/webrev.00 High resolution image width and height were calculated using only scale factor in the AquaPainter class. The fix calculates image width a

Re: [9] Review request for 8032667 [macosx] Components cannot be rendered in HiDPI to BufferedImage

Bylokhov wrote: Hello, Alexander. You cannot skip scalfactor as a key, because images with different scale are different. On 3/25/14 8:10 PM, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8032667 webrev: http

Re: [9] Review request for 8032667 [macosx] Components cannot be rendered in HiDPI to BufferedImage

list in case if they are not passed to the constructor. Thanks, Alexandr. On 3/26/2014 4:30 PM, Sergey Bylokhov wrote: Hello, Alexander. I think it will not work if the user set scale=1.5? On 3/26/14 4:18 PM, Alexander Scherbatiy wrote: Hello, Could you review the updated fix

[9] Review request for 8038113 [macosx] JTree icon is not rendered in high resolution on Retina

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8038113 webrev: http://cr.openjdk.java.net/~alexsch/8038113/webrev.00 MultiResolution image is used to create resolution variants for the JTree icons. The fix assumes that AquaPainter uses the graphics tra

Re: [OpenJDK 2D-Dev] [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

Below are some thoughts about TK.createMRImage(...) method On 3/24/2014 4:52 PM, Alexander Scherbatiy wrote: Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8029339/webrev.03/ - baseImageWidth/Height arguments are added to the getResolutionVariant

[9] Review request for 8036882 [macosx] Native memory leak in Java_sun_lwawt_macosx_CImage_nativeGetNSImageRepresentationSizes

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8036882 webrev: http://cr.openjdk.java.net/~alexsch/8036882/webrev.00 autorelease is added for [[NSMutableArray alloc] init] call. There is no a test for the fix because it is hard to write it. Thanks, Alexandr

Re: [9] Review request for 8032667 [macosx] Components cannot be rendered in HiDPI to BufferedImage

PM, Sergey Bylokhov wrote: Hi, Alexander. The fix looks fine to me. Probably the test can be automated? before the fix COMP->imagex1->imagex2 and the COMP->imagex2 should be the same, and after the fix it should be different? On 3/26/14 5:43 PM, Alexander Scherbatiy wrote: Could yo

Re: [9] Review request for 8038113 [macosx] JTree icon is not rendered in high resolution on Retina

the properly scaled image. Thanks, Alexandr. On 3/26/2014 6:15 PM, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8038113 webrev: http://cr.openjdk.java.net/~alexsch/8038113/webrev.00 MultiResolution image is used to

Re: [OpenJDK 2D-Dev] [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

7:43 AM, Alexander Scherbatiy wrote: Below are some thoughts about TK.createMRImage(...) method On 3/24/2014 4:52 PM, Alexander Scherbatiy wrote: Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8029339/webrev.03/ - baseImageWidth/Height argumen

Re: [9] Review request for 8038113 [macosx] JTree icon is not rendered in high resolution on Retina

() method which uses the properly scaled image. Thanks, Alexandr. On 3/26/2014 6:15 PM, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8038113 webrev: http://cr.openjdk.java.net/~alexsch/8038113/webrev.00 MultiResolution image

Re: [9] Review Request: 8039267 Test closed/java/awt/Choice/ChoiceLocationTest/ChoiceLocationTest.html should be removed

The fix looks good for me. Thanks, Alexandr. On 4/8/2014 2:47 PM, Petr Pchelko wrote: Hello, Could I get a second review on this trivial change? Thank you. With best regards. Petr. On 04.04.2014, at 16:59, Alexander Zvegintsev wrote: Hello Petr, the fix looks good to me. Thanks,

[9] Review request for 8039001 [macosx] Textfields in dialogs are disabled after using F3 on Mac OS X to select a window

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8039001 webrev: http://cr.openjdk.java.net/~alexsch/8039001/webrev.00 NSRunningApplication active property is false when windowDidBecomeKey notification is received after switching from the Mission Control

Re: Review request for JDK-8038631: Create wrapper for awt.Robot with additional functionality

On 4/7/2014 3:56 PM, Dmitriy Ermashov wrote: Hi, Sergey Do you have any additions? http://cr.openjdk.java.net/~yan/8038631/webrev.06/ Will the AccessController.doPrivileged() block work under the Security manager if the ExtendedRobot package is not listed in the "package.access" list?

Re: Review request for JDK-8038631: Create wrapper for awt.Robot with additional functionality

The fix looks good for me. Thanks, Alexandr. On 4/9/2014 4:54 PM, Dmitriy Ermashov wrote: Sure, the correct URL is your one. Thanks! On 04/09/2014 04:53 PM, Petr Pchelko wrote: Hello, Dmitriy. I assume the correct link is http://cr.openjdk.java.net/~yan/8038631/webrev.07 Looks good. Wit

[9] Review request for 8040279 [macosx] Do not use the base image in the MultiResolutionBufferedImage constructor

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8040279 webrev: http://cr.openjdk.java.net/~alexsch/8040279/webrev.00 MultiResolutionBufferedImage extends BufferedImage. In this case it needs to use the base image to write it to the BufferedImage. The f

Re: Review request for JDK-8039279: Move first batch of functional tests to openjdk repository

The fix looks good for me. If it is unlikely to use sun.awt.* classes to check the OS version, may be it would be better to add the OS version check method to the ExtendedRobot? Thanks, Alexandr. On 4/17/2014 1:22 PM, Dmitriy Ermashov wrote: Hi, Please, review the changeset for: http

Re: [9] Review request for 8040279 [macosx] Do not use the base image in the MultiResolutionBufferedImage constructor

createBufferedImage method does not create a BufferredImage any more, so it worths renaming. With best regards. Petr. On 15.04.2014, at 18:36, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8040279 webrev: http://cr.openjdk.java.net

Re: [OpenJDK 2D-Dev] [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

On 3/27/14 7:43 AM, Alexander Scherbatiy wrote: Below are some thoughts about TK.createMRImage(...) method On 3/24/2014 4:52 PM, Alexander Scherbatiy wrote: Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8029339/webrev.03/ - baseImageWidth/Height argumen

Re: [OpenJDK 2D-Dev] [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

these capabilities? This is the request from the AWT team for the HiDPI support. Thanks, Alexandr. ...jim On 4/4/14 4:53 AM, Alexander Scherbatiy wrote: On 4/3/2014 2:23 AM, Jim Graham wrote: Hi Alexandr, The back and forth is getting confusing here, so I thought I

[9] Review request for 8040291 [macosx] Http-Images are not fully loaded when using ImageIcon

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8040291 webrev: http://cr.openjdk.java.net/~alexsch/8040291/webrev.00 The SunToolkit.prepareResolutionVariant() method wraps the base image observer and passes it to the resolution variant. It leads that th

Re: [OpenJDK 2D-Dev] [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

/browse/JDK-7124410 Thanks, Alexandr. On 4/25/2014 6:45 PM, Alexander Scherbatiy wrote: On 4/25/2014 2:17 AM, Jim Graham wrote: Hi Alexandr, I asked for who was requesting these facilities and you responded with the solution you are planning to provide. I don't care what the solution

Re: [9] Review Request: 8031485 [macosx] Combo box consuming escape key events

The fix looks good for me. Thanks, Alexandr. On 5/14/2014 6:13 PM, Petr Pchelko wrote: Hello, Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8031485 The fix is available at: http://cr.openjdk.java.net/~pchelko/9/8031485/webrev.00/ We should not consume th

Re: Request for review, JDK-8009883, REGRESSION: test/closed/javax/swing/AbstractButton/4246045/bug4246045.java fails

Hi Peter, Is there any difference between AccessibleAWTFocusHandler and AccessibleFocusHandler classes? Thanks, Alexandr. On 5/7/2014 5:45 AM, Pete Brunet wrote: Hi Swing and AWT teams, (and Artem since you were involved in the 7179482 fix), I'd appreciate your review for a fix to

Re: Request for review, JDK-8009883, REGRESSION: test/closed/javax/swing/AbstractButton/4246045/bug4246045.java fails

On 5/16/2014 7:15 PM, Pete Brunet wrote: On 5/16/14 6:45 AM, Alexander Scherbatiy wrote: Hi Peter, Is there any difference between AccessibleAWTFocusHandler and AccessibleFocusHandler classes? Hi Alexandr, The former is the focus handler used by the inner class accessibility support for

Re: [OpenJDK 2D-Dev] [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

Hi Phil, I need a reviewer from the 2d group for the fix. Could you take a look at the fix and review it? Thanks, Alexandr. On 5/12/2014 6:35 PM, Alexander Scherbatiy wrote: There was a long thread about the image with sub-pixel resolution drawing on Mac OS X: http

Re: [OpenJDK 2D-Dev] [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

r the low-resolution image faster. Thanks, Alexandr. -phil. On 5/16/2014 9:16 AM, Alexander Scherbatiy wrote: Hi Phil, I need a reviewer from the 2d group for the fix. Could you take a look at the fix and review it? Thanks, Alexandr. On 5/12/2014 6:35 PM, Alexander Scherba

[9] Review request for 8036110 In TextField can only select text visible or to the left of the cursor

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8036110 webrev: http://cr.openjdk.java.net/~alexsch/8036110/webrev.00 This is a regression from the fix 7092551 where the EDIT control has been changed to the RICHEDIT. GetScrollInfo(hWnd, SB_HORZ, &scrollin

Re: [9] Review request for 8036110 In TextField can only select text visible or to the left of the cursor

On 5/19/2014 8:18 PM, Sergey Bylokhov wrote: Hello, Alexander. Can you check that the test works correctly on linux/osx. The test passes on Linux Ubuntu and Mac OS X. Thanks, Alexandr. On 19.05.2014 19:05, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug

Re: [9] Review request for 8040291 [macosx] Http-Images are not fully loaded when using ImageIcon

Hello, Could you look at the fix? Thanks, Alexandr. On 4/30/2014 6:34 PM, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8040291 webrev: http://cr.openjdk.java.net/~alexsch/8040291/webrev.00 The

Re: [9] Review request for 8040291 [macosx] Http-Images are not fully loaded when using ImageIcon

, Alexandr. With best regards. Petr. On May 20, 2014, at 6:32 PM, Alexander Scherbatiy wrote: Hello, Could you look at the fix? Thanks, Alexandr. On 4/30/2014 6:34 PM, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK

Re: [9] Review request for 8040291 [macosx] Http-Images are not fully loaded when using ImageIcon

best regards. Petr. On May 20, 2014, at 7:07 PM, Alexander Scherbatiy wrote: Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8040291/webrev.01 - The getRVSize() method from the SunToolkit is fixed On 5/20/2014 6:46 PM, Petr Pchelko wrote: Hello, Alexander. SunToolkit

Re: Request for review, JDK-8009883, REGRESSION: test/closed/javax/swing/AbstractButton/4246045/bug4246045.java fails

On 5/20/2014 1:10 AM, Pete Brunet wrote: On 5/16/14 11:04 AM, Pete Brunet wrote: On 5/16/14 10:45 AM, Alexander Scherbatiy wrote: On 5/16/2014 7:15 PM, Pete Brunet wrote: On 5/16/14 6:45 AM, Alexander Scherbatiy wrote: Hi Peter, Is there any difference between

Re: Request for review, JDK-8009883, REGRESSION: test/closed/javax/swing/AbstractButton/4246045/bug4246045.java fails

On 5/21/2014 2:56 PM, Alexander Scherbatiy wrote: On 5/20/2014 1:10 AM, Pete Brunet wrote: On 5/16/14 11:04 AM, Pete Brunet wrote: On 5/16/14 10:45 AM, Alexander Scherbatiy wrote: On 5/16/2014 7:15 PM, Pete Brunet wrote: On 5/16/14 6:45 AM, Alexander Scherbatiy wrote: Hi Peter, Is

Re: [9] Review request for 8040291 [macosx] Http-Images are not fully loaded when using ImageIcon

Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8040291/webrev.03/ - The test checks that the resolution-variant observer is called at least once. Thanks, Alexandr. On 5/21/2014 2:50 PM, Alexander Scherbatiy wrote: Could you review the updated fix: http

Re: Request for review, JDK-8009883, REGRESSION: test/closed/javax/swing/AbstractButton/4246045/bug4246045.java fails

5/21/14 10:08 AM, Pete Brunet wrote: On 5/21/14 7:04 AM, Alexander Scherbatiy wrote: On 5/21/2014 2:56 PM, Alexander Scherbatiy wrote: On 5/20/2014 1:10 AM, Pete Brunet wrote: On 5/16/14 11:04 AM, Pete Brunet wrote: On 5/16/14 10:45 AM, Alexander Scherbatiy wrote: On 5/16/2014 7:15 PM, Pete B

Re: [7u] Review request for 7160604: Using non-opaque windows - popups are initially not painted correctly

The backport looks good for me. Thanks, Alexandr. On 5/23/2014 2:33 PM, Anton Litvinov wrote: Hello Sergey and Alexander, On "jdk7u-dev" e-mail alias my request to push this backport was rejected and I was obligated to pass the regular code review. Could you please review this back po

Re: [9] Review Request: 8043610 Sorting columns in JFileChooser fails with AppContext NPE

The fix looks good for me. Thanks, Alexandr. On 5/22/2014 5:43 PM, Petr Pchelko wrote: Hello, AWT Team. Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8043610 The fix is available at: http://cr.openjdk.java.net/~pchelko/9/8043610/webrev/ The problem is th

Re: Review Request for 8041915: Move 8 awt tests to OpenJDK regression tests tree

The fix looks good for me. Thanks, Alexandr. On 5/26/2014 1:41 PM, Dmitriy Ermashov wrote: Hi, I still have no second successful review.. Could you please look at the fix of https://bugs.openjdk.java.net/browse/JDK-8041915 Webrev is here: http://cr.openjdk.java.net/~yan/8041915/webrev.

[9] Review request for 8043705 Can't exit color chooser dialog when running as an applet

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8043705 webrev: http://cr.openjdk.java.net/~alexsch/8043705/webrev.00 AppContext.getAppContext() returns null in Applet for the getActiveWindowHandles() method which is called from the native system. The

Re: [9] Review Request: 8041990 [macosx] Language specific keys does not work in applets when opened outside the browser

The fix looks good for me. Thanks, Alexandr. On 5/28/2014 12:52 PM, Petr Pchelko wrote: Hello, Please review an updated fix: http://cr.openjdk.java.net/~pchelko/9/8041990/webrev.01/ I've removed null-checks in EventQueueAccessor, because these could mask bugs. All the rest is the same.

Re: [9] Review Request: 8041990 [macosx] Language specific keys does not work in applets when opened outside the browser

so it was moved to a separate method in InputMethodEvent. Thank you. With best regards. Petr. On 06 июня 2014 г., at 12:25, Alexander Scherbatiy wrote: The fix looks good for me. Thanks, Alexandr. On 5/28/2014 12:52 PM, Petr Pchelko wrote: Hello, Please review an updated fix:

Re: [9] Review Request: 8033786 White flashing when opening Dialogs and Menus using Nimbus with dark background

The swing part looks good for me. Thanks, Alexandr. On 6/11/2014 5:13 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9, which is also targeted for jdk 8u20. Problems description: JDialog does not set background color of the peer, like JFrame does + there is a lag between

Re: Review Request: 8046221 [TEST_BUG] Cleanup datatransfer tests

The fix looks good for me. Thanks, Alexandr. On 6/6/2014 5:05 PM, Petr Pchelko wrote: Hello, AWT Team. Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8046221 The fix is available at: http://cr.openjdk.java.net/~pchelko/9/8046221/webrev/ During my datatrans

[9] Review request for 8043869 [macosx] java -splash does not honor @2x hi dpi notation for retina support

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8043869 webrev: http://cr.openjdk.java.net/~alexsch/8043869/webrev.00 The scaleFactor field is added to the Splash struct. The SplahsScreen class scales the graphics and the size according to the scale facto

Re: [9] Review request for 8043869 [macosx] java -splash does not honor @2x hi dpi notation for retina support

s. Petr. On 17 июня 2014 г., at 15:36, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8043869 webrev: http://cr.openjdk.java.net/~alexsch/8043869/webrev.00 The scaleFactor field is added to the Splash struct. The SplahsScre

Re: [9] Review Request: 8047061 [macosx] Crash when setting display mode

The fix looks good to me. Thanks, Alexandr. On 6/17/2014 4:43 PM, Petr Pchelko wrote: Hello, AWT Team. Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8047061 The fix is available at: http://cr.openjdk.java.net/~pchelko/9/8047061/webrev/ When we are search

Re: [9] Review request for 8043869 [macosx] java -splash does not honor @2x hi dpi notation for retina support

plash screen image name and size are provided for the developer even the high resolution splash screen is shown. Thank you for the clarification. The updated version looks fine to me. With best regards. Petr. On 17 июня 2014 г., at 18:16, Alexander Scherbatiy wrote: Hello, Could yo

Re: Review Request for 8047180: Move functional tests AWT_Headless/Automated to OpenJDK repository

The fix looks good to me. Thanks, Alexandr. On 6/20/2014 10:26 AM, Dmitriy Ermashov wrote: On 06/19/2014 06:39 PM, Petr Pchelko wrote: Hello, Dmitriy. It's impossible to review)) Impossible is nothing! (c)) I've briefly skimmed the classes and didn't see any problems with the tests. Loo

Re: [9] Review request for 8043869 [macosx] java -splash does not honor @2x hi dpi notation for retina support

se items are being read from a user generated image file. One last thing, I am assuming you have run all the launcher regressions including the SplashScreen tests in the jdk/test/closed ? Kumar On 6/18/2014 6:03 AM, Alexander Scherbatiy wrote: Hello, Could you review the updated

Re: [9] Review Request: JDK-8047799 Remove WindowClosingSupport

The fix looks good to me. Thanks, Alexandr. On 6/26/2014 1:12 PM, Petr Pchelko wrote: Hello, Please review the updated version: http://cr.openjdk.java.net/~pchelko/9/8047799/webrev.01/ I've removed the unused import as Anthony suggested. Also the Component.windowClosingException is no

Re: [9] Review request for 8044614: [macosx] Focus issue with 2 applets in firefox

Let's assume one browser has 3 applets where the second applet has focus. I click on the second browser with an applet (the applet receives the focus) and then click on the first browser back. Should the second applet in the first browser receive the focus? Thanks, Alexandr. On 7/2/2014

Re: [9] Review request for 8044614: [macosx] Focus issue with 2 applets in firefox

On 02/07/2014 16:36, Alexander Scherbatiy wrote: Let's assume one browser has 3 applets where the second applet has focus. I click on the second browser with an applet (the applet receives the focus) and then click on the first browser back. Should the second applet in the first brows

Re: [9] Review request for 8044614: [macosx] Focus issue with 2 applets in firefox

On 7/3/2014 2:25 PM, Alexander Scherbatiy wrote: On 7/3/2014 1:15 PM, dmitry markov wrote: Hi Alexandr, Thank you for review. For the use case you described - when we move back to the first browser window with 3 applets, the first applet (not the second one) will receive the focus. This

[9] Review request for 8049198 [macosx] Incorrect thread access when showing splash screen

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8049198 webrev: http://cr.openjdk.java.net/~alexsch/8049198/webrev.00 NSScreen call is moved to perform on the main thread. Thanks, Alexandr.

Re: [9] Review request for 8049198 [macosx] Incorrect thread access when showing splash screen

. With best regards. Petr. On 10 июля 2014 г., at 16:42, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8049198 webrev: http://cr.openjdk.java.net/~alexsch/8049198/webrev.00 NSScreen call is moved to perform on the main thread

Re: [9] Review Request: 8049998 [macosx] test java/awt/image/ImageIconHang.java fails with NPE

The fix looks good. Thanks, Alexandr. On 7/11/2014 3:50 PM, Petr Pchelko wrote: Hello, AWT Team. Please review a little fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8049998 The fix is available at: http://cr.openjdk.java.net/~pchelko/9/8049998/webrev/

[9] Review request for 8044444 The output's 'Page-n' footer does not show completely.

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-804 webrev: http://cr.openjdk.java.net/~alexsch/804/webrev.00 Native method printLoop from CPrinterJob calls javaPrinterJobToNSPrintInfo(...) method after javaPageFormatToNSPrintInfo(...). Both meth

Re: [9] Review request for 8044614: [macosx] Focus issue with 2 applets in firefox

efactoring: focusedWindow -> globalFocusedWindow, previousFocusedWindow -> pluginFocusedWindow, etc. - Added manual test Thanks, Dmitry On 04/07/2014 14:26, Alexander Scherbatiy wrote: On 7/3/2014 2:25 PM, Alexander Scherbatiy wrote: On 7/3/2014 1:15 PM, dmitry markov wrote: Hi Alexandr

Re: [9] Review request for 8044614: [macosx] Focus issue with 2 applets in firefox

The fix looks good to me. Thanks, Alexandr. On 7/18/2014 3:52 PM, dmitry markov wrote: Hi Alexandr, Please find answer below. Thanks, Dmitry On 17/07/2014 14:18, Alexander Scherbatiy wrote: The pluginFocusedWindow is only updated after switching from one browser to another

[9] Review request for 8051359 JPopupMenu creation in headless mode with JDK9b23 causes NPE

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8051359 webrev: http://cr.openjdk.java.net/~alexsch/8051359/webrev.00 The fix avoids NPE throwing in headless mode. There are already regression tests that covers the issue in jdk/test/javax/swing/Headless

Re: [9] Review request for 8051359 JPopupMenu creation in headless mode with JDK9b23 causes NPE

k in targetToAppContext method? I think this check is incorrect, because it's perfectly valid to have multiple AppContexts in headless mode. With best regards. Petr On 21 июля 2014 г., at 13:33, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.

Re: [9] Review request for 8044614: [macosx] Focus issue with 2 applets in firefox

owse/JDK-8044614 http://cr.openjdk.java.net/~dmarkov/8044614/jdk9/webrev.02/ Thanks in advance, Dmitry On 18/07/2014 15:57, Alexander Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 7/18/2014 3:52 PM, dmitry markov wrote: Hi Alexandr, Please find answer below. Thank

Re: [9] Review Request: 8051588 DataTransferer.getInstance throws ClassCastException in headless mode

The fix looks good to me. Thanks, Alexandr. On 7/22/2014 4:20 PM, Petr Pchelko wrote: Hello, AWT Team. Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8051588 The fix is available at: http://cr.openjdk.java.net/~pchelko/9/8051588/webrev/ JCK test fails in hea

Re: [9] Review Request: 8051449 Incorrect parsing of the default flavor mapping

The fix looks good to me. Thanks, Alexandr. On 7/28/2014 3:35 PM, Petr Pchelko wrote: Hello, AWT Team. Please review an updated version of this fix: http://cr.openjdk.java.net/~pchelko/9/8051449/webrev.01/ I've changed the package name for a flavormap.properties file, because it needs

Re: [OpenJDK 2D-Dev] [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

Just friendly remainder. Thanks, Alexandr. On 7/8/2014 7:02 PM, Alexander Scherbatiy wrote: Hi Phil, Could you review the fix? Thanks, Alexandr. On 6/11/2014 7:18 PM, Alexander Scherbatiy wrote: Hi Phil , I just prepared a simple FAQ about the Custom MultiResolution

Re: [OpenJDK 2D-Dev] [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

anks, Alexandr. On 7/29/2014 6:44 PM, Alexander Scherbatiy wrote: On 6/11/2014 7:18 PM, Alexander Scherbatiy wrote: Hi Phil , I just prepared a simple FAQ about the Custom MultiResolution image API. Hope it will be helpful. 1. Scale naming convention for high-resolution images. Different OSes

Re: [7u-dev] Request for approval for JDK-8043610: Sorting columns in JFileChooser fails with AppContext NPE

The fix looks good to me. Thanks, Alexandr. On 8/20/2014 5:35 PM, Alexey Ivanov wrote: Hello, Please approve the backport of the fix to jdk7u-dev. I replaced lambda expressions and method reference with anonymous classes: webrev: http://cr.openjdk.java.net/~aivanov/8043610/jdk7/

Re: [9] Review request for 8055664: move 14 tests about setLocationRelativeTo to jdk

The fix looks good to me. Thanks, Alexandr. On 8/28/2014 7:04 PM, Alexander Zvegintsev wrote: Still looks good to me. -- Thanks, Alexander. On 08/28/2014 06:38 PM, Yuri Nesterenko wrote: Thank you Alexander! new version: http://cr.openjdk.java.net/~yan/8055664/webrev.01 -yan On 0

Re: [9] Review request for JDK-8056211: JCK test api/java_awt/Event/InputMethodEvent/serial fails

The fix looks good to me. Thanks, Alexandr. On 9/2/2014 3:09 PM, Alexey Ivanov wrote: Hello AWT team, This is a reminder, Is there any volunteer to review this fix? Thanks, Alexey. On 29.08.2014 12:20, Alexey Ivanov wrote: Hello AWT Team, Could you please review the fix for bug:

Re: [9] Review request for 8055746 : plenty of clipboard/dnd tests fail and break X11

The fix looks good to me. Thanks, Alexandr. On 9/1/2014 4:55 PM, Alexander Zvegintsev wrote: Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8055746/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8055746 This is a merge issue. JDK-8051449 [2] was pushe

[9] Review request for 8057940 JCK test api/java_awt/Image/renderable/ParameterBlock fails with StackOverflowError

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8057940 webrev: http://cr.openjdk.java.net/~alexsch/8057940/webrev.00 The fix reverts JDK-8049893 change which introduces infinity loop in the ParameterBlock.add(int)/set(int) methods after replacing Integer

Re: [9] Review Request for 8054359: move awt automated tests from AWT_Modality to OpenJDK repository - part 8

75 int x = Toolkit.getDefaultToolkit().getScreenSize().width - 200; 76 parent.setLocation(x, 50); 77 window.setLocation(x, 250); 78 dialog.setLocation(x, 450); It is better to use part of the screen or frame size instead of absolute values like 200, 50

Re: [9] Review Request for 8056991: Provide OSInfo functionality to regression tests

test/lib/testlibrary/jdk/testlibrary/OSInfo.java 32 import static jdk.testlibrary.OSInfo.OSType.*; Is this import necessary? 115 public static PrivilegedAction getOSTypeAction() { 116 return osTypeAction; 117 } Is this method used in the tests? Thanks, Alexandr. On 9/15/20

Re: [9] Review Request for 8056991: Provide OSInfo functionality to regression tests

The fix looks good to me. Thanks, Alexandr. On 9/15/2014 3:00 PM, Yuri Nesterenko wrote: On 09/15/2014 02:42 PM, Alexander Scherbatiy wrote: test/lib/testlibrary/jdk/testlibrary/OSInfo.java 32 import static jdk.testlibrary.OSInfo.OSType.*; Is this import necessary? Yes: many tests use

Re: [9] Review Request: 8055326 Fix typos in client-related packages

The fix looks good to me. Thanks, Alexandr. On 9/10/2014 4:11 PM, Sergey Bylokhov wrote: Hi, Phil. It seems both changes are unnecessary: http://cr.openjdk.java.net/~serb/8055326/webrev.01 On 21.08.2014 22:04, Phil Race wrote: Was the additional spce on the 2nd line intended here ? --

Re: [9] Review Request: 8058635 Fix type in client-related package for Compilation fail in sun/awt/datatransfer/SuplementaryCharactersTransferTest.java

The fix looks good to me. Thanks, Alexandr. On 9/18/2014 1:00 PM, pooja chopra wrote: |Hello, | || |Please review a fix ||for| |the issue: | || |8058635| |[TEST_BUG] ||sun/awt/datatransfer/SuplementaryCharactersTransferTest.java fails with Compilation error ||| || |Test bug fix. | ||

Re: [9] Review request for 8058726: Update regtests using sun.awt.OSInfo, part 1

The fix looks good to me. Thanks, Alexandr. On 9/18/2014 2:48 PM, Yuri Nesterenko wrote: Colleagues, please review this change in tests only: http://cr.openjdk.java.net/~yan/8058726/webrev.00 and http://cr.openjdk.java.net/~yan/8058726/webrev.diff.00 for a bug https://bugs.openjdk.jav

Re: [9] Review Request: 8041734 JFrame in full screen mode leaves empty workspace after close

The fix looks good to me. Is it possible to write an automated test for the fix? Thanks, Alexandr. On 9/22/2014 3:00 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9, which adds additional call to nswindow.close() when we hide/dispose our peer. Bug: https://bugs.openjd

Re: [9] Review Request: 8058858 JRE 8u20 crashes while using Japanese IM on Windows

The fix looks good to me. Thanks, Alexandr. On 9/22/2014 7:29 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. The problem is that we call DeleteLocalRef() on the cached global reference returned by JNU_ClassString(env). Bug: https://bugs.openjdk.java.net/browse/JDK

Re: [9] Review request for 8051857: OperationTimedOut exception inside from XToolkit.syncNativeQueue call

The fix looks good to me. Thanks, Alexandr. On 9/23/2014 7:44 PM, Sergey Bylokhov wrote: Hi, Alexander. The fix looks good. On 23.09.2014 17:59, Alexander Zvegintsev wrote: Hi Sergey, you are right, please see updated webrev here: http://cr.openjdk.java.net/~azvegint/jdk/9/8051857/01/

Re: [9] Review Request: 7148531 [macosx] In test, the window does not have time to resize before make a screenshot

The fix looks good to me. Thanks, Alexandr. On 10/14/2014 4:46 PM, Alexander Zvegintsev wrote: Hello Sergey, the fix looks good to me. Thanks, Alexander. On 10/14/2014 04:31 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. - Frame was changed to undecorated to sol

Re: [9] Review request for 8044444 The output's 'Page-n' footer does not show completely.

Hello, Could you review the fix? Thanks, Alexandr. On 7/15/2014 3:28 PM, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-804 webrev: http://cr.openjdk.java.net/~alexsch/804/webrev.00 Native method printLoop from

Re: [9] Review Request: JDK-8058805 Fix type in client-related package for tray.policy file missing in java/awt/TrayIcon/SecurityCheck/NoPermissionTest

The fix looks good to me. Thanks, Alexandr. On 11/5/2014 6:28 PM, pooja chopra wrote: Hi All, A gentle reminder . Please review below fix . webrev Link : - http://cr.openjdk.java.net/~kshefov/8058805/webrev.01/ JBS: - https://bugs.openjdk.java.net/browse/JDK-8058805 Regards, Pooja On

[9] Review request for 8064468 ownedWindowList access requires synchronization in Window.setAlwaysOnTop() method

Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8064468 webrev: http://cr.openjdk.java.net/~alexsch/8064468/webrev.00 The fix uses the copy of the owned windows list to avoid the synchronization issue. Thanks, Alexandr.

Re: Fwd: [9] Review request: JDK-8023723 Can not paste and copy the text from the text area into the editor

ect: **[9] Review request: JDK-8023723 Can not paste and copy the text from the text area into the editor* *Date: *14 ноября 2014 г., 15:36:51 GMT+4 *To: *Sergey Bylokhov <mailto:sergey.bylok...@oracle.com>>, Alexander Scherbatiy mailto:alexandr.scherba...@oracle.com>> Hello, AWT Team

Re: Will fix be backported?

On 11/10/2014 6:33 PM, Hendrik Schreiber wrote: Hey... How can I check whether a fix is being backported to JDK8? E.g. https://bugs.openjdk.java.net/browse/JDK-8043869 only lists emb-9 under backports. Does that mean it's not being backported to 8? I have created the backport to JDK 8:

Re: Will fix be backported?

On 11/14/2014 4:31 PM, Hendrik Schreiber wrote: On Nov 14, 2014, at 14:16, Alexander Scherbatiy wrote: On 11/10/2014 6:33 PM, Hendrik Schreiber wrote: How can I check whether a fix is being backported to JDK8? E.g. https://bugs.openjdk.java.net/browse/JDK-8043869 only lists emb-9 under

Re: [9] Review request for 8044444 The output's 'Page-n' footer does not show completely.

sure what the default settings were that were created for the empty attribute set vs the ones that are used when you fixed this. You'll have to tell me that. Perhaps what is needed is a unified call to get the PageFormat which can figure out whether to use the attributes or not. And you c

Re: [9] Review request: JDK-8058193 [macosx] Potential incomplete fix for JDK-8031485

The fix looks good to me. Thanks, Alexandr. On 11/19/2014 2:19 PM, Petr Pchelko wrote: Hello, AWT Team. Please review the fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8058193 The fix is available at: http://cr.openjdk.java.net/~pchelko/9/8058193/webrev/ The problem is th

Re: How to draw HiDPI image resources as BufferedImage?

Hi Tobias, The public API that allows to do that is discussed on the following thread: JDK-8029339 Custom MultiResolution image support on HiDPI displays http://mail.openjdk.java.net/pipermail/awt-dev/2014-August/008371.html Thanks, Alexandr. On 11/25/2014 12:32 PM, Tobias Bley

Re: [9] Review request for 8044444 The output's 'Page-n' footer does not show completely.

-phil. On 11/18/14 8:17 AM, Alexander Scherbatiy wrote: Hi Phil, Before the 8011069 fix RasterPrinterJob.getPageFormatFromAttributes() method returns null for null attributes and native page size for ImageableArea has been used. After the 8011069 fix the attributes are not null and u

Re: [9] Review Request: 6345095 regression test EmptyClipRenderingTest fails

The fix looks good to me. Thanks, Alexandr. On 12/2/2014 5:34 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. - This test fails on osx because of rounded corners. Now it use undecorated frame. - On windows it fails, because sometimes the paint event was coming after

Re: [9] Review request for 8044444 The output's 'Page-n' footer does not show completely.

/without print dialog and with/without media printable area properties is added. Thanks, Alexandr. -phil. On 11/27/14 7:45 AM, Alexander Scherbatiy wrote: On 11/21/2014 9:20 PM, Phil Race wrote: This seems to me to be asking about something I covered already. >The latter one app

  1   2   3   4   5   6   >