Re: Review request for 8048171: Test java/awt/Mixing/AWT_Mixing/OpaqueOverlappingChoice.java fails on solaris, linux but passes on windows

Hi Ambarish, The bug was test was throwing "java.lang.RuntimeException: Opacity test mismatchs". Did this fix solve that problem? It seems to fail in my linux even with this fix. Regards Prasanta On 10/29/2015 7:30 PM, Ambarish Rapte wrote: Dear All, Kindly review the fix fo

Re: Review request for 8048171: Test java/awt/Mixing/AWT_Mixing/OpaqueOverlappingChoice.java fails on solaris, linux but passes on windows

guess we should not touch mouse while test in in progress, in that case it passed. Fix looks fine to me. Regards Prasanta On 10/30/2015 12:09 PM, prasanta sadhukhan wrote: Hi Ambarish, The bug was test was throwing "java.lang.RuntimeException: Opacity test mismatchs". Did this fix

Re: Review request for 8060137: Removing Text from TextField / TextArea is not possible after typing

Looks ok to me. Regards Prasanta On 11/16/2015 3:54 PM, Ambarish Rapte wrote: Dear All, Please review the fix for JDK9, Bug: https://bugs.openjdk.java.net/browse/JDK-8060137 Webrev: http://cr.openjdk.java.net/~arapte/8060137/webrev.00/

Re: Review request for 8060137: Removing Text from TextField / TextArea is not possible after typing

137/webrev.02/>/ // // Many Thanks, Ambarish // *From:*Ambarish Rapte *Sent:* Thursday, November 19, 2015 9:19 PM *To:* Semyon Sadetsky; Prasanta Sadhukhan; awt-dev@openjdk.java.net *Subject:* RE: Review request for 8060137: Removing Text from TextField / TextArea is not possible after

Re: Review Request for 8039081: [TEST_BUG] Test java/awt/TrayIcon/PopupMenuLeakTest/PopupMenuLeakTest.java fails

Looks ok to me. Regards Prasanta On 11/30/2015 10:19 AM, Ambarish Rapte wrote: Hi, Gentle reminder, Please review. Thanks, Ambarish *From:*Ambarish Rapte *Sent:* Friday, November 20, 2015 4:01 PM *To:* Prasanta Sadhukhan; Semyon Sadetsky; awt-dev@openjdk.java.net *Subject:* Review

Re: Review request for 8146317: Memory leak in wcstombsdmp

Looks good to me. Regards Prasanta On 1/6/2016 6:36 PM, Ambarish Rapte wrote: Hi , Please review the fix for JDK9, Bug: https://bugs.openjdk.java.net/browse/JDK-8146317 Webrev: http://cr.openjdk.java.net/~arapte/8146317/webrev.00/

Re: Review request for 6180449: PIT: Text in TextArea scrolls to its left one char when selecting the text from the end

Look ok to me. Did you do the test in windows also? This message can be changed as it seems expected result is same for all platform, right? so why to mention mac differently Expected selected text: '1234 ' and for mac '1234'" On 1/12/2016 3:34 PM, Ambarish Rapte wrote: Hi,

Re: Review request for 6180449: PIT: Text in TextArea scrolls to its left one char when selecting the text from the end

penjdk.java.net/%7Earapte/6180449/webrev.01/> Thanks, Ambarish *From:*prasanta sadhukhan *Sent:* Tuesday, January 12, 2016 4:41 PM *To:* Ambarish Rapte; Semyon Sadetsky; awt-dev@openjdk.java.net *Subject:* Re: Review request for 6180449: PIT: Text in TextArea scrolls to its left one char whe

Re: Review request for 6180449: PIT: Text in TextArea scrolls to its left one char when selecting the text from the end

take a look. Thanks, Ambarish *From:*prasanta sadhukhan *Sent:* Thursday, January 14, 2016 2:45 PM *To:* Ambarish Rapte; Semyon Sadetsky; awt-dev@openjdk.java.net *Subject:* Re: Review request for 6180449: PIT: Text in TextArea scrolls to its left one char when selecting the text from the en

Re: Review Request for 8025001: setFocusTraversalPolicy() to ContainerOrderFocusTraversalPolicy results in an infinite loop

Looks ok to me logically. Also, don't we need to do the same for getComponentBefore() to check for same component? Did you run JCK java/awt/containerorderfocustraversalpolicy tests just to be safe? Regards Prasanta On 2/1/2016 7:18 PM, Ambarish Rapte wrote: Hi All, Please rev

Re: Review Request For 8149636: TextField flicker & over scroll when selection scrolls beyond the bounds of TextField.

pte/8149636/webrev.03/> Thanks, Ambarish *From:*prasanta sadhukhan *Sent:* Thursday, March 17, 2016 2:49 PM *To:* Ambarish Rapte; awt-dev@openjdk.java.net *Cc:* Semyon Sadetsky *Subject:* Re: Review Request For 8149636: TextField flicker & over scroll when selection scrolls beyond the

Re: Review Request For 8149636: TextField flicker & over scroll when selection scrolls beyond the bounds of TextField.

Semyon Sadetsky; Prasanta Sadhukhan; awt-dev@openjdk.java.net *Subject:* RE: Review Request For 8149636: TextField flicker & over scroll when selection scrolls beyond the bounds of TextField. Hi, Gentle reminder for review… Thanks, Ambarish *From:*Ambarish Rapte *Sent:* Tuesday, March

Re: Review request for 8033936: java.awt.List events are not sent properly to handleEvent or ItemListener

FIx looks ok to me. But in testcase, there is no dispose() method but you are still calling dispose(). Also, why there is a need to call performTest() twice? Regards Prasanta On 3/18/2016 2:04 PM, Ambarish Rapte wrote: Hi, Please review the fix for JDK9, Bug:

Re: Review request for 6191390: Action Event triggered by list does not reflect the modifiers properly on win32

rgey Bylokhov Sent: Tuesday, March 29, 2016 5:37 PM To: Ambarish Rapte; Semyon Sadetsky; Prasanta Sadhukhan; awt-dev@openjdk.java.net Subject: Re: Review request for 6191390: Action Event triggered by list does not reflect the modifiers properly on win32 Can you please confirm that this is the

Re: [9] Review request for 8132706 [macosx] Toolkit.getImage() throws NPE for null URL

Hi Alex, Just one observation. If url is null in getImageFromHash() then wouldn't we be getting NPE from checkPermissions(url) as it calls URLUtil.getConnectPermission(url); which calls url.toString().toLowerCase() so it will not come to your check , right? String key = (url == null) ? nu

Re: [9] Review request for JDK-8137137: [macosx] The native dialog doesn't have 'close'(X) button on Mac OS.

Hi Manajit. While pressing x button , the test dialog is not closing in windows. Please check that. Also, the failure message /throw new RuntimeException("Updating TrayIcon popup menu"// //+ " items FAILED");// / seems to be wrong. Regards Prasanta On 4/18/2016 2:59 PM,

Re: Review request for 6384991: TrayIcon ActionListener called at wrong time

:* Tuesday, April 12, 2016 10:03 AM *To:* Sergey Bylokhov; Semyon Sadetsky; Prasanta Sadhukhan; awt-dev@openjdk.java.net *Subject:* Review request for 6384991: TrayIcon ActionListener called at wrong time Hi All, Please review the fix for JDK9, Webrev: http

Re: [9] Review request for JDK-8137137: [macosx] The native dialog doesn't have 'close'(X) button on Mac OS.

anajit On 18-Apr-2016, at 3:30 pm, prasanta sadhukhan <mailto:prasanta.sadhuk...@oracle.com>> wrote: Hi Manajit. While pressing x button , the test dialog is not closing in windows. Please check that. Also, the failure message /throw new RuntimeException("Updating

Re: Review request for 8145284: [Documentation] [TextField] Missing new line character handling

Hi Ambarish, Should we put the doc change at the top or at TextField constructor where you actually made the change for 8055197? My take it should be done in the latter. Also, I think you need a ccc for this. Regards Prasanta On 5/12/2016 12:33 PM, Ambarish Rapte wrote: Hi, Please review t

Re: Review request for 8145284: [Documentation] [TextField] Missing new line character handling

ava.net/%7Earapte/8145284/webrev.01/> I shall raise CCC after technical review. Regards, Ambarish *From:*prasanta sadhukhan *Sent:* Thursday, May 12, 2016 12:44 PM *To:* Ambarish Rapte; Sergey Bylokhov; Semyon Sadetsky; awt-dev@openjdk.java.net *Subject:* Re: Review

Re: Review request for 8145284: [Documentation] [TextField] Missing new line character handling

TextField(String text, int columns) constructor, but with empty string as argument. The comment added is API argument based, Hence these 2 constructors are skipped to add comment. Regards, Ambarish *From:*prasanta sadhukhan *Sent:* Monday, May 16, 2016 8:41 AM *To:* Ambarish Rapte; awt-dev

Re: Review request for 8153184: BorderLayout javadoc says current version of JDK is 1.2

Looks good to me. But the testcase has no bearing to this bug and should be removed and "noreg-doc" label needs to be added to bugreport. Also, a ccc needs to be raised for this. Regards Prasanta *From:*Muneer Kolarkunnu *Sent:* Thursday, May 12, 2016 5:19 PM *To:* awt-dev@openjdk.java.net *Su

Re: Review request for 8153184: BorderLayout javadoc says current version of JDK is 1.2

se[It got added by mistake]. Regards, Muneer *From:*prasanta sadhukhan *Sent:* Tuesday, May 17, 2016 12:24 PM *To:* Muneer Kolarkunnu; awt-dev@openjdk.java.net <mailto:awt-dev@openjdk.java.net> *Subject:* Re: Review request for 8153184: BorderLayout javadoc says current version of JDK

Re: Review request for JDK-8160936: [TEST_BUG] closed/java/awt/Component/ResourceExhaustionTest/ResourceExhaustionTest fails

looks good to me. Regards Prasanta On 8/2/2016 3:51 PM, Ambarish Rapte wrote: Hi, Please review the fix for JDK9, Bug: https://bugs.openjdk.java.net/browse/JDK-8160936 Webrev: http://cr.openjdk.java.net/~arapte/8160936/webrev.00/

Re: Review Request for 8039081: [TEST_BUG] Test java/awt/TrayIcon/PopupMenuLeakTest/PopupMenuLeakTest.java fails

-Original Message- From: Sergey Bylokhov Sent: Monday, December 07, 2015 6:03 PM To: Ambarish Rapte; Semyon Sadetsky; Prasanta Sadhukhan; awt-dev@openjdk.java.net Subject: Re: Review Request for 8039081: [TEST_BUG] Test java/awt/TrayIcon/PopupMenuLeakTest/PopupMenuLeakTest.java fails Hi, Ambarish

Re: Review Request for 8039081: [TEST_BUG] Test java/awt/TrayIcon/PopupMenuLeakTest/PopupMenuLeakTest.java fails

InfoWindow.Balloon(eframe, target, this); so should it not get disposed like balloon? Regards Prasanta The test is updated, http://cr.openjdk.java.net/~arapte/8039081/webrev.03/ Regards, Ambarish -Original Message- From: Prasanta Sadhukhan Sent: Friday

Re: Review Request for 8039081: [TEST_BUG] Test java/awt/TrayIcon/PopupMenuLeakTest/PopupMenuLeakTest.java fails

, Ambarish -Original Message- From: Prasanta Sadhukhan Sent: Friday, August 05, 2016 12:50 PM To: Ambarish Rapte; awt-dev@openjdk.java.net Subject: Re: Review Request for 8039081: [TEST_BUG] Test java/awt/TrayIcon/PopupMenuLeakTest/PopupMenuLeakTest.java fails On 8/5/2016 12

Re: Review Request: JDK-8144735 [hidpi] javax/swing/JWindow/ShapedAndTranslucentWindows/TranslucentPerPixelTranslucentGradient.java fails

I wonder how it compiles? I tried a small program -- public class Test { AccelSurface b = new AccelSurface(); SurfaceData c = (SurfaceData)b; } class SurfaceData extends Surface {} class Surface {} class AccelSurface extends Surface {} - and it fails to com

Re: Review Request : JDK-8168292 [TestBug]Test java/awt/TrayIcon/DragEventSource/DragEventSource.java fails on OS X

Hi Prem, +1 to 8168292 but one thing is that this issue is created to enable to work on 8168291 and was mentioned that the problem DragEventSource fails on osx will be addressed as part of 8168292 which I do not see being done in your webrev. So, either open up 8168291 or fix it in this bug.

Re: Review Request : JDK-8168292 [TestBug]Test java/awt/TrayIcon/DragEventSource/DragEventSource.java fails on OS X

resolves issue both on Linux and OS X platforms . Regards, Prem *From:*Prasanta Sadhukhan *Sent:* Wednesday, October 26, 2016 12:02 PM *To:* Ajit Ghaisas; Prem Balakrishnan; Alexander Scherbatiy; Rajeev Chamyal; awt-dev@openjdk.java.net *Subject:* Re: Review Request : JDK-8168292 [TestBug]Test java

Re: RFR:8168316: Suppress deprecation warnings for Applet classes in java.desktop

Do we need the suppression in JavaSoundAudioClip.java as I could not find any mention of Applet in that class? In AppletViewer.java shouldn't we need to add "deprecation" to 45 @SuppressWarnings("serial") // JDK implementation class Do we still need this 160 @SuppressWarnings("deprecation"

Re: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

Also, in gtk3_interface.c, there is this change for color.alpha 2219 color.alpha = 0; in gtk3_get_color_for_flags() but it is used in gtk3_get_color_for_state() where it is not initialized 2268 GdkRGBA color; Regards Prasanta On 12/1/2016 1:28 AM, Phil Race wrote: Hi Goetz, DataBuffer

Re: Review Request: JDK-8172009 [TEST_BUG] increase timeout in java/awt/print/PaintSetEnabledDeadlock/PaintSetEnabledDeadlock.java

/2017 4:20 PM, Ajit Ghaisas wrote: Change looks fine. Some correction can be done by replacing wildcard imports by specific imports. Regards, Ajit *From:*Prem Balakrishnan *Sent:* Wednesday, January 04, 2017 4:09 PM *To:* Ajit Ghaisas; Prasanta Sadhukhan; awt-dev@openjdk.java.net *Subjec

Re: Review Request: JDK-8172009 [TEST_BUG] increase timeout in java/awt/print/PaintSetEnabledDeadlock/PaintSetEnabledDeadlock.java

ttp://cr.openjdk.java.net/%7Epkbalakr/8172009/webrev.02/> Regards, Prem *From:*Prasanta Sadhukhan *Sent:* Wednesday, January 04, 2017 4:36 PM *To:* Ajit Ghaisas; Prem Balakrishnan; awt-dev@openjdk.java.net *Subject:* Re: Review Request: JDK-8172009 [TEST_BUG] increase timeout in java/awt

Re: RFR: 8170493: JNI exception pending in JavaComponentAccessibility.m:142

looks good to me. Regards Prasanta On 1/14/2017 5:46 AM, Philip Race wrote: silences a hypothetical problem of a NULL return in an out-of-memory situation. This was detected by static analysis, not an actualy observed problem. bug : https://bugs.openjdk.java.net/browse/JDK-8170493 diff : a/src

Re: Review Request : JDK-8175066 Compilation error due to tag in JDK-8162959

ok.+1 Regards Prasanta On 2/16/2017 3:57 PM, Ajit Ghaisas wrote: This fixes the build. I checked on Windows7 x64. Regards, Ajit *From:* Prem Balakrishnan *Sent:* Thursday, February 16, 2017 3:48 PM *To:* Prasanta Sadhukhan; Ajit Ghaisas *Cc:* awt-dev@openjdk.java.net *Subject:* Review

[10] RFR JDK-8177699:Some swing and awt tests are not in TEST.groups

Hi All, Please review a fix for an issue where some tests are not added to TEST.groups. Proposed fix is to add those. Bug: https://bugs.openjdk.java.net/browse/JDK-8177699 webrev: http://cr.openjdk.java.net/~psadhukhan/8177699/webrev.00/ Regards Prasanta

Re: [10] RFR JDK-8177699:Some swing and awt tests are not in TEST.groups

creenMenu/ScreenMenuMemoryLeakTest.java> fails in OSx platfrom. I think better to consider that in this review. Regards, Muneer -Original Message- From: Prasanta Sadhukhan Sent: Monday, June 12, 2017 1:22 PM To: awt-dev@openjdk.java.net Subject: [10] RFR JDK-8177699:Some swing and awt tests are not in

[10] RFR JDK-8088132:[Swing, singleThread] ClassCastException in nested event loop when showing multiple message dialogs in SwingNode

Hi All, Please review this fix http://cr.openjdk.java.net/~psadhukhan/fx/8088132/webrev.00/ for an fx issue https://bugs.openjdk.java.net/browse/JDK-8088132 More info in JBS. Regards Prasanta

Re: [10] RFR JDK-8088132:[Swing, singleThread] ClassCastException in nested event loop when showing multiple message dialogs in SwingNode

Hi Sergey, AFAIK, FX singleThread feature is supported but experimental feature. I have modified webrev to include DefaultKeyboardFocusManager too http://cr.openjdk.java.net/~psadhukhan/fx/8088132/webrev.01/ I do not think there is any problem in skipping code which works with EDT as for exampl

Re: [10] RFR JDK-8088132:[Swing, singleThread] ClassCastException in nested event loop when showing multiple message dialogs in SwingNode

Any feedback on this? Regards Prasanta On 8/16/2017 4:03 PM, Prasanta Sadhukhan wrote: Hi Sergey, AFAIK, FX singleThread feature is supported but experimental feature. I have modified webrev to include DefaultKeyboardFocusManager too http://cr.openjdk.java.net/~psadhukhan/fx/8088132/webrev.01

Re: [10] RFR JDK-8088132:[Swing, singleThread] ClassCastException in nested event loop when showing multiple message dialogs in SwingNode

Prasanta On 8/23/2017 9:31 PM, Sergey Bylokhov wrote: Hi, Prasanta. On 16.08.2017 3:33, Prasanta Sadhukhan wrote: Now, since here FX App thread itself is the dispatch thread, we can be sure the events are dispatched in sequence and dispose is checked below after EDT. Why we can sure about this? If

Re: [10][JDK-8175015] FileSystemView.isDrive(File) memory leak on "C:\" file reference

One thing, if sf.isFileSystem() is true and sf.parent is NULL, then in previous case, it falls through but with this fix, it returns false. Can you clarify? Regards Prasanta On 8/30/2017 11:42 AM, Sergey Bylokhov wrote: Ok, looks fine. - krishna.addepa...@oracle.com wrote: Hi Sergey, I

Re: [10][JDK-8175015] FileSystemView.isDrive(File) memory leak on "C:\" file reference

ok..looks fine. Regards Prasanta On 8/30/2017 2:41 PM, Krishna Addepalli wrote: Hi Prasanta, Even in the previous case, it falls through and returns false. The same behavior is maintained with the current code as well. Thanks, Krishna *From:*Prasanta Sadhukhan *Sent:* Wednesday, August

Re: [10] RFR JDK-8088132:[Swing, singleThread] ClassCastException in nested event loop when showing multiple message dialogs in SwingNode

/8088132/webrev.02/ Regards Prasanta On 8/23/2017 9:31 PM, Sergey Bylokhov wrote: Hi, Prasanta. On 16.08.2017 3:33, Prasanta Sadhukhan wrote: Now, since here FX App thread itself is the dispatch thread, we can be sure the events are dispatched in sequence and dispose is checked below after EDT

Re: [10] RFR JDK-8088132:[Swing, singleThread] ClassCastException in nested event loop when showing multiple message dialogs in SwingNode

op.  - The DefaultKeyboardFocusManager also should check for "javafx.embed.singleThread" Please find modified webrev catering to both comments http://cr.openjdk.java.net/~psadhukhan/8088132/webrev.04/ Regards Prasanta On 9/13/17 03:11, Prasanta Sadhukhan wrote: Hi Sergey, I have modifie

Re: [10] RFR JDK-8088132:[Swing, singleThread] ClassCastException in nested event loop when showing multiple message dialogs in SwingNode

Hi Sergey, Please find modified webrev catering to DefaultKeyboardFocusManager also http://cr.openjdk.java.net/~psadhukhan/8088132/webrev.05/ Regards Prasanta On 9/23/2017 7:52 AM, Sergey Bylokhov wrote: Hi, Prasanta. On 9/19/17 22:26, Prasanta Sadhukhan wrote: Hi, Prasanta.  - In this

Re: [10] Review request for 8183504: 8u131 Win 10, issue with wrong position of Sogou IME popup

Hi Semyon, In windows10 after your fix too, I still find the sogou input appearing at the bottom right corner of the screen, not below text component caret. However  in windows 7, even without your fix, I find the sogou input appearing below text component caret. Regards Prasanta On 10/2/20

Re: [10] Review request for 8183504: 8u131 Win 10, issue with wrong position of Sogou IME popup

/8183504/webrev.01/ On 10/25/2017 12:36 AM, Prasanta Sadhukhan wrote: Hi Semyon, In windows10 after your fix too, I still find the sogou input appearing at the bottom right corner of the screen, not below text component caret. However  in windows 7, even without your fix, I find the sogou input

Re: [10] Review request for 8183504: 8u131 Win 10, issue with wrong position of Sogou IME popup

nt meaning? Regards Prasanta On 10/26/2017 11:10 AM, Prasanta Sadhukhan wrote: Hi Semyon, It now works for windows10 but regress in windows 7 for me, where no Sogou input window appears below text component. Regards Prasanta On 10/26/2017 4:52 AM, Semyon Sadetsky wrote: Hi Prasanta, Ple

Re: [10] Review request for 8183504: 8u131 Win 10, issue with wrong position of Sogou IME popup

://cr.openjdk.java.net/~ssadetsky/8183504/webrev.02/ --Semyon On 10/26/2017 12:52 AM, Prasanta Sadhukhan wrote: Hi All, A related issue, as per https://docs.oracle.com/javase/8/docs/technotes/guides/imf/spec.html#InputStyles we support 3 styles, /On-the-spot, ///Below-the-spot and /Root-window

Re: [10] RFR JDK-8190456: sanity/client/SwingSet/src/ComboBoxDemoTest.java failed with NPE from java.awt.EventQueue.getCurrentEventImpl()

Hi Muneer, Earlier, before your fix, if Thread.currentThread() is not equal to  dispatchThread, then it was returning " null", but now it will not return anything even though return value should be AWTEvent. Is it not giving any compilation problem? Regards Prasanta On 11/1/2017 2:03 PM, Mune

Re: RFR: 8185739: Memory leak in BitmapUtil::BitmapToRgn

Hi Phil, Since you are checking for buf value in line248 and doing cleanup, shouldn't we do the same in line322 also in BlendCopy()? Regards Prasanta On 11/7/2017 1:31 AM, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8185739 Webrev: http://cr.openjdk.java.net/~prr/8185739/

Re: RFR: 8185739: Memory leak in BitmapUtil::BitmapToRgn

+1 Regards Prasanta On 11/8/2017 3:44 AM, Phil Race wrote: Might as well .. http://cr.openjdk.java.net/~prr/8185739.1 -phil. On 11/06/2017 11:58 PM, Prasanta Sadhukhan wrote: Hi Phil, Since you are checking for buf value in line248 and doing cleanup, shouldn't we do the same in li

Re: [10] RFR JDK-8190456: sanity/client/SwingSet/src/ComboBoxDemoTest.java failed with NPE from java.awt.EventQueue.getCurrentEventImpl()

sanity tests for 1000 iterations on SBR and passed all tests without any new issues. Regards, Muneer *From:*Prasanta Sadhukhan *Sent:* Friday, November 03, 2017 11:49 AM *To:* Muneer Kolarkunnu; awt-dev@openjdk.java.net *Subject:* Re: [10] RFR JDK-8190456: sanity/client/SwingS

Re: [10] Review Request: 8183518 Premature deprecation of Event/InputEvent/KeyEvent in Java 9

Hi Sergey, Don't we need to remove @SuppressWarnings("deprecation") from BasicComboPopup and BasicGraphicsUtils? Regards Prasanta On 11/22/2017 4:16 AM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk10. Bug: https://bugs.openjdk.java.net/browse/JDK-8183518 Webrev can be found at

Re: [10] Review Request: 8183518 Premature deprecation of Event/InputEvent/KeyEvent in Java 9

looks good to me. I guess, bugid can be added to test. Regards Prasanta On 11/22/2017 9:57 PM, Sergey Bylokhov wrote: Thank you for review. Yes, it can be removed: http://cr.openjdk.java.net/~serb/8183518/webrev.01 On 22/11/2017 03:09, Prasanta Sadhukhan wrote: Hi Sergey, Don't we ne

Re: [8u] RFR: JDK8U Backport of 8183504: 8u131 Win 10, issue with wrong position of Sogou IME popup

You need to set "cfr" here 3877 cf.rcArea.left = cf.rcArea.top = cf.rcArea.right = cf.rcArea.bottom = 0; Regards Prasanta On 11/27/2017 2:56 PM, Sreeprakash Sreedharan wrote: Hi, Please review this webrev for JDK-8u backport. Webrev: http://cr.openjdk.java.net/~ssreedharan/8183504/jdk8u-d

Re: [8u] RFR: JDK8U Backport of 8183504: 8u131 Win 10, issue with wrong position of Sogou IME popup

504/jdk8u-dev/webrev.01/> Regards, Sreeprakash *From:*Prasanta Sadhukhan *Sent:* Monday, November 27, 2017 4:09 PM *To:* Sreeprakash Sreedharan ; Semyon Sadetsky *Cc:* awt-dev@openjdk.java.net *Subject:* Re: [8u] RFR: JDK8U Backport of 8183504: 8u131 Win 10, issue with wrong position of Sog

Re: [10] Review Request: 8193012 Small cleanup of AWTEvent class

+1 Regards Prasanta On 12/5/2017 3:29 AM, Sergey Bylokhov wrote: Hello. Please review small cleanup for jdk10. Bug: https://bugs.openjdk.java.net/browse/JDK-8193012 Webrev can be found at: http://cr.openjdk.java.net/~serb/8193012/webrev.00 The fix for JDK-8129854[1] missed some fields in AW

Re: RFR: 8193211 : Update jtreg TEST.groups and ProblemList for client-libs

+1 Regards Prasanta On 12/8/2017 1:15 AM, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8193211 Webrev: http://cr.openjdk.java.net/~prr/8193211/ adds jdk_swing_core and jdk_desktop_core test groups to jtreg Also problem lists many (by no means all) of the known jtreg failures.

Re: [11] Review Request: JDK-8196441 java/awt/Modal/ToBack/*.java tests fail

Hi Prem, I still see java/awt/Modal/ToBack/ToBackAppModal1Test.java (1st test in the list) fails in ubuntu16.04. Did you run all the tests listed there in JBS? Regards Prasanta On 2/16/2018 11:27 AM, Prem Balakrishnan wrote: Hi All, Please review the following fix for JDK 11 : Bug: https:

Re: [11] Review Request JDK-8198347 [TESTBUG] java/awt/Modal/ToBack/*.java tests fail on Ubuntu 17.10

Hi Prem, None of this tests fail for me in my ubuntu17.10 even without your fix. If I run the toBack folder, I only see the tests mentioned in JDK-8196441 to be failing. Maybe you can run in some other 17.10 system. Regards Prasanta On 2/19/2018 11:33 AM, Prem Balakrishnan wrote: Hi All, P

Re: [OpenJDK 2D-Dev] [11] Review Request: 8198333 ProblemList should be updated for headless mode

Couple of points. Shouldn't java/awt/List/SetBackgroundTest/SetBackgroundTest.java be run only on solaris/linux as it tests if (!isXAWT){ 77 System.out.println(" this is XAWT-only test. "); 78 return; 79 } java/awt/Toolkit/RealSync/Test.java has System.ex

Re: [OpenJDK 2D-Dev] [11] Review Request: 8198333 ProblemList should be updated for headless mode

als("linux")) { 44 System.out.println("Linux specific test. No need to continue"); 45 return; 46 } Regards Prasanta On 2/21/2018 7:28 PM, Prasanta Sadhukhan wrote: Couple of points. Shouldn't java/awt/List/SetBackgroundTest/SetBackgroundTest.java

Re: [OpenJDK 2D-Dev] [11] Review Request: 8198333 ProblemList should be updated for headless mode

ded in the headless mode, which is subject of the fix. Regards Prasanta On 2/21/2018 7:28 PM, Prasanta Sadhukhan wrote: Couple of points. Shouldn't java/awt/List/SetBackgroundTest/SetBackgroundTest.java be run only on solaris/linux as it tests if (!isXAWT){   77 System.out.pr

Re: [AWT Dev] [11] RFR JDK-8197926: java/awt/dnd/ImageTransferTest/ImageTransferTest.java doesnt close the windows in HiDPI setting

+1 Regards Prasanta On 2/22/2018 1:49 AM, Sergey Bylokhov wrote: Then it look fine, Thank you for clarification. On 21/02/2018 10:28, Jayathirth D V wrote: Hi Sergey, Thanks for your inputs. In all the cases where Robot is working properly we expect all dnd operations to be finished within

[11] RFR JDK-8198693:Update ProblemsList for mac

Hi All, Please review the problem list updation for mac to weed out the test that are failing at least once in few iterations. I tested on mac 10.13.3. With this problem list, the test failures and errors are nearly zero apart from 2-3 tests that are failing intermittently. Bug: https://bugs.

Re: [11] Review Request: 8199022 New failures should be added to ProblemList

Hi Sergey, Looks ok to me. Could you also please add these tests to the list as well java/awt/image/VolatileImage/CustomCompositeTest.java 8199002 windows-all, linux-all java/awt/image/VolatileImage/GradientPaints.java 8199003 linux-all java/awt/JAWT/JAWT.sh   windows-all Regards Prasanta On

Re: [11] Review Request: 8199022 New failures should be added to ProblemList

JDK-8197798 <https://bugs.openjdk.java.net/browse/JDK-8197798> On 3/7/2018 7:25 PM, Sergey Bylokhov wrote: Hi, Prasanta. What bugid for java/awt/JAWT/JAWT.sh ? On 07/03/2018 00:21, Prasanta Sadhukhan wrote: Hi Sergey, Looks ok to me. Could you also please add these tests to the l

Re: [11] Review Request: 8199022 New failures should be added to ProblemList

+1 Regards Prasanta On 3/8/2018 12:38 AM, Sergey Bylokhov wrote: The patch is updated: http://cr.openjdk.java.net/~serb/8199022/webrev.01 On 07/03/2018 05:57, Prasanta Sadhukhan wrote: JDK-8197798 <https://bugs.openjdk.java.net/browse/JDK-8197798> On 3/7/2018 7:25 PM, Sergey Bylokhov

Re: RFR: 8198649 : Switch AWT/Swing's default GTK version to 3

+1 Regards Prasanta On 3/16/2018 11:04 PM, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8198649 Webrev: http://cr.openjdk.java.net/~prr/8198649/ This is a very small change to switch the default GTK library loaded from GTK 2.2 to GTK 3. Both are supported as of JDK 9 but it s

Re: [11] Review request for JDK-8204859: [macosx] Remove javax/swing/plaf/nimbus/8057791/bug8057791.java from the ProblemList.txt

+1 Regards Prasanta On 6/12/2018 5:53 PM, Manajit Halder wrote: Hi All, Kindly review the fix for JDK11. Bug: https://bugs.openjdk.java.net/browse/JDK-8204859 Webrev: http://cr.openjdk.java.net/~mhalder/8204859/webrev.00/ Changes:

Re: [11] Review request for JDK-8204860: The frame could be resized by dragging a corner of the frame with the mouse

Also, I guess JFrame handling should be in EDT. Regards Prasanta On 7/9/2018 6:14 PM, Sergey Bylokhov wrote: Hi, Manajit. Did you run the test on other platforms? I am not sure, but look like the line below can throw npe: if(!prop1.equals(prop2)) { On 06/07/2018 16:37, Manajit Halder wrote: Hi

Re: [11] Review request for JDK-8204860: The frame could be resized by dragging a corner of the frame with the mouse

webrev: http://cr.openjdk.java.net/~mhalder/8204860/webrev.06/ <http://cr.openjdk.java.net/%7Emhalder/8204860/webrev.06/> Regards, Manajit On 09-Jul-2018, at 6:33 PM, Prasanta Sadhukhan <mailto:prasanta.sadhuk...@oracle.com>> wrote: Also, I guess JFrame handling should be i

Re: RFR [XS] : 8207941 : javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java fails on machines without Arial font [testbug]

Looks good to me. BTW, did you test on latest ubuntu and solaris? Please add the bugid to the test. Regards Prasanta On 7/20/2018 1:21 PM, Baesken, Matthias wrote: Hello,  the test javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java does not work on some of our  Linux and AIX

Re: [12] JDK-8182043: Access to Windows Large Icons

Hi Shashi, The previous review thread is too long so probably need the original reviewer to take a look. But here are my 2 cents * Can you please explain how the new API is supposed to be used? It says "Scaled icon for a file, directory, or folder as it would be displayed ina system fil

Re: [11] Review request for JDK-8208394: [macosx] test java/awt/Frame/UnfocusableMaximizedFrameResizablity/UnfocusableMaximizedFrameResizablity.java compilation fail

+1 On 7/27/2018 5:36 PM, Manajit Halder wrote: Hi All, Kindly review the fix for JDK11. Bug: https://bugs.openjdk.java.net/browse/JDK-8208394 Webrev: http://cr.openjdk.java.net/~mhalder/8208394/webrev.00/ Regards, Manajit

Re: Subject: [11] Review request for JDK-8208125: Cannot input text into JOptionPane Text Input Dialog

looks fine. Regards Prasanta On 8/9/2018 2:51 AM, Philip Race wrote: +1 -phil. On 8/8/18, 5:56 AM, Manajit Halder wrote: Hi Phil, Thanks for your review comment. Reverted the code optimization and test code as per the suggestion. Now the code change is same as the changeset e0b025915be8.

Re: [12] Review request for JDK-8208743: JDialog with JTextArea can't accept focus when setResizable(false) called

Hi Manajit, Although it looks good, but I guess having JBS issue to just create a testcase may not be right. My take is close this as duplicate of 8208125 and add this testcase when you fix 8209123 Regards Prasanta On 8/16/2018 5:11 PM, Mana

Re: [12] Review Request: 8209340 The code which avoids synthetic accessors has become outdated

+1 Regards Prasanta On 8/20/2018 12:20 PM, Krishna Addepalli wrote: Hi Sergey, Thanks for providing the test code. Now I understand why the constructors were explicitly written. After some discussions here, I understood that the "Compiler generated default constructor has the same access as t

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

One thing, since you are passing va_list as the last parameter, shouldn't all fprintf be actually vfprintf? Regards Prasanta On 14-Sep-18 12:55 AM, Krishna Addepalli wrote: Hi All, Enhancement: https://bugs.openjdk.java.net/browse/JDK-8196681 Webrev: http://cr.openjdk.java.net/~kaddepalli/81

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

the calls to vfprintf. Here is the new webrev: http://cr.openjdk.java.net/~kaddepalli/8196681/webrev01/ <http://cr.openjdk.java.net/%7Ekaddepalli/8196681/webrev01/> Krishna *From:*Prasanta Sadhukhan *Sent:* Friday, September 14, 2018 11:38 AM *To:* Krishna Addepalli ; a

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

ttp://cr.openjdk.java.net/%7Ekaddepalli/8196681/webrev02/> --Krishna *From:*Prasanta Sadhukhan *Sent:* Friday, September 14, 2018 3:23 PM *To:* Krishna Addepalli ; awt-dev@openjdk.java.net *Subject:* Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled o

Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

them as is. Thanks, Krishna *From:*Prasanta Sadhukhan *Sent:* Friday, September 14, 2018 5:48 PM *To:* Krishna Addepalli ; awt-dev@openjdk.java.net *Subject:* Re: RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled one question: why nullptr is used? I see

[12] RFR JDK-8191178:[macos] Problem with input of yen symbol

Hi All, Please review a fix for an issue where when "yen" symbol is entered from a keyboard using Romaji keyboard layout using "backslash" character, it was showing a "backslash" character rather than "yen" symbol. This is a regression of JDK-8068283

Re: [12] RFR JDK-8191178:[macos] Problem with input of yen symbol

idth currency symbols’, as well. Thanks, Dmitry On 17 Sep 2018, at 10:02, Prasanta Sadhukhan <mailto:prasanta.sadhuk...@oracle.com>> wrote: Hi All, Please review a fix for an issue where when "yen" symbol is entered from a keyboard using Romaji keyboard layout using

[12] RFR JDK-8210306:Missing closing bracket in GridBagLayout gridwidth, gridheight description

Hi All, Please review a doc fix for a missing closing bracket in GridBagLayout description /Use //|GridBagConstraints.RELATIVE|//to specify that the component's display area will be from //|gridx|//to the next to the last cell in its row *(for */*/|gridwidth|/*/** or from //|gridy|/// diff

Re: [12] JDK-8061359: [macosx] Checkbox toggles on Space press but does not spoken by Voice Over

Please add a between if and ( before pushing. Just one more thing, you have done for checkbox, should n't we need to do for AccessibleRole.RADIO_BUTTON? Regards Prasanta On 10-Oct-18 4:27 PM, Manajit Halder wrote: Looks good me. Regards, Manajit On 09/10/18 9:50 AM, Shashidhara Veerabhadr

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8213130: Update ProblemList after verification of jtreg tests in Win 7

looks ok. Regards Prasanta On 30-Oct-18 2:13 PM, Jayathirth D V wrote: Hello All, Please review the following fix in JDK 12: Bug : https://bugs.openjdk.java.net/browse/JDK-8213130 Webrev : http://cr.openjdk.java.net/~jdv/8213130/webrev.00/

[12] RFR JDK-8213138: Update ProblemList.txt for mac

Hi All, Please review an updation of ProblemList for mac jtreg run. Following tests were added in ProblemList. With this addition, mac10.13 jtreg run shows no failures/errors. java/awt/Window/MainKeyWindowTest/TestMainKeyWindow.java: JDK-8213126

Re: [12] RFR JDK-8213138: Update ProblemList.txt for mac

On 31-Oct-18 4:27 AM, Sergey Bylokhov wrote: Hi, Prasanta. On 30/10/2018 02:58, Prasanta Sadhukhan wrote: java/awt/Window/MainKeyWindowTest/TestMainKeyWindow.java: JDK-8213126 <https://bugs.openjdk.java.net/browse/JDK-8213126> The failure of the TestMainKeyWindow.java is not a bug, you

[12] RFR JDK-8198334: java/awt/FileDialog/8003399/bug8003399.java fails in headless mode

Hi All, Please review a fix for an issue where some tests are found to be failing with HeadlessException in mach5 systems. Proposed fix is to mark those tests as headful. Bug: https://bugs.openjdk.java.net/browse/JDK-8198334 webrev: http://cr.openjdk.java.net/~psadhukhan/8198334/webrev.0/ Reg

Re: [12] Review request for JDK-8209123: [Macosx] Maximized frame is resizable on Mac but not on Windows and Ubuntu

Hi Manajit, I see in SwingSet2's InternalFrames Demo, when we create a new Frame with resizable and maximizable set and I maximize the window, then I am not able to resize the frame even without your fix. I thought it will allow me to resize without your fix, which is the bug you are trying to

Re: [12] Review request for JDK-8209123: [Macosx] Maximized frame is resizable on Mac but not on Windows and Ubuntu

maximizable and it is allowing me to resize even though it is maximised. Regards Prasanta On 22-Nov-18 6:05 PM, Manajit Halder wrote: Hi Prasanta, Please find my answer inline to your comments: Regards, Manajit On 22-Nov-2018, at 12:03 PM, Prasanta Sadhukhan <mailto:prasanta.sadhuk...@oracle.

Re: [12] Review request for JDK-8209123: [Macosx] Maximized frame is resizable on Mac but not on Windows and Ubuntu

also I think there is no need to create a separate issue as the behaviours are system defined in Mac and as expected. Regards, Manajit On 23-Nov-2018, at 11:24 AM, Prasanta Sadhukhan <mailto:prasanta.sadhuk...@oracle.com>> wrote: I see. Can you tell me if you saw this problem in a

Re: [12]RFR: JDK-8215921: There is no change when select different Foreground and Background by mouse.

Hi Krishna, Fix looks ok..In testcase, I guess you do not need import javax.management.RuntimeErrorException; and also the formatting of try-catch block of run() method needs to be corrected. Also, I do not think you need to call Robot.setAutoDelay() multiple times, it's one-time setting and i

Re: [12]RFR: JDK-8215921: There is no change when select different Foreground and Background by mouse.

/8215921/webrev05 <http://cr.openjdk.java.net/%7Ekaddepalli/8215921/webrev05> Thanks, Krishna On 29-Jan-2019, at 2:05 PM, Prasanta Sadhukhan <mailto:prasanta.sadhuk...@oracle.com>> wrote: Hi Krishna, Fix looks ok..In testcase, I guess you do not need import javax.management.Runtim

[13] RFR JDK-8217464: Remove resolved client bugs from the ProblemList.txt

Hi All, Please review an updation of ProblemList to remove/update resolved client bugs from ProblemList Bug: https://bugs.openjdk.java.net/browse/JDK-8217464 webrev: http://cr.openjdk.java.net/~psadhukhan/8217464/webrev.0/ Few test are closed as duplicate of other bug so the ProblemList is u

Re: [13] Review request for JDK-8207938: At step6, Click Add button, case failed automatically.

Hi Manajit, I see that IconObserver object is used in updateNativeImage() 209 CImage cimage = CImage.getCreator().createFromImage(image, observer); 210 boolean imageAutoSize = target.isImageAutoSize(); If there is an invalid tray icon target, then wouldn't it cause NPE @210 also? 211 cimage.exe

  1   2   3   4   >