Ted Gould has proposed merging lp:~ted/indicator-appmenu/dont-save-accel into
lp:indicator-appmenu.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Okay, this is the matched entry to:
lp:~ted/dbusmenu/accel-ref
Basically the ref was handled wrong, but both
Ted Gould has proposed merging
lp:~ted/indicator-appmenu/i-pity-the-fool-with-an-edit-menu into
lp:indicator-appmenu.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
This removes the edit menu at the request of mpt.
--
https://code.launchpad.net/~ted/indicator
Ted Gould has proposed merging lp:~ted/indicator-appmenu/remove-chrome-now into
lp:indicator-appmenu.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Removing Chrome from the blacklist
--
https://code.launchpad.net/~ted/indicator-appmenu/remove-chrome-now/+merge
Review: Approve
--
https://code.launchpad.net/~bratsche/appmenu-gtk/watch-gtkaction-sensitivity-change/+merge/36487
Your team ayatana-commits is subscribed to branch lp:appmenu-gtk.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to
Ted Gould has proposed merging lp:~ted/dbusmenu/typedef-removal into
lp:dbusmenu.
Requested reviews:
DBus Menu Team (dbusmenu-team)
Removes the typedef in the class structure as it seems to make vapigen unhappy.
--
https://code.launchpad.net/~ted/dbusmenu/typedef-removal/+merge/36314
Your
Ted Gould has proposed merging lp:~ted/indicator-application/lib-deps-fixes
into lp:indicator-application.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Creates a separate package config line for the library which removes the extra
deps, most notably
Review: Approve
--
https://code.launchpad.net/~indicator-applet-developers/indicator-appmenu/one-more-xerror-fix/+merge/36149
Your team ayatana-commits is subscribed to branch lp:indicator-appmenu.
___
Mailing list:
On Mon, 2010-09-20 at 15:51 +, David Barth wrote:
What's the rational for not sending activate signals if there are no submenus?
Basically because GTK doesn't separate between about to show and
activate. So it seems that some people (Shotwell) are using the
activate signal as about-to-show,
On Tue, 2010-09-21 at 09:54 +, David Barth wrote:
A bug in bamf, or simply a timing issue where events are not
delivered in the expected order.
I don't think it actually happens, but Jason was concerned about it
after reviewing the code. No reason not to be safe.
--
Review: Approve
Probably should drop some of teh debugging messages out of
finalized_dbusmenuitem_cb but otherwise it looks good.
--
https://code.launchpad.net/~dbarth/indicator-me/hint-fixes/+merge/36170
Your team ayatana-commits is subscribed to branch lp:indicator-me.
Ted Gould has proposed merging lp:~ted/indicator-appmenu/mnemonic-fix into
lp:indicator-appmenu.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Fixes the issue where all the underscores show up from KDE apps. Annoying as
hell.
--
https://code.launchpad.net
Ted Gould has proposed merging lp:~ted/indicator-appmenu/bamf-window-refs into
lp:indicator-appmenu.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Jason was concerned that we needed to keep a ref to the window just incase it
got destroyed. Now, I can't come
Ted Gould has proposed merging
lp:~ted/indicator-appmenu/better-dbus-error-handling into lp:indicator-appmenu.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
I occationally get a crash on startup with indicator-applet-appmenu where it is
deep in dbus at startup
Ted Gould has proposed merging
lp:~ted/indicator-appmenu/indicator-about-to-show into lp:indicator-appmenu.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Makes it so that we pass the about to show signal down into the menuitem
--
https://code.launchpad.net
Ted Gould has proposed merging lp:~ted/dbusmenu/about-to-show-is-activate into
lp:dbusmenu.
Requested reviews:
DBus Menu Team (dbusmenu-team)
Making it so that we pass about-to-show up to menu items with children as
activate
--
https://code.launchpad.net/~ted/dbusmenu/about-to-show
Review: Needs Information
A few concerns.
* This patch adds several translatable strings. So I don't think it can land
for Maverick.
* And this comment:
179 + /* this is dangerous: it leaves the signal connected even if the
dbusmenu
180 + object is disposed, for example if the
Ted Gould has proposed merging lp:~ted/dbusmenu/hashtable_free into lp:dbusmenu.
Requested reviews:
DBus Menu Team (dbusmenu-team)
Freeing the hashtable used to serialize the menu item.
--
https://code.launchpad.net/~ted/dbusmenu/hashtable_free/+merge/35540
Your team ayatana-commits
Ted Gould has proposed merging lp:~ted/indicator-appmenu/menu-show-signals into
lp:indicator-appmenu.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Passes up the signal to show the menus so that Unity can pick it up.
Unfortunately, I can't really test
Review: Approve
--
https://code.launchpad.net/~cjcurran/indicator-sound/missing-nonmono-icon/+merge/35302
Your team ayatana-commits is subscribed to branch lp:indicator-sound.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to :
Review: Needs Information
BAMF doesn't export it's full version into the pkgconfig file... so we
can't really check the version in the configure file. So, I think we
either should fix BAMF or not merge something that implies that we can
check it.
review needsinfo
--
Review: Approve
review approve
--
https://code.launchpad.net/~dbarth/indicator-me/clean-checkmarks/+merge/35061
Your team ayatana-commits is subscribed to branch lp:indicator-me.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to
Review: Approve
--
https://code.launchpad.net/~bratsche/appmenu-gtk/toplevel-destroyed-fix/+merge/35017
Your team ayatana-commits is subscribed to branch lp:appmenu-gtk.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to :
Review: Approve
--
https://code.launchpad.net/~bratsche/appmenu-gtk/five-is-a-crowd/+merge/34918
Your team ayatana-commits is subscribed to branch lp:appmenu-gtk.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to :
Review: Approve
Probably should change /XX to be something that someone can find if they
look at the filesystem. I'd suggest /downloaded-coverart-XX. This way
if someone looks at the directory they'll know what the files are. Otherwise,
I'm happy :)
--
Ted Gould has proposed merging lp:~ted/indicator-appmenu/dialogs-as-desktop
into lp:indicator-appmenu.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Disables user_visible which doesn't really do what we want. It tracks things
in the task list, which excludes
On Fri, 2010-09-03 at 22:00 +0530, Owais Lone wrote:
I just realized that the messaging indicator no longer shows arrows to
depict running apps.
Was this intentional? Why?
It's a bug, we're working on it. Sorry.
--Ted
signature.asc
Description: This is a digitally signed
Ted Gould has proposed merging
lp:~ted/indicator-appmenu/working-close-menu-item into lp:indicator-appmenu
with lp:~ted/indicator-appmenu/desktop-menu-handling as a prerequisite.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Have the close menu work
Ted Gould has proposed merging lp:~ted/libindicate/rb-crash into lp:libindicate.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Unreferences the proxy object on dispose so that we don't get any more signals
from it.
--
https://code.launchpad.net/~ted
Ted Gould has proposed merging lp:~ted/indicator-messages/triangle-fix into
lp:indicator-messages.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
The triangle display callback wasn't getting the dbusmenu menuitem in its
callback, so was exiting early. Now
Forgot to commit :) Fixed in r369.
--
https://code.launchpad.net/~ted/indicator-applet/an-extra-pixel/+merge/33913
Your team ayatana-commits is subscribed to branch lp:indicator-applet.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to
Fixed in r72.
--
https://code.launchpad.net/~ted/indicator-appmenu/desktop-menu-handling/+merge/34491
Your team ayatana-commits is subscribed to branch lp:indicator-appmenu.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to :
Review: Needs Fixing
* The temporary file needs to be built with mkstemp to create a random
directory for the artwork.
* It should be in the XDG temp directory instead of hardcoded to /tmp
* You can use g_file_is_native() to determine whether it's local or not, just
incase they're using
Ted Gould has proposed merging lp:~ted/indicator-session/bug611257 into
lp:indicator-session.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Related bugs:
#611257 indicator-session-service crashed with signal 5 in
g_type_create_instance()
https
Merged in trunk and solved conflicts in r31
--
https://code.launchpad.net/~ted/indicator-datetime/date-and-update/+merge/34152
Your team ayatana-commits is subscribed to branch lp:indicator-datetime.
___
Mailing list:
Ted Gould has proposed merging lp:~ted/dbusmenu/event-status-signal into
lp:dbusmenu.
Requested reviews:
DBus Menu Team (dbusmenu-team)
Fixes the event status signal, builds a test for it, and adjusts the timeout to
make it more responsive.
--
https://code.launchpad.net/~ted/dbusmenu/event
Review: Approve
Seems fine, sad to loose even more relative sizing of the arrows moving to
fixed pixel sizes.
--
https://code.launchpad.net/~dbarth/indicator-messages/triangle-n-icon/+merge/33828
Your team ayatana-commits is subscribed to branch lp:indicator-messages.
Review: Approve
--
https://code.launchpad.net/~bratsche/appmenu-gtk/activate-remote-menus/+merge/33836
Your team ayatana-commits is subscribed to branch lp:appmenu-gtk.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to :
Review: Approve
--
https://code.launchpad.net/~mpt/indicator-me/icon-fixes/+merge/33678
Your team ayatana-commits is subscribed to branch lp:indicator-me.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to :
Review: Approve
--
https://code.launchpad.net/~cjcurran/indicator-sound/fix-rounded-corners-on-album-art/+merge/33686
Your team ayatana-commits is subscribed to branch lp:indicator-sound.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post
On Mon, 2010-08-23 at 07:39 +, Aurélien Gâteau wrote:
I wanted to try it on KDE, but it seems the menubar items (File,
Edit, View) do not contain any '_' character. Is it a known
problem?
The fact that you can't see them visually, yes, it's part of a GTK thing
where we're supposed to
On Mon, 2010-08-23 at 10:34 +, David Barth wrote:
Review: Needs Fixing
Line 125: a bit uneasy to see priv dereferenced without being controlled
first; is the GET_PRIVATE macro ensuring you will return immediately if
passed some garbage/null pointer? Being a callback, it makes sense to be
Ted Gould has proposed merging lp:~ted/dbusmenu/bigger-max-xml into lp:dbusmenu.
Requested reviews:
Neil J. Patel (njpatel)
Increase the max number of characters the XML string can be. GIMP is crazy.
--
https://code.launchpad.net/~ted/dbusmenu/bigger-max-xml/+merge/33219
Your team ayatana
Ted Gould has proposed merging
lp:~ted/indicator-application/ordering-for-keyboard-stuff into
lp:indicator-application.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Adding the keyboard stuff to the overrides.
--
https://code.launchpad.net/~ted/indicator
Ted Gould has proposed merging
lp:~ted/indicator-application/icon-label-updates-wrong into
lp:indicator-application.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Not using the get_position everywhere, so things were getting out of position.
--
https
Ted Gould has proposed merging lp:~ted/dbusmenu/show-menu-on-activate into
lp:dbusmenu.
Requested reviews:
DBus Menu Team (dbusmenu-team)
Opening menus when requested. Originally I thought we'd be able to use
activate, but that created a nice little signal loop -- oops. Added a new
Ted Gould has proposed merging lp:~ted/indicator-application/approver-rejudge
into lp:indicator-application.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Allow for rejudging.
--
https://code.launchpad.net/~ted/indicator-application/approver-rejudge/+merge
Ted Gould has proposed merging lp:~ted/indicator-applet/blacklist-datetime into
lp:indicator-applet.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Remove indicator-datetime from indicator-applet
--
https://code.launchpad.net/~ted/indicator-applet/blacklist
I don't think that's the case because show_local by default is set to FALSE.
So the local menu will still not be shown until the signal gets back from DBus.
It just means that the connection to the registrar would be slightly delayed
when it has something to connect with. But, when running
The approver is only used so that Unity can choose to put some of the
application indicators into the Unity launcher. We needed some way to know
which ones Unity was stealing. So the workflow is that the applications will
register like normal and there is a possible approver there. The
Ted Gould has proposed merging lp:~ted/dbusmenu/fixing-qt-layout into
lp:dbusmenu.
Requested reviews:
DBus Menu Team (dbusmenu-team)
Fixing the layouts coming from Qt
--
https://code.launchpad.net/~ted/dbusmenu/fixing-qt-layout/+merge/32777
Your team ayatana-commits is subscribed to branch
Ted Gould has proposed merging
lp:~ted/indicator-application/approver-actually-approve into
lp:indicator-application.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Making the approvers actually approve entries.
NOTE: This makes it so that all your application
Ted Gould has proposed merging lp:~ted/appmenu-gtk/ask-dbus into lp:appmenu-gtk.
Requested reviews:
Canonical Desktop Experience Team (canonical-dx-team)
Changes the order of operation slightly so that we're only asking Dbus for the
name once in an async way. This seems to help in cases
On Wed, 2010-08-11 at 22:54 -0400, Ken VanDine wrote:
* Should notifications be handled by empathy or telepathy-indicator?
- If empathy isn't running, but you are logged on with
mission-control-5, you will get indicators for new chats but no
notifications. Perhaps we should
Ted Gould has proposed merging
lp:~ted/indicator-application/damn-missed-codys-review into
lp:indicator-application.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
I missed Cody's review of the last branch, and this is the memory leak that he
found.
--
https
Review: Approve
I'm not sure I understand this, but I can't find any coding errors :)
--
https://code.launchpad.net/~bratsche/appmenu-gtk/performance-improvements/+merge/32586
Your team ayatana-commits is subscribed to branch lp:appmenu-gtk.
___
Review: Approve
--
https://code.launchpad.net/~bratsche/appmenu-gtk/correct-key-value-pair/+merge/32468
Your team ayatana-commits is subscribed to branch lp:appmenu-gtk.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to :
Review: Approve
The code seems okay. I'm a bit worried that it seems we're choosing mpris 1
vs. 2 by a lookup table. It seems we should be able to see which interface
that the music player is exporting and choose the best one there.
--
Ted Gould has proposed merging lp:~ted/indicator-application/x-label-branch
into lp:indicator-application.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Moving the label attributes to the X namespace as the KDE folks aren't
interested in it. Hopefully they'll
On Tue, 2010-08-10 at 15:16 +0100, Matthew Paul Thomas wrote:
Mohammed Amine IL Idrissi wrote on 07/08/10 22:32:
3. If the answer is yes, can I program it in Python? I noticed the
indicator is coded in C, and I mainly code in Python/PyGTK.
...
The menu is in C for speed. You're welcome to
On Tue, 2010-08-10 at 17:56 -0400, Martin Owens wrote:
On Tue, 2010-08-10 at 14:27 -0500, Ted Gould wrote:
Just an FYI, the GSettings keys already exist[1] and the menu already
installs them. Just the only way to set them is with the editor. A
GUI
could simply set those keys
The proposal to merge lp:~ted/indicator-application/label-in-the-lib into
lp:indicator-application has been updated.
Status: Needs review = Superseded
--
https://code.launchpad.net/~ted/indicator-application/label-in-the-lib/+merge/31886
Your team ayatana-commits is subscribed to branch
Ted Gould has proposed merging lp:~ted/indicator-session/lock-screen-sanity
into lp:indicator-session.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
This changes the behavior of the menu item to always be Lock Screen and lock
the screen. While the other areas
Ted Gould has proposed merging
lp:~ted/indicator-application/labels-in-the-indicator into
lp:indicator-application with lp:~ted/indicator-application/label-in-the-lib as
a prerequisite.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Adding label support
Just an FYI, distcheck failed because the new symbols weren't added into the
documentation list. No biggie, I fixed it. Thanks again for the work!
--
https://code.launchpad.net/~sense/indicator-application/runtime-themepath-change/+merge/31842
Your team ayatana-commits is subscribed to branch
Review: Approve
review approve
--
https://code.launchpad.net/~agateau/dbusmenu/misc-tool-fixes/+merge/31869
Your team ayatana-commits is subscribed to branch lp:dbusmenu.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to :
Ted Gould has proposed merging lp:~ted/indicator-application/abi-break into
lp:indicator-application with lp:~ted/indicator-application/label-in-the-lib as
a prerequisite.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Breaking the ABI, we ran out of pointers
Review: Approve
On Wed, 2010-08-04 at 11:38 +, Conor Curran wrote:
+}*/
+
In general, I'd avoid commenting out code. It doesn't get tested by the
complier, and can be found easily enough using version control. Axe
early and axe often :)
+static gboolean
What do you guys think about changing the signal to include the path in it,
that's save a DBus call. From:
+ signal name=NewIconThemePath
+ /signal
To:
signal name=NewIconThemePath
arg type=s name=icon_theme_path direction=out /
/signal
The others don't have
On Mon, 2010-08-02 at 15:33 +, Cody Russell wrote:
-app_menu_bridge_set_show_local (context-bridge, TRUE);
+{
+ if (context-bridge != NULL
+{
+ app_menu_bridge_set_show_local (context-bridge, TRUE);
+}
+}
I think
Ted Gould has proposed merging lp:~ted/dbusmenu/glob-property-requests into
lp:dbusmenu.
Requested reviews:
DBus Menu Team (dbusmenu-team)
This branch makes it so that property requests are pulled into a single larger
request.
--
https://code.launchpad.net/~ted/dbusmenu/glob-property
Ted Gould has proposed merging lp:~ted/dbusmenu/glob-layout-updates into
lp:dbusmenu with lp:~ted/dbusmenu/glob-property-requests as a prerequisite.
Requested reviews:
DBus Menu Team (dbusmenu-team)
This branch makes it so that layout updates are sent once every visit to the
idle loop. So
Ted Gould has proposed merging lp:~ted/dbusmenu/breadth-first-properties into
lp:dbusmenu with lp:~ted/dbusmenu/glob-property-requests as a prerequisite.
Requested reviews:
DBus Menu Team (dbusmenu-team)
This branch makes it so that we request the properties in a bredth first
manner
Ted Gould has proposed merging lp:~ted/dbusmenu/open-menu-signal into
lp:dbusmenu.
Requested reviews:
DBus Menu Team (dbusmenu-team)
This is the signal for opening the menu from the application side. Right now
it just connects everything on the server side, but doesn't handle the client
Review: Approve
--
https://code.launchpad.net/~agateau/dbusmenu/click-to-dump/+merge/30401
Your team ayatana-commits is subscribed to branch lp:dbusmenu.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to :
Ted Gould has proposed merging lp:~ted/indicator-appmenu/dbus-api-migration
into lp:indicator-appmenu.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
This migrates Indicator Appmenu over to the AppMenu Dbus API.
--
https://code.launchpad.net/~ted/indicator
Ted Gould has proposed merging lp:~ted/dbusmenu/null-values-make-vala-smile
into lp:dbusmenu.
Requested reviews:
DBus Menu Team (dbusmenu-team)
NULL protection on the client side of events.
--
https://code.launchpad.net/~ted/dbusmenu/null-values-make-vala-smile/+merge/29875
Your team
Ted Gould has proposed merging lp:~ted/indicator-datetime/service-based into
lp:indicator-datetime.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
This migrates the currently limited functionality of the datetime indicator to
being a service based limited
Status: Development = Abandoned
--
lp:indicator-applet/python0.2
https://code.edge.launchpad.net/~indicator-applet-developers/indicator-applet/indicate-python
Your team ayatana-commits is subscribed to branch lp:indicator-applet/python0.2.
To unsubscribe from this branch go to
Ted Gould has proposed merging lp:~ted/indicator-application/approver-api into
lp:indicator-application.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Adding a basic approver interface and some code to support it. Should unblock
some, but isn't complete
On Jul 8, 2010, at 7:27 AM, Sense Hofstede qe...@ubuntu.com wrote:
On 8 July 2010 08:51, Evgeny Kolesnikov evge...@gmail.com wrote:
Idea: Add possibility to optionally accompany icon with some text (just like
Indicator Applet Session or any other menu widget do).
Purpose: Some applications
Review: Approve
review approve
--
https://code.launchpad.net/~bratsche/appmenu-gtk/image-check/+merge/29466
Your team ayatana-commits is subscribed to branch lp:appmenu-gtk.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to :
Review: Approve
I'd recommend changing the 1,2,3 for the events into an enum to make the code a
little more readable.
--
https://code.launchpad.net/~cjcurran/indicator-sound/event-handling/+merge/29473
Your team ayatana-commits is subscribed to branch lp:indicator-sound.
Review: Approve
--
https://code.launchpad.net/~bratsche/appmenu-gtk/panel-blacklist/+merge/29482
Your team ayatana-commits is subscribed to branch lp:appmenu-gtk.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to :
Review: Approve
I don't think that it'll fix the bugs, but I do think this is a good
improvement.
--
https://code.launchpad.net/~qense/indicator-application/appstore-private-macro-calls/+merge/29492
Your team ayatana-commits is subscribed to branch lp:indicator-application.
Review: Approve
* It would be nice to turn the ints at the top of
player-controler.vala into an enum so that we'd get some
type-safety from the variables.
* It seems like app_info and mpris_adaptor need to be initalized
in PlayerController()
* The player
Review: Approve
Looks good. Not for this review but I'm curious if we shoudln't replace the
recurse variable with a GArray?
--
https://code.launchpad.net/~bratsche/appmenu-gtk/uimanager-fixes/+merge/29045
Your team ayatana-commits is subscribed to branch lp:appmenu-gtk.
Review: Approve
--
https://code.launchpad.net/~bratsche/appmenu-gtk/action-notify/+merge/29047
Your team ayatana-commits is subscribed to branch lp:appmenu-gtk.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to :
Review: Approve
--
https://code.launchpad.net/~bratsche/appmenu-gtk/timer-per-toplevel2/+merge/29052
Your team ayatana-commits is subscribed to branch lp:appmenu-gtk.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to :
Review: Approve
Can we just delete VANISH and APPEAR? I don't think they'll be useful again,
eh?
--
https://code.launchpad.net/~bratsche/appmenu-gtk/deeper-reparenting/+merge/29095
Your team ayatana-commits is subscribed to branch lp:appmenu-gtk.
___
Ted Gould has proposed merging
lp:~ted/indicator-applet/sensitivity-isnt-always-a-good-thing into
lp:indicator-applet.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Related bugs:
#598524 doesn't respect unsensitive widget status
https://bugs.launchpad.net
Ted Gould has proposed merging lp:~ted/indicator-appmenu/indicator-list-apps
into lp:indicator-appmenu.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Fixing the debug interface so we can get a list of menus that are registered.
--
https://code.launchpad.net
Ted Gould has proposed merging lp:~ted/indicator-appmenu/unity-crasher-fun into
lp:indicator-appmenu.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Bad signal. Bad bad signal. Tracking the old root item so that we can
disconnect from it properly. Also
Ted Gould has proposed merging lp:~ted/indicator-appmenu/grab-late-menus into
lp:indicator-appmenu.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Fix menus starting out.
--
https://code.launchpad.net/~ted/indicator-appmenu/grab-late-menus/+merge/28796
Your
Ted Gould has proposed merging lp:~ted/indicator-appmenu/mock-application into
lp:indicator-appmenu.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Really simple mock application utility that takes a JSON file from
dbusmenu-dumper and turns
Ted Gould has proposed merging lp:~ted/dbusmenu/dumping-our-values into
lp:dbusmenu.
Requested reviews:
DBus Menu Team (dbusmenu-team)
Make the dumper handle values better. Including collections and STRV lists.
--
https://code.launchpad.net/~ted/dbusmenu/dumping-our-values/+merge/28655
Review: Approve
So excited!
review approve
On Mon, 2010-06-28 at 20:45 +, Cody Russell wrote:
Cody Russell has proposed merging lp:~bratsche/appmenu-gtk/rebuild-on-attach
into lp:appmenu-gtk.
Requested reviews:
Canonical Desktop Experience Team (canonical-dx-team)
This will
Review: Approve
--
https://code.launchpad.net/~cjcurran/indicator-sound/album-art-crasher/+merge/28497
Your team ayatana-commits is subscribed to branch lp:indicator-sound.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to :
Review: Needs Fixing
* I think you need a g_list_free() in your finalize function to free the list
data.
* Usually when I free or unref things I set their variable to NULL. The
reason is that if you add code later that uses it the symptom will be a
segfault unstead of some weird memory
Review: Approve
--
https://code.launchpad.net/~agateau/appmenu-gtk/fix597550/+merge/28401
Your team ayatana-commits is subscribed to branch lp:appmenu-gtk.
___
Mailing list: https://launchpad.net/~ayatana-commits
Post to :
Ted Gould has proposed merging lp:~ted/dbusmenu/be-like-qt into lp:dbusmenu.
Requested reviews:
DBus Menu Team (dbusmenu-team)
Makes our structures over Dbus look like and interoperate with the Qt
implementation.
--
https://code.launchpad.net/~ted/dbusmenu/be-like-qt/+merge/28346
Your team
301 - 400 of 617 matches
Mail list logo
