Hi Helga,
there is a b43-dev ML that may be more on topic, so I added it to CC:
On Sun, Mar 23, 2025 at 11:21 AM Helga K wrote:
>
> Hi,
>
> I'm a C dev that works in network hardware testing and bringup.
> I'm extremely tired of the myriad issues of the broadcom-wl d
On Wed, 5 Feb 2025 12:06:14 +0100
Salvatore Bonaccorso wrote:
> https://wireless.wiki.kernel.org site now redirects to
> https://wireless.docs.kernel.org/en/latest/ making the reference
> information for the b43 firmware inaccessible. Update the URL to the
> current location.
>
https://wireless.wiki.kernel.org site now redirects to
https://wireless.docs.kernel.org/en/latest/ making the reference
information for the b43 firmware inaccessible. Update the URL to the
current location.
Link: https://bugs.debian.org/1095062
Signed-off-by: Salvatore Bonaccorso
---
drivers
On Wed, Feb 05, 2025 at 12:06:14PM +0100, Salvatore Bonaccorso wrote:
> https://wireless.wiki.kernel.org site now redirects to
> https://wireless.docs.kernel.org/en/latest/ making the reference
> information for the b43 firmware inaccessible. Update the URL to the
> current locatio
text data bss dec hex filename
> 16481 6232 0 22713 58b9
> drivers/net/wireless/broadcom/b43/tables_lpphy.o
>
> After:
> =
>text data bss dec hex filename
> 22305 395 0 22700
with allmodconfig:
> Before:
> ==
>text data bss dec hex filename
> 16481 6232 0 22713 58b9
> drivers/net/wireless/broadcom/b43/tables_lpphy.o
>
> After:
> =
>text data bss dec hex filename
> 22305
0 2271358b9
drivers/net/wireless/broadcom/b43/tables_lpphy.o
After:
=
textdata bss dec hex filename
22305 395 0 2270058ac
drivers/net/wireless/broadcom/b43/tables_lpphy.o
Signed-off-by: Christophe JAILLET
---
Compile tested-only.
lpphy_write_gain_t
_table(struct b43_wldev *dev, int
offset,
}
These three changes look like they are not necessary.
Correct. I'll send a v2.
CJ
_______
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
, data);
> @@ -2392,7 +2392,7 @@ void lpphy_write_gain_table(struct b43_wldev *dev, int
> offset,
> }
These three changes look like they are not necessary.
--
Michael Büsch
https://bues.ch/
pgpFWJiCJolef.pgp
Description: OpenPGP digital signature
___
0 2271358b9
drivers/net/wireless/broadcom/b43/tables_lpphy.o
After:
=
textdata bss dec hex filename
22369 395 0 2276458ec
drivers/net/wireless/broadcom/b43/tables_lpphy.o
Signed-off-by: Christophe JAILLET
---
Compile tested-only.
lpphy_write_gain_t
).
>
> sprintf() will be converted as weel if they have.
>
> Generally, this patch is generated by
> make coccicheck M= MODE=patch \
> COCCI=scripts/coccinelle/api/device_attr_show.cocci
>
> No functional change intended
>
> CC: Larry Finger
> CC: Kalle Valo
&g
have.
Generally, this patch is generated by
make coccicheck M= MODE=patch \
COCCI=scripts/coccinelle/api/device_attr_show.cocci
No functional change intended
CC: Larry Finger
CC: Kalle Valo
CC: linux-wirel...@vger.kernel.org
CC: b43-dev@lists.infradead.org
Acked-by: Larry Finger
Signed-off-by
" disabled)\n");
>> +count = sysfs_emit(buf, "0 (Short Preamble" " disabled)\n");
>>
>
> Please either leave the line break in place, or remove the string
> continuation.
Good catch, i will update it.
Thanks
Zhijian
>
>
>
___
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
reamble" " disabled)\n");
>
Please either leave the line break in place, or remove the string continuation.
--
Michael Büsch
https://bues.ch/
pgp73fELlqcsq.pgp
Description: OpenPGP digital signature
___
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
().
sprintf() will be converted as weel if they have.
Generally, this patch is generated by
make coccicheck M= MODE=patch \
COCCI=scripts/coccinelle/api/device_attr_show.cocci
No functional change intended
CC: Larry Finger
CC: Kalle Valo
CC: linux-wirel...@vger.kernel.org
CC: b43-dev@lists.infradead.org
have.
Generally, this patch is generated by
make coccicheck M= MODE=patch \
COCCI=scripts/coccinelle/api/device_attr_show.cocci
No functional change intended
CC: Larry Finger
CC: Kalle Valo
CC: linux-wirel...@vger.kernel.org
CC: b43-dev@lists.infradead.org
Signed-off-by: Li Zhijian
---
This
actual queue instantiated.
>
> Log of issue before change (with kernel parameter qos=0):
> [ +5.112651] [ cut here ]
> [ +0.05] WARNING: CPU: 7 PID: 25513 at net/mac80211/util.c:449
> __ieee80211_wake_queue+0xd5/0x180 [mac80211]
> [ +0.00
ter, the default behavior is problematic for most
> users and may be difficult to debug. This patch offers a working out-of-box
> experience for bcm4331 users.
>
> [snip]
>
> Fixes: e6f5b934fba8 ("b43: Add QOS support")
> Signed-off-by: Rahul Rameshbabu
LGTM
Rev
ling to stop
> the actual queue instantiated.
>
> Fixes: bad691946966 ("b43: avoid packet losses in the dma worker code.")
> Signed-off-by: Rahul Rameshbabu
LGTM
Reviewed-by: Julian Calaby
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www
nt queue and failing
> to stop/wake the actual queue instantiated.
>
> Fixes: 5100d5ac81b9 ("b43: Add PIO support for PCMCIA devices")
> Signed-off-by: Rahul Rameshbabu
LGTM
Reviewed-by: Julian Calaby
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http://www
nt queue and failing
> to stop/wake the actual queue instantiated.
>
> [snip]
>
> Fixes: e6f5b934fba8 ("b43: Add QOS support")
> Signed-off-by: Rahul Rameshbabu
LGTM
Reviewed-by: Julian Calaby
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http
ry. Some of the other architectures are easier.
>>
>> Just tried this with the x86 binary just because and ran into extraction
>> issues as expected. I could not find other architecture options from
>> Broadcom's download page, but I may not have been looking well
into extraction
> issues as expected. I could not find other architecture options from
> Broadcom's download page, but I may not have been looking well enough...
>
> ❯ b43-fwcutter ./wlc_hybrid.o_shipped
> Sorry, the input file is either wrong or not supported by b43-f
On Sun, 31 Dec 2023 05:03:27 +
Rahul Rameshbabu wrote:
> Rahul Rameshbabu (4):
> wifi: b43: Stop/wake correct queue in DMA Tx path when QoS is disabled
> wifi: b43: Stop/wake correct queue in PIO Tx path when QoS is disabled
> wifi: b43: Stop correct queue in DMA worker
olving "github.com" port 22
debug3: resolve_host: lookup github.com:22
debug3: channel_clear_timeouts: clearing
debug3: ssh_connect_direct: entering
debug1: Connecting to github.com [192.30.255.113] port 22.
debug3: set_sock_tos: set socket 3 IP_TOS 0x48
Fixe
When QoS is disabled, the queue priority value will not map to the correct
ieee80211 queue since there is only one queue. Stop queue 0 when QoS is
disabled to prevent trying to stop a non-existent queue and failing to stop
the actual queue instantiated.
Fixes: bad691946966 ("b43: avoid p
When QoS is disabled, the queue priority value will not map to the correct
ieee80211 queue since there is only one queue. Stop/wake queue 0 when QoS
is disabled to prevent trying to stop/wake a non-existent queue and failing
to stop/wake the actual queue instantiated.
Fixes: 5100d5ac81b9 (&quo
(with kernel parameter qos=0):
[ +5.112651] [ cut here ]
[ +0.05] WARNING: CPU: 7 PID: 25513 at net/mac80211/util.c:449
__ieee80211_wake_queue+0xd5/0x180 [mac80211]
[ +0.67] Modules linked in: b43(O) snd_seq_dummy snd_hrtimer snd_seq
snd_seq_device
improve the out-of-box experience while
cleaning up some fundamental issues in the driver when QoS is disabled, either
by the related kernel parameter or the newly introduced QoS disablement
function.
Running FW 784.2 during testing.
Log:
[ 11.661972] b43-phy0: Loading firmware version 784.2 (2012
. That said, new firmware could help us drop the fifth patch
>> in this series. I am thinking about using b43-fwcutter to extract
>> proprietary fw from a newer release of broadcom-wl to see if that makes
>> a difference. That said, I am a bit puzzled since the device I am
>>
b43-fwcutter to extract
proprietary fw from a newer release of broadcom-wl to see if that makes
a difference. That said, I am a bit puzzled since the device I am
testing on released in early 2011, and I used firmware released in late
2012.
Unfortunately, it is very difficult to get the parameters
ueue_mapping(skb));
>> +else
>> +ieee80211_stop_queue(dev->wl->hw, 0);
>
> This code sequence occurs in several places. Would it be better to put this
> in a
> routine specific to b43, thus it would only be used once?
Right, I am waiting t
; On Sat, 30 Dec 2023 18:48:45 +1100
>> > Julian Calaby wrote:
>> >> > --- a/drivers/net/wireless/broadcom/b43/dma.c
>> >> > +++ b/drivers/net/wireless/broadcom/b43/dma.c
>> >> > @@ -1399,7 +1399,10 @@ int b43_dma_tx(struct b43
gt;wl->hw, 0);
This code sequence occurs in several places. Would it be better to put this in a
routine specific to b43, thus it would only be used once?
We certainly could try extracting firmware from a newer binary. Any suggestions?
Larry
_______
acquire from http://lwfinger.com/b43-firmware/, which I extract from
> broadcom-wl-6.30.163.46.
It's still pretty old.
Nobody has worked on getting a newer version extracted for a long time.
But I'm fine with just disabling QoS on this device.
Upgrading to a newer firmware probably is a bi
On Sat, 30 Dec 2023 17:15:18 +
Rahul Rameshbabu wrote:
> On Sat, 30 Dec, 2023 14:40:36 +0100 Michael Büsch wrote:
> > [[PGP Signed Part:Undecided]]
> > On Sat, 30 Dec 2023 18:48:45 +1100
> > Julian Calaby wrote:
> >> > --- a/drivers/net/wireless/broadc
ously, the warning would be
>> incorrectly triggered when OpenFW reported QoS capability is present.
>
>> --- a/drivers/net/wireless/broadcom/b43/main.c
>> +++ b/drivers/net/wireless/broadcom/b43/main.c
>> @@ -2713,7 +2713,7 @@ static int b43_upload_microcode
On Sat, 30 Dec, 2023 14:40:36 +0100 Michael Büsch wrote:
> [[PGP Signed Part:Undecided]]
> On Sat, 30 Dec 2023 18:48:45 +1100
> Julian Calaby wrote:
>> > --- a/drivers/net/wireless/broadcom/b43/dma.c
>> > +++ b/drivers/net/wireless/broadcom/b43/dma.c
>> > @
too old for this device.
I just retested with newer firmware released on 2012-08-15. I still see
the same issue with QoS. This appears to be the newest firmware I can
acquire from http://lwfinger.com/b43-firmware/, which I extract from
broadcom-wl-6.30.163.46.
[ 11.661972] b43-phy0: Loading fi
ngineered to me.
Can we just instead do it like this, please?
if (!modparam_qos || dev->fw.opensource || dev->dev->chip_id ==
BCMA_CHIP_ID_BCM4331)
> wl->hw->queues = 1;
>
> err = ieee80211_register_hw(wl->hw);
--
Michael Büsch
https:/
On Sat, 30 Dec 2023 18:48:45 +1100
Julian Calaby wrote:
> > --- a/drivers/net/wireless/broadcom/b43/dma.c
> > +++ b/drivers/net/wireless/broadcom/b43/dma.c
> > @@ -1399,7 +1399,10 @@ int b43_dma_tx(struct b43_wldev *dev, struct sk_buff
> > *skb)
> >
/drivers/net/wireless/broadcom/b43/main.c
> +++ b/drivers/net/wireless/broadcom/b43/main.c
> @@ -2713,7 +2713,7 @@ static int b43_upload_microcode(struct b43_wldev *dev)
> dev->hwcrypto_enabled = false;
> }
> /* adding QoS support s
ake_queue+0xd5/0x180 [mac80211]
> [ +0.67] Modules linked in: b43(O) snd_seq_dummy snd_hrtimer snd_seq
> snd_seq_device nft_chain_nat xt_MASQUERADE nf_nat xfrm_user xfrm_algo
> xt_addrtype overlay ccm af_packet amdgpu snd_hda_codec_cirrus
> snd_hda_codec_generic ledtrig_au
From: Arnd Bergmann
[ Upstream commit 212457ccbd60dba34f965e4ffbe62f0e4f970538 ]
clang warns about an unpacked structure inside of a packed one:
drivers/net/wireless/broadcom/b43/b43.h:654:4: error: field data within 'struct
b43_iv' is less aligned than 'union (unnamed union
From: Arnd Bergmann
[ Upstream commit 212457ccbd60dba34f965e4ffbe62f0e4f970538 ]
clang warns about an unpacked structure inside of a packed one:
drivers/net/wireless/broadcom/b43/b43.h:654:4: error: field data within 'struct
b43_iv' is less aligned than 'union (unnamed union
From: Arnd Bergmann
[ Upstream commit 212457ccbd60dba34f965e4ffbe62f0e4f970538 ]
clang warns about an unpacked structure inside of a packed one:
drivers/net/wireless/broadcom/b43/b43.h:654:4: error: field data within 'struct
b43_iv' is less aligned than 'union (unnamed union
From: Arnd Bergmann
[ Upstream commit 212457ccbd60dba34f965e4ffbe62f0e4f970538 ]
clang warns about an unpacked structure inside of a packed one:
drivers/net/wireless/broadcom/b43/b43.h:654:4: error: field data within 'struct
b43_iv' is less aligned than 'union (unnamed union
From: Arnd Bergmann
[ Upstream commit 212457ccbd60dba34f965e4ffbe62f0e4f970538 ]
clang warns about an unpacked structure inside of a packed one:
drivers/net/wireless/broadcom/b43/b43.h:654:4: error: field data within 'struct
b43_iv' is less aligned than 'union (unnamed union
From: Arnd Bergmann
[ Upstream commit 212457ccbd60dba34f965e4ffbe62f0e4f970538 ]
clang warns about an unpacked structure inside of a packed one:
drivers/net/wireless/broadcom/b43/b43.h:654:4: error: field data within 'struct
b43_iv' is less aligned than 'union (unnamed union
From: Arnd Bergmann
[ Upstream commit 212457ccbd60dba34f965e4ffbe62f0e4f970538 ]
clang warns about an unpacked structure inside of a packed one:
drivers/net/wireless/broadcom/b43/b43.h:654:4: error: field data within 'struct
b43_iv' is less aligned than 'union (unnamed union
Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> clang warns about an unpacked structure inside of a packed one:
>
> drivers/net/wireless/broadcom/b43/b43.h:654:4: error: field data within
> 'struct b43_iv' is less aligned than 'union (unnamed union at
From: Arnd Bergmann
clang warns about an unpacked structure inside of a packed one:
drivers/net/wireless/broadcom/b43/b43.h:654:4: error: field data within 'struct
b43_iv' is less aligned than 'union (unnamed union at
/home/arnd/arm-soc/drivers/net/wireless/broadcom/b43/b43.h
On 5/16/23 02:45, Arnd Bergmann wrote:
From: Arnd Bergmann
clang warns about an unpacked structure inside of a packed one:
drivers/net/wireless/broadcom/b43/b43.h:654:4: error: field data within 'struct
b43_iv' is less aligned than 'union (unnamed union at
/home/arnd/arm-
tal signature
_______
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
patches for a regression here.
Which reminds me that I was missing:
Reported-by: kernel test robot
Link: https://lore.kernel.org/oe-kbuild-all/202305160749.ay1haoyp-...@intel.com/
Should I resend this as a combined patch for both drivers?
Arnd
_______
u check if the b43legacy driver has the same issue?
Acked-by: Michael Büsch
--
Michael Büsch
https://bues.ch/
pgpZ62NuaoR0W.pgp
Description: OpenPGP digital signature
_______
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
On Tue, May 16, 2023 at 09:45:42AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> clang warns about an unpacked structure inside of a packed one:
>
> drivers/net/wireless/broadcom/b43/b43.h:654:4: error: field data within
> 'struct b43_iv' is less aligned t
From: Arnd Bergmann
clang warns about an unpacked structure inside of a packed one:
drivers/net/wireless/broadcom/b43/b43.h:654:4: error: field data within 'struct
b43_iv' is less aligned than 'union (unnamed union at
/home/arnd/arm-soc/drivers/net/wireless/broadcom/b43/b43.h
Lukas Bulwahn wrote:
> Commit 399500da18f7 ("ssb: pick PCMCIA host code support from b43 driver")
> removes the config B43_PCMCIA.
>
> Clean up the last reference to this removed config B43_PCMCIA in the
> b43_print_driverinfo() function.
>
> Signed-off-by: L
t;ssb: pick PCMCIA host code support from b43 driver")
> removes the config B43_PCMCIA.
>
> Clean up the last reference to this removed config B43_PCMCIA in the
> b43_print_driverinfo() function.
>
> Signed-off-by: Lukas Bulwahn
> ---
> drivers/net/wireless/broadcom/b43/
Commit 399500da18f7 ("ssb: pick PCMCIA host code support from b43 driver")
removes the config B43_PCMCIA.
Clean up the last reference to this removed config B43_PCMCIA in the
b43_print_driverinfo() function.
Signed-off-by: Lukas Bulwahn
---
drivers/net/wireless/broadcom/b43/m
Xin Gao wrote:
> No need to initialise static variables to zero.
>
> Signed-off-by: Xin Gao
> Acked-by: Larry Finger
> [kv...@kernel.org: improve commit log]
Patch applied to wireless-next.git, thanks.
dbf8cd368a47 wifi: b43: do not initialise static variable
On 7/20/22 14:42, Xin Gao wrote:
do not initialise statics to 0.
Signed-off-by: Xin Gao
---
drivers/net/wireless/broadcom/b43/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/b43/main.c
b/drivers/net/wireless/broadcom/b43/main.c
index
do not initialise statics to 0.
Signed-off-by: Xin Gao
---
drivers/net/wireless/broadcom/b43/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/b43/main.c
b/drivers/net/wireless/broadcom/b43/main.c
index 17bcec5f3ff7..5e233d0e06c0 100644
Jilin Yuan wrote:
> Delete the redundant word 'early'.
>
> Signed-off-by: Jilin Yuan
Patch applied to wireless-next.git, thanks.
e2dfb8a5c605 wifi: b43: fix repeated words in comments
--
https://patchwork.kernel.org/project/linux-wireless/patch/20220709133119.21076-1-y
Delete the redundant word 'early'.
Signed-off-by: Jilin Yuan
---
drivers/net/wireless/broadcom/b43/phy_common.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/b43/phy_common.h
b/drivers/net/wireless/broadcom/b43/phy_comm
From: Haowen Bai
[ Upstream commit 11800d893b38e0e12d636c170c1abc19c43c730c ]
fix warning reported by smatch:
drivers/net/wireless/broadcom/b43/phy_n.c:585 b43_nphy_adjust_lna_gain_table()
warn: assigning (-2) to unsigned variable '*(lna_gain[0])'
Signed-off-by: Haowen Bai
Sig
From: Haowen Bai
[ Upstream commit 11800d893b38e0e12d636c170c1abc19c43c730c ]
fix warning reported by smatch:
drivers/net/wireless/broadcom/b43/phy_n.c:585 b43_nphy_adjust_lna_gain_table()
warn: assigning (-2) to unsigned variable '*(lna_gain[0])'
Signed-off-by: Haowen Bai
Sig
From: Haowen Bai
[ Upstream commit 11800d893b38e0e12d636c170c1abc19c43c730c ]
fix warning reported by smatch:
drivers/net/wireless/broadcom/b43/phy_n.c:585 b43_nphy_adjust_lna_gain_table()
warn: assigning (-2) to unsigned variable '*(lna_gain[0])'
Signed-off-by: Haowen Bai
Sig
From: Haowen Bai
[ Upstream commit 11800d893b38e0e12d636c170c1abc19c43c730c ]
fix warning reported by smatch:
drivers/net/wireless/broadcom/b43/phy_n.c:585 b43_nphy_adjust_lna_gain_table()
warn: assigning (-2) to unsigned variable '*(lna_gain[0])'
Signed-off-by: Haowen Bai
Sig
From: Haowen Bai
[ Upstream commit 11800d893b38e0e12d636c170c1abc19c43c730c ]
fix warning reported by smatch:
drivers/net/wireless/broadcom/b43/phy_n.c:585 b43_nphy_adjust_lna_gain_table()
warn: assigning (-2) to unsigned variable '*(lna_gain[0])'
Signed-off-by: Haowen Bai
Sig
From: Haowen Bai
[ Upstream commit 11800d893b38e0e12d636c170c1abc19c43c730c ]
fix warning reported by smatch:
drivers/net/wireless/broadcom/b43/phy_n.c:585 b43_nphy_adjust_lna_gain_table()
warn: assigning (-2) to unsigned variable '*(lna_gain[0])'
Signed-off-by: Haowen Bai
Sig
From: Haowen Bai
[ Upstream commit 11800d893b38e0e12d636c170c1abc19c43c730c ]
fix warning reported by smatch:
drivers/net/wireless/broadcom/b43/phy_n.c:585 b43_nphy_adjust_lna_gain_table()
warn: assigning (-2) to unsigned variable '*(lna_gain[0])'
Signed-off-by: Haowen Bai
Sig
From: Haowen Bai
[ Upstream commit 11800d893b38e0e12d636c170c1abc19c43c730c ]
fix warning reported by smatch:
drivers/net/wireless/broadcom/b43/phy_n.c:585 b43_nphy_adjust_lna_gain_table()
warn: assigning (-2) to unsigned variable '*(lna_gain[0])'
Signed-off-by: Haowen Bai
Sig
Haowen Bai wrote:
> fix warning reported by smatch:
> drivers/net/wireless/broadcom/b43/phy_n.c:585 b43_nphy_adjust_lna_gain_table()
> warn: assigning (-2) to unsigned variable '*(lna_gain[0])'
>
> Signed-off-by: Haowen Bai
Patch applied to wireless-next.git, thank
fix warning reported by smatch:
drivers/net/wireless/broadcom/b43/phy_n.c:585 b43_nphy_adjust_lna_gain_table()
warn: assigning (-2) to unsigned variable '*(lna_gain[0])'
Signed-off-by: Haowen Bai
---
V1->V2: change title prefix b43.
drivers/net/wireless/broadcom/b43/phy_n.c |
Haowen Bai writes:
> fix warning reported by smatch:
> drivers/net/wireless/broadcom/b43/phy_n.c:585 b43_nphy_adjust_lna_gain_table()
> warn: assigning (-2) to unsigned variable '*(lna_gain[0])'
>
> Signed-off-by: Haowen Bai
> ---
> drivers/net/wireless/broadc
fix warning reported by smatch:
drivers/net/wireless/broadcom/b43/phy_n.c:585 b43_nphy_adjust_lna_gain_table()
warn: assigning (-2) to unsigned variable '*(lna_gain[0])'
Signed-off-by: Haowen Bai
---
drivers/net/wireless/broadcom/b43/phy_n.c | 2 +-
1 file changed, 1 insertion(+),
linux b43
--
HH Wielage
___
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
s means that "start" becomes a very high positive value. The result
> of that is that we never enter the "for (i = start; i <= end; i++) {"
> loop. Instead of storing the result from b43legacy_radio_aci_detect()
> it just uses zero.
>
> Fixes: ef1a628d83fc ("b4
is that we never enter the "for (i = start; i <= end; i++) {"
loop. Instead of storing the result from b43legacy_radio_aci_detect()
it just uses zero.
Fixes: ef1a628d83fc ("b43: Implement dynamic PHY API")
Signed-off-by: Dan Carpenter
---
drivers/net/wireless/broadcom/b43/
Zhen Lei wrote:
> These TODO empty code are added by
> commit 9442e5b58edb ("b43: N-PHY: partly implement SPUR workaround"). It's
> been more than a decade now. I don't think anyone who wants to perfect
> this workaround can follow this TODO tip exactly. Instead,
le Valo
> > Cc: "David S. Miller"
> > Cc: Jakub Kicinski
> > Cc: Kees Cook
> > Cc: Greg Kroah-Hartman
> > Cc: Jason Gunthorpe
> > Cc: Chao Yu
> > Cc: Leon Romanovsky
> > Cc: linux-wirel...@vger.kernel.org
> > Cc: b43
he relayfs file. That's fine,
> > not a big deal, debugfs will always provide a way for you to get that if
> > needed.
>
> Unless debugfs is disabled, like on Android, which is the real problem I'm
> trying to solve.
Then use some other filesystem to place your relay
s the real problem
I'm
trying to solve.
Jeff
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum,
a Linux Foundation Collaborative Project
___
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
t/wireless/ath/ath11k/spectral.c, line 902
> drivers/net/wireless/ath/ath9k/common-spectral.c, line 1077
> kernel/trace/blktrace.c, line 549
Ah, that's just the "parent" dentry for the relayfs file. That's fine,
not a big deal, debugfs will always provide a
Foundation Collaborative Project
___________
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
is a recommended way to get a
> dentry not associated with debugfs.
What do you exactly mean by "not associated with debugfs"?
And why are you passing a debugfs dentry to relay_open()? That feels
really wrong and fragile.
Ideally I want to get rid of the "raw" dentry that
debugfs.
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum,
a Linux Foundation Collaborative Project
___
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
debugfs is disabled).
Thanks,
Jeff
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum,
a Linux Foundation Collaborative Project
___
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43
an
> Cc: Jason Gunthorpe
> Cc: Chao Yu
> Cc: Leon Romanovsky
> Cc: linux-wirel...@vger.kernel.org
> Cc: b43-dev@lists.infradead.org
> Cc: net...@vger.kernel.org
> Cc: linux-ker...@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman
> ---
> drivers/net/wireless/broa
-kernel user that was
storing the result of debugfs_create_bool(), so that api can be cleaned
up.
Cc: Kalle Valo
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: Kees Cook
Cc: Greg Kroah-Hartman
Cc: Jason Gunthorpe
Cc: Chao Yu
Cc: Leon Romanovsky
Cc: linux-wirel...@vger.kernel.org
C
Kees Cook
> Cc: Greg Kroah-Hartman
> Cc: Jason Gunthorpe
> Cc: Chao Yu
> Cc: Leon Romanovsky
> Cc: linux-wirel...@vger.kernel.org
> Cc: b43-dev@lists.infradead.org
> Cc: net...@vger.kernel.org
> Cc: linux-ker...@vger.kernel.org
> Signed-off-by: G
-kernel user that was
storing the result of debugfs_create_bool(), so that api can be cleaned
up.
Cc: Kalle Valo
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: Kees Cook
Cc: Greg Kroah-Hartman
Cc: Jason Gunthorpe
Cc: Chao Yu
Cc: Leon Romanovsky
Cc: linux-wirel...@vger.kernel.org
C
rew
___
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
On 2021/5/11 9:11, Leizhen (ThunderTown) wrote:
>
>
> On 2021/5/11 4:02, Andrew Lunn wrote:
>> On Mon, May 10, 2021 at 10:51:17PM +0800, Zhen Lei wrote:
>>> These TODO empty code are added by
>>> commit 9442e5b58edb ("b43: N-PHY: partly implement SPUR w
These TODO empty code are added by
commit 9442e5b58edb ("b43: N-PHY: partly implement SPUR workaround"). It's
been more than a decade now. I don't think anyone who wants to perfect
this workaround can follow this TODO tip exactly. Instead, it limits them
to new thinking. Remo
v1 --> v2:
Fixes "W=1" warnings. That's because after removing the todo code,
the local variables 'noise' and 'tone' are not referenced.
Thanks to Andrew Lunn for his review.
Zhen Lei (1):
b43: phy_n: Delete some useless TODO code
drivers/
On 2021/5/11 4:02, Andrew Lunn wrote:
> On Mon, May 10, 2021 at 10:51:17PM +0800, Zhen Lei wrote:
>> These TODO empty code are added by
>> commit 9442e5b58edb ("b43: N-PHY: partly implement SPUR workaround"). It's
>> been more than a decade now. I don't
On Mon, May 10, 2021 at 10:51:17PM +0800, Zhen Lei wrote:
> These TODO empty code are added by
> commit 9442e5b58edb ("b43: N-PHY: partly implement SPUR workaround"). It's
> been more than a decade now. I don't think anyone who wants to perfect
> this workaround
1 - 100 of 2070 matches
Mail list logo
