On Wednesday 13 December 2006 08:49, Oliver Lehmann wrote:
a Kern Sibbald writes:
patch-src-findlib-attribs.c
when restoring a symlink, use lchflags to restore the file flags
defined for the symlink (new feature)
when restoring a hardlink, don't call chmod, chown, utime because
Hello,
I've now taken a look at these patches and though they might be going in the
right direction, I cannot consider them for inclusion in version 1.40 for
several reasons:
1. They are not relative to the current CVS.
2. They are a significant change from the current code, which is not a
Hello,
On Wednesday 13 December 2006 10:11, Oliver Lehmann wrote:
Hi Kern,
Kern Sibbald writes:
1. They are not relative to the current CVS.
Hm, they are applying to it, or? At least I tried that..
2. They are a significant change from the current code, which is not a
problem
patch-src-findlib-create_file.c
Try to unset file flags of the sourcefile when the hardlink failed.
Retry to hardlink then. If the hardlink fails then again, restore the
file flags of the sourcefile. If the hardlink was created w/o errors,
restore the fileflags of the sourcefile.
Why
On Wednesday 13 December 2006 12:01, Oliver Lehmann wrote:
Hi Kern,
it is ok when you want me to deliver the patch in a defined format. I've no
problems with that. I must say that I didn't read the developer manual
before I sent the patch, but I hope the patch does now comply to the
Folks,
just to dropping into this discussion.
Kern Sibbald wrote:
On Wednesday 13 December 2006 08:49, Oliver Lehmann wrote:
a Kern Sibbald writes:
patch-src-findlib-attribs.c
when restoring a symlink, use lchflags to restore the file flags
defined for the symlink (new feature)
This
On Wednesday 13 December 2006 16:07, Attila Fülöp wrote:
Folks,
just to dropping into this discussion.
Kern Sibbald wrote:
On Wednesday 13 December 2006 08:49, Oliver Lehmann wrote:
a Kern Sibbald writes:
patch-src-findlib-attribs.c
when restoring a symlink, use lchflags to
Jeremy C. Reed wrote:
Why do the chflags(attr-olname, s.st_flags) restore the fileflags of the
sourcefile twice?
once in case the 2nd linking failed (there is a return after that!)
and the 2nd time for the linking was successfull case.
Also the first reset of the chflags() should probably
On Wed, 13 Dec 2006, Kern Sibbald wrote:
Concerning all these differences on FreeBSD: if the changes needed to make
things work correctly on FreeBSD are extensive and require a bit of
#ifdefing, we are going to have to re-think how we do it. The code is
...
I just want to point out that
On Wednesday 13 December 2006 17:20, Oliver Lehmann wrote:
Jeremy C. Reed wrote:
Why do the chflags(attr-olname, s.st_flags) restore the fileflags of the
sourcefile twice?
once in case the 2nd linking failed (there is a return after that!)
and the 2nd time for the linking was
Kern Sibbald wrote:
I encourage you to re-submit a patch for the above problem once 1.40.0 is
out,
possibly coordinating with Attila, since he seems to be working on something
a bit more encompasing (attribs + ACLs, ...).
Ok, no problem - I'll do so.
--
Oliver Lehmann
Kern Sibbald wrote:
On Wednesday 13 December 2006 16:07, Attila Fülöp wrote:
Folks,
just to dropping into this discussion.
Kern Sibbald wrote:
On Wednesday 13 December 2006 08:49, Oliver Lehmann wrote:
a Kern Sibbald writes:
patch-src-findlib-attribs.c
when restoring a symlink, use
Here is an untested patch (or at least an idea :) that should help those
who don't use raised securelevel. This patch needs some debug output for
both chflags introduced here.
Index: src/findlib/create_file.c
I see my patch is missing a closing brace. And also it fails to return
error if
Jeremy C. Reed wrote:
Here is an untested patch (or at least an idea :) that should help those
who don't use raised securelevel. This patch needs some debug output for
both chflags introduced here.
Index: src/findlib/create_file.c
I see my patch is missing a closing brace. And
The patch I sent was not correct because ofname and olname where mixed up
when doing the flags work. I fixed this now, and I tried restoring
my /usr/bin. It now created the hardlinks, but gave me errors that the owner
and times of the hardlinks are not setable (because of the same thing)
How
Oliver Lehmann wrote:
The patch I sent was not correct because ofname and olname where mixed up
when doing the flags work. I fixed this now, and I tried restoring
my /usr/bin. It now created the hardlinks, but gave me errors that the owner
and times of the hardlinks are not setable (because
On Tuesday 12 December 2006 23:01, Jeremy C. Reed wrote:
Here is an untested patch (or at least an idea :) that should help those
who don't use raised securelevel. This patch needs some debug output for
both chflags introduced here.
Index: src/findlib/create_file.c
I see my patch
Kern Sibbald wrote:
Please fix it up correctly, then send it to me in the same diff format versus
the current CVS, but please send it as an attachment to avoid the possibility
of word wrap. I'll then take a look at putting it in the code. If you send
it in the next few days, it will
Hello,
I haven't yet looked at the patches, but here are a couple of preliminary
comments. I'll take a careful look at the patches later today.
On Wednesday 13 December 2006 07:54, Oliver Lehmann wrote:
Kern Sibbald wrote:
Please fix it up correctly, then send it to me in the same diff
19 matches
Mail list logo
