[PATCH v2 10/29] ARM: boards: i.MX8M: add HAB image support

2023-10-17 Thread Marco Felsch
From: Rouven Czerwinski This adds the habv4-imx8-gencsf.h header to include HAB image commands which are enabled if CONFIG_HABV4 is enabled. Signed-off-by: Rouven Czerwinski [m.fel...@pengutronix.de: split commit] Signed-off-by: Marco Felsch --- Changelog: v2: - unchanged - v1-link: https

[PATCH v2 05/29] i.MX: HABv4: extend support to i.MX8M SoCs

2023-10-17 Thread Marco Felsch
with the i.MX8MQ except for the DIR_BT_DIS fuse. Signed-off-by: Rouven Czerwinski [m.fel...@pengutronix.de: adapt commit message] [m.fel...@pengutronix.de: integrate review feedback] Signed-off-by: Marco Felsch --- Changelog: v2: - unchanged - v1-link: https://lore.barebox.org/barebox

[PATCH v2 08/29] ARM: i.MX: introduce build_imx8m_habv4img

2023-10-17 Thread Marco Felsch
From: Rouven Czerwinski Similar to the helper for i.MX6, this allows us to build HAB enabled images by selecting KConfig symbols. So far I have only tested signed images, so there is no support for usb-signed or encrypted images yet. Signed-off-by: Rouven Czerwinski --- Changelog: v2: -

[PATCH v2 03/29] i.MX: HABv4: fix i.MX8MQ device lockdown

2023-10-17 Thread Marco Felsch
review feedback] [a.fat...@pengutronix.de: fixup imx_hab_device_locked_down_ocotp logic for imx6 and imx8m] Signed-off-by: Marco Felsch --- Changelog: v2: - integrate Ahmads fixup patch - v1-link: https://lore.barebox.org/barebox/20231010143314.2031253-1-m.fel...@pengutronix.de/T/#t drivers/hab

[PATCH v2 28/29] Documentation: boards: imx: replace i.MX8MQ with i.MX8M

2023-10-17 Thread Marco Felsch
Some parts of the documentation refer to the i.MX8MQ which are valid for all i.MX8M SoCs. Also rename the i.MX8 to i.MX8M to make it clear which family we meant. Signed-off-by: Marco Felsch --- Changelog: v2: - unchaned - v1-link: https://lore.barebox.org/barebox/20231010143314.2031253-1-m.fel

[PATCH v2 07/29] ARM: i.MX: allow HAB for i.MX8M family

2023-10-17 Thread Marco Felsch
From: Rouven Czerwinski Since the HAB driver can now parse events for the complete family, allow selection for the whole family. Signed-off-by: Rouven Czerwinski --- Changelog: v2: - unchanged - v1-link: https://lore.barebox.org/barebox/20231010143314.2031253-1-m.fel...@pengutronix.de/T/#t

[PATCH v2 01/29] kbuild: clean start*_*.{p,ps}imximg files

2023-10-17 Thread Marco Felsch
From: Rouven Czerwinski Cleanup files build during i.MX8M image generation. Signed-off-by: Rouven Czerwinski --- Changelog: v2: - unchanged - v1-link: https://lore.barebox.org/barebox/20231010143314.2031253-1-m.fel...@pengutronix.de/T/#t images/Makefile | 3 ++- 1 file changed, 2

[PATCH v2 11/29] ARM: i.MX8M: add flexspi-imx8m{m,p}-cfg.h header

2023-10-17 Thread Marco Felsch
Add dedicated configuration headers to be more user-friendly. No functional change. Signed-off-by: Marco Felsch --- Changelog: v2: - dropped ifdef guard - v1-link: https://lore.barebox.org/barebox/20231010143314.2031253-1-m.fel...@pengutronix.de/T/#t include/mach/imx/flexspi-imx8mm-cfg.h | 8

[PATCH v2 00/29] i.MX8M HAB Fixes

2023-10-17 Thread Marco Felsch
: Documentation patches to become an overview of the FlexSPI HAB single image implementation. Testers are very welcome :) Marco Felsch (20): i.MX: HAB: remove unused init() hook ARM: i.MX8M: add flexspi-imx8m{m,p}-cfg.h header ARM: boards: i.MX8M: make use of new flexspi-imx8m{m,p}-cfg.h header

[PATCH v2 04/29] i.MX: HAB: remove unused init() hook

2023-10-17 Thread Marco Felsch
The init() hook was never used so we can remove it to cleanup the code a bit. Signed-off-by: Marco Felsch --- Changelog: v2: - unchanged - v1-link: https://lore.barebox.org/barebox/20231010143314.2031253-1-m.fel...@pengutronix.de/T/#t drivers/hab/hab.c | 18 -- 1 file changed

[PATCH v2 06/29] i.MX: HABv4: retrieve HAB ROM version for i.MX8M

2023-10-17 Thread Marco Felsch
From: Rouven Czerwinski The HAB userguide mentions this additional API calls introduced in 2018 (which coincides with the introduction of i.MX8M SoCs). Call this API call unconditionally on i.MX8M SoCs to print the HAB version the ROM code supports. Signed-off-by: Rouven Czerwinski ---

[PATCH v2 02/29] i.MX: HABv4: fix event status comparison

2023-10-17 Thread Marco Felsch
From: Rouven Czerwinski Instead of only printing events belonging to a certain level, print all events that have a higher status than the current event. This fixes event printing for i.MX8M based boards. Fixes: 8b35facbb971 ("i.MX: HABv4: Improve HAB event printing") Signed-off-by: Rouven

Re: [PATCH 21/26] scripts: imx: add helper to write CSF Blocks command

2023-10-16 Thread Marco Felsch
Hi Sascha, On 23-10-16, Marco Felsch wrote: > On 23-10-13, Sascha Hauer wrote: > > On Tue, Oct 10, 2023 at 04:33:09PM +0200, Marco Felsch wrote: > > > The upcoming commit fixes the HAB support for FlexSPI enabled barebox > > > images. This commit prepares the sour

Re: [PATCH 21/26] scripts: imx: add helper to write CSF Blocks command

2023-10-15 Thread Marco Felsch
On 23-10-13, Sascha Hauer wrote: > On Tue, Oct 10, 2023 at 04:33:09PM +0200, Marco Felsch wrote: > > The upcoming commit fixes the HAB support for FlexSPI enabled barebox > > images. This commit prepares the source to keep the diff smaller. > > > > For the upcoming fi

Re: [PATCH 14/26] ARM: lds: add support for a 2nd CSF area

2023-10-15 Thread Marco Felsch
On 23-10-13, Sascha Hauer wrote: > On Tue, Oct 10, 2023 at 04:33:02PM +0200, Marco Felsch wrote: > > Extend the CSF area to be able two store two CSF slots. The 2nd CSF slot > > is required in case of FlexSPI HAB boot support. The first slot is used > > for the MMC-IVT + bare

Re: [PATCH 11/26] ARM: i.MX8M: add flexspi-imx8m{m,p}-cfg.h header

2023-10-15 Thread Marco Felsch
On 23-10-13, Sascha Hauer wrote: > On Tue, Oct 10, 2023 at 04:32:59PM +0200, Marco Felsch wrote: > > Add dedicated configuration headers which guard the flexspi_* options > > like it is done for the HABV4 configuration block to be more > > user-friendly. > > >

[PATCH 2/2] ARM64: configs: cleanup multi_v8_defconfig

2023-10-10 Thread Marco Felsch
Cleanup the defconfig to keep only the required config symbols. The cleanup is done by running: 1) make ARCH=arm multi_v8_defconfig 2) make ARCH=arm savedefconfig 3) mv defconfig arch/arm/configs/multi_v8_defconfig This sequence also sort the config entries accordingly. Signed-off-by: Marco

[PATCH 1/2] ARM64: configs: enable SPI drivers

2023-10-10 Thread Marco Felsch
Enable NXP (Q)SPI drivers since NOR flashes are often used as: - bootsource and/or - storage medium e.g. for barebox-state Signed-off-by: Marco Felsch --- arch/arm/configs/multi_v8_defconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/configs

Re: [PATCH] fixup! i.MX: HABv4: fix i.MX8MQ device lockdown

2023-10-10 Thread Marco Felsch
Hi Ahmad, On 23-10-10, Ahmad Fatoum wrote: > Fixed up patch splits imx_hab_lockdown_device_ocotp into two > functions, one i.MX6- and another i.MX8M-specific, because they differ > in the fuse written: OCOTP_SEC_CONFIG_1 vs MX8M_OCOTP_SEC_CONFIG_1. > > The same OCOTP_SEC_CONFIG_1 fuse is also

[PATCH 22/26] scripts: imx: fix HAB for FlexSPI boot

2023-10-10 Thread Marco Felsch
IVT. Please check the upcoming documentation patch for a in detail image layout overview. Signed-off-by: Marco Felsch --- include/mach/imx/imx-header.h | 1 + scripts/imx/imx-image.c | 9 + scripts/imx/imx.c | 38 --- 3 files changed, 45

[PATCH 04/26] i.MX: HAB: remove unused init() hook

2023-10-10 Thread Marco Felsch
The init() hook was never used so we can remove it to cleanup the code a bit. Signed-off-by: Marco Felsch --- drivers/hab/hab.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/hab/hab.c b/drivers/hab/hab.c index fa9912f784b4..a1c1e89eb249 100644

[PATCH 20/26] scripts: imx-image: hab_sign: refactor function

2023-10-10 Thread Marco Felsch
Refactor the code to make it possible to write multiple CSF blocks. This is required for the upcoming FlexSPI CSF data fix. Signed-off-by: Marco Felsch --- scripts/imx/imx-image.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/scripts/imx/imx-image.c b/scripts

[PATCH 25/26] Documentation: boards: imx: replace i.MX8MQ with i.MX8M

2023-10-10 Thread Marco Felsch
Some parts of the documentation refer to the i.MX8MQ which are valid for all i.MX8M SoCs. Also rename the i.MX8 to i.MX8M to make it clear which family we meant. Signed-off-by: Marco Felsch --- Documentation/boards/imx.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 19/26] scripts: imx-image: header_v2: add CSF slots

2023-10-10 Thread Marco Felsch
Place the MMC/SD CSF data int slot-0 and the FlexSPI CSF data into slot-1. This must be done since the MMC/SD and FlexSPI CSF data are different. Signed-off-by: Marco Felsch --- scripts/imx/imx-image.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/imx/imx

[PATCH 15/26] scripts: imx: force flexspi and hab option order

2023-10-10 Thread Marco Felsch
. Signed-off-by: Marco Felsch --- scripts/imx/imx.c | 12 1 file changed, 12 insertions(+) diff --git a/scripts/imx/imx.c b/scripts/imx/imx.c index e3169bace6a6..32488455b7a8 100644 --- a/scripts/imx/imx.c +++ b/scripts/imx/imx.c @@ -614,6 +614,12 @@ static int do_flexspi_ivtofs(struct

[PATCH 26/26] Documentation: boards: imx: add FlexSPI sub-section

2023-10-10 Thread Marco Felsch
Document the FlexSPI image and boot feature to make it easier for users to enable the support. Also document the image layout since it became more complex with FlexSPI and HAB, so a detailed overview is very helpful. Signed-off-by: Marco Felsch --- Documentation/boards/imx.rst | 77

[PATCH 23/26] scripts: imx-image: add missing close()

2023-10-10 Thread Marco Felsch
Close the csfbin file after we read it into buf. Signed-off-by: Marco Felsch --- scripts/imx/imx-image.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/imx/imx-image.c b/scripts/imx/imx-image.c index 8c4cc771ee28..4a0a44b3a9b3 100644 --- a/scripts/imx/imx-image.c +++ b/scripts

[PATCH 24/26] scripts: imx-image: add support for CST_EXTRA_CMDLINE_OPTIONS

2023-10-10 Thread Marco Felsch
Add CST_EXTRA_CMDLINE_OPTIONS environment variable to allow build tools like PTXdist or Yocto to pass additional cst command line options. This becomes important for newer cst versions (> 3.3.1) since they support multiple backends: ssl (default) and pkcs11. Signed-off-by: Marco Fel

[PATCH 21/26] scripts: imx: add helper to write CSF Blocks command

2023-10-10 Thread Marco Felsch
re we need to handle the blocks command separately which is done by this commit. At the moment there is no functional change. Signed-off-by: Marco Felsch --- scripts/imx/imx.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/scripts/imx/imx.c b/scripts/imx/i

[PATCH 18/26] scripts: imx: add imx8m_get_offset_size helper

2023-10-10 Thread Marco Felsch
No functional change, just move the offset and signed_size calculation into a dedicated helper. Signed-off-by: Marco Felsch --- scripts/imx/imx.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/scripts/imx/imx.c b/scripts/imx/imx.c index

[PATCH 08/26] ARM: i.MX: introduce build_imx8m_habv4img

2023-10-10 Thread Marco Felsch
From: Rouven Czerwinski Similar to the helper for i.MX6, this allows us to build HAB enabled images by selecting KConfig symbols. So far I have only tested signed images, so there is no support for usb-signed or encrypted images yet. Signed-off-by: Rouven Czerwinski --- images/Makefile.imx |

[PATCH 06/26] i.MX: HABv4: retrieve HAB ROM version for i.MX8M

2023-10-10 Thread Marco Felsch
From: Rouven Czerwinski The HAB userguide mentions this additional API calls introduced in 2018 (which coincides with the introduction of i.MX8M SoCs). Call this API call unconditionally on i.MX8M SoCs to print the HAB version the ROM code supports. Signed-off-by: Rouven Czerwinski ---

[PATCH 01/26] kbuild: clean start*_*.{p,ps}imximg files

2023-10-10 Thread Marco Felsch
From: Rouven Czerwinski Cleanup files build during i.MX8M image generation. Signed-off-by: Rouven Czerwinski --- images/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/images/Makefile b/images/Makefile index 9739a15c06ba..90d596deabcd 100644 ---

[PATCH 00/26] i.MX8M HAB Fixes

2023-10-10 Thread Marco Felsch
: Documentation patches to become an overview of the FlexSPI HAB single image implementation. Testers are very welcome :) Regards, Marco Marco Felsch (17): i.MX: HAB: remove unused init() hook ARM: i.MX8M: add flexspi-imx8m{m,p}-cfg.h header ARM: boards: i.MX8M: make use of new flexspi-imx8m

[PATCH 03/26] i.MX: HABv4: fix i.MX8MQ device lockdown

2023-10-10 Thread Marco Felsch
review feedback] Signed-off-by: Marco Felsch --- drivers/hab/hab.c| 31 ++- include/mach/imx/ocotp-fusemap.h | 3 +++ 2 files changed, 29 insertions(+), 5 deletions(-) diff --git a/drivers/hab/hab.c b/drivers/hab/hab.c index afe6a6682276..fa9912f784b4

[PATCH 09/26] ARM: i.MX: convert i.MX8M to helper

2023-10-10 Thread Marco Felsch
-off-by: Rouven Czerwinski [m.fel...@pengutronix.de: convert all possible make targets] [m.fel...@pengutronix.de: adapt commit message] Signed-off-by: Marco Felsch --- images/Makefile.imx | 97 - 1 file changed, 26 insertions(+), 71 deletions(-) diff

[PATCH 13/26] ARM: lds: introduce HAB_CSF_LEN define for the hab_csf section

2023-10-10 Thread Marco Felsch
Introduce the HAB_CSF_LEN to make conditional size changes easier later on. No functional change. Signed-off-by: Marco Felsch --- arch/arm/lib/pbl.lds.S | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm/lib/pbl.lds.S b/arch/arm/lib/pbl.lds.S index 2b4b1d6a9513

[PATCH 14/26] ARM: lds: add support for a 2nd CSF area

2023-10-10 Thread Marco Felsch
the i.MX8M image layout. Signed-off-by: Marco Felsch --- arch/arm/lib/pbl.lds.S | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/lib/pbl.lds.S b/arch/arm/lib/pbl.lds.S index 898d6be33b54..9ab6d22eb59d 100644 --- a/arch/arm/lib/pbl.lds.S +++ b/arch/arm/lib/pbl.lds.S @@ -12,7 +12,11

[PATCH 17/26] scripts: imx: fix i.MX8M CSF header placement

2023-10-10 Thread Marco Felsch
The current boot flow is broken if both the FlexSPI image and the HAB support is enabled. The HAB/CST tool need to take the additional FlexSPI IVT header into account which is added in between the first IVT header and the barebox pbl code. Signed-off-by: Marco Felsch --- include/mach/imx/imx

[PATCH 12/26] ARM: boards: i.MX8M: make use of new flexspi-imx8m{m,p}-cfg.h header

2023-10-10 Thread Marco Felsch
Use the new config header to make it more user-friendly. Signed-off-by: Marco Felsch --- arch/arm/boards/nxp-imx8mm-evk/flash-header-imx8mm-evk.imxcfg | 3 +-- arch/arm/boards/nxp-imx8mn-evk/flash-header-imx8mn-evk.imxcfg | 3 +-- arch/arm/boards/nxp-imx8mp-evk/flash-header-imx8mp-evk.imxcfg

[PATCH 16/26] scripts: imx: move flexspi_image() into header

2023-10-10 Thread Marco Felsch
Move the flexspi_image() into the imx.h header to make the code reusable between imx.c and imx-image.c. No functional change. Signed-off-by: Marco Felsch --- scripts/imx/imx-image.c | 12 scripts/imx/imx.h | 13 + 2 files changed, 13 insertions(+), 12 deletions

[PATCH 02/26] i.MX: HABv4: fix event status comparison

2023-10-10 Thread Marco Felsch
From: Rouven Czerwinski Instead of only printing events belonging to a certain level, print all events that have a higher status than the current event. This fixes event printing for i.MX8M based boards. Fixes: 8b35facbb971 ("i.MX: HABv4: Improve HAB event printing") Signed-off-by: Rouven

[PATCH 07/26] ARM: i.MX: allow HAB for i.MX8M family

2023-10-10 Thread Marco Felsch
From: Rouven Czerwinski Since the HAB driver can now parse events for the complete family, allow selection for the whole family. Signed-off-by: Rouven Czerwinski --- arch/arm/mach-imx/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-imx/Kconfig

[PATCH 05/26] i.MX: HABv4: extend support to i.MX8M SoCs

2023-10-10 Thread Marco Felsch
with the i.MX8MQ except for the DIR_BT_DIS fuse. Signed-off-by: Rouven Czerwinski [m.fel...@pengutronix.de: adapt commit message] [m.fel...@pengutronix.de: integrate review feedback] Signed-off-by: Marco Felsch --- drivers/hab/hab.c | 6 +- drivers/hab/habv4.c | 26

[PATCH 10/26] ARM: boards: i.MX8M: add HAB image support

2023-10-10 Thread Marco Felsch
From: Rouven Czerwinski This adds the habv4-imx8-gencsf.h header to include HAB image commands which are enabled if CONFIG_HABV4 is enabled. Signed-off-by: Rouven Czerwinski [m.fel...@pengutronix.de: split commit] Signed-off-by: Marco Felsch --- arch/arm/boards/nxp-imx8mm-evk/flash-header

[PATCH 11/26] ARM: i.MX8M: add flexspi-imx8m{m,p}-cfg.h header

2023-10-10 Thread Marco Felsch
Add dedicated configuration headers which guard the flexspi_* options like it is done for the HABV4 configuration block to be more user-friendly. Signed-off-by: Marco Felsch --- include/mach/imx/flexspi-imx8mm-cfg.h | 10 ++ include/mach/imx/flexspi-imx8mp-cfg.h | 10 ++ 2 files

Re: [PATCH 2/2] HAB: extend fuse information with i.MX8M

2023-10-03 Thread Marco Felsch
Hi Ahmad, On 23-10-02, Ahmad Fatoum wrote: > From: Rouven Czerwinski > > The i.MX8M family of processors moved the SEC_CONFIG_1 fuse to a > different location. Extend the hab driver with the new location and take > care of the DIR_BT_DIS fuse which only needs to be burned on i.MX8MQ. > >

Re: [PATCH 2/4] ARM: dma: define DMA_ALIGNMENT instead of defining dma_alloc

2023-09-21 Thread Marco Felsch
> > Signed-off-by: Ahmad Fatoum feel free to add my r-b for the whole series. Reviewed-by: Marco Felsch > --- > arch/arm/include/asm/dma.h | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/arch/arm/include/asm/dma.h b/arch/arm/inclu

Re: [PATCH] regulator: replace _internal suffix by _rdev

2023-09-20 Thread Marco Felsch
On 23-09-20, Sascha Hauer wrote: > Rename functions to better align with the Linux Kernel. Thanks a lot. > Signed-off-by: Sascha Hauer Reviewed-by: Marco Felsch

Re: [PATCH 1/2] net: phy: Add phy_(set|clear)_bits_mmd()

2023-09-20 Thread Marco Felsch
On 23-09-20, Sascha Hauer wrote: > Provide phy_set_bits_mmd() and phy_clear_bits() for easier code adoption > from the kernel. > > Signed-off-by: Sascha Hauer Reviewed-by: Marco Felsch > --- > include/linux/phy.h | 28 > 1 file changed, 28 in

Re: [PATCH 10/11] regulator: drop struct regulator_dev::supply_name

2023-09-20 Thread Marco Felsch
On 23-09-20, Sascha Hauer wrote: > The supply name can be set in struct regulator_desc, no need to have > it in struct regulator_dev also, so drop it there. > > Signed-off-by: Sascha Hauer Reviewed-by: Marco Felsch

Re: [PATCH 09/11] regulator: Set initial voltage

2023-09-20 Thread Marco Felsch
On 23-09-20, Sascha Hauer wrote: > When voltage constraints are given in the device tree then we should > set the regulator to a valid voltage before enabling it. Without it > we can end up with invalid voltages. > > Signed-off-by: Sascha Hauer Reviewed-by: Marco Felsch

Re: [PATCH 08/11] regulator: register regulator as last step in of_regulator_register()

2023-09-20 Thread Marco Felsch
On 23-09-20, Sascha Hauer wrote: > In of_regulator_register() call __regulator_register as last step after > all fields have been initialized. This was not possible before as > __regulator_register() returned the struct regulator_internal * which > contained the remaining fields. Now that struct

Re: [PATCH 07/11] regulator: stpmic1: add .supply_name

2023-09-20 Thread Marco Felsch
On 23-09-20, Sascha Hauer wrote: > Add .supply_name to the regulator descriptors, otherwise the supplies > are never enabled. > > Signed-off-by: Sascha Hauer Reviewed-by: Marco Felsch

Re: [PATCH 06/11] regulator: stpmic1: add .get_voltage_sel

2023-09-20 Thread Marco Felsch
On 23-09-20, Sascha Hauer wrote: > To get the current voltage from the regulators the .get_voltage_sel > callback is needed. Initialize it to the correct function. > > Signed-off-by: Sascha Hauer Reviewed-by: Marco Felsch

Re: [PATCH 05/11] regulator: Add missing cases in regulator_map_voltage()

2023-09-20 Thread Marco Felsch
On 23-09-20, Sascha Hauer wrote: > regulator_map_voltage() misses to handle some cases, sync this with the > kernel. > > Signed-off-by: Sascha Hauer Reviewed-by: Marco Felsch

Re: [PATCH 04/11] regulator: add regulator_get_voltage_internal()

2023-09-20 Thread Marco Felsch
On 23-09-20, Sascha Hauer wrote: > regulator_get_voltage() works on struct regulator * which may not always > be available internally, so add a regulator_get_voltage_internal() and > use it from regulator_get_voltage(). > > Signed-off-by: Sascha Hauer > --- > drivers/regulator/core.c | 52

Re: [PATCH 03/11] regulator: introduce regulator logging functions.

2023-09-20 Thread Marco Felsch
a Hauer Reviewed-by: Marco Felsch > --- > drivers/regulator/core.c | 12 ++-- > include/regulator.h | 13 + > 2 files changed, 23 insertions(+), 2 deletions(-) > > diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c > index 41a337

Re: [PATCH 02/11] regulator: merge struct regulator_internal fields into struct regulator_dev

2023-09-20 Thread Marco Felsch
ri link so that we can't get a > rdev from a ri pointer. We could add that link, but instead make the > whole stuff a bit easier by just merging everything from struct > regulator_internal to struct regulator_dev. This also aligns it with Linux :) > Signed-off-by: Sascha Hau

Re: [PATCH 01/11] regulator: rename variable rd to rdev

2023-09-20 Thread Marco Felsch
On 23-09-20, Sascha Hauer wrote: > the struct regulator_dev * variable is mostly named 'rdev', but > sometimes 'rd' is used. Rename to 'rdev' consistently. > > Signed-off-by: Sascha Hauer Reviewed-by: Marco Felsch > --- > drivers/regulator/core.c | 32 ---

Re: [PATCH 02/11] regulator: merge struct regulator_internal fields into struct regulator_dev

2023-09-20 Thread Marco Felsch
On 23-09-20, Sascha Hauer wrote: > On Wed, Sep 20, 2023 at 12:52:03PM +0200, Marco Felsch wrote: > > Hi Sascha, > > > > On 23-09-20, Sascha Hauer wrote: > > > Each struct regulator_dev instance has a struct regulator_internal > > > associated with it.

Re: [PATCH 02/11] regulator: merge struct regulator_internal fields into struct regulator_dev

2023-09-20 Thread Marco Felsch
Hi Sascha, On 23-09-20, Sascha Hauer wrote: > Each struct regulator_dev instance has a struct regulator_internal > associated with it. The idea was that core internal fields are seen > by the core only. In the end this is more confusing than helpful. We > have a ri->rdev link, but no rdev->ri

Re: [PATCH v2] aiodev: imx_thermal: fix breakage after device tree sync

2023-09-11 Thread Marco Felsch
v5.8-rc1") > Signed-off-by: Ahmad Fatoum Reviewed-by: Marco Felsch

Re: [PATCH master] aiodev: imx_thermal: fix breakage after device tree sync

2023-09-11 Thread Marco Felsch
On 23-09-11, Ahmad Fatoum wrote: > On 11.09.23 14:35, Marco Felsch wrote: > > On 23-09-11, Ahmad Fatoum wrote: > >> fsl,tempmon-data is a deprecated property that has been replaced > >> upstream by a NVMEM cell pointing at the calibration value and so > >> made

Re: [PATCH] Documentation: dt-bindings: ocotp: deprecate barebox,provide-mac-address

2023-09-11 Thread Marco Felsch
On 23-09-11, Ahmad Fatoum wrote: > On 11.09.23 14:29, Marco Felsch wrote: > > On 23-09-11, Ahmad Fatoum wrote: > >> While we'll continue to support barebox,provide-mac-address, new boards > >> should prefer using the upstream NVMEM binding for describing the MAC

Re: [PATCH master] aiodev: imx_thermal: fix breakage after device tree sync

2023-09-11 Thread Marco Felsch
On 23-09-11, Ahmad Fatoum wrote: > fsl,tempmon-data is a deprecated property that has been replaced > upstream by a NVMEM cell pointing at the calibration value and so > made it into barebox breaking the driver. > > Switch to using the new property to fix the regression. The Linux driver code

Re: [PATCH] Documentation: dt-bindings: ocotp: deprecate barebox,provide-mac-address

2023-09-11 Thread Marco Felsch
On 23-09-11, Ahmad Fatoum wrote: > While we'll continue to support barebox,provide-mac-address, new boards > should prefer using the upstream NVMEM binding for describing the MAC address. > > Add an example to the documentation. > > Signed-off-by: Ahmad Fatoum > --- >

Re: [PATCH] ARM: i.MX8M: don't print TF-A version

2023-09-11 Thread Marco Felsch
f-by: Ahmad Fatoum Reviewed-by: Marco Felsch > --- > arch/arm/mach-imx/imx8m.c | 11 --- > 1 file changed, 11 deletions(-) > > diff --git a/arch/arm/mach-imx/imx8m.c b/arch/arm/mach-imx/imx8m.c > index af44b089e08a..c7c799c64bc4 100644 > --- a/arch/arm/mach-imx/im

Re: [PATCH master 1/2] clk: implement clk_get_optional helper

2023-09-05 Thread Marco Felsch
> > Signed-off-by: Ahmad Fatoum Reviewed-by: Marco Felsch

Re: [PATCH master 2/2] pwm: imx: enable clocks during PWM register accesses

2023-09-05 Thread Marco Felsch
; This fixes system hang during PWM access on i.MX8M and presumably i.MX7. > > Reported-by: Bastian Krause > Signed-off-by: Ahmad Fatoum Reviewed-by: Marco Felsch

[PATCH v3] ARM: i.MX8M: esdctl: split memory banks for devices with >4G

2023-09-05 Thread Marco Felsch
bled which is configured for sizes <=4G. Split the memory space into two memory banks: "ram0" and "ram1" to fix this issue. Signed-off-by: Marco Felsch --- Changelog: v3: - add comment - add ifdef to fix 32bit compilation warning v2: - drop add_mem() usage and use arm_add_mem_device(

Re: [PATCH v2] ARM: i.MX8M: esdctl: split memory banks for devices with >4G

2023-09-05 Thread Marco Felsch
On 23-09-04, Sascha Hauer wrote: > Hi Marco, > > On Thu, Aug 31, 2023 at 04:47:24PM +0200, Marco Felsch wrote: > > At the moment the whole available memory is added to one single memory > > bank "ram0". This can cause barebox chainload issues on devices with a

Re: [PATCH v2] ARM: i.MX8M: esdctl: split memory banks for devices with >4G

2023-09-05 Thread Marco Felsch
On 23-09-04, Ahmad Fatoum wrote: > On 31.08.23 16:47, Marco Felsch wrote: > > At the moment the whole available memory is added to one single memory > > bank "ram0". This can cause barebox chainload issues on devices with a > > huge amount of memory like the

[PATCH v2] ARM: i.MX8M: esdctl: split memory banks for devices with >4G

2023-08-31 Thread Marco Felsch
bled which is configured for sizes <=4G. Split the memory space into two memory banks: "ram0" and "ram1" to fix this issue. Signed-off-by: Marco Felsch --- v2: - drop add_mem() usage and use arm_add_mem_device() directly arch/arm/mach-imx/esdctl.c | 23 +++ 1

Re: [PATCH 2/2] ARM: i.MX8M: esdctl: split memory banks for devices with >4G

2023-08-31 Thread Marco Felsch
On 23-08-31, Lucas Stach wrote: > Am Donnerstag, dem 31.08.2023 um 15:05 +0200 schrieb Marco Felsch: > > At the moment the whole available memory is added to one single memory > > bank "ram0". This can cause barebox chainload issues on devices with a > > huge amount

[PATCH 2/2] ARM: i.MX8M: esdctl: split memory banks for devices with >4G

2023-08-31 Thread Marco Felsch
bled which is configured for sizes <=4G. Split the memory space into two memory banks: "ram0" and "ram1" to fix this issue. Signed-off-by: Marco Felsch --- arch/arm/mach-imx/esdctl.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach

[PATCH 1/2] ARM: i.MX: esdctl: add force_split option to add_mem

2023-08-31 Thread Marco Felsch
Currently add_mem() tries to merge the memory banks if they are continuous. Add a option to avoid this merge which is not always useful e.g. for devices with memory > 4G. Signed-off-by: Marco Felsch --- arch/arm/mach-imx/esdctl.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deleti

[PATCH 1/4] ARM: boards: polyhex-debix: fix RGMII pin setup

2023-08-29 Thread Marco Felsch
On the Debix SBC the EQOS interface is used as primary interface, the FEC pins are routed to the extension header. On the other hand the Debix SoM/Baseboard combination both interfaces are used. So fix the RGMII pin setup by adding the EQOS pin as well and keep the FEC. Signed-off-by: Marco

[PATCH 3/4] ARM: boards: polyhex-debix: add support to read MAC addresses

2023-08-29 Thread Marco Felsch
For the Debix SoM/Baseboard combination the MAC addresses are stored on a baseboard EEPROM in ASCII format. This commit adds the support to read the MAC addresses from the EEPROM and set it accordingly. Signed-off-by: Marco Felsch --- arch/arm/boards/polyhex-debix/board.c | 66

[PATCH 4/4] ARM: dts: imx8mp-debix-som-a-bmb-08-upstream: sync with mainlined kernel version

2023-08-29 Thread Marco Felsch
Sync the *-upstream.dts(i) versions with the mainlined kernel version [1] available with v6.6. [1] https://lore.kernel.org/all/20230809071026.3546605-4-m.fel...@pengutronix.de/ Signed-off-by: Marco Felsch --- .../imx8mp-debix-som-a-bmb-08-upstream.dts| 126 -- arch/arm/dts

[PATCH 2/4] ARM: boards: polyhex-debix: add SoM/Baseboard combination compatible

2023-08-29 Thread Marco Felsch
/lore.kernel.org/all/20230809071026.3546605-3-m.fel...@pengutronix.de/ Signed-off-by: Marco Felsch --- arch/arm/boards/polyhex-debix/board.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boards/polyhex-debix/board.c b/arch/arm/boards/polyhex-debix/board.c index 46cb18c5889c..f81666ce0c93 100644 -

Re: [PATCH] mci: sdhci: don't hang indefinitely waiting for DMA completion

2023-08-25 Thread Marco Felsch
ate any further communication with the card > will work, but at least, the system isn't stuck and the shell can be > reached. The reset is done on the off-chance that the DMA would've completed > after the 10s and corrupted memory if not disabled. > > Signed-off-by: Ahmad Fatoum Reviewed-by: Marco Felsch

Re: [PATCH master 1/3] envfs: fix defaultenv_append_directory macro definition

2023-08-17 Thread Marco Felsch
On 23-08-17, Ahmad Fatoum wrote: > defaultenv_append_directory is called as if it were a function and the > trailing semicolon can break parse of if-else statements. Wrap in do { } > while (0) to avoid this. > > Signed-off-by: Ahmad Fatoum Reviewed-by: Marco Felsch

[PATCH v2 07/11] net: phy: replace phy_{write,read,modify}_mmd_indirect with phy_{write,read,modify}_mmd

2023-08-11 Thread Marco Felsch
Make use of the phy_{write,read,modify}_mmd API to align the code with Linux. This also fixes the r8169 driver since this driver did not adapt the parameters while porting from Linux. Signed-off-by: Marco Felsch --- v2: - replace phy_*_mmd_indirect with phy_*_mmd arch/arm/boards/datamodul-edm

[PATCH v2 10/11] net: phy: at803x: add disable hibernation mode support

2023-08-11 Thread Marco Felsch
Ys. | | Signed-off-by: Wei Fang | Reviewed-by: Andrew Lunn | Signed-off-by: Jakub Kicinski The commit is adapted to always disable the hibernation mode instead of making it optional since bootloaders require no special power optimization. Signed-off-by: Marco Felsch ---

[PATCH v2 04/11] net: phy: mmd_phy_indirect: align parameters with Linux

2023-08-11 Thread Marco Felsch
Switch the prtad and devad to align it with Linux to make porting from Linux less error prone. While on it rename prtad with regnum. Signed-off-by: Marco Felsch --- v2: - new patch drivers/net/phy/phy.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net

[PATCH v2 05/11] net: phy: add phydev_{err,err_probe,info,warn,dbg} macros

2023-08-11 Thread Marco Felsch
Import Linux macros to make it easier to port drivers to barebox. Signed-off-by: Marco Felsch Reviewed-by: Ahmad Fatoum --- v2: - add afa's rb include/linux/phy.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/include/linux/phy.h b/include/linux/phy.h index fee3868d38f9

[PATCH v2 01/11] ARM: boards: make use of MDIO_MMD register defines

2023-08-11 Thread Marco Felsch
Make use of the register definition instead of having magic numbers. No functional change. Signed-off-by: Marco Felsch Reviewed-by: Ahmad Fatoum --- v2: - added afa's rb arch/arm/boards/datamodul-edm-qmx6/board.c | 7 --- arch/arm/boards/embest-marsboard/board.c | 7 --- arch

[PATCH v2 11/11] net: phy: at803x: disable extended next page bit

2023-08-11 Thread Marco Felsch
to mainline kernels by rmk. | | Signed-off-by: Russell King | Reviewed-by: Andrew Lunn | Link: https://lore.kernel.org/r/e1kzsdb-000417...@rmk-pc.armlinux.org.uk | Signed-off-by: Jakub Kicinski Signed-off-by: Marco Felsch Reviewed-by: Ahmad Fatoum --- v2 - add afa's rb

[PATCH v2 08/11] net: phy: add deprecation warning to phy_{read,write,modify}_mmd_indirect

2023-08-11 Thread Marco Felsch
Add deprecation warnings and point to the new APIs user should use instead. Signed-off-by: Marco Felsch --- v2: - new patch drivers/net/phy/phy.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index 4cabb436e461..ad02732ff93b 100644

[PATCH v2 06/11] net: phy: import phy_{read,write,modify}_mmd helpers from Linux

2023-08-11 Thread Marco Felsch
which is ported from Linux as well. Signed-off-by: Marco Felsch --- v2: - new patch drivers/net/phy/phy.c | 109 ++ include/linux/phy.h | 10 2 files changed, 119 insertions(+) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index

[PATCH v2 03/11] net: phy: fix struct member comments

2023-08-11 Thread Marco Felsch
Nothing special just add the missing @ which is useful for the documentation generation. Signed-off-by: Marco Felsch --- v2: - new patch include/linux/phy.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/include/linux/phy.h b/include/linux/phy.h index

[PATCH v2 02/11] net: phy: micrel: make use of MDIO_MMD register defines

2023-08-11 Thread Marco Felsch
Make use of the register definition instead of having magic numbers. No functional change. Signed-off-by: Marco Felsch Reviewed-by: Ahmad Fatoum --- v2: - added afa's rb drivers/net/phy/micrel.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/net/phy

[PATCH v2 09/11] net: phy: at803x: disable SmartEEE

2023-08-11 Thread Marco Felsch
The SmartEEE functionality can cause strange connection issues. Disable it unconditional and leave it to the OS to enable it again. Signed-off-by: Marco Felsch --- v2: - always disable smarteee (afa) - adapt commit message drivers/net/phy/at803x.c | 19 ++- 1 file changed, 18

Re: [PATCH] of: of_net: add support to parse ASCII encoded mac-addresses

2023-08-08 Thread Marco Felsch
On 23-08-08, Ahmad Fatoum wrote: > Hello Marco, > > On 08.08.23 11:46, Marco Felsch wrote: > > Hi Ahmad, > > > > On 23-08-08, Ahmad Fatoum wrote: > >> Hello Marco, > >> > >> On 07.08.23 19:07, Marco Felsch wrote: > >>> Som

Re: [PATCH] of: of_net: add support to parse ASCII encoded mac-addresses

2023-08-08 Thread Marco Felsch
Hi Ahmad, On 23-08-08, Ahmad Fatoum wrote: > Hello Marco, > > On 07.08.23 19:07, Marco Felsch wrote: > > Some vendors like Polyhex store the MAC address ASCII encoded instead of > > using the plain 6-byte MAC address. This commit adds the support to > > decode th

Re: [PATCH] of: of_net: add support to parse ASCII encoded mac-addresses

2023-08-08 Thread Marco Felsch
Hi Sascha, On 23-08-08, Sascha Hauer wrote: > On Mon, Aug 07, 2023 at 07:07:43PM +0200, Marco Felsch wrote: > > Some vendors like Polyhex store the MAC address ASCII encoded instead of > > using the plain 6-byte MAC address. This commit adds the support to > > decode the 12-b

[PATCH] of: of_net: add support to parse ASCII encoded mac-addresses

2023-08-07 Thread Marco Felsch
Some vendors like Polyhex store the MAC address ASCII encoded instead of using the plain 6-byte MAC address. This commit adds the support to decode the 12-byte ASCII encoded MAC addresses. Signed-off-by: Marco Felsch --- drivers/of/of_net.c | 19 +++ 1 file changed, 19

Re: [PATCH] bootm: export bootm_set_verify_mode

2023-07-27 Thread Marco Felsch
den by built-in environment. > > Signed-off-by: Ahmad Fatoum Reviewed-by: Marco Felsch > --- > common/bootm.c | 5 + > include/bootm.h | 1 + > 2 files changed, 6 insertions(+) > > diff --git a/common/bootm.c b/common/bootm.c > index 791d6b8fbbf1..c46b00a86f6

Re: [PATCH 1/4] commands: hab: check for error in imx_hab_device_locked_down

2023-07-27 Thread Marco Felsch
e to add my r-b for the whole series. Reviewed-by: Marco Felsch

<    1   2   3   4   5   6   7   8   >