Re: [Barry-devel] [Patch]GUI - User Experience enhancement

2009-07-07 Thread Ryan Li
I agree with this, but I don't know what others think? Ryan Jason Thomas wrote: > I have a suggestion, the box that pops up when the backup is complete is > annoying. > > I work with multiple work spaces and I start a backup on one, switch to > another and keep working and the pop up is lost behi

Re: [Barry-devel] [Patch]GUI - User Experience enhancement

2009-07-07 Thread Ryan Li
Hi Chris, 1) The StatusBarHandler class is a great idea. It should be a standalone class, either BackupWindow.h or its own header. Also I notice that StatusBarHandler gets rid of the call to m_pStatusBar->show_now()... any thoughts on tha

Re: [Barry-devel] [Patch]GUI - User Experience enhancement

2009-07-07 Thread Chris Frey
I agree with this idea too. Either put the message in the status bar, or make the popup window only on top of the Barrybackup window somehow, so it doesn't get disconnected from the application. (I don't know how to do this offhand. Status bar is probably easier. :-) Maybe if we go the status b

Re: [Barry-devel] Barry tethering chat script for China Mobile

2009-07-07 Thread Chris Frey
Hi Juvenn, In looking at the modemtest logs, it seems you are using ipmodem mode, but in looking at the pppob log, it seems you are using serial mode. Are you using the pppob -s switch in your configuration? Does it work differently with or without that switch? - Chris On Sun, Jul 05, 2009 at

Re: [Barry-devel] [Patch]GUI - User Experience enhancement

2009-07-07 Thread Chris Frey
On Tue, Jul 07, 2009 at 09:18:13PM +0800, Ryan Li wrote: > Yeah, I moved it to BackupWindow.h. First thought was to util.h, but > found that it could only be used in BackupWindow. > I saw that show_now() was not used in some situations, and without it > everything worked fine. Now it's back. :-)

Re: [Barry-devel] [PATCH] Phone duplication after synchronization

2009-07-07 Thread Chris Frey
On Sat, Jul 04, 2009 at 08:07:39AM +0200, Nicolas wrote: > Hi, > > To avoid a little bug. > > Indeed, in the code you have : > if (...) { > } > if (...) { > } > ... > > But, If you define a home fax number, you have : > type == fax > AND > type == home I don't think the if/else is the correct