[PATCH] b43: Fix IRQ sync for SDIO

2009-09-11 Thread Michael Buesch
synchronize_irq is meaningless for SDIO. sdio_release_irq will sync the IRQ thread for us. Signed-off-by: Michael Buesch --- Index: wireless-testing/drivers/net/wireless/b43/main.c === --- wireless-testing.orig/drivers/net

[PATCH] b43: Rewrite suspend/resume code

2009-09-11 Thread Michael Buesch
This removes most of the b43 suspend/resume code (it's handled by mac80211) and moves the registration of devices to the attachment phase. This is required, because we must not register/unregister devices on suspend/resume. Signed-off-by: Michael Buesch --- Nobody replied to my RFT reques

[PATCH] b43: Fix resume failure

2009-09-11 Thread Michael Buesch
take a few milliseconds. So we don't really need to be interruptible. Signed-off-by: Michael Buesch --- Index: wireless-testing/drivers/net/wireless/b43/main.c === --- wireless-testing.orig/drivers/net/wireless/b43/main.c

[PATCH] ssb: Disable verbose SDIO coreswitch

2009-09-11 Thread Michael Buesch
Disable SDIO coreswitch debugging. Signed-off-by: Michael Buesch --- Index: wireless-testing/drivers/ssb/sdio.c === --- wireless-testing.orig/drivers/ssb/sdio.c2009-09-08 19:29:16.0 +0200 +++ wireless-testing/drivers

[PATCH] b43: Fix SDIO interrupt handler deadlock

2009-09-11 Thread Michael Buesch
We need to release the SDIO host before locking the driver mutex. Signed-off-by: Michael Buesch --- Index: wireless-testing/drivers/net/wireless/b43/main.c === --- wireless-testing.orig/drivers/net/wireless/b43/main.c 2009

Re: [PATCH] b43: Add Soft-MAC SDIO device support

2009-09-11 Thread Michael Buesch
On Thursday 10 September 2009 23:23:19 Gábor Stefanik wrote: > On Thu, Sep 10, 2009 at 7:34 PM, Michael Buesch wrote: > > From: Albert Herranz > > > > This adds support for Soft-MAC SDIO devices to b43. > > The driver still lacks some fixes for SDIO devices, so i

[PATCH RFC] b43: Always use block-I/O for PIO data register

2009-09-10 Thread Michael Buesch
I think this should fix the issue with the swapped PIO data register. I think the engineers somehow hardwired the register to the platform architecture (That's also why setting the MACCTL BE bit fails). So we simply always use block-I/O on those registers. That should fix the issue, as block-I/O do

Re: [PATCH] b43: Force-wake queues on init

2009-09-10 Thread Michael Buesch
On Thursday 10 September 2009 20:34:36 Luis R. Rodriguez wrote: > On Thu, Sep 10, 2009 at 11:31 AM, Michael Buesch wrote: > > Force wake the mac80211 queues on init. > > Under rare circumstances they may be stopped, if a DMA error or > > something else causes a device re

[PATCH] b43: Force-wake queues on init

2009-09-10 Thread Michael Buesch
Force wake the mac80211 queues on init. Under rare circumstances they may be stopped, if a DMA error or something else causes a device reset while a queue was stopped. Signed-off-by: Michael Buesch --- Index: wireless-testing/drivers/net/wireless/b43/main.c

[PATCH] b43: Do not use _irqsafe callbacks

2009-09-10 Thread Michael Buesch
We don't need to call the irqsafe callbacks. Signed-off-by: Michael Buesch --- Apply on top the other patches. Index: wireless-testing/drivers/net/wireless/b43/dma.c === --- wireless-testing.orig/drivers/net/wireless/b43/

[PATCH] b43: Add Soft-MAC SDIO device support

2009-09-10 Thread Michael Buesch
From: Albert Herranz This adds support for Soft-MAC SDIO devices to b43. The driver still lacks some fixes for SDIO devices, so it's currently marked as BROKEN. Signed-off-by: Albert Herranz Signed-off-by: Michael Buesch --- Depends on the SSB SDIO patch. Index: wireless-testing/dr

Re: b43 dma error

2009-09-08 Thread Michael Buesch
On Tuesday 08 September 2009 20:06:49 Gábor Stefanik wrote: > On Tue, Sep 8, 2009 at 7:50 PM, John Daiker wrote: > > On 09/08/2009 07:54 AM, Larry Finger wrote: > >> > >> Michael Buesch wrote: > >>> > >>> On Tuesday 08 September 2009 15:47:3

Re: b43 dma error

2009-09-08 Thread Michael Buesch
On Tuesday 08 September 2009 19:50:25 John Daiker wrote: > On 09/08/2009 07:54 AM, Larry Finger wrote: > > Michael Buesch wrote: > >> On Tuesday 08 September 2009 15:47:32 Dave Young wrote: > >>> I tested wireless-testing b43 driver, but got "Fatal DMA er

[PATCH] b44/b43/b43legacy: Fix switch warnings introduced by SSB-SDIO

2009-09-08 Thread Michael Buesch
This fixes some gcc warnings for switch statements. Signed-off-by: Michael Buesch Index: wireless-testing/drivers/net/b44.c === --- wireless-testing.orig/drivers/net/b44.c 2009-09-08 19:21:34.0 +0200 +++ wireless

[PATCH] ssb: Implement SDIO host bus support

2009-09-08 Thread Michael Buesch
: Michael Buesch --- drivers/ssb/Kconfig | 14 + drivers/ssb/Makefile |1 + drivers/ssb/main.c| 58 +- drivers/ssb/scan.c| 11 + drivers/ssb/sdio.c| 611 + drivers/ssb/ssb_private.h | 40 +++ include

Re: b43 dma error

2009-09-08 Thread Michael Buesch
On Tuesday 08 September 2009 15:47:32 Dave Young wrote: > I tested wireless-testing b43 driver, but got "Fatal DMA error" > then the controller keep restarting... > > Please tell what I can provide or test, Thanks. Is this a regression? If so, please bisect. -- Greetings, Michael. _

Re: [PATCH RFC 1/3] sdio: recognize io card without powercycle

2009-09-07 Thread Michael Buesch
On Monday 07 September 2009 20:59:45 Chris Ball wrote: > Hi Michael, > >> Please submit this to the SDIO maintainer. > > MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND SDIO SUBSYSTEM > S: Orphan > L: linux-...@vger.kernel.org > F: drivers/mmc/ > F: include/linux/mmc/ > > So, these patche

Re: [PATCH RFC 3/3] ssb: add support for ssb over sdio

2009-09-07 Thread Michael Buesch
On Monday 07 September 2009 20:47:27 Albert Herranz wrote: > > (next time please inline the patch) Thanks a lot for the patch. I'll do more cleanups on it and submit it to john later. -- Greetings, Michael. ___ Bcm43xx-dev mailing list Bcm43x

Re: [PATCH RFC 2/3] sdio: pass unknown cis tuples to sdio drivers

2009-09-07 Thread Michael Buesch
On Monday 07 September 2009 20:47:12 Albert Herranz wrote: > > Please also submit to the SDIO maintainer. -- Greetings, Michael. ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev

Re: [PATCH RFC 1/3] sdio: recognize io card without powercycle

2009-09-07 Thread Michael Buesch
On Monday 07 September 2009 20:46:58 Albert Herranz wrote: > > Please submit this to the SDIO maintainer. -- Greetings, Michael. ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev

Re: [PATCH 1/2] [b43-fwcutter] Firmware FW14 and FW15 are the same.

2009-09-06 Thread Michael Buesch
On Sunday 06 September 2009 23:33:27 Hauke Mehrtens wrote: > The extracted files have the same md5sum. > The package broadcom-wl-4.178.10.4.tar.bz2 was extracted from > wrt610n_v1.00.00.018_us.tgz as the package from the Linksys is not > available any more. Changed the link to the > broadcom-wl-4.1

Re: [PATCH] b43: PCMCIA is not experimental anymore

2009-09-06 Thread Michael Buesch
On Sunday 06 September 2009 20:42:00 Gábor Stefanik wrote: > On Sun, Sep 6, 2009 at 2:49 PM, Michael Buesch wrote: > > PCMCIA support works well and is not experimental anymore. > > > > Signed-off-by: Michael Buesch > > > > --- > >  drivers/net/wireless/b43/

[COMPAT PATCH] b43: Threaded interrupts wrapper

2009-09-06 Thread Michael Buesch
A patch converting b43 to threaded interrupts will be merged soon. This will completely break b43 on compat-wireless, because working threaded IRQ support requires kernel >= 2.6.31. This patchset implements a workqueue based workaround wrapper, which works on kernels with and without threaded IRQ

[PATCH] b43: Fix sparse warning in hw-tkip code

2009-09-06 Thread Michael Buesch
restricted unsigned short [usertype] The code should work correctly with and without this patch applied. Signed-off-by: Michael Buesch Index: wireless-testing/drivers/net/wireless/b43/xmit.c === --- wireless-testing.orig/drivers/net

[PATCH] b43: Really disable QoS, if requested

2009-09-06 Thread Michael Buesch
ff-by: Michael Buesch Index: wireless-testing/drivers/net/wireless/b43/main.c === --- wireless-testing.orig/drivers/net/wireless/b43/main.c 2009-09-06 15:37:47.0 +0200 +++ wireless-testing/drivers/net/wireless/b43/main.c20

[PATCH] b43: PCMCIA is not experimental anymore

2009-09-06 Thread Michael Buesch
PCMCIA support works well and is not experimental anymore. Signed-off-by: Michael Buesch --- drivers/net/wireless/b43/Kconfig |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- wireless-testing.orig/drivers/net/wireless/b43/Kconfig +++ wireless-testing/drivers/net/wireless/b43

[PATCH RFT] b43: Fix suspend/resume

2009-09-06 Thread Michael Buesch
ss-testing/20090906-1240/mb-wl-20090906-1240.tar.bz2 (Apply up to including 006-b43-fix-suspend.patch) Signed-off-by: Michael Buesch Index: wireless-testing/drivers/net/wireless/b43/main.c === --- wireless-testing.orig/drivers/net/wi

[PATCH 5/5] b43: remove SHM spinlock

2009-09-04 Thread Michael Buesch
This removes the SHM spinlock. SHM is protected by wl->mutex. Signed-off-by: Michael Buesch Index: wireless-testing/drivers/net/wireless/b43/b43.h === --- wireless-testing.orig/drivers/net/wireless/b43/b43.h2009-09-04

[PATCH 3/5] b43: Remove DMA/PIO queue locks

2009-09-04 Thread Michael Buesch
This removes the DMA/PIO queue locks. Locking is handled by wl->mutex now. Signed-off-by: Michael Buesch Index: wireless-testing/drivers/net/wireless/b43/dma.c === --- wireless-testing.orig/drivers/net/wireless/b43/dm

[PATCH 4/5] b43: Remove PIO RX workqueue

2009-09-04 Thread Michael Buesch
This removes the PIO RX work. It's not needed anymore, because we can sleep in the threaded interrupt handler. Signed-off-by: Michael Buesch Index: wireless-testing/drivers/net/wireless/b43/pio.c === --- wireless-testing

[PATCH 2/5] b43: Remove TX spinlock

2009-09-04 Thread Michael Buesch
This removes the TX spinlock and defers TX to a workqueue to allow locking wl->mutex instead and to allow sleeping for register accesses. Signed-off-by: Michael Buesch Index: wireless-testing/drivers/net/wireless/b43/b4

[PATCH 1/5] b43: Use a threaded IRQ handler

2009-09-04 Thread Michael Buesch
-off-by: Michael Buesch Index: wireless-testing/drivers/net/wireless/b43/b43.h === --- wireless-testing.orig/drivers/net/wireless/b43/b43.h2009-09-04 22:15:30.0 +0200 +++ wireless-testing/drivers/net/wireless/b43/b43.h

[PATCH 0/5] b43: Prepare driver for sleeping busses

2009-09-04 Thread Michael Buesch
This patchset is the first series to remove atomic sections from the b43 driver to allow running b43 on a slow bus like SDIO that needs to sleep for register accesses. -- Greetings, Michael. ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de http

Re: b43-fwcutter patch for new firmware versions (508.1107 and 508.102)

2009-09-04 Thread Michael Buesch
On Thursday 03 September 2009 23:37:31 Larry Finger wrote: > Daniel Lenski wrote: > > Larry, > > I agree on the ridiculously poor packaging... did I mention they're 1gb+ > > extracted? > > I didn't look at what is contained within that package, but we > certainly don't need it. > > > I have not f

Re: [PATCH v2] b43: LP-PHY: Begin implementing calibration & software RFKILL support

2009-09-01 Thread Michael Buesch
On Monday 31 August 2009 21:38:28 Gábor Stefanik wrote: > On Mon, Aug 31, 2009 at 9:17 PM, Michael Buesch wrote: > > On Monday 31 August 2009 19:53:31 John W. Linville wrote: > >> On Sun, Aug 30, 2009 at 05:55:40PM +0200, Michael Buesch wrote: > >> > On Sunday 30 Aug

Re: [PATCH v2] b43: LP-PHY: Begin implementing calibration & software RFKILL support

2009-08-31 Thread Michael Buesch
On Monday 31 August 2009 19:53:31 John W. Linville wrote: > On Sun, Aug 30, 2009 at 05:55:40PM +0200, Michael Buesch wrote: > > On Sunday 30 August 2009 17:10:23 Larry Finger wrote: > > > Michael Buesch wrote: > > > > On Sunday 30 August 2009 02:15:55 Gábor Stefani

Re: [PATCH v2] b43: LP-PHY: Begin implementing calibration & software RFKILL support

2009-08-30 Thread Michael Buesch
On Sunday 30 August 2009 17:10:23 Larry Finger wrote: > Michael Buesch wrote: > > On Sunday 30 August 2009 02:15:55 Gábor Stefanik wrote: > >> static void lpphy_pr41573_workaround(struct b43_wldev *dev) > >> { > >>struct b43_phy_lp *lpphy = dev->phy.l

Re: [PATCH v2] b43: LP-PHY: Begin implementing calibration & software RFKILL support

2009-08-30 Thread Michael Buesch
On Sunday 30 August 2009 02:15:55 Gábor Stefanik wrote: > static void lpphy_pr41573_workaround(struct b43_wldev *dev) > { > struct b43_phy_lp *lpphy = dev->phy.lp; > @@ -1357,28 +1488,440 @@ static void lpphy_pr41573_workaround(struct > b43_wldev *dev) > b43_lptab_read_bulk(d

Re: b43: LP-PHY: Fix TX gain tables

2009-08-28 Thread Michael Buesch
On Friday 28 August 2009 22:36:02 Gábor Stefanik wrote: > The rev1 2GHz and rev2 5GHz gain tables were incorrectly documented > on the specs originally. Update these gaintables to match the cor- > rected specs. > > Signed-off-by: Gábor Stefanik ack -- Greetings, Michael. __

Re: [PATCH] b43: Implement antenna diversity support for LP-PHY

2009-08-27 Thread Michael Buesch
On Thursday 27 August 2009 20:56:22 Gábor Stefanik wrote: > The A/G-PHY changes are fallout fixes from the enum change, > which in turn allows the LP-PHY code to be much simpler. > The antenna_to_phyctl change is a fix for a potential > existing bug that this patch may otherwise trigger. > > Signe

Re: [PATCH] b43: LP-PHY: Revert to the original PHY register write routine

2009-08-26 Thread Michael Buesch
On Wednesday 26 August 2009 23:38:48 Gábor Stefanik wrote: > From: root > > After some discussion on IRC about the PHY register write change, > I am not sure anymore if this is the right thing to do. > > Signed-off-by: Gábor Stefanik > --- > drivers/net/wireless/b43/phy_lp.c |3 ++- > 1 fi

Re: [PATCH] b43: Fix and update LP-PHY code

2009-08-26 Thread Michael Buesch
On Wednesday 26 August 2009 22:54:03 John W. Linville wrote: > On Wed, Aug 26, 2009 at 10:47:12PM +0200, Gábor Stefanik wrote: > > 2009/8/26 Michael Buesch : > > > And, everything in its own patch, please. I don't see a reason for > > > patching unrelated things

Re: [PATCH] b43: Fix and update LP-PHY code

2009-08-26 Thread Michael Buesch
On Wednesday 26 August 2009 22:47:12 Gábor Stefanik wrote: > 2009/8/26 Michael Buesch : > > On Wednesday 26 August 2009 20:51:25 Gábor Stefanik wrote: > >> -Fix a few nasty typos (b43_phy_* operations instead of b43_radio_*) > >>  in the channel tune routines. > &g

Re: [PATCH] b43: Remove scary message from LP-PHY's Kconfig

2009-08-26 Thread Michael Buesch
On Wednesday 26 August 2009 21:48:52 Gábor Stefanik wrote: > From: root Gábor Stefanik > > The most common LP-PHY device, BCM4312, is now fully functional. > So, no need to say "probably won't work for you" anymore. > It's also not "for debuggers and developers only", as it is > perfectly usable

Re: [PATCH] ssb: Implement PMU LDO control and use it in b43

2009-08-26 Thread Michael Buesch
On Wednesday 26 August 2009 20:51:26 Gábor Stefanik wrote: > Implement the "PMU LDO set voltage" and "PMU LDO PA ref enable" > functions, and use them during LP-PHY baseband init in b43. > > Signed-off-by: Gábor Stefanik ack -- Greetings, Michael. __

Re: [PATCH] b43: Fix and update LP-PHY code

2009-08-26 Thread Michael Buesch
On Wednesday 26 August 2009 20:51:25 Gábor Stefanik wrote: > -Fix a few nasty typos (b43_phy_* operations instead of b43_radio_*) > in the channel tune routines. > -Fix some typos & spec errors found by MMIO tracing. > -Optimize b43_phy_write & b43_phy_mask/set/maskset to use > only the minimal n

Re: [PATCH] b43: LP-PHY: Fix a few typos in the RC calibration code

2009-08-25 Thread Michael Buesch
On Tuesday 25 August 2009 16:17:48 Gábor Stefanik wrote: > The RC calibration code has some typos - fix them. > Also, make the default channel 7, as channel 1 is still > broken (only channels 7 and 8, and occasionally 9 work). > > Signed-off-by: Gábor Stefanik ack > --- > drivers/net/wireless/

Re: [PATCH] b43: LP-PHY: Fix and simplify Qdiv roundup

2009-08-25 Thread Michael Buesch
On Tuesday 25 August 2009 16:40:17 Gábor Stefanik wrote: > The Qdiv roundup routine is essentially a fixed-point > division algorithm, using only integer math. > However, the version in the specs had a major error > that has been recently fixed (a missing quotient++). > > Replace Qdiv roundup with

[RFT] b43: Get rid of spinlocks (version 2)

2009-08-23 Thread Michael Buesch
Hi, This patchset removes all spinlocks (except the LEDs lock for now) from b43. There are no known races or bugs added by this patchset. Please test it a lot, so we can ensure there are no regressions. It sometimes crashes for me in the lockdep code on module unload, but I'm not really sure whet

Re: [PATCH] b43-fwcutter: Update version since adding FW15

2009-08-22 Thread Michael Buesch
On Saturday 22 August 2009 06:22:04 Larry Finger wrote: > The program version should have been updated when FW15 was added. > > Signed-off-by: Larry Finger > --- I always do that just before releasing the new version. -- Greetings, Michael. ___ Bcm43

Re: [PATCH 1/2] fwcutter: mklist.py - Update to new library and skip some sections

2009-08-21 Thread Michael Buesch
On Thursday 20 August 2009 19:30:11 Larry Finger wrote: > Switch from the deprecated md5 library to hashlib. > > Detect the ro section that describes the firmware version, > print the address of the data, and and skip some ro sections > that are not of interest. > > Signed-off-by: Larry Finger

Re: [PATCH 2/2 V2] fwcutter: Add two new sources for 478.104 firmware

2009-08-21 Thread Michael Buesch
On Thursday 20 August 2009 23:51:38 Larry Finger wrote: > Add 2 new files with 478.104 firmware, which includes Rev 16. > > Signed-off-by: Larry Finger > --- > V2 - New files are FW15. Applied, thanks. -- Greetings, Michael. ___ Bcm43xx-dev mailing l

Re: [PATCH 2/2] fwcutter: Add two new sources for 478.104 firmware

2009-08-20 Thread Michael Buesch
On Thursday 20 August 2009 20:16:55 Larry Finger wrote: > Michael Buesch wrote: > > On Thursday 20 August 2009 19:32:43 Larry Finger wrote: > >> + .id = "FW14", > > > >> + .id = "FW14", > >

Re: [PATCH 2/2] fwcutter: Add two new sources for 478.104 firmware

2009-08-20 Thread Michael Buesch
On Thursday 20 August 2009 19:32:43 Larry Finger wrote: > + .id = "FW14", > + .id = "FW14", Is the extracted firmware exactly binary equal to the existing FW14? (We should not trust their version numbers and doublecheck this) -- Greetings, Michae

Re: [RESEND] [PATCH] b43 : remove old kidx API

2009-08-20 Thread Michael Buesch
On Thursday 20 August 2009 16:52:13 John W. Linville wrote: > On Mon, Jul 27, 2009 at 10:43:36PM +0200, gregor kowski wrote: > > Remove old kidx API. > > This simplify the code, and fix a potential key overflow. > > > > Signed-off-by: Gregor Kowski > > Is this patch still relevant? no -- Gre

Re: [PATCHv4] b43 add harware tkip

2009-08-20 Thread Michael Buesch
ump key, fix an issue with setting > random value on tkip key clear. > > This add hardware tkip for b43. > > Signed-off-by: Gregor Kowski Acked-by: Michael Buesch -- Greetings, Michael. ___ Bcm43xx-dev mailing list Bcm4

Re: [PATCH] b43: Fix sparse warnings

2009-08-18 Thread Michael Buesch
On Monday 17 August 2009 22:30:41 Pavel Roskin wrote: > On Sat, 2009-08-15 at 12:04 +0200, Michael Buesch wrote: > > > I still do not understand why it does complain about an _explicit_ > > truncation. > > That's simply stupid. If I program an explicit truncation I _

Re: [RFT] Threaded IRQ handlers for b43

2009-08-17 Thread Michael Buesch
On Sunday 16 August 2009 15:39:57 Michael Buesch wrote: > This request-for-test patch converts the b43 driver to use threaded > interrupt handlers. This is needed to support b43 on SDIO. But it also > simplifies the locking by removal of the wl->irq_lock spinlock. > > http:/

Re: [PATCH v2] b43: LP-PHY: Remove BROKEN from B43_PHY_LP

2009-08-16 Thread Michael Buesch
On Sunday 16 August 2009 20:22:41 Gábor Stefanik wrote: > Larry has reported success getting scan data with an LP-PHY device, > so it's probably time to release LP-PHY support for testing. > > Also disable 802.11a support for now, as 802.11a currently causes > the driver to panic on startup (NULL

Re: [PATCH] b43: LP-PHY: Update B2062 radio init with recent spec changes

2009-08-16 Thread Michael Buesch
On Sunday 16 August 2009 20:08:13 Gábor Stefanik wrote: > The spec for initializing the B2062 radio have changed recently, > update the code to match the changes. > > Signed-off-by: Gábor Stefanik ack > --- > drivers/net/wireless/b43/phy_lp.c |5 + > 1 files changed, 5 insertions(+), 0

Re: [PATCH] b43: LP-PHY: Remove BROKEN from B43_PHY_LP

2009-08-16 Thread Michael Buesch
On Sunday 16 August 2009 18:42:51 Gábor Stefanik wrote: > Larry has reported success getting scan data with an LP-PHY device, > so it's probably time to release LP-PHY support for testing. > > Also add a temporary BROKEN Kconfig symbol to disable 5GHz support, > as 5GHz currently causes the driver

Re: [PATCH] b43: LP-PHY: Fix a spec error in the B2062 channel switch routine

2009-08-16 Thread Michael Buesch
On Sunday 16 August 2009 15:32:40 Gábor Stefanik wrote: > The channel switch routine had a whole instruction missing. Add it. > > Signed-off-by: Gábor Stefanik ack > --- > drivers/net/wireless/b43/phy_lp.c |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/driver

Re: [PATCH] b43: LP-PHY: Update code for spec fixes, and fix a few typos

2009-08-16 Thread Michael Buesch
On Sunday 16 August 2009 15:26:37 Gábor Stefanik wrote: > A few typos have been discovered both in the specs in and our code. > This patch fixes them. > > Also use lpphy_op_switch_channel consistently, and make all callers > print its return value for easier debugging. > > Signed-off-by: Gábor St

[RFT] Threaded IRQ handlers for b43

2009-08-16 Thread Michael Buesch
This request-for-test patch converts the b43 driver to use threaded interrupt handlers. This is needed to support b43 on SDIO. But it also simplifies the locking by removal of the wl->irq_lock spinlock. http://bu3sch.de/patches/wireless-testing/20090816-1535/patches/002-b43-threaded-irq-handler.pa

Re: [PATCH v2] b43: LP-PHY: Update baseband init for recent spec changes

2009-08-15 Thread Michael Buesch
On Sunday 16 August 2009 01:05:04 Gábor Stefanik wrote: > The spec had some nasty typos, and a large part of the rev0/1 BB > init procedure was also missing. Fix these. > > Also make the init-time channel switch debuggable. > > (The change from -EINVAL to -EIO is simply to make it possible > to d

Re: Question about LDO and SSB

2009-08-15 Thread Michael Buesch
On Saturday 15 August 2009 22:33:19 Larry Finger wrote: > Michael, > > I just ran across a couple of routines named sb_pmu_set_ldo_voltage() > and sb_pmu_paref_ldo_enable(). These are no-ops for all chips except > for 0x4328, 0x5354, and 0x4312 and I don't need to be concerned at the > moment, but

Re: [PATCH] b43: Fix sparse warnings

2009-08-15 Thread Michael Buesch
On Friday 14 August 2009 23:46:54 Pavel Roskin wrote: > On Fri, 2009-08-14 at 17:29 -0400, Pavel Roskin wrote: > > On Fri, 2009-08-14 at 23:00 +0200, Michael Buesch wrote: > > > On Friday 14 August 2009 22:52:13 Pavel Roskin wrote: > > > > On Fri, 2009-08-14 at 22:

Re: [PATCH] b43: Fix sparse warnings

2009-08-15 Thread Michael Buesch
On Friday 14 August 2009 23:35:29 Pavel Roskin wrote: > On Fri, 2009-08-14 at 23:04 +0200, Gábor Stefanik wrote: > > On Fri, Aug 14, 2009 at 11:00 PM, Michael Buesch wrote: > > > On Friday 14 August 2009 22:52:13 Pavel Roskin wrote: > > >> On Fri, 2009-08-14 at 22:

Re: [PATCH] b43: Fix sparse warnings

2009-08-14 Thread Michael Buesch
On Friday 14 August 2009 22:52:13 Pavel Roskin wrote: > On Fri, 2009-08-14 at 22:15 +0200, Michael Buesch wrote: > > > > - b43_phy_mask(dev, 0x048A, (u16)~0x8000); > > > + b43_phy_mask(dev, 0x048A, (u16)(~0x8000 & 0x)); > >

Re: [PATCH] ssb: Fix e typo in the rev8 SPROM extraction routine

2009-08-14 Thread Michael Buesch
On Friday 14 August 2009 14:11:53 Gábor Stefanik wrote: > No comment. :-) > > Signed-off-by: Gábor Stefanik > --- > Mark, this should fix your MAC address bug. > Anyone else testing LP-PHY should also apply this. > > drivers/ssb/pci.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-

Re: [PATCH] b43: Add LP-PHY firmware loading support

2009-08-14 Thread Michael Buesch
On Friday 14 August 2009 22:20:55 Gábor Stefanik wrote: > 2009/8/14 Michael Buesch : > > On Friday 14 August 2009 13:51:59 Gábor Stefanik wrote: > >> Add support for loading LP-PHY firmware to b43_try_request_fw. > >> > >> Signed-off-by: Gábor Stefanik >

Re: [PATCH] b43: Add LP-PHY firmware loading support

2009-08-14 Thread Michael Buesch
On Friday 14 August 2009 13:51:59 Gábor Stefanik wrote: > Add support for loading LP-PHY firmware to b43_try_request_fw. > > Signed-off-by: Gábor Stefanik ack -- Greetings, Michael. ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lis

Re: [PATCH] b43: LP-PHY: Implement channel switching for rev0/1/B2062 radio

2009-08-14 Thread Michael Buesch
On Friday 14 August 2009 00:15:17 Gábor Stefanik wrote: > -Move pdiv from lpphy_2062_init to struct b43_phy_lp. > -Add channel table for the B2062 radio. > -Add code for tuning the B2062 radio to channel. > -Add error handling to op_switch_channel, and use it for both radios. > > Rev0/1/B2062 will

Re: [PATCH] b43: LP-PHY: Implement channel switching for rev2+/B2063 radio

2009-08-14 Thread Michael Buesch
On Thursday 13 August 2009 22:46:30 Gábor Stefanik wrote: > Rev.2+/B2063 will now hopefully show some signs of life, though > it won't work at full performance, as calibration is still missing. > > Signed-off-by: Gábor Stefanik ack -- Greetings, Michael.

Re: [PATCH] b43: Fix sparse warnings

2009-08-14 Thread Michael Buesch
On Friday 14 August 2009 00:15:07 Larry Finger wrote: > The b43 driver generates the following sparse warnings: > > CHECK drivers/net/wireless/b43/phy_g.c > drivers/net/wireless/b43/phy_g.c:974:35: warning: cast truncates bits from > constant value (7fff becomes 7fff) > CHECK drivers/

Re: [RFC/RFT] b43: LP-PHY: Implement channel switching for rev2+/B2063 radio

2009-08-13 Thread Michael Buesch
On Thursday 13 August 2009 20:00:47 Gábor Stefanik wrote: > (List re-CC-ed.) > > 2009/8/13 Michael Buesch : > > On Thursday 13 August 2009 19:50:16 Gábor Stefanik wrote: > >> 2009/8/13 Michael Buesch : > >> > On Thursday 13 August 2009 17:02:21 Gábor Stefanik

Re: [RFC/RFT] b43: LP-PHY: Implement channel switching for rev2+/B2063 radio

2009-08-13 Thread Michael Buesch
On Thursday 13 August 2009 17:02:21 Gábor Stefanik wrote: > Rev.2+/B2063 will now hopefully show some signs of life, though > it won't work at full performance, as calibration is still missing. > > Signed-off-by: Gábor Stefanik > static void lpphy_baseband_rev0_1_init(struct b43_wldev *dev) > @

Re: [PATCH v2] b43: Update dummy transmission to match V4 specs

2009-08-13 Thread Michael Buesch
On Thursday 13 August 2009 16:51:51 Gábor Stefanik wrote: > The V4 dummy transmission has two extra bools in its prototype, > so update all callers with the 2 bools. > > Signed-off-by: Gábor Stefanik > --- > v2: Convert all callers to v4, and drop the v3->v4 wrapper. > - /* Commit writes */

Re: [PATCH] b43: LP-PHY: Initialize TX power control

2009-08-13 Thread Michael Buesch
On Wednesday 12 August 2009 22:42:40 Gábor Stefanik wrote: > The HW TX power control init still needs work. > The SW init is complete according to the specs. HW PCTL needs a serious amount of work in the common code, too. For now I would focus to SW PCTL and fix HW PCTL later. > > Signed-off-by:

Re: [PATCH] b43: Update dummy transmission to match V4 specs

2009-08-13 Thread Michael Buesch
On Wednesday 12 August 2009 22:39:44 Gábor Stefanik wrote: > The V4 dummy transmission function has two extra bools in its > prototype, so add a wrapper function for callers that expect the > V3 version. > > Signed-off-by: Gábor Stefanik Nah, please just convert all callers instead. There are no

Re: [PATCH v3] b43: Implement RC calibration for rev.0/1 LP-PHYs

2009-08-13 Thread Michael Buesch
nd removed forward declaration > -Reordered variable declarations at the start of rev0_1_rc_calib. > -The ideal power table is now static const. > > Interdiff v1->v2 available @ http://b43.pastebin.com/f5fe6ba3c for easier > review. > Acked-by: Michael Buesch -- Greetings, Michael.

Re: [PATCH] b43: Implement RC calibration for rev.0/1 LP-PHYs

2009-08-12 Thread Michael Buesch
On Wednesday 12 August 2009 19:56:25 Gábor Stefanik wrote: > + b43_phy_maskset(dev, B43_LPPHY_RF_OVERRIDE_2, 0xFEFF, 1<<8); > + b43_phy_maskset(dev, B43_LPPHY_AFE_DDFS_INCR_INIT, 0x80FF, incr2 << 3); Can you try to stick to one style? a << b is our coding style. > +static void lp

Re: [PATCH RFC] ssb: Implement the remaining rev.8 SPROM vars needed for LP-PHY

2009-08-10 Thread Michael Buesch
On Monday 10 August 2009 21:07:45 Gábor Stefanik wrote: > > Also, it seems you need +1 instead of +2 (it is an u16 pointer). > I'm adding to _offset, not to SPOFF(_offset). AFAICS _offset is not an > u16 pointer, it's a plain #defined number, unlike SPOFF(_offset). Ah ok. All those parenthesis are

Re: [PATCH V2] b43: Update LP-PHY rev2+ baseband init to match the specs

2009-08-10 Thread Michael Buesch
On Monday 10 August 2009 20:57:06 Gábor Stefanik wrote: > The rev2+ BB init spec has changed behind us, and thus the code is > no longer up to date. Update the code to match the current specs. > Also implement save/restore dig filt state, as required by the > new specification. > > Signed-off-by:

Re: [PATCH RFC] ssb: Implement the remaining rev.8 SPROM vars needed for LP-PHY

2009-08-10 Thread Michael Buesch
On Monday 10 August 2009 20:49:02 Gábor Stefanik wrote: > Also add a "SPEX32" macro for extracting 32-bit SPROM variables. > > Signed-off-by: Gábor Stefanik > --- > I'm not quite sure that the SPEX32 macro is sane endianness-wise; > please review it carefully. (In the future, we will probably nee

Re: [PATCH] b43: Update LP-PHY rev2+ baseband init to match the specs

2009-08-10 Thread Michael Buesch
On Monday 10 August 2009 20:42:33 Gábor Stefanik wrote: > +static void lpphy_save_dig_flt_state(struct b43_wldev *dev) > +{ > + static const u16 addr[] = { > + B43_PHY_OFDM(0xC1), > + B43_PHY_OFDM(0xC2), > + B43_PHY_OFDM(0xC3), > + B43_PHY_OFDM(0x

Re: [PATCH] b43: Implement LP-PHY baseband table initialization

2009-08-10 Thread Michael Buesch
On Monday 10 August 2009 20:39:47 Gábor Stefanik wrote: > Implement LP-PHY baseband table init for all revisions. > > Signed-off-by: Gábor Stefanik > --- > Changes from RFC: > -Improved table formatting in the code. > -The 2GHz check in adjust_gain_table now uses b43_current_band. > -Added a comm

Re: [RFC PATCH] b43: Implement LP-PHY baseband table initialization

2009-08-10 Thread Michael Buesch
On Monday 10 August 2009 14:52:49 Michael Buesch wrote: > On Monday 10 August 2009 14:49:31 Gábor Stefanik wrote: > > 2009/8/10 Michael Buesch : > > > On Monday 10 August 2009 03:00:46 Gábor Stefanik wrote: > > >> +static const u16 lpphy_sw_control_t

Re: [RFC PATCH] b43: Implement LP-PHY baseband table initialization

2009-08-10 Thread Michael Buesch
On Monday 10 August 2009 14:49:31 Gábor Stefanik wrote: > 2009/8/10 Michael Buesch : > > On Monday 10 August 2009 03:00:46 Gábor Stefanik wrote: > >> +static const u16 lpphy_sw_control_table[] = { > >> +     0x0128, > >> +     0x0128, > >> +    

Re: [RFC PATCH] b43: Implement LP-PHY baseband table initialization

2009-08-10 Thread Michael Buesch
On Monday 10 August 2009 03:00:46 Gábor Stefanik wrote: > +static const u16 lpphy_sw_control_table[] = { > + 0x0128, > + 0x0128, > + 0x0009, > + 0x0009, > + 0x0028, > + 0x0028, Is it possible to use more than one value per line for all these tables? Make sure to make best u

Re: [PATCH] b43: LP-PHY: Implement STX synchronization

2009-08-09 Thread Michael Buesch
On Sunday 09 August 2009 20:15:09 Gábor Stefanik wrote: > The v2+ radio init (B2063) is now complete, modulo BCM4325 support. > > Signed-off-by: Gábor Stefanik ack -- Greetings, Michael. ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https

Re: [PATCH] b43: Fix hardware key index handling

2009-08-07 Thread Michael Buesch
On Friday 07 August 2009 16:37:26 John W. Linville wrote: > On Thu, Aug 06, 2009 at 10:36:50AM +0200, Michael Buesch wrote: > > This fixes the hardware encryption keys index and array size handling. > > > > Thanks to Gregor Kowski for reporting this issue. > > > &

Re: [PATCH] b43: Fix hardware key index handling

2009-08-06 Thread Michael Buesch
On Thursday 06 August 2009 16:29:58 Larry Finger wrote: > Michael Buesch wrote: > > This fixes the hardware encryption keys index and array size handling. > > > > Thanks to Gregor Kowski for reporting this issue. > > > > Signed-off-by: Michael Buesch > >

[PATCH] b43: Fix hardware key index handling

2009-08-06 Thread Michael Buesch
This fixes the hardware encryption keys index and array size handling. Thanks to Gregor Kowski for reporting this issue. Signed-off-by: Michael Buesch --- This should probably go as a bugfix. (Does this actually fix the PHY transmission errors? I don't see them anymore... Note that you

Re: [RESEND] [PATCHv2] b43 add harware tkip

2009-08-04 Thread Michael Buesch
On Wednesday 05 August 2009 00:23:23 gregor kowski wrote: > On 8/5/09, Michael Buesch wrote: > > On Wednesday 05 August 2009 00:03:11 gregor kowski wrote: > >> On 8/4/09, Michael Buesch wrote: > >> > On Tuesday 04 August 2009 23:54:42 gregor kowski wrote: >

Re: [PATCH] b43: Typo fixes & minor cleanup

2009-08-04 Thread Michael Buesch
On Wednesday 05 August 2009 00:10:58 Gábor Stefanik wrote: > Fix a typo in the HostFlags #defines. > Make use of HostFlags defines in the LP-PHY code. > Fix fallout from the IEEE80211_IF_TYPE to NL80211_IFTYPE change. > > Signed-off-by: Gábor Stefanik > --- > > drivers/net/wireless/b43/b43.h

Re: [RESEND] [PATCHv2] b43 add harware tkip

2009-08-04 Thread Michael Buesch
On Wednesday 05 August 2009 00:03:11 gregor kowski wrote: > On 8/4/09, Michael Buesch wrote: > > On Tuesday 04 August 2009 23:54:42 gregor kowski wrote: > >> On 7/31/09, Michael Buesch wrote: > >> > On Friday 31 July 2009 23:04:17 gregor kowski wrote: > >>

Re: [PATCH] remove wrong probe_resp_plcp write

2009-08-04 Thread Michael Buesch
On Tuesday 04 August 2009 23:58:45 gregor kowski wrote: > On 8/4/09, Johannes Berg wrote: > > On Tue, 2009-08-04 at 22:27 +0200, Michael Buesch wrote: > > > > Just remove it -- if we need it back we can find it in the git archives, > > and it's rather unlik

Re: [PATCH] b43: Add LP 2063 radio init

2009-08-04 Thread Michael Buesch
On Tuesday 04 August 2009 23:57:32 Gábor Stefanik wrote: > Add B2063 radio init code and tables for LP-PHY. > Rename structures common between B2062 and B2063 to B206X. > > Signed-off-by: Gábor Stefanik ack -- Greetings, Michael. ___ Bcm43xx-dev mail

Re: [RESEND] [PATCHv2] b43 add harware tkip

2009-08-04 Thread Michael Buesch
On Tuesday 04 August 2009 23:54:42 gregor kowski wrote: > On 7/31/09, Michael Buesch wrote: > > On Friday 31 July 2009 23:04:17 gregor kowski wrote: > >> Hi Michael, > >> > >> > It's mapped to 4, because you removed the old API support. > >> &

<    1   2   3   4   5   6   7   8   9   10   >