Re: [PATCH] b43: Fix some TX/RX locking issues

2008-04-25 Thread Larry Finger
Michael Buesch wrote: > This fixes some TX/RX related locking issues. > With this patch applied, some of the PHY transmission errors are fixed. > > Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> > > --- > > John, this is for 2.6.26. > > This patch cures the single PHY transmission error th

Re: Tons of interrupts on driver load

2008-04-25 Thread Larry Finger
Richard Jonsson wrote: > Larry Finger skrev: >> Richard Jonsson wrote: >>> flipping switch a few times, led unchanged >>> [ 1534.770048] b43-phy0: Radio hardware status changed to ENABLED >>> [ 1550.778511] b43-phy0: Radio hardware status changed to DISABLED >>> [ 1562.783474] b43-phy0: Radio hardw

[PATCH] b43: Don't disable IRQs in mac_suspend

2008-04-25 Thread Michael Buesch
This patch removes the IRQ-disable from mac_suspend. The main advantage of this is to get rid of the IRQ-sync call in mac_suspend. We need to remove the MAC suspend bit from the IRQ service mask, as otherwise the IRQ handler would race with us. Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> --

Re: Tons of interrupts on driver load

2008-04-25 Thread Richard Jonsson
Larry Finger skrev: > Richard Jonsson wrote: >> flipping switch a few times, led unchanged >> [ 1534.770048] b43-phy0: Radio hardware status changed to ENABLED >> [ 1550.778511] b43-phy0: Radio hardware status changed to DISABLED >> [ 1562.783474] b43-phy0: Radio hardware status changed to ENABLED

Re: Tons of interrupts on driver load

2008-04-25 Thread Richard Jonsson
Here comes a slice of dmesg with debugging turned on. This is from v2.6.25-4571-g87322bc of mainline. Same as before. Richard Jonsson skrev: >> OK, after bootup with v2.5.25-rc3-git I get this, looks sane to me: >> >> [ 32.474786] b43-phy0: Loading firmware version 351.126 (2006-07-29 >> 05

Re: Tons of interrupts on driver load

2008-04-25 Thread Larry Finger
Richard Jonsson wrote: > flipping switch a few times, led unchanged > [ 1534.770048] b43-phy0: Radio hardware status changed to ENABLED > [ 1550.778511] b43-phy0: Radio hardware status changed to DISABLED > [ 1562.783474] b43-phy0: Radio hardware status changed to ENABLED > [ 1565.788237] b43-phy0:

Re: Tons of interrupts on driver load

2008-04-25 Thread Richard Jonsson
> > OK, after bootup with v2.5.25-rc3-git I get this, looks sane to me: > > [ 32.474786] b43-phy0: Loading firmware version 351.126 (2006-07-29 > 05:54:02) > [ 32.474797] b43-phy0 warning: You are using an old firmware image. > Support for old firmware will be removed in July 2008. > [ 32

[PATCH] b43: Fix some TX/RX locking issues

2008-04-25 Thread Michael Buesch
This fixes some TX/RX related locking issues. With this patch applied, some of the PHY transmission errors are fixed. Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> --- John, this is for 2.6.26. Index: wireless-testing/drivers/net/wireless/b43/b43.h =

Re: Tons of interrupts on driver load

2008-04-25 Thread Richard Jonsson
Richard Jonsson skrev: > Larry Finger skrev: >> Richard Jonsson wrote: >>> [10493.303801] b43-phy0 warning: You are using an old firmware image. >>> Support for old firmware will be removed in July 2008. >>> [10493.303807] b43-phy0 warning: You must go to >>> http://linuxwireless.org/en/users/Dri

Re: Tons of interrupts on driver load

2008-04-25 Thread Richard Jonsson
Larry Finger skrev: > Richard Jonsson wrote: >> [10493.303801] b43-phy0 warning: You are using an old firmware image. >> Support for old firmware will be removed in July 2008. >> [10493.303807] b43-phy0 warning: You must go to >> http://linuxwireless.org/en/users/Drivers/b43#devicefirmware and >

Re: Tons of interrupts on driver load

2008-04-25 Thread Richard Jonsson
Michael Buesch skrev: > On Friday 25 April 2008 18:09:27 Richard Jonsson wrote: >> To add, I thought that my hardware had died judging by the messages >> above, so I temporarily connected to an access point in the area and >> could successfully load a few webpages before I disconnected. > > You

Re: Tons of interrupts on driver load

2008-04-25 Thread Larry Finger
Richard Jonsson wrote: > [10493.303801] b43-phy0 warning: You are using an old firmware image. > Support for old firmware will be removed in July 2008. > [10493.303807] b43-phy0 warning: You must go to > http://linuxwireless.org/en/users/Drivers/b43#devicefirmware and > download the latest firmw

Re: Tons of interrupts on driver load

2008-04-25 Thread Michael Buesch
On Friday 25 April 2008 18:09:27 Richard Jonsson wrote: > To add, I thought that my hardware had died judging by the messages > above, so I temporarily connected to an access point in the area and > could successfully load a few webpages before I disconnected. You really need to be a bit more de

Re: Tons of interrupts on driver load

2008-04-25 Thread Richard Jonsson
Michael Buesch skrev: > On Friday 25 April 2008 17:21:00 Richard Jonsson wrote: >> I use a custom kernel, but I think I turned off b43/ssb debugging some >> time ago. Anyway dmesg is drowning in this: > > Oh, finally something useful. Great! > >> [ 7389.533848] b43-phy0 warning: You must go to

Re: Tons of interrupts on driver load

2008-04-25 Thread Michael Buesch
On Friday 25 April 2008 17:21:00 Richard Jonsson wrote: > I use a custom kernel, but I think I turned off b43/ssb debugging some > time ago. Anyway dmesg is drowning in this: Oh, finally something useful. Great! > [ 7389.533848] b43-phy0 warning: You must go to > http://linuxwireless.org/en/use

Re: Tons of interrupts on driver load

2008-04-25 Thread Richard Jonsson
Larry Finger skrev: > Richard Jonsson wrote: >> Pavel Roskin skrev: >>> On Thu, 2008-04-24 at 21:48 +0200, Richard Jonsson wrote: Hello, First some background: I am currently running latest mainline from git. This kernel suffers from a scheduler? >>> I think this question

Re: Tons of interrupts on driver load

2008-04-25 Thread Larry Finger
Richard Jonsson wrote: > Pavel Roskin skrev: >> On Thu, 2008-04-24 at 21:48 +0200, Richard Jonsson wrote: >>> Hello, >>> >>> First some background: >>> I am currently running latest mainline from git. This kernel suffers >>> from a scheduler? >> I think this question is more suited for LKML. >> >

Re: Inconsistency in handling board revision

2008-04-25 Thread gavron
Larry Finger wrote: > Michael Buesch wrote: > >> On Friday 25 April 2008 06:55:54 Larry Finger wrote: >> >>> Michael, >>> >>> I have discovered that both sprom_extract_r123() in the ssb driver, >>> and ssb-sprom use a two-byte quantity to extract the board revision. >>> In the specifica

Re: Inconsistency in handling board revision

2008-04-25 Thread Larry Finger
Michael Buesch wrote: > On Friday 25 April 2008 16:16:49 Larry Finger wrote: >> Michael Buesch wrote: >>> On Friday 25 April 2008 06:55:54 Larry Finger wrote: Michael, I have discovered that both sprom_extract_r123() in the ssb driver, and ssb-sprom use a two-byte quantity to e

Re: Inconsistency in handling board revision

2008-04-25 Thread gavron
Larry Finger wrote: > Michael Buesch wrote: > >> On Friday 25 April 2008 06:55:54 Larry Finger wrote: >> >>> Michael, >>> >>> I have discovered that both sprom_extract_r123() in the ssb driver, >>> and ssb-sprom use a two-byte quantity to extract the board revision. >>> In the specifica

Re: Inconsistency in handling board revision

2008-04-25 Thread Michael Buesch
On Friday 25 April 2008 16:16:49 Larry Finger wrote: > Michael Buesch wrote: > > On Friday 25 April 2008 06:55:54 Larry Finger wrote: > >> Michael, > >> > >> I have discovered that both sprom_extract_r123() in the ssb driver, > >> and ssb-sprom use a two-byte quantity to extract the board revision

Re: Inconsistency in handling board revision

2008-04-25 Thread Larry Finger
Michael Buesch wrote: > On Friday 25 April 2008 06:55:54 Larry Finger wrote: >> Michael, >> >> I have discovered that both sprom_extract_r123() in the ssb driver, >> and ssb-sprom use a two-byte quantity to extract the board revision. >> In the specifications detailed in >> http://bcm-v4.sipsolu

Re: [PATCH V3] ssb-sprom: Update README

2008-04-25 Thread Michael Buesch
On Friday 25 April 2008 06:42:20 Larry Finger wrote: > This version modifies the setting of the patch to ssb_sprom to handle > systems with multiple SSB-based devices. Applied, thanks. -- Greetings Michael. ___ Bcm43xx-dev mailing list Bcm43xx-dev@list

Re: Inconsistency in handling board revision

2008-04-25 Thread Michael Buesch
On Friday 25 April 2008 06:55:54 Larry Finger wrote: > Michael, > > I have discovered that both sprom_extract_r123() in the ssb driver, > and ssb-sprom use a two-byte quantity to extract the board revision. > In the specifications detailed in > http://bcm-v4.sipsolutions.net/SPROM, a single-byt

Re: Tons of interrupts on driver load

2008-04-25 Thread Richard Jonsson
Pavel Roskin skrev: > On Thu, 2008-04-24 at 21:48 +0200, Richard Jonsson wrote: >> Hello, >> >> First some background: >> I am currently running latest mainline from git. This kernel suffers >> from a scheduler? > > I think this question is more suited for LKML. > I'm sorry for being a bit vague