Campbell, i'm not sure what's up to phabricator here. If you want to know
some data about old patches i can write an exporter for you. For the new
one using neither maniphest nor differencial is gonna to be accurate --
with all that tendency to commandeer revision the revisions and those devs
who
Is it possible to correct patch application with arcanist to also use the
original author? I've been bitten by this before, not acknowledging patch
authors properly.
If not better make it a rule to also not apply patches through arcanist.
On 21 September 2014 10:05, Sergey Sharybin
`arc apply --hold D666` then do regular push. This is a good idea to do
anyway to review things before they go to the master.If author is not
correct, you can amend the commit `git commit -a --am --author=Proper Guy
`.
Differencial only contains authorship information if the patch was
submitted
Sergey, having the `author` set correct is good of course, but in
practice I think its not going to work well for us under our current
phabricator configuration.
It means before accepting some patch we have to...
- Manually search git log to check if someone under that name committed before
...
I don't remember having issues checking for the author name in the past. Is
it something you did experience a lot or it's something you're
exaggerating? I'm still unconvinced asking for some details or greping log
would give any slowdown in your review pipeline. It easily fits into the
time
On Sun, Sep 21, 2014 at 11:37 PM, Sergey Sharybin sergey@gmail.com wrote:
I don't remember having issues checking for the author name in the past. Is
it something you did experience a lot or it's something you're
exaggerating?
For both the git migration and credits generator I ran into
The only way to make `arc patch` to get proper authorship is to force
everyone to use arc for submitting the reports. Now, if you force everyone
to fill in proper name and Public Email, getting this info for those who
don't use git would be matter of single click on their nick. Setting this
up is
It appears that arguments will continue over the best way to make
a system whereby contributions can automatically be deduced,
and in all likelihood, such automatic extraction will never be 100% correct.
It feels like there are two desires from developers for such a credits page:
1) some
My personal preference is probably for a hand-tuned static html page that
thanks
Ton then lists Core Developers, Cycles Team, Module Owners, Contributors,
Release Add-On Developers, Website Editors, Wiki Documenters, etc and also
thanks other projects and companies that provided code (Eigen,
The only way to make `arc patch` to get proper authorship is to force
everyone to use arc for submitting the reports.
Just for the records, more than once recently I had troubles tracking
back the original author of a phabricator patch before committing it.
In one of the cases I had to give up
It seems theres still quite some dissatisfaction with having incorrect
information on the credits page, (as maintainer of the credits
generator I propose we...)
- remove individual contributors from
http://www.blender.org/about/credits/ add a note that this information
is no-longer available.
-
Removing the page seems like an extreme reaction.
Why not just keep the page creation as it is right now but then *insert*
a static html list of the missing 253 names into an Also Thanks To
section until you have this problem sorted out properly?
Cheers, Harley
I'd be happy to drop the commit count, its not an accurate indication
of contributions anyway,
However I don't think doing that makes the task any easier. To get
every patch-author we still need some way to map committed patches to
a user name.
On Sun, Sep 14, 2014 at 9:33 AM, Harley Acheson
I might sound harsh but I believe that to ease out this process, at
least for the future, it could be time for the committers to actually
commit with the author's name (git commit --author=insert_name) and drop
the all patch by someone nonsense. If the guys taking care of the
Linux kernel can
On Sun, Sep 14, 2014 at 5:49 PM, Kévin Dietrich
kevin.dietr...@mailoo.org wrote:
I might sound harsh but I believe that to ease out this process, at
least for the future, it could be time for the committers to actually
commit with the author's name (git commit --author=insert_name) and drop
We do this when we can do it. But git requires a full id (Full Name
valid.m...@mailbox.org) on first commit, and we usually do not have
those mail addresses (Phab does not show them for e.g.). So we only can
commit authored patches for people already 'registered' somehow in our
git repo (or
On Sun, 14 Sep 2014 18:49:20 +1000
Campbell Barton ideasma...@gmail.com wrote:
On Sun, Sep 14, 2014 at 5:49 PM, Kévin Dietrich
kevin.dietr...@mailoo.org wrote:
I might sound harsh but I believe that to ease out this process, at
least for the future, it could be time for the committers to
Campbell, it could be possible to setup an export script as well, but imo
it's just some legacy workaround. We just need to be sure patches are
authored by the patch author when committing them. It happens automatically
when patch author and developer uses arc. For other cases you can use
--author
In case this is useful, I *think* we are missing the following 253
contributors, comparing
the current About page to the version from January of this year:
Aaron Keith (spudmn), 3 commits (2010 2011)
Adam Dominec, 1 patch 2012
Adam Wiseman (wiseman303), 3 commits (2010 2012)
Adrian
Hi,
On Mon, Sep 15, 2014 at 2:45 AM, Harley Acheson
harley.ache...@gmail.com wrote:
In case this is useful, I *think* we are missing the following 253
contributors, comparing
the current About page to the version from January of this year:
[snip]
Jehan Pag耀s, 1 patch – 2013
I don't care
Sorry about mangling your name Jehan. Here's another try at the list...
Aaron Keith (spudmn), 3 commits (2010 – 2011)
Adam Dominec, 1 patch – 2012
Adam Wiseman (wiseman303), 3 commits (2010 – 2012)
Adrian Winchell, 1 patch – 2009
Agustin Benavidez, 1 patch – 2012
Alain Ducharme, 1 patch – 2013
Hello,
The About/Credits http://www.blender.org/about/credits/ page is not
accurate.
The version of it on January 22 2014 showed me as having 17 patches
(2010-2013)
http://web.archive.org/web/20140122054638/http://www.blender.org/about/credits/
But I've been off the page since at least July 10
Hello Again,
Looking at it a little closer, in November 13 2013 the credits page
acknowledged
451 individual contributors, while the current page lists only 238 people.
So 213
have been dropped from it.
On Sat, Sep 13, 2014 at 9:50 AM, Paolo Acampora palu...@gmail.com wrote:
Surely many
On Sat, 13 Sep 2014 18:50:22 +0200
Paolo Acampora palu...@gmail.com wrote:
Surely many people is left outside by the autogenerated system, I never
thought it was a problem, after all the purpose of my contributions was
never to just appear on the list, but I'm sure there are others, like me,
I'm almost positive these lists are auto-generated by a script
(written by Campbell Barton if I recall correctly) - It sorta sounds
like it's not working properly anymore - perhaps because of the switch
to phabricator? Pretty sure there was no devious reason to not
include devs intended.
-Sean
When using GForce (the old tracker), the script would get a CSV file
and cross reference patch ID's with commits,
With Phabricator we need way download a list of patch/diff authors
into a file the credits generator can parse.
This wasn't high priority for the initial migration, but I'll check
If it isn't possible to get the diff author information back we could
_consider_ the following:
Correct a *single* commit (only) for each of the 213 missing contributors,
abandon the
commit count as being inaccurate from now on, and create a new Credits
page listing
all contributors without
27 matches
Mail list logo
