Many thanks, Vince! I will fix the printf and markdown errors.
With release date now not far off, I propose (Bioc policymakers please weigh in
if this is inadequate) to
- remove web browser communication from vignette, examples and unit tests
- evaluate stubs and/or "mocks" for possible use in
Thanks Paul. Package works. Browser visualizations look really nice.
I tried to run your unit tests and they
use a function called "printf". Setting printf = sprintf allowed the tests
to all run to completion.
The following vignette chunk is problematic ... maybe you meant eval=FALSE,
Hi Vince,
My dumb mistake, sorry. Now fixed, version 0.99.9,
https://github.com/paul-shannon/IGV
I’m looking forward to hearing your suggestions.
- Paul
> On Apr 9, 2018, at 4:49 PM, Vincent Carey wrote:
>
> Hi Paul -- I am trying to build your vignette but
Hi Paul -- I am trying to build your vignette but it has
load("~/s/work/priceLab/AD/tbl.gwas.level_1.RData")
I think it should be possible to get your package through
check, but I would like to get the vignette built and
check out the tests before commenting further.
On Mon, Apr 9, 2018 at
> "Once your package builds and checks without errors or (avoidable) warnings,
> a Bioconductor team member will provide a technical review of your package.
> Other Bioconductor developers and users with domain expertise are encouraged
> to provide additional community commentary. Reviewers