Crash on reconfigure with kernel table

2018-02-06 Thread Toke Høiland-Jørgensen
While testing the babel sadr patch, I ran into this crash on reconfigure of the kernel protocol: Basically, start with this config: router id 62.168.0.1; debug protocols all; protocol device {} ipv6 sadr table tab1; protocol kernel { ipv6 sadr { table tab1; export all; import

[PATCH v3] babel: Add source-specific routing support

2018-02-06 Thread Toke Høiland-Jørgensen
This adds support for source-specific routing to the babel protocol. It changes the protocol to support both NET_IP6 and NET_IP6_SADR channels for IPv6 addresses, preferring the NET_IP6_SADR channel. If only a NET_IP6 channel is configured, source-specific updates are ignored. Otherwise,

[PATCH] Add cscope Makefile target

2018-02-06 Thread Toke Høiland-Jørgensen
For those who prefer cscope to etags Signed-off-by: Toke Høiland-Jørgensen --- .gitignore | 1 + Makefile.in | 5 - 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index 0dcebfd1..3b734f49 100644 --- a/.gitignore +++ b/.gitignore @@ -12,3

Re: [PATCH 1/2] Add IP6_SADR support to Bird Core

2018-02-06 Thread Ondrej Zajicek
On Mon, Feb 05, 2018 at 03:33:25PM +0100, Toke Høiland-Jørgensen wrote: > Will fix and resubmit. What about the issue with 'learn'? :) Fixed in 28b3b551222ab58456a067a9be4790824cdbb60e -- Elen sila lumenn' omentielvo Ondrej 'Santiago' Zajicek (email: santi...@crfreenet.org) OpenPGP encrypted

Re: bird 2.0.1: SIGSEGV in nexthop_size

2018-02-06 Thread Ondrej Zajicek
On Mon, Jan 29, 2018 at 01:38:17PM +0100, Svenne Krap wrote: > Hi, > > We downgraded to version 1.6.3 as we are in a hurry to get to production. > > We can still simulate the old environment, so I will try the patches... > > It will probably not be today or tomorrow. Hi, the issue noticed by

Re: [PATCH 1/2] Add IP6_SADR support to Bird Core

2018-02-06 Thread Ondrej Zajicek
On Tue, Feb 06, 2018 at 04:57:43PM +0100, Toke Høiland-Jørgensen wrote: > What, we have to be nice to the users now? ;) > > Fair enough, I'll add support for both types of channels. Should it be > possible to connect the same instance to both an ipv6 and and ipv6_sadr > channel type, or is it OK

Re: [PATCH 1/2] Add IP6_SADR support to Bird Core

2018-02-06 Thread Toke Høiland-Jørgensen
Ondrej Zajicek writes: > On Tue, Feb 06, 2018 at 04:38:59PM +0100, Toke Høiland-Jørgensen wrote: >> > I did not check 2/2 yet, but i think it should support both regular >> > ipv6 and ipv6 SADR channels/tables, not just the SADR ones. >> >> Hmm, well, my assumption was

Re: [PATCH 1/2] Add IP6_SADR support to Bird Core

2018-02-06 Thread Toke Høiland-Jørgensen
Ondrej Zajicek writes: > On Tue, Feb 06, 2018 at 05:20:25PM +0100, Toke Høiland-Jørgensen wrote: >> It's mandatory, otherwise you can get routing loops. See >> https://tools.ietf.org/html/draft-ietf-babel-source-specific-03#section-6 >> >> I figure the packet parser

Re: Bird 1.6.3 filters breaking down on reconfigure.

2018-02-06 Thread Ondrej Zajicek
On Mon, Feb 05, 2018 at 11:05:05PM +0100, Roelf "rewbycraft" Wichertjes wrote: > Hello everyone, > > I am experiencing a problem where upon issuing "birdc configure" (or "birdc6 > configure") some strange things happen. > ... > A lot of these issues sound like bird simply not properly re-applying

Re: [PATCH 1/2] Add IP6_SADR support to Bird Core

2018-02-06 Thread Toke Høiland-Jørgensen
Ondrej Zajicek writes: > On Tue, Feb 06, 2018 at 04:57:43PM +0100, Toke Høiland-Jørgensen wrote: >> What, we have to be nice to the users now? ;) >> >> Fair enough, I'll add support for both types of channels. Should it be >> possible to connect the same instance to both

Re: [PATCH 1/2] Add IP6_SADR support to Bird Core

2018-02-06 Thread Toke Høiland-Jørgensen
Ondrej Zajicek writes: > On Mon, Feb 05, 2018 at 03:33:25PM +0100, Toke Høiland-Jørgensen wrote: >> Will fix and resubmit. What about the issue with 'learn'? :) > > Fixed in 28b3b551222ab58456a067a9be4790824cdbb60e Great, thanks! Do you want me to submit a new version

Re: [PATCH 1/2] Add IP6_SADR support to Bird Core

2018-02-06 Thread Ondrej Zajicek
On Tue, Feb 06, 2018 at 05:20:25PM +0100, Toke Høiland-Jørgensen wrote: > It's mandatory, otherwise you can get routing loops. See > https://tools.ietf.org/html/draft-ietf-babel-source-specific-03#section-6 > > I figure the packet parser needs to be aware of whether it is configured > to support

Re: [PATCH 1/2] Add IP6_SADR support to Bird Core

2018-02-06 Thread Ondrej Zajicek
On Tue, Feb 06, 2018 at 04:38:59PM +0100, Toke Høiland-Jørgensen wrote: > > I did not check 2/2 yet, but i think it should support both regular > > ipv6 and ipv6 SADR channels/tables, not just the SADR ones. > > Hmm, well, my assumption was that since sadr tables can hold normal ipv6 > routes as

Re: Crash on reconfigure with kernel table

2018-02-06 Thread Ondrej Zajicek
On Tue, Feb 06, 2018 at 08:50:52PM +0100, Toke Høiland-Jørgensen wrote: > While testing the babel sadr patch, I ran into this crash on reconfigure > of the kernel protocol: Hi Likely it is reconfiguration of table tab1 (changing net type) that does not work. You could try to rename it during net