Re: [blfs-dev] Patch for Glib with a dependency on pcre2

2016-10-16 Thread Samuel Tyler
On Mon, Oct 17, 2016 at 6:40 AM, Samuel Tyler < samuel.ty...@education.nsw.gov.au> wrote: > > > On Sun, Oct 16, 2016 at 3:37 AM, Pierre Labastie > wrote: > >> On 14/10/2016 23:36, Samuel Tyler wrote: >> >> > Here is the new patch - fixing vte. >> > ​ >> >> We usually try

Re: [blfs-dev] Patch for Glib with a dependency on pcre2

2016-10-16 Thread Samuel Tyler
On Sun, Oct 16, 2016 at 3:37 AM, Pierre Labastie wrote: > On 14/10/2016 23:36, Samuel Tyler wrote: > > > Here is the new patch - fixing vte. > > ​ > > We usually try to stick to template/template.xml. There is a fairly > detailed > comment about references, which says: >

Re: [blfs-dev] Patch for Glib with a dependency on pcre2

2016-10-15 Thread Pierre Labastie
On 14/10/2016 23:36, Samuel Tyler wrote: > Here is the new patch - fixing vte. > ​ We usually try to stick to template/template.xml. There is a fairly detailed comment about references, which says: --- notice no period as this is not a sentence. If there are more than two, they must

Re: [blfs-dev] Patch for Glib with a dependency on pcre2

2016-10-14 Thread Samuel Tyler
*Samuel* Public School Student On Sat, Oct 15, 2016 at 8:23 AM, Samuel Tyler < samuel.ty...@education.nsw.gov.au> wrote: > > > > > On Sat, Oct 15, 2016 at 5:52 AM, Bruce Dubbs > wrote: > >> Ken Moffat wrote: >> >>> On Fri, Oct 14, 2016 at 01:22:10PM -0500, Bruce Dubbs

Re: [blfs-dev] Patch for Glib with a dependency on pcre2

2016-10-14 Thread Samuel Tyler
On Sat, Oct 15, 2016 at 5:52 AM, Bruce Dubbs wrote: > Ken Moffat wrote: > >> On Fri, Oct 14, 2016 at 01:22:10PM -0500, Bruce Dubbs wrote: >> >>> Samuel Tyler wrote: >>> From Ticket #8427, I have created my first patch for the BLFS book and have attached

Re: [blfs-dev] Patch for Glib with a dependency on pcre2

2016-10-14 Thread Bruce Dubbs
Ken Moffat wrote: On Fri, Oct 14, 2016 at 01:22:10PM -0500, Bruce Dubbs wrote: Samuel Tyler wrote: From Ticket #8427, I have created my first patch for the BLFS book and have attached it. Almost right. Apart from patching the wrong package :) We try to keep dependencies in

Re: [blfs-dev] Patch for Glib with a dependency on pcre2

2016-10-14 Thread Ken Moffat
On Fri, Oct 14, 2016 at 01:22:10PM -0500, Bruce Dubbs wrote: > Samuel Tyler wrote: > > From Ticket #8427, I have created my first patch for the BLFS book and have > > attached it. > > Almost right. Apart from patching the wrong package :) > > We try to keep dependencies in alphabetical order,

Re: [blfs-dev] Patch for Glib with a dependency on pcre2

2016-10-14 Thread Bruce Dubbs
Samuel Tyler wrote: From Ticket #8427, I have created my first patch for the BLFS book and have attached it. Almost right. We try to keep dependencies in alphabetical order, but for optional dependencies all internal links go before all external links. We use for list punctuation a, b,

Re: [blfs-dev] Patch for Glib with a dependency on pcre2

2016-10-14 Thread Tim Tassonis
On 10/14/2016 08:12 AM, Samuel Tyler wrote: From Ticket #8427, I have created my first patch for the BLFS book and have attached it. This is wrong, pcre2 is not a dependency of glib2 and most definitely not a required one. It is a required dependency of vte-0.46.0, you have to patch that