[blink-dev] RE: Intent to Ship: Protected Audience: reporting timeouts & multiple-bids

2024-05-21 Thread 'Erik Anderson' via blink-dev
Hi, Thanks for reaching out. We’ve reviewed the proposal and don’t have any significant concerns. We’ll continue providing feedback via GitHub where appropriate. Thanks, Erik From: Paul Jensen Sent: Friday, May 17, 2024 5:42 AM To: Yoav Weiss (@Shopify) Cc: blink-dev ; Erik Anderson Subjec

[blink-dev] Intent to Extend Deprecation Trial: Partitioning Storage, Service Workers, and Communication APIs

2024-05-21 Thread Mike Taylor
** *Contact emails* * miketa...@chromium.org Explainer https://github.com/wanderview/quota-storage-partitioning/blob/main/explainer.md Specification None Summary We shipped

Re: [blink-dev] Intent to Deprecate and Remove: Deprecate old CSS custom state syntax

2024-05-21 Thread Joey Arhar
> Do you know what the breakage looks like I pushed to make sure that using the old syntax with CustomStateSet.add() wouldn't throw exceptions when in the new mode in order to reduce breakage. When websites use the old syntax after it's removed, they will just have styling differences because thei

Re: [blink-dev] Intent to Deprecate and Remove: Deprecate old CSS custom state syntax

2024-05-21 Thread 'Vladimir Levin' via blink-dev
Hey, 0.04% seems like a fairly sizable number. Do you know what the breakage looks like or whether this usage is limited to a library/a small set of large websites or something else? Ideally, this is feature detected with some fallback syntax On Tue, May 21, 2024 at 1:39 PM Joey Arhar wrote:

[blink-dev] Intent to Deprecate and Remove: Deprecate old CSS custom state syntax

2024-05-21 Thread Joey Arhar
Contact emailsjar...@chromium.org ExplainerNone Specificationhttps://github.com/whatwg/html/pull/8467 Summary The CSS custom state pseudo-class is being renamed from :--foo to :state(foo). The new syntax, :state(foo), has been enabled by default, and now we have to deprecate and remove the :--f

Re: [blink-dev] Intent to Ship: Deprecate Mutation Events

2024-05-21 Thread Vladimir Levin
On Tue, May 21, 2024 at 12:09 PM Mason Freed wrote: > Thank you all! I will proceed cautiously. A few comments below... > > On Tue, May 21, 2024 at 6:37 AM Mike Taylor > wrote: > >> I had a slight concern about the quilljs usage - even though they've >> minted a new version, we know that getting

Re: [blink-dev] Intent to Ship: Deprecate Mutation Events

2024-05-21 Thread Mason Freed
Thank you all! I will proceed cautiously. A few comments below... On Tue, May 21, 2024 at 6:37 AM Mike Taylor wrote: > I had a slight concern about the quilljs usage - even though they've > minted a new version, we know that getting sites to update is a major > hurdle. That said, after reading t

[blink-dev] Re: Question about "component_deps_blink Assignment had no effect" build error on ios.

2024-05-21 Thread 'Colin Blundell' via blink-dev
I missed this in the CL review, sorry - you have a dependency on Blink in the component but iOS doesn't use Blink in its default build configuration. Try building the iOS files only if `use_blink` is true and also gating the addition of the unittest target as a components_unittests dep on `use_blin

[blink-dev] Re: Question about "component_deps_blink Assignment had no effect" build error on ios.

2024-05-21 Thread 'Kartar Singh' via blink-dev
+cc blink-dev@chromium.org Since the gn variable(*component_deps_blink*) is blink specific and +cc chromium-m...@chromium.org since the failing target is in mojo(*mojom_core*). On Mon, May 20, 2024 at 6:15 PM Kartar Singh wrote: > Hey, > > We have been trying to set up a new component(//componen

Re: [blink-dev] Intent to Ship: Deprecate Mutation Events

2024-05-21 Thread Mike Taylor
LGTM3. I had a slight concern about the quilljs usage - even though they've minted a new version, we know that getting sites to update is a major hurdle. That said, after reading through the comments and linked issues on upstream repos (react-quill, etc) - nobody seems to be describing any br

Re: [blink-dev] Intent to Ship: CSS font-size-adjust with the two-value syntax

2024-05-21 Thread 'Dominik Röttsches' via blink-dev
Big thanks ChangSeok for implementing this and pushing for this feature. I can say a few things about the open issues > - https://github.com/w3c/csswg-drafts/issues/6384 > font-size-adjust relies on a font metric reference point, for example, the x-height, cap-height, etc. in order to scale fon

Re: [blink-dev] Intent to Ship: CSS font-size-adjust with the two-value syntax

2024-05-21 Thread Philip Jägenstedt
Hi ChangSeok, Thank you for working on this, it's great to see both more powerful typography control, and progress on Interop 2024. Can you say something about the remaining failures in WPT? font-size-adjust-012.html font-size-adjust-013.html both look like minor differences, but it seems like it

Re: [blink-dev] Intent to Ship: Protected Audience ads reporting - allow cross-origin subframes to send reportEvent() beacons

2024-05-21 Thread Mike Taylor
Thanks Liam! LGTM1 to ship. On 5/20/24 3:51 PM, Liam Brady wrote: Thanks for your feedback on this intent! We plan on modifying the "Allow-Cross-Origin-Event-Reporting" response header to accept a boolean instead of a string literal to match the preferred convention for response headers. On

[blink-dev] Intent to Ship: Importmap integrity

2024-05-21 Thread Yoav Weiss (@Shopify)
Contact emailsyoavwe...@chromium.org Explainerhttps://github.com/guybedford/import-maps-extensions#integrity Specificationhttps://github.com/whatwg/html/pull/10269 The PR is ready to land, but we're holding off on that for 2 weeks at Mozilla's request. See below. Summary Imported ES modules ca

Re: [blink-dev] Re: Intent to Experiment: Element Capture

2024-05-21 Thread 'Elad Alon' via blink-dev
Thank you for the LGTMs. A quick update that we have discussed the matter with the OT Core team, and it appears to us all better to have the breaking period between June 24 (first day of break) and July 15 (first day of renewed experiment). This ensures that partners have time to mint a new tok

[blink-dev] Re: Intent to Ship: Compute Pressure

2024-05-21 Thread Raphael Kubo da Costa
Op 17-05-2024 om 16:59 schreef Philip Jägenstedt: What will be the behavior on Android, will the API appear to work but never invoke the observer callback? If so, would it make sense to disable the feature on Android instead? I'd just like to check if there's a general guideline for cases like