Re: [blink-dev] Intent to Ship: SVG context-fill and context-stroke

2024-03-26 Thread Stefan Zager
On Tue, Mar 26, 2024 at 10:33 AM Yoav Weiss (@Shopify) < yoavwe...@chromium.org> wrote: > LGTM3 assuming that the gradients bug mentioned upthread is resolved in > https://issues.chromium.org/issues/40362923#comment36 > Yes, it is fixed. > > On Friday, March 22, 2024 at 8:00:56 PM UTC+1 Chris

Re: [blink-dev] Intent to Ship: SVG context-fill and context-stroke

2024-03-26 Thread Yoav Weiss (@Shopify)
LGTM3 assuming that the gradients bug mentioned upthread is resolved in https://issues.chromium.org/issues/40362923#comment36 On Friday, March 22, 2024 at 8:00:56 PM UTC+1 Chris Harrelson wrote: > LGTM2 > > On Fri, Mar 22, 2024 at 11:47 AM Mike Taylor > wrote: > >> LGTM1 >> On 3/18/24 10:53

Re: [blink-dev] Intent to Ship: SVG context-fill and context-stroke

2024-03-22 Thread Chris Harrelson
LGTM2 On Fri, Mar 22, 2024 at 11:47 AM Mike Taylor wrote: > LGTM1 > On 3/18/24 10:53 AM, Mike Taylor wrote: > > Thanks on both fronts, Stefan! > On 3/15/24 8:37 PM, Stefan Zager wrote: > > On Fri, Mar 15, 2024 at 6:29 AM Mike Taylor > wrote: > >> On 3/14/24 6:29 PM, Stefan Zager wrote: >> >>

Re: [blink-dev] Intent to Ship: SVG context-fill and context-stroke

2024-03-22 Thread Mike Taylor
LGTM1 On 3/18/24 10:53 AM, Mike Taylor wrote: Thanks on both fronts, Stefan! On 3/15/24 8:37 PM, Stefan Zager wrote: On Fri, Mar 15, 2024 at 6:29 AM Mike Taylor wrote: On 3/14/24 6:29 PM, Stefan Zager wrote: On Thu, Mar 14, 2024, 3:13 PM Mike Taylor wrote: On

Re: [blink-dev] Intent to Ship: SVG context-fill and context-stroke

2024-03-18 Thread Mike Taylor
Thanks on both fronts, Stefan! On 3/15/24 8:37 PM, Stefan Zager wrote: On Fri, Mar 15, 2024 at 6:29 AM Mike Taylor wrote: On 3/14/24 6:29 PM, Stefan Zager wrote: On Thu, Mar 14, 2024, 3:13 PM Mike Taylor wrote: On 3/14/24 1:17 PM, Stefan Zager wrote:

Re: [blink-dev] Intent to Ship: SVG context-fill and context-stroke

2024-03-15 Thread Stefan Zager
On Fri, Mar 15, 2024 at 6:29 AM Mike Taylor wrote: > On 3/14/24 6:29 PM, Stefan Zager wrote: > > On Thu, Mar 14, 2024, 3:13 PM Mike Taylor wrote: > >> On 3/14/24 1:17 PM, Stefan Zager wrote: >> > *WebKit*: No signal >> >> Can we request a signal? >> > > It strikes me as odd to request a

Re: [blink-dev] Intent to Ship: SVG context-fill and context-stroke

2024-03-15 Thread Mike Taylor
On 3/14/24 6:29 PM, Stefan Zager wrote: On Thu, Mar 14, 2024, 3:13 PM Mike Taylor wrote: On 3/14/24 1:17 PM, Stefan Zager wrote: Contact emails sza...@chromium.org Explainer None Specification

Re: [blink-dev] Intent to Ship: SVG context-fill and context-stroke

2024-03-14 Thread Stefan Zager
On Thu, Mar 14, 2024 at 8:23 PM 一丝 wrote: > Nice work, this feature is a great addition to SVG, and Rust-based resvg > also implemented it a while ago: > https://github.com/RazrFalcon/resvg/pull/665 > > Chrome's current implementation doesn't seem to include > gradients/patterns, resvg supports

Re: [blink-dev] Intent to Ship: SVG context-fill and context-stroke

2024-03-14 Thread Stefan Zager
Patterns and gradients are supported in chromium, if you have a counter example please file a bug and assign to me. On Thu, Mar 14, 2024, 8:23 PM 一丝 wrote: > Nice work, this feature is a great addition to SVG, and Rust-based resvg > also implemented it a while ago: >

Re: [blink-dev] Intent to Ship: SVG context-fill and context-stroke

2024-03-14 Thread 一丝
Nice work, this feature is a great addition to SVG, and Rust-based resvg also implemented it a while ago: https://github.com/RazrFalcon/resvg/pull/665 Chrome's current implementation doesn't seem to include gradients/patterns, resvg supports them. Any plans to implement it before shipping? If

Re: [blink-dev] Intent to Ship: SVG context-fill and context-stroke

2024-03-14 Thread Stefan Zager
On Thu, Mar 14, 2024, 3:13 PM Mike Taylor wrote: > On 3/14/24 1:17 PM, Stefan Zager wrote: > > Contact emails sza...@chromium.org > > Explainer None > > Specification https://svgwg.org/svg2-draft/painting.html#context-paint > > Summary > > Implements an existing SVG feature that allows the

Re: [blink-dev] Intent to Ship: SVG context-fill and context-stroke

2024-03-14 Thread Mike Taylor
On 3/14/24 1:17 PM, Stefan Zager wrote: Contact emails sza...@chromium.org Explainer None Specification https://svgwg.org/svg2-draft/painting.html#context-paint Summary Implements an existing SVG feature that allows the keywords 'context-fill' and

[blink-dev] Intent to Ship: SVG context-fill and context-stroke

2024-03-14 Thread Stefan Zager
Contact emailssza...@chromium.org ExplainerNone Specificationhttps://svgwg.org/svg2-draft/painting.html#context-paint Summary Implements an existing SVG feature that allows the keywords 'context-fill' and 'context-stroke' when specifying fill and stroke properties: