[
https://issues.apache.org/jira/browse/BOOKKEEPER-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552689#comment-13552689
]
Ivan Kelly commented on BOOKKEEPER-311:
---
This was committed with BOOKKEEPER-331.
[
https://issues.apache.org/jira/browse/BOOKKEEPER-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424749#comment-13424749
]
Flavio Junqueira commented on BOOKKEEPER-311:
-
The Sun conventions say
[
https://issues.apache.org/jira/browse/BOOKKEEPER-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424774#comment-13424774
]
Mridul Muralidharan commented on BOOKKEEPER-311:
The line length was
[
https://issues.apache.org/jira/browse/BOOKKEEPER-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424777#comment-13424777
]
Flavio Junqueira commented on BOOKKEEPER-311:
-
One issue, unrelated to
[
https://issues.apache.org/jira/browse/BOOKKEEPER-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424780#comment-13424780
]
Uma Maheswara Rao G commented on BOOKKEEPER-311:
Yes, 80 characters
[
https://issues.apache.org/jira/browse/BOOKKEEPER-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424784#comment-13424784
]
Mridul Muralidharan commented on BOOKKEEPER-311:
Could be added as
[
https://issues.apache.org/jira/browse/BOOKKEEPER-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13424896#comment-13424896
]
Sijie Guo commented on BOOKKEEPER-311:
--
{quote}
IMO, we have to be very strict
[
https://issues.apache.org/jira/browse/BOOKKEEPER-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420570#comment-13420570
]
Sijie Guo commented on BOOKKEEPER-311:
--
@Flavio,
There is one TODO in the
[
https://issues.apache.org/jira/browse/BOOKKEEPER-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13420587#comment-13420587
]
Mridul Muralidharan commented on BOOKKEEPER-311:
Sijie Guo has
[
https://issues.apache.org/jira/browse/BOOKKEEPER-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13409242#comment-13409242
]
Sijie Guo commented on BOOKKEEPER-311:
--
for consume request:
1) the changes
[
https://issues.apache.org/jira/browse/BOOKKEEPER-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13409319#comment-13409319
]
Mridul Muralidharan commented on BOOKKEEPER-311:
bq. 1) the changes
[
https://issues.apache.org/jira/browse/BOOKKEEPER-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13409321#comment-13409321
]
Mridul Muralidharan commented on BOOKKEEPER-311:
I think I messed up
[
https://issues.apache.org/jira/browse/BOOKKEEPER-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13409467#comment-13409467
]
Sijie Guo commented on BOOKKEEPER-311:
--
thanks for Mridul for explaining details.
[
https://issues.apache.org/jira/browse/BOOKKEEPER-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402165#comment-13402165
]
Mridul Muralidharan commented on BOOKKEEPER-311:
bq. Also, it would
14 matches
Mail list logo
