Re: [Bridge] [PATCH net-next 0/4] Allow bridge to function in non-promisc mode

2013-03-13 Thread Stephen Hemminger
On Wed, 13 Mar 2013 11:45:40 -0400 Vlad Yasevich vyase...@redhat.com wrote: On 03/13/2013 11:39 AM, Stephen Hemminger wrote: On Wed, 13 Mar 2013 08:12:29 -0400 Vlad Yasevich vyase...@redhat.com wrote: On 03/13/2013 02:22 AM, Oleg A. Arkhangelsky wrote: 13.03.2013, 05:45, Vlad

Re: [Bridge] [PATCH net-next 2/4] bridge: Allow an ability to designate an uplink port

2013-03-13 Thread Stephen Hemminger
On Wed, 13 Mar 2013 22:33:33 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Mar 12, 2013 at 09:45:24PM -0400, Vlad Yasevich wrote: Allow a ports to be designated as uplink. Multiple ports may be designated as uplinks and they will be kept in a list. Signed-off-by: Vlad

Re: [Bridge] [RFC PATCH v2 net-next 0/3] Allow bridge to function in non-promisc mode

2013-03-08 Thread Stephen Hemminger
On Fri, 08 Mar 2013 16:23:53 -0500 Vlad Yasevich vyase...@redhat.com wrote: On 03/08/2013 10:17 AM, Vlad Yasevich wrote: On 03/08/2013 12:43 AM, Stephen Hemminger wrote: On Thu, 7 Mar 2013 16:28:45 -0500 Vlad Yasevich vyase...@redhat.com wrote: The series adds an ability to configure

Re: [Bridge] [RFC PATCH v2 net-next 0/3] Allow bridge to function in non-promisc mode

2013-03-07 Thread Stephen Hemminger
On Thu, 7 Mar 2013 16:28:45 -0500 Vlad Yasevich vyase...@redhat.com wrote: The series adds an ability to configure the bridge into a non-primiscuous mode. Instead, it provides the ability to identitfy some set of bridge ports as uplinks and allows for MAC addresses to be programmed onto

Re: [Bridge] [PATCH net-next V6 02/14] bridge: Add vlan filtering infrastructure

2013-02-05 Thread Stephen Hemminger
On Sun, 20 Jan 2013 12:59:22 -0500 Vlad Yasevich vyase...@redhat.com wrote: On 01/17/2013 08:57 PM, Michał Mirosław wrote: 2013/1/16 Vlad Yasevich vyase...@redhat.com: [...] --- /dev/null +++ b/net/bridge/br_vlan.c [...] +struct net_port_vlan *nbp_vlan_find(const struct

Re: [Bridge] [PATCH net-next v5 01/14] vlan: wrap hw-acceleration calls in separate functions.

2013-01-10 Thread Stephen Hemminger
On Wed, 9 Jan 2013 12:17:48 -0500 Vlad Yasevich vyase...@redhat.com wrote: /** + * vlan_hw_buggy - Check to see if VLAN hw acceleration is supported. + * @dev: netdevice of the lowerdev/hw nic + * + * Checks to see if HW and driver report VLAN acceleration correctly. + */ +static

Re: [Bridge] [PATCH net-next v5 02/14] bridge: Add vlan filtering infrastructure

2013-01-10 Thread Stephen Hemminger
This patch has some minor whitespace and spelling errors: WARNING: line over 80 characters #429: FILE: net/bridge/br_private.h:205: +static inline struct net_bridge_port *vlans_to_port(struct net_port_vlans *vlans) ERROR: trailing whitespace #432: FILE: net/bridge/br_private.h:208: + $

Re: [Bridge] [PATCH net-next v5 01/14] vlan: wrap hw-acceleration calls in separate functions.

2013-01-10 Thread Stephen Hemminger
On Thu, 10 Jan 2013 13:41:58 -0500 Vlad Yasevich vyase...@redhat.com wrote: On 01/10/2013 01:25 PM, Stephen Hemminger wrote: On Wed, 9 Jan 2013 12:17:48 -0500 Vlad Yasevich vyase...@redhat.com wrote: /** + * vlan_hw_buggy - Check to see if VLAN hw acceleration is supported

Re: [Bridge] [PATCH 3/3] iproute2: make `bridge mdb` output consistent with input

2012-12-20 Thread Stephen Hemminger
On Thu, 20 Dec 2012 22:31:55 +0800 Cong Wang amw...@redhat.com wrote: bridge - dev group - grp All three patches accepted for next version of iproute2.

Re: [Bridge] [PATCH] iproute2: update usage info of bridge monitor

2012-12-14 Thread Stephen Hemminger
On Fri, 14 Dec 2012 13:59:32 +0800 Cong Wang amw...@redhat.com wrote: Cc: Stephen Hemminger shemmin...@vyatta.com Signed-off-by: Cong Wang amw...@redhat.com --- diff --git a/bridge/monitor.c b/bridge/monitor.c index 44e14d8..29bb931 100644 --- a/bridge/monitor.c +++ b/bridge/monitor.c

Re: [Bridge] [PATCH] bridge: Bug fix for incorrect interpretation of MLDv2 maximum response code

2012-12-13 Thread Stephen Hemminger
On Fri, 14 Dec 2012 08:07:01 +0800 Ang Way Chuang wc...@sfc.wide.ad.jp wrote: This patch fixes the incorrect interpretation of endianness of MLDv2 maximum response code within bridge's multicast snooping code. Signed-off-by: Ang Way Chuang wc...@sfc.wide.ad.jp --- diff --git

Re: [Bridge] [PATCH] bridge: Bug fix for incorrect interpretation of MLDv2 maximum response code

2012-12-13 Thread Stephen Hemminger
On Fri, 14 Dec 2012 08:19:04 +0800 Ang Way Chuang wc...@sfc.wide.ad.jp wrote: On 14/12/2012 08:12, Stephen Hemminger wrote: On Fri, 14 Dec 2012 08:07:01 +0800 Ang Way Chuang wc...@sfc.wide.ad.jp wrote: This patch fixes the incorrect interpretation of endianness of MLDv2 maximum

Re: [Bridge] [PATCH 2/2] iproute2: add support to monitor mdb entries too

2012-12-12 Thread Stephen Hemminger
On Wed, 12 Dec 2012 16:23:10 +0800 Cong Wang amw...@redhat.com wrote: From: Cong Wang amw...@redhat.com This patch implements `bridge monitor mdb`. Cc: Stephen Hemminger shemmin...@vyatta.com Cc: Thomas Graf tg...@suug.ch Signed-off-by: Cong Wang amw...@redhat.com Accepted for 3.8

Re: [Bridge] [PATCH net-next v5] bridge: export multicast database via netlink

2012-12-11 Thread Stephen Hemminger
-specific. We may need to support modify multicast database too (RTM_{ADD,DEL}MDB). (Thanks to Thomas for patient reviews) Cc: Herbert Xu herb...@gondor.apana.org.au Cc: Stephen Hemminger shemmin...@vyatta.com Cc: David S. Miller da...@davemloft.net Cc: Thomas Graf tg...@suug.ch Cc: Jesper

Re: [Bridge] [PATCH v4] iproute2: add mdb sub-command to bridge

2012-12-07 Thread Stephen Hemminger
# ./bridge/bridge mdb bridge br0: port eth0, group 224.8.8.9 port eth1, group 224.8.8.8 I like the ability to see what is going on. It would be good if there was also a monitor like hook to see new entries created and destroyed (later version). The output format

Re: [Bridge] [patch v2] bridge: make buffer larger in br_setlink()

2012-12-07 Thread Stephen Hemminger
nlmsghdr *nlh) struct ifinfomsg *ifm; struct nlattr *protinfo; struct net_bridge_port *p; - struct nlattr *tb[IFLA_BRPORT_MAX]; + struct nlattr *tb[IFLA_BRPORT_MAX + 1]; int err; ifm = nlmsg_data(nlh); Acked-by: Stephen Hemminger shemmin

Re: [Bridge] [PATCH net-next v2] bridge: export multicast database via netlink

2012-12-04 Thread Stephen Hemminger
netlink message type RTM_GETMDB. Similar to fdb, but currently bridge-specific. We may need to support modify multicast database too (RTM_{ADD,DEL}MDB). Cc: Herbert Xu herb...@gondor.apana.org.au Cc: Stephen Hemminger shemmin...@vyatta.com Cc: David S. Miller da...@davemloft.net Cc: Thomas

Re: [Bridge] [PATCH net-next v1 1/2] bridge: export port_no and port_id via IFA_INFO_DATA

2012-11-30 Thread Stephen Hemminger
On Fri, 30 Nov 2012 17:58:32 +0800 Cong Wang amw...@redhat.com wrote: port_no will be used to get ifindex of a port in user-space, export it togather with port_id. Cc: Herbert Xu herb...@gondor.apana.org.au Cc: Stephen Hemminger shemmin...@vyatta.com Cc: David S. Miller da...@davemloft.net

Re: [Bridge] [patch net-next v2 01/15] net: introduce upper device lists

2012-08-14 Thread Stephen Hemminger
On Tue, 14 Aug 2012 23:33:44 +0100 Ben Hutchings bhutchi...@solarflare.com wrote: On Tue, 2012-08-14 at 17:05 +0200, Jiri Pirko wrote: This lists are supposed to serve for storing pointers to all upper devices. Eventually it will replace dev-master pointer which is used for bonding,

Re: [Bridge] [PATCH 4/7] bridge: call NETDEV_RELEASE notifier in br_del_if()

2012-07-27 Thread Stephen Hemminger
On Fri, 27 Jul 2012 23:38:01 +0800 Cong Wang amw...@redhat.com wrote: When a bridge interface deletes its underlying ports, it should notify netconsole too, like what bonding interface does. Cc: David S. Miller da...@davemloft.net Signed-off-by: Cong Wang amw...@redhat.com ---

Re: [Bridge] [PATCH] bridge: fix entering disabled state logging

2012-03-06 Thread Stephen Hemminger
is that it was introduced: 2010-05-16stephen hemminger bridge: change console message interface 28a16c97963d3bc36a2c192859f6d8025ef2967a and no one noticed since then :D The message could be corrected to have correct verb tense. s/entering/entered/ Acked-by: Stephen Hemminger shemmin

Re: [Bridge] [PATCH 4/4] br_device: unify return value of .ndo_set_mac_address if address is invalid

2012-02-21 Thread Stephen Hemminger
-by: Stephen Hemminger shemmin...@vyatta.com ___ Bridge mailing list Bridge@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/bridge

Re: [Bridge] [PATCH] net: bridge: netfilter: Fix dependency for BRIDGE_NF_EBTABLES

2012-01-10 Thread Stephen Hemminger
On Tue, 10 Jan 2012 23:48:25 -0200 Fabio Estevam feste...@gmail.com wrote: Fix the following build warning: warning: (BRIDGE_NF_EBTABLES) selects NETFILTER_XTABLES which has unmet direct dependencies (NET INET NETFILTER) Signed-off-by: Fabio Estevam fabio.este...@freescale.com ---

Re: [Bridge] [PATCH] netfilter: Fix br_nf_pre_routing() in conjunction with bridge-nf-call-ip(6)tables=0

2012-01-03 Thread Stephen Hemminger
On Tue, 3 Jan 2012 14:26:04 +0100 Richard Weinberger rich...@nod.at wrote: If net.bridge.bridge-nf-call-iptables or net.bridge.bridge-nf-call-ip6tables are set to zero xt_physdev has no effect because skb-nf_bridge has not been set up. Signed-off-by: Richard Weinberger rich...@nod.at I

Re: [Bridge] [PATCH] bridge: push blocking slaves to forwarding when turning stp off

2011-12-13 Thread Stephen Hemminger
On Tue, 13 Dec 2011 11:36:25 +0200 Vitalii Demianets vi...@nppfactor.kiev.ua wrote: If there is a slave in blocking state when stp is turned off, that slave will remain in blocking state for indefinitely long time until interface state changed. We should push all blocking slaves into

Re: [Bridge] [PATCH] bridge: Cannot communicate with brX when its MAC address is changed

2011-12-01 Thread Stephen Hemminger
On Wed, 30 Nov 2011 17:31:18 +0900 Koki Sanagi sanagi.k...@jp.fujitsu.com wrote: When the MAC address of a bridge interface is changed, it cannot communicate with others. Because Whether or not a packet should be transferred to bridge interface depends on whether or not dst of a packet is in

Re: [Bridge] [PATCH] bridge: master device stuck in no-carrier state forever when in user-stp mode

2011-12-01 Thread Stephen Hemminger
similar regarding master following slaves' states. Signed-off-by: Vitalii Demianets vi...@nppfactor.kiev.ua This method works fine. David please apply to -net. Acked-by: Stephen Hemminger shemmin...@vyatta.com ___ Bridge mailing list Bridge

Re: [Bridge] sky2 hw csum failure

2011-11-15 Thread Stephen Hemminger
On Tue, 15 Nov 2011 18:28:55 +0800 Yan, Zheng zheng.z@intel.com wrote: I re-tested the checksum code, both CHECKSUM_NONE and CHECKSUM_COMPLETE cases are OK. Maybe the bug is related to sky2. Regards Yan, Zheng There are three types of receive checksumming: 1. Hardware does not do

[Bridge] [RFT] bridge: checksum not updated after pull

2011-11-15 Thread Stephen Hemminger
checksum needs to be adjusted. Signed-off-by: Stephen Hemminger shemmin...@vyatta.com --- a/net/bridge/br_multicast.c 2011-11-09 13:55:00.028012483 -0800 +++ b/net/bridge/br_multicast.c 2011-11-15 10:05:06.171314194 -0800 @@ -1501,7 +1501,9 @@ static int br_multicast_ipv6_rcv(struct

Re: [Bridge] [PATCH] bridge: Reset IPCB on forward non-local packets in br_handle_frame_finish()

2011-11-02 Thread Stephen Hemminger
On Wed, 02 Nov 2011 23:08:57 +0400 Vasily Averin v...@parallels.com wrote: if dst is not local br_handle_frame_finish() does not clone original skb and forgets to reset IPCB before return to IP stack. it can lead to stack corruption in icmp_send() Signed-off-by: Vasily Averin v...@sw.ru

Re: [Bridge] [PATCH] bridge: Reset IPCB on forward non-local packets in br_handle_frame_finish()

2011-11-02 Thread Stephen Hemminger
On Wed, 2 Nov 2011 13:45:29 -0600 Daniel Robbins drobb...@funtoo.org wrote: On Wed, Nov 2, 2011 at 1:31 PM, Stephen Hemminger shemmin...@vyatta.com wrote: What kernel version are you using? There were several previous fixes in br_netfilter to deal with this type of issue over the last

Re: [Bridge] [PATCH] skip . and .. in accurately in isbridge()

2011-09-07 Thread Stephen Hemminger
On Wed, 7 Sep 2011 15:33:13 +0800 Xiaochen Wang wangxiaoch...@gmail.com wrote: On Tue, Sep 6, 2011 at 12:43 AM, Stephen Hemminger shemmin...@vyatta.com wrote: On Mon, 5 Sep 2011 22:58:07 +0800 Xiaochen Wang wangxiaoch...@gmail.com wrote: Hi all,  In commit f88f8 Skip

Re: [Bridge] [PATCH] skip . and .. in accurately in isbridge()

2011-09-05 Thread Stephen Hemminger
On Mon, 5 Sep 2011 22:58:07 +0800 Xiaochen Wang wangxiaoch...@gmail.com wrote: Hi all, In commit f88f8 Skip . and .. in foreach_bridge test, the code skips all directories starting with dot. But if we create a bridge staring with dot, e.g. `.br0`, then `brctl show` cannot show this

Re: [Bridge] [patch net-next-2.6] br: remove redundant check and init

2011-09-01 Thread Stephen Hemminger
; + case SPEED_10: + return 100; } } Yeah, this code predates when ethtool was sane about ops Acked-by: Stephen Hemminger shemmin...@vyatta.com ___ Bridge mailing list Bridge@lists.linux-foundation.org

[Bridge] [RFC] bridge: add netfilter hook for forwarding 802.1D group addresses

2011-08-19 Thread Stephen Hemminger
processed on the local host and not forwarded. Spanning Tree Packets are treated specially and do not go through the new chain. This code is conceptual design concept only. It compiles but hasn't been tested. Signed-off-by: Stephen Hemminger shemmin...@vyatta.com --- include/linux

Re: [Bridge] [RFC] bridge: add netfilter hook for forwarding 802.1D group addresses

2011-08-19 Thread Stephen Hemminger
On Fri, 19 Aug 2011 17:18:04 -0500 Christian Benvenuti (benve) be...@cisco.com wrote: The patch description and the code are clearly saying that STP is an exception, but I am just worried about the users. Maybe a proper description in the iptables help is sufficient. Users may otherwise try

Re: [Bridge] [RFC] bridge: allow passing link-local multicast

2011-08-18 Thread Stephen Hemminger
On Thu, 18 Aug 2011 16:06:19 +0100 Nick Carter ncarter...@gmail.com wrote: Why can't we use the 802.1D specified STP group address to identify ? The existing code uses that address. I know you said on another thread that there are people using other addresses. Who are these people ? Are they

[Bridge] [RFC] bridge: allow passing link-local multicast

2011-08-15 Thread Stephen Hemminger
options that are needed and this is a better way to enable them. Thanks to David Lamparter, and others for bringing this up. Users who need this facility should provide feedback, is this a usable solution? Signed-off-by: Stephen Hemminger shemmin...@vyatta.com --- Patch against net-next

Re: [Bridge] possible bridge regression in bridge: implement [add/del]_slave ops?

2011-07-05 Thread Stephen Hemminger
I just put a fix for the detection of bridge pseudo-device being up into the current rstp code available at: git://git.kernel.org/pub/scm/linux/kernel/git/shemminger/rstp.git ___ Bridge mailing list Bridge@lists.linux-foundation.org

Re: [Bridge] Bridge interface always down since Linux = 2.6.39

2011-06-30 Thread Stephen Hemminger
On Thu, 30 Jun 2011 15:05:36 +0200 Arnaud Fontaine ar...@milkypond.org wrote: Hello, After upgrading my kernel to 2.6.39 (I also tested with 3.0.0-rc4), my bridge interface with only TAP interfaces is always down (the flag is NO_CARRIER and operational state is DOWN) despite it was

Re: [Bridge] possible bridge regression in bridge: implement [add/del]_slave ops?

2011-06-30 Thread Stephen Hemminger
On Thu, 30 Jun 2011 15:27:19 +0200 Alexander Stein alexander.st...@systec-electronic.com wrote: On Thursday 30 June 2011 10:33:23 Alexander Stein wrote: BTW: I noticed that in 2.6.39.2 independently from this patch revert this bridge didn't show up RUNNING ifconfg. Is this intended? Another

Re: [Bridge] [Patch] bridge: call NETDEV_ENSLAVE notifiers when adding a slave

2011-05-19 Thread Stephen Hemminger
On Thu, 19 May 2011 18:24:17 +0800 Amerigo Wang amw...@redhat.com wrote: In the previous patch I added NETDEV_ENSLAVE, now we can notify netconsole when adding a device to a bridge too. By the way, s/netdev_bonding_change/call_netdevice_notifiers/ in bond_main.c, since this is not bonding

Re: [Bridge] Bug#625914: linux-image-2.6.38-2-amd64: bridging is not interacting well with multicast in 2.6.38-4

2011-05-13 Thread Stephen Hemminger
On Tue, 10 May 2011 16:35:40 -0700 Noah Meyerhans no...@debian.org wrote: On Tue, May 10, 2011 at 03:11:00PM -0700, Stephen Hemminger wrote: There were two more follow on commits in stable related to this. I recommend merging 2.6.38.6 which includes these. The problem still exists

[Bridge] [PATCH] bridge: fix forwarding of IPv6

2011-05-13 Thread Stephen Hemminger
The commit 6b1e960fdbd75dcd9bcc3ba5ff8898ff1ad30b6e bridge: Reset IPCB when entering IP stack on NF_FORWARD broke forwarding of IPV6 packets in bridge because it would call bp_parse_ip_options with an IPV6 packet. Reported-by: Noah Meyerhans no...@debian.org Signed-off-by: Stephen Hemminger

Re: [Bridge] Bug#625914: linux-image-2.6.38-2-amd64: bridging is not interacting well with multicast in 2.6.38-4

2011-05-12 Thread Stephen Hemminger
On Thu, 12 May 2011 15:59:16 -0700 (PDT) David Miller da...@davemloft.net wrote: From: Noah Meyerhans no...@debian.org Date: Tue, 10 May 2011 16:35:40 -0700 On Tue, May 10, 2011 at 03:11:00PM -0700, Stephen Hemminger wrote: There were two more follow on commits in stable related

Re: [Bridge] Bug#625914: linux-image-2.6.38-2-amd64: bridging is not interacting well with multicast in 2.6.38-4

2011-05-10 Thread Stephen Hemminger
. This patch fixes the problem. Signed-off-by: Herbert Xu herb...@gondor.apana.org.au Acked-by: Stephen Hemminger shemmin...@vyatta.com Signed-off-by: David S. Miller da...@davemloft.net Signed-off-by: Greg Kroah-Hartman gre...@suse.de The diff is diff --git a/net/bridge

Re: [Bridge] Bridge and authentication

2011-05-04 Thread Stephen Hemminger
On Wed, 4 May 2011 15:21:41 +0200 IMS ims77@gmail.com wrote: Hello, I'm trying to configure an Ubuntu server with 2 wired interfaces set as a bridge and I want a radius authentication on each interfaces. I'm able to set my configuration files to have a bridge between the 2 interfaces

Re: [Bridge] Bugs fixed on Debian's bridge-utils

2011-05-03 Thread Stephen Hemminger
On Tue, 3 May 2011 18:23:43 +0200 Santiago Garcia Mantinan ma...@debian.org wrote: Hi! As the Debian's maintainer of bridge-utils on my last upload to Debian I cared to comment the source stating the bugs we had fixed on bridge-utils on Debian that are still opened on your upstream version,

Re: [Bridge] [PATCH] bridge: Module use count must be updated as bridges are created/destroyed

2011-04-29 Thread Stephen Hemminger
On Fri, 29 Apr 2011 00:25:30 -0700 (PDT) David Miller da...@davemloft.net wrote: From: Jan Beulich jbeul...@novell.com Date: Fri, 29 Apr 2011 08:21:14 +0100 Otherwise 'modprobe -r' on a module having a dependency on bridge will implicitly unload bridge, bringing down all connectivity that

Re: [Bridge] no wireless interfaces?

2011-04-29 Thread Stephen Hemminger
On Fri, 29 Apr 2011 11:36:28 -0500 jharvell+lists.bri...@dogpad.net jharvell+lists.bri...@dogpad.net wrote: I tried to bridge a wireless interface to a wired Ethernet interface, and it failed with Operation not supported. Looking at the kernel code, it seems like this is intentional. I

Re: [Bridge] brctl problem: broadcast doesn't get through

2011-04-24 Thread Stephen Hemminger
On Sun, 24 Apr 2011 17:04:47 +0200 Ireneusz Szcześniak irek.szczesn...@gmail.com wrote: Hi, I'm creating a bridge, and then add to it two tap interfaces. No physical interface is added to the bridge. These are the commands: brctl addbr test ip tuntap add mode tap tap0 ip tuntap add

Re: [Bridge] [PATCH] bridge: return value for br_stp_recalculate_bridge_id()

2011-03-30 Thread Stephen Hemminger
On Wed, 30 Mar 2011 14:23:27 +0800 Dongdong Deng dongdong.d...@windriver.com wrote: Return 'false' for user has set a mac addr case in br_stp_recalculate_bridge_id() function. and this could address the following build warning: net/bridge/br_stp_if.c: In function

Re: [Bridge] [PATCH] BRIDGE: As per 802.1D clause 9.3.4 Added support to prevent processing port's own BPDU (If a loopback condition exists)

2011-03-30 Thread Stephen Hemminger
On Wed, 30 Mar 2011 21:03:36 +0530 Sasikanth V sasikanth@gmail.com wrote: Signed-off-by: Sasikanth V sasikanth@gmail.com --- net/bridge/br_private.h |1 + net/bridge/br_stp.c | 20 ++-- net/bridge/br_stp_if.c|2 ++ net/bridge/br_stp_timer.c |

Re: [Bridge] promiscuous mode necessary for supporting KVM?

2011-03-28 Thread Stephen Hemminger
On Mon, 28 Mar 2011 09:29:25 -0500 Scott Koranda skora...@gmail.com wrote: My platform is Debian Squeeze amd64: $ /etc/network# cat /etc/issue Debian GNU/Linux 6.0 \n \l $ /etc/network# uname -r 2.6.32-5-amd64 I followed what I believe to be the canonical instructions for deploying

[Bridge] [ANNOUNCE] bridge-utils 1.5

2011-03-28 Thread Stephen Hemminger
) to the net...@vger.kernel.org mailing list. Changelog: Anton Danilov (1): show selected bridge Fischer, Anna (1): bridge-utils: Add 'hairpin' port forwarding mode Stephen Hemminger (8): don't install libbridge.a use proper version of install in doc/Makefile Check

[Bridge] [PATCH] bridge: notify applications if address of bridge device changes

2011-03-24 Thread Stephen Hemminger
-by: Stephen Hemminger shemmin...@vyatta.com --- net/bridge/br_if.c |6 +- net/bridge/br_private.h |2 +- net/bridge/br_stp_if.c |9 ++--- net/core/dev.c |1 + 4 files changed, 13 insertions(+), 5 deletions(-) --- a/net/bridge/br_stp_if.c2011-03-22 10:13

Re: [Bridge] build breakage due to br_multicast.c referencing ipv6_dev_get_saddr()

2011-03-16 Thread Stephen Hemminger
On Wed, 16 Mar 2011 12:34:19 + Jan Beulich jbeul...@novell.com wrote: With BRIDGE=y and IPV6=m commit fe29ec41aaa51902aebd63658dfb04fe6fea8be5 (bridge: Use IPv6 link-local address for multicast listener queries) causes the build to break. Rather than continue with the config games, lets

Re: [Bridge] [PATCH 1/2] Issue NETDEV_CHANGE notification when bridge changes state

2011-03-06 Thread Stephen Hemminger
On Sun, Mar 06, 2011 at 09:45:41AM -0800, Stephen Hemminger wrote: Since this a generic problem, it needs a better solution. Sending NETDEV_CHANGE impacts lots of other pieces, and even user space has similar problems. It does seem a little broad notification type. I've checked over

Re: [Bridge] [PATCH 1/2] Issue NETDEV_CHANGE notification when bridge changes state

2011-03-05 Thread Stephen Hemminger
Why not set forwarding delay to zero? I don't think you are using STP? P.s: removing linux-kernel mailing list, since there is no point in copying the whole world on this thread. ___ Bridge mailing list Bridge@lists.linux-foundation.org

Re: [Bridge] Multicast snooping fixes and suggestions

2011-02-23 Thread Stephen Hemminger
On Wed, 23 Feb 2011 21:57:32 -0800 H. Peter Anvin h...@zytor.com wrote: Ok, so stupid question... how do hardware switches deal with this? It would seem to me that if everyone behind say a Cisco switch had these kind of issues they would have limited appeal... Real bridges run current

Re: [Bridge] Multicast snooping fixes and suggestions

2011-02-17 Thread Stephen Hemminger
On Wed, 16 Feb 2011 00:19:16 +0100 Linus Lüssing linus.luess...@web.de wrote: Hello everyone, While testing the (very awesome!) bridge igmp/mld snooping support I came across two issues which are breaking IPv6 multicast snooping and IPv6 non-link-local multicast on bridges with multicast

Re: [Bridge] Problem configuring bridge as a hub between host server and running VM guest

2011-02-16 Thread Stephen Hemminger
On Fri, 4 Feb 2011 11:17:29 -0500 Ravi Varun Nair rvn...@us.ibm.com wrote: What I am trying to do is have a copy of all the traffic coming in on the physical interface be given to the VM. T A better way is to use tc mirred action to mirror packets to a dummy or other interface. --

Re: [Bridge] mac addresses of local interfaces do not obey setageing 0

2011-02-16 Thread Stephen Hemminger
On Wed, 9 Feb 2011 19:17:52 +0100 Veaceslav Falico vfal...@redhat.com wrote: Hello, I have a host and a VM inside this host bridged. I've set ageing_time and forward_delay to 0 and trying to capture all the traffic that goes through that bridge from my VM, but it fails to capture the

Re: [Bridge] rstp solutions

2011-01-03 Thread Stephen Hemminger
On Sun, 2 Jan 2011 09:38:50 +0200 tamar zeiri tamarzeiri...@gmail.com wrote: Hi all Can anyone recommend the best solution for rstp (2.6 kernel)? Did anyone work with rstplib on real bridges? Thanks Did you look at rstp daemon?

Re: [Bridge] [PATCH] net: bridge: check the length of skb after nf_bridge_maybe_copy_header()

2011-01-03 Thread Stephen Hemminger
On Mon, 03 Jan 2011 09:22:14 -0800 (PST) David Miller da...@davemloft.net wrote: From: Changli Gao xiao...@gmail.com Date: Mon, 3 Jan 2011 18:44:59 +0800 On Sat, Jan 1, 2011 at 3:10 AM, David Miller da...@davemloft.net wrote: From: Changli Gao xiao...@gmail.com Date: Sat, 25 Dec 2010

Re: [Bridge] rstp solutions

2011-01-03 Thread Stephen Hemminger
On Mon, 3 Jan 2011 15:43:53 -0500 Ryan Whelan rcwhe...@gmail.com wrote: there haven't been any updates to it in years, is it still being maintained? It never got packaged or widely used. I want to do something better but never seem to get the time.

Re: [Bridge] Why should static MAC address match one of the port MAC addresses - bug?

2010-12-26 Thread Stephen Hemminger
On Sun, 26 Dec 2010 18:21:58 +0100 Rolf Fokkens rolf.fokk...@wanadoo.nl wrote: In this particular situation it's not possible to do so as all interfaces are tap interfaces, with random generated MAC addresses. Changing the tap interface's MAC address results in this: [r...@home01 ~]#

Re: [Bridge] [PATCH] bridge: Fix return value of br_multicast_add_group()

2010-12-09 Thread Stephen Hemminger
On Thu, 9 Dec 2010 15:02:36 +0100 Tobias Klauser tklau...@distanz.ch wrote: If br_multicast_new_group returns NULL, we would return 0 (no error) to the caller, which is not what we want. Instead we should return -ENOMEM in this case. Also replace IS_ERR(x) || !x by IS_ERR_OR_NULL(x)

Re: [Bridge] ksoftirqd process

2010-12-09 Thread Stephen Hemminger
On Thu, 9 Dec 2010 21:44:28 +0530 Pravin Pardeshi pravin.parde...@tcs.com wrote: Hi, I want to have bridge for two NICs (eth0 and eth1) with Knoppix 6.2 Live CD on virtualbox. I tried the following commands; # brctl addbr br0 # brctl sethello 30 # brctl stp br0 off # ifconfig eth0

Re: [Bridge] Disable mac address learning

2010-11-27 Thread Stephen Hemminger
On Sat, 27 Nov 2010 16:46:34 -0500 Benjamin Vanheuverzwijn bvan...@gmail.com wrote: Hi, Is there a way to disable the mac address learning in linux using brctl or custom code so any packet sent to the bridge will be flooded in each interfaces. I would like to do something similar as

Re: [Bridge] [PATCH 0/5] bridge: RCU annotation and cleanup

2010-11-15 Thread Stephen Hemminger
On Mon, 15 Nov 2010 21:23:37 +0900 Tetsuo Handa penguin-ker...@i-love.sakura.ne.jp wrote: + rp = rcu_dereference(hlist_next_rcu(rp-next)); I think this one is hlist_next_rcu(rp). Yes, you are correct. -- ___ Bridge mailing

[Bridge] [PATCH 0/5] bridge: RCU annotation and cleanup

2010-11-14 Thread Stephen Hemminger
This is a split up of what Eric did with a couple of small changes and additions. ___ Bridge mailing list Bridge@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/bridge

[Bridge] [PATCH 5/5] bridge: add RCU annotations to bridge port lookup

2010-11-14 Thread Stephen Hemminger
eric.duma...@gmail.com Signed-off-by: Stephen Hemminger shemmin...@vyatta.com --- net/bridge/br_if.c |2 +- net/bridge/br_netlink.c |4 ++-- net/bridge/br_notify.c |4 ++-- net/bridge/br_private.h |9 + 4 files changed, 10 insertions(+), 9 deletions(-) --- a/net/bridge

[Bridge] [PATCH 2/5] bridge: add proper RCU annotation to should_route_hook

2010-11-14 Thread Stephen Hemminger
From: Eric Dumazet eric.duma...@gmail.com Add br_should_route_hook_t typedef, this is the only way we can get a clean RCU implementation for function pointer. Signed-off-by: Eric Dumazet eric.duma...@gmail.com Signed-off-by: Stephen Hemminger shemmin...@vyatta.com --- include/linux/if_bridge.h

[Bridge] [PATCH 3/5] netdev: add rcu annotations to receive handler hook

2010-11-14 Thread Stephen Hemminger
Suggested by Eric's bridge RCU changes. Signed-off-by: Stephen Hemminger shemmin...@vyatta.com --- include/linux/netdevice.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/include/linux/netdevice.h 2010-11-14 11:41:53.224298362 -0800 +++ b/include/linux/netdevice.h 2010-11

[Bridge] [PATCH 4/5] bridge: fix RCU races with bridge port

2010-11-14 Thread Stephen Hemminger
The macro br_port_exists() is not enough protection when only RCU is being used. There is a tiny race where other CPU has cleared port handler hook, but is bridge port flag might still be set. Signed-off-by: Stephen Hemminger shemmin...@vyatta.com --- net/bridge/br_fdb.c | 15

[Bridge] [PATCH 1/5] bridge: add RCU annotation to bridge multicast table

2010-11-14 Thread Stephen Hemminger
From: Eric Dumazet eric.duma...@gmail.com Add modern __rcu annotatations to bridge multicast table. Signed-off-by: Eric Dumazet eric.duma...@gmail.com Signed-off-by: Stephen Hemminger shemmin...@vyatta.com --- net/bridge/br_forward.c |4 +- net/bridge/br_multicast.c | 78

Re: [Bridge] DHCP problem on bridge

2010-11-06 Thread Stephen Hemminger
On Sun, 31 Oct 2010 00:31:11 +0800 Kian Yang Liew liewkiany...@gmail.com wrote: Dear All, I have a network with 500 vlan and I bind all these 500 vlan into 1 bridge interface. Then I have run a dhcp server on this bridge interface to provide dhcp to all the computer in the vlan. It look

Re: [Bridge] EAPOL bridging

2010-10-18 Thread Stephen Hemminger
On Sun, 17 Oct 2010 14:06:28 -0400 Benjamin Poirier benjamin.poir...@gmail.com wrote: Hello, I have some trouble bridging EAPOL frames. I'd like to do this to allow wired 802.1x authentication from within a kvm virtual machine. I have the following setup: kvm -- tap0 -- br0 -- eth1 --

Re: [Bridge] [PATCH] bridge: Forward reserved group addresses if !STP

2010-10-18 Thread Stephen Hemminger
-by: Benjamin Poirier benjamin.poir...@polymtl.ca Signed-off-by: Stephen Hemminger shemmin...@vyatta.com ___ Bridge mailing list Bridge@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/bridge

Re: [Bridge] Giving enslaved interface an IP?

2010-10-18 Thread Stephen Hemminger
On Mon, 18 Oct 2010 19:16:18 -0700 Thomas Taranowski t...@baringforge.com wrote: I have bridged eth0 and eth1, where eth0 is the world, and eth1 has some locally administered targets with normal IPs. On eth1, I also have some other devices with 192.168.x.x addresses I locally assigned. I'd

Re: [Bridge] F13 bridge issues

2010-10-13 Thread Stephen Hemminger
On Wed, 13 Oct 2010 11:27:18 -0400 Mark Liggett mligg...@btisystems.com wrote: Hi everyone, I'm using Ethernet bridging on an up-to-date F13 system. I've created a bridge adapter br0 and added eth2 and eth3 to it. Everything works as expected for a short time before the 2 Ethernet cards

Re: [Bridge] F13 bridge issues

2010-10-13 Thread Stephen Hemminger
On Wed, 13 Oct 2010 11:27:18 -0400 Mark Liggett mligg...@btisystems.com wrote: Hi everyone, I'm using Ethernet bridging on an up-to-date F13 system. I've created a bridge adapter br0 and added eth2 and eth3 to it. Everything works as expected for a short time before the 2 Ethernet cards

Re: [Bridge] About local delivery of bridged packets

2010-10-12 Thread Stephen Hemminger
On Tue, 12 Oct 2010 13:01:08 + (UTC) Aijaz Baig aijazba...@gmail.com wrote: Aijaz Baig aijazbaig1 at gmail.com writes: Hello, I am trying to understand how does the bridging code determine if the packet is to be delivered locally or is it to be forwarded. Before being

Re: [Bridge] Why should static MAC address match one of the port MAC addresses.

2010-10-12 Thread Stephen Hemminger
On Tue, 12 Oct 2010 15:40:25 +0200 Michel Lammertink mlammert...@ti-wmc.nl wrote: Hi all, I've read many messages on this mailing list with the question about setting a static MAC address on the bridge interface, but two questions remain: 1. Why should the MAC address of the bridge

Re: [Bridge] Real time issues when using a bridge

2010-10-12 Thread Stephen Hemminger
On Tue, 12 Oct 2010 16:31:36 +0200 Jean-Michel Hautbois jhautb...@gmail.com wrote: Hi there ! I am facing a jitter issue that I will try to explain : I have the following configuration : (A) eth0 -- br0 -- eth1 (B) I have a small and custom kernel (I removed netfilter, for instance)

Re: [Bridge] Bridge between switch and router + VLAN issue

2010-10-06 Thread Stephen Hemminger
On Tue, 5 Oct 2010 13:46:31 +0530 krunal patel krunal@gmail.com wrote: Hi, There is one setup i am not able to complete. I am putting bridge between a VLAN aware switch and a router with VLAN's. All hosts are behind VLAN switch and their gateway is router. All works well when there

Re: [Bridge] help needed regarding configuration for bridging

2010-09-13 Thread Stephen Hemminger
On Mon, 13 Sep 2010 15:11:21 +0530 debasis das fordeba...@gmail.com wrote: Hi all, I have a Linux box with 3 interfaces eth0,eth1 and eth2. Could anyone please let me know whether the following configuration would be valid : *#brctl addbr br1 #brctl addif br1 eth1

Re: [Bridge] Port Security

2010-09-10 Thread Stephen Hemminger
On Fri, 10 Sep 2010 00:01:57 -0400 Ryan Whelan rcwhe...@gmail.com wrote: I am developing an appliance that will use bridging to create a little integrated switch. We need to ensure that only approved devices are allowed to connect to the switch; are there any mechanisms to enforce security

Re: [Bridge] bridge interface mac address

2010-09-08 Thread Stephen Hemminger
On Wed, 08 Sep 2010 12:28:00 +0200 x...@muc.ccc.de wrote: hi! i'm using dynamips (router/switch emulator) and would like to have an interface on the host as a link to the 'emulated lab'. with dynamips, one of the host's interfaces can be used to connect to a port of the 'emulated lab'.

Re: [Bridge] help needed regarding crash while adding interface to a bridge using brctl utility

2010-08-30 Thread Stephen Hemminger
On Mon, 30 Aug 2010 16:29:43 +0530 debasis das fordeba...@gmail.com wrote: Hi, I am getting a crash while adding an interface to a bridge using the brctl utility. The crash dump is as below: #vconfig add eth0 5 #brctl addbr br0 #brctl addif br0 eth0.5 Oops: sig: 11 [#1] a00:

Re: [Bridge] Number of addresses limitation

2010-08-26 Thread Stephen Hemminger
On Thu, 26 Aug 2010 23:00:07 +0200 Nicolas de Pesloüan nicolas.2p.deb...@free.fr wrote: Le 26/08/2010 21:38, Nicolas de Pesloüan a écrit : Le 25/08/2010 23:49, François Schmidts a écrit : On 25/08/2010 22:39, Stephen Hemminger wrote: On Wed, 25 Aug 2010 21:43:11 +0200 Nicolas de

Re: [Bridge] [patch net-next-2.6] bridge: allow hub-like behaviour

2010-08-12 Thread Stephen Hemminger
On Thu, 12 Aug 2010 13:15:24 +0200 Jiri Pirko jpi...@redhat.com wrote: Wed, Aug 11, 2010 at 06:07:41PM CEST, shemmin...@vyatta.com wrote: NO. unnecessary Already possible, without patch. Just set the hold time on the bridge to 0! Sorry, but could you please point me a sysfs node where

Re: [Bridge] [patch net-next-2.6] bridge: allow hub-like behaviour

2010-08-12 Thread Stephen Hemminger
On Thu, 12 Aug 2010 14:48:48 +0200 Jiri Pirko jpi...@redhat.com wrote: Thu, Aug 12, 2010 at 02:35:41PM CEST, shemmin...@vyatta.com wrote: On Thu, 12 Aug 2010 13:15:24 +0200 Jiri Pirko jpi...@redhat.com wrote: Wed, Aug 11, 2010 at 06:07:41PM CEST, shemmin...@vyatta.com wrote: NO.

Re: [Bridge] rstpd 2.4

2010-07-27 Thread Stephen Hemminger
On Tue, 27 Jul 2010 11:26:55 +0200 Rodolfo Giometti giome...@enneenne.com wrote: On Fri, Jul 02, 2010 at 09:21:48AM -0700, Stephen Hemminger wrote: The 2.4 kernel is missing all the hooks to provide user level STP. The startup is not the big issue, the real problem is that the kernel

Re: [Bridge] [PATCH 7/8] net: bridge: fix sign bug

2010-07-15 Thread Stephen Hemminger
+1435,7 @@ static int br_multicast_ipv6_rcv(struct net_bridge *br, struct icmp6hdr *icmp6h; u8 nexthdr; unsigned len; - unsigned offset; + int offset; int err; if (!pskb_may_pull(skb, sizeof(*ip6h))) Acked-by: Stephen Hemminger shemmin...@vyatta.com

Re: [Bridge] rstpd 2.4

2010-07-02 Thread Stephen Hemminger
On Fri, 2 Jul 2010 15:56:41 +0200 Rodolfo Giometti giome...@enneenne.com wrote: Hello, project rstpd at http://git.kernel.org/?p=linux/kernel/git/shemminger/rstp.git can work if default kernel stp is disabled by calling userspace program /sbin/bridge-stp and checking the return code. On

Re: [Bridge] Bridge responds on its IP address even when br0 is down.

2010-06-09 Thread Stephen Hemminger
On Wed, 9 Jun 2010 16:46:01 +0200 Joakim Tjernlund joakim.tjernl...@transmode.se wrote: System A: eth0 has ip 192.168.1.16 Then do in system A brctl addbr br0 ifconfig br0 192.168.1.18 down From system B I ping 192.168.1.18 and system A responds! Even though interface br0 is

Re: [Bridge] Bridge responds on its IP address even when br0 is down.

2010-06-09 Thread Stephen Hemminger
On Wed, 9 Jun 2010 18:30:17 +0200 Joakim Tjernlund joakim.tjernl...@transmode.se wrote: Stephen Hemminger shemmin...@linux-foundation.org wrote on 2010/06/09 17:23:19: On Wed, 9 Jun 2010 16:46:01 +0200 Joakim Tjernlund joakim.tjernl...@transmode.se wrote: System A: eth0 has ip

Re: [Bridge] [PATCH] netconsole: queue console messages to send later

2010-06-07 Thread Stephen Hemminger
On Mon, 07 Jun 2010 14:50:48 -0500 Matt Mackall m...@selenic.com wrote: On Mon, 2010-06-07 at 16:24 -0300, Flavio Leitner wrote: There are some networking drivers that hold a lock in the transmit path. Therefore, if a console message is printed after that, netconsole will push it through

<    1   2   3   4   5   >