bug#11100: Racy code in copy.c

2021-11-18 Thread Jim Meyering
On Thu, Nov 18, 2021 at 8:38 AM Paul Eggert wrote: > I spotted a SELinux security-context race introduced by the circa-2012 > fix for Bug#11100, and installed the attached patch into coreutils > master. This also gets rid of a label and goto (which is what led me to > find the issue). Nice! Thank

bug#50714: OS X, one failure: tests/tail-2/pipe-f.sh

2021-09-20 Thread Jim Meyering
Uname -v reports this: Darwin Kernel Version 20.6.0: Mon Aug 30 06:12:21 PDT 2021; root:xnu-7195.141.6~3/RELEASE_X86_64 Sorry, I don't have time to delve into this, but here's the log from the sole test failure: pipe-f.log Description: Binary data

bug#50611: one-byte (write) heap-buffer-underrun

2021-09-15 Thread Jim Meyering
Thanks for all your recent changes! I built+tested with ASAN on Fedora 34: Configure and build as usual, then "make clean" and do this: > san='-fsanitize-address-use-after-scope -fsanitize=address -static-libasan'; > ASAN_OPTIONS=detect_leaks=0 , CFLAGS='-O -ggdb3' AM_CFLAGS="$san" > AM_LDFLAGS=

bug#50167: fixes for "fmt - -" etc.

2021-08-25 Thread Jim Meyering
On Wed, Aug 25, 2021, 4:37 PM Bernhard Voelker wrote: > On 8/25/21 10:38 AM, Jim Meyering wrote: > > * cfg.mk (exclude_file_name_regexp--sc_system_h_headers): > > Add find-mount-point.h to the regexp. > > +1 > even better, thanks. > Thanks. Pushed. >

bug#50167: fixes for "fmt - -" etc.

2021-08-25 Thread Jim Meyering
On Tue, Aug 24, 2021 at 11:10 PM Paul Eggert wrote: > On 8/24/21 12:42 PM, Bernhard Voelker wrote: > > Was there a particular reason to include stdlib.h? > > It's needed to declare 'free', which is used by _GL_ATTRIBUTE_DEALLOC_FREE. > > I added "#include " so that find-mount-point.h would be an

bug#49741: basenc --base64url decoding bug

2021-08-17 Thread Jim Meyering
On Tue, Aug 17, 2021 at 2:02 AM Pádraig Brady wrote: > On 16/08/2021 22:17, Assaf Gordon wrote: > > Hello Emil and all, > > > > Thanks for the clear and easily reproducible bug report. > > > > Attached a suggested fix. > > Comments very welcomed, > > minor nit in NEWS: > s/silently discard/silentl

bug#45093: Character 149 causing ASCII BEL output to console in Windoze port of Gnu CoreUtils

2020-12-07 Thread Jim Meyering
tags 45093 notabug close 45093 stop On Mon, Dec 7, 2020 at 9:11 AM Paul Eggert wrote: > On 12/6/20 8:23 PM, Robert S. Kissel wrote: > > I'm pretty sure this is a bug in the Windoze port of head and tail, > > You should have better luck writing directly to the people who prepared that > port, as t

bug#44235: [PATCH] dd: drop old workaround for lseek() bug in Linux kernel

2020-10-26 Thread Jim Meyering
On Mon, Oct 26, 2020 at 6:13 AM Pádraig Brady wrote: > On 26/10/2020 10:44, Kamil Dudka wrote: > > The workaround triggers warnings with new kernel versions in case > > a user does not have sufficient privileges for the MTIOCGET ioctl. > > > > * src/dd.c (skip_via_lseek): Drop wrapper function no

bug#39364: [PATCH] rmdir: fix clobbered errno

2020-02-03 Thread Jim Meyering
On Mon, Feb 3, 2020 at 5:28 AM Pádraig Brady wrote: ... > Actually I think the key issue is not errno handling, > but a logic error fixed with: > > @@ -102,7 +102,7 @@ ignorable_failure (int error_number, char const *dir) > return (ignore_fail_on_non_empty > && (errno_rmdir_non_emp

bug#39364: [PATCH] rmdir: fix clobbered errno

2020-02-02 Thread Jim Meyering
On Sun, Feb 2, 2020 at 5:11 AM Bernhard Voelker wrote: > On 2020-02-02 07:32, Jim Meyering wrote: > > FTR, here's a minimal test addition that exercises the bug. Succeeds > > on 6.10, fails on 6.11: > > Minor tweak for the test ... > > -rmdir --ignore-fail-on-non-e

bug#39364: [PATCH] rmdir: fix clobbered errno

2020-02-01 Thread Jim Meyering
On Fri, Jan 31, 2020 at 9:55 AM Pádraig Brady wrote: > ... > This looks like a regression introduced in v6.10-21-ged5c4e7 > I.E. is_empty_dir() is globbering errno, and thus > a non specific and non terminating warning is output, > rather than a specific error, and exit. FTR, here's a minimal tes

bug#39364: [PATCH] rmdir: fix clobbered errno

2020-02-01 Thread Jim Meyering
Nice find and thank you for the patch. That's a 12-year-old bug I introduced. I confirm: with 6.10, running this: mkdir -p a/b && chmod a-w a && rmdir --ignore a/b prints this and exits nonzero: rmdir: failed to remove `a/b': Permission denied With 6.11 and newer, it silently succeeds. On Fri

bug#38627: uniq -c gets wrong count with non-ascii strings

2019-12-17 Thread Jim Meyering
27;uniq' uses the equivalent of strcmp (byte comparison). Since the two > lines compare equal in your locale, GNU 'uniq' says there's just one line. > > The GNU 'uniq' behavior appears to be a consequence of this commit: > > commit 545c2323d493c7ed9c

bug#36831: enhance 'directory not empty' message

2019-07-29 Thread Jim Meyering
On Sun, Jul 28, 2019 at 11:29 PM Assaf Gordon wrote: ... > What do others think? If this is a desired improvement, I'll finish the > patch with news/tests/etc. ... > [PATCH] mv: improve ENOTEMPTY/EEXIST error message > > Suggested by Alex Mantel in > https://bugs.gnu.org/36831 . > > $ mkdir A

bug#34239: build failure on Android, due to S_MAGIC_* symbols

2019-02-16 Thread Jim Meyering
On Tue, Jan 29, 2019 at 9:01 PM Pádraig Brady wrote: > On 28/01/19 19:19, Bruno Haible wrote: > > Hi, > > > > Compiling coreutils on Android produces this error: > > > > CC src/tail.o > > In file included from ../src/tail.c:63: > > ../src/fs-is-local.h: In function 'is_local_fs_type': > >

bug#30963: ls -fA -> still . and ..

2018-03-27 Thread Jim Meyering
On Tue, Mar 27, 2018 at 3:06 PM, Paul Eggert wrote: > On 03/27/2018 10:27 AM, Karl Berry wrote: >> >> ls -aA also shows . and ..; maybe it shouldn't? > > You're right, it shouldn't. This was a bug I introduced in 2004 and I think > you're the first to report it (!). In my defense, it wasn't offici

bug#29961: [PATCH] mv: document the missing atomicity of 'mv -n'

2018-01-03 Thread Jim Meyering
On Wed, Jan 3, 2018 at 8:27 AM, Kamil Dudka wrote: > On Wednesday, January 3, 2018 4:08:51 PM CET Pádraig Brady wrote: >> Eep, Seems like we should use RENAME_NOREPLACE in this case, >> rather than document the caveat? Good catch/fix. Thanks to both of you.

bug#21760: timeout: Feature Request: --verbose ==> output if timeout

2017-11-23 Thread Jim Meyering
On Thu, Nov 23, 2017 at 2:35 PM, Pádraig Brady wrote: ... >> So I'm leaning towards supporting --verbose which would output something >> like: >> >> timeout: aborting command 'blah' with signal SIGTERM >> timeout: aborting command 'blah' with signal SIGKILL + error (0, 0, _("abortin

bug#29259: tail does not seek to the end of block device

2017-11-13 Thread Jim Meyering
On Mon, Nov 13, 2017 at 12:03 AM, Pádraig Brady wrote: > On 12/11/17 22:21, Pádraig Brady wrote: >> On 12/11/17 21:52, Paul Eggert wrote: >>> Why doesn't lseek work for this? >> >> Good call, it probably would. >> Something like the following is more acceptable >> since it adds very little complex

bug#29164: Scratch this bug report

2017-11-06 Thread Jim Meyering
tags 29164 notabug thanks On Mon, Nov 6, 2017 at 12:21 AM, Thomas Deutschmann wrote: > please ignore this bug report. This is caused by Gentoo's sandbox in > portage and no problem in coreutils. Sorry for wasting your time :/ Closing and marking as notabug

bug#29038: df hangs on fifos/named pipes

2017-10-29 Thread Jim Meyering
On Sun, Oct 29, 2017 at 3:34 PM, Pádraig Brady wrote: ... >> That was discovered by Martijn Dekker, CCed, when looking for a >> portable way to identify the file system of an arbitrary file. > > Yes we shouldn't hang. > > RE side effects, open() is a fairly innocuous operation, > and we expect sta

bug#28859: Segmentation fault with NULL pointer dereference in 'stty'

2017-10-17 Thread Jim Meyering
On Tue, Oct 17, 2017 at 12:37 AM, Pádraig Brady wrote: > On 16/10/17 10:49, Jim Meyering wrote: >> On Mon, Oct 16, 2017 at 2:30 AM, Pádraig Brady wrote: >>> On 15/10/17 18:07, Jaeseung Choi wrote: >>>> Dear GNU team, >>>> >>>> While

bug#28859: Segmentation fault with NULL pointer dereference in 'stty'

2017-10-16 Thread Jim Meyering
On Mon, Oct 16, 2017 at 2:30 AM, Pádraig Brady wrote: > On 15/10/17 18:07, Jaeseung Choi wrote: >> Dear GNU team, >> >> While testing coreutils for a research purpose, we found the following >> crash in 'stty'. Running stty with the command-line "stty eol -F AA" >> raises a crash as below. We did

bug#28506: coreutils 8.28 test suite hangs on APFS filesystem

2017-09-25 Thread Jim Meyering
On Sun, Sep 24, 2017 at 10:34 AM, Jack Howarth wrote: > On Sun, Sep 24, 2017 at 1:16 PM, Jack Howarth < ... > Attached are the tests/touch/trailing-slash.log and > tests/touch/trailing-slash.trs files generated from a build on an APFS > volume running 10.13 in case you can identify why that t

bug#28506: coreutils 8.28 test suite hangs on APFS filesystem

2017-09-20 Thread Jim Meyering
On Wed, Sep 20, 2017 at 10:20 PM, Pádraig Brady wrote: > On 18/09/17 18:07, Jack Howarth wrote: >> On Mon, Sep 18, 2017 at 7:40 PM, Jim Meyering wrote: >> >>> On Mon, Sep 18, 2017 at 4:26 PM, Jack Howarth >>> wrote: >>>> On Mon, Sep 18, 2017 at 5

bug#28506: coreutils 8.28 test suite hangs on APFS filesystem

2017-09-18 Thread Jim Meyering
On Mon, Sep 18, 2017 at 4:26 PM, Jack Howarth wrote: > On Mon, Sep 18, 2017 at 5:08 PM, Jim Meyering wrote: ... >> Is there any chance your failing test was via a python2 framework? I'm >> asking (on Pádraig's behalf) because there is a known problem whereby >> SIG

bug#28506: coreutils 8.28 test suite hangs on APFS filesystem

2017-09-18 Thread Jim Meyering
On Mon, Sep 18, 2017 at 1:18 PM, Jack Howarth wrote: > The coreutils 8.28 release, when built on macOS 10.13 under the new APFS > filesystem, produces a hang during the test suite run. The hang appears to > occur in the execution of coreutils-8.28/tests/split/filter.sh at.. > > + yes > + head -n20

bug#28461: erreurs

2017-09-17 Thread Jim Meyering
On Sat, Sep 16, 2017 at 11:27 PM, Assaf Gordon wrote: ... > Attached an updated patch with all instances of 'parameter' > changed to 'argument'. Looks fine. Thank you! I marked the issue as "done".

bug#28461: erreurs

2017-09-15 Thread Jim Meyering
On Fri, Sep 15, 2017 at 8:37 PM, Pádraig Brady wrote: ... > That's a good improvement! Indeed! > > I'd change: > > s/missing more parameters after/missing parameter after/ Or, perhaps use wording similar to what test does: ..._("missing argument after %s")

bug#28054: coreutils 8.27 test failure on x86_64-foxkit-linux-musl

2017-08-13 Thread Jim Meyering
On Sun, Aug 13, 2017 at 1:07 AM, Pádraig Brady wrote: > On 11/08/17 11:49, A. Wilcox wrote: > >> FAIL: tests/misc/csplit-io-err >> == > This was due to an inconsistency in the errors output by seq. > A fix for that buglet is attached. > >> FAIL: tests/misc/printf-surpri

bug#27368: Minor concern: Confusing tail warning

2017-06-17 Thread Jim Meyering
On Sat, Jun 17, 2017 at 3:57 PM, Pádraig Brady wrote: > On 17/06/17 14:30, Pádraig Brady wrote: >> On 17/06/17 07:35, Jim Meyering wrote: >>> In this new function, please move the declaration of "i" into the for-loop: >>> >>> +static bool >>&

bug#27368: Minor concern: Confusing tail warning

2017-06-17 Thread Jim Meyering
On Sat, Jun 17, 2017 at 1:32 AM, Pádraig Brady wrote: ... > Two proposed patches for this are attached. Nice fixes. Thank you! In the NEWS addition: tail -f will now exit immediately if the output is piped and the reader of the pipe terminates. + tail -f will no longer erroneously warn

bug#25680: maint: tweaks so syntax tests pass for previous commit

2017-02-15 Thread Jim Meyering
On Wed, Feb 15, 2017 at 11:46 AM, Paul Eggert wrote: > I see some problems with this followup patch: > > http://git.savannah.gnu.org/cgit/coreutils.git/commit/?id=bd4bb42d65aac6591277066739ca42d1ddcc2d0e > > in that it will make force-link.c and force-link.h harder to move to gnulib. > Is there so

bug#25398: stty: bug or feature?

2017-01-08 Thread Jim Meyering
On Mon, Jan 9, 2017 at 1:31 AM, Pádraig Brady wrote: > On 08/01/17 20:08, Pádraig Brady wrote: >> On 08/01/17 18:14, Dave B wrote: >>> Would it be possible "one day" for stty to parse the command line args, >>> and only open the port when all the specified parameters are actually in >>> force? >>

bug#25185: translation bug in id

2016-12-12 Thread Jim Meyering
On Mon, Dec 12, 2016 at 11:04 AM, Christian González wrote: > I recently started id on my server > > id -z root > > And it told me in German > > "id: die Option --zero ist im Sandardformat nicht zulässig" > > But "Sandardformat" is no word. It should mean "Standardformat". > > If you had a bug tra

bug#25041: Bugs in TAC and TAIL for closed stdin

2016-11-27 Thread Jim Meyering
On Sun, Nov 27, 2016 at 7:40 AM, Pádraig Brady wrote: > I'll push the attached later Thanks to both of you. That patch looks fine, modulo a formatting nit: the second line is indented one space too far: + f->ignore = ! (reopen_inaccessible_files + && fo

bug#25004: Bug in OD utility

2016-11-23 Thread Jim Meyering
On Wed, Nov 23, 2016 at 5:16 PM, Marcel Böhme wrote: > Hi Pádraig, > >> On 24 Nov 2016, at 8:45 AM, Pádraig Brady wrote: >> >> I can't reproduce the issue here BTW with ASAN and running in a tight >> loop for a few minutes. So perhaps it has been fixed in glibc already? >> I have glibc-2.22-10.f

bug#25003: Bug in SPLIT utility

2016-11-23 Thread Jim Meyering
On Wed, Nov 23, 2016 at 4:21 PM, Pádraig Brady wrote: > On 23/11/16 22:16, Pádraig Brady wrote: >> On 23/11/16 17:30, Jim Meyering wrote: >>> On Wed, Nov 23, 2016 at 5:22 AM, Marcel Böhme >>> wrote: >>>> Dear all, >>>> >>>> We ar

bug#25003: Bug in SPLIT utility

2016-11-23 Thread Jim Meyering
On Wed, Nov 23, 2016 at 5:22 AM, Marcel Böhme wrote: > Dear all, > > We are running small 1h fuzzing sessions with AFLFast, a fork of AFL. > We’ll be reporting each found bug separately. > > On Coreutils v8.25 and trunk, the following input crashes. > Option -n was introduced with v8.8. > > $ ./sp

bug#24436: [PATCH] dircolors: highlight Motion JPEG multimedia files

2016-11-15 Thread Jim Meyering
On Wed, Sep 14, 2016 at 7:13 AM, Antonio Ospite wrote: > * src/dircolors.hin: Add .mjpg and .mjpeg multimedia files. > --- > > Please CC me on reply, I am not subscribed. > > Thanks, >Antonio > > src/dircolors.hin | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/dircolors.hin b/

bug#24874: dd: misleading parsing of hex numbers

2016-11-04 Thread Jim Meyering
On Fri, Nov 4, 2016 at 12:03 PM, Pádraig Brady wrote: > On 04/11/16 16:20, Pádraig Brady wrote: >> On 04/11/16 11:19, Stephan Bauroth wrote: >>> Dear coreutils team :) >>> >>> I encountered a buglike behaviour of dd when handling skip and count >>> parameters that are encoded in hex and thus prefi

bug#24604: Add '--no-preserve-roots' flag to 'rm' for better safety

2016-10-04 Thread Jim Meyering
On Tue, Oct 4, 2016 at 5:54 AM, Pádraig Brady wrote: > On 04/10/16 12:38, Pádraig Brady wrote: >> On 04/10/16 03:21, Mohammed Sadiq wrote: >>> '--no-preserve-root' that can be used to ignore if the path is root when >>> using >>> the 'rm' command. >>> >>> But as the most of the GNU commands accep

bug#24232: [PATCH] ls: postpone installation of signal handlers

2016-09-06 Thread Jim Meyering
On Tue, Sep 6, 2016 at 10:05 AM, Paul Eggert wrote: > On 09/06/2016 08:59 AM, Pádraig Brady wrote: >> >> Will push later. > > > Before pushing, can you please change the name of "sigs" back to "sig"? I > prefer the old name, as "sig[i]" clearly means "signal i", whereas "sigs[i]" > is more confusi

bug#24251: Potential cp bug: directories created with --parents and --no-preserve=mode retain original mode bits don't match ~umask

2016-08-18 Thread Jim Meyering
On Thu, Aug 18, 2016 at 5:57 AM, Pádraig Brady wrote: > On 17/08/16 12:42, Mark Mitchell wrote: >> Hi, >> >> I'm writing to report a potential bug with cp. I don't think the mode bits >> always get properly set on directories created when using the --parents >> option combined with --no-preserve=

bug#23825: maint: avoid md5sum.c warning from bleeding-edge gcc's -Wstrict-overflow

2016-06-23 Thread Jim Meyering
On Thu, Jun 23, 2016 at 7:26 AM, Pádraig Brady wrote: > On 23/06/16 08:13, Paul Eggert wrote: >> Incidentally, 'yes' has a different bug: it mishandles the case where >> 'write' succeeds but returns a value less than the buffer size. I'll try >> to look into that too. Simplest would be to use stdi

bug#23825: maint: avoid md5sum.c warning from bleeding-edge gcc's -Wstrict-overflow

2016-06-22 Thread Jim Meyering
src/md5sum.c:870:3: error: assuming signed overflow does not occur \ when simplifying conditional to constant [-Werror=strict-overflow] * src/md5sum.c (main): Use an unsigned variable as the loop index, rather than optind. From 8912aa7c6dc7acb76d2de648e89098943bfe149a Mon Sep 17 00:

bug#23537: timeout test gets false-positive for duration of -1.189731495357231765e+4932

2016-05-15 Thread Jim Meyering
tags 23537 notabug stop On Sun, May 15, 2016 at 8:06 AM, Jim Meyering wrote: > On Sun, May 15, 2016 at 4:21 AM, Pádraig Brady wrote: >> Has up to date centos6 the bug? >> I didn't see it with glibc-2.12-1.166.el6_7.7.x86_64 > > Yes. I am surprised that you don't

bug#23537: timeout test gets false-positive for duration of -1.189731495357231765e+4932

2016-05-15 Thread Jim Meyering
On Sun, May 15, 2016 at 4:21 AM, Pádraig Brady wrote: > Has up to date centos6 the bug? > I didn't see it with glibc-2.12-1.166.el6_7.7.x86_64 Yes. I am surprised that you don't see it and I do: $ rpm -q glibc glibc-2.12-1.166.el6_7.7.x86_64 $ src/timeout 0.1 sleep 1.189731495357231765e+49

bug#23537: timeout test gets false-positive for duration of -1.189731495357231765e+4932

2016-05-14 Thread Jim Meyering
On systems with recent glibc, this abuse of timeout elicits the expected error: $ src/timeout -- -1.189731495357231765e+4932 sleep 0 src/timeout: invalid time interval ‘-1.189731495357231765e+4932’ Try 'src/timeout --help' for more information. But with glibc-2.12's strtod, that input maps

bug#23442: [PATCH] maint: avoid new warning from gcc (GCC) 7.0.0 20160503 (experimental)

2016-05-05 Thread Jim Meyering
On Thu, May 5, 2016 at 1:54 AM, Bernhard Voelker wrote: > On 05/04/2016 05:08 PM, Jim Meyering wrote: >> Subject: [PATCH] maint: avoid new warning from gcc (GCC) 7.0.0 20160503 >> (experimental) >> >> * src/id.c (main): When configured with --enable-gcc-warnings and u

bug#23442: [PATCH] maint: avoid new warning from gcc (GCC) 7.0.0 20160503 (experimental)

2016-05-04 Thread Jim Meyering
On Wed, May 4, 2016 at 12:40 AM, Bernhard Voelker wrote: > On 05/04/2016 05:59 AM, Jim Meyering wrote: >> - bool default_format = (just_user + just_group + just_group_list >> + bool default_format = (0U + just_user + just_group + just_group_list >>

bug#23442: [PATCH] maint: avoid new warning from gcc (GCC) 7.0.0 20160503 (experimental)

2016-05-03 Thread Jim Meyering
On Tue, May 3, 2016 at 8:59 PM, Jim Meyering wrote: > coreutils failed to build when configured with --enable-gcc-warnings > and the latest gcc built from git. > > Here's a patch to fix that: One nit in the commit log, fixed locally: s/U0/0U/

bug#23442: [PATCH] maint: avoid new warning from gcc (GCC) 7.0.0 20160503 (experimental)

2016-05-03 Thread Jim Meyering
coreutils failed to build when configured with --enable-gcc-warnings and the latest gcc built from git. Here's a patch to fix that: From e22ff987e4d3c29b445b3e94de65c633f8a05870 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Tue, 3 May 2016 20:56:20 -0700 Subject: [PATCH] maint: avoi

bug#23073: wc reports wrong byte counts when using '--from-files0=-'

2016-03-21 Thread Jim Meyering
On Sun, Mar 20, 2016 at 5:59 PM, William R. Fraser wrote: > When wc gets its list of files by reading from stdin, using the argument > '--from-files0=-', it reuses the same fstatus struct for each file. > > The problem is that the 'wc' function checks the 'failed' member of this > struct and if it

bug#22931: tests/split/filter.sh fails on an XFS file system

2016-03-08 Thread Jim Meyering
On Sun, Mar 6, 2016 at 7:36 PM, Jim Meyering wrote: > The split/filter.sh test would fail like this: > > $ make check TESTS=tests/split/filter.sh VERBOSE=yes SUBDIRS=. > + truncate -s9223372036854775807 zero.in > + timeout 10 sh -c 'split --filter="head -c1

bug#22931: tests/split/filter.sh fails on an XFS file system

2016-03-06 Thread Jim Meyering
On Sun, Mar 6, 2016 at 7:36 PM, Jim Meyering wrote: > The split/filter.sh test would fail like this: > > $ make check TESTS=tests/split/filter.sh VERBOSE=yes SUBDIRS=. > + truncate -s9223372036854775807 zero.in > + timeout 10 sh -c 'split --filter="head -c1

bug#22931: tests/split/filter.sh fails on an XFS file system

2016-03-06 Thread Jim Meyering
date the commit log with the issue URL as soon as it's assigned] From 889415ab359c943ee4c358f8c5fb07bca95a4ead Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sun, 6 Mar 2016 16:38:01 -0800 Subject: [PATCH] tests: avoid false-failure of split/filter.sh on XFS * tests/split/filter.sh: Use OFF_T_M

bug#22909: [PATCH] test: Document that -a and -o are undesirable

2016-03-04 Thread Jim Meyering
On Fri, Mar 4, 2016 at 9:50 AM, Jim Meyering wrote: > On Fri, Mar 4, 2016 at 9:12 AM, Pádraig Brady wrote: >> On 04/03/16 08:55, Eric Blake wrote: > ... >>> +NOTE: Use of binary -a and -o create inherently ambiguous situations. > > I like that, too. Thanks. One nit: s/

bug#22909: [PATCH] test: Document that -a and -o are undesirable

2016-03-04 Thread Jim Meyering
On Fri, Mar 4, 2016 at 9:12 AM, Pádraig Brady wrote: > On 04/03/16 08:55, Eric Blake wrote: ... >> +NOTE: Use of binary -a and -o create inherently ambiguous situations. I like that, too. Thanks. One nit: s/create/creates/

bug#22698: ls output changes considered unacceptable

2016-02-17 Thread Jim Meyering
On Wed, Feb 17, 2016 at 8:46 AM, Mike Hodson wrote: >>On Tue, Feb 16, 2016 at 6:45 AM, Bernhard Voelker >>wrote: >>> On 02/16/2016 11:50 AM, Jason A. Donenfeld wrote: >>> [...] We don't want those single quotes. >> >> >> Who exactly is "we"? >> >> I can only speak for myself: I'm don't really ca

bug#22567: Factoring 38 nines

2016-02-05 Thread Jim Meyering
On Fri, Feb 5, 2016 at 11:29 AM, Eric Blake wrote: > On 02/05/2016 11:30 AM, SasQ wrote: > >> >> OK, this convinces me this is not a bug. 4m30 on my machine. >> But it's definitely a user-interface fail ;) >> It should at least output some warning that the computations might >> take longer, or dis

bug#22042: don't say K bytes on both head and tail's man pages

2015-11-30 Thread Jim Meyering
On Mon, Nov 30, 2015 at 6:52 AM, Pádraig Brady wrote: > On 29/11/15 23:35, Bernhard Voelker wrote: >> On 11/29/2015 12:16 AM, Pádraig Brady wrote: >>> I remember having slight reservations about K too. >>> http://lists.gnu.org/archive/html/bug-coreutils/2009-05/msg00279.html >>> Nothing much bette

bug#15604: [coreutils] [PATCH] md5sum: Add option to ignore non-existant files

2015-11-23 Thread Jim Meyering
On Mon, Nov 23, 2015 at 6:24 PM, Pádraig Brady wrote: > On 23/11/15 16:41, Jim Meyering wrote: >> I think a common expected usage of --ignore-missing would be >> the case of an SHA1SUM file listing all possibly-verified files for >> which it is common to verify only the

bug#15604: [coreutils] [PATCH] md5sum: Add option to ignore non-existant files

2015-11-23 Thread Jim Meyering
On Mon, Nov 23, 2015 at 5:24 PM, Pádraig Brady wrote: > On 23/11/15 16:05, Jim Meyering wrote: >> On Mon, Nov 23, 2015 at 2:20 PM, Pádraig Brady wrote: >>>> I'll push a bit later today. >>> >>> Pushed at >>> http://git.sv.gnu.org/git

bug#15604: [coreutils] [PATCH] md5sum: Add option to ignore non-existant files

2015-11-23 Thread Jim Meyering
On Mon, Nov 23, 2015 at 2:20 PM, Pádraig Brady wrote: >> I'll push a bit later today. > > Pushed at > http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=v8.24-91-g9fd0662 > Marking http://bugs.gnu.org/15604 done Given how this warns/fails when using --check does nothing, $ :|sha1sum

bug#21760: timeout: Feature Request: --verbose ==> output if timeout was reached

2015-10-28 Thread Jim Meyering
On Wed, Oct 28, 2015 at 7:10 AM, Bernhard Voelker wrote: > On 10/28/2015 11:00 AM, Pádraig Brady wrote: >> >> Reopened until someone else votes. > > I'm 50:50 regarding the usefulness of --verbose. > Writing "killed PRG after N seconds elapsed" sounds like a useful > message, yet I'm afraid that t

bug#21356: BUG: split shorter version of '--numeric-suffixes' give error

2015-08-31 Thread Jim Meyering
On Mon, Aug 31, 2015 at 10:13 AM, Pádraig Brady wrote: > I'll apply the attached later. Nice. Thanks to both of you.

bug#20998: Out of bounds global read in shred / genpattern()

2015-07-06 Thread Jim Meyering
On Mon, Jul 6, 2015 at 5:45 PM, Pádraig Brady wrote: > On 07/07/15 00:29, Hanno Böck wrote: >> Hi, >> >> There is an out of bounds read error in the function genpattern() in >> shred (coreutils 8.23). This issue only appears randomly. >> >> To test: >> a) recompile coreutils 8.23 with address sani

bug#20923: mgetgroups.c vs getgrouplist warning on OS X

2015-06-30 Thread Jim Meyering
On Tue, Jun 30, 2015 at 9:36 AM, Paul Eggert wrote: > Jim Meyering wrote: > >> same result as before: > > OK, let's give up on this approach and try something more direct. I > installed the attached patch; does it work on OS X? Perfect. I made latest coreutils use late

bug#20923: mgetgroups.c vs getgrouplist warning on OS X

2015-06-29 Thread Jim Meyering
On Mon, Jun 29, 2015 at 7:19 PM, Paul Eggert wrote: > Jim Meyering wrote: >> >> Darn it. I see that I mistakenly pushed one of your patches >> when I pushed the linkat.m4 fix, Paul. Sorry about that. >> Happy to revert, if you'd like that. Let me know. > >

bug#20923: mgetgroups.c vs getgrouplist warning on OS X

2015-06-29 Thread Jim Meyering
On Mon, Jun 29, 2015 at 2:01 PM, Jim Meyering wrote: > On Mon, Jun 29, 2015 at 11:39 AM, Paul Eggert wrote: >> Jim Meyering wrote: >>> >>> the first variant compiled >>> just fine here (and probably everywhere), >>> so HAVE_GETGROUPLIST_WITH_INT was

bug#20923: mgetgroups.c vs getgrouplist warning on OS X

2015-06-29 Thread Jim Meyering
On Mon, Jun 29, 2015 at 11:39 AM, Paul Eggert wrote: > Jim Meyering wrote: >> >> the first variant compiled >> just fine here (and probably everywhere), >> so HAVE_GETGROUPLIST_WITH_INT was not defined. > > > Yes, well, it did work on GNU/Linux, which is what

bug#20923: mgetgroups.c vs getgrouplist warning on OS X

2015-06-29 Thread Jim Meyering
On Sun, Jun 28, 2015 at 11:48 PM, Paul Eggert wrote: > Jim Meyering wrote: >> >> I compiled the just-published snapshot on OS X configured with >> --enable-gcc-warnings, and saw this: >> >> lib/mgetgroups.c: In function 'mgetgroups': >> lib/mget

bug#20923: mgetgroups.c vs getgrouplist warning on OS X

2015-06-28 Thread Jim Meyering
I compiled the just-published snapshot on OS X configured with --enable-gcc-warnings, and saw this: lib/mgetgroups.c: In function 'mgetgroups': lib/mgetgroups.c:90:45: error: pointer targets in passing argument 3 of 'getgrouplist' differ in signedness [-Werror=pointer-sign] ng = getgrou

bug#20536: avoid new gcc warning: ENOTSUP vs EOPNOTSUPP

2015-05-10 Thread Jim Meyering
On Sun, May 10, 2015 at 7:17 AM, Paul Eggert wrote: > Jim Meyering wrote: >> >> + return err == EOPNOTSUPP >> +#if ENOTSUP != EOPNOTSUPP >> +|| err == ENOTSUP >> +#endif >> +; > > Would the following work instead? It's a bit cl

bug#20536: avoid new gcc warning: ENOTSUP vs EOPNOTSUPP

2015-05-09 Thread Jim Meyering
Building with very new gcc-from-git, I encountered 3 new warnings. Here's a patch to address them: Without this change, very recent gcc (e.g., version 6.0.0 20150509) would print the following when configured with --enable-gcc-warnings: src/copy.c:165:30: error: logical 'or' of equal expression

bug#20354: [feature request] ln with command line arguments in reverse order

2015-04-19 Thread Jim Meyering
On Sun, Apr 19, 2015 at 8:27 AM, Ma Jiehong wrote: > The translation in the help message is not wrong, and "TARGET" and > "LINK_NAME" are used. > > The issue simply is with the mental model made when approaching the "ln" > command. In French, the usual way to say when creating a link is: "Je vais

bug#20214: Nohup input redirection inconsistent with documentation

2015-03-29 Thread Jim Meyering
On Fri, Mar 27, 2015 at 7:14 PM, Jim Meyering wrote: > On Fri, Mar 27, 2015 at 3:11 PM, Paul Eggert wrote: >> Isaac Schwabacher wrote: >> >>> This is confusing at best >> >> Yes, at the very least the documentation should be improved. I installed >

bug#20214: Nohup input redirection inconsistent with documentation

2015-03-27 Thread Jim Meyering
On Fri, Mar 27, 2015 at 3:11 PM, Paul Eggert wrote: > Isaac Schwabacher wrote: > >> This is confusing at best > > Yes, at the very least the documentation should be improved. I installed > the attached patch to try to do that. > >> Is it really better for a read on stdin to fail with EBADF rather

bug#20114: tr does not support multibyte characters in the first argument

2015-03-17 Thread Jim Meyering
On Mon, Mar 16, 2015 at 5:15 AM, Pádraig Brady wrote: ... > Yes you're right Bruno. > Multi-byte support in coreutils in general has languished, > but we hope to start improving support in the next major release (9?) > after the current imminent 8.24 stable release. > > To that end I've put togeth

bug#19969: problem: wc -c doesn't read actual # of bytes in file

2015-03-02 Thread Jim Meyering
On Mon, Mar 2, 2015 at 1:29 PM, Linda Walsh wrote: > > > Jim Meyering wrote: >>> >>> As root: >>> # cd /proc >>> # find -H [^0-9]* -name self -prune -o -name thread-self -prune -o -type >>> f ! >>> -name kmsg ! -name kcore ! -name kp

bug#19969: problem: wc -c doesn't read actual # of bytes in file

2015-03-02 Thread Jim Meyering
On Sat, Feb 28, 2015 at 12:59 AM, Linda Walsh wrote: > (coreutils-8.21-7.7.7) > > wc -c(bytes) doesn't seem to reliably read the number > of bytes in a file. > > I was wanting to find out what the largest data-source > files in '/proc' and '/sys' (didn't get around to trying > /sys, since all the

bug#19503: most translations of proper names aren't being used

2015-01-04 Thread Jim Meyering
On Sun, Jan 4, 2015 at 9:43 AM, Pádraig Brady wrote: ... > BTW, it might have been nice to have the initial git commits > for these tools attributed to the original author. Hindsight and all that :) It would have been nice, indeed. When I agreed to do the job of maintaining the fileutils, textut

bug#19503: most translations of proper names aren't being used

2015-01-04 Thread Jim Meyering
On Sun, Jan 4, 2015 at 7:53 AM, Pádraig Brady wrote: ... > Also there is the more general point about how correct > it is to attribute a program to author(s) in any case, > as that tracked to a much more accurate level of detail > by git blame etc. Should we be removing output of > author names a

bug#19456: GNU coreutils - touch / add -v, --verbose option

2014-12-28 Thread Jim Meyering
On Sun, Dec 28, 2014 at 12:33 AM, Jari Aalto wrote: > It would be nice to see progress of touched files. Please > add option[1]: Hi Jari, My preference is to avoid adding the --verbose option to programs like touch. Here is some explanation for why I have seriously considered taking the relative

bug#19377: bug#19378: [PATCH 3/4] cat, chcon, chgrp, chmod, chown, cp, du, head: support wildcards on OS/2

2014-12-18 Thread Jim Meyering
On Mon, Dec 15, 2014 at 9:11 PM, KO Myung-Hun wrote: > Jim Meyering wrote: >> On Mon, Dec 15, 2014 at 8:35 PM, KO Myung-Hun wrote: >>> Paul Eggert wrote: >>>> KO Myung-Hun wrote: >>>>> /* Redirection and wildcarding when done by the utility its

bug#19377: bug#19378: [PATCH 3/4] cat, chcon, chgrp, chmod, chown, cp, du, head: support wildcards on OS/2

2014-12-15 Thread Jim Meyering
On Mon, Dec 15, 2014 at 8:35 PM, KO Myung-Hun wrote: > Paul Eggert wrote: >> KO Myung-Hun wrote: >>> /* Redirection and wildcarding when done by the utility itself. >>> Generally a noop, but used in particular for native VMS. */ >>> #ifndef initialize_main >>> -# define initialize_main(ac

bug#19377: bug#19378: [PATCH 3/4] cat, chcon, chgrp, chmod, chown, cp, du, head: support wildcards on OS/2

2014-12-15 Thread Jim Meyering
On Mon, Dec 15, 2014 at 12:57 AM, Pádraig Brady wrote: > On 15/12/14 01:15, KO Myung-Hun wrote: >> >> >> Pádraig Brady wrote: >>> forcemerge 19378 19377 >>> stop >>> >>> On 14/12/14 03:47, KO Myung-Hun wrote: And ln,ls,mv,rm,tail. * src/cat.c (main): Expand wildcards on OS/2. *

bug#19377: bug#19376: [PATCH 4/4] build: use -pi.bak instead of -pi

2014-12-14 Thread Jim Meyering
On Sun, Dec 14, 2014 at 5:25 AM, Pádraig Brady wrote: > forcemerge 19376 19377 > stop > > On 14/12/14 03:47, KO Myung-Hun wrote: >> This fixes the following error. >> >> - >> Can't do inplace edit without backup. >> - >> >> * Makefile.am (dist-hook): Use -pi.bak instead of -pi. >> * bootst

bug#18621: [BUG] wc -c incorrectly counts bytes in /sys

2014-10-07 Thread Jim Meyering
On Tue, Oct 7, 2014 at 5:36 PM, Pádraig Brady wrote: > On 10/08/2014 12:51 AM, Paul Eggert wrote: >> Paul Eggert wrote: >> >>> The attached patch still needs a changelog entry and test cases. >> >> I wrote those up and pushed the attached patch; this should fix the bug so >> I'm closing the bug r

bug#18621: [BUG] wc -c incorrectly counts bytes in /sys

2014-10-03 Thread Jim Meyering
On Fri, Oct 3, 2014 at 9:48 AM, Pádraig Brady wrote: > On 10/03/2014 03:47 PM, George Shuklin wrote: ... > I'm not sure where the above code comes from, > by coreutils trunk has the same behavior with these files. > We could avoid it with the following patch. > Note in the case where "real" small

bug#18054: Problematic translation strings in coreutils 8.22

2014-07-19 Thread Jim Meyering
On Sat, Jul 19, 2014 at 8:45 AM, Bernhard Voelker wrote: > On 07/19/2014 04:57 PM, Paul Eggert wrote: >> From: Paul Eggert >> [...] >> Problem reported by Sebastian Rasmussen in: http://bugs.gnu.org/18054 > > This feels wrong. > As Padraig often said, we should encourage people to contribute > to

bug#17833: coreutils 8.22 df

2014-07-11 Thread Jim Meyering
On Thu, Jul 10, 2014 at 4:28 PM, Pádraig Brady wrote: > The attached should handle this by giving precedence > to displaying real device nodes. Thanks. That looks fine. I'd add an "s" to that NEWS entry: s/give/gives/ + df now give precedence to displaying real device nodes in the presence of

bug#7320: [PATCH] 'id' prints incorrectly groups for the session

2014-06-26 Thread Jim Meyering
On Thu, Jun 26, 2014 at 3:23 AM, Pádraig Brady wrote: > -g=$(id -u $NON_ROOT_USERNAME) || framework_failure_ > +u=$(id -u $NON_ROOT_USERNAME) || framework_failure_ > +g=u This will work better :-) g=$u

bug#17495: chgrp: mention of being a member of the target group

2014-06-19 Thread Jim Meyering
Looks fine. Two nits barely worth mentioning: one in the .texi file: s/group in/group of/ one in the log: s/\*man/* man/ Also, in the relative formality of documentation, it's slightly better to write "It is" than "It's"

bug#17590: [PATCH] build: libstdbuf.so: avoid new OS X link failure

2014-05-26 Thread Jim Meyering
On Mon, May 26, 2014 at 1:25 AM, Pádraig Brady wrote: > On 05/25/2014 11:19 PM, Jim Meyering wrote: >> On Sun, May 25, 2014 at 1:31 PM, Pádraig Brady wrote: >>> On 05/25/2014 08:48 PM, Jim Meyering wrote: >>>> Without the attached patch, I'd get this new link f

bug#17590: [PATCH] build: libstdbuf.so: avoid new OS X link failure

2014-05-25 Thread Jim Meyering
On Sun, May 25, 2014 at 1:31 PM, Pádraig Brady wrote: > On 05/25/2014 08:48 PM, Jim Meyering wrote: >> Without the attached patch, I'd get this new link failure on OS X: >> >> Undefined symbols for architecture x86_64: >> "_libintl_gettext"

bug#17590: [PATCH] build: libstdbuf.so: avoid new OS X link failure

2014-05-25 Thread Jim Meyering
Without the attached patch, I'd get this new link failure on OS X: Undefined symbols for architecture x86_64: "_libintl_gettext", referenced from: _apply_mode in src_libstdbuf_so-libstdbuf.o ld: symbol(s) not found for architecture x86_64 collect2: error: ld returned 1 exit status make[2]:

bug#17455: [PATCH] shred: fix overflow checking of command-line options

2014-05-10 Thread Jim Meyering
On Sat, May 10, 2014 at 11:42 AM, Paul Eggert wrote: > * src/shred.c (main): Limit -n (number of passes) value to > ULONG_MAX, not to UINT32_MAX, since the vars are unsigned long. > Limit the -s (file size) value to OFF_T_MAX. > --- > src/shred.c | 9 + > 1 file changed, 5 insertions(+),

bug#16171: ptx: heap buffer overrun, when run with two file arguments

2014-04-28 Thread Jim Meyering
On Mon, Apr 28, 2014 at 6:52 AM, Pádraig Brady wrote: ... >> I see it here too (as the only failure in make check with -fsanitize=address > > The attached should address this. Thanks for taking the time to address that. The patch looks fine, modulo what looks like an accidentally-added empty line

  1   2   3   4   5   6   7   8   9   10   >