bug#21876: Please list ACFS in the list of remote filesystems

2015-11-11 Thread Ondřej Vašík
Hi, as reported in https://bugzilla.redhat.com/show_bug.cgi?id=1280333 , Oracle ADVM/ACFS is not listed among the remote filesystems and in stat.c . Can you please add S_MAGIC_ACFS (0x61636673) to stat.c as a remote filesystem? Not sending as a patch, as this is quite simple change. Thanks in adva

bug#21369: Coreutils RHEL 6.7 runuser

2015-08-31 Thread Ondřej Vašík
Bob Proulx píše v Pá 28. 08. 2015 v 13:10 -0600: > tag 21369 + notabug moreinfo > thanks > billy_k_woo...@homedepot.com wrote: > > /sbin/runuser issue on RHEL 6.7 when executing `whoami` as tomcat. ... > For another you are reporting a problem about "Coreutils RHEL 6.7 > runuser" but runuser is not

[PATCH] md5sum: handle carriage returns at the eol in input sum files

2010-03-02 Thread Ondřej Vašík
.html , but I haven't found patch solving this issue in those reports. Attached patch should solve it and I don't see any negative side effects from it. Greetings, Ondřej Vašík From f5b34e9ff958ae8df8c7e0adfb8dd04ad95d3668 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Ond=C5=99ej=

Re: [PATCH] status=noinfo option for dd

2010-02-19 Thread Ondřej Vašík
IXLY_CORRECT but doing additionally this hack looks silly to me) Greetings, Ondřej Vašík signature.asc Description: Toto je digitálně podepsaná část zprávy

[PATCH] tests/cp/cp-a-selinux: skip the test if no loopdevices available

2010-02-01 Thread Ondřej Vašík
, Ondřej Vašík From 67bc8118e98f99f59d1f601d06c121f3ed2c4f58 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Ond=C5=99ej=20Va=C5=A1=C3=ADk?= Date: Mon, 1 Feb 2010 16:29:27 +0100 Subject: [PATCH] tests: cp-a-selinux :skip the test if no loopdevices available * tests/cp/cp-a-selinux: skip the

Re: date and printf commands

2010-01-07 Thread Ondřej Vašík
Hi, Eric Blake wrote: > According to David Venus on 12/23/2009 3:35 PM: > > 2) Be able to say things like "fist day of year" (20090101), "week" > > (20091220), "month" (20091201), etc. > > > > 3) Be able to say things like "last day of year" (20091231), "week" > > (20091226), "month" (20091231), e

Re: Build failures of coreutils-8.1 in Fedora build system "koji"

2009-11-24 Thread Ondřej Vašík
Hi, Ondřej Vašík wrote: > Hi, > I'm trying to package coreutils-8.1 for Fedora Rawhide, but few tests > are failing > ( http://koji.fedoraproject.org/koji/getfile?taskID=1819634&name=build.log ). > I removed all Fedora-only patches to prevent patch-related issues. Koji

Re: Build failures of coreutils-8.1 in Fedora build system "koji"

2009-11-23 Thread Ondřej Vašík
Hi Jim, Jim Meyering wrote: > Ondřej Vašík wrote: > > I'm trying to package coreutils-8.1 for Fedora Rawhide, but few tests > > are failing > > ( http://koji.fedoraproject.org/koji/getfile?taskID=1819634&name=build.log > > ). > > I removed all Fedora-on

Build failures of coreutils-8.1 in Fedora build system "koji"

2009-11-20 Thread Ondřej Vašík
Greetings, Ondřej Vašík signature.asc Description: Toto je digitálně podepsaná část zprávy

[PATCH]: chcon: no longer abort on SELinux disabled kernel

2009-10-05 Thread Ondřej Vašík
changed to not hardcode "runcon" program name. Greetings, Ondřej Vašík From 3dbd792b3e9379a4795d1becdc4252de236429bc Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Ond=C5=99ej=20Va=C5=A1=C3=ADk?= Date: Mon, 5 Oct 2009 09:20:48 +0200 Subject: [PATCH] chcon: no longer abort on SELinux disab

Re: [PATCH]: ls: do not show long iso time format for en_* locales

2009-09-26 Thread Ondřej Vašík
Jim Meyering wrote: > Here's an incomplete patch. > It needs a test and a NEWS entry. > Ondřej, can you adjust your test to work (or skip) > if there is no en* locale? Maybe something like that (attachment)? It's checking for existence of locale binary and en_US locale and performing the test only

Re: [PATCH]: ls: do not show long iso time format for en_* locales

2009-09-26 Thread Ondřej Vašík
Paul Eggert wrote: > Ondřej Vašík writes: > > > as reported in https://bugzilla.redhat.com/show_bug.cgi?id=525134 by > > Daniel Qarras, ls -l shows iso long format for en_* locales. > > I just now read that Bugzilla report, and the diagnosis and the > patch do not s

[PATCH]: ls: do not show long iso time format for en_* locales

2009-09-25 Thread Ondřej Vašík
(imho better than long iso style). Greetings, Ondřej Vašík From e82f581055af6eadcf3e99ff7aa3f5f3479c7c22 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Ond=C5=99ej=20Va=C5=A1=C3=ADk?= Date: Fri, 25 Sep 2009 15:20:47 +0200 Subject: [PATCH] ls: do not show long iso time format for en_* locales

Re: [PATCH] cp, mv: do preserve extended attributes even for read-only source files

2009-09-15 Thread Ondřej Vašík
Jim Meyering wrote: > Ondřej Vašík wrote: > > Pádraig Brady wrote: > >> Yes I agree that the change is required. > >> I've tweaked it so that the geteuid() syscall is only called > >> if readonly files. Also I removed the error message on chmod failure

Re: [PATCH] cp, mv: do preserve extended attributes even for read-only source files

2009-09-15 Thread Ondřej Vašík
Pádraig Brady wrote: > Yes I agree that the change is required. > I've tweaked it so that the geteuid() syscall is only called > if readonly files. Also I removed the error message on chmod failure > as the user will still get an error message _if_ the copy_xattr fails. > Also I ran it through inde

Re: [PATCH] cp, mv: do preserve extended attributes even for read-only source files

2009-09-14 Thread Ondřej Vašík
/html/bug-coreutils/2009-09/msg00166.html and it seems it is not a bug in libattr (just strange requirement by kernel), I modified the comment about workaround - as the culprit is probably in kernel. Greetings, Ondřej Vašík From 500acf63e78cc6bdb4fdd8b84c1f5e2305b96fb1 Mon Sep 17 00:00:0

Re: [PATCH] doc: du - clarify default blocksize in usage/manpage

2009-09-09 Thread Ondřej Vašík
ble and convert it internally to uppercased string - as those envvars are not program_name dependent. So I called emit_blocksize_note with constant string (uppercased). Additionally I factored out duplicities about SIZE's - to same function in system.h Greetings, Ondřej Vašík Fro

Re: [PATCH] doc: du - clarify default blocksize in usage/manpage

2009-09-09 Thread Ondřej Vašík
Eric Blake wrote: > According to Ondřej Vašík on 9/9/2009 2:19 AM: > > Hello, > > as requested via https://bugzilla.redhat.com/show_bug.cgi?id=511188 , it > > would be nice to clarify default blocksize used by du in manpage/--help > > output. Although I closed that b

[PATCH] doc: du - clarify default blocksize in usage/manpage

2009-09-09 Thread Ondřej Vašík
it breaks translation strings, I guess it would be better to postpone commit after 7.6 (if accepted). Greetings, Ondřej Vašík From f5f6875b2d8828218105b3601c80ebfdc7eeefb4 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Ond=C5=99ej=20Va=C5=A1=C3=ADk?= Date: Wed, 9 Sep 2009 10:00:32 +0200

Re: [PATCH] cp, mv: do preserve extended attributes even for read-only source files

2009-09-07 Thread Ondřej Vašík
Pádraig Brady wrote: > Ondřej Vašík wrote: > > Pádraig Brady wrote: > >> To minimize side affects perhaps we should only do the chmod(600) > >> if (geteuid () != 0 && !access (src_name, W_OK)) ? > > > > Good idea, it would reduce possibility of s

Re: [PATCH] cp, mv: do preserve extended attributes even for read-only source files

2009-09-07 Thread Ondřej Vašík
Pádraig Brady wrote: > Ondřej Vašík wrote: > > Ah, I knew I forgot to do something :). Thanks for spotting this. > > > > Restoring to dest_mode & ~omitted_permissions done in attached patch, > > dropped redirections from the test as well. Additionally - I modi

Re: [PATCH] cp, mv: do preserve extended attributes even for read-only source files

2009-09-07 Thread Ondřej Vašík
Hi, Jim Meyering wrote: > Pádraig Brady wrote: > > Ondřej Vašík wrote: > >> As reported in > >> http://lists.gnu.org/archive/html/bug-coreutils/2009-08/msg00342.html by > >> Ernest N. Mamikonyan, cp/mv fails to preserve extended attributes for > >>

[PATCH] cp,mv: do preserve extended attributes even for read-only source files

2009-09-03 Thread Ondřej Vašík
better one at the moment. Test included... Greetings, Ondřej Vašík From cae691907fe50e2ab05198a7c647fe4140e3669e Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Ond=C5=99ej=20Va=C5=A1=C3=ADk?= Date: Thu, 3 Sep 2009 16:10:21 +0200 Subject: [PATCH] cp,mv: do preserve extended attributes even for

Re: cp(1) extended attributes bug + [PATCH]: fix the leak in copy_reg()

2009-09-02 Thread Ondřej Vašík
Ernest N. Mamikonyan wrote: [returning mailing list to CC, please keep it there] > On Tue, 01 Sep 2009 02:16:28 -0400, Ondřej Vašík wrote: > > Ernest N. Mamikonyan wrote: > >> Cp(1) doesn't correctly copy extended attributes for read-only files: > >> > >&g

Re: cp(1) extended attributes bug

2009-08-31 Thread Ondřej Vašík
reservation is suppressed and not preserving extended attributes is not considered as error in that case. Greetings, Ondřej Vašík signature.asc Description: Toto je digitálně podepsaná část zprávy

Re: [PATCH] ls -i: print consistent inode numbers also for mount points

2009-08-31 Thread Ondřej Vašík
Pádraig Brady wrote: > So there was a lot more disk access with the new binary. > but the NEWS suggests that should only be the case for > "systems with dysfunctional readdir". > > What was your system? Quite ancient system... I checked this on my old Fedora Core 6... Anyway could check with some

Re: [PATCH] ls -i: print consistent inode numbers also for mount points

2009-08-31 Thread Ondřej Vašík
m5.631s user0m3.012s sys 0m4.815s new binary: real6m8.560s user0m3.947s sys 0m30.572s But correctness should be preferred as this is not so common usecase... > Review appreciated. Looks ok from my point of view. Greetings, Ondřej Vašík signature.asc Descriptio

Re: [PATCH] cp: ignore obscure failure to preserve symlink time stamps,

2009-08-24 Thread Ondřej Vašík
Jim Meyering wrote: > Kamil Dudka wrote: > > On Monday 24 of August 2009 10:46:26 Jim Meyering wrote: > >> Actually, the comment I added above has a typo. > >> s/ENOTSUP/ENOSYS/. > >> > >> The diagnostic reported corresponds to ENOSYS. > >> The adjusted patch is here: > >> > >> > >> http://www.redh

[PATCH]: remove one duplicity in copy.c caused by factorization

2009-07-08 Thread Ondřej Vašík
Hello, while making coreutils update for F-11, I spotted one duplicity in copy.c caused by http://git.savannah.gnu.org/cgit/coreutils.git/commit/?id=e0cf592f48b4e67dc31d0482ae4f4dbc820e883e factorization commit. Attached patch removes this duplicity. Greetings, Ondřej Vašík From

Re: su command failing on RHEL5

2009-06-12 Thread Ondřej Vašík
et us know the fix available or not. Next time it would be better to use RHEL product support or RedHat bugzilla. Please try to use it instead of upstream mailing list, if --session-command is not solving your issue. Greetings, Ondřej Vašík signature.asc Description: Toto j

Re: [PATCH] dd: do not unnecesarilly allocate memory for input block size, when not needed

2009-05-22 Thread Ondřej Vašík
Pádraig Brady wrote: > So that would not run skip(STDOUT_FILENO,...) if count==0. > Would this break existing scripts that for example used > this command to position a non seekable device? > > dd count=0 of=/dev/tape seek=1234 Thanks for objection, you are right, my patch seems to be not corre

[PATCH] dd: do not unnecesarilly allocate memory for input block size, when not needed

2009-05-22 Thread Ondřej Vašík
mentioning in NEWS is not required in that case... Greetings, Ondřej Vašík From 5c9811896936341f462f67fd192748cac2f49dbd Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Ond=C5=99ej=20Va=C5=A1=C3=ADk?= Date: Fri, 22 May 2009 09:47:34 +0200 Subject: [PATCH] dd: do not unnecesarilly allocate memory for

Re: [PATCH] mv: do not produce diagnostics for xattr/selinux preserving failures

2009-04-28 Thread Ondřej Vašík
Ondřej Vašík wrote: > Hello, > as requested via IRC, adding separate test cases for patches added > previously in that thread. It should check correct diagnostics for > SELinux context/xattrs on filesystem without xattr/SELinux > support(fat32). Sorry for added dosfstools dependenc

Re: [PATCH] mv: do not produce diagnostics for xattr/selinux preserving failures

2009-04-27 Thread Ondřej Vašík
Hello, as requested via IRC, adding separate test cases for patches added previously in that thread. It should check correct diagnostics for SELinux context/xattrs on filesystem without xattr/SELinux support(fat32). Greetings, Ondřej From e6d3f340ad40635425a63a2edceb7c4a833e048e Mon Sep

Re: Human readable sort

2009-04-27 Thread Ondřej Vašík
but is this intentional? Greetings, Ondřej Vašík signature.asc Description: Toto je digitálně podepsaná část zprávy ___ Bug-coreutils mailing list Bug-coreutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-coreutils

Re: [PATCH] mv: do not produce diagnostics for xattr/selinux preserving failures

2009-04-24 Thread Ondřej Vašík
Ondřej Vašík wrote: > Ondřej Vašík wrote: > It reminds me another issue - due to reduce_diagnostic, if you use cp -a > --preserve=xattr,context , failure diagnostic is reduced, but the > command itself fails. Additionally for cp and --require-preserve=context > and ENODATA/EN

Re: [PATCH] mv: do not produce diagnostics for xattr/selinux preserving failures

2009-04-24 Thread Ondřej Vašík
Hello, Ondřej Vašík wrote: > Jim Meyering píše v Pá 17. 04. 2009 v 13:54 +0200: > > Ondřej Vašík wrote: > > > as reported in rhbz #496142 by Eric Sandeen, mv produces a lot of > > > unwanted messages when moving files to filesystem without xattr support. > > >

Re: join utility segfults

2009-04-24 Thread Ondřej Vašík
Ondřej Vašík wrote: > Pádraig Brady wrote: > > Roman Kirillov wrote: > > > [kiril...@chiark py-src]$ join s1.txt s2.txt > > > Segmentation fault > > > files: http://sigizmund.info/upload/s12.tgz (28 mb) > > > > This issue seems related to the i18

Re: join utility segfults

2009-04-23 Thread Ondřej Vašík
-8:~$ join s1.txt s2.txt > /dev/null > Segmentation fault (core dumped) Just would like to add that it's already fixed in Fedora rawhide package, so I'll fix it in next Fedora coreutils update for F-9/F-10. In F-8 not, it's alrea

Re: [PATCH] mv: do not produce diagnostics for xattr/selinux preserving failures

2009-04-17 Thread Ondřej Vašík
Jim Meyering píše v Pá 17. 04. 2009 v 13:54 +0200: > Ondřej Vašík wrote: > > as reported in rhbz #496142 by Eric Sandeen, mv produces a lot of > > unwanted messages when moving files to filesystem without xattr support. > > I guess mv selinux/xattr diagnostic error messages

[PATCH] mv: do not produce diagnostics for xattr/selinux preserving failures

2009-04-17 Thread Ondřej Vašík
Hello, as reported in rhbz #496142 by Eric Sandeen, mv produces a lot of unwanted messages when moving files to filesystem without xattr support. I guess mv selinux/xattr diagnostic error messages should be reduced as is done for cp -a, attached patch should do that. Greetings, Ondřej

Re: ls -v is still inconsistent

2009-03-25 Thread Ondřej Vašík
Jim Meyering wrote: > Pushed. > > http://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=1721cf06d9 I guess info doc about suffix regex should be updated too... Greetings, Ondrej From 88ebd00c46668f2b677c8da9a7e40584d5b97d9b Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Ond=C5=99ej=20Va

Re: [PATCH]: cp: make -a option preserve SELinux context and xattrs with reduced diagnostics

2009-03-11 Thread Ondřej Vašík
Hello, Jim Meyering wrote: > Ondřej Vašík wrote: > > Jim Meyering wrote: > >> Ondřej Vašík wrote: > >> > What about to split that into two patches? One for SELinux changes and > >> > one for xattr changes (commited after 7.1) - to make it more safe -

Re: [PATCH]: cp: make -a option preserve SELinux context and xattrs with reduced diagnostics

2009-02-17 Thread Ondřej Vašík
Jim Meyering wrote: > Ondřej Vašík wrote: > > What about to split that into two patches? One for SELinux changes and > > one for xattr changes (commited after 7.1) - to make it more safe - and > > to give other distros more time to fix the leak... > > That sounds even

Re: [PATCH]: cp: make -a option preserve SELinux context and xattrs with reduced diagnostics

2009-02-17 Thread Ondřej Vašík
Jim Meyering wrote: > When will the libattr fix be in F10? Upstream report: http://oss.sgi.com/archives/xfs/2009-02/msg00331.html Talked with Fedora attr maintainer and he will do an update for F-10 and Rawhide in day or two - upon the upstream reaction. So it should be in F-10 early next week.

[PATCH]: Invalid longoption for -v in nl usage

2009-02-17 Thread Ondřej Vašík
Hello, as reported in rhbz #485712 , nl incorrectly states that long format for -v is --first-page. Info documentation is correct and informs about --starting-line-number as correct long option for -v. I guess best way is to fix usage (and to not add --first-page option) as afaik nobody complained

Re: [PATCH]: cp: make -a option preserve SELinux context and xattrs with reduced diagnostics

2009-02-16 Thread Ondřej Vašík
Jim Meyering wrote: > Unfortunately, with this patch, "make check" fails the cp/link-heap test. > Investigating why, I discovered that it introduces a huge leak into > cp -a, at least on F10. 80MB worth in this case. > > I'll let you investigate that one ;-) Leak is in libattr - added by 2.4.43

[PATCH]: cp: make -a option preserve SELinux context and xattrs with reduced diagnostics

2009-02-09 Thread Ondřej Vašík
tr/SELinux context is not preserved NOTE: Added documentation of --preserve=context, description of current behaviour to cp --preserve=all and cp -a documentation. Added tests to ensure that cp -a actually works with SELinux (until now it was checking just failures. Greetings,

Re: date --date "4:59:54 1 hour 53 min 46 sec ago"

2009-01-29 Thread Ondřej Vašík
Eric Blake wrote: > Bauke Jan Douma xs4all.nl> writes: > > > > ~ $ date --date "4:59:54 1 hour 53 min 46 sec ago" > > > Wed Jan 28 06:52:08 CST 2009 > I've verified that the parse is unchanged between 6.10 and now (7.0+). > It's got to be one of these gnulib patches: > git log 30ffdfc..81e61

[PATCH]: chmod, chown, chgrp: Reduce verbosity of silent mode

2008-11-27 Thread Ondřej Vašík
conditional). Greetings, Ondřej Vašík From 18b8f5bf5c18115d0546e42951dc951da58a549c Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Ond=C5=99ej=20Va=C5=A1=C3=ADk?= <[EMAIL PROTECTED]> Date: Thu, 27 Nov 2008 15:04:10 +0100 Subject: [PATCH] chmod, chown, chgrp: Reduce verbosity of silent mode * c

[PATCH]: typo in last units factorization patch

2008-11-26 Thread Ondřej Vašík
Hi Jim, I spotted typo in your last factorization patch. Patch to fix that attached, it also removes runcon/chcon item from TODO. Ondřej From 26563a7e759b5f9c2515d06b1efe7d1ccc2ca0ca Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Ond=C5=99ej=20Va=C5=A1=C3=ADk?= <[EMAIL PROTECTED]> Date: Wed, 26 Nov 200

Re: [PATCH]: ls: add --user-format option for user defined format

2008-11-20 Thread Ondřej Vašík
Jim Meyering wrote: > - is it worthwhile to add a --printf option to ls? > I don't like the --user-format name) You know my opinion ... I guess it is worthwhile, as the consumer of ls output is generally human and human wishes do differ. I'm ok with --printf option, you are right - it wo

Re: [PATCH]: chmod - do inform about using different mode than requested with SGID/SUID/sticky bits without permissions to change them

2008-11-20 Thread Ondřej Vašík
Andreas Schwab wrote: > Eric Blake <[EMAIL PROTECTED]> writes: > > > Would a double --verbose make sense? > > --verbose=2 Rather than some level-numbers I do prefer --verbose and --verbose=high ... Ondřej signature.asc Description: Toto je digitálně podepsaná část zprávy ___

Re: [PATCH]: chmod - do inform about using different mode than requested with SGID/SUID/sticky bits without permissions to change them

2008-11-20 Thread Ondřej Vašík
Jim Meyering wrote: > Ondřej Vašík <[EMAIL PROTECTED]> wrote: > > Throwing out "--changes" should be ok, if user wants to be informed, he > > can parse verbose output easily and common case is to use it without > > verbose mode at all. Anyway --verbose outp

Re: [PATCH]: chmod - do inform about using different mode than requested with SGID/SUID/sticky bits without permissions to change them

2008-11-20 Thread Ondřej Vašík
Jim Meyering wrote: > Ondřej Vašík <[EMAIL PROTECTED]> wrote: > > as reported in > > https://bugs.launchpad.net/ubuntu/+source/coreutils/+bug/187315 by Aaron > > Toponce , chmod could display confusing messages when used for > > SGID/SUID/sticky bits without permis

Re: [PATCH]: ls: add --user-format option for user defined format

2008-11-20 Thread Ondřej Vašík
Pádraig Brady wrote: > Ondřej Vašík wrote: > > Let's do some summary, feel free to add/comment items if you have > > something not mentioned here: > > > > What patched ls --user-format can and upstream find -printf not: > > 1) colored files by LS_COLORS or a

Re: [PATCH]: ls: add --user-format option for user defined format

2008-11-10 Thread Ondřej Vašík
f possible format options. This patch covers all the ls functionality (if not, please let me know what is missing), has minimal impact on the rest of code and it is documented. Therefore please consider that long option for ls again. Greetings, Ondřej Vašík signature.asc Description: Toto je digitálně podepsaná část zprávy ___ Bug-coreutils mailing list Bug-coreutils@gnu.org http://lists.gnu.org/mailman/listinfo/bug-coreutils

Re: [Bug 294348] Re: ubuntu directing users to coreutils mailing list for general problems

2008-11-10 Thread Ondřej Vašík
such change should not break anything ... In report bugs section will be something like "Report ginstall bugs to " which could be more clear for everyone ("ginstall" word is simply not "install" word and could not cause confusion). Greetings, Ondřej Vaš

Re: [PATCH]: ls: add --user-format option for user defined format

2008-11-04 Thread Ondřej Vašík
Pádraig Brady wrote: > Thanks for doing that. > However I thought that item had been removed from the TODO: > http://lists.gnu.org/archive/html/bug-coreutils/2008-02/msg00115.html > This is a large patch to do essentially what `find -printf` already does. Sorry, haven't seen that thread before. I

Re: [PATCH]: chmod - do inform about using different mode than requested with SGID/SUID/sticky bits without permissions to change them

2008-10-25 Thread Ondřej Vašík
Hello, thanks for review and objections. Paul Eggert wrote: > Ondřej Vašík <[EMAIL PROTECTED]> writes: > > > - bool changed = (chmod_succeeded > > - && mode_changed (file, old_mode, new_mode)); > > + bool mode_change =

[PATCH]: chmod - do inform about using different mode than requested with SGID/SUID/sticky bits without permissions to change them

2008-10-24 Thread Ondřej Vašík
e by chmod command. Greetings, Ondřej Vašík From 4eaf35f250ab6eec036b7ab21a482a76289f8303 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Ond=C5=99ej=20Va=C5=A1=C3=ADk?= <[EMAIL PROTECTED]> Date: Fri, 24 Oct 2008 17:24:09 +0200 Subject: [PATCH] chmod: inform in verbose if used mode for chmod w

[PATCH] : ls: clarify documentation of exit statuses

2008-10-09 Thread Ondřej Vašík
Hello, as reported in rh bz#446294 , ls is not very clear with it's exit status documentation. This patch should clarify it a bit. Greetings, Ondřej Vašík From a3ef5a58f396b53287d7870d2cf35198789240cf Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Ond=C5=99ej=20Va=C5=A1=C3=ADk?= &l

[PATCH]: cp '-a' should try to preserve SELinux context, SELinux context cp documentation adjustments

2008-10-07 Thread Ondřej Vašík
it should try) SELinux context. Following changes were done to make documentation more precise and preserve=context and preserve=all behaviour after failure SELinux context preserving is documented by that patch as well. Greetings, Ondřej Vašík From

Re: [PATCH]: Basic info documentation for SELinux context related commands runcon and chcon

2008-10-07 Thread Ondřej Vašík
Hi, Jim Meyering wrote: > Ondřej Vašík <[EMAIL PROTECTED]> wrote: > > as those commands were not documented in info documentation, I wrote > > basic info documentation for runcon and chcon command (and related > > SELinux context menu section). It is completely based

[PATCH]: Basic info documentation for SELinux context related commands runcon and chcon

2008-10-06 Thread Ondřej Vašík
attachement. Greetings, Ondřej Vašík From 0b46a52b8f94fcbf145e0def84174cadd06bc4d2 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Ond=C5=99ej=20Va=C5=A1=C3=ADk?= <[EMAIL PROTECTED]> Date: Mon, 6 Oct 2008 14:18:53 +0200 Subject: [PATCH] Coreutils.texi: Document runcon and chcon in SELinux context s

[PATCH]: Invalid nonimplemented option in chcon

2008-10-06 Thread Ondřej Vašík
Hello, as reported in RedHat bugzilla #463883, chcon option -c is described in help, but not implemented. After short talk with Jim via IRC decision was to remove this option and related things from chcon source code completetely. It is done in attached patch. Greetings, Ondřej Vašík

Re: Issue with ls -v / sort -V and strverscmp() usage

2008-09-03 Thread Ondřej Vašík
Bruno Haible wrote: > Ondřej Vašík wrote: > > 3) to use/create different function for handling version sort (like > > rpmvercmp in recommended in glibc strverscmp() bugzilla) > > Does rpmvercmp have the above property? Similar. It separates name, epoch, version, release

Issue with ls -v / sort -V and strverscmp() usage

2008-09-03 Thread Ondřej Vašík
Hello, as reported in RH bugzilla #253817 (https://bugzilla.redhat.com/show_bug.cgi?id=253817), there is an issue with ls -v (and there will be same issue with sort -V soon). Problem is with sorting files with extensions or dist-tags (like .tar.gz) because .tar.gz is more than .1.tar.gz. Therefore

Re: [PATCH]: Fix for several getdate.y issues (amended patch #3)

2008-07-25 Thread Ondřej Vašík
12 deletions(-) diff --git a/ChangeLog b/ChangeLog index 6c48308..b19680f 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2008-07-25 Ondřej Vašík <[EMAIL PROTECTED]> + + getdate.y: Allow only timezone range specified by POSIX + * lib/getdate.y (time_zone_hhmm): Allow only TZ in the

Re: [PATCH]: Fix for several getdate.y issues (amended patch #3)

2008-07-21 Thread Ondřej Vašík
Hello, Jim Meyering wrote: > I'm a little leery of this patch, because it makes interpretation > of UTC+dd and UTC-dd dependent on the value of dd. For dd <= 14, dd > represents hours. Otherwise, it represents minutes. That would have > to be documented, but seems odd enough that my reflex is to

Re: [PATCH]: Fix for several getdate.y issues (amended patch #3)

2008-07-04 Thread Ondřej Vašík
5f522..076d70e 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,12 @@ +2008-07-04 Ondřej Vašík <[EMAIL PROTECTED]> + + getdate.y: Allow only timezone range specified by POSIX + * lib/getdate.y (time_zone_hhmm): Allow only TZ in the range + -24 to +24 hours, consider first two digits bet

[PATCH]: who -r empty last runlevel + missing informations about some who options in coreutils.texi

2008-07-02 Thread Ondřej Vašík
nlevel in who -r as 'S'. Signed-off-by: Ondřej Vašík <[EMAIL PROTECTED]> --- src/who.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/who.c b/src/who.c index 5529618..952023a 100644 --- a/src/who.c +++ b/src/who.c @@ -508,7 +508,7 @@ print_runlevel (con

Re: [PATCH]: Fix for several getdate.y issues

2008-07-01 Thread Ondřej Vašík
Ondřej Vašík wrote: > Jim Meyering wrote: > > Would you mind separating that into a few separate change sets? > ... > I hope I will do the rest of patches ( 1 or 2 more > are still necessary to cover all the issues I found). Here is the second set of patches. First one (ge

Re: [PATCH]: Fix for several getdate.y issues

2008-06-27 Thread Ondřej Vašík
Do not ignore specified time zone when relative offset for days/months/years is specified. Signed-off-by: Ondřej Vašík <[EMAIL PROTECTED]> --- lib/getdate.y | 40 1 files changed, 20 insertions(+), 20 deletions(-) diff --git a/lib/getdate.y b/lib

[PATCH]: Fix for several getdate.y issues

2008-06-27 Thread Ondřej Vašík
3=ADk?= <[EMAIL PROTECTED]> Date: Fri, 27 Jun 2008 12:31:10 +0200 Subject: [PATCH] * tests/misc/date: add tests for new fixes of date format Signed-off-by: Ondřej Vašík <[EMAIL PROTECTED]> --- tests/misc/date |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/

[PATCH]: Replace echo AUTHORS FIXME unknown by bash builtin echo authors

2008-06-23 Thread Ondřej Vašík
echo.c: Use bash builtin echo authors instead of FIXME unknown Signed-off-by: Ondřej Vašík <[EMAIL PROTECTED]> --- AUTHORS|2 +- src/echo.c |4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/AUTHORS b/AUTHORS index 404cf70..666edc1 100644 --- a/AUTHORS +++ b

Re: [PATCH] id should not show selinux context when user is specified

2008-04-23 Thread Ondřej Vašík
ich checks if SELinux is displayed where it should be. Problem reported by Ronny Buchmann in http://bugzilla.redhat.com/443485. Signed-off-by: Ondřej Vašík <[EMAIL PROTECTED]> --- NEWS |4 src/id.c | 10 +- tests/misc/Make

[PATCH] id should not show selinux context when user is specified

2008-04-22 Thread Ondřej Vašík
nly when used without specified user Signed-off-by: Ondřej Vašík <[EMAIL PROTECTED]> --- NEWS |4 src/id.c |7 +-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 04893c6..ef3feda 100644 --- a/NEWS +++ b/NEWS @@ -75,6 +

Re: [PATCH] Fix bug when attempting to echo special sequences literally. -- [RESUBMISSION]

2008-03-13 Thread Ondřej Vašík
Why to use it only for fist option? I would prefer to add that as option separator (like in attached patch). I had that issue report against Red Hat Enterprise Linux (https://bugzilla.redhat.com/show_bug.cgi?id=431005) and submitted following patch to Fedora Rawhide branch ~1 month ago. Was going t

Re: [PATCH] mkdir/split: send --verbose output to stdout + [PATCH]: same for rmdir/install

2008-03-10 Thread Ondřej Vašík
Jim Meyering wrote: > ... > So you'll have to make the three .c files include the new .h, > and you'll have to adjust src/Makefile.am to link the new .c > file to each of those three programs. > ... > Then, create the file "patch" like this: > > git format-patch --stdout --signoff HEAD~1 > pat

Re: [PATCH] mkdir/split: send --verbose output to stdout + [PATCH]: same for rmdir/install

2008-03-03 Thread Ondřej Vašík
Hello, I think there are still some things to be consolidated. The same with verbose output should be done in the case of install(when making dir) and in the case of rmdir. In the case of shred should be mentioned in info that verbose output is to standard error. Those things done in attached patch

Re: date issues with YYYYMMDD/YYMMDD date format and relative offset

2007-11-19 Thread Ondřej Vašík
Hi Jim, Jim Meyering wrote: > However, there's a simple work-around: simply to drop the "+", e.g., > > $ date -d '20050101 1 day' > Sun Jan 2 00:00:00 CST 2005 Yes, I know about that work-around, you could use unsigned offset/ unsigned offset ago as work-around, but the behaviour still diff

date issues with YYYYMMDD/YYMMDD date format and relative offset

2007-11-16 Thread Ondřej Vašík
Hello, date command has some troubles with MMDD date format. When you try 'date -d "20050101 +1 day"' (or whatever relative offset), you will get invalid date because of conflicts in translation tables. Nearly same command date -d "20050101 UTC +1 day" is working correctly with current versio