Eric Blake wrote:
Jim Meyering jim at meyering.net writes:
Once most of your infrastructure improvements are in gnulib,
would you please write a brief summary to go in NEWS
for the upcoming coreutils-7.7 release?
How about the following? I still want to get my symlink module in first, but
The attached patch removes the inconsistent use of bitwise
operators on boolean values.
As well as being distracting, bitwise operators are
not short circuiting and brittle with C89 where
bool can be an int, i.e. 1.
cheers,
Pádraig.
From f83dd9eb575685c7e2bbdc62a868fb28a15a82c6 Mon Sep 17
Pádraig Brady wrote:
The attached patch removes the inconsistent use of bitwise
operators on boolean values.
As well as being distracting, bitwise operators are
not short circuiting and brittle with C89 where
bool can be an int, i.e. 1.
...
Subject: [PATCH] maint: Use logical rather than
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Pádraig Brady on 9/23/2009 5:58 AM:
Another ununused parameter warning patch attached
+static void mpz_init_set_ui (mpz_t z, unsigned long i) { z[0] = i; (void) i;
}
Doesn't the assignment count as a use of i, so that the (void) i;
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Jim Meyering on 9/23/2009 1:00 AM:
Subject: [PATCH 2/2] maint: summarize gnulib changes
Thanks for doing all that.
I've pushed an initial gnulib-submodule-update patch
and then your first patch (to fix the then-failing readlink
Eric Blake wrote:
According to Pádraig Brady on 9/23/2009 5:58 AM:
Another ununused parameter warning patch attached
+static void mpz_init_set_ui (mpz_t z, unsigned long i) { z[0] = i; (void)
i; }
Doesn't the assignment count as a use of i, so that the (void) i; is
redundant?
Oops yes.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Eric Blake on 9/18/2009 5:35 AM:
On one hand:
ln -s dangling link = 0
stat dangling/ = ENOENT
stat link/ = ENOENT
mkdir link/ = 0
Creating a directory through a slashed symlink works on Solaris 10, and is
required by POSIX, but it
Eric Blake wrote:
According to Jim Meyering on 9/23/2009 1:00 AM:
Subject: [PATCH 2/2] maint: summarize gnulib changes
Thanks for doing all that.
I've pushed an initial gnulib-submodule-update patch
and then your first patch (to fix the then-failing readlink test),
but without the
I'd like to make a test release soon. Maybe as soon as Friday.
If you have something that you'd like included, please speak up.
NEWS is already pretty long:
** Bug fixes
cp --preserve=xattr and --archive now preserve extended attributes even
when the source file doesn't have write access.
Eric Blake wrote:
According to Eric Blake on 9/18/2009 5:35 AM:
On one hand:
ln -s dangling link = 0
stat dangling/ = ENOENT
stat link/ = ENOENT
mkdir link/ = 0
Creating a directory through a slashed symlink works on Solaris 10, and is
required by POSIX, but it fails on Linux with
Jim Meyering jim at meyering.net writes:
I'd like to make a test release soon. Maybe as soon as Friday.
If you have something that you'd like included, please speak up.
I'm nearly ready to post support for ln -P/-L, thanks to the pending addition
of gnulib linkat(). That would be nice to
Eric Blake wrote:
Jim Meyering jim at meyering.net writes:
I'd like to make a test release soon. Maybe as soon as Friday.
If you have something that you'd like included, please speak up.
I'm nearly ready to post support for ln -P/-L, thanks to the pending addition
of gnulib linkat(). That
Pádraig Brady p...@draigbrady.com writes:
As well as being distracting, bitwise operators are
not short circuiting and brittle with C89 where
bool can be an int, i.e. 1.
I don't find them distracting; on the contrary, I find them a helpful
reminder that the expressions are boolean (in the
On Tue, 22 Sep 2009 22:16 +0200, Jim Meyering j...@meyering.net wrote:
+Using color to distinguish file types is disabled both by default and\n\
+with --color=never.
Okay with me. It forces is disabled to describe a state also for the option.
(In some translations this won't work, though. But
Benno Schulenberg wrote:
On Tue, 22 Sep 2009 22:16 +0200, Jim Meyering j...@meyering.net wrote:
+Using color to distinguish file types is disabled both by default and\n\
+with --color=never.
Okay with me. It forces is disabled to describe a state also for the
option.
(In some translations
Paul Eggert wrote:
Pádraig Brady p...@draigbrady.com writes:
As well as being distracting, bitwise operators are
not short circuiting and brittle with C89 where
bool can be an int, i.e. 1.
I don't find them distracting; on the contrary, I find them a helpful
reminder that the expressions
Paul Eggert wrote:
Pádraig Brady p...@draigbrady.com writes:
As well as being distracting, bitwise operators are
not short circuiting and brittle with C89 where
bool can be an int, i.e. 1.
I don't find them distracting; on the contrary, I find them a helpful
reminder that the
Jim Meyering wrote:
Considering your arguments, I wonder if it's worthwhile to see
how many of those changes are in parts of the code where decreased
code size and fewer branches might make a difference. Or go one
better...
Here's list of size changes for reference:
$ find -type f -perm
Paul Eggert eggert at CS.UCLA.EDU writes:
Furthermore, bitwise operators often generate shorter and faster code,
particularly on modern processors where conditional branches are far
more expensive than logical operations. For example, consider these
functions:
bool F (bool a, bool b, bool
Jim Meyering jim at meyering.net writes:
OK, I've pushed the NEWS change (including the typo fix
canonicalize=readlink), then a separate commit to resync gnulib.
Thanks.
Here's another patch related to gnulib churn. I am _NOT_ planning on
attempting to port coreutils to mingw, so the
Eric Blake e...@byu.net writes:
bool F (bool a, bool b, bool c, bool d) { return a b c d; }
bool G (bool a, bool b, bool c, bool d) { return a b c d; }
the compiler should be generating identical code for either choice
of operator.
Not necessarily, because it could be that the
Pádraig Brady p...@draigbrady.com writes:
I did also check the speed with a test program
(attached) which showed the logical test was a bit faster on my pentium-m.
Note I compiled without optimization
I would expect optimization would be crucial: I got the 60% increase
in number of
22 matches
Mail list logo
